Tim Allison
af51ea4c10
bug 50955 -- word 6.0 charset fix
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790061 13f79535-47bb-0310-9956-ffa450edef68
2017-04-04 02:06:46 +00:00
Javen O'Neal
28999738a9
Convert all *.java files to use native end of line character(s)
...
$ dos2unix `find -name *.java`
$ svn propset svn:eol-style native `find -name *.java`
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782114 13f79535-47bb-0310-9956-ffa450edef68
2017-02-08 07:47:30 +00:00
Tim Allison
13499b6444
Bug 60574 prevent rare NPE in ListTables
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1778320 13f79535-47bb-0310-9956-ffa450edef68
2017-01-11 16:01:32 +00:00
Andreas Beeker
8973c2fe07
SonarQube fixes
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777252 13f79535-47bb-0310-9956-ffa450edef68
2017-01-04 01:06:30 +00:00
Dominik Stadler
b573615cd0
bug 60526: Make loggers final and make throttled log actually work
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776555 13f79535-47bb-0310-9956-ffa450edef68
2016-12-30 13:09:28 +00:00
kiwiwings
0ff9cbb0f9
#60331 - Remove deprecated classes (POI 3.16)
...
- remove orphaned classes immediately, which are quite likely not used anymore
- deprecated the rest
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1774842 13f79535-47bb-0310-9956-ffa450edef68
2016-12-18 03:26:13 +00:00
Dominik Stadler
230453d76e
Adjust toString() of ExternalNameRecord
...
Fix some IntelliJ warnings
Reformat TextPieceTable
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1773776 13f79535-47bb-0310-9956-ffa450edef68
2016-12-12 11:41:07 +00:00
Dominik Stadler
90ce8cb096
Remove unnecessary cast and reformat some code a bit
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771247 13f79535-47bb-0310-9956-ffa450edef68
2016-11-25 05:34:58 +00:00
Javen O'Neal
518253650a
remove Internal UnhandledDataStructure.copyOfRange because function is available in JDK 1.6+ and we no longer support JDK 1.5
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751984 13f79535-47bb-0310-9956-ffa450edef68
2016-07-09 06:38:16 +00:00
Javen O'Neal
fba65665fb
reorganize imports (remove unused imports, sort alphabetically)
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751244 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 10:38:25 +00:00
Javen O'Neal
ac84cdb773
findbugs: remove implements Cloneable declaration from classes that don't implement a clone method
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751035 13f79535-47bb-0310-9956-ffa450edef68
2016-07-02 08:30:34 +00:00
Andreas Beeker
1b086d3a35
forbidden-apis-fix
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1750868 13f79535-47bb-0310-9956-ffa450edef68
2016-06-30 23:03:17 +00:00
Nick Burch
0c9e0cb608
#59739 When testing for a valid NFIB in a FileInformationBlock, accept common "nearby" values as found from CommonCrawl
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1750866 13f79535-47bb-0310-9956-ffa450edef68
2016-06-30 21:20:23 +00:00
Dominik Stadler
6b1caa4e2c
Bug 59739: For now fix the regression in FileInformationBlock which was introduced after 3.15-beta1 so that the documents can be loaded again pending a full fix as discussed in the bug.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1750864 13f79535-47bb-0310-9956-ffa450edef68
2016-06-30 21:06:04 +00:00
Andreas Beeker
85f22291be
Sonar fixes
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1750171 13f79535-47bb-0310-9956-ffa450edef68
2016-06-24 22:04:12 +00:00
Javen O'Neal
bb43d1eb3c
remove deprecated o.a.p.hwpf.usermodel.Shapes (replaced by OfficeDrawing in POI 3.8 beta 4)
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748788 13f79535-47bb-0310-9956-ffa450edef68
2016-06-17 01:34:00 +00:00
Javen O'Neal
aeddbc05e4
whitespace (2 spaces or tabs to 4 spaces)
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748489 13f79535-47bb-0310-9956-ffa450edef68
2016-06-15 03:55:45 +00:00
Javen O'Neal
f2390589dc
bug 59170: remove deprecated writeTo method in @Internal PAPBinTable
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748488 13f79535-47bb-0310-9956-ffa450edef68
2016-06-15 03:42:18 +00:00
Javen O'Neal
2b7649cbd6
whitespace (2 spaces to 4 spaces)
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748487 13f79535-47bb-0310-9956-ffa450edef68
2016-06-15 03:34:56 +00:00
Javen O'Neal
46a36df416
remove deprecated constructor for @Internal PAPBinTable
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748486 13f79535-47bb-0310-9956-ffa450edef68
2016-06-15 03:31:41 +00:00
Javen O'Neal
e355d20cfa
bug 59170: remove deprecated methods
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748483 13f79535-47bb-0310-9956-ffa450edef68
2016-06-15 03:26:58 +00:00
Andreas Beeker
e58f6f3fb0
findbugs fixes
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744802 13f79535-47bb-0310-9956-ffa450edef68
2016-05-20 22:05:00 +00:00
Javen O'Neal
a4af4fc6c3
fix several findbugs SF_SWITCH_NO_DEFAULT warnings
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738782 13f79535-47bb-0310-9956-ffa450edef68
2016-04-12 12:03:24 +00:00
Dominik Stadler
5dc647da61
Bug 56911: Fix IndexOutOfBoundsException in PlfLfo.add() and add minimal test, however these classes look quite untested and thus require more test-coverage to make them more robust
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737947 13f79535-47bb-0310-9956-ffa450edef68
2016-04-06 09:00:05 +00:00
Andreas Beeker
ceda10fa32
sonar fixes
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736932 13f79535-47bb-0310-9956-ffa450edef68
2016-03-28 22:46:53 +00:00
Andreas Beeker
197aef5420
findbugs fixes - SE_COMPARATOR_SHOULD_BE_SERIALIZABLE
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736114 13f79535-47bb-0310-9956-ffa450edef68
2016-03-21 23:42:56 +00:00
Dominik Stadler
f1a476d83a
Fix bug 56549: correctly calculate char index ranges for HWPF in the TextPieceTable
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734718 13f79535-47bb-0310-9956-ffa450edef68
2016-03-12 16:56:26 +00:00
Andreas Beeker
0776e32108
sonar fixes
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734641 13f79535-47bb-0310-9956-ffa450edef68
2016-03-11 23:14:09 +00:00
Tim Allison
827c3f562b
Bug 56880 - switch exception to logged warning that non-extended pascal strings are not supported. Full fix would add parsing for these strings.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1728547 13f79535-47bb-0310-9956-ffa450edef68
2016-02-04 19:54:15 +00:00
Andreas Beeker
8d033e235c
replace Throwable.printStackTrace() with POILogger calls - Todo: other printStrackTrace(...) calls
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1723899 13f79535-47bb-0310-9956-ffa450edef68
2016-01-10 02:20:35 +00:00
Dominik Stadler
387fb86d68
Eclipse warnings, code formatting, javadoc, ...
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717972 13f79535-47bb-0310-9956-ffa450edef68
2015-12-04 14:38:14 +00:00
Andreas Beeker
4ccadf7315
fix unnecessary cast warnings
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715626 13f79535-47bb-0310-9956-ffa450edef68
2015-11-22 12:30:42 +00:00
Dominik Stadler
4b487fcc10
Eclipse warnings
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706750 13f79535-47bb-0310-9956-ffa450edef68
2015-10-05 06:41:48 +00:00
Andreas Beeker
eee32c0480
fixed sonar issues and eclipse warnings
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706742 13f79535-47bb-0310-9956-ffa450edef68
2015-10-05 00:28:54 +00:00
Andreas Beeker
1b2b506edb
Sonar fixes - add cloneable interface to classes with clone()
...
Sonar fixes - remove pubic/static/final modifier from interfaces
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1705789 13f79535-47bb-0310-9956-ffa450edef68
2015-09-28 23:16:58 +00:00
Andreas Beeker
6f7f16853e
Removed HDF API
...
Sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1705779 13f79535-47bb-0310-9956-ffa450edef68
2015-09-28 21:26:06 +00:00
Andreas Beeker
aaafb0270d
Bug 58326 - Forbidden APIs patches - first set of changes for locale and timezone settings
...
also includes fixes for
- name shadowing
- unused deprecated method "getClipRect" in classes extending Graphics2d
- HexDump - replaced intermediate String.format calls with custom padding
- convert testcases to junit4
- closing resources
also tested with an arbitary timezone (PST) and locale (ru)
supresses forbidden apis check for
- LocaleUtil (the only place where Locale.getDefault() and TimeZone.getDefault() should be called)
- Classes using FontMetrics - without the actual text it's difficult to return something sane
Some usage of UTC and Locale.ROOT might be still wrong, e.g. in MapiMessage we don't access the
extended mapi properties, which might contain the timezone
DataFormatter has now a Observable property which need to be observed when custom formats are used
and the Locale changes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701688 13f79535-47bb-0310-9956-ffa450edef68
2015-09-07 20:19:50 +00:00
Andreas Beeker
dd5e6e61c4
FindBugs - DMI_INVOKING_TOSTRING_ON_ARRAY
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696043 13f79535-47bb-0310-9956-ffa450edef68
2015-08-15 12:20:52 +00:00
Andreas Beeker
05c92b7a19
FindBugs - DLS_DEAD_LOCAL_STORE
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696038 13f79535-47bb-0310-9956-ffa450edef68
2015-08-15 11:57:57 +00:00
Andreas Beeker
c4e543d4fa
Findbugs fixes for DMI_INVOKING_TOSTRING_ON_ARRAY
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694124 13f79535-47bb-0310-9956-ffa450edef68
2015-08-04 23:11:50 +00:00
Tim Allison
13dc67c73a
POI-56998 add some getters to help with list numbering in hwpf
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1676561 13f79535-47bb-0310-9956-ffa450edef68
2015-04-28 15:17:51 +00:00
Dominik Stadler
acfc276396
Fix usage of Generics in some classes
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1674964 13f79535-47bb-0310-9956-ffa450edef68
2015-04-20 19:15:21 +00:00
Dominik Stadler
b0f0aca92a
Eclipse warnings, Generics, unused members in some exapmles and scratchpad classes.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1668480 13f79535-47bb-0310-9956-ffa450edef68
2015-03-22 21:45:03 +00:00
Andreas Beeker
4bed984c0f
Charset.forName() for known encodings makes catching UnknownEncodingException obsolete
...
Unify UTF-16LE conversion to StringUtil
BugFix for RecordInputStream.readFully in combination with continuing records
BugFix for integration tests - fix pathname for handler/exclude lookup on windows
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648032 13f79535-47bb-0310-9956-ffa450edef68
2014-12-27 01:33:28 +00:00
Andreas Beeker
d60adb500e
Bug 56913 - Replace usages of o.a.p.util.ArrayUtil.copyOf* methods with replacements from j.u.Arrays
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1622589 13f79535-47bb-0310-9956-ffa450edef68
2014-09-05 00:31:47 +00:00
Nick Burch
da61e7dd32
Fix bug 54725 - HWPF where no parent style CHP exists, use an empty
...
set when processing the style to avoid a NPE
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614926 13f79535-47bb-0310-9956-ffa450edef68
2014-07-31 15:41:58 +00:00
Cédric Walter
1c987c38e6
performance issue: removed instantiation of new String object by copying an existing string.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1583366 13f79535-47bb-0310-9956-ffa450edef68
2014-03-31 16:16:52 +00:00
Cédric Walter
a0d1ab5add
performance issue logging calls are expensive because of the objects created when assembling the log messages. Using the check() method of the logging sub-system can prevent object creation
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1583357 13f79535-47bb-0310-9956-ffa450edef68
2014-03-31 15:54:52 +00:00
Andreas Beeker
2cfc8dbf17
FindBugs fix
...
- fixed "Equals method should not assume anything about the type of its argument"
- see http://findbugs.sourceforge.net/bugDescriptions.html#BC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568861 13f79535-47bb-0310-9956-ffa450edef68
2014-02-16 23:36:32 +00:00
Andreas Beeker
53c90692ee
FindBugs fix
...
- fixed "equals() method does not check for null argument"
- see http://findbugs.sourceforge.net/bugDescriptions.html#NP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENT
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568812 13f79535-47bb-0310-9956-ffa450edef68
2014-02-16 19:35:16 +00:00