moparisthebest/poi
1
0
Fork 0
Code Issues Pull Requests Releases 1 Wiki Activity
9,142 Commits 29 Branches 84 Tags 722 MiB
ac763a24ad
Commit Graph

2453 Commits

Author SHA1 Message Date
Javen O'Neal
49add35f3b fix compile error 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812531 13f79535-47bb-0310-9956-ffa450edef68
 2017-10-18 14:40:05 +00:00
Javen O'Neal
42c4e4909c cleanup for r1812475: avoid NPEs from string.isEmpty() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812520 13f79535-47bb-0310-9956-ffa450edef68
 2017-10-18 14:29:56 +00:00
Javen O'Neal
fc2bcfae9a cleanup for r1812476: avoid NPEs from string.isEmpty() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812516 13f79535-47bb-0310-9956-ffa450edef68
 2017-10-18 14:08:43 +00:00
Javen O'Neal
5fb4887907 replace "".equals(string) with string.isEmpty() to avoid null strings silently evaluating to false; most code should probably check string for null if it is not already 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812476 13f79535-47bb-0310-9956-ffa450edef68
 2017-10-18 08:41:42 +00:00
Javen O'Neal
aba704b928 prefer literal.equals(variable) over variable.equals(literal) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812475 13f79535-47bb-0310-9956-ffa450edef68
 2017-10-18 08:41:25 +00:00
Javen O'Neal
3a2ee5f4d1 convert "".equals(string) to string.isEmpty() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812470 13f79535-47bb-0310-9956-ffa450edef68
 2017-10-18 08:22:51 +00:00
Javen O'Neal
21b65721e7 simplfy PackagingURIHelper#combine boolean logic using xor and replacing +FORWARD_SLASH_CHAR with FORWARD_SLASH_STRING 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812468 13f79535-47bb-0310-9956-ffa450edef68
 2017-10-18 08:10:36 +00:00
Javen O'Neal
afa5be82d3 fix typo 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812464 13f79535-47bb-0310-9956-ffa450edef68
 2017-10-18 07:47:25 +00:00
Javen O'Neal
cfac692a6a string.equals("") -> string.isEmpty() or "".equals(string) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812463 13f79535-47bb-0310-9956-ffa450edef68
 2017-10-18 07:45:53 +00:00
Javen O'Neal
7eb6686b1d remove deprecated XSSFRowShifter.shiftMerged(int,int,int) method; replaced with RowShifter.shiftMergedRegions(int,int,int) in POI 3.15 beta 2 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812354 13f79535-47bb-0310-9956-ffa450edef68
 2017-10-17 07:10:25 +00:00
Dustin Spicuzza
ab147e9998 Bug 61584: Fix XDGFPage variable typo causing crash 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812240 13f79535-47bb-0310-9956-ffa450edef68
 2017-10-16 01:35:31 +00:00
PJ Fanning
e1571c9130 Remove unnecessary toString calls [thanks to Kui Liu]. This close #79. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812233 13f79535-47bb-0310-9956-ffa450edef68
 2017-10-15 20:34:10 +00:00
Dominik Stadler
bc7d79a613 Fix some findbugs-issues and apply some code-cleanup and apply some smaller pull requests. 
This closes #74, This closes #75, This closes #76

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812097 13f79535-47bb-0310-9956-ffa450edef68
 2017-10-13 09:40:22 +00:00
Dominik Stadler
887ec868b7 Fix aparent copy/paste error in XSSFBorderFormatting 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811867 13f79535-47bb-0310-9956-ffa450edef68
 2017-10-11 18:32:13 +00:00
Dominik Stadler
793938ecef Bug 58068: Add a method to pass the actual Color to StylesTable.findFont(). 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811866 13f79535-47bb-0310-9956-ffa450edef68
 2017-10-11 18:32:01 +00:00
Dominik Stadler
c05e07b55c adjust tests, javadoc, ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811865 13f79535-47bb-0310-9956-ffa450edef68
 2017-10-11 18:31:34 +00:00
Dominik Stadler
673b223f61 Remove "filling" in IntList as this has no effect whatsoever as far as I could see 
Fix some IntelliJ warnings, missing JavaDoc, typos, Findbugs issues

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811793 13f79535-47bb-0310-9956-ffa450edef68
 2017-10-11 05:32:05 +00:00
Dominik Stadler
0e52f62a1e Bug 61564: Try to get rid of the Java 9 illegal access warning now that we run Java 8 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811145 13f79535-47bb-0310-9956-ffa450edef68
 2017-10-04 19:54:41 +00:00
Dominik Stadler
688d5072d1 Fix bug 61516: when copying cells with formulas we should properly check for references that are invalid afterwards. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809967 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-28 09:56:45 +00:00
Dominik Stadler
43717f6936 Fix some Sonar issues 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809636 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-25 15:10:40 +00:00
Dominik Stadler
61a281e790 Replace the incompatible new interface method endSheet() with a Java 8 default method so existing implementations do not need to be adjusted. Also use this for headerFooter() and remove the empty implementations that are now obsolete. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809635 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-25 14:45:14 +00:00
PJ Fanning
3a622169d3 Remove more deprecated classes and methods 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809428 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-23 14:03:25 +00:00
Dominik Stadler
acb1772d4b Tried to enable this test, but it is broken since a long time and I am not sure how this is expected to behave... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809372 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-23 07:44:09 +00:00
Dominik Stadler
4a6bb031a0 Apply patch to add endSheet() to the XSSFEventBasedExcelExtractor, fixes bug 60737, thanks to user zakim for the patch 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809371 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-23 07:41:27 +00:00
Dominik Stadler
5ed15ac7c2 More IntelliJ warnings fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809370 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-23 07:38:01 +00:00
Dominik Stadler
29dbeb51ad Bug 59747: Adjust order of first two entries in the resulting Zip to try to enable some external tools to auto-detect the file-type 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809357 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-22 21:19:39 +00:00
Dominik Stadler
79a039ec8d Fix some IntelliJ warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809349 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-22 20:07:56 +00:00
Tim Allison
9cade10fa4 Bug 61349 -- add more sanity checks when allocating byte[] 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809169 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-21 14:52:59 +00:00
Dominik Stadler
828fb9a86c Apply patch from bug 61033 to add a XSSFWorkbook.setCellFormulaValidation(false) to speed up some operations 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809071 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-20 19:08:57 +00:00
PJ Fanning
f13f0dfbbd Bug 61528 - Pivot Table enhancements, new example [Thanks to R Kietel]. This closes #71 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808945 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-19 21:18:09 +00:00
PJ Fanning
a9ec0770f0 tidy up some test code 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808944 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-19 21:04:30 +00:00
Dominik Stadler
1496e83eaa Adjust to make forbidden-api-check succeed again 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808930 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-19 19:02:31 +00:00
Dominik Stadler
985af5304a Bug 61148: Fix calculating formula value, unfortunately we currently need to set the value twice 
Also rework related tests to run more of the tests for HSSF, XSSF and SXSSF

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808929 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-19 19:02:22 +00:00
Dominik Stadler
c31d6686db Fix some IntelliJ warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808908 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-19 16:23:37 +00:00
Tim Allison
a59402a37f 60805 (partial) -- remove/suppress println in tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808903 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-19 15:52:21 +00:00
Dominik Stadler
d1765d7e76 While working on bug 61148 I found that getCellType() and setCellErrorValue() in SXSSFCell are doing different things than the ones in XSSFCell, tried to fix this by mimicking functionality of XSSF in SXSSF as well. 
Reformating some small things as well.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808874 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-19 12:47:13 +00:00
PJ Fanning
51305b6260 use non-deprecated versions of getCellType 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808741 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-18 16:31:55 +00:00
PJ Fanning
e0ee55e75f change CellFormat.ultimateType to return CellType 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808739 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-18 16:06:54 +00:00
PJ Fanning
318fe3e597 change HyperLink getType to return HyperlinkType 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808737 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-18 15:55:48 +00:00
PJ Fanning
aaad224db9 fix compiler warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808722 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-18 14:15:15 +00:00
PJ Fanning
7dad60e9d4 update getCellType to return CellType enum instead of int 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808718 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-18 13:58:55 +00:00
PJ Fanning
4a4c428b6b update getCellType to return CellType enum instead of int 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808703 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-18 13:38:07 +00:00
PJ Fanning
d4486af6de update getCellType to return CellType enum instead of int 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808700 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-18 13:26:16 +00:00
PJ Fanning
d9b63eb569 remove some deprecated code slated for removal in 3.18 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808687 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-18 12:27:36 +00:00
PJ Fanning
16d262d0b4 Change getCachedFormulaResultType to return CellType 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808678 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-18 10:50:50 +00:00
Andreas Beeker
a51bac65b7 #60499 - Deleting a picture that is used twice on a slide corrupt the slide 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808661 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-17 22:45:03 +00:00
Dominik Stadler
71cfb659a1 Remove deprecated methods from NPOIFSFileSystem/OPOIFSFileSystem 
IntelliJ warnings/suggestions

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808622 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-17 11:08:45 +00:00
Dominik Stadler
2917583bd2 Fix some warnings in OOXMLLite and move copyFile to IOUtils 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808621 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-17 11:08:31 +00:00
Dominik Stadler
b644047b70 Various code cleanups, "final" for static methods is useless, for-loops, simplify boolean conditions, try-with-resource, javadoc, ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808620 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-17 11:08:23 +00:00
Dominik Stadler
75c63b6bbe Some more code cleanup 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808619 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-17 11:07:48 +00:00
PJ Fanning
0b7774a452 remove some deprecated code slated for removal in 3.18 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808535 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-16 12:16:29 +00:00
Dominik Stadler
2600c60fb5 Use Integer.compare() where possible 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808522 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-16 08:29:20 +00:00
Dominik Stadler
b7547a01f6 Use Collections.singleton() where applicable 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808520 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-16 08:28:56 +00:00
Dominik Stadler
356d4a77cb Fix some warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808519 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-16 08:28:50 +00:00
Dominik Stadler
5341a131de Remove unnecessary local variables 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808518 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-16 08:28:38 +00:00
Dominik Stadler
7937da6a10 Remove unnecessary type arguments (Java 8) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808516 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-16 08:27:23 +00:00
Dominik Stadler
87f5a0c7cd Remove unused imports 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808513 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-16 08:23:48 +00:00
Dominik Stadler
8ca329e08b Remove unnecessary casts and toString() calls 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808512 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-16 08:23:30 +00:00
Dominik Stadler
f27cb3354d Remove unnecessary initialization of members 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808510 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-16 08:22:59 +00:00
Dominik Stadler
e57e73fe38 Let IntelliJ cleanup some code-warnings across the whole code-base: unnecessary casts 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808508 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-16 08:21:28 +00:00
Dominik Stadler
c9151662e8 Add test for question on the mailing-list 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808500 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-16 08:20:06 +00:00
Dominik Stadler
6592bf6fbe Adjust some more places for the new versions of some third party libraries 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808473 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-15 18:39:29 +00:00
Dominik Stadler
276c8c89de Update third party libs to latest versions 
Start updating build to Java 8
Set version to 4.0-beta1

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808472 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-15 18:39:18 +00:00
PJ Fanning
8f53bd94a6 remove some deprecated code slated for removal in 3.18 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808455 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-15 12:29:35 +00:00
PJ Fanning
19d58f3657 remove some deprecated code slated for removal in 3.18 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808403 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-14 23:44:47 +00:00
PJ Fanning
4d1907b447 remove some deprecated code slated for removal in 3.18 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808402 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-14 23:09:08 +00:00
PJ Fanning
320d9735ca remove some deprecated code slated for removal in 3.18 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808400 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-14 22:19:16 +00:00
PJ Fanning
18e53b3bef add missing licenses on test classes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808315 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-14 07:21:33 +00:00
PJ Fanning
5ef2f1636c Numeric Array Formula and Matrix Function [from Bob95132] This closes #69 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808297 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-13 23:54:36 +00:00
PJ Fanning
e726dd68de [bug-61515] fix xlsf issue with relationships [from Alain Bearez] This closes #70 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808294 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-13 23:10:44 +00:00
Andreas Beeker
d17deb6185 #61478 - POI OOXML-Schema lookup uses wrong classloader 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1807418 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-05 21:30:29 +00:00
Tim Allison
60176900fc While working on 61475, need to add a new line after picture text...not worth separate ticket. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1806843 13f79535-47bb-0310-9956-ffa450edef68
 2017-08-31 20:20:24 +00:00
Tim Allison
235d102f26 61475 -- append text from pictures only once...bug from my work on 61470. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1806839 13f79535-47bb-0310-9956-ffa450edef68
 2017-08-31 19:14:43 +00:00
Tim Allison
3b32a00aa7 61470 -- add extraction of content within ruby elements; allow users to concatenate or not concatenate phonetic strings. Default is to concatenate. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1806712 13f79535-47bb-0310-9956-ffa450edef68
 2017-08-30 16:29:52 +00:00
Greg Woolsey
914ae602b1 Fixes bug #61468, caused by a confusing OOXML spec design as noted in JavaDocs added in r1795648. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1806623 13f79535-47bb-0310-9956-ffa450edef68
 2017-08-29 17:14:52 +00:00
Dominik Stadler
34f35b2d0e Revert performance tuning done via Bug 61350 as it lead to problems when running multi-threaded large regression tests. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1806077 13f79535-47bb-0310-9956-ffa450edef68
 2017-08-24 19:46:39 +00:00
Dominik Stadler
2108f82449 Fix 60384 and 60709: When shifting with merged regions we should correctly check if the region is moved along or needs to be removed because it is not fully kept via the shifting. This was broken by the fix for bug 59740, now additional unit tests ensure that it works better. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1805518 13f79535-47bb-0310-9956-ffa450edef68
 2017-08-19 16:31:45 +00:00
Dominik Stadler
b233345510 Add more non-test classes in OOXMLLite and add another font-metric that appears 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1805516 13f79535-47bb-0310-9956-ffa450edef68
 2017-08-19 16:31:28 +00:00
Greg Woolsey
5e5adc70e5 Bug 61431 - Conditional formatting evaluation ignores undefined cells 
now evaluating based on cell references instead, and watching out for undefined cells in rules that require a cell.

Added unit test based on previously failing file.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1805245 13f79535-47bb-0310-9956-ffa450edef68
 2017-08-16 23:52:27 +00:00
Andreas Beeker
6f341568b6 #61381 - PushbackInputStreams passed to ZipHelper may not hold 8 bytes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1804854 13f79535-47bb-0310-9956-ffa450edef68
 2017-08-11 20:47:48 +00:00
PJ Fanning
9fa3e36e9a [Bug-61048] SXSSF module writes wrong escape sequence for carriage returns 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1804596 13f79535-47bb-0310-9956-ffa450edef68
 2017-08-09 18:37:14 +00:00
Andreas Beeker
ff2bcdf62d #61363 - Unify escher shape id allocation 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803483 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-30 23:11:36 +00:00
Andreas Beeker
b3c111a283 Add handling of alternate content elements 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803397 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-29 23:08:15 +00:00
Greg Woolsey
f9b9c0d18b Deleting a sheet did not delete table parts and relations. Deleting a table needs to also delete any queryTable relations and parts. 
Previous behavior didn't result in documents Excel complained about, but left dead entries in the ZIP structure, which made it bigger and bugged me.

This change does not attempt to delete query connection definitions, as those aren't referenced as relations, and don't have a usage counter to ensure we only delete them if there are no other references.  In my samples I had query tables on multiple sheets using the same connection definition, and wanted to delete only one sheet/table but leave others.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803317 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-28 18:01:36 +00:00
PJ Fanning
9f28e36438 [Bug-61354] fix issue with extracting text from Word docs. This closes #66 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803250 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-28 07:42:23 +00:00
Greg Woolsey
e1f37388fc Fix data validation value list evaluation 
One of my users found that my initial implementation was lacking a core distinction - most evaluations expect a single result, and "unwrap" 2/3D ValueEval results to a single value based on the input row/column.

However, data validation list formulas explicitly are expected to return a 2D ValueEval.  This worked when the formula was simple and evaluated to a single Ptg, but only returned one value when the formula was more complex, or referenced a named range defined as a complex formula.

This change teaches WorkbookEvaluator about the distinction, by way of a new attribute for FormulaType.

There is room for discussion over how it is implemented, but this works for me.

Includes the failing workbook we had as a new unit test.

While I was in FormulaType I went ahead and removed the deprecated, unused, and redundant code marked for removal in 3.17.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803121 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-26 22:19:58 +00:00
Andreas Beeker
49a222ecbc #61350 - Use unsynchronized xmlbeans 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803120 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-26 22:15:27 +00:00
Greg Woolsey
9e896b17ea Another font size variation. I suspect it is my Windows 10 scaling factor, set to 100% instead of the Windows 10 default 125%. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803117 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-26 22:00:23 +00:00
Andreas Beeker
4ca2ad85b9 remove test leftover 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803024 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-26 08:13:16 +00:00
Andreas Beeker
d345faa025 Bug 61182 - Invalid signature created for streamed xlsx file 
- add hashes for other linebreaks

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803011 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-25 22:42:22 +00:00
Tim Allison
67719a8d4f augment expected sizes in TestFonts 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1802855 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-24 19:29:29 +00:00
Andreas Beeker
08b03d9547 Fonts bugfix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1802751 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-24 05:39:33 +00:00
Andreas Beeker
2325cdb9e6 Bug 61331 - Font group handling / common font interface 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1802741 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-23 22:45:47 +00:00
Dominik Stadler
f28bbb750c Adjust TestFonts for my version of Ubuntu 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1802632 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-21 18:19:22 +00:00
Dominik Stadler
c76672b8aa ExtractorFactory: Try to close resources also on Errors to avoid keeping files open too long 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1802630 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-21 18:19:11 +00:00
PJ Fanning
d4c9e0206a fix tests broken by <br/> doc changes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1802131 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-17 11:36:32 +00:00
PJ Fanning
810d03f499 javadoc: replace invalid self enclosing elements 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1802110 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-17 08:24:24 +00:00
PJ Fanning
9b3812d027 some javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1802035 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-15 22:31:09 +00:00
Javen O'Neal
36e97a30e5 bug 61296: deduplicate ooxml schema constants 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801904 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-14 03:47:38 +00:00
Javen O'Neal
0a18068f0c bug 61296: consolidate some of the ooxml namespace uri copy-paste in POI, prepare to make these usable by downstream libraries like Tika 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801903 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-14 03:39:25 +00:00
Javen O'Neal
e8d59d0d7b bug 61296: consolidate some of the ooxml namespace uri copy-paste in POI, prepare to make these usable by downstream libraries like Tika 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801901 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-14 03:14:30 +00:00
PJ Fanning
d1a51f76f0 avoid unnecessary string concats in SXSSF SheetDataWriter 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801806 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-13 07:14:01 +00:00
Javen O'Neal
f1cf95ecb5 add 362px font height for my computer's configuration (high-dpi monitor) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801803 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-13 04:30:41 +00:00
Javen O'Neal
2b0ded5cb3 replace commented-out throw-away code that writes workbook to C:\temp\xxxxx.xlsx for manual review with XSSFTestDataSamples.writeOut(wb, "bug xxxxx for manual review") 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801801 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-13 04:19:20 +00:00
PJ Fanning
eddad11775 [Bug-61281] fix issue with export of table columns - Thanks to Daniel for the patch 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801721 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-12 10:46:13 +00:00
PJ Fanning
748e0c4981 remove more deprecated methods 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801697 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-12 08:38:20 +00:00
PJ Fanning
f11bb182e9 remove deprecated methods from CommentsTable 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801692 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-12 08:15:44 +00:00
PJ Fanning
1f8de11b31 [Bug-61281] guard against index out of bounds in XSSFExportToXml column mapping 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801634 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-11 16:38:49 +00:00
PJ Fanning
9ae9aa0210 expand range of acceptable values in TestFonts 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801416 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-10 07:26:40 +00:00
Andreas Beeker
4c10645b48 font rendering - handle a few system dependent textbox sizes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801401 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-09 23:28:41 +00:00
PJ Fanning
e046241c30 [Bug-61268] avoid NegativeArraySizeException parsing doc file 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801395 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-09 22:32:27 +00:00
Andreas Beeker
0cac9103ba Rollback of r1801368 because of a generics bug with self-referenced types in Java6 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801373 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-09 15:27:29 +00:00
Andreas Beeker
377615e9cd #61169 - Text with Japanese characters overflows textbox 
- add resize methods with Graphics argument

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801329 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-08 22:20:55 +00:00
PJ Fanning
68be989d22 [Bug 61246] remove flush method 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800712 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-03 20:32:55 +00:00
PJ Fanning
0c9a1ef203 [Bug 61246] fix issue where SXSSF sheet data has unicode surrogate chars replaced by '?' 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800705 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-03 18:49:25 +00:00
PJ Fanning
3cac752c89 Add missing deprecations for CellType methods that return ints 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800569 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-02 17:12:55 +00:00
PJ Fanning
cbb15b1efa Remove more deprecated code (MissingCellPolicy) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800400 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-30 13:00:57 +00:00
PJ Fanning
ee70c9a8fb Remove more deprecated code (especially from Spreadsheet Cell classes) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800375 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-30 11:48:23 +00:00
Javen O'Neal
e552b04d9c remove incomplete javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800361 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-30 07:48:40 +00:00
Javen O'Neal
7cb0588daf add @Internal annotation to methods that return a CT* class 
add @Override annotation where missing

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800360 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-30 07:45:46 +00:00
Greg Woolsey
07a7987a48 Expose one more bit of style information generically (for XSSF). If someone needs all these properties for HSSF charts as well, we can build a new Interface for the various bits and populate it with things like axis line width and color, etc. but for now I think most users are in the XSSF realm like me. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800341 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-29 23:06:27 +00:00
Nick Burch
2cbd15ece2 Deprecated xssfSheetIterator has been removed, so remove javadoc reference 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800288 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-29 14:38:41 +00:00
Andreas Beeker
b2d19936ef remove temporary jenkins debug output 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800263 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-29 10:49:22 +00:00
Andreas Beeker
1ce039753a remove timezoned call to Date.toString() - SignatureProperties don't necessarily need an Id attribute 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800257 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-29 09:33:33 +00:00
PJ Fanning
af35e389da remove some unused imports 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800255 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-29 08:55:35 +00:00
PJ Fanning
5f6e2b780a remove deprecated POIXMLDocument.hasOOXMLHeader 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800254 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-29 08:45:00 +00:00
PJ Fanning
657784ce1a Remove old XSSFWorkbook wb.xssfSheetIterator method 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800248 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-29 08:15:50 +00:00
PJ Fanning
4bcc0f4eb1 Remove old XSSFPaswordHelper 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800247 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-29 08:10:32 +00:00
Nick Burch
07c18a9055 Used deprecated external method removed, so remove internal method 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800212 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-28 23:29:58 +00:00
Andreas Beeker
9ef695aedf add debugging info to find signature differences 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800209 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-28 23:04:25 +00:00
PJ Fanning
5c65b55bd4 Ensure SpreadsheetVersion is set for AreaReferences 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800208 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-28 22:11:26 +00:00
Andreas Beeker
51b46a9e4e Bug 61182 - Invalid signature created for streamed xslx file 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800207 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-28 21:38:23 +00:00
PJ Fanning
4209a1b2da Remove some deprecated *SSF APIs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800147 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-28 10:34:37 +00:00
Nick Burch
a753adb848 Add import for javadocs references 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799832 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-25 19:16:36 +00:00
Andreas Beeker
85963a56f7 rollback invalid commit - r1799740 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799742 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-24 09:20:02 +00:00
Andreas Beeker
6aae53935a release prepare for 3.17-beta1 - pin documentation 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799740 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-24 09:03:00 +00:00
PJ Fanning
61b0ecbd4b Add StaxHelper to ensure that StAX parsers have sensible defaults, including settings to avoid XML Entity Expansion issues 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799734 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-24 07:30:07 +00:00
Greg Woolsey
972d561897 Add file that failed regression tests as a unit test. 
Adjust table style processing to allow for AlternateContent wrappers for table element style definitions.  


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799733 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-24 05:55:45 +00:00
Greg Woolsey
0e23e4e9d8 Move my new unit conversions to the Units class, move and deprecate duplicate and scattered unit constants, update constant references to standardize on the ones in the Units class. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799683 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-23 15:43:48 +00:00
Greg Woolsey
12048f528b Bug 61203 
one of these days I'll add the copyright to my project templates.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799645 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-23 06:17:09 +00:00
Greg Woolsey
8c67848ad6 Bug 61203 - XSSFDrawing.getAnchorFromParent handles CTOneCellAnchor incorrectly, ignores CTAbsoluteAnchor 
This is likely incomplete, but closer to where things should be.  It is backward compatible with previous uses of XSSFClientAnchor.

This fixes a bug in XSSFGraphicFrame that was hiding the parent class anchor property (which is a protected field set directly from XSSFDrawing).  This is a peril of using direct property access - the hiding wasn't obvious because there was no setter being overridden.

XSSFGraphicFrame now notices when it relates to a chart, and setts the frame property of the XSSFChart.  That was not being set on parse previously, only when creating charts from scratch.  That didn't seem right.

XSSFClientAnchor now calculates size and position correctly based on initial inputs from the different types of anchors.  It DOES NOT update those initial inputs, however.  It does properly adjust if the size or initial position are absolute and the corresponding row/column values are requested.

Added new class EMUUtils to centralize the measurement constants and conversions since there are so many units in play in the OOXML spec and POI APIs:

* EMUs (English Metric Units)
* Inches
* Centimeters
* Points
* Pixels
* Twips (1/20th of a point)

I'm sure there are more conversions that could be done there, I just started with what I needed.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799643 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-23 05:16:38 +00:00
Tim Allison
fe5f8fb54c bug 61053 -- not a fix, but this aligns XSSFBSheetHandler's behavior with streaming and non-streaming extractors for xlsx 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799345 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-20 12:59:33 +00:00
Javen O'Neal
9326624d76 unit test that is not written yet should fail 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799324 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-20 09:13:18 +00:00
Javen O'Neal
de9134c1d8 simplify unit test code with IOUtils.write to a NullOutputStream 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799323 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-20 09:12:42 +00:00
Javen O'Neal
171692edf2 bug 57919: close opened resources 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799316 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-20 08:13:58 +00:00
Javen O'Neal
5971083683 rename createXls and createXlsx helper functions: these are specifically for testing text rotation. 
Made the file creation compatible on Windows and Mac/Linux using POI TempFile instead of a hard-coded filename.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799307 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-20 07:05:08 +00:00
Javen O'Neal
51065c8159 bug 58113: this passes with SXSSF now 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799306 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-20 07:03:13 +00:00
Javen O'Neal
15212e0feb bug 56557: open test-data/spreadsheet/56557.xlsx such that the unit test test56557() does not leave a modified file on disk after running. 
I verified that
> Workbook wb = XSSFTestDataSamples.openSampleWorkbook("56557.xlsx")
and
> Workbook wb = WorkbookFactory.create(XSSFTestDataSamples.getSampleFile("56557.xlsx"), password=null, readOnly=false);
both fail when the fix from r1798913 for SXSSFWorkbook is not applied and both pass when the fix is applied.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799304 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-20 06:08:38 +00:00
Dominik Stadler
2095c92402 Improve error message if we encounter invalid/unexpected files in integration tests 
Adjust some tests slightly

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799178 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-19 11:05:20 +00:00
Dominik Stadler
128ba623f8 Don't try to clone a chart, this makes integration-tests work for a few more documents, also the one added via bug 56557 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799037 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-18 05:59:25 +00:00