Javen O'Neal
a3e44453ca
rename drawBorders(..., short color, ...) to drawColoredBorders to make it obvious that method changes border line style and color
...
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748074 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 01:00:51 +00:00
Javen O'Neal
75e4c452bf
test copy constructor: make changes to same range: this is a better test for deepcopy
...
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748073 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 00:50:52 +00:00
Javen O'Neal
ca9431d71f
add copy constructor
...
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748072 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 00:43:34 +00:00
Javen O'Neal
d68b4ea41d
move colors in TestBorderPropertyTemplate to testclass constants
...
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748071 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 00:40:46 +00:00
Javen O'Neal
344b9d9884
remove public convenience methods that let the user avoid creating a CellAddress object. Having the user provide a CellAddress increases the chance the user-provided object will be reused if possible. This also moves the validation of the CellAddress object outside of this BorderPropertyTemplate class (easier to debug), improves readability, and runs slightly faster since the CellAddress is needed anyways as a key.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748065 13f79535-47bb-0310-9956-ffa450edef68
2016-06-12 22:33:24 +00:00
Javen O'Neal
e6937956f2
use CellAddress in unit tests where possible to improve readability
...
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748062 13f79535-47bb-0310-9956-ffa450edef68
2016-06-12 22:01:30 +00:00
Javen O'Neal
16fb41d5f1
make these classes more discoverable/searchable using more specific names
...
rename PropertyTemplate to BorderPropertyTemplate
rename Extent to BorderExtent
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747884 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 12:09:23 +00:00
Javen O'Neal
bd22a7be43
replace usage of all deprecated CellStyle.BORDER_* constants with BorderStyle.*
...
update PropertyTemplate functions to require enum instead of short borderType
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747868 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 09:15:57 +00:00
Javen O'Neal
7dc4706edf
continue simplifying using helper functions
...
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747859 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 08:15:50 +00:00
Javen O'Neal
66875dbc1b
continue simplifying using helper functions
...
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747858 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 08:08:04 +00:00
Javen O'Neal
8ad237f679
add helper functions for verifying template properties were set correctly
...
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747855 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 07:48:32 +00:00
Javen O'Neal
222e32d577
whitespace (unwrap lines)
...
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747854 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 07:40:46 +00:00
Javen O'Neal
50d0a1197f
shorten PropertyTemplate.Extent to Extent
...
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747853 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 07:10:21 +00:00
Javen O'Neal
fc6b8cdd0e
+props svn:eol-style=native
...
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747852 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 07:00:40 +00:00
Javen O'Neal
54213ab158
bug 58787: add PropertyTemplate, unit test, and example from Mark Murphy
...
Attachment 33684 plus changes to TestPropertyTemplate#applyBorders: replaced assertEquals(CellStyle.BORDER_*, cs.getBorder*()) with assertEquals(BorderStyle.*, cs.getBorder*())
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747851 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 06:47:25 +00:00
Javen O'Neal
db6ceaa7fa
bug 59684: correctly parse CellReference(HOMEst163); Also deprecate misspelled methods isRowWithinRange/isColumnWithinRange
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747687 13f79535-47bb-0310-9956-ffa450edef68
2016-06-10 11:52:44 +00:00
Javen O'Neal
9fba427794
convert TestCellUtil to BaseTestCellUtil so that it can be tested with different workbook instances
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742859 13f79535-47bb-0310-9956-ffa450edef68
2016-05-09 01:09:36 +00:00
Javen O'Neal
4e33c06871
bug 59336: patch from Mark Murphy: deprecate functions in CellUtil that require an unnecessary Workbook argument.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739536 13f79535-47bb-0310-9956-ffa450edef68
2016-04-17 01:29:19 +00:00
Javen O'Neal
1786767b89
bug 59264: use BorderStyle for changing Cell border line style
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737879 13f79535-47bb-0310-9956-ffa450edef68
2016-04-05 20:28:46 +00:00
Andreas Beeker
7d6be0ff54
#59170 - Remove deprecated classes (POI 3.15) - org.apache.poi.hssf/ss.util.Region
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734651 13f79535-47bb-0310-9956-ffa450edef68
2016-03-12 00:17:16 +00:00
Javen O'Neal
347881ef1e
bug 58633 comment 5 and comment 6: add unit test coverage for CellUtil.java; throw exception of Cell does not belong to workbook for some methods
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722618 13f79535-47bb-0310-9956-ffa450edef68
2016-01-02 11:11:33 +00:00
asf-sync-process
de7807c8a7
bug 58633: Set multiple CellStyle properties at once. Patch from Mark Murphy.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722607 13f79535-47bb-0310-9956-ffa450edef68
2016-01-02 04:29:34 +00:00
Dominik Stadler
b4ac21a810
Eclipse warnings
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722406 13f79535-47bb-0310-9956-ffa450edef68
2015-12-30 20:31:13 +00:00
Javen O'Neal
ae9bcd8e82
convert junit3 to junit4
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715752 13f79535-47bb-0310-9956-ffa450edef68
2015-11-23 10:26:06 +00:00
Javen O'Neal
dbba80c3fc
bug 58637: contribution from Hannes Erven: add CellAddress class, distinct from CellReference
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715743 13f79535-47bb-0310-9956-ffa450edef68
2015-11-23 09:30:53 +00:00
Javen O'Neal
265d198612
bug 58576: rename canComputeColumnWidht to canComputeColumnWidth
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712219 13f79535-47bb-0310-9956-ffa450edef68
2015-11-03 07:23:09 +00:00
Javen O'Neal
07cf6736ae
improve error message if CellRangeAddress intersection assertion fails
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711597 13f79535-47bb-0310-9956-ffa450edef68
2015-10-31 11:20:15 +00:00
Javen O'Neal
043a86e243
bug 58443: prevent corrupted workbooks by checking for overlapping merged regions before adding a merged region to a sheet; fix unit tests that produced corrupt workbooks; remove deprecated HSSFSheet#addMergedRegion(Region)
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711586 13f79535-47bb-0310-9956-ffa450edef68
2015-10-31 10:22:19 +00:00
Javen O'Neal
c22fdbbc2b
bug 58441: define equals method for CellRangeAddressBase
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710172 13f79535-47bb-0310-9956-ffa450edef68
2015-10-23 11:17:06 +00:00
Andreas Beeker
5f94d8b533
fix eclipse warning - mostly generics cosmetics
...
close resources in tests
junit4 conversions
convert spreadsheet based formular test to junit parameterized tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1702659 13f79535-47bb-0310-9956-ffa450edef68
2015-09-12 18:45:07 +00:00
Andreas Beeker
aaafb0270d
Bug 58326 - Forbidden APIs patches - first set of changes for locale and timezone settings
...
also includes fixes for
- name shadowing
- unused deprecated method "getClipRect" in classes extending Graphics2d
- HexDump - replaced intermediate String.format calls with custom padding
- convert testcases to junit4
- closing resources
also tested with an arbitary timezone (PST) and locale (ru)
supresses forbidden apis check for
- LocaleUtil (the only place where Locale.getDefault() and TimeZone.getDefault() should be called)
- Classes using FontMetrics - without the actual text it's difficult to return something sane
Some usage of UTC and Locale.ROOT might be still wrong, e.g. in MapiMessage we don't access the
extended mapi properties, which might contain the timezone
DataFormatter has now a Observable property which need to be observed when custom formats are used
and the Locale changes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701688 13f79535-47bb-0310-9956-ffa450edef68
2015-09-07 20:19:50 +00:00
Nick Burch
aa455c91fd
Fix some Forbidden APIs errors
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700670 13f79535-47bb-0310-9956-ffa450edef68
2015-09-01 21:09:20 +00:00
Andreas Beeker
6703c9d3fb
forbidden apis fixes
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700076 13f79535-47bb-0310-9956-ffa450edef68
2015-08-29 21:45:08 +00:00
Andreas Beeker
f2487c035a
junit4 fix
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700043 13f79535-47bb-0310-9956-ffa450edef68
2015-08-29 14:47:16 +00:00
Andreas Beeker
33ffe01bff
- reworked HexDump class - unified array dumps and usage of standard java calls for hex format
...
- fixed a few findbugs DM_DEFAULT_ENCODING issues
- removed a few System.out/.err calls - instead the poilogger is used
- closed a few left open resource instances
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700040 13f79535-47bb-0310-9956-ffa450edef68
2015-08-29 14:41:12 +00:00
Nick Burch
a92c078d18
Fix indents
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696429 13f79535-47bb-0310-9956-ffa450edef68
2015-08-18 14:34:52 +00:00
Nick Burch
3bde975db7
Patch from Javen ONeal from bug #58252 - More CellReference unit testing coverage
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696427 13f79535-47bb-0310-9956-ffa450edef68
2015-08-18 14:32:53 +00:00
Dominik Stadler
651f03cc64
* Make on unit test not fail if Fonts are not available on the machine
...
* Refactor SheetUtil a bit to reduce code-duplication, adjust JavaDoc for -1 return values
* Add method to check if we can compute text-width
* Add unit-tests which verify some more of SheetUtil
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691341 13f79535-47bb-0310-9956-ffa450edef68
2015-07-16 09:06:47 +00:00
David North
32bf29fba6
Whitespace seems to be confusing the license header check; try pasting one off another file.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1685523 13f79535-47bb-0310-9956-ffa450edef68
2015-06-15 09:44:12 +00:00
Dominik Stadler
dafeb24564
One more file with missing license header
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1685522 13f79535-47bb-0310-9956-ffa450edef68
2015-06-15 09:38:29 +00:00
David North
369c593380
Add explicit test for NPE only caught by other tests. Test '97 fallback behaviour generally.
...
https://bz.apache.org/bugzilla/show_bug.cgi?id=56328
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1685104 13f79535-47bb-0310-9956-ffa450edef68
2015-06-12 15:29:20 +00:00
David North
16a9eca7c8
My own patch to fix #56328
...
Add tests for initial patch applied by Nick in r1582892
Fix and test AreaReference#isWholeColumnReference to take account of the prevailing spreadsheet version. Fixing all users of this is a big undertaking, so for now I've left a fallback on the original behaviour for some cases.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1685101 13f79535-47bb-0310-9956-ffa450edef68
2015-06-12 15:20:10 +00:00
Dominik Stadler
8997d8900d
* Add missing close() on streams in ImageUtils.getImageDimension()
...
* Add some unit tests for CellReference
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1650070 13f79535-47bb-0310-9956-ffa450edef68
2015-01-07 14:36:39 +00:00
Dominik Stadler
8a82d32ae8
Apply patch for bug 57151: Document CellRangeAddress and add some validation to prevent invalid row/column combinations.
...
Cover class CellRangeAddress fully in unit tests.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1635389 13f79535-47bb-0310-9956-ffa450edef68
2014-10-30 05:53:06 +00:00
Nick Burch
508f36d702
SheetUtil helper for finding the main cell of a merged region, if in one
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1632833 13f79535-47bb-0310-9956-ffa450edef68
2014-10-18 19:58:05 +00:00
Dominik Stadler
7e21a14172
Adjust for JDK 8 where an empty locale is added to the array returned by DateFormat.getAvailableLocales()
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575563 13f79535-47bb-0310-9956-ffa450edef68
2014-03-08 16:46:59 +00:00
Dominik Stadler
a128bcd5e2
Enhance test to print out more information, it seems to fail on Apache Jenkins JDK8 build
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575500 13f79535-47bb-0310-9956-ffa450edef68
2014-03-08 08:41:08 +00:00
Yegor Kozlov
0d752498a2
Bugzilla >52928 - DateFormatConverter: an utility to convert instances of java.text.DateFormat to Excel format patterns
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1301923 13f79535-47bb-0310-9956-ffa450edef68
2012-03-17 12:16:45 +00:00
Yegor Kozlov
828ee0cf88
Bugzilla 52583 - fixed WorkbookUtil#createSafeSheetName to escape colon
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1294180 13f79535-47bb-0310-9956-ffa450edef68
2012-02-27 15:21:40 +00:00
Yegor Kozlov
b1dce5c2ad
more progress with xssf chart api, see Bug 51196
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1167579 13f79535-47bb-0310-9956-ffa450edef68
2011-09-10 19:00:47 +00:00