Javen O'Neal
|
a3e44453ca
|
rename drawBorders(..., short color, ...) to drawColoredBorders to make it obvious that method changes border line style and color
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748074 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-13 01:00:51 +00:00 |
Javen O'Neal
|
ca9431d71f
|
add copy constructor
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748072 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-13 00:43:34 +00:00 |
Javen O'Neal
|
0ae778e5cd
|
rewrite switch statements to not re-check the switch'd variable
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748070 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-12 23:43:16 +00:00 |
Javen O'Neal
|
a63d82bbee
|
rename borderIsNotSetOrBlank to borderIsNotSet. Changing a set border style from NONE to THIN fails the unit test. What is the correct behavior?
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748068 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-12 23:03:23 +00:00 |
Javen O'Neal
|
67b7e97a9f
|
rename borderIsNotSetOrBlank to borderIsNotSet. Changing a set border style from NONE to THIN fails the unit test. What is the correct behavior?
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748067 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-12 22:59:47 +00:00 |
Javen O'Neal
|
ad98f81e5f
|
move check if border line style is blank before setting the border color to a helper function for readability
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748066 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-12 22:57:37 +00:00 |
Javen O'Neal
|
344b9d9884
|
remove public convenience methods that let the user avoid creating a CellAddress object. Having the user provide a CellAddress increases the chance the user-provided object will be reused if possible. This also moves the validation of the CellAddress object outside of this BorderPropertyTemplate class (easier to debug), improves readability, and runs slightly faster since the CellAddress is needed anyways as a key.
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748065 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-12 22:33:24 +00:00 |
Javen O'Neal
|
513dfc5ff1
|
javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748063 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-12 22:02:38 +00:00 |
Javen O'Neal
|
3530aa3bf2
|
javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748061 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-12 22:00:45 +00:00 |
Javen O'Neal
|
f9c7ae0102
|
javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748055 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-12 21:35:56 +00:00 |
Javen O'Neal
|
16fb41d5f1
|
make these classes more discoverable/searchable using more specific names
rename PropertyTemplate to BorderPropertyTemplate
rename Extent to BorderExtent
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747884 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 12:09:23 +00:00 |
Javen O'Neal
|
cea8cc65a3
|
javadoc update and boolean addLeft|Right|Top|Bottom line wrap update
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747877 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 11:12:04 +00:00 |
Javen O'Neal
|
7c90716fdc
|
fix javadocs: remove unnecessary @links, remove references to CellStyle
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747873 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 10:09:05 +00:00 |
Javen O'Neal
|
ad11547c8a
|
move loop-invariants outside the loop for readability and execution speed
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747871 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 09:58:12 +00:00 |
Javen O'Neal
|
bd22a7be43
|
replace usage of all deprecated CellStyle.BORDER_* constants with BorderStyle.*
update PropertyTemplate functions to require enum instead of short borderType
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747868 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 09:15:57 +00:00 |
Javen O'Neal
|
fc6b8cdd0e
|
+props svn:eol-style=native
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747852 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 07:00:40 +00:00 |
Javen O'Neal
|
54213ab158
|
bug 58787: add PropertyTemplate, unit test, and example from Mark Murphy
Attachment 33684 plus changes to TestPropertyTemplate#applyBorders: replaced assertEquals(CellStyle.BORDER_*, cs.getBorder*()) with assertEquals(BorderStyle.*, cs.getBorder*())
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747851 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 06:47:25 +00:00 |
Javen O'Neal
|
db6ceaa7fa
|
bug 59684: correctly parse CellReference(HOMEst163); Also deprecate misspelled methods isRowWithinRange/isColumnWithinRange
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747687 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-10 11:52:44 +00:00 |
Javen O'Neal
|
730641576a
|
bug 59443: exit early on setAddress if address is the same
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742881 13f79535-47bb-0310-9956-ffa450edef68
|
2016-05-09 05:46:14 +00:00 |
Javen O'Neal
|
4e33c06871
|
bug 59336: patch from Mark Murphy: deprecate functions in CellUtil that require an unnecessary Workbook argument.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739536 13f79535-47bb-0310-9956-ffa450edef68
|
2016-04-17 01:29:19 +00:00 |
Dominik Stadler
|
62ee0abc13
|
Code cleanup via IntelliJ: Remove unnecessary semicolon
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738031 13f79535-47bb-0310-9956-ffa450edef68
|
2016-04-06 19:49:47 +00:00 |
Javen O'Neal
|
b8dcd4df42
|
bug 59264: fix findbugs warning 'A boxed value is unboxed and then immediately reboxed.'
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737896 13f79535-47bb-0310-9956-ffa450edef68
|
2016-04-06 00:06:53 +00:00 |
Javen O'Neal
|
c95f6a4b35
|
whitespace (tabs to 4 spaces)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737895 13f79535-47bb-0310-9956-ffa450edef68
|
2016-04-05 23:47:41 +00:00 |
Javen O'Neal
|
fe13debb84
|
bug 59264: move border style deprecations to POI 3.15 beta 2.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737894 13f79535-47bb-0310-9956-ffa450edef68
|
2016-04-05 23:30:37 +00:00 |
Javen O'Neal
|
5752c4bb7e
|
bug 59264: allow borders styles to be set with BorderStyles enums or Short codes for backwards compatibility
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737885 13f79535-47bb-0310-9956-ffa450edef68
|
2016-04-05 21:36:11 +00:00 |
Javen O'Neal
|
1786767b89
|
bug 59264: use BorderStyle for changing Cell border line style
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737879 13f79535-47bb-0310-9956-ffa450edef68
|
2016-04-05 20:28:46 +00:00 |
Dominik Stadler
|
0115c12e2d
|
Fix some compiler warnings, javadoc, ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736924 13f79535-47bb-0310-9956-ffa450edef68
|
2016-03-28 20:22:08 +00:00 |
Andreas Beeker
|
e9f333827d
|
fix eclipse warnings
close resources
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735912 13f79535-47bb-0310-9956-ffa450edef68
|
2016-03-21 00:14:21 +00:00 |
Andreas Beeker
|
56ceb000f1
|
sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735345 13f79535-47bb-0310-9956-ffa450edef68
|
2016-03-16 23:30:19 +00:00 |
Andreas Beeker
|
7d6be0ff54
|
#59170 - Remove deprecated classes (POI 3.15) - org.apache.poi.hssf/ss.util.Region
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734651 13f79535-47bb-0310-9956-ffa450edef68
|
2016-03-12 00:17:16 +00:00 |
Javen O'Neal
|
347881ef1e
|
bug 58633 comment 5 and comment 6: add unit test coverage for CellUtil.java; throw exception of Cell does not belong to workbook for some methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722618 13f79535-47bb-0310-9956-ffa450edef68
|
2016-01-02 11:11:33 +00:00 |
Javen O'Neal
|
4a47ec3d39
|
fix javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722609 13f79535-47bb-0310-9956-ffa450edef68
|
2016-01-02 06:23:05 +00:00 |
asf-sync-process
|
de7807c8a7
|
bug 58633: Set multiple CellStyle properties at once. Patch from Mark Murphy.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722607 13f79535-47bb-0310-9956-ffa450edef68
|
2016-01-02 04:29:34 +00:00 |
Javen O'Neal
|
a50f45e4c2
|
bug 58775: use short for data format index, int for cell style index
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721930 13f79535-47bb-0310-9956-ffa450edef68
|
2015-12-28 14:50:54 +00:00 |
Javen O'Neal
|
5da709336c
|
supporting change for bug 56454: SheetUtil.containsCell and CellRangeAddress.isInRange are equivalent
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1718221 13f79535-47bb-0310-9956-ffa450edef68
|
2015-12-06 21:11:38 +00:00 |
Javen O'Neal
|
226fefe0c9
|
patch from Stefan Thurnherr: bug 57450: autosize columns in SXSSF using rows that have been flushed to disk
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717146 13f79535-47bb-0310-9956-ffa450edef68
|
2015-11-30 00:22:50 +00:00 |
Javen O'Neal
|
8c1517eee4
|
javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716948 13f79535-47bb-0310-9956-ffa450edef68
|
2015-11-28 11:55:02 +00:00 |
Javen O'Neal
|
47dc6340c2
|
javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716947 13f79535-47bb-0310-9956-ffa450edef68
|
2015-11-28 11:53:22 +00:00 |
Javen O'Neal
|
2a62f57db5
|
+FIXME
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716838 13f79535-47bb-0310-9956-ffa450edef68
|
2015-11-27 11:30:18 +00:00 |
Javen O'Neal
|
19f4f8af22
|
javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716365 13f79535-47bb-0310-9956-ffa450edef68
|
2015-11-25 11:52:25 +00:00 |
Javen O'Neal
|
e8b2d5feb4
|
bug 58651: replace for-looped sheet.getMergedRegion(index) with sheet.getMergedRegions()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716362 13f79535-47bb-0310-9956-ffa450edef68
|
2015-11-25 11:48:17 +00:00 |
Javen O'Neal
|
a736ac1777
|
FindBug warning: ICAST_IDIV_CAST_TO_DOUBLE: integral division result cast to double
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716005 13f79535-47bb-0310-9956-ffa450edef68
|
2015-11-24 01:11:57 +00:00 |
Javen O'Neal
|
cba32cd1a0
|
FindBug warning: EQ_SELF_USE_OBJECT: class defines equals(Region) and uses Object.equals(Object)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716004 13f79535-47bb-0310-9956-ffa450edef68
|
2015-11-24 01:10:47 +00:00 |
Javen O'Neal
|
6acd60f74d
|
fix normal priority FindBugs warning: DMI_INVOKING_HASHCODE_ON_ARRAY
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715998 13f79535-47bb-0310-9956-ffa450edef68
|
2015-11-24 00:08:22 +00:00 |
Javen O'Neal
|
3e10c4f0f6
|
bug 58365: patch from Hannes Erven: add method to efficiently get all cell comments on a Sheet and return a dictionary with the location of each comment as the key and the comment itself as the value.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715839 13f79535-47bb-0310-9956-ffa450edef68
|
2015-11-23 15:11:28 +00:00 |
Javen O'Neal
|
dbba80c3fc
|
bug 58637: contribution from Hannes Erven: add CellAddress class, distinct from CellReference
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715743 13f79535-47bb-0310-9956-ffa450edef68
|
2015-11-23 09:30:53 +00:00 |
Javen O'Neal
|
20ba4851a8
|
fix for bug 51622: autosize columns with leading whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712477 13f79535-47bb-0310-9956-ffa450edef68
|
2015-11-04 06:39:57 +00:00 |
Javen O'Neal
|
265d198612
|
bug 58576: rename canComputeColumnWidht to canComputeColumnWidth
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712219 13f79535-47bb-0310-9956-ffa450edef68
|
2015-11-03 07:23:09 +00:00 |
Javen O'Neal
|
3b88a60498
|
supporting change for bug 57450 from Stefan Thurnherr
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712217 13f79535-47bb-0310-9956-ffa450edef68
|
2015-11-03 07:07:11 +00:00 |
Javen O'Neal
|
f98fda03c1
|
add javadoc info for intersects
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711613 13f79535-47bb-0310-9956-ffa450edef68
|
2015-10-31 12:21:51 +00:00 |