Commit Graph

6823 Commits

Author SHA1 Message Date
Andreas Beeker
33ffe01bff - reworked HexDump class - unified array dumps and usage of standard java calls for hex format
- fixed a few findbugs DM_DEFAULT_ENCODING issues
- removed a few System.out/.err calls - instead the poilogger is used
- closed a few left open resource instances

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700040 13f79535-47bb-0310-9956-ffa450edef68
2015-08-29 14:41:12 +00:00
Andreas Beeker
537ca7355a sonar - remove build dir when cleaning
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700034 13f79535-47bb-0310-9956-ffa450edef68
2015-08-29 14:03:48 +00:00
Nick Burch
c451224d84 Fix a handful of forbidden apis identified problems
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1698198 13f79535-47bb-0310-9956-ffa450edef68
2015-08-27 17:21:35 +00:00
Nick Burch
57a1370f1d Enable the Forbidden APIs checks on Main, Scratchpad and OOXML. Run with "ant forbidden-apis-check"
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1698148 13f79535-47bb-0310-9956-ffa450edef68
2015-08-27 13:23:44 +00:00
Nick Burch
eea3ef5c49 Update RAT docs, and fetch the Forbidden APIs jar
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1698147 13f79535-47bb-0310-9956-ffa450edef68
2015-08-27 13:14:46 +00:00
Nick Burch
d1f537ff48 Stub a call to the Forbidden APIs check
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1698143 13f79535-47bb-0310-9956-ffa450edef68
2015-08-27 13:07:36 +00:00
Dominik Stadler
cfd25be631 Sonar Maven: Next try: Disable Subversion to see if we get results then.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1698142 13f79535-47bb-0310-9956-ffa450edef68
2015-08-27 13:04:25 +00:00
Dominik Stadler
892e01b656 Sonar Maven: Revert previous changes as they also did not work, it seems there is no way to get a Sonar Maven build this way :(
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1698089 13f79535-47bb-0310-9956-ffa450edef68
2015-08-27 08:20:40 +00:00
Dominik Stadler
b98bfd48aa Adjust excludes for TestRecordLister
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1698081 13f79535-47bb-0310-9956-ffa450edef68
2015-08-27 06:32:33 +00:00
Andreas Beeker
880d5fa413 javadoc fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1698030 13f79535-47bb-0310-9956-ffa450edef68
2015-08-26 22:26:39 +00:00
Andreas Beeker
cf84bb1a85 Fix for JDK6 bug: http://bugs.java.com/view_bug.do?bug_id=6569074
This was fixed in jdk 7u72 ... so we'll keep this bit uncleaner version for a while ...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1698006 13f79535-47bb-0310-9956-ffa450edef68
2015-08-26 21:25:58 +00:00
Dominik Stadler
6bdc2fb024 Add possibility to set zoomPercent for XWPFDocument
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1697992 13f79535-47bb-0310-9956-ffa450edef68
2015-08-26 19:34:28 +00:00
Dominik Stadler
fd02230c1d Next try for Sonar Maven build: Specify the src-pathes in the various pom.xml files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1697758 13f79535-47bb-0310-9956-ffa450edef68
2015-08-25 19:04:11 +00:00
Dominik Stadler
5a867f39e9 Adjust excludes after adjusting multiple HeaderFooterRecord instances
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1697602 13f79535-47bb-0310-9956-ffa450edef68
2015-08-25 08:32:41 +00:00
Dominik Stadler
50687e782b Refactor BaseXLSIteratingTest into a Parameterized test to better show which files failed
Simplify exclusion handling
Exclude testEXCEL_3.xls and testEXCEL_4.xls in two tests, not sure why this worked before?!

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1697601 13f79535-47bb-0310-9956-ffa450edef68
2015-08-25 08:30:49 +00:00
Dominik Stadler
97fa448a2c Allow multiple instances of HeaderFooterRecord in CustomViewSettingsRecordAggregate similar to ChartSubstreamRecordAggreagte in order to read sample 49931.xls correctly after re-saving it with HSSFWorkbook
Improve error output


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1697600 13f79535-47bb-0310-9956-ffa450edef68
2015-08-25 08:28:54 +00:00
Dominik Stadler
868f3209e3 Try to specify list of sources in Sonar-Run to look at the SVN-Sources, not the copied ones because of our custom Maven build.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1697581 13f79535-47bb-0310-9956-ffa450edef68
2015-08-25 07:06:51 +00:00
Andreas Beeker
cd536720dd common sl: reworked and unified generics definitions
made various methods available through common sl
added createTextBox,AutoShape,... methods to ShapeContainers
hslf tables created by poi, will be identified as such when the file is read again

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1697515 13f79535-47bb-0310-9956-ffa450edef68
2015-08-24 23:15:14 +00:00
Nick Burch
0d7476e130 Tweak error message to make clear that we really need a file showing the problem
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1697502 13f79535-47bb-0310-9956-ffa450edef68
2015-08-24 21:20:01 +00:00
Nick Burch
d662021baf Javadoc tweak
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1697462 13f79535-47bb-0310-9956-ffa450edef68
2015-08-24 17:55:57 +00:00
Dominik Stadler
639b847d6e Reduce required memory in tests by not actually creating all the rows/cells when verifying the max number of cellstyles. Hopefully this will avoid the OOMs that we see in various CI environments currently while still verifying the limits correctly.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1697326 13f79535-47bb-0310-9956-ffa450edef68
2015-08-24 08:12:01 +00:00
Dominik Stadler
2d677beac8 Specify the amount of memory for OOXMLLite as different environments fail sometimes currently and it should make the build more reproducible if we state how much memeory we want
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1697233 13f79535-47bb-0310-9956-ffa450edef68
2015-08-23 18:10:01 +00:00
Dominik Stadler
7851601247 Add empty.pptx to excludes in rat-check
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1697232 13f79535-47bb-0310-9956-ffa450edef68
2015-08-23 18:09:56 +00:00
Andreas Beeker
68890d022a Move security schemas to security module
Fork xmlbeans plugin and run with more memory depending on 32/64bit runtime

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696874 13f79535-47bb-0310-9956-ffa450edef68
2015-08-20 23:06:00 +00:00
Dominik Stadler
39163eccff Eclipse warnings, code formatting, missing @Overrides, Javadoc, missing close(), ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696794 13f79535-47bb-0310-9956-ffa450edef68
2015-08-20 14:28:39 +00:00
Dominik Stadler
8e738cac68 Sonar Maven build:
* Try to provide more memory for the unit test runs as some unit tests create large spreadsheets now
* svn-ignore one more directory

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696711 13f79535-47bb-0310-9956-ffa450edef68
2015-08-20 06:33:02 +00:00
Dominik Stadler
f828ff1554 Somehow the Date formatting via SimpleDateFormatter fails on some CI machines, don't rely on this to avoid test-failures due to timezones/locales but rather compare the date directly.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696710 13f79535-47bb-0310-9956-ffa450edef68
2015-08-20 06:29:48 +00:00
Nick Burch
cd988b9c2e Patch from Javen ONeal from bug #58254 - CellFormatResult.text should check for nulls as per the javadoc
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696638 13f79535-47bb-0310-9956-ffa450edef68
2015-08-19 18:00:31 +00:00
Dominik Stadler
c275dea88c POI Bug 58260: Fix checks for limit on number of styles in XSSF/SXSSF and fix having more than 32k styles in SXSSF workbooks
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696586 13f79535-47bb-0310-9956-ffa450edef68
2015-08-19 13:36:08 +00:00
Dominik Stadler
a6caec985c Add additional checks to narrow down why this test fails when run via Maven
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696584 13f79535-47bb-0310-9956-ffa450edef68
2015-08-19 13:28:23 +00:00
Dominik Stadler
580171fe27 Adjust excludes to make the output a bit cleaner in OOXMLLite and also look in the superclass for @Test annotations to include one additional unit-test that we missed currently.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696577 13f79535-47bb-0310-9956-ffa450edef68
2015-08-19 13:03:05 +00:00
David North
2af2fa28c2 Improve ReadOnlySharedStringsTable to cope gracefully with an empty SST part.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58262

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696559 13f79535-47bb-0310-9956-ffa450edef68
2015-08-19 11:10:13 +00:00
Dominik Stadler
1e45197f59 * Adjust reported text when a Zip-Bomb is detected to allow to quickly see why it happened
* Fail only with inflation ratio lower than the min, not equals, to behave as documented
* Add getters to be able to temporarily adjust the limits for unit tests
* Allow lower inflation ratio in OOXMLPrettyPrint as this is a dev-only tool

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696556 13f79535-47bb-0310-9956-ffa450edef68
2015-08-19 10:57:19 +00:00
David North
5706c2ac9b Make intersection formulae work in XSSF. Patch from Matt Hillsdon plus additional tests.
https://bz.apache.org/bugzilla/show_bug.cgi?id=52111

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696549 13f79535-47bb-0310-9956-ffa450edef68
2015-08-19 10:10:08 +00:00
Dominik Stadler
badd478547 Add one unit-test for a different way of calculating workdays to see if this also triggers test failures in Sonar Maven runs which currently fail for test-case TestWorkdayFunction
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696498 13f79535-47bb-0310-9956-ffa450edef68
2015-08-18 20:24:07 +00:00
Dominik Stadler
85d45501c9 Add more of the xsds to the Sonar Maven ooxml-schema pom.xml to try to make the Sonar Maven run finally run again.
svn-ignore two more generated src-directories

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696492 13f79535-47bb-0310-9956-ffa450edef68
2015-08-18 20:05:58 +00:00
Dominik Stadler
c83a211b60 Set some svn-ignores for generated files and directories
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696485 13f79535-47bb-0310-9956-ffa450edef68
2015-08-18 19:07:39 +00:00
Nick Burch
152b0d1e6d Comments, imports and warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696436 13f79535-47bb-0310-9956-ffa450edef68
2015-08-18 14:59:52 +00:00
Nick Burch
91ed79222b Fix indents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696432 13f79535-47bb-0310-9956-ffa450edef68
2015-08-18 14:49:38 +00:00
Nick Burch
96a2062e6e Patch from Javen ONeal from bug #58253 - CellReference upper-case check for #REF!, and code readability + javadoc improvements
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696430 13f79535-47bb-0310-9956-ffa450edef68
2015-08-18 14:46:01 +00:00
Nick Burch
a92c078d18 Fix indents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696429 13f79535-47bb-0310-9956-ffa450edef68
2015-08-18 14:34:52 +00:00
Nick Burch
3bde975db7 Patch from Javen ONeal from bug #58252 - More CellReference unit testing coverage
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696427 13f79535-47bb-0310-9956-ffa450edef68
2015-08-18 14:32:53 +00:00
Dominik Stadler
873bdb687c Use more permsize when running ooxml-lite as it seems to reach the default limit now
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696359 13f79535-47bb-0310-9956-ffa450edef68
2015-08-18 05:57:03 +00:00
Dominik Stadler
415d494631 Adjust dependencies to make target compile-ooxml-xsds run standalone and use init instead of check-jars,fetch-jars
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696358 13f79535-47bb-0310-9956-ffa450edef68
2015-08-18 05:12:43 +00:00
Andreas Beeker
61a491dca9 sonar xmlbeans fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696355 13f79535-47bb-0310-9956-ffa450edef68
2015-08-18 01:16:26 +00:00
Dominik Stadler
0377dbbb3e Bug 54938: Throw InvalidFormatException as documented instead of IllegalArgumentException in WorkbookFactory.create()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696338 13f79535-47bb-0310-9956-ffa450edef68
2015-08-17 20:54:32 +00:00
Andreas Beeker
633eb964b4 Update to 3.13-SNAPSHOT
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696179 13f79535-47bb-0310-9956-ffa450edef68
2015-08-16 22:54:18 +00:00
Dominik Stadler
0345110611 Try to make Sonar builds run again: add missing dependency, add ooxml-schema-security, don't depend on dir test-data and build-directory directly, don't override a POILogger that is set via System Properties
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696165 13f79535-47bb-0310-9956-ffa450edef68
2015-08-16 20:51:40 +00:00
Andreas Beeker
d90309db4e Move and rename hslf line because of ambiguity with common sl line
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696095 13f79535-47bb-0310-9956-ffa450edef68
2015-08-15 20:43:51 +00:00
Andreas Beeker
5827cee62d FindBugs - DLS_DEAD_LOCAL_STORE
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696050 13f79535-47bb-0310-9956-ffa450edef68
2015-08-15 13:05:00 +00:00