Commit Graph

5835 Commits

Author SHA1 Message Date
Dominik Stadler
9bf1bf60b2 Bug 57200: Do not try to delete the poifiles-tempdir as it can interfere when multiple applications are using SXSSF on the same machine.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734719 13f79535-47bb-0310-9956-ffa450edef68
2016-03-12 16:56:33 +00:00
Dominik Stadler
f1a476d83a Fix bug 56549: correctly calculate char index ranges for HWPF in the TextPieceTable
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734718 13f79535-47bb-0310-9956-ffa450edef68
2016-03-12 16:56:26 +00:00
Andreas Beeker
8e36872c48 #59170 - Remove deprecated classes (POI 3.15) - *Workbook.setRepeatingRowsAndColumns()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734701 13f79535-47bb-0310-9956-ffa450edef68
2016-03-12 13:33:53 +00:00
Dominik Stadler
2b28cd97a3 Apply patch to fix bug 57495: getTableArray method can not get 0 pos table
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734694 13f79535-47bb-0310-9956-ffa450edef68
2016-03-12 11:45:34 +00:00
Dominik Stadler
06083f85f4 Refactor some common code from the various Document-Factories into a helper class
Fix a potential file-handle-leak for password protected workbooks or slideshows

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734691 13f79535-47bb-0310-9956-ffa450edef68
2016-03-12 11:37:32 +00:00
Dominik Stadler
6d97ae7083 Fix some cases where POI itself or the tests leaked file-handles
Also fix some IntelliJ warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734690 13f79535-47bb-0310-9956-ffa450edef68
2016-03-12 11:37:22 +00:00
Dominik Stadler
128a991f9c Findbugs fixes
OldExcelExtractor could leak file handles in case of exceptions
Free file handles in POIFSDump, add unit-test for POIFSDump
Add a Findbugs exclude and adjust findbugs-ant slightly

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734689 13f79535-47bb-0310-9956-ffa450edef68
2016-03-12 11:37:12 +00:00
Dominik Stadler
b1bc13c26f Mark duplicated RecordFormatException as deprecated to be able to remove it at some point in the future
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734688 13f79535-47bb-0310-9956-ffa450edef68
2016-03-12 11:36:56 +00:00
Dominik Stadler
b989e4f5a8 Enable some tests that are ignored, actually run green and did not have any comment why they were ignored in the first place
Fix some compiler warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734687 13f79535-47bb-0310-9956-ffa450edef68
2016-03-12 11:36:50 +00:00
Dominik Stadler
8c508d89b0 Add test for bug 59098 which shows that this is fixed in 3.14.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734686 13f79535-47bb-0310-9956-ffa450edef68
2016-03-12 11:36:43 +00:00
Andreas Beeker
7d6be0ff54 #59170 - Remove deprecated classes (POI 3.15) - org.apache.poi.hssf/ss.util.Region
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734651 13f79535-47bb-0310-9956-ffa450edef68
2016-03-12 00:17:16 +00:00
Andreas Beeker
0776e32108 sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734641 13f79535-47bb-0310-9956-ffa450edef68
2016-03-11 23:14:09 +00:00
Andreas Beeker
630bdd0f15 sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734339 13f79535-47bb-0310-9956-ffa450edef68
2016-03-10 00:32:33 +00:00
Andreas Beeker
1b9523898d sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734337 13f79535-47bb-0310-9956-ffa450edef68
2016-03-10 00:20:34 +00:00
Andreas Beeker
e2fc2822a6 Remove a superfluous/bloated log function, which String.format can do better and is only used once ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734310 13f79535-47bb-0310-9956-ffa450edef68
2016-03-09 20:57:26 +00:00
Nick Burch
9090741226 More helpful exception message if POIFS is given a raw XML file (eg an Office 2003 XML file), plus tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734215 13f79535-47bb-0310-9956-ffa450edef68
2016-03-09 10:57:52 +00:00
Andreas Beeker
9f47700711 #59058 - OOM when parsing docx after OPCPackage.open with File but not with InputStream (TIKA-1866)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734184 13f79535-47bb-0310-9956-ffa450edef68
2016-03-09 01:25:02 +00:00
Andreas Beeker
3a328aa220 #57031 - Out of Memory when extracting text from attached files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734182 13f79535-47bb-0310-9956-ffa450edef68
2016-03-09 00:41:02 +00:00
Dominik Stadler
e444b4b01a Fix source rebuilding verification after resulting binaries in dist-folder changed
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1733878 13f79535-47bb-0310-9956-ffa450edef68
2016-03-07 08:32:11 +00:00
Nick Burch
ea9169b3c4 Comment and Javadoc updates
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1733119 13f79535-47bb-0310-9956-ffa450edef68
2016-03-01 18:11:14 +00:00
Andreas Beeker
261ef4934c #59056 - Render individual slideshow shapes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732974 13f79535-47bb-0310-9956-ffa450edef68
2016-02-29 23:59:49 +00:00
Andreas Beeker
e5baa15b25 Fix NPE of regression tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732972 13f79535-47bb-0310-9956-ffa450edef68
2016-02-29 23:36:58 +00:00
Dominik Stadler
4ad3d7b35a Exclude file for bug 59074 for some more tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732783 13f79535-47bb-0310-9956-ffa450edef68
2016-02-28 19:40:25 +00:00
Andreas Beeker
a7ca3d19ae find bugs fix - WMF_HEADER_MAGIC isn't final but should be
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732753 13f79535-47bb-0310-9956-ffa450edef68
2016-02-28 15:24:14 +00:00
Dominik Stadler
2fa065d96c Also mark the file for bug 59074 as expected-failure for integration testing
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732620 13f79535-47bb-0310-9956-ffa450edef68
2016-02-27 10:23:53 +00:00
Dominik Stadler
da1879c1b2 Bug 57914: Provide a better error message for OOXML strict format which we do not support yet.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732619 13f79535-47bb-0310-9956-ffa450edef68
2016-02-27 10:23:46 +00:00
Nick Burch
62b5b0d874 #59074 More helpful exception if Excel 1-95 files are given to ExtractorFactory
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732587 13f79535-47bb-0310-9956-ffa450edef68
2016-02-26 23:56:31 +00:00
Nick Burch
856261f4d0 Refactor out the POIFS directory entry name for Excel 1-95 entries, and have ExtractorFactory detect (but not support) these old files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732583 13f79535-47bb-0310-9956-ffa450edef68
2016-02-26 23:43:59 +00:00
Nick Burch
1cbcfbe026 Fix inconsistent indents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732580 13f79535-47bb-0310-9956-ffa450edef68
2016-02-26 23:32:54 +00:00
Nick Burch
0b8283b37c Refactor to pull out the list of Excel 97+ directory entry names to a common place, avoiding duplication. Also starts on unit testing #59074
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732579 13f79535-47bb-0310-9956-ffa450edef68
2016-02-26 23:32:17 +00:00
Andreas Beeker
41d693fe15 Regression fixes for H/XSLF and HWMF
see http://apache-poi.1045710.n5.nabble.com/3-14-beta-2-3-14-final-tt5721829.html

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732236 13f79535-47bb-0310-9956-ffa450edef68
2016-02-24 22:43:51 +00:00
Dominik Stadler
161ef55132 Bug 47245: Comment out check and exception in case row-records are missing for some cells as it seems POI is handling this gracefully and LibreOffice/Excel are as well
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732235 13f79535-47bb-0310-9956-ffa450edef68
2016-02-24 22:39:11 +00:00
Nick Burch
d35942ca52 #59021 Namespace aware processing fix for ReadOnlySharedStringsTable, to match the one recently added to XSSFSheetXMLHandler
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731986 13f79535-47bb-0310-9956-ffa450edef68
2016-02-23 22:24:09 +00:00
Nick Burch
194fdfe162 Pull out two more XSSF namespace definitions as re-usable constants
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731980 13f79535-47bb-0310-9956-ffa450edef68
2016-02-23 22:16:54 +00:00
Nick Burch
094e3f68e6 Pull out http://schemas.openxmlformats.org/spreadsheetml/2006/main to a re-used constant
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731975 13f79535-47bb-0310-9956-ffa450edef68
2016-02-23 22:10:20 +00:00
Nick Burch
c58e4fe96c Patch from Jim King from bug #57989 - XSSFChart support for setting chart titles, plus get+set unit tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731566 13f79535-47bb-0310-9956-ffa450edef68
2016-02-21 21:17:23 +00:00
Dominik Stadler
0f10be0ca4 One more possible resource leak when creating the TextExtractor fails with a RuntimeException or one of the named exceptions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731561 13f79535-47bb-0310-9956-ffa450edef68
2016-02-21 20:42:05 +00:00
Dominik Stadler
10f46da1ae Include stacktrace of inner exception when block-positions are invalid in POIFSFileSystem
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731560 13f79535-47bb-0310-9956-ffa450edef68
2016-02-21 20:41:56 +00:00
Tim Allison
bc716a2796 POI 59030 fix NPE in XWPFTableCell's getVerticalAlignment via Prasad Babu
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731257 13f79535-47bb-0310-9956-ffa450edef68
2016-02-19 15:46:26 +00:00
Javen O'Neal
2cab09db04 bug 58896: comment out time-dependent test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731101 13f79535-47bb-0310-9956-ffa450edef68
2016-02-18 17:53:13 +00:00
Nick Burch
20777db2e7 Javadoc fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731047 13f79535-47bb-0310-9956-ffa450edef68
2016-02-18 11:16:11 +00:00
Javen O'Neal
7bb1a1bb22 move trackColumnsForAutoSizingIfSXSSF into ITestDataProvider, replace ITestDataProvider.trackColumnsForAutosizing(Sheet, int...) with ITestDataProvider.trackAllColumnsForAutosizing(Sheet) to avoid cluttering unit tests with specific columns that will be autosized
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730999 13f79535-47bb-0310-9956-ffa450edef68
2016-02-18 04:05:45 +00:00
Javen O'Neal
57ebf6b133 bug 58896: add unit test to time Sheet.autoSizeColumn
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730997 13f79535-47bb-0310-9956-ffa450edef68
2016-02-18 03:33:25 +00:00
Javen O'Neal
5e52b6f4e9 avoid redundant null check
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730994 13f79535-47bb-0310-9956-ffa450edef68
2016-02-18 02:03:11 +00:00
Tim Allison
9e46ee937c 59021 -- fix content extraction from namespaced elements in XSSFEventBasedExcelExtractor
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730992 13f79535-47bb-0310-9956-ffa450edef68
2016-02-18 01:49:59 +00:00
Javen O'Neal
c80fa0c870 bug 56345: reject single-cell merged regions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730991 13f79535-47bb-0310-9956-ffa450edef68
2016-02-18 01:33:14 +00:00
Dominik Stadler
5093542774 Add test which verifies that bug 52684 is not a problem (any more)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730948 13f79535-47bb-0310-9956-ffa450edef68
2016-02-17 21:35:22 +00:00
Javen O'Neal
3cb72bfa7b bug 58339: patch from Patrick Zimmermann to allow OFFSET() to accept missing optional width or height parameters
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730606 13f79535-47bb-0310-9956-ffa450edef68
2016-02-15 20:27:59 +00:00
Dominik Stadler
4aeff3f0ac Tried to reproduce bug 55476, but could not, added unit test anyway
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730598 13f79535-47bb-0310-9956-ffa450edef68
2016-02-15 19:16:45 +00:00
Nick Burch
86153c0ea6 Add details of the ignored errors where the HSSF spec provides a good description, and a bit more refactoring. #56892
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730543 13f79535-47bb-0310-9956-ffa450edef68
2016-02-15 14:58:16 +00:00