Commit Graph

1291 Commits

Author SHA1 Message Date
Nick Burch
1c693babb8 Fix inconsistent whitespace/indents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678188 13f79535-47bb-0310-9956-ffa450edef68
2015-05-07 13:08:15 +00:00
Nick Burch
9fd1832753 Start on XWPFStyles support for document default styles
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678187 13f79535-47bb-0310-9956-ffa450edef68
2015-05-07 13:07:00 +00:00
Nick Burch
9a755850e9 Begin on test for going from xwpf text to style
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678179 13f79535-47bb-0310-9956-ffa450edef68
2015-05-07 12:37:43 +00:00
Dominik Stadler
ea27ddf601 Try to fix flaky test by waiting for a switch of the second to ensure that we have the same timestamps in the two workbooks that we compare byte-wise in this test.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1677950 13f79535-47bb-0310-9956-ffa450edef68
2015-05-06 08:42:28 +00:00
Andreas Beeker
02bbe3b566 OOM fix for gump run
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1677913 13f79535-47bb-0310-9956-ffa450edef68
2015-05-05 23:51:10 +00:00
Tim Allison
8bfc6056c8 POI-57889 prevent NPE with on some documents with XWPFParagraph's getNumFmt() and add some other classes to enable calculation of paragraph numbers
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1677723 13f79535-47bb-0310-9956-ffa450edef68
2015-05-05 01:39:16 +00:00
Nick Burch
e9340cc1ba If an empty stream or file is given to WorkbookFactory.create, give a more informative exception - EmptyFileException
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1677562 13f79535-47bb-0310-9956-ffa450edef68
2015-05-04 09:15:48 +00:00
Andreas Beeker
02e70fdbfe fixed HSLF text handling
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/common_sl@1677496 13f79535-47bb-0310-9956-ffa450edef68
2015-05-03 23:42:42 +00:00
Nick Burch
c8f8cde62d Patch from Mark Olesen from bug #57552: Sort PackagePart returns from OPCPackage by name considering numbers in filenames, so Image10.png comes after Image9.png, fixing problems with XSLF adding 10+ images to a slide
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1677373 13f79535-47bb-0310-9956-ffa450edef68
2015-05-03 08:47:50 +00:00
Nick Burch
3543d1a553 Avoid short wrapping on cell styles and formats > 32,767 in XSSF - format supports up to 64,000 of them #57880
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1677371 13f79535-47bb-0310-9956-ffa450edef68
2015-05-03 08:10:07 +00:00
Nick Burch
16d2e7881a Ensure consistent ordering when writing out formats following changes in r1677368
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1677370 13f79535-47bb-0310-9956-ffa450edef68
2015-05-03 07:59:18 +00:00
Nick Burch
c76db74929 Fix inconsistent indents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1677369 13f79535-47bb-0310-9956-ffa450edef68
2015-05-03 07:56:40 +00:00
Nick Burch
602832bda6 Somewhat speed up creating data formats with large counts, and add maximum format/style count checking. #57884
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1677368 13f79535-47bb-0310-9956-ffa450edef68
2015-05-03 07:53:09 +00:00
Dominik Stadler
31adc2f269 Add verifying testcase for Bug 57423 and Bug 55752, both are still not solved, though.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1676965 13f79535-47bb-0310-9956-ffa450edef68
2015-04-30 11:54:13 +00:00
Dominik Stadler
3275263c2b Remove Eclipse warnings in tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1676903 13f79535-47bb-0310-9956-ffa450edef68
2015-04-30 05:58:15 +00:00
Nick Burch
925d32e2c1 Allow WorkbookFactory.create to open xlsx files protected with the default password
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1676853 13f79535-47bb-0310-9956-ffa450edef68
2015-04-29 20:36:13 +00:00
Nick Burch
9f196708d4 #57593 Complete create overloading in WorkbookFactory to take passwords
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1676847 13f79535-47bb-0310-9956-ffa450edef68
2015-04-29 20:19:38 +00:00
Nick Burch
73aa2c9ee3 Fix inconsistent indents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1676845 13f79535-47bb-0310-9956-ffa450edef68
2015-04-29 20:13:42 +00:00
Nick Burch
2889cabaed #57593 Begin adding overloaded WorkbookFactory.create methods which take the spreadsheet password
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1676843 13f79535-47bb-0310-9956-ffa450edef68
2015-04-29 20:12:18 +00:00
Nick Burch
fb4bf25259 Use a constant for the name of the OOXML encrypted package node
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1676838 13f79535-47bb-0310-9956-ffa450edef68
2015-04-29 19:47:35 +00:00
Nick Burch
b3bd87d3c2 When removing a SXSSF sheet, ensure temp files associated with it are disposed of #57666
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1676833 13f79535-47bb-0310-9956-ffa450edef68
2015-04-29 19:28:26 +00:00
Nick Burch
b2a1862f19 Patch from Jon Scharff from bug #57826 - If a XSSF shape has a buFont but no bullet character, mirror Excel and treat as un-bulleted
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1676831 13f79535-47bb-0310-9956-ffa450edef68
2015-04-29 19:21:37 +00:00
Nick Burch
c029154424 Add a (disabled) unit test showing the incorrect ordering problem of parts - bug #57552
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1676810 13f79535-47bb-0310-9956-ffa450edef68
2015-04-29 18:31:12 +00:00
Andreas Beeker
e6413c3fe7 committing intermediate results - hslf is mostly migrated to common interface - junit tests partly fail - still a few compile errors - xslf drawing works - hslf drawing is not yet tested
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/common_sl@1676365 13f79535-47bb-0310-9956-ffa450edef68
2015-04-27 20:13:43 +00:00
Dominik Stadler
4c96affb9a Add unit-test which verifies that fill and alignment styles are applied and read back in correctly.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1676276 13f79535-47bb-0310-9956-ffa450edef68
2015-04-27 14:29:59 +00:00
Nick Burch
3c1d9756ba Fix some inconsistent whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1675748 13f79535-47bb-0310-9956-ffa450edef68
2015-04-24 02:20:57 +00:00
Nick Burch
b681f4fb3a #57642 Fix setSheetName with ISERROR on XSSF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1675745 13f79535-47bb-0310-9956-ffa450edef68
2015-04-24 02:13:07 +00:00
Nick Burch
a5846f0f66 #57829 Avoid XmlValueDisconnectedException when removing a XWPFRun from a XWPFParagraph by removing from IRuns as well
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1675738 13f79535-47bb-0310-9956-ffa450edef68
2015-04-24 01:29:10 +00:00
Dominik Stadler
f5c3a2a62c Print out slightly more on test-failure for a unit tests which fails intermittently
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1675266 13f79535-47bb-0310-9956-ffa450edef68
2015-04-22 06:49:38 +00:00
Dominik Stadler
d1385bbe1b Fix bug 57828, shifting more than one commit per row did not work.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1674975 13f79535-47bb-0310-9956-ffa450edef68
2015-04-20 20:13:33 +00:00
Dominik Stadler
dfe1c74dff Fix some Eclipse warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1674965 13f79535-47bb-0310-9956-ffa450edef68
2015-04-20 19:17:24 +00:00
Dominik Stadler
5118bdb128 Avoid possible NullPointerException seen with some powerpoint files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1674958 13f79535-47bb-0310-9956-ffa450edef68
2015-04-20 18:26:39 +00:00
Dominik Stadler
ca8e3c465e Avoid NullPointerException if an image cannot be read
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1674952 13f79535-47bb-0310-9956-ffa450edef68
2015-04-20 18:10:43 +00:00
Dominik Stadler
37a7733b45 Add missing nested Exception in thrown Exception
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1674618 13f79535-47bb-0310-9956-ffa450edef68
2015-04-19 12:35:19 +00:00
Dominik Stadler
570819e4f6 Bug 56579: Throw exception if max string length of 32767 chars is exceeded in XSSF and SXSSF.
Add verification testcase for bug 57008.
Move some unit tests to the Bsae-Test-Class to verify things for all SS-implementations.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1671096 13f79535-47bb-0310-9956-ffa450edef68
2015-04-03 15:55:21 +00:00
Dominik Stadler
b173dc11d0 XMLPrettyPrint: Don't try to pretty-print non-XML files and print out which file from the ooxml-file fails to parse
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1671095 13f79535-47bb-0310-9956-ffa450edef68
2015-04-03 15:54:59 +00:00
Andreas Beeker
652211b8d2 Snapshot commit - still lots of errors, xslf rendering works, started work on hslf
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/common_sl@1667902 13f79535-47bb-0310-9956-ffa450edef68
2015-03-19 23:44:23 +00:00
Dominik Stadler
0216a881f7 Bug 56017: fix shifting comments with shifted rows and move some more tests into the base classes to run them against XSSF, SXSSF and HSSF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1666843 13f79535-47bb-0310-9956-ffa450edef68
2015-03-15 20:52:55 +00:00
Dominik Stadler
30d20582af Bug 56295: Fix cloning of styles across workbooks and handling of default value of attribute applyFill
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1666736 13f79535-47bb-0310-9956-ffa450edef68
2015-03-14 19:32:28 +00:00
Dominik Stadler
7bf9b90fb2 Remove some findbugs warnings about missing close of streams, use existing IOUtils.copy() to copy from one stream to another
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1666683 13f79535-47bb-0310-9956-ffa450edef68
2015-03-14 13:18:43 +00:00
Nick Burch
ff737c5df4 Detect OOXML-strict, and give more helpful exceptions for them
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1666525 13f79535-47bb-0310-9956-ffa450edef68
2015-03-13 17:39:47 +00:00
Nick Burch
48e3a2e56a Fix inconsistent indents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1666518 13f79535-47bb-0310-9956-ffa450edef68
2015-03-13 17:17:47 +00:00
Nick Burch
a62be1da0c More relation types
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1666517 13f79535-47bb-0310-9956-ffa450edef68
2015-03-13 17:17:27 +00:00
Nick Burch
ace2354d6c Stub unit tests for #57699
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1666510 13f79535-47bb-0310-9956-ffa450edef68
2015-03-13 16:46:15 +00:00
Dominik Stadler
97ce24a440 Verify that document from bug 56392 works
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1666003 13f79535-47bb-0310-9956-ffa450edef68
2015-03-11 20:39:18 +00:00
Dominik Stadler
b7c14b3a8f Bug 56467: Fix cloning of sheets with pictures
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1665959 13f79535-47bb-0310-9956-ffa450edef68
2015-03-11 18:24:49 +00:00
Dominik Stadler
51fdb9434d Add testcase which verifies that bug 56820 was solved by some other fix already
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1665957 13f79535-47bb-0310-9956-ffa450edef68
2015-03-11 18:24:32 +00:00
Nick Burch
c5ea89b2bc Fix inconsistent indents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1665933 13f79535-47bb-0310-9956-ffa450edef68
2015-03-11 16:30:02 +00:00
Nick Burch
555e42f4de Give a more helpful exception if a Visio VSDX ooxml file is passed to ExtractorFactory
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1665929 13f79535-47bb-0310-9956-ffa450edef68
2015-03-11 16:17:41 +00:00
Andreas Beeker
a0070048fe committing intermediate results - xslf now compiles - hslf needs to be migrated to common interface - drawing is not yet tested
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/common_sl@1664935 13f79535-47bb-0310-9956-ffa450edef68
2015-03-07 23:35:40 +00:00
Nick Burch
aff5642202 Patch from tntim96 from bug #56799 - Include CTTblGrid in the smaller poi-ooxml-schemas jar
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1664236 13f79535-47bb-0310-9956-ffa450edef68
2015-03-05 06:31:18 +00:00
Dominik Stadler
9ede62441a Bug 57165: also verify that createSheet() had the same problem and is also fixed now
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1663154 13f79535-47bb-0310-9956-ffa450edef68
2015-03-01 20:01:43 +00:00
Dominik Stadler
e13374683a Bug 57165: Avoid PartAlreadyExistsException when removing/cloning sheets
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1663153 13f79535-47bb-0310-9956-ffa450edef68
2015-03-01 19:56:56 +00:00
Dominik Stadler
54bbd99ce4 Add missing close and handle theme-pptx in ExtractorFactory. Add creating slide-bitmaps to PPTX integration test.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1663137 13f79535-47bb-0310-9956-ffa450edef68
2015-03-01 17:50:16 +00:00
Nick Burch
2ccd6db57e More missing core properties unit tests, covering read-write without checks, and encryption
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1662972 13f79535-47bb-0310-9956-ffa450edef68
2015-02-28 17:37:11 +00:00
Nick Burch
3ba7b59afc Ensure that the core properties are there before saving them, in case they have not yet been lazy-created
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1662971 13f79535-47bb-0310-9956-ffa450edef68
2015-02-28 17:36:19 +00:00
Dominik Stadler
f043c44017 * Verify some more Text-Extraction features as part of integration tests, fix some NullPointerExceptions that showed up now because the event-based extraction does not have a Document available
* Also handle a XLSX which does not have row-numbers in the sheet-xml. Excel can read it so it makes sense to also allow to read it in the XSSFSheetXMLHandler 
* Remove some Eclipse warnings in test-code

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1662691 13f79535-47bb-0310-9956-ffa450edef68
2015-02-27 14:58:41 +00:00
Dominik Stadler
e86ed72c2b * Add text-extraction verification to integration-tests via a new abstract base FileHandler
* Fix NullPointerException found in some documents when running against the test-data
* Add support for extracting text from Dir-Entries WORKBOOK and BOOK to support some old/strangely formatted XLS files.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1662652 13f79535-47bb-0310-9956-ffa450edef68
2015-02-27 09:59:14 +00:00
Dominik Stadler
7dfcd6c684 Adjust tests and fix small typo
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1662650 13f79535-47bb-0310-9956-ffa450edef68
2015-02-27 09:52:57 +00:00
Dominik Stadler
b57a4f04e3 Adjust to provide full exception information for cases where we catch unexpected exceptions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1662447 13f79535-47bb-0310-9956-ffa450edef68
2015-02-26 13:43:10 +00:00
Nick Burch
66afa6d09b Update Javadocs to refer to the fact that WorkbookFactory.create will throw a EncryptedDocumentException if the file is password protected
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1662074 13f79535-47bb-0310-9956-ffa450edef68
2015-02-24 18:20:02 +00:00
Nick Burch
7ee6e41e59 Fix inconsistent indents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1661912 13f79535-47bb-0310-9956-ffa450edef68
2015-02-24 12:11:34 +00:00
Nick Burch
b6a88f09c8 Patch from rojotek from github-18 - Handle documents with a picture-only header
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1661908 13f79535-47bb-0310-9956-ffa450edef68
2015-02-24 12:09:30 +00:00
Nick Burch
d5065b1742 Change from XMLEventFactory.newFactory to XMLEventFactory.newInstance, for IBM JDK Compatibility, fixes #57622
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1661903 13f79535-47bb-0310-9956-ffa450edef68
2015-02-24 12:03:53 +00:00
Dominik Stadler
1bbbd985d4 Bug 57612: Fix checking for proxy/accessible website in TestSignatureInfo
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1661774 13f79535-47bb-0310-9956-ffa450edef68
2015-02-23 20:45:21 +00:00
Nick Burch
327df5cf76 Unit tests for OPC handling of files without a Core Properties part
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1661663 13f79535-47bb-0310-9956-ffa450edef68
2015-02-23 13:21:23 +00:00
Dominik Stadler
04ae3247eb Revert organize imports
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1661327 13f79535-47bb-0310-9956-ffa450edef68
2015-02-21 11:58:45 +00:00
Andreas Beeker
996c9dd93c initial commit - still lots of errors, but I need to switch to a clean trunk for releasing and testing
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/common_sl@1661322 13f79535-47bb-0310-9956-ffa450edef68
2015-02-21 10:56:03 +00:00
Dominik Stadler
fa85c4bbef Use assertArrayEquals() to try to better show why this test fails in some rare cases currently
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1660697 13f79535-47bb-0310-9956-ffa450edef68
2015-02-18 18:47:22 +00:00
Dominik Stadler
ce007f05ee Bug 57459: Add method in SXSSFSheet to directly set row OutLineLevel
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1659785 13f79535-47bb-0310-9956-ffa450edef68
2015-02-14 12:46:16 +00:00
Dominik Stadler
e450b8d5e1 Adjust TestSignatureInfo so junit provides more information if an unexpected exception happens
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1659784 13f79535-47bb-0310-9956-ffa450edef68
2015-02-14 12:46:04 +00:00
Nick Burch
702f8b9ee7 Finish converting ErrorEval to only use the FormulaError constants, and then finish unit test for 57535
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1658190 13f79535-47bb-0310-9956-ffa450edef68
2015-02-08 15:37:14 +00:00
Nick Burch
b1a6afc36a Add a unit test (disabled) for bug #57535 - "Unknown error type: -60" fetching formula error value
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1658186 13f79535-47bb-0310-9956-ffa450edef68
2015-02-08 15:17:47 +00:00
Nick Burch
25385edc38 XWPF implementation of some common Paragraph methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1657717 13f79535-47bb-0310-9956-ffa450edef68
2015-02-05 23:31:59 +00:00
Nick Burch
483982caad Stub a common WP paragraph class, needs uncommenting as XWPF implements/emulates
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1657712 13f79535-47bb-0310-9956-ffa450edef68
2015-02-05 23:20:43 +00:00
Nick Burch
c526206e0d More common HWPF/XWPF interfaces
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1657634 13f79535-47bb-0310-9956-ffa450edef68
2015-02-05 17:35:09 +00:00
Nick Burch
1f2fc6c08b More common XWPF/HWPF character run methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1657631 13f79535-47bb-0310-9956-ffa450edef68
2015-02-05 17:25:02 +00:00
Nick Burch
a351b66fde XWPF double strikethrough, and start on a common interface for HWPF and XWPF character runs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1657624 13f79535-47bb-0310-9956-ffa450edef68
2015-02-05 17:00:08 +00:00
Nick Burch
b25e4ca87d 57482 Handle XSLX files with no shared strings table in read-only mode
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1653825 13f79535-47bb-0310-9956-ffa450edef68
2015-01-22 12:15:59 +00:00
Nick Burch
ca33983388 Unit test from Isao Kadowaki from bug #57482
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1653814 13f79535-47bb-0310-9956-ffa450edef68
2015-01-22 11:45:40 +00:00
Dominik Stadler
eab2c0d20d Add a developer-tool to pretty-print the XMLs in an OOXML file. This makes it easier to compare OOXML files produced by different applications with differeing XML formatting.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1653777 13f79535-47bb-0310-9956-ffa450edef68
2015-01-22 07:24:01 +00:00
Nick Burch
0257c23cae Have ExtractorFactory open OPCPackages from files in read-only mode by default, since writing should never be needed when extracting text
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1652877 13f79535-47bb-0310-9956-ffa450edef68
2015-01-18 23:46:29 +00:00
Nick Burch
df20c0a69b For XSSFSheet, add a getDrawingPatriarch() method alongside the existing createDrawingPatriarch() one
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1652876 13f79535-47bb-0310-9956-ffa450edef68
2015-01-18 23:45:04 +00:00
Nick Burch
c4eb73a28b Test to show that bug #57430 works fine already
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1651314 13f79535-47bb-0310-9956-ffa450edef68
2015-01-13 09:57:46 +00:00
Dominik Stadler
113edb1a76 Adjust Bin2Dec similar to what we did for Hex2Dec in Bug 57196 and fix some smaller problems in the implementation found while adding full unit tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1650654 13f79535-47bb-0310-9956-ffa450edef68
2015-01-09 20:37:11 +00:00
Dominik Stadler
3403bef5a8 Fix Eclipse warnings, provide better error message and adjust javadoc slightly
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1650598 13f79535-47bb-0310-9956-ffa450edef68
2015-01-09 16:52:23 +00:00
Dominik Stadler
c8bf92f963 Bug 57196: Resolve RefEval to it's inner ValueEval in Hex2Dec
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1650597 13f79535-47bb-0310-9956-ffa450edef68
2015-01-09 16:51:02 +00:00
Nick Burch
ed8964594b Swap Exception for Throwable, to skip a wider range of problems (eg GAE) when attempting to set an xml security manager as best we can
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1650290 13f79535-47bb-0310-9956-ffa450edef68
2015-01-08 13:22:50 +00:00
Dominik Stadler
8997d8900d * Add missing close() on streams in ImageUtils.getImageDimension()
* Add some unit tests for CellReference

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1650070 13f79535-47bb-0310-9956-ffa450edef68
2015-01-07 14:36:39 +00:00
Dominik Stadler
f912ecac92 Add reproducer for bug 56655
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1650069 13f79535-47bb-0310-9956-ffa450edef68
2015-01-07 14:34:13 +00:00
Dominik Stadler
5aff4f5a2a Add reproducing testcase for Bug 57294
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649536 13f79535-47bb-0310-9956-ffa450edef68
2015-01-05 14:39:51 +00:00
Dominik Stadler
fa8eae2bfd Move some tests to the base test class where applicapple
Introduce class BaseTestXCell to collect tests for XSSFCell and SXSSFCell that do not work for HSSFCell

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649527 13f79535-47bb-0310-9956-ffa450edef68
2015-01-05 14:03:37 +00:00
Dominik Stadler
c2d82b6005 Update disabled test for bug 54071 to show the root-cause better
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649526 13f79535-47bb-0310-9956-ffa450edef68
2015-01-05 13:48:41 +00:00
Dominik Stadler
8edf70ec8f Add unit tests for XSSFTextRun and TextPainter, slightly more tests for XSSFSheet and enhance unit tests for XWPFParagraph and ExcelAntTest
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649309 13f79535-47bb-0310-9956-ffa450edef68
2015-01-04 10:23:01 +00:00
Dominik Stadler
9794510d33 Improve information in exceptions thrown by XSSFRichTextString and improve unit tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649234 13f79535-47bb-0310-9956-ffa450edef68
2015-01-03 19:30:56 +00:00
Dominik Stadler
2f681f430c Fix copy/paste errors in XSSFSimpleShape, allow unset of insets multiple times and add unit tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649233 13f79535-47bb-0310-9956-ffa450edef68
2015-01-03 19:30:36 +00:00
Dominik Stadler
3bbf57cd27 Fix copy/paste error in XSSFTextParagraph and add unit tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649232 13f79535-47bb-0310-9956-ffa450edef68
2015-01-03 19:29:51 +00:00
Dominik Stadler
302db39cb7 Fix some Eclipse warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649123 13f79535-47bb-0310-9956-ffa450edef68
2015-01-02 21:06:51 +00:00
Dominik Stadler
ffcc20f60e Bug 46898: Convert unit tests for circular references to also run for XSSF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649122 13f79535-47bb-0310-9956-ffa450edef68
2015-01-02 21:04:50 +00:00
Dominik Stadler
12edcc5ed2 Bug 46192: Add methods to query outline level for HSSF and XSSF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649107 13f79535-47bb-0310-9956-ffa450edef68
2015-01-02 20:03:28 +00:00
Dominik Stadler
5c76ccba5b Add missing close() of resources in both production code and tests
Use revert() instead of close() on OCPPackage in some places to not re-write the file unnecessarily.
This should now run tests without leftover file handles when checked with file leak detector and
allows to find newly introduced cases more easily.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648160 13f79535-47bb-0310-9956-ffa450edef68
2014-12-28 09:16:57 +00:00
Dominik Stadler
26585f4e95 Ensure that XSSFWorkbooks contain a BookView, some corrupt ones do not contain this, e.g. ones created by movescound.com
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648158 13f79535-47bb-0310-9956-ffa450edef68
2014-12-28 09:08:58 +00:00
Dominik Stadler
5173eca9ea Fix Eclipse warnings, unnecessary casts, use generics, static access...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648156 13f79535-47bb-0310-9956-ffa450edef68
2014-12-28 09:06:12 +00:00
Andreas Beeker
4bed984c0f Charset.forName() for known encodings makes catching UnknownEncodingException obsolete
Unify UTF-16LE conversion to StringUtil
BugFix for RecordInputStream.readFully in combination with continuing records
BugFix for integration tests - fix pathname for handler/exclude lookup on windows

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648032 13f79535-47bb-0310-9956-ffa450edef68
2014-12-27 01:33:28 +00:00
Dominik Stadler
0c580c8f45 Add a test-suite which performs integration/stress tests which load and handle all stored test files in various ways.
It works by using handlers for each type of file which perform various operations on the files, e.g. loading,
iterating content, modify, ... This will trigger changes which break working with the available test-files and
thus provides another layer of regression testing which hopefully prevents some failures from making it into
releases.

It is runnable via a new ant-target 'test-integration' and also added to the jenkins-target.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647885 13f79535-47bb-0310-9956-ffa450edef68
2014-12-25 09:16:44 +00:00
Andreas Beeker
202aa8177f - Support for Office Binary Document RC4 CryptoAPI Encryption for HSLF
- Support for Office Binary Document RC4 Encryption
- use LittleEndian class in LittleEndianInputStream
- add normalize method for HSLF, to remove edit history, which is also necessary for encryption support
- update PersistDirectoryEntry handling in PersistPtrHolder to recognize groups while serializing
- deprecated PersistPtrHolder.getSlideOffsetDataLocationsLookup() - throws now UnsupportedOperationException,
  as this wasn't used outside the scope of the class and was quite internal logic of PersistPtrHolder


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647867 13f79535-47bb-0310-9956-ffa450edef68
2014-12-25 01:56:29 +00:00
Dominik Stadler
ed60f5cb08 Add comment
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647512 13f79535-47bb-0310-9956-ffa450edef68
2014-12-23 09:26:22 +00:00
Dominik Stadler
95c9b9991a Fix testcases which were not executed before, use tempfile, cleanup, ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647511 13f79535-47bb-0310-9956-ffa450edef68
2014-12-23 09:26:14 +00:00
Dominik Stadler
7ee9ce8388 Fix two Eclipse warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647325 13f79535-47bb-0310-9956-ffa450edef68
2014-12-22 14:56:47 +00:00
Dominik Stadler
83f5683c50 Bug 57373: Fix get/setFirstVisibleTab() for XSSFWorkbook
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647322 13f79535-47bb-0310-9956-ffa450edef68
2014-12-22 14:37:37 +00:00
Dominik Stadler
1db7f3bd3b Bug 57362: Properly initialize chart axis when loading a workbook which already contains a chart.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647317 13f79535-47bb-0310-9956-ffa450edef68
2014-12-22 14:16:23 +00:00
Dominik Stadler
f622530806 Remove iterating over the number of runs for certain XSSFRichTextString operations. If I didn't overlook something, they can directly access the array element anyway. Seems this was some leftover copy/paste stuff.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647315 13f79535-47bb-0310-9956-ffa450edef68
2014-12-22 14:09:55 +00:00
Dominik Stadler
03f846c695 Bug 56511: Add a null-check to ensure that the run actually has a font to not cause a NullPointerException but rather return null as documented
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647308 13f79535-47bb-0310-9956-ffa450edef68
2014-12-22 13:06:58 +00:00
Dominik Stadler
645d2083bf Bug 56550: Defer the initialization of the _classes to when it is actually needed to allow IBM JDK to at least load the class
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647302 13f79535-47bb-0310-9956-ffa450edef68
2014-12-22 12:38:44 +00:00
Dominik Stadler
43ee4e08ca Add missing license header to newly added file
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647294 13f79535-47bb-0310-9956-ffa450edef68
2014-12-22 11:49:43 +00:00
Dominik Stadler
0b6867d1d5 Bug 56644: Fix adding cells if MissingCellPolicy is set to NULL_FOR_BLANK and the last column in a row is empty
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647291 13f79535-47bb-0310-9956-ffa450edef68
2014-12-22 11:11:34 +00:00
Dominik Stadler
181de5f6e5 Bug 56888: XSSFDataValidation ignores "allow blank" read from sheet, assumes true
Add TestSXSSFDataValidation to verify some parts for SXSSF as well

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647276 13f79535-47bb-0310-9956-ffa450edef68
2014-12-22 10:03:32 +00:00
Dominik Stadler
a98c9daa01 Some Eclipse warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647269 13f79535-47bb-0310-9956-ffa450edef68
2014-12-22 09:16:16 +00:00
Dominik Stadler
2d07fa94af Add reproducer for Bug 57165, no fix yet, though...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647265 13f79535-47bb-0310-9956-ffa450edef68
2014-12-22 09:10:01 +00:00
Dominik Stadler
0fdfac62c9 Bug 57171 and 57163: Adjust the active sheet in setSheetOrder() and removeSheet() for both HSSF and XSSF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647264 13f79535-47bb-0310-9956-ffa450edef68
2014-12-22 09:00:18 +00:00
Dominik Stadler
12353bca7f Bug 57236: Add reproducer, although I am not sure if we should and how to fix this...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647254 13f79535-47bb-0310-9956-ffa450edef68
2014-12-22 07:57:03 +00:00
Dominik Stadler
213aa1559b Adjust typos in Javadoc
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647210 13f79535-47bb-0310-9956-ffa450edef68
2014-12-21 21:07:06 +00:00
Nick Burch
3a72ec0aec Patch from Kamil Linek from bug #57071 - 3+ XSSF column label names for pivot tables
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647088 13f79535-47bb-0310-9956-ffa450edef68
2014-12-21 06:20:06 +00:00
Nick Burch
942f8044d9 Patch from Kamil Linek from bug #57063 - XSSF custom column label names for pivot tables
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647087 13f79535-47bb-0310-9956-ffa450edef68
2014-12-21 06:12:20 +00:00
Dominik Stadler
68bb54e06a Bug 57254: XWPF: Correctly build internal list of styles when styles are added
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1646742 13f79535-47bb-0310-9956-ffa450edef68
2014-12-19 14:42:25 +00:00
Dominik Stadler
66de3ced8b Remove unused members,
Fix an Eclipse warning

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1646736 13f79535-47bb-0310-9956-ffa450edef68
2014-12-19 14:36:41 +00:00
Dominik Stadler
fb9295ffb9 Bug 57312: Add check for null value of underline w:val
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1646729 13f79535-47bb-0310-9956-ffa450edef68
2014-12-19 14:29:50 +00:00
Dominik Stadler
51308cd422 Bug 57355: Fix ArrayIndexOutOfBoundsException by removing two unnecessary lines in XSSFSheet.getColumnWidthInPixels()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1645900 13f79535-47bb-0310-9956-ffa450edef68
2014-12-16 10:40:02 +00:00
Andreas Beeker
1460fd33b2 Added workarounds to tests for JDK 6 LineBreakMeasurer bug and handle it
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1644806 13f79535-47bb-0310-9956-ffa450edef68
2014-12-12 01:43:45 +00:00
Andreas Beeker
dbfabda346 close decrypted stream - test for #57296
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1644796 13f79535-47bb-0310-9956-ffa450edef68
2014-12-12 00:06:15 +00:00
Andreas Beeker
f3e4795275 57250 - XMLSlideShow.setSlideOrder() produces corrupted CTSlideIdList
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1643684 13f79535-47bb-0310-9956-ffa450edef68
2014-12-07 15:28:01 +00:00
Andreas Beeker
93dffcb366 XML signatures - ignore line breaks in Office 2007 .rels files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1643415 13f79535-47bb-0310-9956-ffa450edef68
2014-12-05 20:20:23 +00:00
Dominik Stadler
1deed31c23 Include root-cause exception information when constructing ContentTypeManager fails
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1641940 13f79535-47bb-0310-9956-ffa450edef68
2014-11-26 21:11:02 +00:00
Andreas Beeker
9d84f426f3 Don't swallow exceptions on validation
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1641025 13f79535-47bb-0310-9956-ffa450edef68
2014-11-22 01:47:48 +00:00
Andreas Beeker
d3dee868ef the subdir element needs to be included otherwise certain xmlbean operations (e.g. selectPath) can't find the corresponding xmlbeans classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1640846 13f79535-47bb-0310-9956-ffa450edef68
2014-11-21 01:06:39 +00:00
Andreas Beeker
27b0d08d0f Bug 57164 - XSSFDrawing.createCellComment() does not honor dx and dy values passed in
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1639996 13f79535-47bb-0310-9956-ffa450edef68
2014-11-16 14:48:47 +00:00
Andreas Beeker
45fb6c5b18 Picture method to resize with different scales in width and height
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1638623 13f79535-47bb-0310-9956-ffa450edef68
2014-11-12 00:19:00 +00:00
Dominik Stadler
194738dd91 Restore printing out test-failures after switch to JUnit4 execution
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1638179 13f79535-47bb-0310-9956-ffa450edef68
2014-11-11 15:30:34 +00:00
Andreas Beeker
d709edb343 Use Junit4 JUnitCore instead of legacy TestRunner
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1637996 13f79535-47bb-0310-9956-ffa450edef68
2014-11-10 23:46:50 +00:00
Dominik Stadler
9f3e8b4919 Bug 57197: use proxy for TestSignatureInfo if set via environment variables
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1637979 13f79535-47bb-0310-9956-ffa450edef68
2014-11-10 20:37:26 +00:00
Dominik Stadler
3cf7699fde Fix Eclipse warning about generics
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1637978 13f79535-47bb-0310-9956-ffa450edef68
2014-11-10 20:36:54 +00:00
Dominik Stadler
3dd00ab13a Add xmlsec-jar in test-ooxml-lite which is missing after removing ooxml.classpath
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1637718 13f79535-47bb-0310-9956-ffa450edef68
2014-11-09 19:19:02 +00:00
Nick Burch
82ee923858 Patch from hishidama to add Cell.removeHyperlink(). This closes #13 from github
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1637562 13f79535-47bb-0310-9956-ffa450edef68
2014-11-08 13:46:30 +00:00
Nick Burch
e2dd7f27c0 Test from Tim to include PropertyList in poi-ooxml-schemas
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1637548 13f79535-47bb-0310-9956-ffa450edef68
2014-11-08 12:21:27 +00:00
Dominik Stadler
24effccc61 Fail build if test-cases fail in OOXMLLite execution to avoid missing included schema-classes. Also adjust how we look for test-classes so that we print out the ones that we skip with known ones excluded. Also print out skipped inner classes.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1637475 13f79535-47bb-0310-9956-ffa450edef68
2014-11-07 22:33:54 +00:00
Dominik Stadler
62ac7efea6 Slowly start to adjust places in tests where we do not properly close file handles
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1637474 13f79535-47bb-0310-9956-ffa450edef68
2014-11-07 22:33:35 +00:00
Dominik Stadler
b6a3184196 Calling ping is not a good idea as it runs endlessly on some platforms, do a Java connection test instead
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1637370 13f79535-47bb-0310-9956-ffa450edef68
2014-11-07 13:05:57 +00:00
Andreas Beeker
69dc33caf2 another signature ubuntu jdk6 bug fix ... and offline/online handling
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1637283 13f79535-47bb-0310-9956-ffa450edef68
2014-11-07 01:16:21 +00:00
Nick Burch
70177caa04 Try for a more specific failure message on the assert
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1637129 13f79535-47bb-0310-9956-ffa450edef68
2014-11-06 14:54:02 +00:00
Andreas Beeker
21d90606ab another blind sha2 bug fix ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1637005 13f79535-47bb-0310-9956-ffa450edef68
2014-11-05 23:33:33 +00:00