Commit Graph

8537 Commits

Author SHA1 Message Date
Dominik Stadler
d0e3102fd1 Bug 59733: Narrow down testcase some more, after the first shift, removing the first row is sufficient to trigger the problem
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752996 13f79535-47bb-0310-9956-ffa450edef68
2016-07-16 20:52:28 +00:00
Dominik Stadler
52bf709104 Add a test to check for a NullPointerException in XSLFTableCell
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752862 13f79535-47bb-0310-9956-ffa450edef68
2016-07-15 18:24:11 +00:00
Dominik Stadler
ae7ef11c88 Bug 59861: Adjust testcase, it works now for me. Also combine the two TestProper classes into one
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752861 13f79535-47bb-0310-9956-ffa450edef68
2016-07-15 18:24:02 +00:00
Javen O'Neal
9d8b7b33db JDK8 javadocs fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752812 13f79535-47bb-0310-9956-ffa450edef68
2016-07-15 10:13:58 +00:00
Javen O'Neal
064abfa59a replace for-loop over index with for-each loop
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752788 13f79535-47bb-0310-9956-ffa450edef68
2016-07-15 07:41:26 +00:00
Javen O'Neal
6ea74f170d annotate purpose of each PROPER() function test case, add a few more test cases, identify some problems with ß handling
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752786 13f79535-47bb-0310-9956-ffa450edef68
2016-07-15 07:25:16 +00:00
Javen O'Neal
0c3aade7b1 JDK8 javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752781 13f79535-47bb-0310-9956-ffa450edef68
2016-07-15 06:35:21 +00:00
Dominik Stadler
aec95a4491 Function PROPER: Don't use a regular expression syntax that is not available on Android. Actually the use of regular expression in this case was overkill, slow and even incorrect in corner cases, the function can be done without regex easily and runs a bit faster anyway (microBench is down from 4sec to 2s)
Also added a unit-test to ensure the behavior stays the same (except in cases where it needed fixing, e.g. some toUppercase() leads to more than one character which was handled incorrectly)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752779 13f79535-47bb-0310-9956-ffa450edef68
2016-07-15 06:32:45 +00:00
Javen O'Neal
75f5d3afc5 bug 59858: describe why VBA macro reading failed
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752778 13f79535-47bb-0310-9956-ffa450edef68
2016-07-15 06:12:37 +00:00
Javen O'Neal
bb8f614a90 bug 59858: add disabled unit test for bug 59858; file from Brooke
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752776 13f79535-47bb-0310-9956-ffa450edef68
2016-07-15 05:28:29 +00:00
David North
a7d210932a "cannot not" presumably means "cannot"
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752452 13f79535-47bb-0310-9956-ffa450edef68
2016-07-13 16:40:47 +00:00
Dominik Stadler
7beffbe3e3 Fix name of new OLE2ScratchpadExtractorFactory
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752304 13f79535-47bb-0310-9956-ffa450edef68
2016-07-12 15:40:18 +00:00
Nick Burch
439fc2e92d Remove un-used imports
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752229 13f79535-47bb-0310-9956-ffa450edef68
2016-07-11 23:00:40 +00:00
Nick Burch
90e8b0f5b0 Last bit of reflection - get back to the full OOXML-enabled factory if we can
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752228 13f79535-47bb-0310-9956-ffa450edef68
2016-07-11 22:57:42 +00:00
Nick Burch
4643b2ade0 Exceptions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752227 13f79535-47bb-0310-9956-ffa450edef68
2016-07-11 22:53:22 +00:00
Nick Burch
7179c813e6 Start moving logic over into the main and scratchpad jars for OLE2
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752226 13f79535-47bb-0310-9956-ffa450edef68
2016-07-11 22:47:02 +00:00
Nick Burch
a5fb04f45f Pull Scratchpad Extractor logic to own class
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752225 13f79535-47bb-0310-9956-ffa450edef68
2016-07-11 22:27:02 +00:00
Nick Burch
ed7940dee5 Start to pull out some of the OLE2 logic, so we can then split some Scratchpad parts out
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752223 13f79535-47bb-0310-9956-ffa450edef68
2016-07-11 22:20:51 +00:00
Nick Burch
f94e7e761b Notes on use
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752222 13f79535-47bb-0310-9956-ffa450edef68
2016-07-11 22:17:34 +00:00
Javen O'Neal
c541e0a16f add BaseTestCellUtil unit tests to cover setting cell style properties with an invalid value and using both valid Short and Enum values
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752079 13f79535-47bb-0310-9956-ffa450edef68
2016-07-10 11:37:22 +00:00
Javen O'Neal
2ec6b12e13 bug 59837: update CellUtil to handle VerticalAlignment and HorizontalAlignment enums
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752077 13f79535-47bb-0310-9956-ffa450edef68
2016-07-10 11:18:55 +00:00
Javen O'Neal
0f8039f3ab bug 59837: replace CellStyle.ALIGN_ and CellStyle.VERTICAL_ constants with HorizontalAlignment and VerticalAlignment enums
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752066 13f79535-47bb-0310-9956-ffa450edef68
2016-07-10 08:29:02 +00:00
Javen O'Neal
847d90603a javadoc fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752063 13f79535-47bb-0310-9956-ffa450edef68
2016-07-10 06:54:36 +00:00
Javen O'Neal
79fac1f707 bug 59264: Unify interface for setting cell border line styles using BorderStyle enum instead of short code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752062 13f79535-47bb-0310-9956-ffa450edef68
2016-07-10 06:52:16 +00:00
Javen O'Neal
ba1e2c8b14 Add comments describing Outlook .msg DirectoryNode names
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752054 13f79535-47bb-0310-9956-ffa450edef68
2016-07-10 01:41:15 +00:00
Javen O'Neal
fbf2d524f9 move string literals out to array that can be for-looped over
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752053 13f79535-47bb-0310-9956-ffa450edef68
2016-07-10 01:29:30 +00:00
Andreas Beeker
cd349946a0 javadocs fixes (jdk8)
eclipse source clean-ups (final members, override annotations, for-each loops)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752037 13f79535-47bb-0310-9956-ffa450edef68
2016-07-09 18:52:26 +00:00
Javen O'Neal
44f0a6a66a add 2^x to POWER2 comments
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751992 13f79535-47bb-0310-9956-ffa450edef68
2016-07-09 08:54:07 +00:00
Javen O'Neal
e563dee47c bug 52949,59830: move module storage and decompressing into a standalone function
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751990 13f79535-47bb-0310-9956-ffa450edef68
2016-07-09 08:51:57 +00:00
Javen O'Neal
d8c65c777e bug 52949,59830: move module storage and decompressing into a standalone function
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751987 13f79535-47bb-0310-9956-ffa450edef68
2016-07-09 08:18:29 +00:00
Javen O'Neal
76dde0aed5 bug 59830: attach context to any IOException (likely a result of reaching EOF on input stream)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751986 13f79535-47bb-0310-9956-ffa450edef68
2016-07-09 08:05:43 +00:00
Javen O'Neal
518253650a remove Internal UnhandledDataStructure.copyOfRange because function is available in JDK 1.6+ and we no longer support JDK 1.5
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751984 13f79535-47bb-0310-9956-ffa450edef68
2016-07-09 06:38:16 +00:00
Javen O'Neal
ca22a79e01 close streams if an exception is throw
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751983 13f79535-47bb-0310-9956-ffa450edef68
2016-07-09 06:30:12 +00:00
Javen O'Neal
909c07f37f bug 59830: add context to why no more bytes could be read from input stream
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751982 13f79535-47bb-0310-9956-ffa450edef68
2016-07-09 05:39:56 +00:00
Javen O'Neal
a6f5ef09ef bug 59833: add getFillPatternEnum and setFillPattern(FillPatternType) to CellStyle; consolidate duplicated FillPattern constants in CellStyle to FillPatternType enum
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751972 13f79535-47bb-0310-9956-ffa450edef68
2016-07-08 22:28:28 +00:00
Javen O'Neal
3092c1121e bug 55555: set fill pattern, foreground color, and background color order correctly to follow HSSFCellStyle's order requirement; patch from Qualtagh. This closes #33 on Github
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751955 13f79535-47bb-0310-9956-ffa450edef68
2016-07-08 18:45:15 +00:00
Javen O'Neal
9c00c18f38 bug 56154: rename setLastModifiedBy to setLastModifiedByUser
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751950 13f79535-47bb-0310-9956-ffa450edef68
2016-07-08 18:05:02 +00:00
Javen O'Neal
ed4ae3fff0 bug 56154: add @since annotations to getLastModifiedBy and setLastModifiedBy methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751949 13f79535-47bb-0310-9956-ffa450edef68
2016-07-08 17:59:01 +00:00
Javen O'Neal
182c1415f5 bug 56154: get and set last modified by user property; patch from Danil Lopatin
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751948 13f79535-47bb-0310-9956-ffa450edef68
2016-07-08 17:56:54 +00:00
Javen O'Neal
d3eae0ccd8 convert OPC Compliance unit tests to junit4
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751891 13f79535-47bb-0310-9956-ffa450edef68
2016-07-08 12:07:20 +00:00
Javen O'Neal
6cbca80d5d whitespace and +svn:eol-style=native
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751890 13f79535-47bb-0310-9956-ffa450edef68
2016-07-08 11:55:21 +00:00
Javen O'Neal
99837b5014 AllOpenXML4JInternalTests no longer needed in AllOpenXML4JTests suite because it was upgraded to junit4
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751889 13f79535-47bb-0310-9956-ffa450edef68
2016-07-08 11:53:28 +00:00
Javen O'Neal
605cfbcfae fix regular expression example
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751885 13f79535-47bb-0310-9956-ffa450edef68
2016-07-08 11:42:01 +00:00
Javen O'Neal
ae0d93e9f8 bug 59826: ant script to apply patch.tar.gz files from bugzilla
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751883 13f79535-47bb-0310-9956-ffa450edef68
2016-07-08 11:32:52 +00:00
Javen O'Neal
92c2fa753d add crude unit test for ZipPackagePropertiesMarshaller
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751872 13f79535-47bb-0310-9956-ffa450edef68
2016-07-08 09:10:03 +00:00
Javen O'Neal
7d427f0d16 convert to junit4
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751870 13f79535-47bb-0310-9956-ffa450edef68
2016-07-08 08:53:34 +00:00
Javen O'Neal
891b45e186 whitespace and +svn:eol-style=native
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751867 13f79535-47bb-0310-9956-ffa450edef68
2016-07-08 08:38:28 +00:00
Javen O'Neal
4c72ddaba1 add @Internal annotations to implementations of Internal EvaluationWorkbook and EvaluationSheet interfaces; added @since annotations to clearAllCachedResultValues added in r1751836.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751843 13f79535-47bb-0310-9956-ffa450edef68
2016-07-07 23:20:34 +00:00
Javen O'Neal
bb7da64c25 add crude line-coverage tests for setDebugEvaluationOutputForNextEval and setIgnoreMissingWorkbooks
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751841 13f79535-47bb-0310-9956-ffa450edef68
2016-07-07 23:00:07 +00:00
Javen O'Neal
dd32e6b5b5 add getters for setIgnoreMissingWorkbooks and setDebugEvaluationOutputForNextEval; add internal decorator; getSupportedFunctionNames and getNotSupportedFunctionNames should return unmodifiable collections
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751840 13f79535-47bb-0310-9956-ffa450edef68
2016-07-07 22:46:06 +00:00