Andreas Beeker
8e84226202
#59170 - Remove deprecated classes (POI 3.15) - o.a.p.hssf.model.*Shape classes removed
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751174 13f79535-47bb-0310-9956-ffa450edef68
2016-07-03 21:54:17 +00:00
Javen O'Neal
4ab0e89901
bug 59781: promote to Common SS: move PaneInformation from o.a.p.hssf.util to o.a.p.ss.util
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751044 13f79535-47bb-0310-9956-ffa450edef68
2016-07-02 09:00:13 +00:00
Andreas Beeker
6eab79528b
a few performance fixes to speed-up the tests
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1750867 13f79535-47bb-0310-9956-ffa450edef68
2016-06-30 22:59:46 +00:00
Andreas Beeker
099f63d054
deprecated constants pointing to MissingCellPolicy - use enum instead
...
javadocs fixes (jdk8)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1750172 13f79535-47bb-0310-9956-ffa450edef68
2016-06-24 23:31:12 +00:00
Javen O'Neal
fd1a23361b
bug 59748: replace Hashtable with HashMap; contributed by Axel Howind
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1750168 13f79535-47bb-0310-9956-ffa450edef68
2016-06-24 21:39:44 +00:00
Javen O'Neal
0f3a7b24b4
bug 56781: make Name#validateName compatible on Java 6 (no Regex \p{IsAlphabetic} metaclasses
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749305 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 11:27:40 +00:00
Javen O'Neal
d23e77fcf5
remove commented out @Ignore
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749294 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 10:32:21 +00:00
Javen O'Neal
b617f3ccec
bug 56781: disallow names with symbols, except underscore, period, and backslash
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749293 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 10:27:52 +00:00
Javen O'Neal
3881a0db31
bug 57929: add disabled unit test, adapted from nova
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749270 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 07:15:09 +00:00
Javen O'Neal
7929adbf80
whitespace (tabs to 4 spaces)
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749264 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 04:21:26 +00:00
Javen O'Neal
57e9abb8d1
parameterize raw generics
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749260 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 03:50:30 +00:00
Javen O'Neal
ce8b8ea7ab
bug 59730: promote XSSFSheet#removeMergedRegions to Sheet interface
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749258 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 03:40:32 +00:00
Javen O'Neal
2804197bdb
bug 56454: add disabled unit test based on Jörg Selbach's test case showing shiftRows incorrectly handles merged regions
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749246 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 01:44:44 +00:00
Javen O'Neal
8c6c7783d6
mv o.a.p.hssf.record.cf.CellRangeUtil o.a.p.ss.util.CellRangeUtil
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749240 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 00:25:29 +00:00
Javen O'Neal
e205422d39
bug 56454: add CellRangeAddress#containsRow and containsColumn
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749239 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 00:16:41 +00:00
Javen O'Neal
e08786d49e
convert TestCellRangeAddress from junit3 to junit4
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749237 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 00:00:41 +00:00
Javen O'Neal
ebd55552bf
bug 59728: add disabled unit test: should not be able to add an array formula to merged region
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749225 13f79535-47bb-0310-9956-ffa450edef68
2016-06-19 22:51:01 +00:00
Nick Burch
7da9b2cd67
#59724 Take advantage of all POIDocument classes being Closeable to tidy the OLE2 text extractor closing
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749214 13f79535-47bb-0310-9956-ffa450edef68
2016-06-19 22:13:41 +00:00
Javen O'Neal
492aac4e73
bug 56958: patch from Yaniv Kunda: check that cells containing array formulas do not belong to a merged region
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749210 13f79535-47bb-0310-9956-ffa450edef68
2016-06-19 22:00:44 +00:00
Javen O'Neal
895bcab9f9
bug 59645: add Page Setup Print row and column headings support for Common SS
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749191 13f79535-47bb-0310-9956-ffa450edef68
2016-06-19 18:20:23 +00:00
Javen O'Neal
d8d821b1f2
add unit test for HSSFWorkbook.getSelectedTabs
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748899 13f79535-47bb-0310-9956-ffa450edef68
2016-06-18 02:37:24 +00:00
Javen O'Neal
59d1dc095b
bug 59170: Removed deprecated methods in POIFS, SS, HSSF, and XSSF
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748897 13f79535-47bb-0310-9956-ffa450edef68
2016-06-18 01:06:53 +00:00
Javen O'Neal
645fbd08fc
bug 59279: add unit test for CellComment.equals and CellComment.hashCode
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748827 13f79535-47bb-0310-9956-ffa450edef68
2016-06-17 10:17:47 +00:00
Javen O'Neal
720e866a4c
add unit test for Cell.getCellComment
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748813 13f79535-47bb-0310-9956-ffa450edef68
2016-06-17 08:54:08 +00:00
Javen O'Neal
e355d20cfa
bug 59170: remove deprecated methods
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748483 13f79535-47bb-0310-9956-ffa450edef68
2016-06-15 03:26:58 +00:00
Andreas Beeker
d8437d0476
reverted changes of r1747942 and deprecated instead
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748313 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 21:18:50 +00:00
Javen O'Neal
227a62ce1e
back out changes for bug 58787: will replae BorderPropertyTemplate with a more general CellStyleTemplate in the future
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748294 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 18:14:26 +00:00
Javen O'Neal
beef6df971
back out changes for bug 58787: will replae BorderPropertyTemplate with a more general CellStyleTemplate in the future
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748293 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 18:12:29 +00:00
Javen O'Neal
8bf974b185
add useless unit test for o.a.p.ss.util.RegionUtil
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748170 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 10:14:44 +00:00
Javen O'Neal
48eb5c521b
improve unit test coverage on CellReference.
...
Add note that _sheetName can be null or empty string, depending on the entry-point.
Throw an exception when parsing a string if sheet name is not quoted and contains a space.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748144 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 08:58:55 +00:00
Javen O'Neal
9d58a47e0c
bug 58787: reintegrate changes from ss_border_property_template branch at r1748074. The BorderPropertyTemplate allows changes to border formatting to be staged in a template and applied to a sheet at a later time. This reduces the number of intermediate styles created, reduces interactions with cell objects (CellUtil.get/setCellProperties), and makes it easier to make the same formatting changes to multiple sheets. This utility can currently apply border line style and border color. This utility also adds the ability to add a border around a cell range rather than a single cell. Contributed by Mark Murphy.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748075 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 01:25:50 +00:00
Javen O'Neal
a3e44453ca
rename drawBorders(..., short color, ...) to drawColoredBorders to make it obvious that method changes border line style and color
...
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748074 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 01:00:51 +00:00
Javen O'Neal
75e4c452bf
test copy constructor: make changes to same range: this is a better test for deepcopy
...
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748073 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 00:50:52 +00:00
Javen O'Neal
ca9431d71f
add copy constructor
...
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748072 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 00:43:34 +00:00
Javen O'Neal
d68b4ea41d
move colors in TestBorderPropertyTemplate to testclass constants
...
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748071 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 00:40:46 +00:00
Javen O'Neal
344b9d9884
remove public convenience methods that let the user avoid creating a CellAddress object. Having the user provide a CellAddress increases the chance the user-provided object will be reused if possible. This also moves the validation of the CellAddress object outside of this BorderPropertyTemplate class (easier to debug), improves readability, and runs slightly faster since the CellAddress is needed anyways as a key.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748065 13f79535-47bb-0310-9956-ffa450edef68
2016-06-12 22:33:24 +00:00
Javen O'Neal
e6937956f2
use CellAddress in unit tests where possible to improve readability
...
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748062 13f79535-47bb-0310-9956-ffa450edef68
2016-06-12 22:01:30 +00:00
Andreas Beeker
a1ff5002a5
fixing javadocs errors (in JDK8)
...
removing Rainers author tags as those cause a lot of errors and should be omitted anyways (see https://poi.apache.org/guidelines.html )
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748046 13f79535-47bb-0310-9956-ffa450edef68
2016-06-12 20:19:59 +00:00
Andreas Beeker
81d891921b
findbugs fixes
...
changed UDFFinder to abstract class and moved DEFAULT constant to factory method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747942 13f79535-47bb-0310-9956-ffa450edef68
2016-06-12 00:12:22 +00:00
Dominik Stadler
b9ceae5ef3
Add some pre-checks to fail the test with better assertion if the locale is not set correctly.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747916 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 17:03:59 +00:00
Javen O'Neal
16fb41d5f1
make these classes more discoverable/searchable using more specific names
...
rename PropertyTemplate to BorderPropertyTemplate
rename Extent to BorderExtent
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747884 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 12:09:23 +00:00
Javen O'Neal
bd22a7be43
replace usage of all deprecated CellStyle.BORDER_* constants with BorderStyle.*
...
update PropertyTemplate functions to require enum instead of short borderType
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747868 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 09:15:57 +00:00
Javen O'Neal
7dc4706edf
continue simplifying using helper functions
...
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747859 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 08:15:50 +00:00
Javen O'Neal
66875dbc1b
continue simplifying using helper functions
...
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747858 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 08:08:04 +00:00
Javen O'Neal
8ad237f679
add helper functions for verifying template properties were set correctly
...
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747855 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 07:48:32 +00:00
Javen O'Neal
222e32d577
whitespace (unwrap lines)
...
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747854 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 07:40:46 +00:00
Javen O'Neal
50d0a1197f
shorten PropertyTemplate.Extent to Extent
...
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747853 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 07:10:21 +00:00
Javen O'Neal
fc6b8cdd0e
+props svn:eol-style=native
...
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747852 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 07:00:40 +00:00
Javen O'Neal
54213ab158
bug 58787: add PropertyTemplate, unit test, and example from Mark Murphy
...
Attachment 33684 plus changes to TestPropertyTemplate#applyBorders: replaced assertEquals(CellStyle.BORDER_*, cs.getBorder*()) with assertEquals(BorderStyle.*, cs.getBorder*())
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747851 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 06:47:25 +00:00
Javen O'Neal
649f2df1e9
add crude unit tests for UDFFinder classes
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747834 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 01:38:27 +00:00