Andreas Beeker
8c1346b138
Add ASL header and exclude table preset from rat-check
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795137 13f79535-47bb-0310-9956-ffa450edef68
2017-05-15 06:30:06 +00:00
Greg Woolsey
0cdc064b0c
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795002 13f79535-47bb-0310-9956-ffa450edef68
2017-05-12 18:01:32 +00:00
Dominik Stadler
d9df038f4a
Bug 60352: Text extraction: Don't include the text "null" for empty cells
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1794260 13f79535-47bb-0310-9956-ffa450edef68
2017-05-07 21:03:46 +00:00
Greg Woolsey
8313b17515
60184 - invalid OOXML produced when XSSFFont.getFamily() called with no families defined
...
Fix to stop creating an empty family when none exist, just use the existing logic to return NOT_APPLICABLE. Creating the empty element produces XML that doesn't comply with the XSD.
Alternative would have been to set the family int value for the new family, but this way checking the value doesn't change the output, which is my preferred behavior. No quantum effects!
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1794111 13f79535-47bb-0310-9956-ffa450edef68
2017-05-05 21:50:59 +00:00
Greg Woolsey
18d107d974
61060 - teach DataFormatter about conditional formatting rules with number formats
...
Currently only implemented for XSSF, as there is no API available for HSSF conditional formatting rule number formats (if it is even in the files).
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1794084 13f79535-47bb-0310-9956-ffa450edef68
2017-05-05 17:44:58 +00:00
Nick Burch
28cbb8e84e
Javadoc fix
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793249 13f79535-47bb-0310-9956-ffa450edef68
2017-04-30 08:49:51 +00:00
Javen O'Neal
f5389965a2
bug 61034: break out of for-loop when both <sheet name="", id=""/> are found
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793230 13f79535-47bb-0310-9956-ffa450edef68
2017-04-29 18:56:09 +00:00
Javen O'Neal
e39ae9cd30
bug 61034: Call to XSSFReader.getSheetsData() returns duplicate sheets.
...
Thanks to Mauricio Eastmond for the Excel test file and unit test.
Thanks to Sebastian Wikalinski for isolating the problem and providing a patch.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793223 13f79535-47bb-0310-9956-ffa450edef68
2017-04-29 17:27:17 +00:00
Tim Allison
a98eaeb917
bug 61051 -- add new worksheet-like relations for xlsb
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1792940 13f79535-47bb-0310-9956-ffa450edef68
2017-04-27 18:50:22 +00:00
Nick Burch
9896e13bf4
Patch from Tim Jones from #61044 - Note on setCompressTempFiles
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1792720 13f79535-47bb-0310-9956-ffa450edef68
2017-04-26 09:43:56 +00:00
Tim Allison
c2dc3ad585
bug 61021 - extract abspath from xlsb
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1792198 13f79535-47bb-0310-9956-ffa450edef68
2017-04-21 13:02:29 +00:00
Javen O'Neal
3c2a6b38bb
Use assertContains instead of assertTrue(text.contains) for better error messages on failure
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1792009 13f79535-47bb-0310-9956-ffa450edef68
2017-04-20 01:28:40 +00:00
Javen O'Neal
3cbf4740b1
Use assertContains instead of assertTrue(text.contains) for better error messages on failure
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1792007 13f79535-47bb-0310-9956-ffa450edef68
2017-04-19 23:51:03 +00:00
Nick Burch
d4d08d5ce8
Use assertContains instead of assertTrue(text.contains) for better error messages on failure
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791857 13f79535-47bb-0310-9956-ffa450edef68
2017-04-19 06:13:33 +00:00
Dominik Stadler
511c2544a8
Let IntelliJ cleanup some code-warnings across the whole code-base: unnecessary toString or semicolon
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791720 13f79535-47bb-0310-9956-ffa450edef68
2017-04-17 20:13:52 +00:00
Andreas Beeker
c89d312bad
#60998 - HSLFTable.setRowHeight sets row height incorrect
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791696 13f79535-47bb-0310-9956-ffa450edef68
2017-04-17 17:13:23 +00:00
Andreas Beeker
7df2a8804c
findbugs fixes
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791679 13f79535-47bb-0310-9956-ffa450edef68
2017-04-17 11:02:22 +00:00
Andreas Beeker
594b46f1cd
fix forbidden-apis-check error
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791646 13f79535-47bb-0310-9956-ffa450edef68
2017-04-16 23:43:56 +00:00
Andreas Beeker
bd237e2483
#60996 - XSSF: Multiple embedded objects on same sheet are ignored
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791644 13f79535-47bb-0310-9956-ffa450edef68
2017-04-16 22:41:28 +00:00
Andreas Beeker
160fb550c1
#60993 - HSLF: Grid and rowspan calculation in table cells is wrong
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791500 13f79535-47bb-0310-9956-ffa450edef68
2017-04-15 12:14:26 +00:00
Javen O'Neal
0acf44d3dc
improve unit test error messages
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791445 13f79535-47bb-0310-9956-ffa450edef68
2017-04-15 03:21:34 +00:00
Javen O'Neal
e7ca1594da
use hamcrest matchers to reduce custom code
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791443 13f79535-47bb-0310-9956-ffa450edef68
2017-04-15 02:50:46 +00:00
Javen O'Neal
7977026f96
use assertStartsWith and assertEndsWith for better unit test error messages
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791440 13f79535-47bb-0310-9956-ffa450edef68
2017-04-15 02:19:24 +00:00
Nick Burch
70ae27f96d
#60973 XDGF Support for "PolylineTo" as well as existing alternate spelling "PolyLineTo"
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791108 13f79535-47bb-0310-9956-ffa450edef68
2017-04-12 11:11:56 +00:00
Nick Burch
3bd1f662f3
Failing, disabled unit test for bug #60973
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791098 13f79535-47bb-0310-9956-ffa450edef68
2017-04-12 09:40:54 +00:00
Greg Woolsey
6163e4ca45
Issue #60971 , handle formula chart titles
...
implemented per issue, breaking out static text vs. formula based title getters and setters, with unit test updates and additions.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791025 13f79535-47bb-0310-9956-ffa450edef68
2017-04-11 20:27:23 +00:00
Andreas Beeker
1f41c31984
Fix AIOOBE while extracting hssf pictures which are externally linked
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790897 13f79535-47bb-0310-9956-ffa450edef68
2017-04-10 21:43:22 +00:00
Dominik Stadler
48526517cd
Adjust checking for Zip-Bomb errors so it also works on JDK >= 8
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790508 13f79535-47bb-0310-9956-ffa450edef68
2017-04-07 06:38:23 +00:00
Dominik Stadler
77614b8c49
Test for another type of xml-bomb
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790473 13f79535-47bb-0310-9956-ffa450edef68
2017-04-06 21:50:03 +00:00
Dominik Stadler
0f193371ea
Fix issue found via large corpus tests: HSSFPicture in a HSSFShapeGroup might not have a patriarch set, so let's walk up the parents to try to find one.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790472 13f79535-47bb-0310-9956-ffa450edef68
2017-04-06 21:49:53 +00:00
Tim Allison
9dcb5d4c47
Bug 60906 -- clean up, and add range checking for casting to ints.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1788295 13f79535-47bb-0310-9956-ffa450edef68
2017-03-23 18:08:52 +00:00
Tim Allison
3d20031b56
Bug 60489 -- add @Test annotation so that this actually runs and includes ConnectsType...<facepalm/>
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1788288 13f79535-47bb-0310-9956-ffa450edef68
2017-03-23 16:56:29 +00:00
Tim Allison
925f4b85ad
Bug 60906 -- fix style index
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1788282 13f79535-47bb-0310-9956-ffa450edef68
2017-03-23 16:31:42 +00:00
Tim Allison
3953b18e2b
60881 -- fix unit test to use assumeTrue thanks to Javen's recommendation.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1788133 13f79535-47bb-0310-9956-ffa450edef68
2017-03-22 16:21:25 +00:00
Tim Allison
2674dad889
60881 -- strip out system.set props for local test.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787891 13f79535-47bb-0310-9956-ffa450edef68
2017-03-21 00:13:11 +00:00
Tim Allison
26dddd5184
60881 -- fix new unit test. xlsb test file apparently requires unlimited jce. If not installed, ignore new test.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787890 13f79535-47bb-0310-9956-ffa450edef68
2017-03-21 00:03:01 +00:00
Tim Allison
69c3311a98
60881 and 60891 -- on further look, no need to throw an exception for an encrypted xlsb. On the second, let's fix readFully to read fully.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787846 13f79535-47bb-0310-9956-ffa450edef68
2017-03-20 20:47:15 +00:00
Tim Allison
e4f884a915
60879 -- figure out if we can support old beta xlsb or throw exception. For now, let's hope there's only one diff and/or the other bounds checking etc will throw exception if there are other problems.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787832 13f79535-47bb-0310-9956-ffa450edef68
2017-03-20 18:50:25 +00:00
Dominik Stadler
1aee770758
Bug 60042: Add sample file to check if this bug is fixed via bug 55791 already.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787664 13f79535-47bb-0310-9956-ffa450edef68
2017-03-19 21:44:05 +00:00
Dominik Stadler
a22b4aaa2d
Bug 60810: Check for duplicate relation-names for notes similar to the fix for slides themselves in bug 55791
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787663 13f79535-47bb-0310-9956-ffa450edef68
2017-03-19 21:43:57 +00:00
Tim Allison
b52126f7f3
60826 -- clean up. Many, many thanks to Javen O'Neal's code review!
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787320 13f79535-47bb-0310-9956-ffa450edef68
2017-03-17 10:09:59 +00:00
Tim Allison
730f394261
60826 -- add initial support for streaming reading of xlsb files.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787228 13f79535-47bb-0310-9956-ffa450edef68
2017-03-16 18:37:13 +00:00
Greg Woolsey
6fc050a162
add missing license header
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786962 13f79535-47bb-0310-9956-ffa450edef68
2017-03-14 22:36:38 +00:00
Greg Woolsey
6349d2c614
Fixed #60858 , which showed a regression of the fix for #56420 introduced by my refactoring to fix #56822 .
...
Includes new unit test based on the bug sample file.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786953 13f79535-47bb-0310-9956-ffa450edef68
2017-03-14 21:39:33 +00:00
Dominik Stadler
aafdbdfdd7
Remove unused import, IntelliJ warnings, duplicated code, improve some exception-texts
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786429 13f79535-47bb-0310-9956-ffa450edef68
2017-03-10 20:13:39 +00:00
Tim Allison
b442671274
51519 -- follow on, make concatenation of rPh configurable
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786021 13f79535-47bb-0310-9956-ffa450edef68
2017-03-08 16:44:40 +00:00
Tim Allison
5bb1195606
51519 -- allow users to ignore or include the <rPh> (phonetic run) element in the ReadOnlySharedStringsTable used in the SAX/streaming xlsx reader.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1785965 13f79535-47bb-0310-9956-ffa450edef68
2017-03-08 13:41:07 +00:00
Javen O'Neal
8dd5f7b887
store repeated expressions as temporary variables to make code shorter
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1785793 13f79535-47bb-0310-9956-ffa450edef68
2017-03-07 03:16:50 +00:00
Andreas Beeker
0744f73add
BugFix for JDK-6623219
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783698 13f79535-47bb-0310-9956-ffa450edef68
2017-02-19 21:36:45 +00:00
Andreas Beeker
7810671d2d
#60662 - Slide import delete unrecognized elements in group shape
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783486 13f79535-47bb-0310-9956-ffa450edef68
2017-02-18 01:07:47 +00:00