Commit Graph

7441 Commits

Author SHA1 Message Date
Javen O'Neal
925a296cc3 eventually we want to forbid StringBuffer usage
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813875 13f79535-47bb-0310-9956-ffa450edef68
2017-10-31 11:10:08 +00:00
PJ Fanning
34006a542e use StringBuilder in more places
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813869 13f79535-47bb-0310-9956-ffa450edef68
2017-10-31 10:24:47 +00:00
Javen O'Neal
bf5a0c4c9e github-68: add @Override to o.a.p.ss.usermodel.charts.DataSources. Thanks to Alain-Bearez.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813868 13f79535-47bb-0310-9956-ffa450edef68
2017-10-31 10:17:38 +00:00
PJ Fanning
e623808539 add test case for bug 61701 and use StringBuilder in more places
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813863 13f79535-47bb-0310-9956-ffa450edef68
2017-10-31 09:48:23 +00:00
Javen O'Neal
722ab2d4f1 github-77: Remove the 'public' modifier to make fields package protected (findbugs-MS_PKGPROTECT). Thanks to BruceKuiLiu for the PR. This closes #77 on github.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813859 13f79535-47bb-0310-9956-ffa450edef68
2017-10-31 09:38:03 +00:00
Javen O'Neal
729c86e82c consolidate duplicated code: XSSFWorkbook#setBookViewsIfMissing()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813841 13f79535-47bb-0310-9956-ffa450edef68
2017-10-31 01:45:03 +00:00
Javen O'Neal
1cea1c52fd bug 61630: Patch from Daniel to fix XSSFExportToXML IllegalArgumentException: Comparison method violates its general contract! (bug 61630, comment 17, attachment 35468). Found during manual testing.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813443 13f79535-47bb-0310-9956-ffa450edef68
2017-10-26 18:10:09 +00:00
Javen O'Neal
2cf5a977aa bug 61630: further XSSFExportToXML performance improvements from Daniel (bug 61630 comment 15, attachment 35450)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813332 13f79535-47bb-0310-9956-ffa450edef68
2017-10-25 18:19:12 +00:00
Javen O'Neal
02093f59dc bug 61630: revert r1813240, which failed the integration test with org.apache.poi.stress.XSSFFileHandler on test-data/spreadsheet/59025.xlsx
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813243 13f79535-47bb-0310-9956-ffa450edef68
2017-10-24 23:44:21 +00:00
Javen O'Neal
87d9019713 bug 61630: further XSSFExportToXML performance improvements from Daniel (comment 9, bug 61630 attachment 35450)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813240 13f79535-47bb-0310-9956-ffa450edef68
2017-10-24 23:00:12 +00:00
PJ Fanning
95828710f1 Remove more deprecated code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813102 13f79535-47bb-0310-9956-ffa450edef68
2017-10-23 21:17:49 +00:00
PJ Fanning
af2813634b Remove more deprecated code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813092 13f79535-47bb-0310-9956-ffa450edef68
2017-10-23 20:39:27 +00:00
PJ Fanning
6c0ac68e05 Remove more deprecated code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813085 13f79535-47bb-0310-9956-ffa450edef68
2017-10-23 20:27:47 +00:00
PJ Fanning
245d9b3b7f Introduce new BorderFormatting methods to expose border styles
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812917 13f79535-47bb-0310-9956-ffa450edef68
2017-10-22 13:53:42 +00:00
PJ Fanning
26cc1e4d32 Remove use of deprecated methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812911 13f79535-47bb-0310-9956-ffa450edef68
2017-10-22 13:03:33 +00:00
PJ Fanning
1ea1a692e0 Remove use of deprecated methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812907 13f79535-47bb-0310-9956-ffa450edef68
2017-10-22 12:45:35 +00:00
PJ Fanning
dfd5f07079 Remove use of deprecated methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812901 13f79535-47bb-0310-9956-ffa450edef68
2017-10-22 12:07:14 +00:00
Dominik Stadler
5d5ba1c767 Add getter/setter for ReadingOrder to XSSF, closes issue #73
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812558 13f79535-47bb-0310-9956-ffa450edef68
2017-10-18 18:26:41 +00:00
Javen O'Neal
79975dcfce bug 61630: performance improvements in XSSFExportToXml. Thanks to Daniel for the patch.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812546 13f79535-47bb-0310-9956-ffa450edef68
2017-10-18 16:04:06 +00:00
Javen O'Neal
22e4bc2399 cleanup for r1812470: avoid NPEs from string.isEmpty()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812532 13f79535-47bb-0310-9956-ffa450edef68
2017-10-18 14:40:56 +00:00
Javen O'Neal
49add35f3b fix compile error
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812531 13f79535-47bb-0310-9956-ffa450edef68
2017-10-18 14:40:05 +00:00
Javen O'Neal
42c4e4909c cleanup for r1812475: avoid NPEs from string.isEmpty()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812520 13f79535-47bb-0310-9956-ffa450edef68
2017-10-18 14:29:56 +00:00
Javen O'Neal
fc2bcfae9a cleanup for r1812476: avoid NPEs from string.isEmpty()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812516 13f79535-47bb-0310-9956-ffa450edef68
2017-10-18 14:08:43 +00:00
Javen O'Neal
5fb4887907 replace "".equals(string) with string.isEmpty() to avoid null strings silently evaluating to false; most code should probably check string for null if it is not already
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812476 13f79535-47bb-0310-9956-ffa450edef68
2017-10-18 08:41:42 +00:00
Javen O'Neal
aba704b928 prefer literal.equals(variable) over variable.equals(literal)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812475 13f79535-47bb-0310-9956-ffa450edef68
2017-10-18 08:41:25 +00:00
Javen O'Neal
3a2ee5f4d1 convert "".equals(string) to string.isEmpty()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812470 13f79535-47bb-0310-9956-ffa450edef68
2017-10-18 08:22:51 +00:00
Javen O'Neal
21b65721e7 simplfy PackagingURIHelper#combine boolean logic using xor and replacing +FORWARD_SLASH_CHAR with FORWARD_SLASH_STRING
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812468 13f79535-47bb-0310-9956-ffa450edef68
2017-10-18 08:10:36 +00:00
Javen O'Neal
afa5be82d3 fix typo
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812464 13f79535-47bb-0310-9956-ffa450edef68
2017-10-18 07:47:25 +00:00
Javen O'Neal
cfac692a6a string.equals("") -> string.isEmpty() or "".equals(string)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812463 13f79535-47bb-0310-9956-ffa450edef68
2017-10-18 07:45:53 +00:00
Javen O'Neal
36dcbd7403 for -> foreach
string.equals() -> string.isEmpty() or .equals(string)
ArrayList -> List

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812461 13f79535-47bb-0310-9956-ffa450edef68
2017-10-18 07:33:07 +00:00
Javen O'Neal
bcbadce32e IntelliJ: simplify boolean logic
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812363 13f79535-47bb-0310-9956-ffa450edef68
2017-10-17 07:43:41 +00:00
Javen O'Neal
7eb6686b1d remove deprecated XSSFRowShifter.shiftMerged(int,int,int) method; replaced with RowShifter.shiftMergedRegions(int,int,int) in POI 3.15 beta 2
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812354 13f79535-47bb-0310-9956-ffa450edef68
2017-10-17 07:10:25 +00:00
Dustin Spicuzza
ab147e9998 Bug 61584: Fix XDGFPage variable typo causing crash
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812240 13f79535-47bb-0310-9956-ffa450edef68
2017-10-16 01:35:31 +00:00
Javen O'Neal
e593f50186 github-79: add String.toString() to forbidden API's
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812239 13f79535-47bb-0310-9956-ffa450edef68
2017-10-16 01:34:13 +00:00
PJ Fanning
16125ab3cc Make public static members final [thanks to Kui Liu]. This close #78.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812234 13f79535-47bb-0310-9956-ffa450edef68
2017-10-15 20:50:58 +00:00
PJ Fanning
e1571c9130 Remove unnecessary toString calls [thanks to Kui Liu]. This close #79.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812233 13f79535-47bb-0310-9956-ffa450edef68
2017-10-15 20:34:10 +00:00
PJ Fanning
229af142fc Remove unnecessary StringBuilder [thanks to Kui Liu]. This close #80.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812232 13f79535-47bb-0310-9956-ffa450edef68
2017-10-15 20:25:33 +00:00
Dominik Stadler
bc7d79a613 Fix some findbugs-issues and apply some code-cleanup and apply some smaller pull requests.
This closes #74, This closes #75, This closes #76

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812097 13f79535-47bb-0310-9956-ffa450edef68
2017-10-13 09:40:22 +00:00
Dominik Stadler
887ec868b7 Fix aparent copy/paste error in XSSFBorderFormatting
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811867 13f79535-47bb-0310-9956-ffa450edef68
2017-10-11 18:32:13 +00:00
Dominik Stadler
793938ecef Bug 58068: Add a method to pass the actual Color to StylesTable.findFont().
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811866 13f79535-47bb-0310-9956-ffa450edef68
2017-10-11 18:32:01 +00:00
Dominik Stadler
c05e07b55c adjust tests, javadoc, ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811865 13f79535-47bb-0310-9956-ffa450edef68
2017-10-11 18:31:34 +00:00
Dominik Stadler
673b223f61 Remove "filling" in IntList as this has no effect whatsoever as far as I could see
Fix some IntelliJ warnings, missing JavaDoc, typos, Findbugs issues

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811793 13f79535-47bb-0310-9956-ffa450edef68
2017-10-11 05:32:05 +00:00
Dominik Stadler
e24f25d0ef Add test which shows that bug 51262 is fixed now
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811595 13f79535-47bb-0310-9956-ffa450edef68
2017-10-09 19:35:32 +00:00
Dominik Stadler
566789e983 Apply patch from bug 61096: Add support for modules in VBAMacroReader
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811383 13f79535-47bb-0310-9956-ffa450edef68
2017-10-07 06:11:12 +00:00
Dominik Stadler
c2d09c0217 Bug 61586: Add test which shows that it works as expected
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811355 13f79535-47bb-0310-9956-ffa450edef68
2017-10-06 17:41:20 +00:00
Dominik Stadler
0e52f62a1e Bug 61564: Try to get rid of the Java 9 illegal access warning now that we run Java 8
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811145 13f79535-47bb-0310-9956-ffa450edef68
2017-10-04 19:54:41 +00:00
Dominik Stadler
dd23ba89a9 Add some more code from the separate integration test project to be able to publish the femaining functionality as separate project at some point
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811144 13f79535-47bb-0310-9956-ffa450edef68
2017-10-04 19:54:21 +00:00
Dominik Stadler
48613ee271 Bug 61064: Support behavior of function CEILING in newer versions of Microsoft Excel
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1810007 13f79535-47bb-0310-9956-ffa450edef68
2017-09-28 14:36:53 +00:00
Dominik Stadler
6450f1cc42 Bug 61082: Adjust JavaDoc for getFirst/LastRow/Cell to explain that there might be empty rows/cells included in the counts
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809988 13f79535-47bb-0310-9956-ffa450edef68
2017-09-28 13:12:32 +00:00
Dominik Stadler
688d5072d1 Fix bug 61516: when copying cells with formulas we should properly check for references that are invalid afterwards.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809967 13f79535-47bb-0310-9956-ffa450edef68
2017-09-28 09:56:45 +00:00
Dominik Stadler
3adbe1f8c5 Adjust some unit-tests, use try-with-resource, enable test which works now, ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809739 13f79535-47bb-0310-9956-ffa450edef68
2017-09-26 12:40:38 +00:00
Dominik Stadler
a751880c11 Replace "getEntry() plus catch" by "hasEntry()" in HSSFWorkbook
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809738 13f79535-47bb-0310-9956-ffa450edef68
2017-09-26 12:33:08 +00:00
Dominik Stadler
991fba37a2 Fixup change for CellReference to keep the behavior the same as before
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809737 13f79535-47bb-0310-9956-ffa450edef68
2017-09-26 12:31:51 +00:00
Dominik Stadler
af1b1d619c Replace deprecated CellReference class and some other warnings fixed
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809714 13f79535-47bb-0310-9956-ffa450edef68
2017-09-26 08:26:05 +00:00
Dominik Stadler
43717f6936 Fix some Sonar issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809636 13f79535-47bb-0310-9956-ffa450edef68
2017-09-25 15:10:40 +00:00
Dominik Stadler
61a281e790 Replace the incompatible new interface method endSheet() with a Java 8 default method so existing implementations do not need to be adjusted. Also use this for headerFooter() and remove the empty implementations that are now obsolete.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809635 13f79535-47bb-0310-9956-ffa450edef68
2017-09-25 14:45:14 +00:00
Tim Allison
7a2ce09761 Bug 61349 -- bump limits on classes that caused regressions in Dominik's regression corpus. Many thanks to Dominik Stadler for running the regression tests!!!
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809623 13f79535-47bb-0310-9956-ffa450edef68
2017-09-25 12:53:10 +00:00
PJ Fanning
3a622169d3 Remove more deprecated classes and methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809428 13f79535-47bb-0310-9956-ffa450edef68
2017-09-23 14:03:25 +00:00
Dominik Stadler
8e1b51128c Fix compiling Examples after adding new interface-method, fix compiler warnings and adjust some broken Javadoc
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809388 13f79535-47bb-0310-9956-ffa450edef68
2017-09-23 10:26:27 +00:00
Dominik Stadler
acb1772d4b Tried to enable this test, but it is broken since a long time and I am not sure how this is expected to behave...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809372 13f79535-47bb-0310-9956-ffa450edef68
2017-09-23 07:44:09 +00:00
Dominik Stadler
4a6bb031a0 Apply patch to add endSheet() to the XSSFEventBasedExcelExtractor, fixes bug 60737, thanks to user zakim for the patch
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809371 13f79535-47bb-0310-9956-ffa450edef68
2017-09-23 07:41:27 +00:00
Dominik Stadler
5ed15ac7c2 More IntelliJ warnings fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809370 13f79535-47bb-0310-9956-ffa450edef68
2017-09-23 07:38:01 +00:00
Dominik Stadler
29dbeb51ad Bug 59747: Adjust order of first two entries in the resulting Zip to try to enable some external tools to auto-detect the file-type
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809357 13f79535-47bb-0310-9956-ffa450edef68
2017-09-22 21:19:39 +00:00
Dominik Stadler
e54490712a Adjust many examples for Java 8: try-with-resource, multi-catch and other code cleanup.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809354 13f79535-47bb-0310-9956-ffa450edef68
2017-09-22 21:16:09 +00:00
Dominik Stadler
79a039ec8d Fix some IntelliJ warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809349 13f79535-47bb-0310-9956-ffa450edef68
2017-09-22 20:07:56 +00:00
Nick Burch
dc9416ec4d Javadoc fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809171 13f79535-47bb-0310-9956-ffa450edef68
2017-09-21 15:09:50 +00:00
Tim Allison
9cade10fa4 Bug 61349 -- add more sanity checks when allocating byte[]
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809169 13f79535-47bb-0310-9956-ffa450edef68
2017-09-21 14:52:59 +00:00
Dominik Stadler
828fb9a86c Apply patch from bug 61033 to add a XSSFWorkbook.setCellFormulaValidation(false) to speed up some operations
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809071 13f79535-47bb-0310-9956-ffa450edef68
2017-09-20 19:08:57 +00:00
PJ Fanning
37b5ca2c31 Bug 61528 - Pivot Table enhancements, new example [Thanks to R Kietel]. This closes #71
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808946 13f79535-47bb-0310-9956-ffa450edef68
2017-09-19 21:21:37 +00:00
PJ Fanning
f13f0dfbbd Bug 61528 - Pivot Table enhancements, new example [Thanks to R Kietel]. This closes #71
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808945 13f79535-47bb-0310-9956-ffa450edef68
2017-09-19 21:18:09 +00:00
PJ Fanning
a9ec0770f0 tidy up some test code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808944 13f79535-47bb-0310-9956-ffa450edef68
2017-09-19 21:04:30 +00:00
Dominik Stadler
01b1005379 Add test to verify that bug 61532 is fixed as far as I see via the changes for bug 61148.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808932 13f79535-47bb-0310-9956-ffa450edef68
2017-09-19 19:19:30 +00:00
Dominik Stadler
1496e83eaa Adjust to make forbidden-api-check succeed again
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808930 13f79535-47bb-0310-9956-ffa450edef68
2017-09-19 19:02:31 +00:00
Dominik Stadler
985af5304a Bug 61148: Fix calculating formula value, unfortunately we currently need to set the value twice
Also rework related tests to run more of the tests for HSSF, XSSF and SXSSF

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808929 13f79535-47bb-0310-9956-ffa450edef68
2017-09-19 19:02:22 +00:00
Dominik Stadler
d1d01bb632 IntelliJ warnings, deprecation
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808928 13f79535-47bb-0310-9956-ffa450edef68
2017-09-19 19:02:06 +00:00
Dominik Stadler
c31d6686db Fix some IntelliJ warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808908 13f79535-47bb-0310-9956-ffa450edef68
2017-09-19 16:23:37 +00:00
Tim Allison
a59402a37f 60805 (partial) -- remove/suppress println in tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808903 13f79535-47bb-0310-9956-ffa450edef68
2017-09-19 15:52:21 +00:00
Dominik Stadler
d1765d7e76 While working on bug 61148 I found that getCellType() and setCellErrorValue() in SXSSFCell are doing different things than the ones in XSSFCell, tried to fix this by mimicking functionality of XSSF in SXSSF as well.
Reformating some small things as well.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808874 13f79535-47bb-0310-9956-ffa450edef68
2017-09-19 12:47:13 +00:00
Javen O'Neal
4835636fed bug 61454: add column width to example Spreadsheet ToHtml; thanks to Christian Froehler
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808817 13f79535-47bb-0310-9956-ffa450edef68
2017-09-19 03:27:40 +00:00
Javen O'Neal
7a52b8c93b bug 61454: add column width to example Spreadsheet ToHtml; thanks to Christian Froehler
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808816 13f79535-47bb-0310-9956-ffa450edef68
2017-09-19 03:26:20 +00:00
Dominik Stadler
357816942a Bug 61520: Add JavaDoc about name-references in Excel
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808763 13f79535-47bb-0310-9956-ffa450edef68
2017-09-18 18:55:07 +00:00
PJ Fanning
51305b6260 use non-deprecated versions of getCellType
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808741 13f79535-47bb-0310-9956-ffa450edef68
2017-09-18 16:31:55 +00:00
PJ Fanning
e0ee55e75f change CellFormat.ultimateType to return CellType
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808739 13f79535-47bb-0310-9956-ffa450edef68
2017-09-18 16:06:54 +00:00
PJ Fanning
318fe3e597 change HyperLink getType to return HyperlinkType
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808737 13f79535-47bb-0310-9956-ffa450edef68
2017-09-18 15:55:48 +00:00
PJ Fanning
aaad224db9 fix compiler warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808722 13f79535-47bb-0310-9956-ffa450edef68
2017-09-18 14:15:15 +00:00
PJ Fanning
7dad60e9d4 update getCellType to return CellType enum instead of int
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808718 13f79535-47bb-0310-9956-ffa450edef68
2017-09-18 13:58:55 +00:00
PJ Fanning
4a4c428b6b update getCellType to return CellType enum instead of int
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808703 13f79535-47bb-0310-9956-ffa450edef68
2017-09-18 13:38:07 +00:00
PJ Fanning
d4486af6de update getCellType to return CellType enum instead of int
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808700 13f79535-47bb-0310-9956-ffa450edef68
2017-09-18 13:26:16 +00:00
PJ Fanning
d9b63eb569 remove some deprecated code slated for removal in 3.18
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808687 13f79535-47bb-0310-9956-ffa450edef68
2017-09-18 12:27:36 +00:00
PJ Fanning
16d262d0b4 Change getCachedFormulaResultType to return CellType
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808678 13f79535-47bb-0310-9956-ffa450edef68
2017-09-18 10:50:50 +00:00
Andreas Beeker
a51bac65b7 #60499 - Deleting a picture that is used twice on a slide corrupt the slide
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808661 13f79535-47bb-0310-9956-ffa450edef68
2017-09-17 22:45:03 +00:00
Dominik Stadler
71cfb659a1 Remove deprecated methods from NPOIFSFileSystem/OPOIFSFileSystem
IntelliJ warnings/suggestions

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808622 13f79535-47bb-0310-9956-ffa450edef68
2017-09-17 11:08:45 +00:00
Dominik Stadler
2917583bd2 Fix some warnings in OOXMLLite and move copyFile to IOUtils
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808621 13f79535-47bb-0310-9956-ffa450edef68
2017-09-17 11:08:31 +00:00
Dominik Stadler
b644047b70 Various code cleanups, "final" for static methods is useless, for-loops, simplify boolean conditions, try-with-resource, javadoc, ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808620 13f79535-47bb-0310-9956-ffa450edef68
2017-09-17 11:08:23 +00:00
Dominik Stadler
75c63b6bbe Some more code cleanup
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808619 13f79535-47bb-0310-9956-ffa450edef68
2017-09-17 11:07:48 +00:00
PJ Fanning
0b7774a452 remove some deprecated code slated for removal in 3.18
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808535 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 12:16:29 +00:00
Dominik Stadler
1f4344a048 Fix some compiler warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808523 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:29:28 +00:00
Dominik Stadler
2600c60fb5 Use Integer.compare() where possible
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808522 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:29:20 +00:00
Dominik Stadler
8b564f1185 Fix some warnings in unit tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808521 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:29:06 +00:00
Dominik Stadler
b7547a01f6 Use Collections.singleton() where applicable
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808520 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:28:56 +00:00
Dominik Stadler
356d4a77cb Fix some warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808519 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:28:50 +00:00
Dominik Stadler
5341a131de Remove unnecessary local variables
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808518 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:28:38 +00:00
Dominik Stadler
7937da6a10 Remove unnecessary type arguments (Java 8)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808516 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:27:23 +00:00
Dominik Stadler
d4070f05e7 Remove unnecessary type arguments
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808515 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:24:05 +00:00
Dominik Stadler
50beafbb47 Suppress some warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808514 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:23:57 +00:00
Dominik Stadler
87f5a0c7cd Remove unused imports
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808513 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:23:48 +00:00
Dominik Stadler
8ca329e08b Remove unnecessary casts and toString() calls
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808512 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:23:30 +00:00
Dominik Stadler
0ce7fff0be Remove unnecessary semicolons
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808511 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:23:15 +00:00
Dominik Stadler
f27cb3354d Remove unnecessary initialization of members
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808510 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:22:59 +00:00
Dominik Stadler
ba5f686a06 Fix typos and warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808509 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:21:35 +00:00
Dominik Stadler
e57e73fe38 Let IntelliJ cleanup some code-warnings across the whole code-base: unnecessary casts
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808508 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:21:28 +00:00
Dominik Stadler
51944a4e82 Detect some HTML files as separate invalid filetype
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808507 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:20:56 +00:00
Dominik Stadler
92ae9ce5e0 Allow to produce a jar for the integration-test-code so we can use it directly in the mass-regression tests without having to copy it for every run.
Enable some forbidden-api-checks for integration-test code

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808506 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:20:50 +00:00
Dominik Stadler
6044d4629c Adjust local test in integration-test file-handler
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808505 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:20:44 +00:00
Dominik Stadler
ee35ccda7f Add .git as excluded dir for integration-tests and add a local test for XSSFBFileHandler to be able to manually test single files quickly
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808504 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:20:38 +00:00
Dominik Stadler
23c2850586 Add additional check as mentioned in bug 50060
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808503 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:20:32 +00:00
Dominik Stadler
445852e773 Tried to reproduce bug 61300, but could not.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808502 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:20:25 +00:00
Dominik Stadler
f839090fe6 At least print out correct offset information for PtrRefN if it has offset values set
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808501 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:20:17 +00:00
Dominik Stadler
c9151662e8 Add test for question on the mailing-list
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808500 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:20:06 +00:00
PJ Fanning
6998fe1ea6 remove some deprecated code slated for removal in 3.18
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808483 13f79535-47bb-0310-9956-ffa450edef68
2017-09-15 20:17:21 +00:00
Dominik Stadler
f947ab760d Java 8: Deprecate some methods in IOUtils
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808475 13f79535-47bb-0310-9956-ffa450edef68
2017-09-15 18:39:43 +00:00
Dominik Stadler
6592bf6fbe Adjust some more places for the new versions of some third party libraries
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808473 13f79535-47bb-0310-9956-ffa450edef68
2017-09-15 18:39:29 +00:00
Dominik Stadler
276c8c89de Update third party libs to latest versions
Start updating build to Java 8
Set version to 4.0-beta1

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808472 13f79535-47bb-0310-9956-ffa450edef68
2017-09-15 18:39:18 +00:00
PJ Fanning
8f53bd94a6 remove some deprecated code slated for removal in 3.18
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808455 13f79535-47bb-0310-9956-ffa450edef68
2017-09-15 12:29:35 +00:00
Nick Burch
e4fc7ff5a7 Remove javadoc references to removed classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808436 13f79535-47bb-0310-9956-ffa450edef68
2017-09-15 09:03:56 +00:00
PJ Fanning
7863d0b312 remove deprecated inner classes from HSFColor
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808432 13f79535-47bb-0310-9956-ffa450edef68
2017-09-15 08:29:31 +00:00
PJ Fanning
19d58f3657 remove some deprecated code slated for removal in 3.18
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808403 13f79535-47bb-0310-9956-ffa450edef68
2017-09-14 23:44:47 +00:00
PJ Fanning
4d1907b447 remove some deprecated code slated for removal in 3.18
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808402 13f79535-47bb-0310-9956-ffa450edef68
2017-09-14 23:09:08 +00:00
PJ Fanning
320d9735ca remove some deprecated code slated for removal in 3.18
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808400 13f79535-47bb-0310-9956-ffa450edef68
2017-09-14 22:19:16 +00:00
PJ Fanning
18e53b3bef add missing licenses on test classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808315 13f79535-47bb-0310-9956-ffa450edef68
2017-09-14 07:21:33 +00:00
Tim Allison
4852228f3f 60279 -- back off to brute-force search for macro content if offset information is not correct
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808301 13f79535-47bb-0310-9956-ffa450edef68
2017-09-14 02:22:55 +00:00
PJ Fanning
5ef2f1636c Numeric Array Formula and Matrix Function [from Bob95132] This closes #69
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808297 13f79535-47bb-0310-9956-ffa450edef68
2017-09-13 23:54:36 +00:00
PJ Fanning
e726dd68de [bug-61515] fix xlsf issue with relationships [from Alain Bearez] This closes #70
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808294 13f79535-47bb-0310-9956-ffa450edef68
2017-09-13 23:10:44 +00:00
Nick Burch
526dc01a50 Copy over and tweak PicturesSource from Apache Tika
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1807651 13f79535-47bb-0310-9956-ffa450edef68
2017-09-07 21:36:15 +00:00
Andreas Beeker
d17deb6185 #61478 - POI OOXML-Schema lookup uses wrong classloader
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1807418 13f79535-47bb-0310-9956-ffa450edef68
2017-09-05 21:30:29 +00:00
Tim Allison
60176900fc While working on 61475, need to add a new line after picture text...not worth separate ticket.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1806843 13f79535-47bb-0310-9956-ffa450edef68
2017-08-31 20:20:24 +00:00
Tim Allison
235d102f26 61475 -- append text from pictures only once...bug from my work on 61470.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1806839 13f79535-47bb-0310-9956-ffa450edef68
2017-08-31 19:14:43 +00:00
Tim Allison
3b32a00aa7 61470 -- add extraction of content within ruby elements; allow users to concatenate or not concatenate phonetic strings. Default is to concatenate.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1806712 13f79535-47bb-0310-9956-ffa450edef68
2017-08-30 16:29:52 +00:00
Greg Woolsey
914ae602b1 Fixes bug #61468, caused by a confusing OOXML spec design as noted in JavaDocs added in r1795648.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1806623 13f79535-47bb-0310-9956-ffa450edef68
2017-08-29 17:14:52 +00:00
Dominik Stadler
20fa8328f4 Verify that bug 61294 is fixed now, add some more coverage for IOUtils in general
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1806162 13f79535-47bb-0310-9956-ffa450edef68
2017-08-25 11:51:18 +00:00
Dominik Stadler
34f35b2d0e Revert performance tuning done via Bug 61350 as it lead to problems when running multi-threaded large regression tests.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1806077 13f79535-47bb-0310-9956-ffa450edef68
2017-08-24 19:46:39 +00:00
Dominik Stadler
2108f82449 Fix 60384 and 60709: When shifting with merged regions we should correctly check if the region is moved along or needs to be removed because it is not fully kept via the shifting. This was broken by the fix for bug 59740, now additional unit tests ensure that it works better.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1805518 13f79535-47bb-0310-9956-ffa450edef68
2017-08-19 16:31:45 +00:00
Dominik Stadler
b233345510 Add more non-test classes in OOXMLLite and add another font-metric that appears
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1805516 13f79535-47bb-0310-9956-ffa450edef68
2017-08-19 16:31:28 +00:00
Greg Woolsey
5e5adc70e5 Bug 61431 - Conditional formatting evaluation ignores undefined cells
now evaluating based on cell references instead, and watching out for undefined cells in rules that require a cell.

Added unit test based on previously failing file.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1805245 13f79535-47bb-0310-9956-ffa450edef68
2017-08-16 23:52:27 +00:00
Andreas Beeker
6f341568b6 #61381 - PushbackInputStreams passed to ZipHelper may not hold 8 bytes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1804854 13f79535-47bb-0310-9956-ffa450edef68
2017-08-11 20:47:48 +00:00
Nick Burch
9ae6952845 Add an example of trying multiple passwords against an OOXML file. More a demo than anything, GPU enabled tools are much faster!
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1804667 13f79535-47bb-0310-9956-ffa450edef68
2017-08-10 12:43:16 +00:00
PJ Fanning
9fa3e36e9a [Bug-61048] SXSSF module writes wrong escape sequence for carriage returns
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1804596 13f79535-47bb-0310-9956-ffa450edef68
2017-08-09 18:37:14 +00:00
Dominik Stadler
b3ad734de1 Assert on the contents of the byte-array to see if the problem happens during writing the data or reading it back in
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803614 13f79535-47bb-0310-9956-ffa450edef68
2017-08-01 06:26:44 +00:00
Dominik Stadler
c7e1fabf1c Reformat code slightly
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803612 13f79535-47bb-0310-9956-ffa450edef68
2017-08-01 06:26:27 +00:00
Andreas Beeker
97f90ca839 Fix further Windows JVM 6 font rendering errors - OOM and EXCEPTION_ACCESS_VIOLATION
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803528 13f79535-47bb-0310-9956-ffa450edef68
2017-07-31 12:25:23 +00:00