Commit Graph

9423 Commits

Author SHA1 Message Date
Javen O'Neal
7cb0588daf add @Internal annotation to methods that return a CT* class
add @Override annotation where missing

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800360 13f79535-47bb-0310-9956-ffa450edef68
2017-06-30 07:45:46 +00:00
Greg Woolsey
07a7987a48 Expose one more bit of style information generically (for XSSF). If someone needs all these properties for HSSF charts as well, we can build a new Interface for the various bits and populate it with things like axis line width and color, etc. but for now I think most users are in the XSSF realm like me.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800341 13f79535-47bb-0310-9956-ffa450edef68
2017-06-29 23:06:27 +00:00
Nick Burch
2cbd15ece2 Deprecated xssfSheetIterator has been removed, so remove javadoc reference
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800288 13f79535-47bb-0310-9956-ffa450edef68
2017-06-29 14:38:41 +00:00
Andreas Beeker
b2d19936ef remove temporary jenkins debug output
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800263 13f79535-47bb-0310-9956-ffa450edef68
2017-06-29 10:49:22 +00:00
Andreas Beeker
1ce039753a remove timezoned call to Date.toString() - SignatureProperties don't necessarily need an Id attribute
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800257 13f79535-47bb-0310-9956-ffa450edef68
2017-06-29 09:33:33 +00:00
PJ Fanning
2ec623fe0b remove deprecated org.apache.poi.hssf.record.RecordFormatException
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800256 13f79535-47bb-0310-9956-ffa450edef68
2017-06-29 09:06:30 +00:00
PJ Fanning
af35e389da remove some unused imports
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800255 13f79535-47bb-0310-9956-ffa450edef68
2017-06-29 08:55:35 +00:00
PJ Fanning
5f6e2b780a remove deprecated POIXMLDocument.hasOOXMLHeader
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800254 13f79535-47bb-0310-9956-ffa450edef68
2017-06-29 08:45:00 +00:00
PJ Fanning
1281127420 remove deprecated org.apache.poi.hssf.record.RecordFormatException
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800249 13f79535-47bb-0310-9956-ffa450edef68
2017-06-29 08:37:02 +00:00
PJ Fanning
657784ce1a Remove old XSSFWorkbook wb.xssfSheetIterator method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800248 13f79535-47bb-0310-9956-ffa450edef68
2017-06-29 08:15:50 +00:00
PJ Fanning
4bcc0f4eb1 Remove old XSSFPaswordHelper
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800247 13f79535-47bb-0310-9956-ffa450edef68
2017-06-29 08:10:32 +00:00
Nick Burch
b3149fe1ad Fix javadoc warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800214 13f79535-47bb-0310-9956-ffa450edef68
2017-06-28 23:30:15 +00:00
Nick Burch
07c18a9055 Used deprecated external method removed, so remove internal method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800212 13f79535-47bb-0310-9956-ffa450edef68
2017-06-28 23:29:58 +00:00
Nick Burch
a658a7f573 Used deprecated external method removed, so remove internal method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800211 13f79535-47bb-0310-9956-ffa450edef68
2017-06-28 23:25:41 +00:00
Andreas Beeker
9ef695aedf add debugging info to find signature differences
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800209 13f79535-47bb-0310-9956-ffa450edef68
2017-06-28 23:04:25 +00:00
PJ Fanning
5c65b55bd4 Ensure SpreadsheetVersion is set for AreaReferences
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800208 13f79535-47bb-0310-9956-ffa450edef68
2017-06-28 22:11:26 +00:00
Andreas Beeker
51b46a9e4e Bug 61182 - Invalid signature created for streamed xslx file
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800207 13f79535-47bb-0310-9956-ffa450edef68
2017-06-28 21:38:23 +00:00
PJ Fanning
4209a1b2da Remove some deprecated *SSF APIs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800147 13f79535-47bb-0310-9956-ffa450edef68
2017-06-28 10:34:37 +00:00
Nick Burch
a753adb848 Add import for javadocs references
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799832 13f79535-47bb-0310-9956-ffa450edef68
2017-06-25 19:16:36 +00:00
PJ Fanning
03d4e52bc0 expand StaxHelper
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799772 13f79535-47bb-0310-9956-ffa450edef68
2017-06-24 13:53:47 +00:00
Andreas Beeker
196b1429fc prepare for 3.17-beta2
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799747 13f79535-47bb-0310-9956-ffa450edef68
2017-06-24 09:27:28 +00:00
Andreas Beeker
85963a56f7 rollback invalid commit - r1799740
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799742 13f79535-47bb-0310-9956-ffa450edef68
2017-06-24 09:20:02 +00:00
Andreas Beeker
6aae53935a release prepare for 3.17-beta1 - pin documentation
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799740 13f79535-47bb-0310-9956-ffa450edef68
2017-06-24 09:03:00 +00:00
PJ Fanning
61b0ecbd4b Add StaxHelper to ensure that StAX parsers have sensible defaults, including settings to avoid XML Entity Expansion issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799734 13f79535-47bb-0310-9956-ffa450edef68
2017-06-24 07:30:07 +00:00
Greg Woolsey
972d561897 Add file that failed regression tests as a unit test.
Adjust table style processing to allow for AlternateContent wrappers for table element style definitions.  


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799733 13f79535-47bb-0310-9956-ffa450edef68
2017-06-24 05:55:45 +00:00
PJ Fanning
eee5205d0c [Bug 60422] Fix forbidden-api build issue
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799723 13f79535-47bb-0310-9956-ffa450edef68
2017-06-24 00:37:03 +00:00
PJ Fanning
c1cc93a2ef [Bug 60422] Tidy up test case
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799722 13f79535-47bb-0310-9956-ffa450edef68
2017-06-24 00:15:20 +00:00
PJ Fanning
66b39c70ad Bug 60422 add testtestcase with current LocaleUtil workaround
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799721 13f79535-47bb-0310-9956-ffa450edef68
2017-06-23 23:42:25 +00:00
Greg Woolsey
0e23e4e9d8 Move my new unit conversions to the Units class, move and deprecate duplicate and scattered unit constants, update constant references to standardize on the ones in the Units class.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799683 13f79535-47bb-0310-9956-ffa450edef68
2017-06-23 15:43:48 +00:00
Greg Woolsey
12048f528b Bug 61203
one of these days I'll add the copyright to my project templates.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799645 13f79535-47bb-0310-9956-ffa450edef68
2017-06-23 06:17:09 +00:00
Greg Woolsey
8c67848ad6 Bug 61203 - XSSFDrawing.getAnchorFromParent handles CTOneCellAnchor incorrectly, ignores CTAbsoluteAnchor
This is likely incomplete, but closer to where things should be.  It is backward compatible with previous uses of XSSFClientAnchor.

This fixes a bug in XSSFGraphicFrame that was hiding the parent class anchor property (which is a protected field set directly from XSSFDrawing).  This is a peril of using direct property access - the hiding wasn't obvious because there was no setter being overridden.

XSSFGraphicFrame now notices when it relates to a chart, and setts the frame property of the XSSFChart.  That was not being set on parse previously, only when creating charts from scratch.  That didn't seem right.

XSSFClientAnchor now calculates size and position correctly based on initial inputs from the different types of anchors.  It DOES NOT update those initial inputs, however.  It does properly adjust if the size or initial position are absolute and the corresponding row/column values are requested.

Added new class EMUUtils to centralize the measurement constants and conversions since there are so many units in play in the OOXML spec and POI APIs:

* EMUs (English Metric Units)
* Inches
* Centimeters
* Points
* Pixels
* Twips (1/20th of a point)

I'm sure there are more conversions that could be done there, I just started with what I needed.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799643 13f79535-47bb-0310-9956-ffa450edef68
2017-06-23 05:16:38 +00:00
Tim Allison
649280df8c bug 61045 -- allow for (and log!) extra bytes in FormatRecord.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799360 13f79535-47bb-0310-9956-ffa450edef68
2017-06-20 18:11:34 +00:00
Tim Allison
fe5f8fb54c bug 61053 -- not a fix, but this aligns XSSFBSheetHandler's behavior with streaming and non-streaming extractors for xlsx
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799345 13f79535-47bb-0310-9956-ffa450edef68
2017-06-20 12:59:33 +00:00
Javen O'Neal
c0e5fcaa98 javadoc
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799332 13f79535-47bb-0310-9956-ffa450edef68
2017-06-20 09:52:43 +00:00
Javen O'Neal
1866c69754 @Ignore("requires an internet connection to a 3rd party site"
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799326 13f79535-47bb-0310-9956-ffa450edef68
2017-06-20 09:16:05 +00:00
Javen O'Neal
9326624d76 unit test that is not written yet should fail
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799324 13f79535-47bb-0310-9956-ffa450edef68
2017-06-20 09:13:18 +00:00
Javen O'Neal
de9134c1d8 simplify unit test code with IOUtils.write to a NullOutputStream
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799323 13f79535-47bb-0310-9956-ffa450edef68
2017-06-20 09:12:42 +00:00
Nick Burch
4a51090ae7 Javadoc fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799320 13f79535-47bb-0310-9956-ffa450edef68
2017-06-20 09:04:02 +00:00
Javen O'Neal
171692edf2 bug 57919: close opened resources
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799316 13f79535-47bb-0310-9956-ffa450edef68
2017-06-20 08:13:58 +00:00
Javen O'Neal
46b5d839c3 bug 57919: add functions to write and close a POIDocument, guaranteeing closure of the output stream and document.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799308 13f79535-47bb-0310-9956-ffa450edef68
2017-06-20 07:28:14 +00:00
Javen O'Neal
5971083683 rename createXls and createXlsx helper functions: these are specifically for testing text rotation.
Made the file creation compatible on Windows and Mac/Linux using POI TempFile instead of a hard-coded filename.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799307 13f79535-47bb-0310-9956-ffa450edef68
2017-06-20 07:05:08 +00:00
Javen O'Neal
51065c8159 bug 58113: this passes with SXSSF now
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799306 13f79535-47bb-0310-9956-ffa450edef68
2017-06-20 07:03:13 +00:00
Javen O'Neal
15212e0feb bug 56557: open test-data/spreadsheet/56557.xlsx such that the unit test test56557() does not leave a modified file on disk after running.
I verified that
> Workbook wb = XSSFTestDataSamples.openSampleWorkbook("56557.xlsx")
and
> Workbook wb = WorkbookFactory.create(XSSFTestDataSamples.getSampleFile("56557.xlsx"), password=null, readOnly=false);
both fail when the fix from r1798913 for SXSSFWorkbook is not applied and both pass when the fix is applied.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799304 13f79535-47bb-0310-9956-ffa450edef68
2017-06-20 06:08:38 +00:00
Javen O'Neal
4d692223bb whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799303 13f79535-47bb-0310-9956-ffa450edef68
2017-06-20 05:51:48 +00:00
Javen O'Neal
5de40d3261 bug 52063: support 2-argument LOOKUP(lookup_value, array) function in Excel
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799302 13f79535-47bb-0310-9956-ffa450edef68
2017-06-20 05:47:56 +00:00
Dominik Stadler
2095c92402 Improve error message if we encounter invalid/unexpected files in integration tests
Adjust some tests slightly

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799178 13f79535-47bb-0310-9956-ffa450edef68
2017-06-19 11:05:20 +00:00
Dominik Stadler
66bf6c5ad7 Need to do the casting differently to make the code compile with Java 6
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799038 13f79535-47bb-0310-9956-ffa450edef68
2017-06-18 05:59:31 +00:00
Dominik Stadler
128ba623f8 Don't try to clone a chart, this makes integration-tests work for a few more documents, also the one added via bug 56557
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799037 13f79535-47bb-0310-9956-ffa450edef68
2017-06-18 05:59:25 +00:00
Dominik Stadler
a37f6a4997 Update forbidden-apis to version 2.3
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799036 13f79535-47bb-0310-9956-ffa450edef68
2017-06-18 05:59:16 +00:00
Dominik Stadler
bac17be565 Fix some IntelliJ warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799035 13f79535-47bb-0310-9956-ffa450edef68
2017-06-18 05:59:11 +00:00