Commit Graph

5812 Commits

Author SHA1 Message Date
Nick Burch
3db4f0b82c Allow creating a CollaboratingWorkbooksEnvironment from a Map too, not only a pair of arrays
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612218 13f79535-47bb-0310-9956-ffa450edef68
2014-07-21 09:44:21 +00:00
Nick Burch
d43121661c Correct non-sheet-based NameXPxg formula rendering, and add tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612203 13f79535-47bb-0310-9956-ffa450edef68
2014-07-21 07:35:09 +00:00
Nick Burch
1179ca9c26 More unit tests for #56737 and #56752
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612157 13f79535-47bb-0310-9956-ffa450edef68
2014-07-20 19:24:42 +00:00
Nick Burch
146c39e070 Comments updates
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612156 13f79535-47bb-0310-9956-ffa450edef68
2014-07-20 19:13:45 +00:00
Nick Burch
05dc1ec70c Change how we update sheet names in XSSF formulas and names, when renaming sheets, to take advantage of the simpler structure that Pxg now offers
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612151 13f79535-47bb-0310-9956-ffa450edef68
2014-07-20 18:56:35 +00:00
Nick Burch
a550397ac2 XSSF Pxgs must escape sheet names where required when generating the formula string
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612150 13f79535-47bb-0310-9956-ffa450edef68
2014-07-20 18:53:27 +00:00
Nick Burch
44a6aef699 Common interface across the XSSF Ptg / Pxg classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612149 13f79535-47bb-0310-9956-ffa450edef68
2014-07-20 18:48:48 +00:00
Nick Burch
4345b06cab Rename missing from previous commit
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612140 13f79535-47bb-0310-9956-ffa450edef68
2014-07-20 18:14:47 +00:00
Nick Burch
42cd819573 Update the formula evaluator to support XSSF style external named ranges too
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612133 13f79535-47bb-0310-9956-ffa450edef68
2014-07-20 17:51:51 +00:00
Nick Burch
0b1dee9913 Better reporting on why a test is failing, and partial NameXPxg eval
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611969 13f79535-47bb-0310-9956-ffa450edef68
2014-07-19 21:27:28 +00:00
Nick Burch
81869b869d Complete the XSSF Formula Parser tests for #56737
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611963 13f79535-47bb-0310-9956-ffa450edef68
2014-07-19 21:00:21 +00:00
Nick Burch
ed7140b3d8 Move towards supporting same workbook named ranges in external style for xssf
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611961 13f79535-47bb-0310-9956-ffa450edef68
2014-07-19 20:51:23 +00:00
Nick Burch
58096a6862 Start to add XSSF specific handling for NameX (named ranges or functions from another file) #56737
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611958 13f79535-47bb-0310-9956-ffa450edef68
2014-07-19 20:30:31 +00:00
Nick Burch
86ca81d22f Provide XSSF-style external sheet support for areas, similar to the recent cell reference support. #56737
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611950 13f79535-47bb-0310-9956-ffa450edef68
2014-07-19 19:42:07 +00:00
Nick Burch
84b50e845e Fix inconsistent indents/whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611949 13f79535-47bb-0310-9956-ffa450edef68
2014-07-19 19:23:13 +00:00
Nick Burch
2cd4290460 Start to update how the formula parser looks up sheets from formula ptgs, to account for the differences in how HSSF and XSSF store references to external sheets. For #56737
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611948 13f79535-47bb-0310-9956-ffa450edef68
2014-07-19 19:19:06 +00:00
Nick Burch
0986f32d46 Fix inconsistent indents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611947 13f79535-47bb-0310-9956-ffa450edef68
2014-07-19 19:11:54 +00:00
Nick Burch
c392b4fa72 The Event User Model fake-workbook for formula evaluations needs to know about the sheet names
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611946 13f79535-47bb-0310-9956-ffa450edef68
2014-07-19 19:10:47 +00:00
Nick Burch
fbcf64087d Fix Generics warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611944 13f79535-47bb-0310-9956-ffa450edef68
2014-07-19 19:00:09 +00:00
Nick Burch
7c382f9f37 The way that HSSF and XSSF stores references to external sheets are rather different, so begin to reflect that in how we parse their formulas into Ptgs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611906 13f79535-47bb-0310-9956-ffa450edef68
2014-07-19 12:49:41 +00:00
Nick Burch
1ed2a18323 There can be more than one linked ExternalLinks table for a workbook #56744
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611890 13f79535-47bb-0310-9956-ffa450edef68
2014-07-19 11:27:46 +00:00
Nick Burch
7d2a9093da Turns out that .xlsx files can have multiple link tables, add a test file which shows this (support to follow)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611878 13f79535-47bb-0310-9956-ffa450edef68
2014-07-19 10:09:00 +00:00
Nick Burch
c386b48755 Convert test to junit 4, and stub out the additional 3d ref tests we need to pass for #56737
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611877 13f79535-47bb-0310-9956-ffa450edef68
2014-07-19 10:08:20 +00:00
Nick Burch
58d3cd3717 Stub the unit test which is the next thing to need to work for progress on #56737
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611833 13f79535-47bb-0310-9956-ffa450edef68
2014-07-18 23:02:51 +00:00
Nick Burch
551573dd95 Bit more towards XSSF name support for #56737, will need some deeper changes though to fully implement
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611830 13f79535-47bb-0310-9956-ffa450edef68
2014-07-18 22:50:54 +00:00
Nick Burch
611bcffb0c Initial support for XSSF External Links tables, which hold references to other workbooks referenced by formulas and names. #56744
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611828 13f79535-47bb-0310-9956-ffa450edef68
2014-07-18 22:48:59 +00:00
Nick Burch
d0db408a2f Leave part disabled for now
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611755 13f79535-47bb-0310-9956-ffa450edef68
2014-07-18 18:30:54 +00:00
Nick Burch
4c362590d8 Start to support formula parsing of sheet-specified named ranges, required for a full fix to bug #56737
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611753 13f79535-47bb-0310-9956-ffa450edef68
2014-07-18 18:30:16 +00:00
Nick Burch
3fd7c0d258 Update bug reference numbers, and bring over part of a test from unfixed that is now working (rest remains broken)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611728 13f79535-47bb-0310-9956-ffa450edef68
2014-07-18 17:27:37 +00:00
Nick Burch
6e37f73018 Have WorkbookEvaluator process NameXPtgs, rather than returning a NameXEval which later places didn't handle. Largely allows us to process the .xls version of the test file for #56737 (but filenames aren't quite the same as in Excel)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611711 13f79535-47bb-0310-9956-ffa450edef68
2014-07-18 16:58:38 +00:00
Nick Burch
d4a1239efa #56737 Sometimes Excel writes an internal reference to a local name in an odd way, without an ExternalNameRecord, try to detect and work around those
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611681 13f79535-47bb-0310-9956-ffa450edef68
2014-07-18 15:59:55 +00:00
Nick Burch
c9d90732e5 Add disabled unit tests for bug #56737, which currently fails (differently) for HSSF and XSSF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611400 13f79535-47bb-0310-9956-ffa450edef68
2014-07-17 16:18:39 +00:00
Nick Burch
696b9d6406 Fix for #56702 - If a cell is of type numeric but has an empty <v/> tag, return as 0
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1610482 13f79535-47bb-0310-9956-ffa450edef68
2014-07-14 18:53:39 +00:00
Nick Burch
b9ff74b050 This bug has been fixed, so re-enable the unit test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1607662 13f79535-47bb-0310-9956-ffa450edef68
2014-07-03 14:46:32 +00:00
Nick Burch
92f1cd20da Add a disabled unit test for bug #56420
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1607661 13f79535-47bb-0310-9956-ffa450edef68
2014-07-03 14:30:47 +00:00
Nick Burch
570b87c885 Update the CheckFunctionsSupported example to take advantage of the new NotImplementedFunctionException to identify the function that is missing
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1607589 13f79535-47bb-0310-9956-ffa450edef68
2014-07-03 11:21:03 +00:00
Nick Burch
dd6819aa13 When throwing an exception during formula evaluation, if this is due to an unimplemented function, have a more specific exception type
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1607588 13f79535-47bb-0310-9956-ffa450edef68
2014-07-03 11:20:32 +00:00
Nick Burch
7bc0767bf5 Formula evaluation and error handling example - reports what cells can't be evaluated, and (TODO) what functions are used but not implemented
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1607583 13f79535-47bb-0310-9956-ffa450edef68
2014-07-03 10:56:25 +00:00
Nick Burch
f33843810a Now that XSSFWorkbook can be closed, the older path based constructor no longer needs to be deprecated #56537
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1607536 13f79535-47bb-0310-9956-ffa450edef68
2014-07-03 05:45:21 +00:00
Dominik Stadler
e34e77b12d Bug 56537: Update javadoc to reflect the addition of Closeable to Workbook
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1607390 13f79535-47bb-0310-9956-ffa450edef68
2014-07-02 15:05:05 +00:00
Dominik Stadler
a8a582e3b2 Upgrade to latest JaCoCo 0.7.1
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1607384 13f79535-47bb-0310-9956-ffa450edef68
2014-07-02 14:48:59 +00:00
Tim Allison
94e9d67258 BUG 54771: add class to svn
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1602960 13f79535-47bb-0310-9956-ffa450edef68
2014-06-16 18:53:28 +00:00
Tim Allison
af7b947bb9 BUG 54771 extract text from SDTs at the cell level within a table row
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1602955 13f79535-47bb-0310-9956-ffa450edef68
2014-06-16 18:46:00 +00:00
Nick Burch
1a969ea635 Make a start on an Ant task to generate an OSGi jar, for #53866
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1602846 13f79535-47bb-0310-9956-ffa450edef68
2014-06-16 11:15:31 +00:00
Dominik Stadler
516ce6c586 Revert upgrade to XMLBeans 2.6.0 to properly discuss on the mailinglist first
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1602075 13f79535-47bb-0310-9956-ffa450edef68
2014-06-12 07:08:21 +00:00
Dominik Stadler
9d1d93b88f Add missing @Overrides, reformat some files, increase coverage slightly,
comments, fix Eclipse warnings and add close() calls in some tests and
in HMEFMessage() to close files during tests correctly.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1602008 13f79535-47bb-0310-9956-ffa450edef68
2014-06-11 20:36:30 +00:00
Dominik Stadler
b9dee7bd46 Update XMLBeans to version 2.6.0
Conflicts:

	.classpath

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1602006 13f79535-47bb-0310-9956-ffa450edef68
2014-06-11 20:32:52 +00:00
Nick Burch
8afc419270 Fix inconsistent indent
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1601930 13f79535-47bb-0310-9956-ffa450edef68
2014-06-11 15:38:26 +00:00
Nick Burch
a1d0c8a260 #56537 close method for SXSSF too
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1601917 13f79535-47bb-0310-9956-ffa450edef68
2014-06-11 14:38:32 +00:00
Nick Burch
47a8f6cf48 Partial fix for #56537 - Have Workbook offer a close() method, which in turn closes the NPOIFS or OPC resource from which it was loaded
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1601901 13f79535-47bb-0310-9956-ffa450edef68
2014-06-11 13:48:54 +00:00