Commit Graph

3190 Commits

Author SHA1 Message Date
Yegor Kozlov
97ceedbbf7 more cleanup and refactoring of the ooxml code:1. removed deprecated methods from xssf and interfaces
2. minimized the accessibility of internal constructors
3. more javadocs


git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ooxml@707839 13f79535-47bb-0310-9956-ffa450edef68
2008-10-25 11:48:50 +00:00
Josh Micich
18e5d2d0db Merged revisions 703100,703197,703302,703596,703620,703645,703651,706540 via svnmerge from
https://svn.apache.org/repos/asf/poi/trunk

........
  r703100 | josh | 2008-10-09 01:33:54 -0700 (Thu, 09 Oct 2008) | 1 line
  
  Removed last occurrences of storing Ptg arrays in Stacks.  Some related clean-up.
........
  r703197 | josh | 2008-10-09 09:10:39 -0700 (Thu, 09 Oct 2008) | 1 line
  
  Should have been submitted with r703100 (changes to Ptg)
........
  r703302 | josh | 2008-10-09 17:40:58 -0700 (Thu, 09 Oct 2008) | 1 line
  
  Fix for bug 45964 - support for link formulas in Text Objects
........
  r703596 | josh | 2008-10-10 15:59:14 -0700 (Fri, 10 Oct 2008) | 1 line
  
  Made RecordInputStream final (major clean-up in test cases and BiffViewer)
........
  r703620 | josh | 2008-10-10 18:11:05 -0700 (Fri, 10 Oct 2008) | 2 lines
  
  fix for bug 45866 - allowed for change of unicode compression across Continue records
........
  r703645 | yegor | 2008-10-11 03:31:24 -0700 (Sat, 11 Oct 2008) | 1 line
  
  fixed error in eval.xml: use &lt; instead of '<'
........
  r703651 | yegor | 2008-10-11 05:01:42 -0700 (Sat, 11 Oct 2008) | 1 line
  
  set trunk version.id=3.3-alpha1
........
  r706540 | yegor | 2008-10-20 23:47:35 -0700 (Mon, 20 Oct 2008) | 1 line
  
  updated release version on the index page, started a new section in the change log
........


git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ooxml@707807 13f79535-47bb-0310-9956-ffa450edef68
2008-10-25 01:47:25 +00:00
Josh Micich
8f89964d1d Further simplification to RecordInputStream. Mostly regarding Strings, ContinueRecords and LittleEndianInput
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@707802 13f79535-47bb-0310-9956-ffa450edef68
2008-10-25 01:02:37 +00:00
Josh Micich
a55f5b5aaa should have been submitted with c707778
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@707780 13f79535-47bb-0310-9956-ffa450edef68
2008-10-24 23:19:26 +00:00
Josh Micich
ffd6eab0da Optimisation of RecordInputStream - removed intermediate 8K byte buffer. Expected performance gain was not realised immediately, so LittleEndianInput stuff has been pushed down into DocumentInputStream to help.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@707778 13f79535-47bb-0310-9956-ffa450edef68
2008-10-24 23:13:44 +00:00
Josh Micich
56a142c735 Fixed test suite name
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@707729 13f79535-47bb-0310-9956-ffa450edef68
2008-10-24 19:25:11 +00:00
Josh Micich
70f4ca4e9c General clean-up in LittleEndian util class. (Some optimization, some obsolete code removal)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@707585 13f79535-47bb-0310-9956-ffa450edef68
2008-10-24 08:58:00 +00:00
Josh Micich
f175e62e37 Simplification and code clean-up
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@707551 13f79535-47bb-0310-9956-ffa450edef68
2008-10-24 05:46:29 +00:00
Josh Micich
9d306f26d0 removing unused code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@707542 13f79535-47bb-0310-9956-ffa450edef68
2008-10-24 04:40:37 +00:00
Josh Micich
a09b170ad4 Removed String methods from LittleEndianInput
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@707541 13f79535-47bb-0310-9956-ffa450edef68
2008-10-24 04:30:38 +00:00
Josh Micich
21a68aae0e added LittleEndianByteArrayInputStream
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@707534 13f79535-47bb-0310-9956-ffa450edef68
2008-10-24 03:47:42 +00:00
Josh Micich
326cf2c32d Further conversion of Ptg classes to use LittleEndian input/output interfaces
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@707525 13f79535-47bb-0310-9956-ffa450edef68
2008-10-24 02:08:47 +00:00
Josh Micich
09fead1ca6 Fix for unicode string bug in StyleRecord. Improvements to WriteAccessRecord.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@707519 13f79535-47bb-0310-9956-ffa450edef68
2008-10-24 00:58:49 +00:00
Josh Micich
812aded595 Converted Ptgs to use LittleEndianOutput
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@707486 13f79535-47bb-0310-9956-ffa450edef68
2008-10-23 22:28:05 +00:00
Josh Micich
1369bb9314 fixed re-serialization of tAttrChoose
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@707481 13f79535-47bb-0310-9956-ffa450edef68
2008-10-23 21:42:05 +00:00
Josh Micich
9f1ad85e0e Fix for bug 45778 - made ObjRecord read sub-record ftLbsData properly
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@707450 13f79535-47bb-0310-9956-ffa450edef68
2008-10-23 19:08:42 +00:00
Yegor Kozlov
dfb6d9f84f 1. important algorithmic improvements of XSSFRow and XSSFSheet, removed LinkedList in favor of TreeMap, that allowed O(Log(N)) performance instead of O(N) when adding new rows and cells2. Revised cell value accessors in XSSFCell. Now both HSSF and XSSF handle various cell types equally. The same exceptions are thrown in case of type mismatch, same behaviour when setting nulls, etc.
3. Moved FormulaError codes out of the Cell interface into enum. Interface isn't a proper place for it
4. Finally finished javadoc on XSSFRow and XSSFCell


git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ooxml@707445 13f79535-47bb-0310-9956-ffa450edef68
2008-10-23 18:57:28 +00:00
Josh Micich
6189c8d1fc Fix for bug 46053 - fixed evaluation cache dependency analysis when changing blank cells
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@706772 13f79535-47bb-0310-9956-ffa450edef68
2008-10-21 21:25:50 +00:00
Yegor Kozlov
b15942d4a8 1. implemented XSSFSheet.autosizeColumn(), for now mostly duplicated HSSF code, will be refactored in future.2. fixed bug #45974: XSSFCell.getCellStyle can return null3. more code cleanup and reaftoring, removed usages of obsolete XSSFCell.getCellNum() in favor of XSSFCell.getColumnIndex(), also more javadoc in core classes
4. fixed a blocker: calling XSSFSheet.getNumMergedRegions() resulted in unreadable workbook, this methods structurally modified worksheet and added unnecessary data 

git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ooxml@706691 13f79535-47bb-0310-9956-ffa450edef68
2008-10-21 17:56:34 +00:00
Yegor Kozlov
9ad77e128b updated release version on the index page, started a new section in the change log
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@706540 13f79535-47bb-0310-9956-ffa450edef68
2008-10-21 06:47:35 +00:00
Yegor Kozlov
82a4bc8cb1 cleanup of POIXMLDocument constructors and related sub-classes
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ooxml@706032 13f79535-47bb-0310-9956-ffa450edef68
2008-10-19 15:31:28 +00:00
Yegor Kozlov
26ec85202e more code cleanup and refactoring: (a) removed references to ooxml schemas from XSSF enums, they should not depend on ooxml-schemas.jar
(b) removed "for testing only" constructors, the goal is to have a single, maximum 2 constructors for objects inherited from POIXMLDocumentPart
(c) more javadocs 


git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ooxml@706003 13f79535-47bb-0310-9956-ffa450edef68
2008-10-19 12:54:40 +00:00
Yegor Kozlov
f90843cd7f applied patch #46003 by Gisella Bronzetti
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ooxml@705701 13f79535-47bb-0310-9956-ffa450edef68
2008-10-17 18:43:37 +00:00
Yegor Kozlov
96d360ff21 applied patches #46004 and #46006 submitted by Gisella Bronzetti
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ooxml@705684 13f79535-47bb-0310-9956-ffa450edef68
2008-10-17 17:44:53 +00:00
Yegor Kozlov
ae00a22c6a should have been included in r705638
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ooxml@705662 13f79535-47bb-0310-9956-ffa450edef68
2008-10-17 16:21:05 +00:00
Yegor Kozlov
59b02716ac more progress on SpreadsheetML drawing layer;finished XSSFPicture, auto-sizing is supported; implemented initial support for shape groups. Common HSSF-XSSF drawing interfaces are still TODO.
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ooxml@705638 13f79535-47bb-0310-9956-ffa450edef68
2008-10-17 15:14:00 +00:00
Yegor Kozlov
9c094be425 refactored POIXMLFactory and related classes; simplified XSSFRelation - now it's just a set of definitions of XSSF relations, all read/load stuff is not used anymore and was removed. Also, removed Workbook.getCustomPallete() - it's OLE-specific
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ooxml@703814 13f79535-47bb-0310-9956-ffa450edef68
2008-10-12 13:10:30 +00:00
Yegor Kozlov
1a700918d8 applied patch #45967 by Gisella Bronzetti: support for XSSFPrintSetup object
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ooxml@703778 13f79535-47bb-0310-9956-ffa450edef68
2008-10-12 10:25:58 +00:00
Yegor Kozlov
b6b88deed5 set trunk version.id=3.3-alpha1
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@703651 13f79535-47bb-0310-9956-ffa450edef68
2008-10-11 12:01:42 +00:00
Yegor Kozlov
96c80f6cfc fixed error in eval.xml: use &lt; instead of '<'
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@703645 13f79535-47bb-0310-9956-ffa450edef68
2008-10-11 10:31:24 +00:00
Josh Micich
7acf9a90b5 fix for bug 45866 - allowed for change of unicode compression across Continue records
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@703620 13f79535-47bb-0310-9956-ffa450edef68
2008-10-11 01:11:05 +00:00
Josh Micich
b2988b3666 Made RecordInputStream final (major clean-up in test cases and BiffViewer)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@703596 13f79535-47bb-0310-9956-ffa450edef68
2008-10-10 22:59:14 +00:00
Yegor Kozlov
6153569465 Initial support for SpreadsheetML drawings,implemented XSSFPicture, added ability to add pictures to workbook, refactored XSSFPictureData to be a subclass of POIXMLDocumentPart. Also refactored misc odds and ends in order to produce xml better compatible with what MS Office produces
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ooxml@703490 13f79535-47bb-0310-9956-ffa450edef68
2008-10-10 14:54:32 +00:00
Josh Micich
b86b4b5ef2 Fix for bug 45964 - support for link formulas in Text Objects
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@703302 13f79535-47bb-0310-9956-ffa450edef68
2008-10-10 00:40:58 +00:00
Josh Micich
f7907b3e5f Should have been submitted with r703100 (changes to Ptg)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@703197 13f79535-47bb-0310-9956-ffa450edef68
2008-10-09 16:10:39 +00:00
Josh Micich
d9075bc8dc Removed last occurrences of storing Ptg arrays in Stacks. Some related clean-up.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@703100 13f79535-47bb-0310-9956-ffa450edef68
2008-10-09 08:33:54 +00:00
Josh Micich
78504dfa20 Merged revisions 703092 via svnmerge from
https://svn.apache.org/repos/asf/poi/trunk

........
  r703092 | josh | 2008-10-09 00:44:37 -0700 (Thu, 09 Oct 2008) | 1 line
  
  converted short HSSFCell.getCellNum to int getColumnIndex
........


git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ooxml@703096 13f79535-47bb-0310-9956-ffa450edef68
2008-10-09 08:03:43 +00:00
Josh Micich
dbc713e083 converted short HSSFCell.getCellNum to int getColumnIndex
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@703092 13f79535-47bb-0310-9956-ffa450edef68
2008-10-09 07:44:37 +00:00
Josh Micich
f7acb6bb7c Merged revisions 703063 via svnmerge from
https://svn.apache.org/repos/asf/poi/trunk

........
  r703063 | josh | 2008-10-08 23:07:36 -0700 (Wed, 08 Oct 2008) | 1 line
  
  Performance optimisation for EvaluationCache.  Changed to use HSSFCell as key into cache entry map.  Reduced dependency information storage for blank cells.  Introduced EvaluationSheet and EvaluationCell interfaces.  Modified HSSFFormulaEvaluator API to have simpler notify~ methods
........


git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ooxml@703083 13f79535-47bb-0310-9956-ffa450edef68
2008-10-09 07:20:46 +00:00
Josh Micich
52c6f5aa0c Merged revisions 701756,702231 via svnmerge from
https://svn.apache.org/repos/asf/poi/trunk

........
  r701756 | josh | 2008-10-05 00:22:12 -0700 (Sun, 05 Oct 2008) | 1 line
  
  Fixing comments and formatting inside Record subclasses
........
  r702231 | josh | 2008-10-06 12:13:41 -0700 (Mon, 06 Oct 2008) | 1 line
  
  Fix for 43354 - made the formula evaluator capable of handling missing function arguments
........


git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ooxml@703070 13f79535-47bb-0310-9956-ffa450edef68
2008-10-09 06:46:17 +00:00
Josh Micich
7e158d23a5 Merged revisions 700479,700493,700916,701302,701569,701598,701747 via svnmerge from
https://svn.apache.org/repos/asf/poi/trunk

........
  r700479 | yegor | 2008-09-30 07:32:37 -0700 (Tue, 30 Sep 2008) | 1 line
  
  reverted the change made in r693085 , see bug #45859
........
  r700493 | yegor | 2008-09-30 08:11:26 -0700 (Tue, 30 Sep 2008) | 1 line
  
  initial support for creating hyperlinks in HSLF, units test are still to do
........
  r700916 | josh | 2008-10-01 13:56:21 -0700 (Wed, 01 Oct 2008) | 1 line
  
  Fixed bug in CellCacheEntry (support for caching blank evaluation results)
........
  r701302 | yegor | 2008-10-02 22:27:06 -0700 (Thu, 02 Oct 2008) | 1 line
  
  fixed bug #45889:rrayIndexOutOfBoundsException when constructing HSLF Table with a single row
........
  r701569 | josh | 2008-10-03 16:50:22 -0700 (Fri, 03 Oct 2008) | 1 line
  
  Fix for bug 45912 - ArrayIndexOutOfBoundsException in EmbeddedObjectRefSubRecord
........
  r701598 | josh | 2008-10-03 21:59:26 -0700 (Fri, 03 Oct 2008) | 1 line
  
  changed workbook reference to index in CellLocation
........
  r701747 | josh | 2008-10-04 21:43:48 -0700 (Sat, 04 Oct 2008) | 1 line
  
  Better bounds checking in RecordInputStream. Removed rarely used methods readShortArray and putShortArray
........


git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ooxml@703069 13f79535-47bb-0310-9956-ffa450edef68
2008-10-09 06:38:50 +00:00
Josh Micich
972ec9b0f5 Performance optimisation for EvaluationCache. Changed to use HSSFCell as key into cache entry map. Reduced dependency information storage for blank cells. Introduced EvaluationSheet and EvaluationCell interfaces. Modified HSSFFormulaEvaluator API to have simpler notify~ methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@703063 13f79535-47bb-0310-9956-ffa450edef68
2008-10-09 06:07:36 +00:00
Josh Micich
aadfcbcb2b Fix for 43354 - made the formula evaluator capable of handling missing function arguments
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@702231 13f79535-47bb-0310-9956-ffa450edef68
2008-10-06 19:13:41 +00:00
Yegor Kozlov
cdfa36cada applied patch #45492 submitted by Gisella Bronzetti,also performed major cleanup of StylesTable and its components, the goal was to ensure that StylesTable works as a cache of styling components, not just a regular store of fill patterns and cell styles.
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ooxml@701797 13f79535-47bb-0310-9956-ffa450edef68
2008-10-05 13:56:28 +00:00
Josh Micich
7eb34c0e77 Fixing comments and formatting inside Record subclasses
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@701756 13f79535-47bb-0310-9956-ffa450edef68
2008-10-05 07:22:12 +00:00
Josh Micich
9897317e8e Better bounds checking in RecordInputStream. Removed rarely used methods readShortArray and putShortArray
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@701747 13f79535-47bb-0310-9956-ffa450edef68
2008-10-05 04:43:48 +00:00
Josh Micich
4bf266b1c7 changed workbook reference to index in CellLocation
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@701598 13f79535-47bb-0310-9956-ffa450edef68
2008-10-04 04:59:26 +00:00
Josh Micich
d0850e433e Fix for bug 45912 - ArrayIndexOutOfBoundsException in EmbeddedObjectRefSubRecord
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@701569 13f79535-47bb-0310-9956-ffa450edef68
2008-10-03 23:50:22 +00:00
Yegor Kozlov
8c23b343cb fixed bug #45889:rrayIndexOutOfBoundsException when constructing HSLF Table with a single row
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@701302 13f79535-47bb-0310-9956-ffa450edef68
2008-10-03 05:27:06 +00:00
Josh Micich
125d197e1b Fixed bug in CellCacheEntry (support for caching blank evaluation results)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@700916 13f79535-47bb-0310-9956-ffa450edef68
2008-10-01 20:56:21 +00:00