Commit Graph

1393 Commits

Author SHA1 Message Date
Nick Burch
1b20215fc7 #57963 Move the WP and SL interface definitions to core from scratchpad, so the OOXML classes can work without scratchpad
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1682204 13f79535-47bb-0310-9956-ffa450edef68
2015-05-28 11:06:18 +00:00
Andreas Beeker
063e74acf6 Fixed some style related corner cases and adapted the tests for it
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/common_sl@1681411 13f79535-47bb-0310-9956-ffa450edef68
2015-05-24 01:10:12 +00:00
Andreas Beeker
78b9be3876 Creating a new slideshow and manipulating existing ones works again :)
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/common_sl@1681389 13f79535-47bb-0310-9956-ffa450edef68
2015-05-23 22:07:05 +00:00
Andreas Beeker
a1c2269e6f A few text handling related fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/common_sl@1680695 13f79535-47bb-0310-9956-ffa450edef68
2015-05-20 23:07:08 +00:00
Andreas Beeker
6520c37b7f Commit changes in common_sl - need to update trunk ...
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/common_sl@1678832 13f79535-47bb-0310-9956-ffa450edef68
2015-05-11 22:07:40 +00:00
Nick Burch
c9c4aee324 #56791 More updates from OPOIFS to NPOIFS
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678802 13f79535-47bb-0310-9956-ffa450edef68
2015-05-11 19:00:12 +00:00
Nick Burch
dd8fc66a0c #56791 More updates from OPOIFS to NPOIFS
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678801 13f79535-47bb-0310-9956-ffa450edef68
2015-05-11 18:59:10 +00:00
Nick Burch
a89a9d673a #56791 More updates from OPOIFS to NPOIFS
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678783 13f79535-47bb-0310-9956-ffa450edef68
2015-05-11 18:04:30 +00:00
Andreas Beeker
2aea517704 HSLF table and example fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/common_sl@1677703 13f79535-47bb-0310-9956-ffa450edef68
2015-05-04 22:31:45 +00:00
Andreas Beeker
02e70fdbfe fixed HSLF text handling
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/common_sl@1677496 13f79535-47bb-0310-9956-ffa450edef68
2015-05-03 23:42:42 +00:00
Andreas Beeker
f0d95c3f8d Added Distributed option to TextAlignment
Added FontAlignment

git-svn-id: https://svn.apache.org/repos/asf/poi/branches/common_sl@1676849 13f79535-47bb-0310-9956-ffa450edef68
2015-04-29 20:26:05 +00:00
Tim Allison
13dc67c73a POI-56998 add some getters to help with list numbering in hwpf
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1676561 13f79535-47bb-0310-9956-ffa450edef68
2015-04-28 15:17:51 +00:00
Andreas Beeker
e6413c3fe7 committing intermediate results - hslf is mostly migrated to common interface - junit tests partly fail - still a few compile errors - xslf drawing works - hslf drawing is not yet tested
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/common_sl@1676365 13f79535-47bb-0310-9956-ffa450edef68
2015-04-27 20:13:43 +00:00
Dominik Stadler
acfc276396 Fix usage of Generics in some classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1674964 13f79535-47bb-0310-9956-ffa450edef68
2015-04-20 19:15:21 +00:00
Dominik Stadler
58145060c2 Fix possible ArrayIndexOutOfBoundsException seen with some word documents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1674954 13f79535-47bb-0310-9956-ffa450edef68
2015-04-20 18:16:30 +00:00
Dominik Stadler
a75cf0b57c Detect if a file is actually PDF instead of .doc similar to how it is already done for RTF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1674951 13f79535-47bb-0310-9956-ffa450edef68
2015-04-20 18:08:24 +00:00
Nick Burch
b3c46f90c1 Patch from Jon Scharff from bug #57820 - Avoid NPE on HSLF Tables with a top position of -1
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1674441 13f79535-47bb-0310-9956-ffa450edef68
2015-04-18 04:16:28 +00:00
Dominik Stadler
b0f0aca92a Eclipse warnings, Generics, unused members in some exapmles and scratchpad classes.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1668480 13f79535-47bb-0310-9956-ffa450edef68
2015-03-22 21:45:03 +00:00
Dominik Stadler
f9961331ff Bug 47304: use fixed encoding when extracting text in WordDocument
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1668367 13f79535-47bb-0310-9956-ffa450edef68
2015-03-22 13:33:43 +00:00
Andreas Beeker
652211b8d2 Snapshot commit - still lots of errors, xslf rendering works, started work on hslf
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/common_sl@1667902 13f79535-47bb-0310-9956-ffa450edef68
2015-03-19 23:44:23 +00:00
Dominik Stadler
666aa6f42a Remove Javadoc/Eclipse warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1666737 13f79535-47bb-0310-9956-ffa450edef68
2015-03-14 19:33:09 +00:00
Dominik Stadler
7bf9b90fb2 Remove some findbugs warnings about missing close of streams, use existing IOUtils.copy() to copy from one stream to another
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1666683 13f79535-47bb-0310-9956-ffa450edef68
2015-03-14 13:18:43 +00:00
Andreas Beeker
a0070048fe committing intermediate results - xslf now compiles - hslf needs to be migrated to common interface - drawing is not yet tested
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/common_sl@1664935 13f79535-47bb-0310-9956-ffa450edef68
2015-03-07 23:35:40 +00:00
Dominik Stadler
0e16d14349 Move test-case to location where the scratchpad-classes are available
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1662712 13f79535-47bb-0310-9956-ffa450edef68
2015-02-27 15:01:46 +00:00
Andreas Beeker
996c9dd93c initial commit - still lots of errors, but I need to switch to a clean trunk for releasing and testing
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/common_sl@1661322 13f79535-47bb-0310-9956-ffa450edef68
2015-02-21 10:56:03 +00:00
Nick Burch
25385edc38 XWPF implementation of some common Paragraph methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1657717 13f79535-47bb-0310-9956-ffa450edef68
2015-02-05 23:31:59 +00:00
Nick Burch
483982caad Stub a common WP paragraph class, needs uncommenting as XWPF implements/emulates
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1657712 13f79535-47bb-0310-9956-ffa450edef68
2015-02-05 23:20:43 +00:00
Nick Burch
c526206e0d More common HWPF/XWPF interfaces
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1657634 13f79535-47bb-0310-9956-ffa450edef68
2015-02-05 17:35:09 +00:00
Nick Burch
1f2fc6c08b More common XWPF/HWPF character run methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1657631 13f79535-47bb-0310-9956-ffa450edef68
2015-02-05 17:25:02 +00:00
Nick Burch
a351b66fde XWPF double strikethrough, and start on a common interface for HWPF and XWPF character runs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1657624 13f79535-47bb-0310-9956-ffa450edef68
2015-02-05 17:00:08 +00:00
Dominik Stadler
71cf9cd8c3 Remove unnecessary casts
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649310 13f79535-47bb-0310-9956-ffa450edef68
2015-01-04 10:23:24 +00:00
Dominik Stadler
8edf70ec8f Add unit tests for XSSFTextRun and TextPainter, slightly more tests for XSSFSheet and enhance unit tests for XWPFParagraph and ExcelAntTest
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649309 13f79535-47bb-0310-9956-ffa450edef68
2015-01-04 10:23:01 +00:00
Dominik Stadler
5a20499263 Bug 53453: Apply patch to add methods to set margins in sections of HWPF documents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649176 13f79535-47bb-0310-9956-ffa450edef68
2015-01-03 09:34:07 +00:00
Andreas Beeker
0ea9f5fff9 Test and fix for bug #46441
Use generics on Shape.getEscherChild() and SimpleShape.getClientDataRecord() to minimize casting
Unify access to Shape.getEscherOptRecord()

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649152 13f79535-47bb-0310-9956-ffa450edef68
2015-01-02 22:57:05 +00:00
Dominik Stadler
d909e0998c Add verifying test-case for bug 52420
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649147 13f79535-47bb-0310-9956-ffa450edef68
2015-01-02 22:38:52 +00:00
Andreas Beeker
b2a69b6152 Bug 56240 - Handle PP97_DUALSTORAGE streams
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648466 13f79535-47bb-0310-9956-ffa450edef68
2014-12-30 02:20:57 +00:00
Andreas Beeker
de9699fcad Bug 47261 - SlideShow.removeSlide makes PPT corrupted
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648458 13f79535-47bb-0310-9956-ffa450edef68
2014-12-30 01:05:41 +00:00
Andreas Beeker
26ae1edcd8 Bug 49541 - Mapping of symbol characters to unicode equivalent
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648415 13f79535-47bb-0310-9956-ffa450edef68
2014-12-29 19:43:35 +00:00
Andreas Beeker
8e3eee35cd Bug 54541 - Add support for cropped images in Slide.draw()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648335 13f79535-47bb-0310-9956-ffa450edef68
2014-12-29 13:35:57 +00:00
Dominik Stadler
5c76ccba5b Add missing close() of resources in both production code and tests
Use revert() instead of close() on OCPPackage in some places to not re-write the file unnecessarily.
This should now run tests without leftover file handles when checked with file leak detector and
allows to find newly introduced cases more easily.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648160 13f79535-47bb-0310-9956-ffa450edef68
2014-12-28 09:16:57 +00:00
Dominik Stadler
1cf8152d14 Start adding some coverage of more Scratchpad-classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648157 13f79535-47bb-0310-9956-ffa450edef68
2014-12-28 09:08:22 +00:00
Dominik Stadler
5173eca9ea Fix Eclipse warnings, unnecessary casts, use generics, static access...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648156 13f79535-47bb-0310-9956-ffa450edef68
2014-12-28 09:06:12 +00:00
Andreas Beeker
4bed984c0f Charset.forName() for known encodings makes catching UnknownEncodingException obsolete
Unify UTF-16LE conversion to StringUtil
BugFix for RecordInputStream.readFully in combination with continuing records
BugFix for integration tests - fix pathname for handler/exclude lookup on windows

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648032 13f79535-47bb-0310-9956-ffa450edef68
2014-12-27 01:33:28 +00:00
Andreas Beeker
47fe5b9651 Unified access to escher opt record
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647927 13f79535-47bb-0310-9956-ffa450edef68
2014-12-26 00:11:23 +00:00
Andreas Beeker
202aa8177f - Support for Office Binary Document RC4 CryptoAPI Encryption for HSLF
- Support for Office Binary Document RC4 Encryption
- use LittleEndian class in LittleEndianInputStream
- add normalize method for HSLF, to remove edit history, which is also necessary for encryption support
- update PersistDirectoryEntry handling in PersistPtrHolder to recognize groups while serializing
- deprecated PersistPtrHolder.getSlideOffsetDataLocationsLookup() - throws now UnsupportedOperationException,
  as this wasn't used outside the scope of the class and was quite internal logic of PersistPtrHolder


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647867 13f79535-47bb-0310-9956-ffa450edef68
2014-12-25 01:56:29 +00:00
Andreas Beeker
21d2bc3cff #57272 - deadlock on corrupted PPT file
+ some refactoring in HSLFSlideShow, which will be necessary for cryptoapi support 

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1643680 13f79535-47bb-0310-9956-ffa450edef68
2014-12-07 14:34:19 +00:00
Dominik Stadler
81a3425f16 Typo and remove unnecessary casts
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1641941 13f79535-47bb-0310-9956-ffa450edef68
2014-11-26 21:11:18 +00:00
Andreas Beeker
f818d1fdb7 house keeping - fixes for sonarqube blockers
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1634255 13f79535-47bb-0310-9956-ffa450edef68
2014-10-25 21:32:03 +00:00
Nick Burch
0bd50defba Add a disabled unit test for bug #56880
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1630543 13f79535-47bb-0310-9956-ffa450edef68
2014-10-09 17:58:47 +00:00
Andreas Beeker
d60adb500e Bug 56913 - Replace usages of o.a.p.util.ArrayUtil.copyOf* methods with replacements from j.u.Arrays
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1622589 13f79535-47bb-0310-9956-ffa450edef68
2014-09-05 00:31:47 +00:00
Nick Burch
da61e7dd32 Fix bug 54725 - HWPF where no parent style CHP exists, use an empty
set when processing the style to avoid a NPE

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614926 13f79535-47bb-0310-9956-ffa450edef68
2014-07-31 15:41:58 +00:00
Dominik Stadler
379214975e Add unit test for bug 37625 which verifies that this file can now be loaded
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613837 13f79535-47bb-0310-9956-ffa450edef68
2014-07-27 19:57:57 +00:00
Nick Burch
4c98f1db45 Patch from Raúl Wegmann from bug #56735 / GitHub Pull #10 - Rationalise POI temp file creation to the TempFile util class, and allow a system wide setting of where Temp files (eg for SXSSF) go, via TempFile / TempFileCreationStrategy
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613246 13f79535-47bb-0310-9956-ffa450edef68
2014-07-24 18:58:27 +00:00
Nick Burch
bb91152a12 For places where an ordered collection is created and used within the context of a single thread, and there are no thread safety concerns, use ArrayList not Vector. See bug #54838
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613186 13f79535-47bb-0310-9956-ffa450edef68
2014-07-24 16:41:43 +00:00
Dominik Stadler
9d1d93b88f Add missing @Overrides, reformat some files, increase coverage slightly,
comments, fix Eclipse warnings and add close() calls in some tests and
in HMEFMessage() to close files during tests correctly.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1602008 13f79535-47bb-0310-9956-ffa450edef68
2014-06-11 20:36:30 +00:00
Dominik Stadler
927e62f662 Apache POI - Use assertArrayEquals() instead of assertTrue(Arrays.equals()), this way we get better information on failure
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1595190 13f79535-47bb-0310-9956-ffa450edef68
2014-05-16 13:25:45 +00:00
Nick Burch
0bcdc868f3 Based on reading of the new file format docs, start to tweak how fixed length vs variable length / multi-valued properties are handled
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1593861 13f79535-47bb-0310-9956-ffa450edef68
2014-05-11 21:16:40 +00:00
Nick Burch
1a149050ee Outlook sometimes stores a codepage of ANSI when it means 1252, detect and alias, fixes bug #53983
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1593306 13f79535-47bb-0310-9956-ffa450edef68
2014-05-08 15:17:22 +00:00
Nick Burch
50ad48e746 Implement a few more MAPI property types
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1593298 13f79535-47bb-0310-9956-ffa450edef68
2014-05-08 14:49:21 +00:00
Nick Burch
27e48c3b79 Fix inconsistent indents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1593297 13f79535-47bb-0310-9956-ffa450edef68
2014-05-08 14:46:43 +00:00
Andreas Beeker
821d3ca5bd Some encryption fixes:
- don't rely on SecretKey object having the right algorithm set
- leave encryption-description parsing of string/stream to xmlbeans and refactor it to one location
- use namespaces of schema instead of hard-coded strings
- use CryptoFunctions.getMessageDigest() instead of code duplication

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1588874 13f79535-47bb-0310-9956-ffa450edef68
2014-04-21 12:16:54 +00:00
Nick Burch
d2d289b90f Rather than having lots of classes all create their own XML DocumentBuilderFactory instance, push that logic to a helper which sets all the right defaults
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1587739 13f79535-47bb-0310-9956-ffa450edef68
2014-04-15 21:59:52 +00:00
Cédric Walter
1c987c38e6 performance issue: removed instantiation of new String object by copying an existing string.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1583366 13f79535-47bb-0310-9956-ffa450edef68
2014-03-31 16:16:52 +00:00
Cédric Walter
a0d1ab5add performance issue logging calls are expensive because of the objects created when assembling the log messages. Using the check() method of the logging sub-system can prevent object creation
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1583357 13f79535-47bb-0310-9956-ffa450edef68
2014-03-31 15:54:52 +00:00
Nick Burch
3868a2cdc7 Avoid an IndexOutOfBoundsException if there are no property nodes when searching for the start index, return -1 instead
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1578929 13f79535-47bb-0310-9956-ffa450edef68
2014-03-18 14:40:27 +00:00
Nick Burch
1e03ded992 When looking for text run related records after a TextHeaderAtom, provide a cleaner way to skip ones we don't care about, and a cleaner way to find the StyleTextPropAtom. Should fix #56260
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1577803 13f79535-47bb-0310-9956-ffa450edef68
2014-03-15 08:16:43 +00:00
Nick Burch
488647cb43 Implement MasterTextPropAtom, which provides the indents for a run of text, needed for #56260
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1577802 13f79535-47bb-0310-9956-ffa450edef68
2014-03-15 08:14:36 +00:00
Nick Burch
adb98e1073 #56260 Partial fix for a slide with a TextHeaderAtom but no other atoms related to it, which is followed by another TextHeaderAtom straight away
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1577537 13f79535-47bb-0310-9956-ffa450edef68
2014-03-14 13:59:24 +00:00
Nick Burch
7984a1ec3f More helpful visio v5 exception, see bug #56171
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1570388 13f79535-47bb-0310-9956-ffa450edef68
2014-02-20 23:20:19 +00:00
Andreas Beeker
49c69f0eed The junit test failed with the original test-file (CDT_Data_Retention-PPT.ppt), so another check was necessary
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1569999 13f79535-47bb-0310-9956-ffa450edef68
2014-02-20 00:03:42 +00:00
Andreas Beeker
8afdb7a9ce Bug 55732 - PPT can't open, fails with "Couldn't instantiate .... StyleTextProp9Atom : java.lang.ArrayIndexOutOfBoundsException: 56"
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1569984 13f79535-47bb-0310-9956-ffa450edef68
2014-02-19 23:45:07 +00:00
Andreas Beeker
edf1ffd89b upgraded to junit4 (before other changes)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1569972 13f79535-47bb-0310-9956-ffa450edef68
2014-02-19 23:30:12 +00:00
Andreas Beeker
2cfc8dbf17 FindBugs fix
- fixed "Equals method should not assume anything about the type of its argument"
- see http://findbugs.sourceforge.net/bugDescriptions.html#BC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568861 13f79535-47bb-0310-9956-ffa450edef68
2014-02-16 23:36:32 +00:00
Andreas Beeker
53c90692ee FindBugs fix
- fixed "equals() method does not check for null argument"
- see http://findbugs.sourceforge.net/bugDescriptions.html#NP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENT

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568812 13f79535-47bb-0310-9956-ffa450edef68
2014-02-16 19:35:16 +00:00
Andreas Beeker
2a14920cdd FindBugs fix
- fixed/checked various null pointer related entries
- see http://findbugs.sourceforge.net/bugDescriptions.html#NP_NULL_PARAM_DEREF
- ... NP_NULL_ON_SOME_PATH, NP_NULL_ON_SOME_PATH_EXCEPTION


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568789 13f79535-47bb-0310-9956-ffa450edef68
2014-02-16 16:30:24 +00:00
Dominik Stadler
dcad3624dc Fix unit tests broken by newly added test-file, ignore TestFontRendering as it is inherently unstable currently
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568744 13f79535-47bb-0310-9956-ffa450edef68
2014-02-16 09:11:28 +00:00
Dominik Stadler
2414998aac Adjust test to write the failing PNG in case expected and actual do not match
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568740 13f79535-47bb-0310-9956-ffa450edef68
2014-02-16 08:39:17 +00:00
Dominik Stadler
b51a52cf20 Provide more output on test that failed for me locally
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568558 13f79535-47bb-0310-9956-ffa450edef68
2014-02-15 00:21:19 +00:00
Andreas Beeker
92a488a28b FindBugs fix
- fixed "Should be a static inner class"
- see http://findbugs.sourceforge.net/bugDescriptions.html#SIC_INNER_SHOULD_BE_STATIC


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568178 13f79535-47bb-0310-9956-ffa450edef68
2014-02-14 01:00:45 +00:00
Andreas Beeker
3ceb93b23d FindBugs fix
- fixed "Field isn't final but should be"
- see http://findbugs.sourceforge.net/bugDescriptions.html#MS_SHOULD_BE_FINAL


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568145 13f79535-47bb-0310-9956-ffa450edef68
2014-02-13 23:34:11 +00:00
Andreas Beeker
8c3785890a Bug 55902 - Mixed fonts issue with Chinese characters (unable to form images from ppt)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1567455 13f79535-47bb-0310-9956-ffa450edef68
2014-02-11 23:16:54 +00:00
Andreas Beeker
413e76aed0 FindBugs fix
- fixed "Class defines equals() and uses Object.hashCode()"
- see http://findbugs.sourceforge.net/bugDescriptions.html#HE_EQUALS_USE_HASHCODE
- implemented UnicodeString.ExtRst.hashCode() + junit-test

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1566427 13f79535-47bb-0310-9956-ffa450edef68
2014-02-09 21:19:20 +00:00
Nick Burch
fdcd28194e Fix up whitespace / indents to be consistent
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563491 13f79535-47bb-0310-9956-ffa450edef68
2014-02-01 22:05:23 +00:00
Nick Burch
c5823a746f Fix javadoc formatting
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563489 13f79535-47bb-0310-9956-ffa450edef68
2014-02-01 21:58:24 +00:00
Nick Burch
2b0c8deb2f Expose the StyleIndex of CharacterRuns, and expand the range style tests to cover this + related
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563486 13f79535-47bb-0310-9956-ffa450edef68
2014-02-01 21:52:19 +00:00
Andreas Beeker
439ad29071 Added license headers
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1559297 13f79535-47bb-0310-9956-ffa450edef68
2014-01-18 00:38:04 +00:00
Andreas Beeker
c148f9c3e5 javadoc fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1557290 13f79535-47bb-0310-9956-ffa450edef68
2014-01-11 00:14:17 +00:00
Dominik Stadler
5e77641784 remove some unused imports and some useless TODOs, slightly more
coverage, @Overrides, more info on failing test, fix some Eclipse
warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1554535 13f79535-47bb-0310-9956-ffa450edef68
2013-12-31 15:12:30 +00:00
Andreas Beeker
ae2b93eaa0 Bug 45776 - Fix corrupt file problem using TextRun.setText
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1554077 13f79535-47bb-0310-9956-ffa450edef68
2013-12-29 22:14:05 +00:00
Andreas Beeker
c95d740ee4 Bug 41246 - AIOOBE with missing notes entries
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553760 13f79535-47bb-0310-9956-ffa450edef68
2013-12-27 23:42:34 +00:00
Andreas Beeker
3ef65e166d Bug 48593 - [PATCH] Multiple Saves Causes Slide Corruption
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553610 13f79535-47bb-0310-9956-ffa450edef68
2013-12-27 00:22:19 +00:00
Andreas Beeker
e34a1f9620 Bug 55579 - [PATCH] Patch for add/embed OLE objects into HSLF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553435 13f79535-47bb-0310-9956-ffa450edef68
2013-12-26 00:46:16 +00:00
Andreas Beeker
2788aca235 javadoc and compiler warning house-keeping
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553428 13f79535-47bb-0310-9956-ffa450edef68
2013-12-25 23:24:04 +00:00
Dominik Stadler
bc7b658ea9 Fix some JavaDoc items that are reported in the build-output
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553404 13f79535-47bb-0310-9956-ffa450edef68
2013-12-25 18:05:41 +00:00
Yegor Kozlov
fdda5f2071 removed pictureFileZero.ppt from svn as requested by the owner, see discussion on @poi-dev from Dec 12, 2013
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1551845 13f79535-47bb-0310-9956-ffa450edef68
2013-12-18 05:26:49 +00:00
Yegor Kozlov
362fec4a01 Bugzilla 55560 : Patch for hiding slides in HSLF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1540295 13f79535-47bb-0310-9956-ffa450edef68
2013-11-09 11:57:21 +00:00
Dominik Stadler
7014abae83 Bug 52400: fix handling some types of TNEF files, make HMEFMessage.HEADER_SIGNATURE int as it is handled as int everywhere, move .dat files to HMEF sample dir, cover some border cases in HMEFMessage, add another .dat sample file
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1538353 13f79535-47bb-0310-9956-ffa450edef68
2013-11-03 12:43:42 +00:00
Dominik Stadler
19630f1a29 Add more output to assertion in test-case that is sometimes failing, see e.g. Jenkins build #170...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1538330 13f79535-47bb-0310-9956-ffa450edef68
2013-11-03 10:11:09 +00:00
Nick Burch
a6b301e485 Fix bug #55733 - XWPFWordExtractor need
s to handle .docx files with neither headers nor footers

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1538044 13f79535-47bb-0310-9956-ffa450edef68
2013-11-01 19:43:46 +00:00
Tim Allison
3e1208af44 Potential NPE in PPExtractor; found while working on TIKA-1171
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1527041 13f79535-47bb-0310-9956-ffa450edef68
2013-09-27 19:35:14 +00:00