moparisthebest/poi
1
0
Fork 0
Code Issues Pull Requests Releases 1 Wiki Activity
9,444 Commits 29 Branches 84 Tags 722 MiB
6b4094650f
Commit Graph

7687 Commits

Author SHA1 Message Date
Andreas Beeker
34c9cffe5d disable ImageIO cache - probably need to set it in every test class or disable it in the beginning of all tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1830520 13f79535-47bb-0310-9956-ffa450edef68
 2018-04-29 21:12:06 +00:00
Andreas Beeker
e0f7014503 #59893 - Forbid calls to InputStream.available 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1830400 13f79535-47bb-0310-9956-ffa450edef68
 2018-04-27 21:38:19 +00:00
Dominik Stadler
2574fd2d3d Streamline assertion-usage in some tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1830296 13f79535-47bb-0310-9956-ffa450edef68
 2018-04-27 06:15:05 +00:00
Dominik Stadler
ad92fcca9e Fix setting active cell in .xls by populating field_6_refs whenever row/column changes, this fixes bug 61905 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1830115 13f79535-47bb-0310-9956-ffa450edef68
 2018-04-25 20:14:07 +00:00
Andreas Beeker
2d6380833a Bug 62187 - commit Commons Compress unrelated changes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1830061 13f79535-47bb-0310-9956-ffa450edef68
 2018-04-25 10:03:39 +00:00
Andreas Beeker
6dc8c3034e #61459 - handle slide layouts in extractor 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1829677 13f79535-47bb-0310-9956-ffa450edef68
 2018-04-20 20:00:46 +00:00
Andreas Beeker
5189313eb4 #61459 - HSLFShape.getShapeName() returns name of shapeType and not the shape name 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1829656 13f79535-47bb-0310-9956-ffa450edef68
 2018-04-20 13:45:18 +00:00
Andreas Beeker
ab390ce170 #62319 - Decommission XSLF-/PowerPointExtractor 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1829653 13f79535-47bb-0310-9956-ffa450edef68
 2018-04-20 12:52:59 +00:00
Dominik Stadler
bc436fcc3d OOXMLLite: improve progress output: count test-classes, not single test-methods 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1829641 13f79535-47bb-0310-9956-ffa450edef68
 2018-04-20 09:46:47 +00:00
Dominik Stadler
2d7fdbc4bc Fix unit test broken with previous check-in 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1829640 13f79535-47bb-0310-9956-ffa450edef68
 2018-04-20 09:45:28 +00:00
Andreas Beeker
15de4bf7a9 Nullpointer fix for slideshow extractor 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1829538 13f79535-47bb-0310-9956-ffa450edef68
 2018-04-19 13:34:52 +00:00
Dominik Stadler
8632f0c47e Add some unit-tests for setActiveCell(), although bug 61905 reports that Excel still does not read this correctly for HSSF workbooks 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1829518 13f79535-47bb-0310-9956-ffa450edef68
 2018-04-19 08:37:17 +00:00
Greg Woolsey
edd87f05b7 add some javadoc to warn that stale cached formula cell values may result in incorrect evaluations, and what to do about it (evaluate formula cells before asking the rule if it applies). 
Doing it for the user turns out to not be that easy, as the FormulaEvaluator instance in use is not known in this context.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1829471 13f79535-47bb-0310-9956-ffa450edef68
 2018-04-18 18:25:08 +00:00
Andreas Beeker
4ba2d64a50 Bug 62092 - Text not extracted from grouped text shapes in HSLF 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1829453 13f79535-47bb-0310-9956-ffa450edef68
 2018-04-18 15:02:02 +00:00
Dominik Stadler
6829dbd447 Close resources correctly when opening encrypted documents in the TextExtractor 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1828378 13f79535-47bb-0310-9956-ffa450edef68
 2018-04-04 19:41:16 +00:00
Dominik Stadler
e9121036cc Bug 62165: Do not close stream when opening succeeds 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1828377 13f79535-47bb-0310-9956-ffa450edef68
 2018-04-04 19:41:10 +00:00
Dominik Stadler
eb4e20cd69 Try to avoid one NPE that popped up in commoncrawl-corpus tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1828375 13f79535-47bb-0310-9956-ffa450edef68
 2018-04-04 19:40:54 +00:00
PJ Fanning
af19295590 fix error message 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1828364 13f79535-47bb-0310-9956-ffa450edef68
 2018-04-04 16:55:46 +00:00
PJ Fanning
16d25b62af [bug-62254] update offset function to support optional offset values 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1828288 13f79535-47bb-0310-9956-ffa450edef68
 2018-04-03 21:51:30 +00:00
Dominik Stadler
2ce07693c5 Add unit tests to include more required classes in poi-ooxml-schemas, add test for bug 62174 so additional schema-classes are included 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1828180 13f79535-47bb-0310-9956-ffa450edef68
 2018-04-02 17:16:16 +00:00
Dominik Stadler
9af2dd7824 OOXMLLite: IDE warnings and add an additional listener to print out progress during running tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1828179 13f79535-47bb-0310-9956-ffa450edef68
 2018-04-02 17:16:07 +00:00
Dominik Stadler
f440933277 Close resources in tests and in case of Exceptions and use try-with-resources. Close the socket-connection during encrpyting/decrypting as soon as it is not needed any more. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1828178 13f79535-47bb-0310-9956-ffa450edef68
 2018-04-02 17:16:01 +00:00
Dominik Stadler
48c8b9af81 Update excludes in OOXMLLite 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1828177 13f79535-47bb-0310-9956-ffa450edef68
 2018-04-02 17:15:49 +00:00
Dominik Stadler
2be766f267 Bug 61267: detect Word v2 files and report that they are not supported in Apache POI 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1828176 13f79535-47bb-0310-9956-ffa450edef68
 2018-04-02 17:15:42 +00:00
PJ Fanning
35fd4f85aa [bug-62216] add test case 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1828174 13f79535-47bb-0310-9956-ffa450edef68
 2018-04-02 15:59:21 +00:00
PJ Fanning
0ec274d46e [bug-62216] Fix issue with SXSSF error cells 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1828144 13f79535-47bb-0310-9956-ffa450edef68
 2018-04-01 16:16:37 +00:00
PJ Fanning
54e533889a [bug-62121] Fixed Power function of negative numbers. Thanks to Bob van den Berge. This closes #104 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1828143 13f79535-47bb-0310-9956-ffa450edef68
 2018-04-01 15:52:13 +00:00
PJ Fanning
3f19729834 [github-103] take latest changes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1828142 13f79535-47bb-0310-9956-ffa450edef68
 2018-04-01 15:37:14 +00:00
PJ Fanning
6ca71f0bb9 add missing license 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1827177 13f79535-47bb-0310-9956-ffa450edef68
 2018-03-19 09:22:46 +00:00
PJ Fanning
aea347d94a [github-103] hsmf: support writing properties. Thanks to Dominik Hölzl. This closes #103 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1827173 13f79535-47bb-0310-9956-ffa450edef68
 2018-03-19 09:10:38 +00:00
PJ Fanning
47fb3691f7 [bug-62176] synchronize temp dir creation 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1826655 13f79535-47bb-0310-9956-ffa450edef68
 2018-03-13 15:12:00 +00:00
Dominik Stadler
fd39985247 Add test for setters/getters of XWPFRun to include morre generated classes in poi-ooxml-schemas. 
See also https://github.com/centic9/poi-on-android/issues/31

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1826464 13f79535-47bb-0310-9956-ffa450edef68
 2018-03-11 21:11:11 +00:00
Andreas Beeker
58a0a100f5 #62159 - Support XML signature over windows certificate store 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1825948 13f79535-47bb-0310-9956-ffa450edef68
 2018-03-06 00:07:20 +00:00
Dominik Stadler
ff96f4c64d Reduce testcase some more, add missing license header 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1825851 13f79535-47bb-0310-9956-ffa450edef68
 2018-03-05 05:14:56 +00:00
Dominik Stadler
feace0e745 Add unit test which verifies that ThresholdInputStream can be used. This currently fails with Java 10 because the reflection relies on internals of class ZipFile that were changed. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1825818 13f79535-47bb-0310-9956-ffa450edef68
 2018-03-04 13:33:38 +00:00
Dominik Stadler
fb2f23678f Some IntelliJ and Javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1825817 13f79535-47bb-0310-9956-ffa450edef68
 2018-03-04 13:33:31 +00:00
Dominik Stadler
f3addac5e0 Fix compiling with current JDK 10 RC build, OOXML-Tests are still failing due to ThresholdInputStream, though. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1825816 13f79535-47bb-0310-9956-ffa450edef68
 2018-03-04 13:33:20 +00:00
PJ Fanning
aee50698a4 use xmlunit for xml diffs in unit tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1825810 13f79535-47bb-0310-9956-ffa450edef68
 2018-03-04 12:24:44 +00:00
PJ Fanning
3716f4a556 remove some deprecated methods 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1825807 13f79535-47bb-0310-9956-ffa450edef68
 2018-03-04 11:47:21 +00:00
PJ Fanning
8d4f3fde68 remove some casts to short 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1825749 13f79535-47bb-0310-9956-ffa450edef68
 2018-03-03 01:48:46 +00:00
PJ Fanning
2688ce9d82 fix license check failure 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1825547 13f79535-47bb-0310-9956-ffa450edef68
 2018-02-28 10:30:05 +00:00
PJ Fanning
b7aafa03fb fix problematic javadoc 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1825542 13f79535-47bb-0310-9956-ffa450edef68
 2018-02-28 10:01:52 +00:00
PJ Fanning
dcbe14abd0 remove XDDFChart workaround that saved workbook to temp file 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1825541 13f79535-47bb-0310-9956-ffa450edef68
 2018-02-28 09:54:58 +00:00
PJ Fanning
590f27e86d [github-98] write data in respective Column in case of XDDFChart. Thanks to Sandeep Tiwari. This closes #98 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1825521 13f79535-47bb-0310-9956-ffa450edef68
 2018-02-27 23:12:53 +00:00
PJ Fanning
daeea27e14 use Integer.toString to convert ints to strings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1825457 13f79535-47bb-0310-9956-ffa450edef68
 2018-02-27 14:24:50 +00:00
PJ Fanning
fef8c69085 tidy up API for font index 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1825409 13f79535-47bb-0310-9956-ffa450edef68
 2018-02-26 20:26:48 +00:00
PJ Fanning
4221ccebda [bug-62055] Fix XSSFImportFromXML table resize. Thanks to Leonard Kappe. This closes #99 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1825315 13f79535-47bb-0310-9956-ffa450edef68
 2018-02-25 17:06:19 +00:00
Greg Woolsey
d144f09d2f Fix for bug #62130. Turns out there were cases when a workbook with multiple edit/save cycles on the same instance would save stale cell data, resulting in incorrect copies. 
Includes new unit test.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1825277 13f79535-47bb-0310-9956-ffa450edef68
 2018-02-24 21:30:47 +00:00
Greg Woolsey
9dff7e2f09 The table auto-filter range should not include table footer rows, while the table range does. POI was using the same for both regardless of footers. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1825182 13f79535-47bb-0310-9956-ffa450edef68
 2018-02-23 23:37:04 +00:00
PJ Fanning
753f6f9dc6 further uptake of int methods for font lookups 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1825103 13f79535-47bb-0310-9956-ffa450edef68
 2018-02-22 22:32:25 +00:00
PJ Fanning
104d4dac06 [bug-62018] use ints to index fonts 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1824826 13f79535-47bb-0310-9956-ffa450edef68
 2018-02-20 00:25:43 +00:00
PJ Fanning
47c1695a08 add apache license to new examples due to rat check failures 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1824489 13f79535-47bb-0310-9956-ffa450edef68
 2018-02-16 14:08:28 +00:00
Nick Burch
24120f228b Unit test to try to reproduce bug #62108 (currenly works though...) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1824451 13f79535-47bb-0310-9956-ffa450edef68
 2018-02-16 11:47:24 +00:00
Nick Burch
269ea2617f Add some write/change code as well for Groovy 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1824378 13f79535-47bb-0310-9956-ffa450edef68
 2018-02-15 22:16:07 +00:00
Nick Burch
8417d99ee6 Commit examples from the JVM Languages page 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1824371 13f79535-47bb-0310-9956-ffa450edef68
 2018-02-15 21:45:47 +00:00
PJ Fanning
51f99aa616 [github-94] Add Range Copier. Thanks to Dragan Jovanović. This closes #94 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1824266 13f79535-47bb-0310-9956-ffa450edef68
 2018-02-14 20:30:01 +00:00
Dominik Stadler
afc3085684 Fix some IntelliJ warnings in XDGF area 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1823988 13f79535-47bb-0310-9956-ffa450edef68
 2018-02-12 15:34:11 +00:00
Alain Béarez
2603eccc96 [bug-57369] support for major and minor unit on XDDFChart axes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1823963 13f79535-47bb-0310-9956-ffa450edef68
 2018-02-12 12:59:38 +00:00
Mark Murphy
0f4c54023e #55953 Added methods to position a table 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1823920 13f79535-47bb-0310-9956-ffa450edef68
 2018-02-12 04:12:06 +00:00
Andreas Beeker
b6fc14300b Update JAXB classes with fixed javadocs for java 8 doclint 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1823910 13f79535-47bb-0310-9956-ffa450edef68
 2018-02-11 22:09:58 +00:00
Mark Murphy
ac7311994a Added missing table border types to XWPF 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1823904 13f79535-47bb-0310-9956-ffa450edef68
 2018-02-11 21:31:32 +00:00
Andreas Beeker
11522974cf #61947 - Remove deprecated classes (POI 4.0.0) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1823894 13f79535-47bb-0310-9956-ffa450edef68
 2018-02-11 20:45:38 +00:00
Andreas Beeker
22659beef2 #62096 - Add support for tabstops 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1823893 13f79535-47bb-0310-9956-ffa450edef68
 2018-02-11 20:39:18 +00:00
Andreas Beeker
ae65b5cb4a FindBugs fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1823892 13f79535-47bb-0310-9956-ffa450edef68
 2018-02-11 20:35:11 +00:00
Mark Murphy
32f3b22d08 Add ability to set get and remove outer borders for tables 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1823873 13f79535-47bb-0310-9956-ffa450edef68
 2018-02-11 18:43:20 +00:00
Dominik Stadler
316041521c Bug 62042: Adjust gradle build to properly set the locale 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1823596 13f79535-47bb-0310-9956-ffa450edef68
 2018-02-08 19:34:22 +00:00
Dominik Stadler
d0adab9aee Various smaller adjustments: Remove filename in test, remove unused parameters, fix a few simple typos in JavaDoc and add more JavaDoc and some more tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1823595 13f79535-47bb-0310-9956-ffa450edef68
 2018-02-08 19:34:16 +00:00
PJ Fanning
ac763a24ad fix further typo in exception message 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1822948 13f79535-47bb-0310-9956-ffa450edef68
 2018-02-02 11:59:58 +00:00
Dominik Stadler
a487bee768 Fix small typo, closes PR #97 on Github. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1822937 13f79535-47bb-0310-9956-ffa450edef68
 2018-02-02 10:35:48 +00:00
PJ Fanning
940f438eaf fix findbug issues introduced recently 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1822758 13f79535-47bb-0310-9956-ffa450edef68
 2018-01-31 05:52:46 +00:00
PJ Fanning
3f2ae2ee4b fix use of forbidden apis in row shift code 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1822743 13f79535-47bb-0310-9956-ffa450edef68
 2018-01-31 05:31:31 +00:00
PJ Fanning
5afe7c20ab use spaces for indents in some files 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1822720 13f79535-47bb-0310-9956-ffa450edef68
 2018-01-31 00:09:51 +00:00
PJ Fanning
bf20eafa7d [bug-55713] Wrong ErrorStyle for DataValidations. Thanks to Philemon Schucker. This closes #95 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1822719 13f79535-47bb-0310-9956-ffa450edef68
 2018-01-31 00:00:17 +00:00
PJ Fanning
de2b6ba095 add missing licenses to source code 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1822641 13f79535-47bb-0310-9956-ffa450edef68
 2018-01-30 13:31:16 +00:00
PJ Fanning
25634cf55f [github-81] Formula adjusting in context of column shifting. Thanks to Dragan Jovanović. This closes #81 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1822639 13f79535-47bb-0310-9956-ffa450edef68
 2018-01-30 13:16:49 +00:00
PJ Fanning
4637ffcbca [bug-62038] add mockito based unit test 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1822517 13f79535-47bb-0310-9956-ffa450edef68
 2018-01-29 15:21:59 +00:00
PJ Fanning
6dc0f74269 ignore broken test temporarily 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1822409 13f79535-47bb-0310-9956-ffa450edef68
 2018-01-27 14:18:05 +00:00
PJ Fanning
ee8dc42e36 some changes to allow shared string table to be subclassed 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1822404 13f79535-47bb-0310-9956-ffa450edef68
 2018-01-27 13:30:52 +00:00
PJ Fanning
a6faf34d92 [github-90] change default DSIG algorithm to SHA256. Thanks to Jörn Franke. This closes #90 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1822293 13f79535-47bb-0310-9956-ffa450edef68
 2018-01-26 13:30:32 +00:00
PJ Fanning
aca52d2a51 bouncycastle 1.59 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1822285 13f79535-47bb-0310-9956-ffa450edef68
 2018-01-26 12:38:49 +00:00
PJ Fanning
7e434aa155 [bug-62038] handle null font size in XSLFTextRun copy 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1822253 13f79535-47bb-0310-9956-ffa450edef68
 2018-01-26 07:51:57 +00:00
Alain Béarez
a5d2574538 code cleaning according to code review recommendations (closes #93) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1822224 13f79535-47bb-0310-9956-ffa450edef68
 2018-01-25 19:59:52 +00:00
Tim Allison
db3e8697f7 related to Bug 61991 -- include docx in test suite to trigger inclusion of CTPictureBase 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1822033 13f79535-47bb-0310-9956-ffa450edef68
 2018-01-23 18:05:23 +00:00
PJ Fanning
48a5e63ad7 [Bug 61972] Adding chart in Document of MS-Word File without reading Temp MS-Word File. Thanks to Sandeep Tiwari. This closes #91 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1821764 13f79535-47bb-0310-9956-ffa450edef68
 2018-01-20 23:01:18 +00:00
PJ Fanning
d12d1afa23 remove unnecessary test override 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1820652 13f79535-47bb-0310-9956-ffa450edef68
 2018-01-09 12:23:37 +00:00
Alain Béarez
5f0072983b introduce XDDFShapeProperties as user model API (closes #72 from GitHub) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1820369 13f79535-47bb-0310-9956-ffa450edef68
 2018-01-06 02:51:53 +00:00
PJ Fanning
d4df69570c [github-86] expose language for Text Runs. Thanks to Geoff Baskwill. This closes #86 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1820242 13f79535-47bb-0310-9956-ffa450edef68
 2018-01-04 23:32:14 +00:00
Dominik Stadler
859ce548a4 Deprecate methods with typos and provide new ones. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819776 13f79535-47bb-0310-9956-ffa450edef68
 2018-01-01 14:39:48 +00:00
Dominik Stadler
6ac8433953 Bug 61937: Add more javadoc 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819774 13f79535-47bb-0310-9956-ffa450edef68
 2018-01-01 14:39:38 +00:00
Dominik Stadler
214695e09c Bug 61543: do not fail with "part already exists" when tables are created/removed 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819773 13f79535-47bb-0310-9956-ffa450edef68
 2018-01-01 14:39:33 +00:00
Dominik Stadler
e05a94e8ee Bug 61550: Add more information to exception text and verify that it is thrown 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819772 13f79535-47bb-0310-9956-ffa450edef68
 2018-01-01 14:39:26 +00:00
Dominik Stadler
33d5bf0961 Bug 61648: Test Sheet.setArrayFormula for SXSSF 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819770 13f79535-47bb-0310-9956-ffa450edef68
 2018-01-01 14:39:15 +00:00
Dominik Stadler
bc4eb140c5 Add test which verifies that bug 61652 is not appearing any more on latest trunk 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819769 13f79535-47bb-0310-9956-ffa450edef68
 2018-01-01 14:39:08 +00:00
Dominik Stadler
d4e89724c7 Update some tests and IntelliJ warnings 
Ignore disabled test instead of not listing it in the test-report at all

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819768 13f79535-47bb-0310-9956-ffa450edef68
 2018-01-01 14:38:58 +00:00
PJ Fanning
d10ec59751 Bug-61947 remove deprecated method 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819766 13f79535-47bb-0310-9956-ffa450edef68
 2018-01-01 13:05:31 +00:00
PJ Fanning
272e33e4a8 Bug-61947 remove deprecated method 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819763 13f79535-47bb-0310-9956-ffa450edef68
 2018-01-01 12:23:06 +00:00
PJ Fanning
822608f1a6 Bug-61947 remove deprecated method 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819762 13f79535-47bb-0310-9956-ffa450edef68
 2018-01-01 12:13:53 +00:00
PJ Fanning
ef89809723 Bug-61947 add back deprecated methods (removed by accident) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819761 13f79535-47bb-0310-9956-ffa450edef68
 2018-01-01 11:54:01 +00:00
PJ Fanning
0f390dab17 Bug-61947 remove deprecated method 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819759 13f79535-47bb-0310-9956-ffa450edef68
 2018-01-01 11:47:53 +00:00
PJ Fanning
186736ce11 Bug-61947 remove deprecated method 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819758 13f79535-47bb-0310-9956-ffa450edef68
 2018-01-01 11:42:43 +00:00
Andreas Beeker
95bbbe5678 #61797 - Embed Excel / Ole objects into powerpoint 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819710 13f79535-47bb-0310-9956-ffa450edef68
 2017-12-31 01:14:08 +00:00
Andreas Beeker
45c73e1741 #61943 - SL Common: narrow generics definition because of tighter java9 checks 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819709 13f79535-47bb-0310-9956-ffa450edef68
 2017-12-31 01:05:59 +00:00
Andreas Beeker
2a18d2d4db #61942 - Refactor PackagePartName handling and add getUnusedPartIndex method 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819708 13f79535-47bb-0310-9956-ffa450edef68
 2017-12-31 00:56:07 +00:00
Andreas Beeker
2dc2933f9a #61941 - Move Ole marker generation to Ole10Native 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819706 13f79535-47bb-0310-9956-ffa450edef68
 2017-12-31 00:22:43 +00:00
Andreas Beeker
7d3876cf12 #61940 - Replace ClassID statics with enum 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819705 13f79535-47bb-0310-9956-ffa450edef68
 2017-12-31 00:13:38 +00:00
Andreas Beeker
e262b250d7 #61939 - Provide schema for AlternateContent - provide new ooxml-schemas-1.4.jar 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819690 13f79535-47bb-0310-9956-ffa450edef68
 2017-12-30 22:17:55 +00:00
Yegor Kozlov
ca7549131b Bug 58106: when a cell with a 'master' shared formula is removed, the next cell in the range becomes the master 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819623 13f79535-47bb-0310-9956-ffa450edef68
 2017-12-30 16:34:57 +00:00
Yegor Kozlov
ff6f06cc27 Bugzilla 61116: Formula evaluation fails when using matrix addition within index function call 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819596 13f79535-47bb-0310-9956-ffa450edef68
 2017-12-30 13:11:56 +00:00
Dominik Stadler
24c2b4fabe Disable test which currently breaks with every little change to the resulting XML 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819424 13f79535-47bb-0310-9956-ffa450edef68
 2017-12-28 13:46:00 +00:00
Dominik Stadler
7a50340cbf Bug 61665: Enhance SSPerformanceTest some more to add a warmup run and allow to run with unsynchronized XmlBeans 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819417 13f79535-47bb-0310-9956-ffa450edef68
 2017-12-28 10:53:40 +00:00
Dominik Stadler
9eb8fedf5d Fix bug 61787, which was introduced by bug 58067: Change how deleted content is detected to not incorrectly see too much text as deleted. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819405 13f79535-47bb-0310-9956-ffa450edef68
 2017-12-28 08:45:51 +00:00
Dominik Stadler
451c26874a Bug 61798: Fix usage of getLastCellNum(), unfortunately this is a bit misleading compared to getFirstCellNum()... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819404 13f79535-47bb-0310-9956-ffa450edef68
 2017-12-28 08:45:43 +00:00
Dominik Stadler
eb8fac4f77 Bug 61911: Avoid IndexOutOfBounds access when reading pictures 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819403 13f79535-47bb-0310-9956-ffa450edef68
 2017-12-28 08:45:36 +00:00
Dominik Stadler
822188c49a Fix IntelliJ warnings and code formatting, generalize ExcelToHtmlUtils, use try-with-resources, update/enhance JavaDoc somewhat 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819402 13f79535-47bb-0310-9956-ffa450edef68
 2017-12-28 08:45:26 +00:00
Greg Woolsey
31ae97e748 Added a couple missing null checks. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819398 13f79535-47bb-0310-9956-ffa450edef68
 2017-12-28 08:17:33 +00:00
Greg Woolsey
a7a3293fb9 Implement DMAX and DSUM functions, following the pattern from DMIN. 
Refactored the D* function enum to have instances return the function implementation instances rather than using a case construct, now that Java 8 is required.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819376 13f79535-47bb-0310-9956-ffa450edef68
 2017-12-27 22:33:03 +00:00
PJ Fanning
50c0ba01c6 Remove misleading SXSSF logging 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819282 13f79535-47bb-0310-9956-ffa450edef68
 2017-12-26 11:02:45 +00:00
Yegor Kozlov
64d98e7872 Bug 61869: updating a cell with shared formula produces an unreadable file 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818818 13f79535-47bb-0310-9956-ffa450edef68
 2017-12-20 16:30:13 +00:00
PJ Fanning
12f82dd617 use try with resources 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818786 13f79535-47bb-0310-9956-ffa450edef68
 2017-12-20 12:15:35 +00:00
PJ Fanning
7cdaeba856 use try with resources 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818781 13f79535-47bb-0310-9956-ffa450edef68
 2017-12-20 11:47:52 +00:00
PJ Fanning
57dcaedde7 use StandardCharsets 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818629 13f79535-47bb-0310-9956-ffa450edef68
 2017-12-19 00:33:16 +00:00
PJ Fanning
bfff3c7bd8 use StandardCharsets 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818628 13f79535-47bb-0310-9956-ffa450edef68
 2017-12-19 00:23:52 +00:00
PJ Fanning
af11cb1023 use non deprecated method for adding string to shared strings table 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818623 13f79535-47bb-0310-9956-ffa450edef68
 2017-12-18 20:54:39 +00:00
Yegor Kozlov
1ccc7bfd46 Bug 61859: support for evaluating comparison operators in array mode, detect array mode from formula ptgs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818587 13f79535-47bb-0310-9956-ffa450edef68
 2017-12-18 15:54:50 +00:00
PJ Fanning
9ab4245730 Bug-61906 fix javadoc issue 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818248 13f79535-47bb-0310-9956-ffa450edef68
 2017-12-15 09:13:16 +00:00
PJ Fanning
e34387b2cf Bug-61906 add API for working with RichStringText and deprecate API methods that use CTRst 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818247 13f79535-47bb-0310-9956-ffa450edef68
 2017-12-15 09:09:50 +00:00
PJ Fanning
b3e2c19784 Bug-61792 simplify sxssf code that writes chars 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818223 13f79535-47bb-0310-9956-ffa450edef68
 2017-12-15 00:54:52 +00:00
Javen O'Neal
525952b625 delete commented out code 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817976 13f79535-47bb-0310-9956-ffa450edef68
 2017-12-13 06:39:01 +00:00
Javen O'Neal
5530f8a831 bug 57423: add unit test demonstrating corrupted workbook where CTRow xmlbeans are not in ascending order in the CTWorksheet; unit test adapted from Luca 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817975 13f79535-47bb-0310-9956-ffa450edef68
 2017-12-13 06:21:19 +00:00
Nick Burch
8498e4d88c #61765 Another HSSF Workbook name found from (unknown) third party software produced files 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817812 13f79535-47bb-0310-9956-ffa450edef68
 2017-12-11 19:52:53 +00:00
Greg Woolsey
11e60eb77e Bug 61882 - Some paths can create an XSSFColor instance with a null CTColor reference 
Protect against this in the future by introducing a factory method to create XSSFColor instances from a CTColor instance and the associated workbook style indexed color map.

If the CTColor instance is null, the factory returns null.  All callers already are prepared for a null instance, but many had their own null check on the CTColor object.  This centralizes that.

This also further forces the requirement for the indexed color map.  Any time a color is created, the workbook or styleTable is available in the same context, so passing this is extra parameter is trivial and allows XSSFColor to properly reference custom/themed indexed colors.

Did not remove any methods yet, only deprecated them.  Changed the signature to one internal test-only constructor.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817796 13f79535-47bb-0310-9956-ffa450edef68
 2017-12-11 17:30:04 +00:00
Andreas Beeker
185a66aed5 remove package name to ease the output 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817600 13f79535-47bb-0310-9956-ffa450edef68
 2017-12-09 12:06:59 +00:00
Andreas Beeker
2c2028ede6 #61881 - handle invalid font names 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817599 13f79535-47bb-0310-9956-ffa450edef68
 2017-12-09 11:44:19 +00:00
Greg Woolsey
41981a4ac9 #61841 
Add @Override annotations, clean up imports

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817331 13f79535-47bb-0310-9956-ffa450edef68
 2017-12-07 01:54:21 +00:00
Greg Woolsey
cbd17b9320 #61841 fix typo in method name 
Fixing the typo pointed out by PJ Fanning, thanks for the proof read!

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817325 13f79535-47bb-0310-9956-ffa450edef68
 2017-12-06 23:53:25 +00:00
Greg Woolsey
94c2b64692 Bug #61841 - Unnecessary long computation when evaluating VLOOKUP on all column reference 
always with the missing license...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817254 13f79535-47bb-0310-9956-ffa450edef68
 2017-12-06 00:46:42 +00:00
Greg Woolsey
6390202491 Bug #61841 - Unnecessary long computation when evaluating VLOOKUP on all column reference 
Found some optimizations in the general evaluation framework related to blank cells in rows beyond the last defined row of a sheet.

I don't see any issue with passing a bit of context down deeper into this framework, as it's all POI-internal and only had one calling path.

See the above bug for the performance analysis.  Not specifically related to VLOOKUP, but improves that case by more than 2/3 as well.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817252 13f79535-47bb-0310-9956-ffa450edef68
 2017-12-06 00:15:51 +00:00
PJ Fanning
5f4f1b5846 use try-with-resources in more places 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817247 13f79535-47bb-0310-9956-ffa450edef68
 2017-12-05 22:31:59 +00:00
PJ Fanning
89a788ea5b use try-with-resources in more places 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817238 13f79535-47bb-0310-9956-ffa450edef68
 2017-12-05 21:23:44 +00:00
Javen O'Neal
58114c6d8c bug 61840: close workbook to prevent resource leak in unit test 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816893 13f79535-47bb-0310-9956-ffa450edef68
 2017-12-01 17:51:19 +00:00
Javen O'Neal
79250e916f bug 61840: add unit test showing that shiftRows does not produce #REF! formula errors if cells are not shifted above the first row 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816892 13f79535-47bb-0310-9956-ffa450edef68
 2017-12-01 17:47:29 +00:00
Nick Burch
e8234fd032 Javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816453 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-27 14:05:17 +00:00
Alain Béarez
c795f2e793 XDDF usermodel for Charts closes #68 on GitHub 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816383 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-26 14:03:01 +00:00
Andreas Beeker
2cda98a4aa #61809 - Infinite loop in SectionIDMap.get() and .put() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816205 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-24 01:02:20 +00:00
PJ Fanning
76a16ba175 use try with resources in examples 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816189 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-23 20:03:25 +00:00
PJ Fanning
3e4e43b28b use try with resources in examples 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816187 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-23 19:28:36 +00:00
Dominik Stadler
d77e980e44 Change order of handling shape-types in copy() as FreeFormShape derives from AutoShape and thus would have not been copied correctly currently 
Fix some Javadoc, some warnings and code duplications

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816185 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-23 18:54:11 +00:00
Dominik Stadler
d6f97af799 Ensure that the tempdir exists when we use ImageIO in one of the tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816046 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-22 12:25:11 +00:00
PJ Fanning
e22d67682f add TestStringCodepointsIterable 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816020 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-22 09:57:45 +00:00
PJ Fanning
d695f8ad68 use codepoint iterator in a few places 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815998 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-22 01:07:24 +00:00
PJ Fanning
268bcdbc2d add forbidden api checks for non-Locale toLowerCase and toUpperCase 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815994 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-21 22:10:48 +00:00
PJ Fanning
0675acb64a add forbidden api checks for non-Locale toLowerCase and toUpperCase 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815989 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-21 21:33:51 +00:00
PJ Fanning
2b02a97d6a remove more uses of Character.toUpperCase 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815988 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-21 21:11:07 +00:00
PJ Fanning
c1ae77c8ce [bug-61792] basic test 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815873 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-20 23:58:13 +00:00
PJ Fanning
d4f15fafa9 [bug-61792] some changes to avoid iterating over chars of Strings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815871 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-20 23:35:36 +00:00
Mark Murphy
c37a85d974 javadocs and Quick page improvements for XSSF Header/Footer 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815706 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-19 01:35:07 +00:00
Greg Woolsey
9d11d1c3ea add Locale awareness to case insensitive conditional comparisons in formatting rule logic. Needed anyway, and removes forbidden API issues. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815404 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-16 01:22:52 +00:00
Greg Woolsey
963a8fedae ignore a unit test that snuck in. It was created to investigate an open bug report. It fails, as expected, which broke the build. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815336 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-15 16:34:14 +00:00
Greg Woolsey
ff034f6a20 Fixes Bug 61764 Conditional formatting rules don't evaluate properly for some multi-range rule definitions 
Fixes Bug 61761 Conditional formatting rule evaluation doesn't like comparing cells of different types

fixed, with unit tests.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815298 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-15 08:35:17 +00:00
Dominik Stadler
3e70d22cbc Fix setting a font-color if no previous color is defined for the font 
Add unit-test to verify this

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815086 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-13 11:46:04 +00:00
Dominik Stadler
1b9d599882 Fix tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815085 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-13 11:44:50 +00:00
Javen O'Neal
f062e7f1c2 bug 61745: remove String#toString() usage found by forbidden apis check 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815048 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-13 00:51:41 +00:00
Javen O'Neal
a1b8f3ff14 bug 61745: add support for charts in XWPF/docx. Thanks to Sandeep Tiwari for the patch 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815047 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-12 21:48:41 +00:00
Javen O'Neal
fbccf3066c github #81: sheet names are case insensitive 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815001 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-12 06:14:43 +00:00
Javen O'Neal
1bc1bdb58b XWPFTable#getRows() should return an unmodifiable list unless the method can correctly update xmlbeans in response to modifying the list 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814999 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-12 01:34:52 +00:00
Javen O'Neal
fd29e87402 make tableRows final; initialize where defined rather than in constructor. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814998 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-12 01:32:43 +00:00
Javen O'Neal
c1e6c2eef7 deprecate XWPFTable#addNewRowBetween(int,int), which has not been implemented since 2008 when this class was first authored. (Unrelated: This closes #82 on github). 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814997 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-12 01:30:42 +00:00
Mark Murphy
70fdcdf848 Surface XSSF Header/Footer Attributes (60887) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814950 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-11 14:18:24 +00:00
Dominik Stadler
2d5b6457c6 Some JavaDoc adjustments, typos, IntelliJ warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814587 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-08 14:59:08 +00:00
Javen O'Neal
8b0145c6e0 bug 61730: remove asSet function from unit test 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814462 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-07 07:26:48 +00:00
Javen O'Neal
163673a7aa bug 61730: remove CellRangeAddressBase which is eager. The lazy iterator is safer, less likely to cause an OOM/DoS. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814461 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-07 07:21:24 +00:00
Javen O'Neal
841cc75ee4 bug 61730: add javadoc 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814451 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-07 01:54:25 +00:00
Javen O'Neal
fb321255e8 bug 61730: add iterator interface to CellRangeAddressBase for iterating over CellAddresses 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814448 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-07 00:29:09 +00:00
Javen O'Neal
baec676cd0 bug 61727: make TestCellRangeUtil unit tests more explicit 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814444 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-06 22:19:06 +00:00
Dominik Stadler
7eb0187a5a Enhance unit-test to Verify that bug 58785 is already via via some other change 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814440 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-06 20:26:32 +00:00
Javen O'Neal
047dcc60ca bug 61727: CellRangeUtil Merge cell ranges broken. Thanks for Sven Rieckhoff for the patch 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814432 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-06 19:51:41 +00:00
Dominik Stadler
ba7c278a0e Adjust some tests to properly close resources 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814374 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-05 20:33:35 +00:00
Dominik Stadler
e54892912e Bug #57517: Fix various things in HSSFOptimiser to make many more cases work fine: Column styles, row styles, user defined styles, ... 
Also call optimise in integration-tests and handle some cases of invalid content in files.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814373 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-05 20:33:28 +00:00
Dominik Stadler
4d13aefd6e Add test-case which shows that bug 55814 is fixed already by other changes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814290 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-04 13:45:12 +00:00
Dominik Stadler
48d6e6c9cf Fix some IntelliJ and JavaDoc warnings and avoid code-duplication and duplicated test-methods 
Adjust tests slighlty, close resources

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814289 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-04 13:45:04 +00:00
Javen O'Neal
673e558b7a bug 61474, github #81: add ShiftMode#ColumnCopy for FormulaShifter 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814268 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-04 10:11:20 +00:00
Javen O'Neal
6234d725e6 bug 61474, github #81: add shiftMergedRegions to BaseRowColShifter interface 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814264 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-04 09:32:05 +00:00
Javen O'Neal
9375ae7873 bug 61474, github #81: bump visibility of abstract methods in BaseRowColShifter abstract class 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814262 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-04 09:17:09 +00:00
Javen O'Neal
6fcacf21f3 bug 61474, github #81: pull up methods from RowShifter to BaseRowColShifter, since both row and column shifting should be able to shift formulas, comments, merged regions, conditional formatting, etc; add @since decorators for new *ColumnShifter and *RowColShifter classes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814261 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-04 09:07:32 +00:00
Javen O'Neal
ec8b13c3a8 bug 61474, github #81: remove @Internal RowShifter#updateRowFormulas, move to XSSFRowColShifter; implement ColumnShifter#updateFormulas; remove duplicated JavaDocs (better to inherit) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814260 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-04 08:54:20 +00:00
Javen O'Neal
4d526bfd01 bug 61474, github #81: implement updateConditionalFormatting for ColumnShifter 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814259 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-04 07:58:41 +00:00
Javen O'Neal
7c88f32408 bug 61474, github #81: implement updateNamedRanges for ColumnShifter 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814258 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-04 07:42:33 +00:00
Javen O'Neal
607ca594b1 bug 61474, github #81: fix ColumnShifter#removalNeeded to use columns instead of rows 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814257 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-04 07:29:53 +00:00
Javen O'Neal
4b92e7c67a bug 61474, github #81: add ColumnShifter interface; deduplicate some code in RowShifter, CFRecordsAggregate 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814256 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-04 07:17:44 +00:00
Javen O'Neal
b671199b40 bug 61474, #81 on github: add @Override annotation; rename FormulaShifter shifter to FormulaShifter formulaShifter to reduce confusion with the shifter variable referring to the RowShifter 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814255 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-04 05:48:18 +00:00
Javen O'Neal
0e540db89b bug 61474,github-81: add FormulaShifter.createForColumnShift and ShiftMode.ColumnMove 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814254 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-04 05:29:52 +00:00
Javen O'Neal
40ae87fd36 github-81: extract routines in HSSFRow#shiftRows 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814253 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-04 04:29:45 +00:00
Javen O'Neal
59594b6030 rename ambiguous variable name shifter -> formulaShifter 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814247 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-04 02:57:01 +00:00
Javen O'Neal
4b2f709551 whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814245 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-04 02:49:52 +00:00
Andreas Beeker
388c491135 #61671 - XSLFSlide does not contain isHidden and setHidden like HSLFSlide does 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814122 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-02 23:15:19 +00:00
Nick Burch
bae303a412 Javadoc fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813966 13f79535-47bb-0310-9956-ffa450edef68
 2017-11-01 11:21:25 +00:00
Javen O'Neal
925a296cc3 eventually we want to forbid StringBuffer usage 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813875 13f79535-47bb-0310-9956-ffa450edef68
 2017-10-31 11:10:08 +00:00
PJ Fanning
34006a542e use StringBuilder in more places 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813869 13f79535-47bb-0310-9956-ffa450edef68
 2017-10-31 10:24:47 +00:00
Javen O'Neal
bf5a0c4c9e github-68: add @Override to o.a.p.ss.usermodel.charts.DataSources. Thanks to Alain-Bearez. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813868 13f79535-47bb-0310-9956-ffa450edef68
 2017-10-31 10:17:38 +00:00
PJ Fanning
e623808539 add test case for bug 61701 and use StringBuilder in more places 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813863 13f79535-47bb-0310-9956-ffa450edef68
 2017-10-31 09:48:23 +00:00