Commit Graph

1409 Commits

Author SHA1 Message Date
Dominik Stadler
d909e0998c Add verifying test-case for bug 52420
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649147 13f79535-47bb-0310-9956-ffa450edef68
2015-01-02 22:38:52 +00:00
Andreas Beeker
b2a69b6152 Bug 56240 - Handle PP97_DUALSTORAGE streams
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648466 13f79535-47bb-0310-9956-ffa450edef68
2014-12-30 02:20:57 +00:00
Andreas Beeker
de9699fcad Bug 47261 - SlideShow.removeSlide makes PPT corrupted
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648458 13f79535-47bb-0310-9956-ffa450edef68
2014-12-30 01:05:41 +00:00
Andreas Beeker
26ae1edcd8 Bug 49541 - Mapping of symbol characters to unicode equivalent
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648415 13f79535-47bb-0310-9956-ffa450edef68
2014-12-29 19:43:35 +00:00
Andreas Beeker
8e3eee35cd Bug 54541 - Add support for cropped images in Slide.draw()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648335 13f79535-47bb-0310-9956-ffa450edef68
2014-12-29 13:35:57 +00:00
Dominik Stadler
5c76ccba5b Add missing close() of resources in both production code and tests
Use revert() instead of close() on OCPPackage in some places to not re-write the file unnecessarily.
This should now run tests without leftover file handles when checked with file leak detector and
allows to find newly introduced cases more easily.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648160 13f79535-47bb-0310-9956-ffa450edef68
2014-12-28 09:16:57 +00:00
Dominik Stadler
1cf8152d14 Start adding some coverage of more Scratchpad-classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648157 13f79535-47bb-0310-9956-ffa450edef68
2014-12-28 09:08:22 +00:00
Dominik Stadler
5173eca9ea Fix Eclipse warnings, unnecessary casts, use generics, static access...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648156 13f79535-47bb-0310-9956-ffa450edef68
2014-12-28 09:06:12 +00:00
Andreas Beeker
4bed984c0f Charset.forName() for known encodings makes catching UnknownEncodingException obsolete
Unify UTF-16LE conversion to StringUtil
BugFix for RecordInputStream.readFully in combination with continuing records
BugFix for integration tests - fix pathname for handler/exclude lookup on windows

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648032 13f79535-47bb-0310-9956-ffa450edef68
2014-12-27 01:33:28 +00:00
Andreas Beeker
47fe5b9651 Unified access to escher opt record
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647927 13f79535-47bb-0310-9956-ffa450edef68
2014-12-26 00:11:23 +00:00
Andreas Beeker
202aa8177f - Support for Office Binary Document RC4 CryptoAPI Encryption for HSLF
- Support for Office Binary Document RC4 Encryption
- use LittleEndian class in LittleEndianInputStream
- add normalize method for HSLF, to remove edit history, which is also necessary for encryption support
- update PersistDirectoryEntry handling in PersistPtrHolder to recognize groups while serializing
- deprecated PersistPtrHolder.getSlideOffsetDataLocationsLookup() - throws now UnsupportedOperationException,
  as this wasn't used outside the scope of the class and was quite internal logic of PersistPtrHolder


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647867 13f79535-47bb-0310-9956-ffa450edef68
2014-12-25 01:56:29 +00:00
Andreas Beeker
21d2bc3cff #57272 - deadlock on corrupted PPT file
+ some refactoring in HSLFSlideShow, which will be necessary for cryptoapi support 

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1643680 13f79535-47bb-0310-9956-ffa450edef68
2014-12-07 14:34:19 +00:00
Dominik Stadler
81a3425f16 Typo and remove unnecessary casts
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1641941 13f79535-47bb-0310-9956-ffa450edef68
2014-11-26 21:11:18 +00:00
Andreas Beeker
f818d1fdb7 house keeping - fixes for sonarqube blockers
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1634255 13f79535-47bb-0310-9956-ffa450edef68
2014-10-25 21:32:03 +00:00
Nick Burch
0bd50defba Add a disabled unit test for bug #56880
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1630543 13f79535-47bb-0310-9956-ffa450edef68
2014-10-09 17:58:47 +00:00
Andreas Beeker
d60adb500e Bug 56913 - Replace usages of o.a.p.util.ArrayUtil.copyOf* methods with replacements from j.u.Arrays
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1622589 13f79535-47bb-0310-9956-ffa450edef68
2014-09-05 00:31:47 +00:00
Nick Burch
da61e7dd32 Fix bug 54725 - HWPF where no parent style CHP exists, use an empty
set when processing the style to avoid a NPE

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614926 13f79535-47bb-0310-9956-ffa450edef68
2014-07-31 15:41:58 +00:00
Dominik Stadler
379214975e Add unit test for bug 37625 which verifies that this file can now be loaded
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613837 13f79535-47bb-0310-9956-ffa450edef68
2014-07-27 19:57:57 +00:00
Nick Burch
4c98f1db45 Patch from Raúl Wegmann from bug #56735 / GitHub Pull #10 - Rationalise POI temp file creation to the TempFile util class, and allow a system wide setting of where Temp files (eg for SXSSF) go, via TempFile / TempFileCreationStrategy
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613246 13f79535-47bb-0310-9956-ffa450edef68
2014-07-24 18:58:27 +00:00
Nick Burch
bb91152a12 For places where an ordered collection is created and used within the context of a single thread, and there are no thread safety concerns, use ArrayList not Vector. See bug #54838
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613186 13f79535-47bb-0310-9956-ffa450edef68
2014-07-24 16:41:43 +00:00
Dominik Stadler
9d1d93b88f Add missing @Overrides, reformat some files, increase coverage slightly,
comments, fix Eclipse warnings and add close() calls in some tests and
in HMEFMessage() to close files during tests correctly.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1602008 13f79535-47bb-0310-9956-ffa450edef68
2014-06-11 20:36:30 +00:00
Dominik Stadler
927e62f662 Apache POI - Use assertArrayEquals() instead of assertTrue(Arrays.equals()), this way we get better information on failure
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1595190 13f79535-47bb-0310-9956-ffa450edef68
2014-05-16 13:25:45 +00:00
Nick Burch
0bcdc868f3 Based on reading of the new file format docs, start to tweak how fixed length vs variable length / multi-valued properties are handled
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1593861 13f79535-47bb-0310-9956-ffa450edef68
2014-05-11 21:16:40 +00:00
Nick Burch
1a149050ee Outlook sometimes stores a codepage of ANSI when it means 1252, detect and alias, fixes bug #53983
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1593306 13f79535-47bb-0310-9956-ffa450edef68
2014-05-08 15:17:22 +00:00
Nick Burch
50ad48e746 Implement a few more MAPI property types
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1593298 13f79535-47bb-0310-9956-ffa450edef68
2014-05-08 14:49:21 +00:00
Nick Burch
27e48c3b79 Fix inconsistent indents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1593297 13f79535-47bb-0310-9956-ffa450edef68
2014-05-08 14:46:43 +00:00
Andreas Beeker
821d3ca5bd Some encryption fixes:
- don't rely on SecretKey object having the right algorithm set
- leave encryption-description parsing of string/stream to xmlbeans and refactor it to one location
- use namespaces of schema instead of hard-coded strings
- use CryptoFunctions.getMessageDigest() instead of code duplication

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1588874 13f79535-47bb-0310-9956-ffa450edef68
2014-04-21 12:16:54 +00:00
Nick Burch
d2d289b90f Rather than having lots of classes all create their own XML DocumentBuilderFactory instance, push that logic to a helper which sets all the right defaults
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1587739 13f79535-47bb-0310-9956-ffa450edef68
2014-04-15 21:59:52 +00:00
Cédric Walter
1c987c38e6 performance issue: removed instantiation of new String object by copying an existing string.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1583366 13f79535-47bb-0310-9956-ffa450edef68
2014-03-31 16:16:52 +00:00
Cédric Walter
a0d1ab5add performance issue logging calls are expensive because of the objects created when assembling the log messages. Using the check() method of the logging sub-system can prevent object creation
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1583357 13f79535-47bb-0310-9956-ffa450edef68
2014-03-31 15:54:52 +00:00
Nick Burch
3868a2cdc7 Avoid an IndexOutOfBoundsException if there are no property nodes when searching for the start index, return -1 instead
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1578929 13f79535-47bb-0310-9956-ffa450edef68
2014-03-18 14:40:27 +00:00
Nick Burch
1e03ded992 When looking for text run related records after a TextHeaderAtom, provide a cleaner way to skip ones we don't care about, and a cleaner way to find the StyleTextPropAtom. Should fix #56260
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1577803 13f79535-47bb-0310-9956-ffa450edef68
2014-03-15 08:16:43 +00:00
Nick Burch
488647cb43 Implement MasterTextPropAtom, which provides the indents for a run of text, needed for #56260
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1577802 13f79535-47bb-0310-9956-ffa450edef68
2014-03-15 08:14:36 +00:00
Nick Burch
adb98e1073 #56260 Partial fix for a slide with a TextHeaderAtom but no other atoms related to it, which is followed by another TextHeaderAtom straight away
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1577537 13f79535-47bb-0310-9956-ffa450edef68
2014-03-14 13:59:24 +00:00
Nick Burch
7984a1ec3f More helpful visio v5 exception, see bug #56171
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1570388 13f79535-47bb-0310-9956-ffa450edef68
2014-02-20 23:20:19 +00:00
Andreas Beeker
49c69f0eed The junit test failed with the original test-file (CDT_Data_Retention-PPT.ppt), so another check was necessary
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1569999 13f79535-47bb-0310-9956-ffa450edef68
2014-02-20 00:03:42 +00:00
Andreas Beeker
8afdb7a9ce Bug 55732 - PPT can't open, fails with "Couldn't instantiate .... StyleTextProp9Atom : java.lang.ArrayIndexOutOfBoundsException: 56"
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1569984 13f79535-47bb-0310-9956-ffa450edef68
2014-02-19 23:45:07 +00:00
Andreas Beeker
edf1ffd89b upgraded to junit4 (before other changes)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1569972 13f79535-47bb-0310-9956-ffa450edef68
2014-02-19 23:30:12 +00:00
Andreas Beeker
2cfc8dbf17 FindBugs fix
- fixed "Equals method should not assume anything about the type of its argument"
- see http://findbugs.sourceforge.net/bugDescriptions.html#BC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568861 13f79535-47bb-0310-9956-ffa450edef68
2014-02-16 23:36:32 +00:00
Andreas Beeker
53c90692ee FindBugs fix
- fixed "equals() method does not check for null argument"
- see http://findbugs.sourceforge.net/bugDescriptions.html#NP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENT

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568812 13f79535-47bb-0310-9956-ffa450edef68
2014-02-16 19:35:16 +00:00
Andreas Beeker
2a14920cdd FindBugs fix
- fixed/checked various null pointer related entries
- see http://findbugs.sourceforge.net/bugDescriptions.html#NP_NULL_PARAM_DEREF
- ... NP_NULL_ON_SOME_PATH, NP_NULL_ON_SOME_PATH_EXCEPTION


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568789 13f79535-47bb-0310-9956-ffa450edef68
2014-02-16 16:30:24 +00:00
Dominik Stadler
dcad3624dc Fix unit tests broken by newly added test-file, ignore TestFontRendering as it is inherently unstable currently
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568744 13f79535-47bb-0310-9956-ffa450edef68
2014-02-16 09:11:28 +00:00
Dominik Stadler
2414998aac Adjust test to write the failing PNG in case expected and actual do not match
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568740 13f79535-47bb-0310-9956-ffa450edef68
2014-02-16 08:39:17 +00:00
Dominik Stadler
b51a52cf20 Provide more output on test that failed for me locally
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568558 13f79535-47bb-0310-9956-ffa450edef68
2014-02-15 00:21:19 +00:00
Andreas Beeker
92a488a28b FindBugs fix
- fixed "Should be a static inner class"
- see http://findbugs.sourceforge.net/bugDescriptions.html#SIC_INNER_SHOULD_BE_STATIC


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568178 13f79535-47bb-0310-9956-ffa450edef68
2014-02-14 01:00:45 +00:00
Andreas Beeker
3ceb93b23d FindBugs fix
- fixed "Field isn't final but should be"
- see http://findbugs.sourceforge.net/bugDescriptions.html#MS_SHOULD_BE_FINAL


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568145 13f79535-47bb-0310-9956-ffa450edef68
2014-02-13 23:34:11 +00:00
Andreas Beeker
8c3785890a Bug 55902 - Mixed fonts issue with Chinese characters (unable to form images from ppt)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1567455 13f79535-47bb-0310-9956-ffa450edef68
2014-02-11 23:16:54 +00:00
Andreas Beeker
413e76aed0 FindBugs fix
- fixed "Class defines equals() and uses Object.hashCode()"
- see http://findbugs.sourceforge.net/bugDescriptions.html#HE_EQUALS_USE_HASHCODE
- implemented UnicodeString.ExtRst.hashCode() + junit-test

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1566427 13f79535-47bb-0310-9956-ffa450edef68
2014-02-09 21:19:20 +00:00
Nick Burch
fdcd28194e Fix up whitespace / indents to be consistent
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563491 13f79535-47bb-0310-9956-ffa450edef68
2014-02-01 22:05:23 +00:00
Nick Burch
c5823a746f Fix javadoc formatting
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563489 13f79535-47bb-0310-9956-ffa450edef68
2014-02-01 21:58:24 +00:00
Nick Burch
2b0c8deb2f Expose the StyleIndex of CharacterRuns, and expand the range style tests to cover this + related
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563486 13f79535-47bb-0310-9956-ffa450edef68
2014-02-01 21:52:19 +00:00
Andreas Beeker
439ad29071 Added license headers
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1559297 13f79535-47bb-0310-9956-ffa450edef68
2014-01-18 00:38:04 +00:00
Andreas Beeker
c148f9c3e5 javadoc fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1557290 13f79535-47bb-0310-9956-ffa450edef68
2014-01-11 00:14:17 +00:00
Dominik Stadler
5e77641784 remove some unused imports and some useless TODOs, slightly more
coverage, @Overrides, more info on failing test, fix some Eclipse
warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1554535 13f79535-47bb-0310-9956-ffa450edef68
2013-12-31 15:12:30 +00:00
Andreas Beeker
ae2b93eaa0 Bug 45776 - Fix corrupt file problem using TextRun.setText
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1554077 13f79535-47bb-0310-9956-ffa450edef68
2013-12-29 22:14:05 +00:00
Andreas Beeker
c95d740ee4 Bug 41246 - AIOOBE with missing notes entries
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553760 13f79535-47bb-0310-9956-ffa450edef68
2013-12-27 23:42:34 +00:00
Andreas Beeker
3ef65e166d Bug 48593 - [PATCH] Multiple Saves Causes Slide Corruption
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553610 13f79535-47bb-0310-9956-ffa450edef68
2013-12-27 00:22:19 +00:00
Andreas Beeker
e34a1f9620 Bug 55579 - [PATCH] Patch for add/embed OLE objects into HSLF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553435 13f79535-47bb-0310-9956-ffa450edef68
2013-12-26 00:46:16 +00:00
Andreas Beeker
2788aca235 javadoc and compiler warning house-keeping
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553428 13f79535-47bb-0310-9956-ffa450edef68
2013-12-25 23:24:04 +00:00
Dominik Stadler
bc7b658ea9 Fix some JavaDoc items that are reported in the build-output
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553404 13f79535-47bb-0310-9956-ffa450edef68
2013-12-25 18:05:41 +00:00
Yegor Kozlov
fdda5f2071 removed pictureFileZero.ppt from svn as requested by the owner, see discussion on @poi-dev from Dec 12, 2013
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1551845 13f79535-47bb-0310-9956-ffa450edef68
2013-12-18 05:26:49 +00:00
Yegor Kozlov
362fec4a01 Bugzilla 55560 : Patch for hiding slides in HSLF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1540295 13f79535-47bb-0310-9956-ffa450edef68
2013-11-09 11:57:21 +00:00
Dominik Stadler
7014abae83 Bug 52400: fix handling some types of TNEF files, make HMEFMessage.HEADER_SIGNATURE int as it is handled as int everywhere, move .dat files to HMEF sample dir, cover some border cases in HMEFMessage, add another .dat sample file
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1538353 13f79535-47bb-0310-9956-ffa450edef68
2013-11-03 12:43:42 +00:00
Dominik Stadler
19630f1a29 Add more output to assertion in test-case that is sometimes failing, see e.g. Jenkins build #170...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1538330 13f79535-47bb-0310-9956-ffa450edef68
2013-11-03 10:11:09 +00:00
Nick Burch
a6b301e485 Fix bug #55733 - XWPFWordExtractor need
s to handle .docx files with neither headers nor footers

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1538044 13f79535-47bb-0310-9956-ffa450edef68
2013-11-01 19:43:46 +00:00
Tim Allison
3e1208af44 Potential NPE in PPExtractor; found while working on TIKA-1171
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1527041 13f79535-47bb-0310-9956-ffa450edef68
2013-09-27 19:35:14 +00:00
Tim Allison
58dd7d7c0c POI-54722 table text in ppt files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1526960 13f79535-47bb-0310-9956-ffa450edef68
2013-09-27 15:45:55 +00:00
Dominik Stadler
ffc31302a4 Adjust build.xml to run JaCoCo coverage when running unit tests when
flag coverage.enabled is set to true, download necessary jars, add jacoco:coverage
to junit targets and a testcoveragereport target which produces the coverage report.
Also fix a test that is affected by JaCoCo and add slightly more coverage in another test.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1510243 13f79535-47bb-0310-9956-ffa450edef68
2013-08-04 16:38:01 +00:00
Nick Burch
dd1116a1e3 Have MAPIMessage try the codepage properties to get the ascii encoding, before falling back to the existing logic around content type parsing
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1497038 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 18:46:37 +00:00
Nick Burch
43b811f049 More unit tests for the HSMF fixed sized property values (a few still remain to be fixed though)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1497023 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 17:45:57 +00:00
Nick Burch
b37e3c6df2 Make the fixed sized properties parser more flexible in the face of slightly duff data
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1497006 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 17:03:26 +00:00
Nick Burch
a9e1c0e320 Dig out the normal type for some more common properties
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1497004 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 16:58:11 +00:00
Nick Burch
b8644921c9 Support decoding a few more property types
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496988 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 16:17:00 +00:00
Nick Burch
c5893c8c34 More friendly output of byte arrays for property values in HSMFDump
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496982 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 16:03:09 +00:00
Nick Burch
43886b815b Fix inconsistent whitespace in HSMF test files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496969 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 15:28:25 +00:00
Nick Burch
73aa6c507e Fix inconsistent whitespace in HSMF files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496962 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 15:23:29 +00:00
Nick Burch
b3e4741320 Convert classes with a assertContains method to using the new POITestCase common parent class, which has it there
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496697 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 00:49:41 +00:00
Nick Burch
84a00d8d4b Sanity check the length, logging and truncating if too long, to avoid a StringIndexOutOfBoundsException (bug #54925)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496520 13f79535-47bb-0310-9956-ffa450edef68
2013-06-25 15:49:45 +00:00
Nick Burch
456f6171d9 Fix the indenting to be consistent throughout the file
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496519 13f79535-47bb-0310-9956-ffa450edef68
2013-06-25 15:44:36 +00:00
Nick Burch
56d1f1b97a Add another record type to the "don't warn" list, and tidy up the code a little bit (see bug #54925)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496518 13f79535-47bb-0310-9956-ffa450edef68
2013-06-25 15:40:05 +00:00
Yegor Kozlov
09c79ffed4 fixed compatibility issues with JDK 1.5
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1489685 13f79535-47bb-0310-9956-ffa450edef68
2013-06-05 02:03:07 +00:00
Nick Burch
c4f77a02e2 Unit test for bugs #54880 & #55030 - seems ok so far
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1488403 13f79535-47bb-0310-9956-ffa450edef68
2013-05-31 21:17:55 +00:00
Nick Burch
17cb45f1bf Fix bug #55001 - check for unicode text too (plus fix indents)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1488329 13f79535-47bb-0310-9956-ffa450edef68
2013-05-31 17:30:29 +00:00
Nick Burch
7c246cb5f0 More on bug #54682 - check for the end offset overflowing too
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1487558 13f79535-47bb-0310-9956-ffa450edef68
2013-05-29 17:31:50 +00:00
Nick Burch
c702bc5ce5 Fix bug #54682 - UnhandledDataStructure should sanity check before allocating, not after
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1487555 13f79535-47bb-0310-9956-ffa450edef68
2013-05-29 17:25:40 +00:00
Nick Burch
b68b2068d4 A bit more towards matching properties to chunks
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1442388 13f79535-47bb-0310-9956-ffa450edef68
2013-02-04 21:46:30 +00:00
Nick Burch
1fe52e8cfc Continue with support for property lookups of chunks
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1441427 13f79535-47bb-0310-9956-ffa450edef68
2013-02-01 12:43:58 +00:00
Nick Burch
8edde11bbc Start on decoding fixed sized HSMF properties, and linking the variable sized ones with their matching chunks
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1441398 13f79535-47bb-0310-9956-ffa450edef68
2013-02-01 11:45:31 +00:00
Yegor Kozlov
7adad438bf Bug 54210 - Fixed rendering text in flipped shapes in PPT2PNG and PPTX2PNG
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1416165 13f79535-47bb-0310-9956-ffa450edef68
2012-12-02 12:24:55 +00:00
Yegor Kozlov
6f0b9cd5df fixed missing licence headers
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1413340 13f79535-47bb-0310-9956-ffa450edef68
2012-11-25 12:01:54 +00:00
Yegor Kozlov
362ded1f94 Bugzilla 54188 - Avoid NPE in PPT2PNG
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1413339 13f79535-47bb-0310-9956-ffa450edef68
2012-11-25 11:53:50 +00:00
Yegor Kozlov
133c0d7c0b Bug 52628 - Replace System.err info messages with a POILogger
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1410318 13f79535-47bb-0310-9956-ffa450edef68
2012-11-16 12:21:49 +00:00
Yegor Kozlov
87073d28da fixed javadoc warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1410315 13f79535-47bb-0310-9956-ffa450edef68
2012-11-16 12:00:02 +00:00
Yegor Kozlov
e68f4e043d Bugzilla 54111 - Fixed extracting text from table cells in HSLF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1406688 13f79535-47bb-0310-9956-ffa450edef68
2012-11-07 16:02:42 +00:00
Sergey Vladimirov
d8ca4323de Bug 52583 - Conversion to html : Problem with combobox
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1406208 13f79535-47bb-0310-9956-ffa450edef68
2012-11-06 16:26:43 +00:00
Sergey Vladimirov
110ef33b6e 52863 - add workaround for files with broken CHP SPRMs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1405861 13f79535-47bb-0310-9956-ffa450edef68
2012-11-05 16:06:36 +00:00
Sergey Vladimirov
2f9f29380a fix bug 53182 - Reading combined character styling and direct formatting of a character run
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1405850 13f79535-47bb-0310-9956-ffa450edef68
2012-11-05 15:51:41 +00:00
Sergey Vladimirov
1ab0e33b9d 52311 - Conversion to html : Problem in titles number
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1405808 13f79535-47bb-0310-9956-ffa450edef68
2012-11-05 14:38:12 +00:00
Sergey Vladimirov
2af967af3d move test case for Bug 47563 to distinguish file
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1405771 13f79535-47bb-0310-9956-ffa450edef68
2012-11-05 12:39:58 +00:00
Sergey Vladimirov
8dde31fbab Add support for CHP SPRM sprmCFNoProof 0x875
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1405762 13f79535-47bb-0310-9956-ffa450edef68
2012-11-05 12:09:53 +00:00
Sergey Vladimirov
8ad617d64d update CHP type definition (all flags from grpfChp are supported now)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1405760 13f79535-47bb-0310-9956-ffa450edef68
2012-11-05 12:03:37 +00:00
Sergey Vladimirov
db30e0f337 a bit more debug logging
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1405759 13f79535-47bb-0310-9956-ffa450edef68
2012-11-05 12:02:50 +00:00
Sergey Vladimirov
e95f5e8333 Bug 53914 - TableRow#getTopBorder() return bottom's border
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1405752 13f79535-47bb-0310-9956-ffa450edef68
2012-11-05 11:49:03 +00:00
Yegor Kozlov
395b0af2e4 Bugzilla 54070: Patch for typos in comments, javadoc and documentation
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1404642 13f79535-47bb-0310-9956-ffa450edef68
2012-11-01 15:26:27 +00:00
Yegor Kozlov
074dd87183 Bug #53707: SlideShow.addPicture declares IOException but throws HSLFException
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1402550 13f79535-47bb-0310-9956-ffa450edef68
2012-10-26 15:40:53 +00:00
Yegor Kozlov
1a3d907dab Bugzilla 53979 - Support fetching properties of Numbered Lists from PPT files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1401652 13f79535-47bb-0310-9956-ffa450edef68
2012-10-24 12:39:58 +00:00
Yegor Kozlov
a9465838ca added missing licence header
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1401650 13f79535-47bb-0310-9956-ffa450edef68
2012-10-24 12:37:46 +00:00
Yegor Kozlov
a88447b0e4 support links to slides in HSLF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1401642 13f79535-47bb-0310-9956-ffa450edef68
2012-10-24 12:11:31 +00:00
Yegor Kozlov
04b9f9dff9 fixed failing tests, force UTC time zone when formatting dates
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1401641 13f79535-47bb-0310-9956-ffa450edef68
2012-10-24 12:06:40 +00:00
Nick Burch
f6f8425c40 Bug #53784 - Partial support for fixed-length Outlook property values in HSMF, with test from Claudius from the bug report
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1398241 13f79535-47bb-0310-9956-ffa450edef68
2012-10-15 10:44:33 +00:00
Nick Burch
a2300daefe Use a chunk that really isn't there, to avoid issues when we start to support message dates better
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1398237 13f79535-47bb-0310-9956-ffa450edef68
2012-10-15 10:36:30 +00:00
Nick Burch
d8849d8c50 Support output to a specified stream
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1398234 13f79535-47bb-0310-9956-ffa450edef68
2012-10-15 10:28:12 +00:00
Yegor Kozlov
a9d303d6ab Bugzilla 53943 - added method processSymbol() to allow converting word symbols
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1397554 13f79535-47bb-0310-9956-ffa450edef68
2012-10-12 13:11:26 +00:00
Sergey Vladimirov
a475de5785 add 4th example file from Bug 53380
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1390167 13f79535-47bb-0310-9956-ffa450edef68
2012-09-25 21:42:09 +00:00
Sergey Vladimirov
92f0d10462 add safe path for documents with missing list information
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1389056 13f79535-47bb-0310-9956-ffa450edef68
2012-09-23 13:34:46 +00:00
Sergey Vladimirov
3f5640f8f2 fix LVL#xst definition and processing
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1389053 13f79535-47bb-0310-9956-ffa450edef68
2012-09-23 13:29:31 +00:00
Sergey Vladimirov
d8a2f3eb72 refactor list format override structures (was marked with @Internal annotation)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1389041 13f79535-47bb-0310-9956-ffa450edef68
2012-09-23 13:00:12 +00:00
Sergey Vladimirov
dc4fd539e0 refactor list format override structures (was marked with @Internal annotation)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1389039 13f79535-47bb-0310-9956-ffa450edef68
2012-09-23 12:57:39 +00:00
Sergey Vladimirov
3c200abd02 refactor list format override structures (was marked with @Internal annotation)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1389038 13f79535-47bb-0310-9956-ffa450edef68
2012-09-23 12:56:32 +00:00
Sergey Vladimirov
9f666b8aee refactor list format override structures (was marked with @Internal annotation)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1389037 13f79535-47bb-0310-9956-ffa450edef68
2012-09-23 12:56:09 +00:00
Sergey Vladimirov
edae5cb060 +one more test file for Bug 53380
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1388351 13f79535-47bb-0310-9956-ffa450edef68
2012-09-21 07:16:03 +00:00
Sergey Vladimirov
94ae826022 Fixed bug 53380 -- ArrayIndexOutOfBounds Excetion parsing word 97 document
We had incorrect implementation for sprmCShd80 (0x4866) 0x66 processing, Shd was used instead of Shd80

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1383584 13f79535-47bb-0310-9956-ffa450edef68
2012-09-11 19:49:44 +00:00
Yegor Kozlov
fb1719c85d Bugzilla 53446 - Fixed some problems extracting PNGs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1369263 13f79535-47bb-0310-9956-ffa450edef68
2012-08-04 05:30:19 +00:00
Yegor Kozlov
e971e30d3b Bugzilla 53205 - Fix some parsing errors and encoding issues in HDGF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1365638 13f79535-47bb-0310-9956-ffa450edef68
2012-07-25 15:45:09 +00:00
Nick Burch
ace1bade16 Add some helper methods for working with attachments
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1359542 13f79535-47bb-0310-9956-ffa450edef68
2012-07-10 09:43:49 +00:00
Nick Burch
832068ae23 Provide one example of how PropertyValues can be encoded and decoded, rest still needed (along with logic in PropertiesChunk to drive it)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1359243 13f79535-47bb-0310-9956-ffa450edef68
2012-07-09 16:08:30 +00:00
Nick Burch
eb368e205d Start on the code to process properties, and wire it up. No properties reading code exists yet
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1358813 13f79535-47bb-0310-9956-ffa450edef68
2012-07-08 18:50:11 +00:00
Nick Burch
9a5378ff55 In preparation for reading the HSMF __properties stream, improve the Types support to be a class with ID+Name+Length, rather than simply an ID. Allows some tidying in HMEF. (Also stubs a few properties bits)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1358802 13f79535-47bb-0310-9956-ffa450edef68
2012-07-08 18:05:17 +00:00
Yegor Kozlov
99fcaf0edb set line color in draw command in PPGraphics2D.java
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1344204 13f79535-47bb-0310-9956-ffa450edef68
2012-05-30 11:33:36 +00:00
Nick Burch
0ac6f0fd5a Patch from Josh Holthaus from bug #53165 - HWPF support for fetching the description (alt text) of a picture
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1332594 13f79535-47bb-0310-9956-ffa450edef68
2012-05-01 09:46:15 +00:00
Maxim Valyanskiy
6facec409f unit test for #52991 (unexpected end of ZLIB input stream)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1305812 13f79535-47bb-0310-9956-ffa450edef68
2012-03-27 11:29:39 +00:00
Maxim Valyanskiy
95b5c80bf0 HWPF: fix NPE when reading paragraph properties
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1305810 13f79535-47bb-0310-9956-ffa450edef68
2012-03-27 11:14:47 +00:00
Maxim Valyanskiy
b9a6d0a2e0 #52991: Unexpected end of ZLIB input stream on embedded OLE extraction from PPT
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1305778 13f79535-47bb-0310-9956-ffa450edef68
2012-03-27 08:32:47 +00:00
Yegor Kozlov
24d8e515b0 small fic to prevent NPE when iterating over shape attributes in HSLF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1299336 13f79535-47bb-0310-9956-ffa450edef68
2012-03-11 07:14:16 +00:00
Yegor Kozlov
b459075ba0 optimized unused imports in poi-scratchpad
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1296980 13f79535-47bb-0310-9956-ffa450edef68
2012-03-05 09:46:11 +00:00
Yegor Kozlov
ede267e7a9 bugzilla 52682 - allow setting text with trailing carriage return in HSLF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1295488 13f79535-47bb-0310-9956-ffa450edef68
2012-03-01 09:51:28 +00:00
Yegor Kozlov
cee330b145 bugzilla 52244 - use correct text attributes when presentation has multiple TxMasterStyleAtoms of the same type
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1295478 13f79535-47bb-0310-9956-ffa450edef68
2012-03-01 09:03:16 +00:00
Yegor Kozlov
715f7d74b4 Bugzilla 52078 - avoid OutOfMemoryError when rendering groupped pictures in HSLF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1293561 13f79535-47bb-0310-9956-ffa450edef68
2012-02-25 09:40:16 +00:00
Yegor Kozlov
df61625757 Bugzilla 52599 - avoid duplicate text when rendering slides in HSLF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1292273 13f79535-47bb-0310-9956-ffa450edef68
2012-02-22 13:23:31 +00:00
Yegor Kozlov
93c7050f8c Bugzilla 52598 - respect slide background when rendering slides in HSLF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1292267 13f79535-47bb-0310-9956-ffa450edef68
2012-02-22 12:59:40 +00:00
Yegor Kozlov
a4c7338078 Bugzilla 51731 - fixed painting shape outlines in HSLF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1292247 13f79535-47bb-0310-9956-ffa450edef68
2012-02-22 11:44:21 +00:00
Nick Burch
ccddafaf5c Fix bug #52664 - MAPIMessage may not always have name chunks when checking for 7 bit encodings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1244449 13f79535-47bb-0310-9956-ffa450edef68
2012-02-15 11:47:11 +00:00
Yegor Kozlov
c85888414b Bugzilla 52649: fixed adobe:ns:meta namespace in WordToFoConverter
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1244429 13f79535-47bb-0310-9956-ffa450edef68
2012-02-15 10:36:53 +00:00
Nick Burch
441c441ac8 Apply patch from bug #52662 - CharacterRun NPE fix when fetching symbol fonts, where no fonts are defined
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1243907 13f79535-47bb-0310-9956-ffa450edef68
2012-02-14 12:56:30 +00:00
Nick Burch
e4bd213ed5 Fix generics warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1225092 13f79535-47bb-0310-9956-ffa450edef68
2011-12-28 05:08:45 +00:00
Yegor Kozlov
c8f9bde8ee removed svn:executable bit from project files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1212745 13f79535-47bb-0310-9956-ffa450edef68
2011-12-10 08:02:08 +00:00
Yegor Kozlov
6867b3eee4 fixed javadoc warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1212511 13f79535-47bb-0310-9956-ffa450edef68
2011-12-09 16:48:38 +00:00
Yegor Kozlov
e8208a7363 Bugzilla 46288: fixed refcount of Fill pictures in HSLF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1212381 13f79535-47bb-0310-9956-ffa450edef68
2011-12-09 12:50:20 +00:00
Nick Burch
aed41195ce Add test file for bug #51873 from Jeremy, and a test that uses it
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1210332 13f79535-47bb-0310-9956-ffa450edef68
2011-12-05 05:12:23 +00:00
Nick Burch
bfcf5190eb Restore HWPF support for inline Escher images (stored in Escher rather than direct in a PICFAndOfficeArtData in the main stream), plus add test for this kind of file
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1207497 13f79535-47bb-0310-9956-ffa450edef68
2011-11-28 18:42:30 +00:00