Commit Graph

6156 Commits

Author SHA1 Message Date
Javen O'Neal 74be4d4174 bug 59638: patch from Axel Howind, support non-comma number grouping separators (such as German 1.234,57)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747139 13f79535-47bb-0310-9956-ffa450edef68
2016-06-07 06:18:44 +00:00
Andreas Beeker a749f7f3f5 sonar fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747093 13f79535-47bb-0310-9956-ffa450edef68
2016-06-06 23:54:29 +00:00
Andreas Beeker 60d35b92c6 close resources
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747092 13f79535-47bb-0310-9956-ffa450edef68
2016-06-06 23:34:17 +00:00
Andreas Beeker b8e38304f2 javadocs / java warnings (jdk8) fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747090 13f79535-47bb-0310-9956-ffa450edef68
2016-06-06 23:33:00 +00:00
Dominik Stadler ee222dc91d Fix test-failure in Maven builds that I introduced by manually deleting the temporary directory in the test. The Maven build runs these in one process and thus the directory was not re-created any more.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746933 13f79535-47bb-0310-9956-ffa450edef68
2016-06-05 16:55:48 +00:00
Andreas Beeker c423015a1b try to find out temp file errors on maven build
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746932 13f79535-47bb-0310-9956-ffa450edef68
2016-06-05 16:49:18 +00:00
Andreas Beeker 9b05849946 PPTX2PNG - don't complain about missing output dir, when in testing mode
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746893 13f79535-47bb-0310-9956-ffa450edef68
2016-06-05 10:18:14 +00:00
Andreas Beeker bd2b438ee1 Regression fix for XSLF
- master style was always overridden, because of r1745100
- AIOOB in TextDirection mapping

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746858 13f79535-47bb-0310-9956-ffa450edef68
2016-06-05 01:04:58 +00:00
Andreas Beeker d80170f9ac #57766 - XSLFTable isn't exported on convert slides of a .pptx slide show to a PNG/SVG image
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746856 13f79535-47bb-0310-9956-ffa450edef68
2016-06-04 22:53:00 +00:00
Dominik Stadler 1caa8ff288 Try to not fail if the time-webservice is offline temporarily
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746671 13f79535-47bb-0310-9956-ffa450edef68
2016-06-03 06:01:27 +00:00
Nick Burch 52537ae58e Add disabled test for XWPF writing to a new stream when opened read-only
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746653 13f79535-47bb-0310-9956-ffa450edef68
2016-06-02 22:59:47 +00:00
Dominik Stadler 1fdbf14e1e Fix some Sonar issues and some IntelliJ warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746627 13f79535-47bb-0310-9956-ffa450edef68
2016-06-02 20:14:28 +00:00
Dominik Stadler 6b6aa56455 Avoid NPE in XWPFTableCell, taken from https://github.com/prasad-babu/poi/tree/WORKING_BRANCH
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746625 13f79535-47bb-0310-9956-ffa450edef68
2016-06-02 20:09:44 +00:00
Dominik Stadler ee6c0625d0 Try to reproduce bug 57798 but it seems to be fixed in the meantime
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746624 13f79535-47bb-0310-9956-ffa450edef68
2016-06-02 20:09:35 +00:00
Dominik Stadler aee2959a64 Bug 59378: Try to reproduce, but could not
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746623 13f79535-47bb-0310-9956-ffa450edef68
2016-06-02 20:09:25 +00:00
Dominik Stadler aad52afa12 The changes for using AccessController/SecurityManager also added a log which now spams a lot if log is enabled in integration-tests, reduce it a bit by not trying to call "cleaner()" on HeapByteBuffer which does not have it for sure
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746411 13f79535-47bb-0310-9956-ffa450edef68
2016-06-01 08:05:07 +00:00
Nick Burch e9a1e2987f Javadoc fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746286 13f79535-47bb-0310-9956-ffa450edef68
2016-05-31 15:08:14 +00:00
Dominik Stadler 7cb15d81db Change logger.log to System.out to print out one line for each file that is handled in the test, otherwise it is sometimes impossible to see where the test stopped (e.g. on timeout), enabling POILogger leads to 400MB logs, which is usually too much to handle...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746275 13f79535-47bb-0310-9956-ffa450edef68
2016-05-31 13:52:16 +00:00
Dominik Stadler 68102762fd Fix some compiler/IntelliJ warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746274 13f79535-47bb-0310-9956-ffa450edef68
2016-05-31 13:48:25 +00:00
Dominik Stadler 505e695099 Bug 57838: Also remove comments when removing a row
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746062 13f79535-47bb-0310-9956-ffa450edef68
2016-05-29 21:33:47 +00:00
Dominik Stadler a2bd714e55 Update error message to better indicate that we need a sample-file here
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746061 13f79535-47bb-0310-9956-ffa450edef68
2016-05-29 21:33:39 +00:00
Dominik Stadler d53ad74c37 Remove the created temporary directory after the test again
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746060 13f79535-47bb-0310-9956-ffa450edef68
2016-05-29 21:33:33 +00:00
Dominik Stadler a9f9290bb7 Try to access set/getVisible as well in TestXSSFVMLDrawing
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746058 13f79535-47bb-0310-9956-ffa450edef68
2016-05-29 21:33:24 +00:00
Andreas Beeker 334ec509fa fix handling of hsl and linear rgb (%-values)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1745412 13f79535-47bb-0310-9956-ffa450edef68
2016-05-24 23:39:23 +00:00
Dominik Stadler 10ce4e23a6 Adjust two tests slightly
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1745370 13f79535-47bb-0310-9956-ffa450edef68
2016-05-24 14:48:57 +00:00
Dominik Stadler a7df6604a4 Upgrade to FindBugs 3.0.1 and add some findbugs-excludes
Update to forbiddenapi-checker 2.1, use the newly provided rule-sets and remove things that were applied upstream 


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1745366 13f79535-47bb-0310-9956-ffa450edef68
2016-05-24 14:17:52 +00:00
Nick Burch 6c976b6700 Fix inconsistent spacing / whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1745361 13f79535-47bb-0310-9956-ffa450edef68
2016-05-24 13:39:46 +00:00
Nick Burch dccad7fb92 Another exclude
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1745358 13f79535-47bb-0310-9956-ffa450edef68
2016-05-24 13:32:33 +00:00
Nick Burch 2ff845b852 Whitespace fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1745357 13f79535-47bb-0310-9956-ffa450edef68
2016-05-24 13:30:58 +00:00
Nick Burch d71d796f62 Copy out code from the site and fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1745348 13f79535-47bb-0310-9956-ffa450edef68
2016-05-24 12:16:13 +00:00
Andreas Beeker 592f22882f #58217 - XSLF: support alpha channel on solid colors (fill, line, text)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1745101 13f79535-47bb-0310-9956-ffa450edef68
2016-05-22 23:58:07 +00:00
Andreas Beeker dae1a761fd XSLF: remove creation of empty paragraph in XSLFTextShape.addNewTextParagraph()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1745100 13f79535-47bb-0310-9956-ffa450edef68
2016-05-22 23:57:14 +00:00
Dominik Stadler e48e4e771d Bug 58190: Add more overloaded methods for adding pictures from streams and files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1745073 13f79535-47bb-0310-9956-ffa450edef68
2016-05-22 16:08:51 +00:00
Andreas Beeker 3d60c67151 fix junit4
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744821 13f79535-47bb-0310-9956-ffa450edef68
2016-05-21 04:06:49 +00:00
Andreas Beeker e58f6f3fb0 findbugs fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744802 13f79535-47bb-0310-9956-ffa450edef68
2016-05-20 22:05:00 +00:00
Andreas Beeker e5393711b7 fix javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744797 13f79535-47bb-0310-9956-ffa450edef68
2016-05-20 21:02:49 +00:00
Dominik Stadler ae32e5f677 Fix some compiler warnings, close resources in tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744636 13f79535-47bb-0310-9956-ffa450edef68
2016-05-19 20:18:19 +00:00
Dominik Stadler 2e4095deeb Apply patch for bug 59355: XSSFPivotTable::addColumnLabel sets the cell type of a cell outside of the source data area
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744635 13f79535-47bb-0310-9956-ffa450edef68
2016-05-19 20:18:08 +00:00
Andreas Beeker eb111ce81f findbugs fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744332 13f79535-47bb-0310-9956-ffa450edef68
2016-05-17 23:34:52 +00:00
Dominik Stadler 0c78005743 Bug 59427: Add a check to better report cases when a document is already closed.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744306 13f79535-47bb-0310-9956-ffa450edef68
2016-05-17 19:08:34 +00:00
Dominik Stadler df72dbfbed Revert expected failure as it seems to be fixed now
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744305 13f79535-47bb-0310-9956-ffa450edef68
2016-05-17 19:08:27 +00:00
Dominik Stadler 6a223ec11e BiffViewer: Close resources always
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744212 13f79535-47bb-0310-9956-ffa450edef68
2016-05-17 08:44:21 +00:00
Dominik Stadler ff055532c1 Exclude newly added corrupt file
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744211 13f79535-47bb-0310-9956-ffa450edef68
2016-05-17 08:44:16 +00:00
Andreas Beeker e28fff0423 ignore external relations
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744196 13f79535-47bb-0310-9956-ffa450edef68
2016-05-17 07:23:34 +00:00
Andreas Beeker 7b282db0e2 Move reflection-equals to POITestCase
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744169 13f79535-47bb-0310-9956-ffa450edef68
2016-05-16 23:28:25 +00:00
Andreas Beeker 61321b4b37 #54570 - InvalidFormatException because of Absolute URI forbidden
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744137 13f79535-47bb-0310-9956-ffa450edef68
2016-05-16 21:04:00 +00:00
Andreas Beeker 33241e821f add asl
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744021 13f79535-47bb-0310-9956-ffa450edef68
2016-05-16 10:54:02 +00:00
Andreas Beeker 73108582a0 deprecation fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744008 13f79535-47bb-0310-9956-ffa450edef68
2016-05-16 10:09:52 +00:00
Andreas Beeker 1f862981e2 Close resources in Common SL rendering classes and minimize memory consumption by using the image anchor dimensions instead of the WMF-included dimensions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744007 13f79535-47bb-0310-9956-ffa450edef68
2016-05-16 10:09:22 +00:00
Andreas Beeker 306edb91e5 sonar fix - reduce complexity by using constants
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744006 13f79535-47bb-0310-9956-ffa450edef68
2016-05-16 10:04:46 +00:00
Andreas Beeker fa00834766 Reduce calls to utf-related methods - the integration test took ages because of poc-shared-strings.xlsx
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744005 13f79535-47bb-0310-9956-ffa450edef68
2016-05-16 10:02:13 +00:00
Andreas Beeker 20fe8a5e0f Reduce calls to utf-related methods - the integration test took ages because of poc-shared-strings.xlsx
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744004 13f79535-47bb-0310-9956-ffa450edef68
2016-05-16 10:01:36 +00:00
Andreas Beeker 2e5f0132c5 Sonar fixes - array is stored directly
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744003 13f79535-47bb-0310-9956-ffa450edef68
2016-05-16 09:57:19 +00:00
Andreas Beeker 84be4acea9 Dispose XmlCursor
Replacing a method argument (XmlCursor) with a local instance and then updating it, doesn't make sense

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744002 13f79535-47bb-0310-9956-ffa450edef68
2016-05-16 09:54:01 +00:00
Andreas Beeker 12425ac107 added commons-logging to integration test to make profiling easier - just match the timestamps of the log with the timestamps of the profiling monitor
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744001 13f79535-47bb-0310-9956-ffa450edef68
2016-05-16 09:49:17 +00:00
Andreas Beeker dde2a25283 #59170 - Remove deprecated classes (POI 3.15) - use FormulaError instead of ErrorConstants
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744000 13f79535-47bb-0310-9956-ffa450edef68
2016-05-16 09:38:42 +00:00
Andreas Beeker 401a9fb477 #58144 - Behaviour for headers and footers of slides is inconsistent between slideshows created in 2003 and 2007
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1743769 13f79535-47bb-0310-9956-ffa450edef68
2016-05-13 23:50:39 +00:00
Javen O'Neal 4a3acf4de0 add @since to javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742882 13f79535-47bb-0310-9956-ffa450edef68
2016-05-09 05:47:49 +00:00
Javen O'Neal 730641576a bug 59443: exit early on setAddress if address is the same
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742881 13f79535-47bb-0310-9956-ffa450edef68
2016-05-09 05:46:14 +00:00
Javen O'Neal 191726ee7b bug 59443: use Comment.setAddress when changing both row and column of cell comment address
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742880 13f79535-47bb-0310-9956-ffa450edef68
2016-05-09 05:25:29 +00:00
Javen O'Neal 70459401a3 bug 59443: add get/setAddress methods on cell comment class
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742879 13f79535-47bb-0310-9956-ffa450edef68
2016-05-09 05:09:41 +00:00
Javen O'Neal fe04abd31d fix BasteTestCellComment#attemptToSave2CommentsWithSameCoordinates to work with different behaviors of HSSFWorkbook and XSSFWorkbook
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742871 13f79535-47bb-0310-9956-ffa450edef68
2016-05-09 04:29:17 +00:00
Javen O'Neal e9bfa9da87 whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742869 13f79535-47bb-0310-9956-ffa450edef68
2016-05-09 03:53:55 +00:00
Javen O'Neal a92163e9b6 add disabled unit test for bug 59393 from stone
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742868 13f79535-47bb-0310-9956-ffa450edef68
2016-05-09 03:49:16 +00:00
Javen O'Neal 88d0eee64b move TestHSSFComment#attemptToSave2CommentsWithSameCoordinates down to BaseTestCellComment
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742866 13f79535-47bb-0310-9956-ffa450edef68
2016-05-09 03:35:45 +00:00
Javen O'Neal 94e4eb5276 merge TestComment into TestHSSFComment
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742865 13f79535-47bb-0310-9956-ffa450edef68
2016-05-09 03:27:32 +00:00
Javen O'Neal 25552a1453 add test case from Anders Åberg for bug 59442
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742862 13f79535-47bb-0310-9956-ffa450edef68
2016-05-09 01:27:31 +00:00
Javen O'Neal 3920d0660c Test CellUtil with XSSFWorkbook and SXSSFWorkbook instances
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742860 13f79535-47bb-0310-9956-ffa450edef68
2016-05-09 01:12:25 +00:00
Javen O'Neal 9fba427794 convert TestCellUtil to BaseTestCellUtil so that it can be tested with different workbook instances
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742859 13f79535-47bb-0310-9956-ffa450edef68
2016-05-09 01:09:36 +00:00
Andreas Beeker f850d93b68 #59434 - Cannot add a picture on a slide that already have an image with an hyperlink on it
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742816 13f79535-47bb-0310-9956-ffa450edef68
2016-05-08 13:28:11 +00:00
Dominik Stadler 61f84af565 Try to print out more information if the timestamp-operation fails
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742425 13f79535-47bb-0310-9956-ffa450edef68
2016-05-05 12:22:44 +00:00
Dominik Stadler d158ef23bd Close file-handles in tests as well to avoid noise when running file-leak-detection
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742424 13f79535-47bb-0310-9956-ffa450edef68
2016-05-05 12:22:37 +00:00
Dominik Stadler 8908412e3a Some general code-fixes found while trying out Java 9
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742423 13f79535-47bb-0310-9956-ffa450edef68
2016-05-05 12:22:31 +00:00
Dominik Stadler 56c5bd05e1 Try to catch more network-unavailable cases in TestSignatureInfo
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742422 13f79535-47bb-0310-9956-ffa450edef68
2016-05-05 12:22:23 +00:00
Dominik Stadler 26de463419 Refactor SSPerformanceTest into a few methods to make it easier to use a profiler
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742420 13f79535-47bb-0310-9956-ffa450edef68
2016-05-05 12:22:16 +00:00
Andreas Beeker f688ed96c6 #59327 - Setting text direction on a table cell has no effect
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742338 13f79535-47bb-0310-9956-ffa450edef68
2016-05-04 22:09:10 +00:00
Javen O'Neal 808254af89 bug 59383: getFormat should cache data formatter (fix from Nick C), accidentally deleted in bug 58532 r1710407.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1741114 13f79535-47bb-0310-9956-ffa450edef68
2016-04-26 22:48:02 +00:00
Javen O'Neal 20b11d54b1 remove unused import
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739689 13f79535-47bb-0310-9956-ffa450edef68
2016-04-18 04:47:06 +00:00
Javen O'Neal 480ec67d81 add unit test for SXSSFSheet#changeRowNum
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739688 13f79535-47bb-0310-9956-ffa450edef68
2016-04-18 04:46:05 +00:00
Javen O'Neal 1e07b01af3 whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739661 13f79535-47bb-0310-9956-ffa450edef68
2016-04-17 21:51:16 +00:00
Javen O'Neal ba64b65412 add unit test for StringUtil#join
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739660 13f79535-47bb-0310-9956-ffa450edef68
2016-04-17 21:28:49 +00:00
Javen O'Neal 556f1e78a1 restore r1739550 and r1739552 (by reverting r1739580). Exclude BaseTestXWorkbook, BaseTestXSheet, BaseTestXRow, and BaseTestXCell from the OOXML-Lite target
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739644 13f79535-47bb-0310-9956-ffa450edef68
2016-04-17 20:17:04 +00:00
Javen O'Neal dca380f057 reformat exclude classes regular expression for OOXMLLite
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739643 13f79535-47bb-0310-9956-ffa450edef68
2016-04-17 20:02:17 +00:00
Javen O'Neal ae5b894886 upgrade TestPaletteRecord to junit4
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739587 13f79535-47bb-0310-9956-ffa450edef68
2016-04-17 11:40:18 +00:00
Javen O'Neal e66fc6b289 bug 58896: write autoSizeColumn timing to POILogger instead of standard output
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739584 13f79535-47bb-0310-9956-ffa450edef68
2016-04-17 11:36:50 +00:00
Javen O'Neal e678eeb582 revert r1739548 and r1739550. I could not figure out how to add BaseTestXWorkbook|Sheet|Row.java without causing junit to complain about 'Test class should have exactly one public constructor'
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739580 13f79535-47bb-0310-9956-ffa450edef68
2016-04-17 11:25:35 +00:00
Javen O'Neal 0b9fea928e add comments
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739554 13f79535-47bb-0310-9956-ffa450edef68
2016-04-17 08:42:26 +00:00
Javen O'Neal da6d61f83b consolidate duplicates between TestXSSF* and TestSXSSF*
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739552 13f79535-47bb-0310-9956-ffa450edef68
2016-04-17 08:40:27 +00:00
Javen O'Neal 144758da98 add junit test classes for combined testing of XML-specific functionality of (S)XSSF Workbook, Sheet, and Row
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739550 13f79535-47bb-0310-9956-ffa450edef68
2016-04-17 08:06:30 +00:00
Javen O'Neal ec84916a9f bug 59342: add sheet tab color getter and setter
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739548 13f79535-47bb-0310-9956-ffa450edef68
2016-04-17 07:39:36 +00:00
Javen O'Neal 4d4b54b7c8 bug 59342: add sheet tab color getter and setter
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739547 13f79535-47bb-0310-9956-ffa450edef68
2016-04-17 07:38:15 +00:00
Javen O'Neal 3ba74f8319 bug 59340: lookup IndexedColors by index
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739539 13f79535-47bb-0310-9956-ffa450edef68
2016-04-17 03:39:21 +00:00
Javen O'Neal 48bba39dcf move unit test for XSSFSheet.setTabColor from TestXSSFWorkbook to TestXSSFSheet
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739538 13f79535-47bb-0310-9956-ffa450edef68
2016-04-17 03:35:58 +00:00
Javen O'Neal 4e33c06871 bug 59336: patch from Mark Murphy: deprecate functions in CellUtil that require an unnecessary Workbook argument.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739536 13f79535-47bb-0310-9956-ffa450edef68
2016-04-17 01:29:19 +00:00
Javen O'Neal f3af2a116b bug 59336: patch from Mark Murphy: replace deprecated usage of functions in CellUtil
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739533 13f79535-47bb-0310-9956-ffa450edef68
2016-04-17 00:32:32 +00:00
Javen O'Neal 6043813e67 bug 59338: patch from Mark Murphy to deprecate HSSFCellUtil class in favor of CellUtil.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739531 13f79535-47bb-0310-9956-ffa450edef68
2016-04-17 00:20:37 +00:00
Javen O'Neal 393ccc1873 fix Sonar warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738876 13f79535-47bb-0310-9956-ffa450edef68
2016-04-12 22:44:28 +00:00
Javen O'Neal ecf7db3223 bug 59312: delete temporary files even when the output stream cannot be closed (such as out of disk space IOException)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738848 13f79535-47bb-0310-9956-ffa450edef68
2016-04-12 18:48:31 +00:00
Javen O'Neal d94ff1aa8e javadocs fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738789 13f79535-47bb-0310-9956-ffa450edef68
2016-04-12 12:19:49 +00:00
Javen O'Neal a4af4fc6c3 fix several findbugs SF_SWITCH_NO_DEFAULT warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738782 13f79535-47bb-0310-9956-ffa450edef68
2016-04-12 12:03:24 +00:00
Javen O'Neal 9e389627cc whitespace (tabs to spaces)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738773 13f79535-47bb-0310-9956-ffa450edef68
2016-04-12 11:28:25 +00:00
Javen O'Neal cb5544ad9f fix several findbugs SF_SWITCH_NO_DEFAULT warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738765 13f79535-47bb-0310-9956-ffa450edef68
2016-04-12 11:12:57 +00:00
Javen O'Neal aa6083ce0a add LINK_TYPE_SECONDARY_CATEGORIES, which appears to be a valid type (0x03) based on HSSFChart.insertData
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738762 13f79535-47bb-0310-9956-ffa450edef68
2016-04-12 11:03:58 +00:00
Dominik Stadler 78a05ca7a0 Fix compiler warnings and ensure CTChartSheets stays included and is not refactored out by automated import reorganization
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738752 13f79535-47bb-0310-9956-ffa450edef68
2016-04-12 10:09:44 +00:00
Javen O'Neal 921c9b9e4b junit4 assert* improvements, add CTChartsheet to unit test so that it's compiled into poi-ooxml-schemas.jar (if it isn't already)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738742 13f79535-47bb-0310-9956-ffa450edef68
2016-04-12 09:22:48 +00:00
Javen O'Neal db25900315 convert to junit4
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738738 13f79535-47bb-0310-9956-ffa450edef68
2016-04-12 08:51:45 +00:00
Dominik Stadler 4010992ac2 Exclude file that was modified and now fails with the known limitation of sheet-cloning
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738704 13f79535-47bb-0310-9956-ffa450edef68
2016-04-12 06:56:06 +00:00
Javen O'Neal 68ac23176f convert to junit4
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738680 13f79535-47bb-0310-9956-ffa450edef68
2016-04-12 03:43:33 +00:00
Javen O'Neal a4808bb56c whitespace: +svn:eol-style=native, tabs to 4 spaces
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738679 13f79535-47bb-0310-9956-ffa450edef68
2016-04-12 03:21:01 +00:00
Javen O'Neal 4260aa76c2 javadoc typo
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738677 13f79535-47bb-0310-9956-ffa450edef68
2016-04-12 03:13:52 +00:00
Javen O'Neal d59c08e954 fix javadocs and findbugs warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738674 13f79535-47bb-0310-9956-ffa450edef68
2016-04-12 01:30:20 +00:00
Javen O'Neal 5e51b9e89b bug 52949: add unit test for reading VBA Macros from a Visio OOXML (VSDM, 2013+) file
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738651 13f79535-47bb-0310-9956-ffa450edef68
2016-04-11 21:35:22 +00:00
Javen O'Neal bbf912dceb bug 52949: add VBAMacroReader unit tests for H/XSLF, H/XWPF, and HGDF; OLE directories as case-insensitive
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738513 13f79535-47bb-0310-9956-ffa450edef68
2016-04-11 05:54:17 +00:00
Javen O'Neal d6252e00b1 bug 52949: fix forbidden apis
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738499 13f79535-47bb-0310-9956-ffa450edef68
2016-04-11 01:26:09 +00:00
Javen O'Neal f49047e733 add @NotImplemented annotation to methods that are not implemented
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738469 13f79535-47bb-0310-9956-ffa450edef68
2016-04-10 21:28:41 +00:00
Javen O'Neal f2e250d7e4 ignore VBA source files in integration test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738460 13f79535-47bb-0310-9956-ffa450edef68
2016-04-10 20:21:55 +00:00
Javen O'Neal f49897de27 bug 52949: parameterize fromNPOIFS also
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738439 13f79535-47bb-0310-9956-ffa450edef68
2016-04-10 14:46:42 +00:00
Javen O'Neal 9f36d6c876 bug 52949: prepare for adding DOC/DOCM and PPT/PPTM test cases
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738438 13f79535-47bb-0310-9956-ffa450edef68
2016-04-10 14:33:47 +00:00
Javen O'Neal 014d371a5f bug 52949: add junit test for RLEDecompressingInputStream
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738436 13f79535-47bb-0310-9956-ffa450edef68
2016-04-10 14:09:02 +00:00
Javen O'Neal 8898db6b2e svn propset svn:eol-style native
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738435 13f79535-47bb-0310-9956-ffa450edef68
2016-04-10 14:05:33 +00:00
Nick Burch d7981342e0 Javadoc tweaks
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738431 13f79535-47bb-0310-9956-ffa450edef68
2016-04-10 13:02:36 +00:00
Nick Burch e8e1a294e6 Make the extractor exactly that, powered by the reader #52949
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738429 13f79535-47bb-0310-9956-ffa450edef68
2016-04-10 12:59:38 +00:00
Nick Burch 2185e91883 Unit test for VBA macro reading #52949
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738427 13f79535-47bb-0310-9956-ffa450edef68
2016-04-10 12:45:53 +00:00
Nick Burch 82351e8fea Start to refactor VBAMacroExtractor into a more general class
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738423 13f79535-47bb-0310-9956-ffa450edef68
2016-04-10 11:54:09 +00:00
Nick Burch 4abcc6626a VBA extraction support from bug #52949 from Barry Lagerweij
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738418 13f79535-47bb-0310-9956-ffa450edef68
2016-04-10 11:16:49 +00:00
Dominik Stadler 2a0ed81538 Bug 57844: Add some javadoc for unimplemented features in SXSSF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738413 13f79535-47bb-0310-9956-ffa450edef68
2016-04-10 09:40:40 +00:00
Tim Allison a060c664a1 close fileinputstream on second exception in ZipPackage
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738251 13f79535-47bb-0310-9956-ffa450edef68
2016-04-08 14:36:05 +00:00
Dominik Stadler 3718d45538 In Example FromHowTo, open the OPCPacakge read-only to not try to write it back on close()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738097 13f79535-47bb-0310-9956-ffa450edef68
2016-04-07 07:25:02 +00:00
Dominik Stadler 5c1780aa72 Close two more file-handles in Example FromHowTo
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738035 13f79535-47bb-0310-9956-ffa450edef68
2016-04-06 19:50:20 +00:00
Dominik Stadler 8b10d4d71b Tried to evaluate all formulas in worksheets as part of the integration tests, but some documents fail and it probably increases runtime of tests considerably, so left commented out for now.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738034 13f79535-47bb-0310-9956-ffa450edef68
2016-04-06 19:50:14 +00:00
Dominik Stadler b9e7c32ffe Bug 58648: Fix handling whitespaces in formulas, unfortunately blank can be the intersection operator as well, so we need to try and skip it as whitespace if intersection fails which can lead to hard to track bugs or misleading error messages with some formulas
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738033 13f79535-47bb-0310-9956-ffa450edef68
2016-04-06 19:50:08 +00:00
Dominik Stadler ec6bb2a066 Slightly improve error message
Fix some IntelliJ/compiler warnings
Use common interfaces where possible
Cleanup after testing POIFSDump

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738032 13f79535-47bb-0310-9956-ffa450edef68
2016-04-06 19:49:59 +00:00
Dominik Stadler 62ee0abc13 Code cleanup via IntelliJ: Remove unnecessary semicolon
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738031 13f79535-47bb-0310-9956-ffa450edef68
2016-04-06 19:49:47 +00:00
Dominik Stadler 2c4a66ee49 Add missing license header
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737963 13f79535-47bb-0310-9956-ffa450edef68
2016-04-06 10:52:36 +00:00
Dominik Stadler 5dc647da61 Bug 56911: Fix IndexOutOfBoundsException in PlfLfo.add() and add minimal test, however these classes look quite untested and thus require more test-coverage to make them more robust
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737947 13f79535-47bb-0310-9956-ffa450edef68
2016-04-06 09:00:05 +00:00
Nick Burch a456ad5d77 Fix javadoc warning - As per http://bugs.java.com/bugdatabase/view_bug.do;jsessionid=d014dfa686594180be40ca5872f5?bug_id=4907024 an @see is only allowed a single link with nothing after it
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737924 13f79535-47bb-0310-9956-ffa450edef68
2016-04-06 06:28:14 +00:00
Javen O'Neal 7fd89e0e39 add test coverage for TestSXSSFCell.toString() on blank and date cells
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737923 13f79535-47bb-0310-9956-ffa450edef68
2016-04-06 06:01:26 +00:00
Javen O'Neal f9c74888e3 add test coverage for WorkbookFactory.create(File file, String password, Boolean readOnly) when file does not exists
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737917 13f79535-47bb-0310-9956-ffa450edef68
2016-04-06 05:15:15 +00:00
Javen O'Neal bed6a46d10 bug 59264: fix javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737914 13f79535-47bb-0310-9956-ffa450edef68
2016-04-06 04:32:36 +00:00
Javen O'Neal b8dcd4df42 bug 59264: fix findbugs warning 'A boxed value is unboxed and then immediately reboxed.'
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737896 13f79535-47bb-0310-9956-ffa450edef68
2016-04-06 00:06:53 +00:00
Javen O'Neal c95f6a4b35 whitespace (tabs to 4 spaces)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737895 13f79535-47bb-0310-9956-ffa450edef68
2016-04-05 23:47:41 +00:00
Javen O'Neal fe13debb84 bug 59264: move border style deprecations to POI 3.15 beta 2.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737894 13f79535-47bb-0310-9956-ffa450edef68
2016-04-05 23:30:37 +00:00
Javen O'Neal e2399abbe9 bug 59264: type safety: check if border code is a valid BorderStyle enum for setBorderX(short)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737886 13f79535-47bb-0310-9956-ffa450edef68
2016-04-05 21:38:55 +00:00
Javen O'Neal 5752c4bb7e bug 59264: allow borders styles to be set with BorderStyles enums or Short codes for backwards compatibility
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737885 13f79535-47bb-0310-9956-ffa450edef68
2016-04-05 21:36:11 +00:00
Javen O'Neal f7939c4c95 bug 59264: add link to BorderStyle on deprecated BORDER_* constants
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737884 13f79535-47bb-0310-9956-ffa450edef68
2016-04-05 21:34:24 +00:00
Javen O'Neal 1786767b89 bug 59264: use BorderStyle for changing Cell border line style
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737879 13f79535-47bb-0310-9956-ffa450edef68
2016-04-05 20:28:46 +00:00
Javen O'Neal 739196e5b3 bug 59264: copy cell border style codes (from CellStyle.java) into BorderStyle enum
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737752 13f79535-47bb-0310-9956-ffa450edef68
2016-04-04 23:27:20 +00:00
Javen O'Neal 8e1b343761 rearrange BORDER_DOTTED and BORDER_HAIR
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737751 13f79535-47bb-0310-9956-ffa450edef68
2016-04-04 23:26:44 +00:00
Dominik Stadler b46a57926c Bug 55982: Don't fail to open the spreadsheet if no TabIdRecord is found
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737602 13f79535-47bb-0310-9956-ffa450edef68
2016-04-03 18:32:22 +00:00
Dominik Stadler e8263f9d8f Fix two more places where wrong/invalid files can lead to file-handle leaks currently
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737489 13f79535-47bb-0310-9956-ffa450edef68
2016-04-02 11:01:56 +00:00