d5528af80c
Add more unit tests to cover more of HSSFWorkbook and HSSFSheet, check one more case of IndexOutOfBoundsException
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1502661 13f79535-47bb-0310-9956-ffa450edef68
2013-07-12 19:21:12 +00:00
6367b8b74e
Add reproducing unit tests to TestUnfixedBugs for Bug 53798 and Bug 54071
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1501263 13f79535-47bb-0310-9956-ffa450edef68
2013-07-09 13:55:54 +00:00
7cc22dd3c1
Refactor to avoid logic duplication on the property value -> string conversion
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1499329 13f79535-47bb-0310-9956-ffa450edef68
2013-07-03 11:36:11 +00:00
fb8d0c1076
Fix bug #55191 - Avoid a ClassCastException if a HPSF string property isn't directly stored as a string
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1499326 13f79535-47bb-0310-9956-ffa450edef68
2013-07-03 11:24:01 +00:00
5a0887c9e4
Fix build broken by previous checkin by creating a TestUnfixedBugs for ooxml as well and excluding the new test-class in test-ooxml similar to the main tests.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1498280 13f79535-47bb-0310-9956-ffa450edef68
2013-07-01 08:03:40 +00:00
067c62168e
Bug 54084: Add testcase which reproduces the bug, no fix available yet
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1498190 13f79535-47bb-0310-9956-ffa450edef68
2013-06-30 22:47:26 +00:00
1b66a17f74
Adjust build.xml to update to junit 4.11
...
Also allow to specify a pattern to only run certain unit tests.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1498178 13f79535-47bb-0310-9956-ffa450edef68
2013-06-30 20:49:51 +00:00
3046f139c7
Add a test to show that bug #53150 has been fixed by the recent fraction work
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1497084 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 20:40:26 +00:00
dd1116a1e3
Have MAPIMessage try the codepage properties to get the ascii encoding, before falling back to the existing logic around content type parsing
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1497038 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 18:46:37 +00:00
e82421ef02
HSMF generally wants Java Lang style encoding names, which HPSF has always worked with Java NIO ones, so add a flag to CodePageUtil to let you select which style to return
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1497037 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 18:44:51 +00:00
8aca6fde15
Deprecate the old HPSF codepage Constants list, and change the code to use the new CodePageUtil class instead for their codepage work
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1497035 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 18:20:37 +00:00
f073151b1a
Bring the numeric CodePage support from HPSF (constants and converters) out to a new Util class, so that HSMF can later use it
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1497032 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 18:18:21 +00:00
43b811f049
More unit tests for the HSMF fixed sized property values (a few still remain to be fixed though)
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1497023 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 17:45:57 +00:00
b37e3c6df2
Make the fixed sized properties parser more flexible in the face of slightly duff data
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1497006 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 17:03:26 +00:00
a9e1c0e320
Dig out the normal type for some more common properties
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1497004 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 16:58:11 +00:00
b8644921c9
Support decoding a few more property types
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496988 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 16:17:00 +00:00
c5893c8c34
More friendly output of byte arrays for property values in HSMFDump
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496982 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 16:03:09 +00:00
43886b815b
Fix inconsistent whitespace in HSMF test files
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496969 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 15:28:25 +00:00
73aa6c507e
Fix inconsistent whitespace in HSMF files
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496962 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 15:23:29 +00:00
4c4d512d4a
Ensure the indenting is consistent within the file, and then make some minor updates to the JavaDocs (language, clarity etc)
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496952 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 14:57:36 +00:00
1ae9e8eba6
Fix JavaDoc warnings
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496701 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 00:56:28 +00:00
b3e4741320
Convert classes with a assertContains method to using the new POITestCase common parent class, which has it there
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496697 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 00:49:41 +00:00
3783080709
Add disabled unit test for bug #54916
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496696 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 00:45:18 +00:00
fd9a30a8cc
New parent test class, which includes the common assertContains pattern
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496695 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 00:44:35 +00:00
43355883c8
JavaDoc fix - missing >
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496685 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 00:21:40 +00:00
82df889469
Add a write method to HPSFPropertiesOnlyDocument, and use this to finish the unit tests for bug #54233
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496683 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 00:18:41 +00:00
90b74675d5
Pull the Properties-Only document type out to a superclass, so other places (eg unit tests) can use it
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496680 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 00:10:43 +00:00
40d49a54d2
Fix bug #54233 - Some HPSF documents require UnicodeStrings to be 4-byte aligned, spot these from the otherwise invalid length
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496675 13f79535-47bb-0310-9956-ffa450edef68
2013-06-25 23:49:24 +00:00
bd92cbc8b5
Fix to have consistent whitespace, and add javadoc deprecated entries
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496673 13f79535-47bb-0310-9956-ffa450edef68
2013-06-25 23:34:22 +00:00
9d87fb9caa
Fix to have consistent whitespace
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496671 13f79535-47bb-0310-9956-ffa450edef68
2013-06-25 23:30:37 +00:00
666841c1e7
Sample file from bug #54233
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496668 13f79535-47bb-0310-9956-ffa450edef68
2013-06-25 23:22:46 +00:00
c147316ff5
Update trunk after 3.10-beta1 tagging in svn
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496661 13f79535-47bb-0310-9956-ffa450edef68
2013-06-25 22:40:02 +00:00
2af696a3ce
Prep for 3.10 beta 1
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496659 13f79535-47bb-0310-9956-ffa450edef68
2013-06-25 22:38:48 +00:00
d4a2a13b77
Remove the executable flag from a number of files that aren't executables so shouldn't have it set
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496656 13f79535-47bb-0310-9956-ffa450edef68
2013-06-25 22:12:48 +00:00
f7a7eeec22
Add missing license headers, and a few javadoc tweaks while working on those files
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496652 13f79535-47bb-0310-9956-ffa450edef68
2013-06-25 22:04:49 +00:00
84a00d8d4b
Sanity check the length, logging and truncating if too long, to avoid a StringIndexOutOfBoundsException (bug #54925 )
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496520 13f79535-47bb-0310-9956-ffa450edef68
2013-06-25 15:49:45 +00:00
456f6171d9
Fix the indenting to be consistent throughout the file
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496519 13f79535-47bb-0310-9956-ffa450edef68
2013-06-25 15:44:36 +00:00
56d1f1b97a
Add another record type to the "don't warn" list, and tidy up the code a little bit (see bug #54925 )
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496518 13f79535-47bb-0310-9956-ffa450edef68
2013-06-25 15:40:05 +00:00
a7bfec9271
Fix from Florian Hopf from bug #54564 - Fix error message text
...
for a workbook with no sheets when a sheet operation is performed
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496516 13f79535-47bb-0310-9956-ffa450edef68
2013-06-25 15:19:56 +00:00
ed5588d9af
Fix indenting to be consistent, and correct the setIncludeCellComments javadoc to match the long standing default ( #54871 )
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496510 13f79535-47bb-0310-9956-ffa450edef68
2013-06-25 15:05:27 +00:00
dbd1a59416
Patch from Andrew Novikov from bug #53972 - Presence of PLV record shouldn't affect HSSF Data Validation
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496499 13f79535-47bb-0310-9956-ffa450edef68
2013-06-25 14:48:16 +00:00
678991d868
Patch from Tim Allison from bug #55142 - Not all XWPF SDT block
...
s need newlines
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496458 13f79535-47bb-0310-9956-ffa450edef68
2013-06-25 13:09:08 +00:00
c1d02cd0f5
Bug 54920: do not set column and row separatedely, but use a reference
...
for newComment(), keep previous method as deprecated. Adjust all places
where newComment() is used and add unit test covering the bug.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1495894 13f79535-47bb-0310-9956-ffa450edef68
2013-06-23 21:31:15 +00:00
cb4dfced34
Patch and unit test from Tim Allen from bug #54686 - Improve how DataFormatter handles fractions
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1494986 13f79535-47bb-0310-9956-ffa450edef68
2013-06-20 13:37:26 +00:00
55751c4671
Patch from Tim Allen from bug #55066 - unit test to show that we no longer load XWPF footnotes twice
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1494962 13f79535-47bb-0310-9956-ffa450edef68
2013-06-20 12:51:30 +00:00
d80ec206c6
Avoid a NPE if no password was given - use the default office one instead
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1494571 13f79535-47bb-0310-9956-ffa450edef68
2013-06-19 11:56:21 +00:00
7117fe26ad
Fix the footnote doubling, and then enable the rest of the SDT tests from Tim Allison from bug #54849
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1494379 13f79535-47bb-0310-9956-ffa450edef68
2013-06-18 23:39:31 +00:00
28899342eb
Remove tab indents
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1494378 13f79535-47bb-0310-9956-ffa450edef68
2013-06-18 23:38:25 +00:00
58b92caebe
Patch from Tim Allison from bug #54849 - Controlled content/Form (Std/StdBlock) content
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1494376 13f79535-47bb-0310-9956-ffa450edef68
2013-06-18 23:35:11 +00:00
426a6f3451
Bug 54607: Add unit test and fix NPE for getTopRow() and getLeftCol()
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1493686 13f79535-47bb-0310-9956-ffa450edef68
2013-06-17 09:06:39 +00:00
Dominik Stadler