Commit Graph

4402 Commits

Author SHA1 Message Date
Dominik Stadler
b79d4fda52 Tried to reproduce Bug 47090, but seems to be fixed now.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516982 13f79535-47bb-0310-9956-ffa450edef68
2013-08-23 18:56:32 +00:00
Dominik Stadler
13e08c3e92 Add testcase which tries to reproduce Bug 48495, but seems to be fixed
now.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516981 13f79535-47bb-0310-9956-ffa450edef68
2013-08-23 18:56:11 +00:00
Dominik Stadler
f8f998b80b Some Eclipse warnings removed
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516980 13f79535-47bb-0310-9956-ffa450edef68
2013-08-23 18:54:05 +00:00
Nick Burch
689aa10390 Add some explicit tests for column letter to/from number conversion
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516978 13f79535-47bb-0310-9956-ffa450edef68
2013-08-23 18:52:18 +00:00
Nick Burch
8b0334c701 Remove some @author tags, as per http://poi.apache.org/guidelines.html#CodeStyle
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516975 13f79535-47bb-0310-9956-ffa450edef68
2013-08-23 18:42:57 +00:00
Nick Burch
f04c20ce5d Start to remove @author tags, as per http://poi.apache.org/guidelines.html#CodeStyle
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516973 13f79535-47bb-0310-9956-ffa450edef68
2013-08-23 18:36:41 +00:00
Nick Burch
95fb311279 Inspired by github pull-6, use a StringBuilder for quicker string appending
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516969 13f79535-47bb-0310-9956-ffa450edef68
2013-08-23 18:30:01 +00:00
Dominik Stadler
bff0813e48 fix some Eclipse warnings, adjust some unit tests slightly
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516818 13f79535-47bb-0310-9956-ffa450edef68
2013-08-23 10:44:39 +00:00
Dominik Stadler
37b7f408a3 Fix unit test for Bug 50298 some more
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516320 13f79535-47bb-0310-9956-ffa450edef68
2013-08-21 22:57:26 +00:00
Dominik Stadler
f0a8bc9281 Adjust test for Bug 50298 to not leave a temporary file behind and
enhance the test with some more cases of moving/changing/removing sheet
order/names

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516314 13f79535-47bb-0310-9956-ffa450edef68
2013-08-21 22:19:58 +00:00
Dominik Stadler
1249614bc8 Bug 50298: Fix corruption of Workbook when setting sheet order. The
boundssheets themselves were adjusted, but not the corresponding
records.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516313 13f79535-47bb-0310-9956-ffa450edef68
2013-08-21 22:08:20 +00:00
Dominik Stadler
134195c86c Also fix some Eclipse warnings while hunting Bugs: Generics, unused
variables, ...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516312 13f79535-47bb-0310-9956-ffa450edef68
2013-08-21 22:06:07 +00:00
Nick Burch
75a56dcf22 Push the fix for bug #55248 up to the Sheet interface (was XSSF only before)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516124 13f79535-47bb-0310-9956-ffa450edef68
2013-08-21 09:41:15 +00:00
Dominik Stadler
9e62269eef Bug 52233: try to fix this without breaking the format of xlsx-files.
The set to null is necessary to not have an empty <cols/> element in the
xlsx, however later on stuff breaks if no colsArray is availalbe,
therefore we now re-create the empty cols array if we did remove it
before.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1515916 13f79535-47bb-0310-9956-ffa450edef68
2013-08-20 18:44:44 +00:00
Dominik Stadler
4a675204cb Revert changes from rev. 1513916 as it severly broke writing valid xlsx files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1515842 13f79535-47bb-0310-9956-ffa450edef68
2013-08-20 15:03:18 +00:00
Cédric Walter
72d3a7d2a3 Bug 55043: patch for missing function QUOTIENT
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1514847 13f79535-47bb-0310-9956-ffa450edef68
2013-08-16 18:54:35 +00:00
Cédric Walter
67f198e752 Bug 55082: patch for missing function ROMAN
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1514834 13f79535-47bb-0310-9956-ffa450edef68
2013-08-16 18:28:18 +00:00
Cédric Walter
7962fc2a9e Bug 55080: patch for missing function IMREAL
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1514830 13f79535-47bb-0310-9956-ffa450edef68
2013-08-16 18:13:40 +00:00
Cédric Walter
aba46897dc Bug 55079: patch for missing function IMAGINARY
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1514824 13f79535-47bb-0310-9956-ffa450edef68
2013-08-16 17:59:01 +00:00
Cédric Walter
a727830c61 Bug 54720: Support for Row/Col Area Range like 8:8 or H:H
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1514812 13f79535-47bb-0310-9956-ffa450edef68
2013-08-16 17:35:16 +00:00
Cédric Walter
baee918c5a Bug 54723: Support for percentage in VALUE() function
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1514799 13f79535-47bb-0310-9956-ffa450edef68
2013-08-16 17:15:47 +00:00
Dominik Stadler
ed2e2a28bc Bug 54786: Fix missing quoting in date formatting, add a number of unit
tests which verify the new formatting options.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1514632 13f79535-47bb-0310-9956-ffa450edef68
2013-08-16 09:38:47 +00:00
Tim Allison
a62fcb2fbf 55419 and refactor SimpleFraction
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1514123 13f79535-47bb-0310-9956-ffa450edef68
2013-08-15 01:46:25 +00:00
Dominik Stadler
17f3b2cb26 Bug 52233: Do not make the XSSFSheet invalid during write(), I could not find out why the ColsArray was set to null in the write() method. By removing this the writing of the sheet does not invalidate the Workbook any more and makes the test case work fine.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1513916 13f79535-47bb-0310-9956-ffa450edef68
2013-08-14 14:57:44 +00:00
Dominik Stadler
2834048155 Various small Eclipse warning fixes,
also ensure close() of stream in Ant-Task, although WorkbookFactory usually takes care of this, however in exception-cases it could be missing

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1513764 13f79535-47bb-0310-9956-ffa450edef68
2013-08-14 08:25:51 +00:00
Dominik Stadler
5ce961a826 Bug 55195: use interface instead of implementation for
NumericValueEval and others.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1513247 13f79535-47bb-0310-9956-ffa450edef68
2013-08-12 20:27:08 +00:00
Dominik Stadler
4a3138f575 Bug 55380: Fix endless loop in CellRangeUtil.mergeCellRanges() by not trying to merge overlapping regions any more, the implementation is buggy and even tagged TODO - unit test missing. The code is hard to understand and bug-free-ness is better than catching all possible merges imho.
Also add many cases to the unit tests and reformat code slightly as well
as fixing some Generics-Warnings.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1513225 13f79535-47bb-0310-9956-ffa450edef68
2013-08-12 19:13:10 +00:00
Tim Allison
ebbbaefe69 55347 - integrate textbox text extraction with Excel extractors
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1511789 13f79535-47bb-0310-9956-ffa450edef68
2013-08-08 14:04:07 +00:00
Tim Allison
0d700b0470 POI 55361 trigger to load CTMoveBookmark in TestXWPFParagraph
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1511777 13f79535-47bb-0310-9956-ffa450edef68
2013-08-08 13:42:01 +00:00
Tim Allison
44824082c3 POI-55294 and 52186
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1510587 13f79535-47bb-0310-9956-ffa450edef68
2013-08-05 16:17:17 +00:00
Dominik Stadler
ffc31302a4 Adjust build.xml to run JaCoCo coverage when running unit tests when
flag coverage.enabled is set to true, download necessary jars, add jacoco:coverage
to junit targets and a testcoveragereport target which produces the coverage report.
Also fix a test that is affected by JaCoCo and add slightly more coverage in another test.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1510243 13f79535-47bb-0310-9956-ffa450edef68
2013-08-04 16:38:01 +00:00
Tim Allison
ee39ef2d73 POI-55292 with added files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1508692 13f79535-47bb-0310-9956-ffa450edef68
2013-07-31 00:21:04 +00:00
Tim Allison
09555c446b POI-55292
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1508691 13f79535-47bb-0310-9956-ffa450edef68
2013-07-31 00:19:07 +00:00
Tim Allison
b21ad9dbd2 added ratted out Apache license to HPSFPropertiesOnlyDocument
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1508190 13f79535-47bb-0310-9956-ffa450edef68
2013-07-29 19:36:24 +00:00
Nick Burch
8e9c0a1cc0 Ensure the interface and implementation javadocs share the same warnings, and paragraph-ise to look nicer
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1503491 13f79535-47bb-0310-9956-ffa450edef68
2013-07-15 21:45:21 +00:00
Dominik Stadler
59455c36a1 Bug 55248: Add methods for showInPane() using int and unit test to verify it can handle more than 32767 rows
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1502749 13f79535-47bb-0310-9956-ffa450edef68
2013-07-13 05:37:41 +00:00
Dominik Stadler
d5528af80c Add more unit tests to cover more of HSSFWorkbook and HSSFSheet, check one more case of IndexOutOfBoundsException
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1502661 13f79535-47bb-0310-9956-ffa450edef68
2013-07-12 19:21:12 +00:00
Dominik Stadler
6367b8b74e Add reproducing unit tests to TestUnfixedBugs for Bug 53798 and Bug 54071
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1501263 13f79535-47bb-0310-9956-ffa450edef68
2013-07-09 13:55:54 +00:00
Nick Burch
7cc22dd3c1 Refactor to avoid logic duplication on the property value -> string conversion
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1499329 13f79535-47bb-0310-9956-ffa450edef68
2013-07-03 11:36:11 +00:00
Nick Burch
fb8d0c1076 Fix bug #55191 - Avoid a ClassCastException if a HPSF string property isn't directly stored as a string
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1499326 13f79535-47bb-0310-9956-ffa450edef68
2013-07-03 11:24:01 +00:00
Dominik Stadler
5a0887c9e4 Fix build broken by previous checkin by creating a TestUnfixedBugs for ooxml as well and excluding the new test-class in test-ooxml similar to the main tests.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1498280 13f79535-47bb-0310-9956-ffa450edef68
2013-07-01 08:03:40 +00:00
Dominik Stadler
067c62168e Bug 54084: Add testcase which reproduces the bug, no fix available yet
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1498190 13f79535-47bb-0310-9956-ffa450edef68
2013-06-30 22:47:26 +00:00
Nick Burch
3046f139c7 Add a test to show that bug #53150 has been fixed by the recent fraction work
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1497084 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 20:40:26 +00:00
Nick Burch
dd1116a1e3 Have MAPIMessage try the codepage properties to get the ascii encoding, before falling back to the existing logic around content type parsing
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1497038 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 18:46:37 +00:00
Nick Burch
e82421ef02 HSMF generally wants Java Lang style encoding names, which HPSF has always worked with Java NIO ones, so add a flag to CodePageUtil to let you select which style to return
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1497037 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 18:44:51 +00:00
Nick Burch
8aca6fde15 Deprecate the old HPSF codepage Constants list, and change the code to use the new CodePageUtil class instead for their codepage work
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1497035 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 18:20:37 +00:00
Nick Burch
f073151b1a Bring the numeric CodePage support from HPSF (constants and converters) out to a new Util class, so that HSMF can later use it
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1497032 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 18:18:21 +00:00
Nick Burch
43b811f049 More unit tests for the HSMF fixed sized property values (a few still remain to be fixed though)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1497023 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 17:45:57 +00:00
Nick Burch
b37e3c6df2 Make the fixed sized properties parser more flexible in the face of slightly duff data
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1497006 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 17:03:26 +00:00
Nick Burch
a9e1c0e320 Dig out the normal type for some more common properties
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1497004 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 16:58:11 +00:00
Nick Burch
b8644921c9 Support decoding a few more property types
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496988 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 16:17:00 +00:00
Nick Burch
c5893c8c34 More friendly output of byte arrays for property values in HSMFDump
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496982 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 16:03:09 +00:00
Nick Burch
43886b815b Fix inconsistent whitespace in HSMF test files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496969 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 15:28:25 +00:00
Nick Burch
73aa6c507e Fix inconsistent whitespace in HSMF files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496962 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 15:23:29 +00:00
Nick Burch
4c4d512d4a Ensure the indenting is consistent within the file, and then make some minor updates to the JavaDocs (language, clarity etc)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496952 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 14:57:36 +00:00
Nick Burch
1ae9e8eba6 Fix JavaDoc warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496701 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 00:56:28 +00:00
Nick Burch
b3e4741320 Convert classes with a assertContains method to using the new POITestCase common parent class, which has it there
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496697 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 00:49:41 +00:00
Nick Burch
3783080709 Add disabled unit test for bug #54916
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496696 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 00:45:18 +00:00
Nick Burch
fd9a30a8cc New parent test class, which includes the common assertContains pattern
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496695 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 00:44:35 +00:00
Nick Burch
43355883c8 JavaDoc fix - missing >
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496685 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 00:21:40 +00:00
Nick Burch
82df889469 Add a write method to HPSFPropertiesOnlyDocument, and use this to finish the unit tests for bug #54233
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496683 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 00:18:41 +00:00
Nick Burch
90b74675d5 Pull the Properties-Only document type out to a superclass, so other places (eg unit tests) can use it
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496680 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 00:10:43 +00:00
Nick Burch
40d49a54d2 Fix bug #54233 - Some HPSF documents require UnicodeStrings to be 4-byte aligned, spot these from the otherwise invalid length
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496675 13f79535-47bb-0310-9956-ffa450edef68
2013-06-25 23:49:24 +00:00
Nick Burch
bd92cbc8b5 Fix to have consistent whitespace, and add javadoc deprecated entries
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496673 13f79535-47bb-0310-9956-ffa450edef68
2013-06-25 23:34:22 +00:00
Nick Burch
9d87fb9caa Fix to have consistent whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496671 13f79535-47bb-0310-9956-ffa450edef68
2013-06-25 23:30:37 +00:00
Nick Burch
d4a2a13b77 Remove the executable flag from a number of files that aren't executables so shouldn't have it set
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496656 13f79535-47bb-0310-9956-ffa450edef68
2013-06-25 22:12:48 +00:00
Nick Burch
f7a7eeec22 Add missing license headers, and a few javadoc tweaks while working on those files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496652 13f79535-47bb-0310-9956-ffa450edef68
2013-06-25 22:04:49 +00:00
Nick Burch
84a00d8d4b Sanity check the length, logging and truncating if too long, to avoid a StringIndexOutOfBoundsException (bug #54925)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496520 13f79535-47bb-0310-9956-ffa450edef68
2013-06-25 15:49:45 +00:00
Nick Burch
456f6171d9 Fix the indenting to be consistent throughout the file
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496519 13f79535-47bb-0310-9956-ffa450edef68
2013-06-25 15:44:36 +00:00
Nick Burch
56d1f1b97a Add another record type to the "don't warn" list, and tidy up the code a little bit (see bug #54925)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496518 13f79535-47bb-0310-9956-ffa450edef68
2013-06-25 15:40:05 +00:00
Nick Burch
a7bfec9271 Fix from Florian Hopf from bug #54564 - Fix error message text
for a workbook with no sheets when a sheet operation is performed

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496516 13f79535-47bb-0310-9956-ffa450edef68
2013-06-25 15:19:56 +00:00
Nick Burch
ed5588d9af Fix indenting to be consistent, and correct the setIncludeCellComments javadoc to match the long standing default (#54871)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496510 13f79535-47bb-0310-9956-ffa450edef68
2013-06-25 15:05:27 +00:00
Nick Burch
dbd1a59416 Patch from Andrew Novikov from bug #53972 - Presence of PLV record shouldn't affect HSSF Data Validation
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496499 13f79535-47bb-0310-9956-ffa450edef68
2013-06-25 14:48:16 +00:00
Nick Burch
678991d868 Patch from Tim Allison from bug #55142 - Not all XWPF SDT block
s need newlines

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496458 13f79535-47bb-0310-9956-ffa450edef68
2013-06-25 13:09:08 +00:00
Dominik Stadler
c1d02cd0f5 Bug 54920: do not set column and row separatedely, but use a reference
for newComment(), keep previous method as deprecated. Adjust all places
where newComment() is used and add unit test covering the bug.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1495894 13f79535-47bb-0310-9956-ffa450edef68
2013-06-23 21:31:15 +00:00
Nick Burch
cb4dfced34 Patch and unit test from Tim Allen from bug #54686 - Improve how DataFormatter handles fractions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1494986 13f79535-47bb-0310-9956-ffa450edef68
2013-06-20 13:37:26 +00:00
Nick Burch
55751c4671 Patch from Tim Allen from bug #55066 - unit test to show that we no longer load XWPF footnotes twice
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1494962 13f79535-47bb-0310-9956-ffa450edef68
2013-06-20 12:51:30 +00:00
Nick Burch
d80ec206c6 Avoid a NPE if no password was given - use the default office one instead
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1494571 13f79535-47bb-0310-9956-ffa450edef68
2013-06-19 11:56:21 +00:00
Nick Burch
7117fe26ad Fix the footnote doubling, and then enable the rest of the SDT tests from Tim Allison from bug #54849
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1494379 13f79535-47bb-0310-9956-ffa450edef68
2013-06-18 23:39:31 +00:00
Nick Burch
28899342eb Remove tab indents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1494378 13f79535-47bb-0310-9956-ffa450edef68
2013-06-18 23:38:25 +00:00
Nick Burch
58b92caebe Patch from Tim Allison from bug #54849 - Controlled content/Form (Std/StdBlock) content
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1494376 13f79535-47bb-0310-9956-ffa450edef68
2013-06-18 23:35:11 +00:00
Dominik Stadler
426a6f3451 Bug 54607: Add unit test and fix NPE for getTopRow() and getLeftCol()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1493686 13f79535-47bb-0310-9956-ffa450edef68
2013-06-17 09:06:39 +00:00
Dominik Stadler
eee1b1af23 Bug 54982: Add a close() interface to POITextExtractor which can be used to free resources later.
Implement close() where necessary so resources are closed. Add close()
to tests and run existing unit tests also against the Extractor that is
built via the Factory. Also add a small test-suite to quickly execute
all extractor-related tests.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1493669 13f79535-47bb-0310-9956-ffa450edef68
2013-06-17 07:53:59 +00:00
Nick Burch
bd1214db1e Patch from Trejkaz from GitHub Pull 2 - HSSFWorkbook.getAllEmbeddedObjects() needs to recurse into container Shapes (with new unit test)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1493001 13f79535-47bb-0310-9956-ffa450edef68
2013-06-14 08:53:29 +00:00
Nick Burch
042aab4030 Fix and update JavaDoc entries, and correct areas with wildy inconsistent whitespace / style to the surrounding code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1492818 13f79535-47bb-0310-9956-ffa450edef68
2013-06-13 18:52:03 +00:00
Nick Burch
ab19d2e09c Fix and update JavaDoc entries, and correct areas with wildy inconsistent whitespace / style to the surrounding code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1492804 13f79535-47bb-0310-9956-ffa450edef68
2013-06-13 18:34:54 +00:00
Nick Burch
5863a82a6e Fix and update JavaDoc entries, and correct areas with wildy inconsistent whitespace / style to the surrounding code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1492802 13f79535-47bb-0310-9956-ffa450edef68
2013-06-13 18:29:08 +00:00
Nick Burch
8bb5601ff8 Fix the javadoc, correct the indenting, and add the new test file from bug #54849
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1492796 13f79535-47bb-0310-9956-ffa450edef68
2013-06-13 18:18:19 +00:00
Nick Burch
0ecaa1ae58 Patch from akhikhl from github pull #4 - Expose from XWPFParagraph the number level and format, if applied
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1492312 13f79535-47bb-0310-9956-ffa450edef68
2013-06-12 18:04:16 +00:00
Nick Burch
8185178ad3 Patch from akhikhl from github pull #3 - Extract references from XWPF footnotes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1492308 13f79535-47bb-0310-9956-ffa450edef68
2013-06-12 17:54:39 +00:00
Nick Burch
b80a40bc13 JavaDoc fixes from #54731 from Dominik Stadler
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1492267 13f79535-47bb-0310-9956-ffa450edef68
2013-06-12 16:32:24 +00:00
Yegor Kozlov
09c79ffed4 fixed compatibility issues with JDK 1.5
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1489685 13f79535-47bb-0310-9956-ffa450edef68
2013-06-05 02:03:07 +00:00
Yegor Kozlov
e3bbd87918 removed @Override to keep javac on JDK 1.5 happy
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1488823 13f79535-47bb-0310-9956-ffa450edef68
2013-06-03 01:05:28 +00:00
Yegor Kozlov
2135b0741c Bug 55047: REPT formula support
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1488811 13f79535-47bb-0310-9956-ffa450edef68
2013-06-02 23:39:41 +00:00
Yegor Kozlov
abd5fcd939 missing tests for Bug 55041 - CODE formula support
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1488810 13f79535-47bb-0310-9956-ffa450edef68
2013-06-02 23:32:24 +00:00
Yegor Kozlov
75e80b999e added missing tests for Bug 55042: patch for missing function COMPLEX
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1488809 13f79535-47bb-0310-9956-ffa450edef68
2013-06-02 23:25:33 +00:00
Yegor Kozlov
ecb8b8240c added missing tests for Bug 55042: patch for missing function COMPLEX
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1488808 13f79535-47bb-0310-9956-ffa450edef68
2013-06-02 23:25:07 +00:00
Yegor Kozlov
4d81d34d5d Bugzilla 55043 and 55042: initial support for Complex and Quotient functions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1488734 13f79535-47bb-0310-9956-ffa450edef68
2013-06-02 16:08:17 +00:00
Yegor Kozlov
0dfb528355 Bugzilla 55041: CODE function support, also removed @Override from interfaces to stay compatible with JDK 1.5
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1488733 13f79535-47bb-0310-9956-ffa450edef68
2013-06-02 15:58:41 +00:00
Yegor Kozlov
c119f35388 Bugzilla 55037: DELTA function support
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1488730 13f79535-47bb-0310-9956-ffa450edef68
2013-06-02 15:30:58 +00:00
Yegor Kozlov
e5cfade841 Bugzilla 55036 - Dec2HEx formula support
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1488729 13f79535-47bb-0310-9956-ffa450edef68
2013-06-02 15:13:47 +00:00
Nick Burch
c4f77a02e2 Unit test for bugs #54880 & #55030 - seems ok so far
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1488403 13f79535-47bb-0310-9956-ffa450edef68
2013-05-31 21:17:55 +00:00
Nick Burch
17cb45f1bf Fix bug #55001 - check for unicode text too (plus fix indents)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1488329 13f79535-47bb-0310-9956-ffa450edef68
2013-05-31 17:30:29 +00:00
Nick Burch
bf581e03b9 Stub out the unit tests needed for bug #55026, and add the sample file from that
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1487657 13f79535-47bb-0310-9956-ffa450edef68
2013-05-29 22:23:51 +00:00
Nick Burch
7c246cb5f0 More on bug #54682 - check for the end offset overflowing too
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1487558 13f79535-47bb-0310-9956-ffa450edef68
2013-05-29 17:31:50 +00:00
Nick Burch
c702bc5ce5 Fix bug #54682 - UnhandledDataStructure should sanity check before allocating, not after
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1487555 13f79535-47bb-0310-9956-ffa450edef68
2013-05-29 17:25:40 +00:00
Nick Burch
2f0107bb4e Where possible, allow fetching of the size of the OPC Package Part (-1 if not)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1482647 13f79535-47bb-0310-9956-ffa450edef68
2013-05-15 00:27:59 +00:00
Nick Burch
808c01e365 Fix #54891 - correct javadoc on HSSF + SS (XSSF was correct) for Row.createCell(int,int)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1479639 13f79535-47bb-0310-9956-ffa450edef68
2013-05-06 16:53:04 +00:00
Yegor Kozlov
76fac97865 Bug 54673 - [PATCH] Simple wildcard support in HLOOKUP, VOOLKUP, MATCH, COUNTIF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1457243 13f79535-47bb-0310-9956-ffa450edef68
2013-03-16 12:33:08 +00:00
Yegor Kozlov
651e622176 Bugzilla 54625 - Register user-defined functions in instance scope instead of static
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1452060 13f79535-47bb-0310-9956-ffa450edef68
2013-03-03 16:16:12 +00:00
Yegor Kozlov
decfde00ff Bugzilla 54469 - Support for financial functions IPMT and PPMT
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1451886 13f79535-47bb-0310-9956-ffa450edef68
2013-03-02 13:17:53 +00:00
Yegor Kozlov
e80c3aabc1 Bugzilla 54436: Fixed metadata for GETPIVOTDATA function
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1451875 13f79535-47bb-0310-9956-ffa450edef68
2013-03-02 11:38:09 +00:00
Nick Burch
522168dda4 Fix bug #54579 - Handle milliseconds in date formats eg ss.000
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1447798 13f79535-47bb-0310-9956-ffa450edef68
2013-02-19 16:28:40 +00:00
Nick Burch
9f23a59eaa Fix bug #54557 - Don't mis-detect format patterns like .000 as dates
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1445725 13f79535-47bb-0310-9956-ffa450edef68
2013-02-13 16:45:03 +00:00
Nick Burch
8d7d3f54c0 Fix bug #54506 - Add "BOOK" to the list of unusual-but-largely-ok Workbook directory entry names list, alongside WORKBOOK, plus tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1443745 13f79535-47bb-0310-9956-ffa450edef68
2013-02-07 21:53:07 +00:00
Nick Burch
887af17af3 Fix 1.6ism from original patch
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1442521 13f79535-47bb-0310-9956-ffa450edef68
2013-02-05 10:00:43 +00:00
Nick Burch
37c76d9b28 EDate function implementation from Detlef Brendle from bug #54508
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1442392 13f79535-47bb-0310-9956-ffa450edef68
2013-02-04 22:01:55 +00:00
Nick Burch
b68b2068d4 A bit more towards matching properties to chunks
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1442388 13f79535-47bb-0310-9956-ffa450edef68
2013-02-04 21:46:30 +00:00
Nick Burch
000620ac52 Improve the number of steps when generating an ID of a new relationship, and add more tests, bug #53904
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1442148 13f79535-47bb-0310-9956-ffa450edef68
2013-02-04 15:06:46 +00:00
Nick Burch
dd21676086 An XBAT may not be fully used, and remaining entries may be 0 not POIFSConstants.UNUSED_BLOCK, so avoid trying to process any that we know aren't used. Fixes bug #53810
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1442095 13f79535-47bb-0310-9956-ffa450edef68
2013-02-04 12:52:12 +00:00
Evgeniy Berlog
5801aa36b2 set isHidden flag 'true' for invisible comment and 'false' for visible comments
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1441829 13f79535-47bb-0310-9956-ffa450edef68
2013-02-02 23:10:34 +00:00
Nick Burch
1fe52e8cfc Continue with support for property lookups of chunks
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1441427 13f79535-47bb-0310-9956-ffa450edef68
2013-02-01 12:43:58 +00:00
Nick Burch
8edde11bbc Start on decoding fixed sized HSMF properties, and linking the variable sized ones with their matching chunks
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1441398 13f79535-47bb-0310-9956-ffa450edef68
2013-02-01 11:45:31 +00:00
Yegor Kozlov
90d7b88fa3 one more fix related to Bugzilla 54407
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1437306 13f79535-47bb-0310-9956-ffa450edef68
2013-01-23 09:14:14 +00:00
Yegor Kozlov
99476fc6b8 Bugzilla 54407 - Avoid XmlValueDisconnectedException when merging slides
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1436913 13f79535-47bb-0310-9956-ffa450edef68
2013-01-22 13:37:14 +00:00
Yegor Kozlov
0d3e7886ea keep javac on JDK 1.5 happy
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1436888 13f79535-47bb-0310-9956-ffa450edef68
2013-01-22 13:02:39 +00:00
Yegor Kozlov
c5e81c11e7 keep javac on JDK 1.5 happy
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1436819 13f79535-47bb-0310-9956-ffa450edef68
2013-01-22 09:35:39 +00:00
Yegor Kozlov
7cde4a3ea7 fix exception when calling importContent, see Bugzilla 54407
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1436608 13f79535-47bb-0310-9956-ffa450edef68
2013-01-21 20:46:32 +00:00
Yegor Kozlov
3680179e47 Bugzilla 54356 - Support of statistical function SLOPE
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1435633 13f79535-47bb-0310-9956-ffa450edef68
2013-01-19 18:33:34 +00:00
Nick Burch
4a133aef08 Remove old documentation, now in the site subtree
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1431977 13f79535-47bb-0310-9956-ffa450edef68
2013-01-11 10:33:38 +00:00
Nick Burch
b7c061f07a Patch from Johan from bug #54402 - fix IfError with indirect references
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1431403 13f79535-47bb-0310-9956-ffa450edef68
2013-01-10 15:08:22 +00:00
Yegor Kozlov
0023138765 Bugzilla 54356: Support of statistical function INTERCEPT
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1426485 13f79535-47bb-0310-9956-ffa450edef68
2012-12-28 12:50:15 +00:00
Nick Burch
876fea8596 Patch from Johan Karlsteen for bug #53966 - Implement IfError AP function
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1426382 13f79535-47bb-0310-9956-ffa450edef68
2012-12-28 03:34:18 +00:00
Nick Burch
21abfa9536 Make the exception a bit more explicit about what is wrong
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1424281 13f79535-47bb-0310-9956-ffa450edef68
2012-12-20 03:54:42 +00:00
Nick Burch
506578f1af Patch from Jan from bug #54282 - Improve the performance of ColumnHelper addCleanColIntoCols, speeds up some .xlsx file loading
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1420501 13f79535-47bb-0310-9956-ffa450edef68
2012-12-12 00:48:13 +00:00
Yegor Kozlov
a359040acc updated sha1 and md5 checksums on the downloads page
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1418446 13f79535-47bb-0310-9956-ffa450edef68
2012-12-07 19:14:31 +00:00
Yegor Kozlov
595c967cf0 Bug 53650 - Prevent unreadable content and disalow to overwrite rows in user templates
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1418264 13f79535-47bb-0310-9956-ffa450edef68
2012-12-07 10:36:16 +00:00
Yegor Kozlov
5b76ca72b6 Bugs 54228,53672 - Fixed XSSF to read cells with missing R attribute
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1417379 13f79535-47bb-0310-9956-ffa450edef68
2012-12-05 12:21:08 +00:00
Yegor Kozlov
7d6b730202 Bug 54206: ValueRecordsAggregate.updateFormulasAfterRowShift doesn't update shared formulas
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1416917 13f79535-47bb-0310-9956-ffa450edef68
2012-12-04 12:44:33 +00:00
Yegor Kozlov
e469414ef2 sync table headers with worksheet on save
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1416166 13f79535-47bb-0310-9956-ffa450edef68
2012-12-02 12:28:32 +00:00
Yegor Kozlov
7adad438bf Bug 54210 - Fixed rendering text in flipped shapes in PPT2PNG and PPTX2PNG
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1416165 13f79535-47bb-0310-9956-ffa450edef68
2012-12-02 12:24:55 +00:00
Yegor Kozlov
372be41bb9 updated version.id and release date of POI-3.9
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1413362 13f79535-47bb-0310-9956-ffa450edef68
2012-11-25 15:22:15 +00:00
Yegor Kozlov
baa610fa5e removed svn:executable from test files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1413341 13f79535-47bb-0310-9956-ffa450edef68
2012-11-25 12:19:05 +00:00
Yegor Kozlov
6f0b9cd5df fixed missing licence headers
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1413340 13f79535-47bb-0310-9956-ffa450edef68
2012-11-25 12:01:54 +00:00
Yegor Kozlov
362ded1f94 Bugzilla 54188 - Avoid NPE in PPT2PNG
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1413339 13f79535-47bb-0310-9956-ffa450edef68
2012-11-25 11:53:50 +00:00
Yegor Kozlov
c7c321b0f1 avoid warning: check if property node exists instead of throw/catch exception
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1410324 13f79535-47bb-0310-9956-ffa450edef68
2012-11-16 12:58:45 +00:00
Yegor Kozlov
133c0d7c0b Bug 52628 - Replace System.err info messages with a POILogger
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1410318 13f79535-47bb-0310-9956-ffa450edef68
2012-11-16 12:21:49 +00:00
Yegor Kozlov
87073d28da fixed javadoc warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1410315 13f79535-47bb-0310-9956-ffa450edef68
2012-11-16 12:00:02 +00:00
Yegor Kozlov
2365cae199 bugzilla 54137 - improved performance of DataFormatter with Fractions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1410269 13f79535-47bb-0310-9956-ffa450edef68
2012-11-16 09:46:28 +00:00
Yegor Kozlov
abc9ef9bb8 follow-up to 54099: include STMerge & CTVMerge in poi-ooxml-schemas jar
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1409676 13f79535-47bb-0310-9956-ffa450edef68
2012-11-15 07:46:39 +00:00