Commit Graph

8624 Commits

Author SHA1 Message Date
Dominik Stadler
2175d4dd7a Fix download-location of commons-logging4 jar and add it to FindBugs and bin-files target correctly
Add ant-jar to findbugs target as it is needed for excelant-code-check now
Fail on error when running Findbugs (still not on found warnings!)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754688 13f79535-47bb-0310-9956-ffa450edef68
2016-07-31 21:23:34 +00:00
Dominik Stadler
d01736974e Allow to specify -addmods for Java 9 support, update to JaCoCo 0.7.7 for initial Java 9 support and add target to create a combined JUnit report
Conflicts:
	build.xml

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754687 13f79535-47bb-0310-9956-ffa450edef68
2016-07-31 21:23:25 +00:00
Dominik Stadler
ced44cffa8 Exclude package sl.draw.binding from coverage-counting as this is generated code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754676 13f79535-47bb-0310-9956-ffa450edef68
2016-07-31 17:19:37 +00:00
Dominik Stadler
98401573ed Test a few more cases of function INDIRECT()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754675 13f79535-47bb-0310-9956-ffa450edef68
2016-07-31 17:19:33 +00:00
Dominik Stadler
bbfb783a57 Bug 59736: Incorrect evaluation of SUBTOTAL with composite interval
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754674 13f79535-47bb-0310-9956-ffa450edef68
2016-07-31 17:19:27 +00:00
Dominik Stadler
5e0612eabd IDE warnings and fix a few places where we do not close resources in tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754673 13f79535-47bb-0310-9956-ffa450edef68
2016-07-31 17:19:17 +00:00
Dominik Stadler
3ba5f7fd73 Adjust build:
* Use "skipexisting" in Get from Ant 1.8
* Do not always re-run ooxml-lite
* Findbugs does not require src- and javadocs-jars, so depend on "jar" instead of "assemble"

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754672 13f79535-47bb-0310-9956-ffa450edef68
2016-07-31 17:19:05 +00:00
Nick Burch
45772fed96 Sonar wants to know about the new commons collections dependency too!
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754620 13f79535-47bb-0310-9956-ffa450edef68
2016-07-30 12:39:16 +00:00
David North
7d5e62fd8c Move commons collections 4 dependency to main
https://bz.apache.org/bugzilla/show_bug.cgi?id=59734


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754602 13f79535-47bb-0310-9956-ffa450edef68
2016-07-30 08:54:50 +00:00
David North
299af644b8 As Nick suspected, the dependency is actually from HSSF too so commons collections 4 needs adding to the main POM
https://bz.apache.org/bugzilla/show_bug.cgi?id=59734


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754563 13f79535-47bb-0310-9956-ffa450edef68
2016-07-29 18:48:07 +00:00
Nick Burch
dfcf57bfbf Javadoc fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754530 13f79535-47bb-0310-9956-ffa450edef68
2016-07-29 14:03:28 +00:00
David North
e5877bd8e0 Introduce name-based methods for access to named ranges in a workbook, and deprecate the old index-based methods.
Re-organise internally to use a map so that lookup is O(1) rather than O(n ranges).

Add a dependency on commons collections 4, also ASL licensed so no problem.

https://bz.apache.org/bugzilla/show_bug.cgi?id=59734

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754521 13f79535-47bb-0310-9956-ffa450edef68
2016-07-29 13:24:00 +00:00
Dominik Stadler
fa24949520 Bug 55384: Handle setting pre-evaluation string correctly in SXSSF as well
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754328 13f79535-47bb-0310-9956-ffa450edef68
2016-07-27 18:15:54 +00:00
Nick Burch
2beb904e86 HWPFDocument.write(File) support and tests #57919
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754108 13f79535-47bb-0310-9956-ffa450edef68
2016-07-26 10:58:08 +00:00
Dominik Stadler
a86686846b Bug 59634: Clarify and refine JavaDoc of various close() methods to consistently state that close() invalidates the object
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753912 13f79535-47bb-0310-9956-ffa450edef68
2016-07-24 11:38:50 +00:00
Andreas Beeker
ab36704d3e Create branch to unify crypto handling in HSSF and support CryptoAPI for HSSF
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hssf_cryptoapi@1753906 13f79535-47bb-0310-9956-ffa450edef68
2016-07-24 11:07:06 +00:00
Nick Burch
5a1ff54cf3 In-place write for HSLF #57919
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753741 13f79535-47bb-0310-9956-ffa450edef68
2016-07-21 23:25:02 +00:00
Nick Burch
13a7be6cd2 Provide a createOrUpdateDocument method at the POIFS level, and use to simplify writing code #57919
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753739 13f79535-47bb-0310-9956-ffa450edef68
2016-07-21 23:09:07 +00:00
Nick Burch
50519d3c73 Javadoc updates
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753659 13f79535-47bb-0310-9956-ffa450edef68
2016-07-21 10:27:27 +00:00
Javen O'Neal
327a4aa091 test Cell.setCellValue(false)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753634 13f79535-47bb-0310-9956-ffa450edef68
2016-07-21 02:17:37 +00:00
Nick Burch
92a146e4b5 If doing an in-place write, update the properties too
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753623 13f79535-47bb-0310-9956-ffa450edef68
2016-07-20 23:31:57 +00:00
Nick Burch
af36e63bff #57919 HSLF writing to new File
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753622 13f79535-47bb-0310-9956-ffa450edef68
2016-07-20 23:20:02 +00:00
Nick Burch
d240667115 #57919 HPSF writing better error handling, and start prep for HSLF more write methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753621 13f79535-47bb-0310-9956-ffa450edef68
2016-07-20 23:09:33 +00:00
Nick Burch
b15c2b1c53 Whitespace / indents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753620 13f79535-47bb-0310-9956-ffa450edef68
2016-07-20 22:39:12 +00:00
Nick Burch
3fa0449747 #57919 Add in-place and new-File write methods to POIDocument
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753619 13f79535-47bb-0310-9956-ffa450edef68
2016-07-20 22:35:51 +00:00
Nick Burch
1ccced289d Mark some more scratchpad document types as currently being read-only
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753618 13f79535-47bb-0310-9956-ffa450edef68
2016-07-20 22:18:25 +00:00
Nick Burch
9830fd3dca Helper class for implementing extra write methods (#57919) for Scratchpad classes which are read-only
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753617 13f79535-47bb-0310-9956-ffa450edef68
2016-07-20 22:13:03 +00:00
Nick Burch
8e50c77100 Prepare for pushing write() and write(File) to POIDocument
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753595 13f79535-47bb-0310-9956-ffa450edef68
2016-07-20 18:41:27 +00:00
Nick Burch
4dee08213a Sync the file-based "past-the-end" exception to match the stream one, so that extending works, then tests for HSSF writing to a new empty POIFS file #57919
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753489 13f79535-47bb-0310-9956-ffa450edef68
2016-07-20 12:01:36 +00:00
Nick Burch
dfd3bbee21 Start on unit testing for HSSFWorkbook.write(File), bug in POIFS to fix first
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753487 13f79535-47bb-0310-9956-ffa450edef68
2016-07-20 11:14:05 +00:00
Nick Burch
d84df31b50 #57919 Start on support for writing to a new File (faster than OutputStream)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753486 13f79535-47bb-0310-9956-ffa450edef68
2016-07-20 11:07:29 +00:00
Javen O'Neal
93a53a1da3 add test case for bug 53564
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753359 13f79535-47bb-0310-9956-ffa450edef68
2016-07-19 10:08:50 +00:00
Javen O'Neal
40ade31cf5 svn propset svn:mime-type application/vnd.openxmlformats-officedocument.spreadsheetml.sheet *.xlsx
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753351 13f79535-47bb-0310-9956-ffa450edef68
2016-07-19 08:43:30 +00:00
Javen O'Neal
ce0cd7cc74 +svn:auto-props for common Microsoft Office files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753350 13f79535-47bb-0310-9956-ffa450edef68
2016-07-19 08:39:38 +00:00
Javen O'Neal
50d1788d3d bug 59881: fix D* functions for blank cells in headers in database; patch from Patrick Zimmermann
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753346 13f79535-47bb-0310-9956-ffa450edef68
2016-07-19 08:02:41 +00:00
Javen O'Neal
3834591a11 +svn:eol-style=native
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753299 13f79535-47bb-0310-9956-ffa450edef68
2016-07-18 18:26:18 +00:00
Javen O'Neal
ebbcd10034 bug 59881: fix spelling; patch from Patrick Zimmermann
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753298 13f79535-47bb-0310-9956-ffa450edef68
2016-07-18 18:25:28 +00:00
Dominik Stadler
abc3072df2 52122: Excel does not handle conditional formatting based on formula correctly unless recalculation is forced
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753199 13f79535-47bb-0310-9956-ffa450edef68
2016-07-18 10:32:55 +00:00
Dominik Stadler
35173d9e30 Some warnings/improvements suggested by IntelliJ
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753188 13f79535-47bb-0310-9956-ffa450edef68
2016-07-18 09:34:59 +00:00
Dominik Stadler
0bf845e0cc 59106: WorkdayFunction does not read the area with holidays correctly to calculate work days
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753125 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 21:18:27 +00:00
Dominik Stadler
29b21a82f7 Adjust unused local variables to also make FindBugs happy
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753124 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 21:18:19 +00:00
Dominik Stadler
da9cd94e76 Fix one more place where stream were left open when an exception is thrown
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753123 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 21:18:12 +00:00
Dominik Stadler
da595c2343 Fix some IntelliJ and Findbugs warnings: StringBuilder, foreach, append(), ...
test-updates

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753122 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 21:18:07 +00:00
Dominik Stadler
412ae950c2 Enable reproducer test for bug 56880 after it was fixed.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753121 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 21:17:51 +00:00
Dominik Stadler
a118ec77d4 Add commented reproducer for bug 57603
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753120 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 21:17:45 +00:00
Javen O'Neal
f7021f3788 only calculate getTextHeight if it will be used
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753115 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 20:33:32 +00:00
Javen O'Neal
056a8dac84 reduce statement complexity in drawContent, also has fewer FLOPS
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753114 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 20:29:34 +00:00
Javen O'Neal
ec4a47df73 if ever combined, VerticalAlignment and HorizontalAlignment would likely end up at org.apache.poi.common.usermodel
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753113 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 20:27:57 +00:00
Javen O'Neal
9ee14c5508 bug 57919: add performance note to javadocs about using BufferedOutputStreams on Document.write(OutputStream) if underlying resource is high latency
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753112 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 20:25:37 +00:00
Javen O'Neal
bdf3f30418 make instance variables final where possible
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753111 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 20:24:14 +00:00