Commit Graph

9137 Commits

Author SHA1 Message Date
Greg Woolsey
9d11d1c3ea add Locale awareness to case insensitive conditional comparisons in formatting rule logic. Needed anyway, and removes forbidden API issues.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815404 13f79535-47bb-0310-9956-ffa450edef68
2017-11-16 01:22:52 +00:00
Greg Woolsey
963a8fedae ignore a unit test that snuck in. It was created to investigate an open bug report. It fails, as expected, which broke the build.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815336 13f79535-47bb-0310-9956-ffa450edef68
2017-11-15 16:34:14 +00:00
Greg Woolsey
ff034f6a20 Fixes Bug 61764 Conditional formatting rules don't evaluate properly for some multi-range rule definitions
Fixes Bug 61761 Conditional formatting rule evaluation doesn't like comparing cells of different types

fixed, with unit tests.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815298 13f79535-47bb-0310-9956-ffa450edef68
2017-11-15 08:35:17 +00:00
Dominik Stadler
3e70d22cbc Fix setting a font-color if no previous color is defined for the font
Add unit-test to verify this

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815086 13f79535-47bb-0310-9956-ffa450edef68
2017-11-13 11:46:04 +00:00
Dominik Stadler
1b9d599882 Fix tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815085 13f79535-47bb-0310-9956-ffa450edef68
2017-11-13 11:44:50 +00:00
Javen O'Neal
f062e7f1c2 bug 61745: remove String#toString() usage found by forbidden apis check
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815048 13f79535-47bb-0310-9956-ffa450edef68
2017-11-13 00:51:41 +00:00
Javen O'Neal
a1b8f3ff14 bug 61745: add support for charts in XWPF/docx. Thanks to Sandeep Tiwari for the patch
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815047 13f79535-47bb-0310-9956-ffa450edef68
2017-11-12 21:48:41 +00:00
Javen O'Neal
bac484ba37 +svn:eol-style native *.java
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815002 13f79535-47bb-0310-9956-ffa450edef68
2017-11-12 06:52:38 +00:00
Javen O'Neal
fbccf3066c github #81: sheet names are case insensitive
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815001 13f79535-47bb-0310-9956-ffa450edef68
2017-11-12 06:14:43 +00:00
Javen O'Neal
1bc1bdb58b XWPFTable#getRows() should return an unmodifiable list unless the method can correctly update xmlbeans in response to modifying the list
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814999 13f79535-47bb-0310-9956-ffa450edef68
2017-11-12 01:34:52 +00:00
Javen O'Neal
fd29e87402 make tableRows final; initialize where defined rather than in constructor.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814998 13f79535-47bb-0310-9956-ffa450edef68
2017-11-12 01:32:43 +00:00
Javen O'Neal
c1e6c2eef7 deprecate XWPFTable#addNewRowBetween(int,int), which has not been implemented since 2008 when this class was first authored. (Unrelated: This closes #82 on github).
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814997 13f79535-47bb-0310-9956-ffa450edef68
2017-11-12 01:30:42 +00:00
Mark Murphy
70fdcdf848 Surface XSSF Header/Footer Attributes (60887)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814950 13f79535-47bb-0310-9956-ffa450edef68
2017-11-11 14:18:24 +00:00
Dominik Stadler
2d5b6457c6 Some JavaDoc adjustments, typos, IntelliJ warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814587 13f79535-47bb-0310-9956-ffa450edef68
2017-11-08 14:59:08 +00:00
Javen O'Neal
8b0145c6e0 bug 61730: remove asSet function from unit test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814462 13f79535-47bb-0310-9956-ffa450edef68
2017-11-07 07:26:48 +00:00
Javen O'Neal
163673a7aa bug 61730: remove CellRangeAddressBase which is eager. The lazy iterator is safer, less likely to cause an OOM/DoS.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814461 13f79535-47bb-0310-9956-ffa450edef68
2017-11-07 07:21:24 +00:00
Javen O'Neal
841cc75ee4 bug 61730: add javadoc
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814451 13f79535-47bb-0310-9956-ffa450edef68
2017-11-07 01:54:25 +00:00
Javen O'Neal
fb321255e8 bug 61730: add iterator interface to CellRangeAddressBase for iterating over CellAddresses
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814448 13f79535-47bb-0310-9956-ffa450edef68
2017-11-07 00:29:09 +00:00
Javen O'Neal
baec676cd0 bug 61727: make TestCellRangeUtil unit tests more explicit
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814444 13f79535-47bb-0310-9956-ffa450edef68
2017-11-06 22:19:06 +00:00
Dominik Stadler
7eb0187a5a Enhance unit-test to Verify that bug 58785 is already via via some other change
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814440 13f79535-47bb-0310-9956-ffa450edef68
2017-11-06 20:26:32 +00:00
Javen O'Neal
047dcc60ca bug 61727: CellRangeUtil Merge cell ranges broken. Thanks for Sven Rieckhoff for the patch
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814432 13f79535-47bb-0310-9956-ffa450edef68
2017-11-06 19:51:41 +00:00
Dominik Stadler
ba7c278a0e Adjust some tests to properly close resources
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814374 13f79535-47bb-0310-9956-ffa450edef68
2017-11-05 20:33:35 +00:00
Dominik Stadler
e54892912e Bug #57517: Fix various things in HSSFOptimiser to make many more cases work fine: Column styles, row styles, user defined styles, ...
Also call optimise in integration-tests and handle some cases of invalid content in files.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814373 13f79535-47bb-0310-9956-ffa450edef68
2017-11-05 20:33:28 +00:00
Dominik Stadler
4d13aefd6e Add test-case which shows that bug 55814 is fixed already by other changes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814290 13f79535-47bb-0310-9956-ffa450edef68
2017-11-04 13:45:12 +00:00
Dominik Stadler
48d6e6c9cf Fix some IntelliJ and JavaDoc warnings and avoid code-duplication and duplicated test-methods
Adjust tests slighlty, close resources

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814289 13f79535-47bb-0310-9956-ffa450edef68
2017-11-04 13:45:04 +00:00
Javen O'Neal
673e558b7a bug 61474, github #81: add ShiftMode#ColumnCopy for FormulaShifter
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814268 13f79535-47bb-0310-9956-ffa450edef68
2017-11-04 10:11:20 +00:00
Javen O'Neal
6234d725e6 bug 61474, github #81: add shiftMergedRegions to BaseRowColShifter interface
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814264 13f79535-47bb-0310-9956-ffa450edef68
2017-11-04 09:32:05 +00:00
Javen O'Neal
9375ae7873 bug 61474, github #81: bump visibility of abstract methods in BaseRowColShifter abstract class
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814262 13f79535-47bb-0310-9956-ffa450edef68
2017-11-04 09:17:09 +00:00
Javen O'Neal
6fcacf21f3 bug 61474, github #81: pull up methods from RowShifter to BaseRowColShifter, since both row and column shifting should be able to shift formulas, comments, merged regions, conditional formatting, etc; add @since decorators for new *ColumnShifter and *RowColShifter classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814261 13f79535-47bb-0310-9956-ffa450edef68
2017-11-04 09:07:32 +00:00
Javen O'Neal
ec8b13c3a8 bug 61474, github #81: remove @Internal RowShifter#updateRowFormulas, move to XSSFRowColShifter; implement ColumnShifter#updateFormulas; remove duplicated JavaDocs (better to inherit)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814260 13f79535-47bb-0310-9956-ffa450edef68
2017-11-04 08:54:20 +00:00
Javen O'Neal
4d526bfd01 bug 61474, github #81: implement updateConditionalFormatting for ColumnShifter
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814259 13f79535-47bb-0310-9956-ffa450edef68
2017-11-04 07:58:41 +00:00
Javen O'Neal
7c88f32408 bug 61474, github #81: implement updateNamedRanges for ColumnShifter
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814258 13f79535-47bb-0310-9956-ffa450edef68
2017-11-04 07:42:33 +00:00
Javen O'Neal
607ca594b1 bug 61474, github #81: fix ColumnShifter#removalNeeded to use columns instead of rows
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814257 13f79535-47bb-0310-9956-ffa450edef68
2017-11-04 07:29:53 +00:00
Javen O'Neal
4b92e7c67a bug 61474, github #81: add ColumnShifter interface; deduplicate some code in RowShifter, CFRecordsAggregate
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814256 13f79535-47bb-0310-9956-ffa450edef68
2017-11-04 07:17:44 +00:00
Javen O'Neal
b671199b40 bug 61474, #81 on github: add @Override annotation; rename FormulaShifter shifter to FormulaShifter formulaShifter to reduce confusion with the shifter variable referring to the RowShifter
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814255 13f79535-47bb-0310-9956-ffa450edef68
2017-11-04 05:48:18 +00:00
Javen O'Neal
0e540db89b bug 61474,github-81: add FormulaShifter.createForColumnShift and ShiftMode.ColumnMove
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814254 13f79535-47bb-0310-9956-ffa450edef68
2017-11-04 05:29:52 +00:00
Javen O'Neal
40ae87fd36 github-81: extract routines in HSSFRow#shiftRows
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814253 13f79535-47bb-0310-9956-ffa450edef68
2017-11-04 04:29:45 +00:00
Javen O'Neal
59594b6030 rename ambiguous variable name shifter -> formulaShifter
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814247 13f79535-47bb-0310-9956-ffa450edef68
2017-11-04 02:57:01 +00:00
Javen O'Neal
4b2f709551 whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814245 13f79535-47bb-0310-9956-ffa450edef68
2017-11-04 02:49:52 +00:00
Andreas Beeker
388c491135 #61671 - XSLFSlide does not contain isHidden and setHidden like HSLFSlide does
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814122 13f79535-47bb-0310-9956-ffa450edef68
2017-11-02 23:15:19 +00:00
Nick Burch
bae303a412 Javadoc fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813966 13f79535-47bb-0310-9956-ffa450edef68
2017-11-01 11:21:25 +00:00
Javen O'Neal
925a296cc3 eventually we want to forbid StringBuffer usage
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813875 13f79535-47bb-0310-9956-ffa450edef68
2017-10-31 11:10:08 +00:00
PJ Fanning
34006a542e use StringBuilder in more places
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813869 13f79535-47bb-0310-9956-ffa450edef68
2017-10-31 10:24:47 +00:00
Javen O'Neal
bf5a0c4c9e github-68: add @Override to o.a.p.ss.usermodel.charts.DataSources. Thanks to Alain-Bearez.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813868 13f79535-47bb-0310-9956-ffa450edef68
2017-10-31 10:17:38 +00:00
PJ Fanning
5402bcdd49 add test case for bug 61701
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813864 13f79535-47bb-0310-9956-ffa450edef68
2017-10-31 09:51:51 +00:00
PJ Fanning
e623808539 add test case for bug 61701 and use StringBuilder in more places
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813863 13f79535-47bb-0310-9956-ffa450edef68
2017-10-31 09:48:23 +00:00
Javen O'Neal
722ab2d4f1 github-77: Remove the 'public' modifier to make fields package protected (findbugs-MS_PKGPROTECT). Thanks to BruceKuiLiu for the PR. This closes #77 on github.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813859 13f79535-47bb-0310-9956-ffa450edef68
2017-10-31 09:38:03 +00:00
Javen O'Neal
729c86e82c consolidate duplicated code: XSSFWorkbook#setBookViewsIfMissing()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813841 13f79535-47bb-0310-9956-ffa450edef68
2017-10-31 01:45:03 +00:00
Javen O'Neal
d4a0dbc792 bump the Eclipse compile source to Java 1.8
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813840 13f79535-47bb-0310-9956-ffa450edef68
2017-10-31 01:08:43 +00:00
Javen O'Neal
1cea1c52fd bug 61630: Patch from Daniel to fix XSSFExportToXML IllegalArgumentException: Comparison method violates its general contract! (bug 61630, comment 17, attachment 35468). Found during manual testing.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813443 13f79535-47bb-0310-9956-ffa450edef68
2017-10-26 18:10:09 +00:00