Commit Graph

7796 Commits

Author SHA1 Message Date
Andreas Beeker
81d891921b findbugs fixes
changed UDFFinder to abstract class and moved DEFAULT constant to factory method

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747942 13f79535-47bb-0310-9956-ffa450edef68
2016-06-12 00:12:22 +00:00
Andreas Beeker
603bda4915 use newer findbugs version, if we run with java 7+
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747936 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 21:23:01 +00:00
Dominik Stadler
b9ceae5ef3 Add some pre-checks to fail the test with better assertion if the locale is not set correctly.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747916 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 17:03:59 +00:00
Dominik Stadler
b758810081 Downgrade version of download-plugin as the newer one is not found by Maven
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747915 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 17:03:53 +00:00
Dominik Stadler
81defe041c Set the correct locale for tests in the Sonar-Maven files to not fail on CI machines that have a different locale set
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747914 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 17:03:46 +00:00
Javen O'Neal
61f0e58abb make CellRangeAddresses easier to cross-reference the example with the written out workbook
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747888 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 12:18:04 +00:00
Javen O'Neal
16fb41d5f1 make these classes more discoverable/searchable using more specific names
rename PropertyTemplate to BorderPropertyTemplate
  rename Extent to BorderExtent

git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747884 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 12:09:23 +00:00
Javen O'Neal
9e54ef68cb bug 57840: lazily compute hashCode; patch from Greg Woolsey
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747881 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 11:40:30 +00:00
Javen O'Neal
55546a5495 whitespace (tabs to spaces, 3-space to 4-space)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747879 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 11:35:18 +00:00
Javen O'Neal
be9b615048 bug 57840: add disabled unit test with large number of structured reference formulas
patch and spreadsheet contributed by Mark Woolsey

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747878 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 11:28:55 +00:00
Javen O'Neal
cea8cc65a3 javadoc update and boolean addLeft|Right|Top|Bottom line wrap update
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747877 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 11:12:04 +00:00
Javen O'Neal
66498c10af fix spelling in javadoc
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747876 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 11:01:48 +00:00
Javen O'Neal
7c90716fdc fix javadocs: remove unnecessary @links, remove references to CellStyle
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747873 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 10:09:05 +00:00
Javen O'Neal
ad11547c8a move loop-invariants outside the loop for readability and execution speed
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747871 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 09:58:12 +00:00
Javen O'Neal
bd22a7be43 replace usage of all deprecated CellStyle.BORDER_* constants with BorderStyle.*
update PropertyTemplate functions to require enum instead of short borderType

git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747868 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 09:15:57 +00:00
Dominik Stadler
9880040b1b Improve output on invalid HTTP Status Code and ignore another failure to contact the TSP server
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747863 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 08:45:41 +00:00
Dominik Stadler
0c74fe60a3 Remove invalid removal of findbugs-zip
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747862 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 08:45:33 +00:00
Dominik Stadler
7efdb9330e Update to latest versions of Maven plugins for Sonar-build and use properties for some third party libs and some Maven plugins
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747861 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 08:45:28 +00:00
Javen O'Neal
7dc4706edf continue simplifying using helper functions
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747859 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 08:15:50 +00:00
Javen O'Neal
66875dbc1b continue simplifying using helper functions
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747858 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 08:08:04 +00:00
Javen O'Neal
8ad237f679 add helper functions for verifying template properties were set correctly
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747855 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 07:48:32 +00:00
Javen O'Neal
222e32d577 whitespace (unwrap lines)
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747854 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 07:40:46 +00:00
Javen O'Neal
50d0a1197f shorten PropertyTemplate.Extent to Extent
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747853 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 07:10:21 +00:00
Javen O'Neal
fc6b8cdd0e +props svn:eol-style=native
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747852 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 07:00:40 +00:00
Javen O'Neal
54213ab158 bug 58787: add PropertyTemplate, unit test, and example from Mark Murphy
Attachment 33684 plus changes to TestPropertyTemplate#applyBorders: replaced assertEquals(CellStyle.BORDER_*, cs.getBorder*()) with assertEquals(BorderStyle.*, cs.getBorder*())

git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747851 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 06:47:25 +00:00
Javen O'Neal
37e7a8a9f0 create branch for bug 58787 Border utility to set cell styles around a range of cells
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747847 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 05:39:42 +00:00
Javen O'Neal
249bdf8661 +props svn:eol-style native
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747846 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 04:27:21 +00:00
Javen O'Neal
8673812492 methods that return lists should return unmodifiable lists; use foreach sheet iterator when sheet index is not needed
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747843 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 03:05:31 +00:00
Javen O'Neal
ed3364b6d2 bug 57840: re-use XSSFEvaluationWorkbook when expanding a shared formula; patch from Greg Woolsey
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747840 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 02:28:21 +00:00
Javen O'Neal
69ded5b7b0 whitespace (tabs to spaces); +props svn:eol-style=native
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747839 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 02:12:43 +00:00
Javen O'Neal
e3beb3abdd bug 57840: cache XSSFEvaluationCell and XSSFEvaluationSheet instances (30% evaluation speedup due to caching and faster cell lookup); patch from Greg Woolsey
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747838 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 02:10:32 +00:00
Javen O'Neal
6d03eafcfe bug 57840: avoid auto-boxing ints for row/column TreeTable lookups (4% evaluation speedup at the cost of additional Integer objects); patch from Greg Woolsey
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747837 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 01:48:37 +00:00
Javen O'Neal
9ca89c2278 add warnings that AnalysisToolPak inconsistently handles case-sensitivity of function names
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747835 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 01:41:54 +00:00
Javen O'Neal
649f2df1e9 add crude unit tests for UDFFinder classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747834 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 01:38:27 +00:00
Javen O'Neal
44c9a66906 remove deprecated o.a.p.xssf.model.IndexedUDFFinder, which was moved to o.a.p.ss.formula.udf 3 years ago and was @Internal before that
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747828 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 00:51:12 +00:00
Javen O'Neal
3c910410d1 +props svn:eol-style=native
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747826 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 00:45:12 +00:00
Javen O'Neal
6ed13b4b5b add @Override annotations
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747825 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 00:42:57 +00:00
Javen O'Neal
3ff5a7669f fix typo
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747824 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 00:42:33 +00:00
Javen O'Neal
cd4058fd60 bug 57840: initialize the column header cache with 50% empty space
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747823 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 00:38:42 +00:00
Javen O'Neal
52e866f4bc whitespace (tabs to spaces)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747822 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 00:34:22 +00:00
Javen O'Neal
9aaa2bd51e whitespace (tabs to spaces)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747821 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 00:16:14 +00:00
Javen O'Neal
82134e3d8a whitespace (tabs to spaces)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747820 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 00:15:00 +00:00
Javen O'Neal
1a906b4d68 bug 57840: add test using a Data Table not anchored at A1
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747819 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 00:11:41 +00:00
Javen O'Neal
b895003260 bug 57840: add data table not anchored at A1 for testing XSSFTable.getStartColIndex()/getEndColIndex()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747817 13f79535-47bb-0310-9956-ffa450edef68
2016-06-10 23:55:27 +00:00
Andreas Beeker
12c7c32187 fix text height test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747803 13f79535-47bb-0310-9956-ffa450edef68
2016-06-10 21:29:47 +00:00
Javen O'Neal
c8627bb8b2 bug 57840: add unit tests for XSSFTable methods; rename XSSFTable.getNumerOfMappedColumns() to getNumberOfMappedColumn()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747771 13f79535-47bb-0310-9956-ffa450edef68
2016-06-10 18:45:14 +00:00
Javen O'Neal
71e3aa52fd bug 57840: add unit test for XSSFTable.findColumnIndex
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747762 13f79535-47bb-0310-9956-ffa450edef68
2016-06-10 18:10:52 +00:00
Javen O'Neal
a6f21296cc bug 57840: fix to reuse XSSFEvaluationWorkbook inside itself; patch from Greg Woolsey
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747754 13f79535-47bb-0310-9956-ffa450edef68
2016-06-10 17:13:45 +00:00
Javen O'Neal
97adda6169 +props svn:eol-style native
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747752 13f79535-47bb-0310-9956-ffa450edef68
2016-06-10 17:12:28 +00:00
Javen O'Neal
ce5eccd8f5 bug 57721: add unit test for evaluating all formulas in a workbook containing structured reference formulas; patch from gruber.chri@gmx.at
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747740 13f79535-47bb-0310-9956-ffa450edef68
2016-06-10 16:36:59 +00:00