Commit Graph

1079 Commits

Author SHA1 Message Date
Javen O'Neal
4d4b54b7c8 bug 59342: add sheet tab color getter and setter
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739547 13f79535-47bb-0310-9956-ffa450edef68
2016-04-17 07:38:15 +00:00
Javen O'Neal
48bba39dcf move unit test for XSSFSheet.setTabColor from TestXSSFWorkbook to TestXSSFSheet
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739538 13f79535-47bb-0310-9956-ffa450edef68
2016-04-17 03:35:58 +00:00
Javen O'Neal
4e33c06871 bug 59336: patch from Mark Murphy: deprecate functions in CellUtil that require an unnecessary Workbook argument.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739536 13f79535-47bb-0310-9956-ffa450edef68
2016-04-17 01:29:19 +00:00
Dominik Stadler
78a05ca7a0 Fix compiler warnings and ensure CTChartSheets stays included and is not refactored out by automated import reorganization
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738752 13f79535-47bb-0310-9956-ffa450edef68
2016-04-12 10:09:44 +00:00
Javen O'Neal
921c9b9e4b junit4 assert* improvements, add CTChartsheet to unit test so that it's compiled into poi-ooxml-schemas.jar (if it isn't already)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738742 13f79535-47bb-0310-9956-ffa450edef68
2016-04-12 09:22:48 +00:00
Javen O'Neal
db25900315 convert to junit4
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738738 13f79535-47bb-0310-9956-ffa450edef68
2016-04-12 08:51:45 +00:00
Tim Allison
a060c664a1 close fileinputstream on second exception in ZipPackage
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738251 13f79535-47bb-0310-9956-ffa450edef68
2016-04-08 14:36:05 +00:00
Dominik Stadler
b9e7c32ffe Bug 58648: Fix handling whitespaces in formulas, unfortunately blank can be the intersection operator as well, so we need to try and skip it as whitespace if intersection fails which can lead to hard to track bugs or misleading error messages with some formulas
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738033 13f79535-47bb-0310-9956-ffa450edef68
2016-04-06 19:50:08 +00:00
Dominik Stadler
ec6bb2a066 Slightly improve error message
Fix some IntelliJ/compiler warnings
Use common interfaces where possible
Cleanup after testing POIFSDump

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738032 13f79535-47bb-0310-9956-ffa450edef68
2016-04-06 19:49:59 +00:00
Dominik Stadler
62ee0abc13 Code cleanup via IntelliJ: Remove unnecessary semicolon
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738031 13f79535-47bb-0310-9956-ffa450edef68
2016-04-06 19:49:47 +00:00
Javen O'Neal
f9c74888e3 add test coverage for WorkbookFactory.create(File file, String password, Boolean readOnly) when file does not exists
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737917 13f79535-47bb-0310-9956-ffa450edef68
2016-04-06 05:15:15 +00:00
Javen O'Neal
1786767b89 bug 59264: use BorderStyle for changing Cell border line style
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737879 13f79535-47bb-0310-9956-ffa450edef68
2016-04-05 20:28:46 +00:00
Dominik Stadler
205055b83c Prevent us from changing the file with every test-run
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737488 13f79535-47bb-0310-9956-ffa450edef68
2016-04-02 11:01:49 +00:00
Dominik Stadler
328c52aab7 Fix some cases where file handles are not closed in OldExcelExtractor
Close resources in some more tests to make the file-leak report clean again

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737487 13f79535-47bb-0310-9956-ffa450edef68
2016-04-02 11:01:43 +00:00
Dominik Stadler
1985e23f59 Regression: Add unit-test which triggers more code deep inside XSLF to have some missing pieces included in the reduced ooxml-schema-jar
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737466 13f79535-47bb-0310-9956-ffa450edef68
2016-04-02 06:38:39 +00:00
Dominik Stadler
d0513f2ca6 Apply patch from bug 58909 - Add a cloneSheet() which directly sets the sheetname to allow to avoid a costly renaming of sheets.
Combine related unit-tests into Base-Test-Classes to run them for all types of Workbook/Sheet/...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737237 13f79535-47bb-0310-9956-ffa450edef68
2016-03-31 13:32:05 +00:00
Dominik Stadler
992adb9c16 Revert set of inadvertedly committed files/changes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737029 13f79535-47bb-0310-9956-ffa450edef68
2016-03-29 18:11:44 +00:00
Dominik Stadler
f5332a3a40 Bug 58915: Add note about memory consumption and update changelog
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737025 13f79535-47bb-0310-9956-ffa450edef68
2016-03-29 17:30:55 +00:00
Dominik Stadler
00e6abb6bc Try to reproduce bug 58922, convert to JUnit 4
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737018 13f79535-47bb-0310-9956-ffa450edef68
2016-03-29 16:11:29 +00:00
Dominik Stadler
0888ad4de5 Fix some compiler warnings, improve error message, cover some more code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737013 13f79535-47bb-0310-9956-ffa450edef68
2016-03-29 15:45:04 +00:00
Dominik Stadler
02b29ea698 Bug 59132: Adjust implementation of COUNTBLANK to be conforming to Excel, empty strings are counted as blank as well
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737009 13f79535-47bb-0310-9956-ffa450edef68
2016-03-29 14:53:44 +00:00
Andreas Beeker
4eeffd0532 XSLF: do not display Master Slide objects by default
XSLF: fix alternate content handling for picture shapes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736935 13f79535-47bb-0310-9956-ffa450edef68
2016-03-28 22:52:01 +00:00
Andreas Beeker
f8767e3981 some zips can't be opened via ZipFile in JDK6, as the central directory
contains either non-latin entries or the compression type can't be handled
the workaround is to iterate over the stream and not the directory


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736933 13f79535-47bb-0310-9956-ffa450edef68
2016-03-28 22:49:45 +00:00
Dominik Stadler
0115c12e2d Fix some compiler warnings, javadoc, ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736924 13f79535-47bb-0310-9956-ffa450edef68
2016-03-28 20:22:08 +00:00
Dominik Stadler
8afb394974 Bug 59199: Handle null date-values in a similar way as null-Strings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736923 13f79535-47bb-0310-9956-ffa450edef68
2016-03-28 20:20:29 +00:00
Javen O'Neal
6b6b6a668e add more commented-out tests for bug 58779: closing an XML Workbook that was not opened as read-only will modify the file on disk
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736742 13f79535-47bb-0310-9956-ffa450edef68
2016-03-27 13:04:37 +00:00
Javen O'Neal
f0e824587b bug 59224: change hasTint, add hasAlpha and unit tests. Patch from gubespam@gmail.com
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736469 13f79535-47bb-0310-9956-ffa450edef68
2016-03-24 17:29:00 +00:00
Javen O'Neal
e2615ce68e bug 59212: Do not check for overlapping regions when adding merged regions to a sheet
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736155 13f79535-47bb-0310-9956-ffa450edef68
2016-03-22 09:02:08 +00:00
Dominik Stadler
d806c2ac2b Check for null in IOUtils.closeQuietly() to not log this unnecessarily
Add coverage for some  more methods in ExtractorFactory
Fix some IntelliJ warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736146 13f79535-47bb-0310-9956-ffa450edef68
2016-03-22 07:51:39 +00:00
Javen O'Neal
a61e242e86 bug 59208: correctly understand val="1" for isBold, isItalic, etc
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736126 13f79535-47bb-0310-9956-ffa450edef68
2016-03-22 04:20:45 +00:00
Andreas Beeker
e9f333827d fix eclipse warnings
close resources

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735912 13f79535-47bb-0310-9956-ffa450edef68
2016-03-21 00:14:21 +00:00
Andreas Beeker
b09c85ff04 eclipse warning fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735706 13f79535-47bb-0310-9956-ffa450edef68
2016-03-18 23:12:28 +00:00
Tim Allison
81e49eff0f 59183 - handle timezones (even with colons) in date parsing metadata in ooxml opc
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735270 13f79535-47bb-0310-9956-ffa450edef68
2016-03-16 17:52:42 +00:00
Nick Burch
197458b30c One final invalid file type check
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735071 13f79535-47bb-0310-9956-ffa450edef68
2016-03-15 12:37:01 +00:00
Nick Burch
7112835d90 Before opening an OOXML file, check the first few bytes, and give helpful exceptions for common mistakes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735069 13f79535-47bb-0310-9956-ffa450edef68
2016-03-15 12:30:45 +00:00
Nick Burch
4d7955d6b5 Start to give more helpful Exceptions from OPCPackage when non-OOXML files are passed to it
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735060 13f79535-47bb-0310-9956-ffa450edef68
2016-03-15 11:50:57 +00:00
Andreas Beeker
3f4f58829d HSLF: Add support for system colors
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734865 13f79535-47bb-0310-9956-ffa450edef68
2016-03-14 00:42:59 +00:00
Dominik Stadler
3c1052e375 Bug 55791: Avoid using an existing file-name when creating a new slide, it could still be left over from previous partial removal
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734862 13f79535-47bb-0310-9956-ffa450edef68
2016-03-13 21:30:27 +00:00
Andreas Beeker
8e36872c48 #59170 - Remove deprecated classes (POI 3.15) - *Workbook.setRepeatingRowsAndColumns()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734701 13f79535-47bb-0310-9956-ffa450edef68
2016-03-12 13:33:53 +00:00
Dominik Stadler
2b28cd97a3 Apply patch to fix bug 57495: getTableArray method can not get 0 pos table
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734694 13f79535-47bb-0310-9956-ffa450edef68
2016-03-12 11:45:34 +00:00
Dominik Stadler
06083f85f4 Refactor some common code from the various Document-Factories into a helper class
Fix a potential file-handle-leak for password protected workbooks or slideshows

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734691 13f79535-47bb-0310-9956-ffa450edef68
2016-03-12 11:37:32 +00:00
Dominik Stadler
6d97ae7083 Fix some cases where POI itself or the tests leaked file-handles
Also fix some IntelliJ warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734690 13f79535-47bb-0310-9956-ffa450edef68
2016-03-12 11:37:22 +00:00
Dominik Stadler
128a991f9c Findbugs fixes
OldExcelExtractor could leak file handles in case of exceptions
Free file handles in POIFSDump, add unit-test for POIFSDump
Add a Findbugs exclude and adjust findbugs-ant slightly

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734689 13f79535-47bb-0310-9956-ffa450edef68
2016-03-12 11:37:12 +00:00
Dominik Stadler
b989e4f5a8 Enable some tests that are ignored, actually run green and did not have any comment why they were ignored in the first place
Fix some compiler warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734687 13f79535-47bb-0310-9956-ffa450edef68
2016-03-12 11:36:50 +00:00
Dominik Stadler
8c508d89b0 Add test for bug 59098 which shows that this is fixed in 3.14.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734686 13f79535-47bb-0310-9956-ffa450edef68
2016-03-12 11:36:43 +00:00
Andreas Beeker
9f47700711 #59058 - OOM when parsing docx after OPCPackage.open with File but not with InputStream (TIKA-1866)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734184 13f79535-47bb-0310-9956-ffa450edef68
2016-03-09 01:25:02 +00:00
Andreas Beeker
3a328aa220 #57031 - Out of Memory when extracting text from attached files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734182 13f79535-47bb-0310-9956-ffa450edef68
2016-03-09 00:41:02 +00:00
Dominik Stadler
da1879c1b2 Bug 57914: Provide a better error message for OOXML strict format which we do not support yet.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732619 13f79535-47bb-0310-9956-ffa450edef68
2016-02-27 10:23:46 +00:00
Nick Burch
62b5b0d874 #59074 More helpful exception if Excel 1-95 files are given to ExtractorFactory
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732587 13f79535-47bb-0310-9956-ffa450edef68
2016-02-26 23:56:31 +00:00
Nick Burch
0b8283b37c Refactor to pull out the list of Excel 97+ directory entry names to a common place, avoiding duplication. Also starts on unit testing #59074
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732579 13f79535-47bb-0310-9956-ffa450edef68
2016-02-26 23:32:17 +00:00