Commit Graph

6772 Commits

Author SHA1 Message Date
Dominik Stadler
a0248ff4f0 Bug 57007: Add initial implementations of DMIN and DGET functions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648166 13f79535-47bb-0310-9956-ffa450edef68
2014-12-28 10:47:41 +00:00
Dominik Stadler
5c76ccba5b Add missing close() of resources in both production code and tests
Use revert() instead of close() on OCPPackage in some places to not re-write the file unnecessarily.
This should now run tests without leftover file handles when checked with file leak detector and
allows to find newly introduced cases more easily.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648160 13f79535-47bb-0310-9956-ffa450edef68
2014-12-28 09:16:57 +00:00
Dominik Stadler
7c9d23d887 Remove unused local variable
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648159 13f79535-47bb-0310-9956-ffa450edef68
2014-12-28 09:09:11 +00:00
Dominik Stadler
26585f4e95 Ensure that XSSFWorkbooks contain a BookView, some corrupt ones do not contain this, e.g. ones created by movescound.com
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648158 13f79535-47bb-0310-9956-ffa450edef68
2014-12-28 09:08:58 +00:00
Dominik Stadler
1cf8152d14 Start adding some coverage of more Scratchpad-classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648157 13f79535-47bb-0310-9956-ffa450edef68
2014-12-28 09:08:22 +00:00
Dominik Stadler
5173eca9ea Fix Eclipse warnings, unnecessary casts, use generics, static access...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648156 13f79535-47bb-0310-9956-ffa450edef68
2014-12-28 09:06:12 +00:00
Dominik Stadler
54fd49b39f Exclude javadoc-jars in findbugs run
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648155 13f79535-47bb-0310-9956-ffa450edef68
2014-12-28 08:59:34 +00:00
Andreas Beeker
4bed984c0f Charset.forName() for known encodings makes catching UnknownEncodingException obsolete
Unify UTF-16LE conversion to StringUtil
BugFix for RecordInputStream.readFully in combination with continuing records
BugFix for integration tests - fix pathname for handler/exclude lookup on windows

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648032 13f79535-47bb-0310-9956-ffa450edef68
2014-12-27 01:33:28 +00:00
Dominik Stadler
ae8391b926 One more change in file-pattern to actually exclude .svn files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647941 13f79535-47bb-0310-9956-ffa450edef68
2014-12-26 07:51:46 +00:00
Dominik Stadler
65ca8293d5 Exclude .svn sub-dirs as it seems Apache Jenkins still runs with Subversion <=1.6
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647939 13f79535-47bb-0310-9956-ffa450edef68
2014-12-26 07:04:34 +00:00
Dominik Stadler
b1e4a93f4d Add jars from compile-lib to findbugs target
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647938 13f79535-47bb-0310-9956-ffa450edef68
2014-12-26 07:04:10 +00:00
Andreas Beeker
47fe5b9651 Unified access to escher opt record
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647927 13f79535-47bb-0310-9956-ffa450edef68
2014-12-26 00:11:23 +00:00
Dominik Stadler
0c580c8f45 Add a test-suite which performs integration/stress tests which load and handle all stored test files in various ways.
It works by using handlers for each type of file which perform various operations on the files, e.g. loading,
iterating content, modify, ... This will trigger changes which break working with the available test-files and
thus provides another layer of regression testing which hopefully prevents some failures from making it into
releases.

It is runnable via a new ant-target 'test-integration' and also added to the jenkins-target.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647885 13f79535-47bb-0310-9956-ffa450edef68
2014-12-25 09:16:44 +00:00
Nick Burch
5ce675f345 Fix inconsistent whitespace/indents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647884 13f79535-47bb-0310-9956-ffa450edef68
2014-12-25 09:13:40 +00:00
Dominik Stadler
c7044b77aa Add javadoc to CellRange.getReferenceText()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647883 13f79535-47bb-0310-9956-ffa450edef68
2014-12-25 08:59:16 +00:00
Andreas Beeker
202aa8177f - Support for Office Binary Document RC4 CryptoAPI Encryption for HSLF
- Support for Office Binary Document RC4 Encryption
- use LittleEndian class in LittleEndianInputStream
- add normalize method for HSLF, to remove edit history, which is also necessary for encryption support
- update PersistDirectoryEntry handling in PersistPtrHolder to recognize groups while serializing
- deprecated PersistPtrHolder.getSlideOffsetDataLocationsLookup() - throws now UnsupportedOperationException,
  as this wasn't used outside the scope of the class and was quite internal logic of PersistPtrHolder


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647867 13f79535-47bb-0310-9956-ffa450edef68
2014-12-25 01:56:29 +00:00
Dominik Stadler
ed60f5cb08 Add comment
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647512 13f79535-47bb-0310-9956-ffa450edef68
2014-12-23 09:26:22 +00:00
Dominik Stadler
95c9b9991a Fix testcases which were not executed before, use tempfile, cleanup, ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647511 13f79535-47bb-0310-9956-ffa450edef68
2014-12-23 09:26:14 +00:00
Dominik Stadler
7ee9ce8388 Fix two Eclipse warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647325 13f79535-47bb-0310-9956-ffa450edef68
2014-12-22 14:56:47 +00:00
Dominik Stadler
83f5683c50 Bug 57373: Fix get/setFirstVisibleTab() for XSSFWorkbook
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647322 13f79535-47bb-0310-9956-ffa450edef68
2014-12-22 14:37:37 +00:00
Dominik Stadler
1db7f3bd3b Bug 57362: Properly initialize chart axis when loading a workbook which already contains a chart.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647317 13f79535-47bb-0310-9956-ffa450edef68
2014-12-22 14:16:23 +00:00
Dominik Stadler
f622530806 Remove iterating over the number of runs for certain XSSFRichTextString operations. If I didn't overlook something, they can directly access the array element anyway. Seems this was some leftover copy/paste stuff.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647315 13f79535-47bb-0310-9956-ffa450edef68
2014-12-22 14:09:55 +00:00
Dominik Stadler
76b750b420 Bug 56511: Add missing sample-file
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647309 13f79535-47bb-0310-9956-ffa450edef68
2014-12-22 13:07:48 +00:00
Dominik Stadler
03f846c695 Bug 56511: Add a null-check to ensure that the run actually has a font to not cause a NullPointerException but rather return null as documented
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647308 13f79535-47bb-0310-9956-ffa450edef68
2014-12-22 13:06:58 +00:00
Dominik Stadler
645d2083bf Bug 56550: Defer the initialization of the _classes to when it is actually needed to allow IBM JDK to at least load the class
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647302 13f79535-47bb-0310-9956-ffa450edef68
2014-12-22 12:38:44 +00:00
Dominik Stadler
a7ba500280 Bug 56595: Also switch the cache in DateUtil.isADateFormat() to ThreadLocals to not have another syncpoint here. Again only very little data is kept, so no memory bloat should happen because of this.
Also do more simple checks before actually looking at the cache

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647296 13f79535-47bb-0310-9956-ffa450edef68
2014-12-22 12:08:59 +00:00
Dominik Stadler
43ee4e08ca Add missing license header to newly added file
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647294 13f79535-47bb-0310-9956-ffa450edef68
2014-12-22 11:49:43 +00:00
Dominik Stadler
0b6867d1d5 Bug 56644: Fix adding cells if MissingCellPolicy is set to NULL_FOR_BLANK and the last column in a row is empty
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647291 13f79535-47bb-0310-9956-ffa450edef68
2014-12-22 11:11:34 +00:00
Dominik Stadler
181de5f6e5 Bug 56888: XSSFDataValidation ignores "allow blank" read from sheet, assumes true
Add TestSXSSFDataValidation to verify some parts for SXSSF as well

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647276 13f79535-47bb-0310-9956-ffa450edef68
2014-12-22 10:03:32 +00:00
Dominik Stadler
a98c9daa01 Some Eclipse warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647269 13f79535-47bb-0310-9956-ffa450edef68
2014-12-22 09:16:16 +00:00
Dominik Stadler
2d07fa94af Add reproducer for Bug 57165, no fix yet, though...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647265 13f79535-47bb-0310-9956-ffa450edef68
2014-12-22 09:10:01 +00:00
Dominik Stadler
0fdfac62c9 Bug 57171 and 57163: Adjust the active sheet in setSheetOrder() and removeSheet() for both HSSF and XSSF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647264 13f79535-47bb-0310-9956-ffa450edef68
2014-12-22 09:00:18 +00:00
Dominik Stadler
76af8804d5 Bug 57231: Add missing ArrayRecord.clone()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647255 13f79535-47bb-0310-9956-ffa450edef68
2014-12-22 08:17:56 +00:00
Dominik Stadler
12353bca7f Bug 57236: Add reproducer, although I am not sure if we should and how to fix this...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647254 13f79535-47bb-0310-9956-ffa450edef68
2014-12-22 07:57:03 +00:00
Nick Burch
c975b754d1 Expose the version information from OldExcelExtractor
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647244 13f79535-47bb-0310-9956-ffa450edef68
2014-12-22 05:59:51 +00:00
Nick Burch
90998b0410 Typo fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647231 13f79535-47bb-0310-9956-ffa450edef68
2014-12-22 00:51:21 +00:00
Dominik Stadler
69ed305eff Eclipse warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647213 13f79535-47bb-0310-9956-ffa450edef68
2014-12-21 21:07:55 +00:00
Dominik Stadler
8e89cbca3a Add a test for spreadsheet/49219.xls which previously failed with NullPointerException because we did not handle serializing ExternalNameRecords without actual data
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647212 13f79535-47bb-0310-9956-ffa450edef68
2014-12-21 21:07:25 +00:00
Dominik Stadler
213aa1559b Adjust typos in Javadoc
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647210 13f79535-47bb-0310-9956-ffa450edef68
2014-12-21 21:07:06 +00:00
Nick Burch
3a72ec0aec Patch from Kamil Linek from bug #57071 - 3+ XSSF column label names for pivot tables
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647088 13f79535-47bb-0310-9956-ffa450edef68
2014-12-21 06:20:06 +00:00
Nick Burch
942f8044d9 Patch from Kamil Linek from bug #57063 - XSSF custom column label names for pivot tables
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647087 13f79535-47bb-0310-9956-ffa450edef68
2014-12-21 06:12:20 +00:00
Dominik Stadler
68bb54e06a Bug 57254: XWPF: Correctly build internal list of styles when styles are added
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1646742 13f79535-47bb-0310-9956-ffa450edef68
2014-12-19 14:42:25 +00:00
Dominik Stadler
66de3ced8b Remove unused members,
Fix an Eclipse warning

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1646736 13f79535-47bb-0310-9956-ffa450edef68
2014-12-19 14:36:41 +00:00
Dominik Stadler
fb9295ffb9 Bug 57312: Add check for null value of underline w:val
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1646729 13f79535-47bb-0310-9956-ffa450edef68
2014-12-19 14:29:50 +00:00
Nick Burch
e27afd1332 Fix warnings and inconsistent indents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1646163 13f79535-47bb-0310-9956-ffa450edef68
2014-12-17 07:01:38 +00:00
Dominik Stadler
6168a7999c Bug 57355: Fix test-compilation casued by moving the code to the base-test-class
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1645922 13f79535-47bb-0310-9956-ffa450edef68
2014-12-16 11:18:21 +00:00
Dominik Stadler
51308cd422 Bug 57355: Fix ArrayIndexOutOfBoundsException by removing two unnecessary lines in XSSFSheet.getColumnWidthInPixels()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1645900 13f79535-47bb-0310-9956-ffa450edef68
2014-12-16 10:40:02 +00:00
Nick Burch
93372f4468 Prep for release
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1645814 13f79535-47bb-0310-9956-ffa450edef68
2014-12-16 01:54:49 +00:00
Nick Burch
c832b0ed4a Prep for release
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1645812 13f79535-47bb-0310-9956-ffa450edef68
2014-12-16 01:52:42 +00:00
Andreas Beeker
181d135fb9 Added link to test cases for the workarounds
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1645344 13f79535-47bb-0310-9956-ffa450edef68
2014-12-13 19:00:00 +00:00