Commit Graph

56 Commits

Author SHA1 Message Date
Andreas Beeker
4a5f7765bb fix eclipse warnings - close resources
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779869 13f79535-47bb-0310-9956-ffa450edef68
2017-01-23 00:31:27 +00:00
Javen O'Neal
96d35e0b8e Eclipse automated refactor/cleanup: convert for loops to for-each loops
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765736 13f79535-47bb-0310-9956-ffa450edef68
2016-10-20 01:54:56 +00:00
Dominik Stadler
5c76ccba5b Add missing close() of resources in both production code and tests
Use revert() instead of close() on OCPPackage in some places to not re-write the file unnecessarily.
This should now run tests without leftover file handles when checked with file leak detector and
allows to find newly introduced cases more easily.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648160 13f79535-47bb-0310-9956-ffa450edef68
2014-12-28 09:16:57 +00:00
Yegor Kozlov
0c12a76991 moved ptg classes to org.apache.poi.ss.formula.ptg
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1038685 13f79535-47bb-0310-9956-ffa450edef68
2010-11-24 16:47:37 +00:00
Yegor Kozlov
de13c1193c Fixed parsing formulas containing defined names beginning with an underscore, see Bug 9640
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@979329 13f79535-47bb-0310-9956-ffa450edef68
2010-07-26 15:52:57 +00:00
Josh Micich
9926c89006 Fixed compiler warnings - unnecessary throws declaration
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@805552 13f79535-47bb-0310-9956-ffa450edef68
2009-08-18 19:49:28 +00:00
Yegor Kozlov
db7502182e Fixed HyperlinkRecord to properly handle URL monikers, see Bugzilla 47498
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@793281 13f79535-47bb-0310-9956-ffa450edef68
2009-07-12 07:21:04 +00:00
Yegor Kozlov
050f386bba removed unused imports of deprecated classes, fixed javadoc errors
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@764203 13f79535-47bb-0310-9956-ffa450edef68
2009-04-11 14:15:27 +00:00
Yegor Kozlov
177533e23b fixed formula parser to correctly resolve sheet-level names
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@729028 13f79535-47bb-0310-9956-ffa450edef68
2008-12-23 16:19:07 +00:00
Josh Micich
6a851a43b2 Code cleanup in junit
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@699489 13f79535-47bb-0310-9956-ffa450edef68
2008-09-26 20:32:06 +00:00
Josh Micich
b1f74040ad Fix formula parser to properly support the range operator. Small fixes to parsing of sheet names and full column references.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@699487 13f79535-47bb-0310-9956-ffa450edef68
2008-09-26 20:25:45 +00:00
Josh Micich
4a19202aae Fix for bug 45780 - update area refs during HSSFSheet.shiftRows()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@696038 13f79535-47bb-0310-9956-ffa450edef68
2008-09-16 20:17:30 +00:00
Josh Micich
e32412de65 Replaced calls to deprecated versions of createCell(), getCell(), createRow(), and getRow(). (Changing short to int)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@688910 13f79535-47bb-0310-9956-ffa450edef68
2008-08-25 22:41:08 +00:00
Josh Micich
ea84181642 Consolidating ValueRecordsAggregate within RowRecordsAggregate
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@683758 13f79535-47bb-0310-9956-ffa450edef68
2008-08-07 23:49:10 +00:00
Josh Micich
27761348b9 refactored all hssf junits to get test sample data in the in one place
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@645348 13f79535-47bb-0310-9956-ffa450edef68
2008-04-07 03:02:03 +00:00
Nick Burch
e113d12d34 Fix from Josh from bug #44417 - Improved handling of references for the need to quote the sheet name for some formulas, but not when fetching a sheet by name
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@628033 13f79535-47bb-0310-9956-ffa450edef68
2008-02-15 12:04:42 +00:00
Nick Burch
022aa1ad69 Fix from bug #41726 - support signed offsets from relative areas and references
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@614211 13f79535-47bb-0310-9956-ffa450edef68
2008-01-22 14:48:51 +00:00
Henri Yandell
fca4623791 Applying the copy2license.pl script (with tiny modification to allow for more whitespace than it expects in the POI header) to all files. ant jar succeeds, and the svn diff has been verified by eye. Still more files to do, this is the first pass.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@489730 13f79535-47bb-0310-9956-ffa450edef68
2006-12-22 19:18:16 +00:00
Amol S. Deshmukh
8a926c028c test case that checks to see if a case of MissingArgsPtg in the formula string is handled correctly
git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@434425 13f79535-47bb-0310-9956-ffa450edef68
2006-08-24 16:41:12 +00:00
Jason Height
07f76e4bb6 Major landing of the following changes:
1) Full implementation of UnicodeStrings
2) exposure of RichText strings to the usermodel
3) Modification to SSTRecord to support duplicates. Fixes a few bugs
4) RecordInputStream *smart* ?? handeling of continue records!

Phew This took 6 months on and off to put together. Just happy to commit somethig

Report any problems!


git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@353769 13f79535-47bb-0310-9956-ffa450edef68
2005-08-18 07:06:44 +00:00
Avik Sengupta
668c108b82 Fix for bug 27272 : Unknown Ptg 3C and 3D
by Patrick Luby, thanks!
PR:
Obtained from:
Submitted by:
Reviewed by:


git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@353691 13f79535-47bb-0310-9956-ffa450edef68
2005-05-19 14:56:45 +00:00
Avik Sengupta
5bb531e555 testcase for bug 34021 , already worked fine
git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@353647 13f79535-47bb-0310-9956-ffa450edef68
2005-04-22 13:12:14 +00:00
Glen Stampoultzis
dbacc2b8f3 Centralized creation of temp files and made the default operation to delete on exit
git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@353606 13f79535-47bb-0310-9956-ffa450edef68
2004-10-12 05:49:01 +00:00
Glen Stampoultzis
a4047ad573 New licence changes.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@353545 13f79535-47bb-0310-9956-ffa450edef68
2004-04-09 13:05:39 +00:00
Avik Sengupta
2245df361f Sync to REL_2_BR: HSSFCell.getStringValue now returns the formula result if it is a string.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@353327 13f79535-47bb-0310-9956-ffa450edef68
2003-08-31 06:19:41 +00:00
Avik Sengupta
e785cbdd46 Syncing to REL_2_BR: Macro functions and related fixes, by Paul Krause bug id:21444
git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@353326 13f79535-47bb-0310-9956-ffa450edef68
2003-08-31 06:16:57 +00:00
Avik Sengupta
b59b8abe8e Addition of GreaterThan and LessThan in formulas (IF Functions)
Originally submitted by Cameron Riley (PR 16392). Thanks.
Added simple tests at high and low level, more complicated cases to be tested
<= and >= probably still wont work!
Had to apply diff by hand, one horrible line at a time (yikes!!)


git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@353081 13f79535-47bb-0310-9956-ffa450edef68
2003-05-04 18:22:09 +00:00
Glen Stampoultzis
64967ec532 Changed copyright from 2002 to 2003
git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@353070 13f79535-47bb-0310-9956-ffa450edef68
2003-04-30 04:39:21 +00:00
Danny Muid
83b4c947da Support for the SUMIF formula and non-alpha string literals
PR:
 Also fixes Bug #17582
Obtained from:
Submitted by:
 Test case for non-alpha string literals provided by ext-jens.riis@nokia.com (Jens Riis)
Reviewed by:
 Thanks Avik for your FormulaParser help


git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@353028 13f79535-47bb-0310-9956-ffa450edef68
2003-03-17 04:47:58 +00:00
Danny Muid
9dfd573ce7 FormulaParser changes to support IF function(s)
git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@353027 13f79535-47bb-0310-9956-ffa450edef68
2003-03-15 01:57:41 +00:00
Andrew C. Oliver
9c206deed3 unit test for date formula
PR:
Obtained from:
Submitted by:
Reviewed by:


git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@352898 13f79535-47bb-0310-9956-ffa450edef68
2002-10-24 02:14:29 +00:00
Andrew C. Oliver
7ee81420f4 Bool formulas http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13078
PR:
Obtained from:
Submitted by:
Reviewed by:


git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@352865 13f79535-47bb-0310-9956-ffa450edef68
2002-10-01 17:37:47 +00:00
Andrew C. Oliver
32543e4e8c *read only* support for optimized ifs. meaning "if(A1=A3,A1,A2)" and stuff.
This optimized if has the conceptual clarity of a featherweight elephant
carrier used as a pizza topping.  This concludes my therapy session.  I love
this project :-).  Next week I'll try and get write support underway unless
someone beats me to it.
PR:
Obtained from:
Submitted by:
Reviewed by:


git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@352839 13f79535-47bb-0310-9956-ffa450edef68
2002-09-06 03:56:47 +00:00
Andrew C. Oliver
72965e9a0d Added (test first) test case for if formulas
PR:
Obtained from:
Submitted by:
Reviewed by:


git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@352833 13f79535-47bb-0310-9956-ffa450edef68
2002-09-02 16:13:48 +00:00
Avik Sengupta
3b6f854e14 writing string formulas now work
git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@352822 13f79535-47bb-0310-9956-ffa450edef68
2002-08-03 18:16:54 +00:00
Avik Sengupta
70c361f9dd better support for sheet functions.... more refactoring after i have written tests for named range. Inclueds a fix for bug 9632
git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@352725 13f79535-47bb-0310-9956-ffa450edef68
2002-06-26 18:05:40 +00:00
Avik Sengupta
3d30c55466 first cut support for sheet references. Writing works fine, reading also works except for bug 9632 .. which means that the formula string retrieved is incorrect. will fix soon
git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@352723 13f79535-47bb-0310-9956-ffa450edef68
2002-06-25 08:35:16 +00:00
Avik Sengupta
1ef8d27a1e fix for bug 9802, we write simple sum ptg, tho we can also read attr ptg. trying to write an attr ptg messes up the class change algo.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@352687 13f79535-47bb-0310-9956-ffa450edef68
2002-06-12 12:40:03 +00:00
Avik Sengupta
ecc283b69d updated tests without ReferenceUtil
git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@352669 13f79535-47bb-0310-9956-ffa450edef68
2002-06-11 20:20:41 +00:00
Avik Sengupta
2072902e33 Framework to set the class of a token
git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@352651 13f79535-47bb-0310-9956-ffa450edef68
2002-05-27 21:00:12 +00:00
Avik Sengupta
65aa73beb4 committing patches supplied by Matthew McClain for bug 8757. This will handle most cases, since majority formulas expect value class params. Ptgs to be refactored for full functionality
git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@352600 13f79535-47bb-0310-9956-ffa450edef68
2002-05-06 18:23:24 +00:00
Avik Sengupta
9a6fc596dd absolute refs in area references, plus some tests
git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@352599 13f79535-47bb-0310-9956-ffa450edef68
2002-05-05 16:55:41 +00:00
Avik Sengupta
94998b29f5 Absolute vs relative references now work .. refactored ReferenceUtils in the bargain
git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@352598 13f79535-47bb-0310-9956-ffa450edef68
2002-05-04 15:45:05 +00:00
Avik Sengupta
8ac8b510cf fixed the tests, but they still work
git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@352596 13f79535-47bb-0310-9956-ffa450edef68
2002-05-03 15:47:20 +00:00
Andrew C. Oliver
46e32166e4 wow... I thought I was doing test first....but um...it turns out it already works. Avik ROCKS!!!
git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@352575 13f79535-47bb-0310-9956-ffa450edef68
2002-05-01 01:41:51 +00:00
Andrew C. Oliver
1ea726c701 probably nothing
git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@352573 13f79535-47bb-0310-9956-ffa450edef68
2002-05-01 01:19:28 +00:00
Andrew C. Oliver
3d1b59dbb3 oops left off avik's test case
git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@352572 13f79535-47bb-0310-9956-ffa450edef68
2002-05-01 01:11:05 +00:00
Andrew C. Oliver
fc90730062 sum formula test
git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@352565 13f79535-47bb-0310-9956-ffa450edef68
2002-04-30 02:12:25 +00:00
Andrew C. Oliver
d83491053b More work from avik
git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@352561 13f79535-47bb-0310-9956-ffa450edef68
2002-04-30 00:18:47 +00:00
Andrew C. Oliver
2297f219ce reference tests
git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@352538 13f79535-47bb-0310-9956-ffa450edef68
2002-04-28 20:51:55 +00:00