moparisthebest/poi
1
0
Fork 0
Code Issues Pull Requests Releases 1 Wiki Activity
8,970 Commits 29 Branches 84 Tags 722 MiB
49add35f3b
Commit Graph

2353 Commits

Author SHA1 Message Date
Javen O'Neal
49add35f3b fix compile error 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812531 13f79535-47bb-0310-9956-ffa450edef68
 2017-10-18 14:40:05 +00:00
Javen O'Neal
42c4e4909c cleanup for r1812475: avoid NPEs from string.isEmpty() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812520 13f79535-47bb-0310-9956-ffa450edef68
 2017-10-18 14:29:56 +00:00
Javen O'Neal
fc2bcfae9a cleanup for r1812476: avoid NPEs from string.isEmpty() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812516 13f79535-47bb-0310-9956-ffa450edef68
 2017-10-18 14:08:43 +00:00
Javen O'Neal
5fb4887907 replace "".equals(string) with string.isEmpty() to avoid null strings silently evaluating to false; most code should probably check string for null if it is not already 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812476 13f79535-47bb-0310-9956-ffa450edef68
 2017-10-18 08:41:42 +00:00
Javen O'Neal
aba704b928 prefer literal.equals(variable) over variable.equals(literal) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812475 13f79535-47bb-0310-9956-ffa450edef68
 2017-10-18 08:41:25 +00:00
Javen O'Neal
3a2ee5f4d1 convert "".equals(string) to string.isEmpty() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812470 13f79535-47bb-0310-9956-ffa450edef68
 2017-10-18 08:22:51 +00:00
Javen O'Neal
21b65721e7 simplfy PackagingURIHelper#combine boolean logic using xor and replacing +FORWARD_SLASH_CHAR with FORWARD_SLASH_STRING 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812468 13f79535-47bb-0310-9956-ffa450edef68
 2017-10-18 08:10:36 +00:00
Javen O'Neal
afa5be82d3 fix typo 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812464 13f79535-47bb-0310-9956-ffa450edef68
 2017-10-18 07:47:25 +00:00
Javen O'Neal
cfac692a6a string.equals("") -> string.isEmpty() or "".equals(string) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812463 13f79535-47bb-0310-9956-ffa450edef68
 2017-10-18 07:45:53 +00:00
Javen O'Neal
7eb6686b1d remove deprecated XSSFRowShifter.shiftMerged(int,int,int) method; replaced with RowShifter.shiftMergedRegions(int,int,int) in POI 3.15 beta 2 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812354 13f79535-47bb-0310-9956-ffa450edef68
 2017-10-17 07:10:25 +00:00
Dustin Spicuzza
ab147e9998 Bug 61584: Fix XDGFPage variable typo causing crash 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812240 13f79535-47bb-0310-9956-ffa450edef68
 2017-10-16 01:35:31 +00:00
PJ Fanning
e1571c9130 Remove unnecessary toString calls [thanks to Kui Liu]. This close #79. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812233 13f79535-47bb-0310-9956-ffa450edef68
 2017-10-15 20:34:10 +00:00
Dominik Stadler
bc7d79a613 Fix some findbugs-issues and apply some code-cleanup and apply some smaller pull requests. 
This closes #74, This closes #75, This closes #76

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812097 13f79535-47bb-0310-9956-ffa450edef68
 2017-10-13 09:40:22 +00:00
Dominik Stadler
887ec868b7 Fix aparent copy/paste error in XSSFBorderFormatting 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811867 13f79535-47bb-0310-9956-ffa450edef68
 2017-10-11 18:32:13 +00:00
Dominik Stadler
793938ecef Bug 58068: Add a method to pass the actual Color to StylesTable.findFont(). 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811866 13f79535-47bb-0310-9956-ffa450edef68
 2017-10-11 18:32:01 +00:00
Dominik Stadler
c05e07b55c adjust tests, javadoc, ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811865 13f79535-47bb-0310-9956-ffa450edef68
 2017-10-11 18:31:34 +00:00
Dominik Stadler
673b223f61 Remove "filling" in IntList as this has no effect whatsoever as far as I could see 
Fix some IntelliJ warnings, missing JavaDoc, typos, Findbugs issues

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811793 13f79535-47bb-0310-9956-ffa450edef68
 2017-10-11 05:32:05 +00:00
Dominik Stadler
0e52f62a1e Bug 61564: Try to get rid of the Java 9 illegal access warning now that we run Java 8 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811145 13f79535-47bb-0310-9956-ffa450edef68
 2017-10-04 19:54:41 +00:00
Dominik Stadler
688d5072d1 Fix bug 61516: when copying cells with formulas we should properly check for references that are invalid afterwards. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809967 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-28 09:56:45 +00:00
Dominik Stadler
43717f6936 Fix some Sonar issues 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809636 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-25 15:10:40 +00:00
Dominik Stadler
61a281e790 Replace the incompatible new interface method endSheet() with a Java 8 default method so existing implementations do not need to be adjusted. Also use this for headerFooter() and remove the empty implementations that are now obsolete. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809635 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-25 14:45:14 +00:00
PJ Fanning
3a622169d3 Remove more deprecated classes and methods 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809428 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-23 14:03:25 +00:00
Dominik Stadler
acb1772d4b Tried to enable this test, but it is broken since a long time and I am not sure how this is expected to behave... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809372 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-23 07:44:09 +00:00
Dominik Stadler
4a6bb031a0 Apply patch to add endSheet() to the XSSFEventBasedExcelExtractor, fixes bug 60737, thanks to user zakim for the patch 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809371 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-23 07:41:27 +00:00
Dominik Stadler
5ed15ac7c2 More IntelliJ warnings fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809370 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-23 07:38:01 +00:00
Dominik Stadler
29dbeb51ad Bug 59747: Adjust order of first two entries in the resulting Zip to try to enable some external tools to auto-detect the file-type 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809357 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-22 21:19:39 +00:00
Dominik Stadler
79a039ec8d Fix some IntelliJ warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809349 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-22 20:07:56 +00:00
Tim Allison
9cade10fa4 Bug 61349 -- add more sanity checks when allocating byte[] 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809169 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-21 14:52:59 +00:00
Dominik Stadler
828fb9a86c Apply patch from bug 61033 to add a XSSFWorkbook.setCellFormulaValidation(false) to speed up some operations 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809071 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-20 19:08:57 +00:00
PJ Fanning
f13f0dfbbd Bug 61528 - Pivot Table enhancements, new example [Thanks to R Kietel]. This closes #71 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808945 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-19 21:18:09 +00:00
PJ Fanning
a9ec0770f0 tidy up some test code 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808944 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-19 21:04:30 +00:00
Dominik Stadler
1496e83eaa Adjust to make forbidden-api-check succeed again 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808930 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-19 19:02:31 +00:00
Dominik Stadler
985af5304a Bug 61148: Fix calculating formula value, unfortunately we currently need to set the value twice 
Also rework related tests to run more of the tests for HSSF, XSSF and SXSSF

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808929 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-19 19:02:22 +00:00
Dominik Stadler
c31d6686db Fix some IntelliJ warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808908 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-19 16:23:37 +00:00
Tim Allison
a59402a37f 60805 (partial) -- remove/suppress println in tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808903 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-19 15:52:21 +00:00
Dominik Stadler
d1765d7e76 While working on bug 61148 I found that getCellType() and setCellErrorValue() in SXSSFCell are doing different things than the ones in XSSFCell, tried to fix this by mimicking functionality of XSSF in SXSSF as well. 
Reformating some small things as well.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808874 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-19 12:47:13 +00:00
PJ Fanning
51305b6260 use non-deprecated versions of getCellType 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808741 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-18 16:31:55 +00:00
PJ Fanning
e0ee55e75f change CellFormat.ultimateType to return CellType 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808739 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-18 16:06:54 +00:00
PJ Fanning
318fe3e597 change HyperLink getType to return HyperlinkType 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808737 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-18 15:55:48 +00:00
PJ Fanning
aaad224db9 fix compiler warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808722 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-18 14:15:15 +00:00
PJ Fanning
7dad60e9d4 update getCellType to return CellType enum instead of int 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808718 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-18 13:58:55 +00:00
PJ Fanning
4a4c428b6b update getCellType to return CellType enum instead of int 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808703 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-18 13:38:07 +00:00
PJ Fanning
d4486af6de update getCellType to return CellType enum instead of int 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808700 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-18 13:26:16 +00:00
PJ Fanning
d9b63eb569 remove some deprecated code slated for removal in 3.18 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808687 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-18 12:27:36 +00:00
PJ Fanning
16d262d0b4 Change getCachedFormulaResultType to return CellType 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808678 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-18 10:50:50 +00:00
Andreas Beeker
a51bac65b7 #60499 - Deleting a picture that is used twice on a slide corrupt the slide 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808661 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-17 22:45:03 +00:00
Dominik Stadler
71cfb659a1 Remove deprecated methods from NPOIFSFileSystem/OPOIFSFileSystem 
IntelliJ warnings/suggestions

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808622 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-17 11:08:45 +00:00
Dominik Stadler
2917583bd2 Fix some warnings in OOXMLLite and move copyFile to IOUtils 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808621 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-17 11:08:31 +00:00
Dominik Stadler
b644047b70 Various code cleanups, "final" for static methods is useless, for-loops, simplify boolean conditions, try-with-resource, javadoc, ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808620 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-17 11:08:23 +00:00
Dominik Stadler
75c63b6bbe Some more code cleanup 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808619 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-17 11:07:48 +00:00