Commit Graph

5713 Commits

Author SHA1 Message Date
Javen O'Neal
a94df00797 make HSSFCellStyle attributes final, add Override decorators on all methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721876 13f79535-47bb-0310-9956-ffa450edef68
2015-12-28 05:43:11 +00:00
Javen O'Neal
ec4732a034 bug 58740: add @Internal annotations and decrease access level to methods that only exist for unit testing
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721864 13f79535-47bb-0310-9956-ffa450edef68
2015-12-28 00:52:47 +00:00
Javen O'Neal
19e5db9602 bug 58740: return unmodifiable list/map when exposing internal data structures
patch from Archie Cobbs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721857 13f79535-47bb-0310-9956-ffa450edef68
2015-12-27 23:17:33 +00:00
Dominik Stadler
d89168fa51 Fix compiling unit-test after previous changes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721471 13f79535-47bb-0310-9956-ffa450edef68
2015-12-22 22:48:31 +00:00
Dominik Stadler
a021bc780b Fix some cases where file resources were not closed correctly, mostly when Exceptions occur during opening files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721470 13f79535-47bb-0310-9956-ffa450edef68
2015-12-22 22:36:43 +00:00
Dominik Stadler
c9dee45744 fix commandline option in PPTX2PNG from quite to quiet
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721469 13f79535-47bb-0310-9956-ffa450edef68
2015-12-22 22:36:33 +00:00
Dominik Stadler
0a3370347e Fix freeing resources in some tests and dev-tools so we can run unit-tests with enabled file-leak-detector
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721468 13f79535-47bb-0310-9956-ffa450edef68
2015-12-22 22:35:59 +00:00
Andreas Beeker
b333ed457d #56004 - Support for WMF rendering (parsing the WMF records)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721078 13f79535-47bb-0310-9956-ffa450edef68
2015-12-21 01:26:39 +00:00
Dominik Stadler
b69c64fe21 Handle some cases better where file handles were left open by the ExtractorFactory, mostly when opening files failed, but also when using the NPOIFSFileSystem for initialization.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721064 13f79535-47bb-0310-9956-ffa450edef68
2015-12-20 20:39:01 +00:00
Nick Burch
355810fb9f Unit test for non-reproducable #58747
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1720588 13f79535-47bb-0310-9956-ffa450edef68
2015-12-17 15:05:06 +00:00
Dominik Stadler
ffe36ac2fe Fix unit test for bug 58731 to actually run
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1720534 13f79535-47bb-0310-9956-ffa450edef68
2015-12-17 12:39:01 +00:00
Nick Burch
1fbfc70cca Unit test for #58731 - not reproduced, and some javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1720411 13f79535-47bb-0310-9956-ffa450edef68
2015-12-16 18:15:31 +00:00
Andreas Beeker
7b4c17b70c #58733 - New AIOOBE in getCell while iterating through a table in PPT
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1720035 13f79535-47bb-0310-9956-ffa450edef68
2015-12-14 22:49:04 +00:00
Andreas Beeker
3e8b58e356 fix forbidden apis issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1719778 13f79535-47bb-0310-9956-ffa450edef68
2015-12-13 09:51:22 +00:00
Andreas Beeker
ad89fdcaf5 #58718 - Master styles not initialized when running multithreaded
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1719758 13f79535-47bb-0310-9956-ffa450edef68
2015-12-13 01:50:24 +00:00
Javen O'Neal
4f8057e56f bug 57450: javadoc fixes from Stefan Thurnherr
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1718226 13f79535-47bb-0310-9956-ffa450edef68
2015-12-06 21:43:26 +00:00
Javen O'Neal
5da709336c supporting change for bug 56454: SheetUtil.containsCell and CellRangeAddress.isInRange are equivalent
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1718221 13f79535-47bb-0310-9956-ffa450edef68
2015-12-06 21:11:38 +00:00
Javen O'Neal
dedb924183 bug 56454: shiftRows incorrectly handle merged regions that do not contain column 0. Add failing unit test from Jörg Selbach.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1718217 13f79535-47bb-0310-9956-ffa450edef68
2015-12-06 20:51:54 +00:00
Javen O'Neal
37622ec57e make test easier to understand using A1 addresses instead of row+col numbers
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1718216 13f79535-47bb-0310-9956-ffa450edef68
2015-12-06 20:43:27 +00:00
Dominik Stadler
96cb8c18fe Bug 58084: Fix cloning Cell Styles with Borders
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717973 13f79535-47bb-0310-9956-ffa450edef68
2015-12-04 14:39:07 +00:00
Dominik Stadler
387fb86d68 Eclipse warnings, code formatting, javadoc, ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717972 13f79535-47bb-0310-9956-ffa450edef68
2015-12-04 14:38:14 +00:00
Javen O'Neal
4aa6108c0d add hashCode for corresponding equals function
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717940 13f79535-47bb-0310-9956-ffa450edef68
2015-12-04 11:59:26 +00:00
Javen O'Neal
abced24fe4 javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717938 13f79535-47bb-0310-9956-ffa450edef68
2015-12-04 11:56:59 +00:00
Javen O'Neal
eca89530d3 whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717931 13f79535-47bb-0310-9956-ffa450edef68
2015-12-04 11:12:27 +00:00
Javen O'Neal
26abacebaf FindBugs warning: ExcelStyleDateFormatter doesn't override java.text.SimpleDAtaFormat.equals(Object)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717930 13f79535-47bb-0310-9956-ffa450edef68
2015-12-04 10:54:21 +00:00
Javen O'Neal
3b24eaacd3 make fields static
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717929 13f79535-47bb-0310-9956-ffa450edef68
2015-12-04 10:51:03 +00:00
Javen O'Neal
ebbf3d0ddb whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717928 13f79535-47bb-0310-9956-ffa450edef68
2015-12-04 10:47:31 +00:00
Javen O'Neal
6d17f8ddef whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717927 13f79535-47bb-0310-9956-ffa450edef68
2015-12-04 10:46:58 +00:00
Javen O'Neal
17a4680cee findbugs: check return value of File.mkdir(s), and don't accidentally catch RuntimeException
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717923 13f79535-47bb-0310-9956-ffa450edef68
2015-12-04 10:33:28 +00:00
Javen O'Neal
93497e5b0e add comments for names of missing functions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717920 13f79535-47bb-0310-9956-ffa450edef68
2015-12-04 10:01:58 +00:00
Javen O'Neal
b6e5801a1c fix javadocs errors
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717907 13f79535-47bb-0310-9956-ffa450edef68
2015-12-04 07:20:36 +00:00
Javen O'Neal
83a2f13494 fix javadoc errors
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717903 13f79535-47bb-0310-9956-ffa450edef68
2015-12-04 07:10:26 +00:00
Javen O'Neal
44c9afd31d fix javadoc errors
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717902 13f79535-47bb-0310-9956-ffa450edef68
2015-12-04 07:05:52 +00:00
Javen O'Neal
9c19c23291 bug 58570: add get/setActiveCell to Sheet interface, add Cell.getAddress,
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717900 13f79535-47bb-0310-9956-ffa450edef68
2015-12-04 06:36:27 +00:00
Javen O'Neal
293ef9fe17 remove deprecated functions (since 2008)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717899 13f79535-47bb-0310-9956-ffa450edef68
2015-12-04 06:30:34 +00:00
Dominik Stadler
5a8aceec32 Add some additional rules for the forbidden-apis-check borrowed from Elasticsearch, also add a separate signature file with more rules for the 'prod' code and fix two newly found issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717689 13f79535-47bb-0310-9956-ffa450edef68
2015-12-02 21:47:52 +00:00
Andreas Beeker
cc77b04a94 Sonar fixes, direct array parameter
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717359 13f79535-47bb-0310-9956-ffa450edef68
2015-12-01 00:23:21 +00:00
Andreas Beeker
f0ed3cbbab - #47904 - Update text styles in HSLF MasterSlide
- common sl unification for TextParagraph.setTextAlign

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717351 13f79535-47bb-0310-9956-ffa450edef68
2015-11-30 23:34:30 +00:00
Javen O'Neal
89fbd66262 bug 58670: cleanup from r1717192
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717194 13f79535-47bb-0310-9956-ffa450edef68
2015-11-30 07:03:09 +00:00
Javen O'Neal
8410c84ad6 bug 58670: replace SXSSFRow's storage of SXSSFCells[] with a TreeMap<Int, SXSSFCell>
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717192 13f79535-47bb-0310-9956-ffa450edef68
2015-11-30 06:07:49 +00:00
Javen O'Neal
b5ad3a9327 add @Override annotations to SXSSFRow
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717181 13f79535-47bb-0310-9956-ffa450edef68
2015-11-30 05:28:57 +00:00
Javen O'Neal
24e5a0a458 add @Override annotation. Explicitly specify workbook type returned by SXSSFITestDataProvider.writeOutAndReadBack
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717179 13f79535-47bb-0310-9956-ffa450edef68
2015-11-30 05:22:14 +00:00
Javen O'Neal
5650b03ea0 testBool/testErr: check values before writeOutAndReadBack
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717178 13f79535-47bb-0310-9956-ffa450edef68
2015-11-30 05:21:01 +00:00
Javen O'Neal
7fc9df615f fix testErr: createRow(1) -> createRow(0); replace assumeTrue with assertEquals for more informative test results
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717171 13f79535-47bb-0310-9956-ffa450edef68
2015-11-30 05:00:24 +00:00
Javen O'Neal
dcba12a0ce whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717167 13f79535-47bb-0310-9956-ffa450edef68
2015-11-30 04:50:18 +00:00
Javen O'Neal
a5725f9b21 add @Override and @NotImplemented annotations to SXSSFCell, update javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717164 13f79535-47bb-0310-9956-ffa450edef68
2015-11-30 04:43:32 +00:00
Javen O'Neal
2924c7b9da break testBoolErr into 2 unit tests. The test shouldn't be aware of the underlying implementation for HSSFRows, and shorter tests are better
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717163 13f79535-47bb-0310-9956-ffa450edef68
2015-11-30 04:38:04 +00:00
Javen O'Neal
b58839e4b0 whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717162 13f79535-47bb-0310-9956-ffa450edef68
2015-11-30 04:36:17 +00:00
Javen O'Neal
71b587ef36 bug 58671: change MissingCellPolicy from class to enum
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717157 13f79535-47bb-0310-9956-ffa450edef68
2015-11-30 04:24:06 +00:00
Javen O'Neal
b2a24f1a71 javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717151 13f79535-47bb-0310-9956-ffa450edef68
2015-11-30 02:06:36 +00:00
Javen O'Neal
11650f84a9 add missing ASF License headers for bug 57450
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717149 13f79535-47bb-0310-9956-ffa450edef68
2015-11-30 01:05:10 +00:00
Javen O'Neal
226fefe0c9 patch from Stefan Thurnherr: bug 57450: autosize columns in SXSSF using rows that have been flushed to disk
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717146 13f79535-47bb-0310-9956-ffa450edef68
2015-11-30 00:22:50 +00:00
Andreas Beeker
c4b5635db3 Add helper method for opening the test files - maybe switched to InputStream if test-data files are changed unexpectedly
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717099 13f79535-47bb-0310-9956-ffa450edef68
2015-11-29 17:41:58 +00:00
Andreas Beeker
60b17589b7 XSLF: tables can now be removed from sheets/groups
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717087 13f79535-47bb-0310-9956-ffa450edef68
2015-11-29 16:17:29 +00:00
Javen O'Neal
0e04793c2c bug 57844: add NotImplemented annotation to SXSSFSheet.shiftRows
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717079 13f79535-47bb-0310-9956-ffa450edef68
2015-11-29 15:31:57 +00:00
Javen O'Neal
0a69246abc add @Override annotations to Sheet classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717078 13f79535-47bb-0310-9956-ffa450edef68
2015-11-29 15:27:34 +00:00
Andreas Beeker
ee0f9b84e1 close resources
fix a few eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717077 13f79535-47bb-0310-9956-ffa450edef68
2015-11-29 15:26:53 +00:00
Javen O'Neal
d7c3a9b2ca remove debugging print statements
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717076 13f79535-47bb-0310-9956-ffa450edef68
2015-11-29 15:24:08 +00:00
Javen O'Neal
79e099f5fa Patch from Lyle for bug 52903: HSSFSheet.shiftRows does not shift hyperlink references
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717069 13f79535-47bb-0310-9956-ffa450edef68
2015-11-29 14:45:24 +00:00
Javen O'Neal
5ee6c34217 findbugs: add missing equals and hashCode for classes with a compareTo method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717068 13f79535-47bb-0310-9956-ffa450edef68
2015-11-29 14:33:28 +00:00
Javen O'Neal
d8223753ae javadoc
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717062 13f79535-47bb-0310-9956-ffa450edef68
2015-11-29 13:15:03 +00:00
Javen O'Neal
74f0442563 bug 58667: make SX/X/HSSFRow implement Comparable interface
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717054 13f79535-47bb-0310-9956-ffa450edef68
2015-11-29 12:14:45 +00:00
Javen O'Neal
16c1afa0d0 HSSFRow: make instance variables final
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717049 13f79535-47bb-0310-9956-ffa450edef68
2015-11-29 11:58:26 +00:00
Javen O'Neal
f3b88f6755 SXSSFRow: privatize instance variables, make _sheet final
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717044 13f79535-47bb-0310-9956-ffa450edef68
2015-11-29 11:50:11 +00:00
Javen O'Neal
ff6d93d4f3 whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717043 13f79535-47bb-0310-9956-ffa450edef68
2015-11-29 11:48:02 +00:00
Javen O'Neal
a2ac15f1c8 make SXSSFRow._style private, add getRowStyleIndex() in its place
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717042 13f79535-47bb-0310-9956-ffa450edef68
2015-11-29 11:47:27 +00:00
Javen O'Neal
f324646c04 javadoc
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717040 13f79535-47bb-0310-9956-ffa450edef68
2015-11-29 11:44:03 +00:00
Javen O'Neal
db3028defb javadoc
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717038 13f79535-47bb-0310-9956-ffa450edef68
2015-11-29 11:39:36 +00:00
Javen O'Neal
7619f0c38f whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717035 13f79535-47bb-0310-9956-ffa450edef68
2015-11-29 11:34:56 +00:00
Javen O'Neal
9d014aa00b bug 52903/58557: add @Override decorators to XSSFHyperlink and HSSFHyperlink
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717026 13f79535-47bb-0310-9956-ffa450edef68
2015-11-29 02:43:17 +00:00
Javen O'Neal
659662b5f8 bug 58636: make ClientAnchor enum constructor private, make byId Internal
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717024 13f79535-47bb-0310-9956-ffa450edef68
2015-11-29 02:18:45 +00:00
Andreas Beeker
484297b9cf #46210 - Title placeholder not recognized by Powerpoint 2003
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717020 13f79535-47bb-0310-9956-ffa450edef68
2015-11-29 01:23:54 +00:00
Andreas Beeker
0c7e8e0c47 #58663 - Pictures cannot be removed from a slide
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717018 13f79535-47bb-0310-9956-ffa450edef68
2015-11-29 00:51:04 +00:00
Javen O'Neal
8c1517eee4 javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716948 13f79535-47bb-0310-9956-ffa450edef68
2015-11-28 11:55:02 +00:00
Javen O'Neal
47dc6340c2 javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716947 13f79535-47bb-0310-9956-ffa450edef68
2015-11-28 11:53:22 +00:00
Javen O'Neal
1f05c1916a make instance variables final
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716843 13f79535-47bb-0310-9956-ffa450edef68
2015-11-27 11:35:43 +00:00
Javen O'Neal
2a62f57db5 +FIXME
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716838 13f79535-47bb-0310-9956-ffa450edef68
2015-11-27 11:30:18 +00:00
Javen O'Neal
58bffd78a1 javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716811 13f79535-47bb-0310-9956-ffa450edef68
2015-11-27 09:45:53 +00:00
Javen O'Neal
19f4f8af22 javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716365 13f79535-47bb-0310-9956-ffa450edef68
2015-11-25 11:52:25 +00:00
Javen O'Neal
e8b2d5feb4 bug 58651: replace for-looped sheet.getMergedRegion(index) with sheet.getMergedRegions()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716362 13f79535-47bb-0310-9956-ffa450edef68
2015-11-25 11:48:17 +00:00
Javen O'Neal
2e795a5f26 javadoc fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716342 13f79535-47bb-0310-9956-ffa450edef68
2015-11-25 09:48:36 +00:00
Javen O'Neal
842171b94a add failing unit test for bug 58648
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716338 13f79535-47bb-0310-9956-ffa450edef68
2015-11-25 09:19:03 +00:00
Javen O'Neal
1f874be829 bug 58636: upgrade anchor types from int to AnchorType enum
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716313 13f79535-47bb-0310-9956-ffa450edef68
2015-11-25 07:16:43 +00:00
Javen O'Neal
026ad8fbdf close workbook at end of example
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716102 13f79535-47bb-0310-9956-ffa450edef68
2015-11-24 10:50:57 +00:00
Dominik Stadler
e20da28904 Remove useless double check on null introduced with the previous bugfix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716082 13f79535-47bb-0310-9956-ffa450edef68
2015-11-24 09:10:27 +00:00
Javen O'Neal
65cd898a61 bug 58637: replace deprecated getCellComment(row, col) usage
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716075 13f79535-47bb-0310-9956-ffa450edef68
2015-11-24 08:54:32 +00:00
Javen O'Neal
72aae0f14b bug 58348: use copy constructor design pattern rather than cloneable pattern for CellCopyPolicy
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716074 13f79535-47bb-0310-9956-ffa450edef68
2015-11-24 08:52:45 +00:00
Javen O'Neal
e117107313 javadoc
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716073 13f79535-47bb-0310-9956-ffa450edef68
2015-11-24 08:50:53 +00:00
Javen O'Neal
e25f69814c whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716060 13f79535-47bb-0310-9956-ffa450edef68
2015-11-24 08:15:42 +00:00
Javen O'Neal
d58342dd9f whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716057 13f79535-47bb-0310-9956-ffa450edef68
2015-11-24 08:13:10 +00:00
Javen O'Neal
735c43ec9d bug 58644: fix HSSFSheet.setZoom(int); update documentation to use non-deprecated method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716053 13f79535-47bb-0310-9956-ffa450edef68
2015-11-24 08:04:42 +00:00
Javen O'Neal
e7d29ad533 whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716051 13f79535-47bb-0310-9956-ffa450edef68
2015-11-24 07:53:17 +00:00
Javen O'Neal
8eabc4710a bug 58642: deprecate Sheet.setZoom(numerator, denominator) and replace with Sheet.setZoom(scale)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716048 13f79535-47bb-0310-9956-ffa450edef68
2015-11-24 07:43:53 +00:00
Javen O'Neal
891f2d26fc bug 58642: remove deprecated functions in Spreadsheet Sheet interface and implementing classes; add @Override annotations
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716046 13f79535-47bb-0310-9956-ffa450edef68
2015-11-24 07:34:09 +00:00
Javen O'Neal
84fdda5736 rewrite ternary expression as simple Math.min call (yes, the ternary expression as written is equivalent to min, not max, despite the variable being called max. I'll leave that fix up to the original author).
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716044 13f79535-47bb-0310-9956-ffa450edef68
2015-11-24 07:05:11 +00:00
Javen O'Neal
dc1acc7ead whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716035 13f79535-47bb-0310-9956-ffa450edef68
2015-11-24 05:57:31 +00:00
Javen O'Neal
2fab3547be whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716034 13f79535-47bb-0310-9956-ffa450edef68
2015-11-24 05:51:54 +00:00
Javen O'Neal
cd254f2f1e FindBugs MALICIOUS_CODE, finalize method should have protected access
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716006 13f79535-47bb-0310-9956-ffa450edef68
2015-11-24 01:20:45 +00:00
Javen O'Neal
a736ac1777 FindBug warning: ICAST_IDIV_CAST_TO_DOUBLE: integral division result cast to double
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716005 13f79535-47bb-0310-9956-ffa450edef68
2015-11-24 01:11:57 +00:00
Javen O'Neal
cba32cd1a0 FindBug warning: EQ_SELF_USE_OBJECT: class defines equals(Region) and uses Object.equals(Object)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716004 13f79535-47bb-0310-9956-ffa450edef68
2015-11-24 01:10:47 +00:00