Commit Graph

37 Commits

Author SHA1 Message Date
Javen O'Neal ed5cd06fb7 bug 60128: close open file descriptors when exceptions are thrown from OPCPackage.open
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760702 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 12:57:39 +00:00
Dominik Stadler 5e0612eabd IDE warnings and fix a few places where we do not close resources in tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754673 13f79535-47bb-0310-9956-ffa450edef68
2016-07-31 17:19:17 +00:00
Andreas Beeker 11fe2eda86 #59841 - OOXML: enable custom zip streams via OPCPackage.open(ZipEntrySource)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753003 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 00:14:06 +00:00
Javen O'Neal fd1a23361b bug 59748: replace Hashtable with HashMap; contributed by Axel Howind
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1750168 13f79535-47bb-0310-9956-ffa450edef68
2016-06-24 21:39:44 +00:00
Andreas Beeker 89fb94e67d sonar fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749795 13f79535-47bb-0310-9956-ffa450edef68
2016-06-22 22:27:53 +00:00
Andreas Beeker c88ba795a0 javadoc fixes (jdk8)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749794 13f79535-47bb-0310-9956-ffa450edef68
2016-06-22 22:26:08 +00:00
Nick Burch 4eb8175d88 Fix inconsistent whitespace and indents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749530 13f79535-47bb-0310-9956-ffa450edef68
2016-06-21 14:34:12 +00:00
Nick Burch 631ca92c16 #59717 POIXMLProperties helper methods for reading and changing OOXML document thumbnails
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749528 13f79535-47bb-0310-9956-ffa450edef68
2016-06-21 14:27:41 +00:00
Javen O'Neal f49047e733 add @NotImplemented annotation to methods that are not implemented
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738469 13f79535-47bb-0310-9956-ffa450edef68
2016-04-10 21:28:41 +00:00
Dominik Stadler e8263f9d8f Fix two more places where wrong/invalid files can lead to file-handle leaks currently
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737489 13f79535-47bb-0310-9956-ffa450edef68
2016-04-02 11:01:56 +00:00
Dominik Stadler 328c52aab7 Fix some cases where file handles are not closed in OldExcelExtractor
Close resources in some more tests to make the file-leak report clean again

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737487 13f79535-47bb-0310-9956-ffa450edef68
2016-04-02 11:01:43 +00:00
Javen O'Neal 01b20a6567 make OPCPackage logger final
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736721 13f79535-47bb-0310-9956-ffa450edef68
2016-03-27 05:01:02 +00:00
Andreas Beeker 5fd71db914 - removed deprecated and confusing methods in XSSFColor
- sonar fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1708236 13f79535-47bb-0310-9956-ffa450edef68
2015-10-12 20:43:42 +00:00
Andreas Beeker 6f7f16853e Removed HDF API
Sonar fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1705779 13f79535-47bb-0310-9956-ffa450edef68
2015-09-28 21:26:06 +00:00
David North 2f8aa558b3 Patch from Chris Boyle to add basic support for .xlsm (macro-enabled) workbooks. The binary blob containing the VBA macros may be copied from one such workbook into another.
Fixes #58036

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1690593 13f79535-47bb-0310-9956-ffa450edef68
2015-07-13 09:05:17 +00:00
Nick Burch c8f8cde62d Patch from Mark Olesen from bug #57552: Sort PackagePart returns from OPCPackage by name considering numbers in filenames, so Image10.png comes after Image9.png, fixing problems with XSLF adding 10+ images to a slide
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1677373 13f79535-47bb-0310-9956-ffa450edef68
2015-05-03 08:47:50 +00:00
Dominik Stadler 7bf9b90fb2 Remove some findbugs warnings about missing close of streams, use existing IOUtils.copy() to copy from one stream to another
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1666683 13f79535-47bb-0310-9956-ffa450edef68
2015-03-14 13:18:43 +00:00
Dominik Stadler e13374683a Bug 57165: Avoid PartAlreadyExistsException when removing/cloning sheets
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1663153 13f79535-47bb-0310-9956-ffa450edef68
2015-03-01 19:56:56 +00:00
Andreas Beeker d0320ad77d Bug 56468 - Writing a workbook more than once corrupts the file
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1594721 13f79535-47bb-0310-9956-ffa450edef68
2014-05-14 21:14:16 +00:00
Nick Burch 67d97d8894 Correct an eclipse warning around close(), and a related bug that this identified
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589756 13f79535-47bb-0310-9956-ffa450edef68
2014-04-24 14:50:52 +00:00
Nick Burch 0457300fdf Try to make a few OPCPackage error messages more helpful, and slightly reform the configure code block to make it hopefully easier to read
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1540877 13f79535-47bb-0310-9956-ffa450edef68
2013-11-11 23:03:00 +00:00
Nick Burch b80a40bc13 JavaDoc fixes from #54731 from Dominik Stadler
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1492267 13f79535-47bb-0310-9956-ffa450edef68
2013-06-12 16:32:24 +00:00
Nick Burch 7aea48961d Add File based constructor to OPCPackage, alongside existing String one (which constructed a File from the string internally)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1351894 13f79535-47bb-0310-9956-ffa450edef68
2012-06-19 22:50:14 +00:00
Yegor Kozlov c0e87067e6 Bugzilla 51780 - support replacement of content types in OPC packages
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1294998 13f79535-47bb-0310-9956-ffa450edef68
2012-02-29 07:50:10 +00:00
Nick Burch c2ef05e163 Fix bug #52540 - Relax the M4.1 constraint on reading OOXML files, as some Office produced ones do have 2 Core Properties, despite the specification explicitly forbidding this
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1237631 13f79535-47bb-0310-9956-ffa450edef68
2012-01-30 12:59:54 +00:00
Nick Burch 7b211912e2 Add a disabled test for bug #51850, and tweak the OPC package exceptions to make it easier to spot when a part name is already used
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1174045 13f79535-47bb-0310-9956-ffa450edef68
2011-09-22 10:26:33 +00:00
Yegor Kozlov 866a7bf272 cleaned javadocs warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1132549 13f79535-47bb-0310-9956-ffa450edef68
2011-06-06 08:45:06 +00:00
Yegor Kozlov 7c8f56ce1c bug 51265: Enhanced Handling of Picture Parts in XWPF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1130120 13f79535-47bb-0310-9956-ffa450edef68
2011-06-01 12:07:16 +00:00
Nick Burch 4f62006ae3 Put more details in the error message for next time
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1124622 13f79535-47bb-0310-9956-ffa450edef68
2011-05-19 09:16:48 +00:00
Nick Burch 268404a200 NPOIFS and OPC both support close(), so mark them as such
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1100013 13f79535-47bb-0310-9956-ffa450edef68
2011-05-06 01:19:21 +00:00
Nick Burch 3c4946472b Improve handling and warnings when closing OPCPackage objects
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@982311 13f79535-47bb-0310-9956-ffa450edef68
2010-08-04 15:58:51 +00:00
Yegor Kozlov d49e83fe92 properly close all IO streams created in OPCPackage, see Bugzilla 48571
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@902565 13f79535-47bb-0310-9956-ffa450edef68
2010-01-24 13:26:19 +00:00
Yegor Kozlov 8b377f2f67 Avoid creating temporary files when opening OPC packages from input stream
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@898927 13f79535-47bb-0310-9956-ffa450edef68
2010-01-13 20:24:15 +00:00
Nick Burch 78d725431c From bug #47999 - avoid un-needed call to the JVM Garbage Collector when working on OOXML OPC Packages
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@825890 13f79535-47bb-0310-9956-ffa450edef68
2009-10-16 13:37:13 +00:00
Yegor Kozlov ba518d2221 fixes and misc refactorings suggested by Intellij
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@806426 13f79535-47bb-0310-9956-ffa450edef68
2009-08-21 06:08:31 +00:00
Josh Micich c83d6bfa24 Fixing compiler warnings - unnecessary typecasts
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@805284 13f79535-47bb-0310-9956-ffa450edef68
2009-08-18 05:29:53 +00:00
Josh Micich 67196db87e Renamed Package (in org.apache.poi.openxml4j.opc) to OPCPackage so as to avoid clash with java.lang.Package (see bugzilla 46859)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@755699 13f79535-47bb-0310-9956-ffa450edef68
2009-03-18 18:54:01 +00:00