Commit Graph

7723 Commits

Author SHA1 Message Date
Dominik Stadler
40a5e940c1 Remove JavaDoc warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1845435 13f79535-47bb-0310-9956-ffa450edef68
2018-11-01 10:30:16 +00:00
Dominik Stadler
0cc8ec178f IDE warnings, tried to reproduce Bug 58927, but could not
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1845434 13f79535-47bb-0310-9956-ffa450edef68
2018-11-01 10:29:54 +00:00
Tim Allison
fd125b9e4e bug 62624 -- ensure streams are closed...thanks to LGTM, and PJ!
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1845300 13f79535-47bb-0310-9956-ffa450edef68
2018-10-31 00:59:16 +00:00
Tim Allison
c257dd71f9 bug 62624 -- fix loop identified as dodgy by FindBugs; add a other sanity checks.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1845299 13f79535-47bb-0310-9956-ffa450edef68
2018-10-31 00:47:51 +00:00
Tim Allison
9229cab9bc bug 62624 -- fix recursion
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1845284 13f79535-47bb-0310-9956-ffa450edef68
2018-10-30 21:30:57 +00:00
Tim Allison
9ab4318ade bug 62625 -- clean up imports
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1845246 13f79535-47bb-0310-9956-ffa450edef68
2018-10-30 15:45:00 +00:00
Tim Allison
1db334a6fd bug 62625 -- add special handling for REFERENCE_NAME record that may only
contain an ascii string, against the spec in VBAMacroReader

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1845238 13f79535-47bb-0310-9956-ffa450edef68
2018-10-30 13:25:20 +00:00
Tim Allison
0fd3027a67 bug 62624 -- fix npe by adding processing of module name mapping in VBAMacroReader
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1845138 13f79535-47bb-0310-9956-ffa450edef68
2018-10-29 15:48:44 +00:00
Tim Allison
ad52c65f70 bug 62859 -- fix two potential NPEs when initializing XWPFSDTContent
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1844920 13f79535-47bb-0310-9956-ffa450edef68
2018-10-26 19:06:18 +00:00
Dominik Stadler
b0f5c2ca7b IDE warnings, slightly more tests and fix test to not leave a modified file behind
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1844894 13f79535-47bb-0310-9956-ffa450edef68
2018-10-26 10:58:37 +00:00
Dominik Stadler
232616f44d Adjust sample for creating comments to also create a .xlsx file
Enhance workbook factory to allow to create new empty workbooks as well

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1844881 13f79535-47bb-0310-9956-ffa450edef68
2018-10-26 09:32:57 +00:00
Dominik Stadler
2148b7f278 Typos and IDE warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1844879 13f79535-47bb-0310-9956-ffa450edef68
2018-10-26 09:32:43 +00:00
Dominik Stadler
8f11f0010e Set NOSONAR, adjust test slightly and reformat code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1844878 13f79535-47bb-0310-9956-ffa450edef68
2018-10-26 09:32:30 +00:00
Dominik Stadler
8bf6a26751 Set NOSONAR and reformat code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1844876 13f79535-47bb-0310-9956-ffa450edef68
2018-10-26 09:32:19 +00:00
Dominik Stadler
50bc5c8d6f Remove the workaround for a bug in JDK 11 which was fixed in ea+28
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1844874 13f79535-47bb-0310-9956-ffa450edef68
2018-10-26 09:32:01 +00:00
PJ Fanning
1f9a0caf2e fix class cast issur recently introduced in BaseXSSFFormulaEvaluator
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1844311 13f79535-47bb-0310-9956-ffa450edef68
2018-10-19 07:43:04 +00:00
Greg Woolsey
d24b4492f0 #62834 FormulaEvaluator.evaluateInCell() throws Exception
added cell type = formula check when looping through the shared formula range, to ignore any non-formula cells.

Also refactored a bit to enable passing in the evaluation context, as getCellFormula() uses it behind the scenes when evaluating a shared formula cell (has to shift the formula references based on the master cell).  Review of these changes is welcome, as always.

Checked all other code referencing the "SHARED" enum, and didn't see anything else that dealt with formula cell values and thus would need to notice non-formula cells.

Added unit test based on the failing file from Bugzilla.  Test failed until the fixed code was in place.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1844295 13f79535-47bb-0310-9956-ffa450edef68
2018-10-19 01:11:47 +00:00
Yegor Kozlov
c7111f562c Bug 62373: Support for FREQUENCY function
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1844238 13f79535-47bb-0310-9956-ffa450edef68
2018-10-18 13:46:04 +00:00
Nick Burch
290e9c4087 #62831 Fix WorkbookFactory.create with a subclass of File, eg from JFileChooser
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1844116 13f79535-47bb-0310-9956-ffa450edef68
2018-10-17 14:24:59 +00:00
Nick Burch
ba71f90c32 Failing unit test for bug #62831
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1844115 13f79535-47bb-0310-9956-ffa450edef68
2018-10-17 14:20:02 +00:00
Alain Béarez
5a53f36391 fix more LGTM alerts, in tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1843557 13f79535-47bb-0310-9956-ffa450edef68
2018-10-11 14:50:27 +00:00
Tim Allison
fcbed10cfc 62815 -- some numeric values not correctly extracted from xlsb
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1843553 13f79535-47bb-0310-9956-ffa450edef68
2018-10-11 14:14:07 +00:00
Alain Béarez
ead92fbe9a fix most alerts reported by LGTM on OOXML
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1843481 13f79535-47bb-0310-9956-ffa450edef68
2018-10-10 17:49:53 +00:00
PJ Fanning
94168f60c6 [bug-62807] fix typo in XSLFTableCell#removeBorder
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1843180 13f79535-47bb-0310-9956-ffa450edef68
2018-10-08 18:38:19 +00:00
PJ Fanning
9f106fe8ec add stax entries to forbidden apis due to android issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1843009 13f79535-47bb-0310-9956-ffa450edef68
2018-10-06 09:38:58 +00:00
PJ Fanning
5baa52f86e small adjustments to byte sizes in TestPackage zip-bomb tests to try fix test that fails on old-xerces harness
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842980 13f79535-47bb-0310-9956-ffa450edef68
2018-10-05 20:17:39 +00:00
PJ Fanning
88fd68050f use jaxp transformer instead of dom serializer to try fix old-xerces test failure
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842979 13f79535-47bb-0310-9956-ffa450edef68
2018-10-05 20:09:45 +00:00
PJ Fanning
268c9230cd use jaxp transformer instead of dom serializer to try fix old-xerces test failure
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842974 13f79535-47bb-0310-9956-ffa450edef68
2018-10-05 19:52:24 +00:00
Alain Béarez
b326a5cd01 adding tricks from other answers on StackOverflow
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842959 13f79535-47bb-0310-9956-ffa450edef68
2018-10-05 18:07:55 +00:00
Alain Béarez
c66af5c21e example from StackOverflow question 47065690
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842925 13f79535-47bb-0310-9956-ffa450edef68
2018-10-05 14:36:18 +00:00
Alain Béarez
01b780666b more XDDF improvements based on SO examples
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842876 13f79535-47bb-0310-9956-ffa450edef68
2018-10-05 09:59:32 +00:00
PJ Fanning
01ad2f9d1a [bug-62800] Fix null pointer exception if a picture shape has no blip id
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842782 13f79535-47bb-0310-9956-ffa450edef68
2018-10-04 07:47:27 +00:00
Alain Béarez
5430141cfb XDDF improvements based on StackOverflow examples
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842728 13f79535-47bb-0310-9956-ffa450edef68
2018-10-03 14:32:34 +00:00
Alain Béarez
6673fe7ad1 fix lgtm alerts in examples
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842707 13f79535-47bb-0310-9956-ffa450edef68
2018-10-03 11:51:41 +00:00
Alain Béarez
e88fc19ca4 change chart data to experiment diverse scripts
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842687 13f79535-47bb-0310-9956-ffa450edef68
2018-10-03 08:20:50 +00:00
PJ Fanning
f3a1ed5a45 deprecate unused Nullable class
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842684 13f79535-47bb-0310-9956-ffa450edef68
2018-10-03 07:42:33 +00:00
PJ Fanning
6b4094650f change method to get XMLEventFactory due to issues seen on Android SDK
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842683 13f79535-47bb-0310-9956-ffa450edef68
2018-10-03 07:36:12 +00:00
PJ Fanning
ef397c0158 rename xmlbeans job
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842663 13f79535-47bb-0310-9956-ffa450edef68
2018-10-02 22:24:09 +00:00
PJ Fanning
46b1833bfc [bug-62796] remove use of Stax Namespace class from PackagePropertiesMarshaller
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842647 13f79535-47bb-0310-9956-ffa450edef68
2018-10-02 19:16:00 +00:00
Alain Béarez
72d02f0c1c extract valuable code from 54470 submitted patch
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842548 13f79535-47bb-0310-9956-ffa450edef68
2018-10-01 19:27:32 +00:00
PJ Fanning
11dee9b086 use StaxHelper to get event factory
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842402 13f79535-47bb-0310-9956-ffa450edef68
2018-09-30 18:14:46 +00:00
PJ Fanning
4833c25d32 lgtm issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842302 13f79535-47bb-0310-9956-ffa450edef68
2018-09-29 09:33:52 +00:00
PJ Fanning
00715c8d89 fix lgtm issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842218 13f79535-47bb-0310-9956-ffa450edef68
2018-09-28 07:48:29 +00:00
PJ Fanning
500c64e657 fix lgtm issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842216 13f79535-47bb-0310-9956-ffa450edef68
2018-09-28 07:33:59 +00:00
PJ Fanning
e505160716 make OPCPackage#close() unsynchronized and add javadoc note saying method is not thread-safe
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842171 13f79535-47bb-0310-9956-ffa450edef68
2018-09-27 21:22:24 +00:00
PJ Fanning
5c1a036de2 [bug-62768] synchronize OPCPackage#close()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842142 13f79535-47bb-0310-9956-ffa450edef68
2018-09-27 19:06:06 +00:00
PJ Fanning
19baa76652 [bug-62736] Relations on XSLFPictureShape are removed unconditionally. Thanks to Mate Borcsok
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842055 13f79535-47bb-0310-9956-ffa450edef68
2018-09-26 21:42:21 +00:00
Alain Béarez
e159d4e179 adapting some contributions by Axel Richter on SO
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1841988 13f79535-47bb-0310-9956-ffa450edef68
2018-09-26 00:30:33 +00:00
PJ Fanning
6af2173f93 fix javadoc
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1841987 13f79535-47bb-0310-9956-ffa450edef68
2018-09-25 22:36:36 +00:00
PJ Fanning
7c243f3d76 lgtm warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1841984 13f79535-47bb-0310-9956-ffa450edef68
2018-09-25 22:07:56 +00:00