Dominik Stadler
328c52aab7
Fix some cases where file handles are not closed in OldExcelExtractor
...
Close resources in some more tests to make the file-leak report clean again
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737487 13f79535-47bb-0310-9956-ffa450edef68
2016-04-02 11:01:43 +00:00
Dominik Stadler
0888ad4de5
Fix some compiler warnings, improve error message, cover some more code
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737013 13f79535-47bb-0310-9956-ffa450edef68
2016-03-29 15:45:04 +00:00
Andreas Beeker
f8767e3981
some zips can't be opened via ZipFile in JDK6, as the central directory
...
contains either non-latin entries or the compression type can't be handled
the workaround is to iterate over the stream and not the directory
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736933 13f79535-47bb-0310-9956-ffa450edef68
2016-03-28 22:49:45 +00:00
Nick Burch
197458b30c
One final invalid file type check
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735071 13f79535-47bb-0310-9956-ffa450edef68
2016-03-15 12:37:01 +00:00
Nick Burch
7112835d90
Before opening an OOXML file, check the first few bytes, and give helpful exceptions for common mistakes
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735069 13f79535-47bb-0310-9956-ffa450edef68
2016-03-15 12:30:45 +00:00
Nick Burch
4d7955d6b5
Start to give more helpful Exceptions from OPCPackage when non-OOXML files are passed to it
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735060 13f79535-47bb-0310-9956-ffa450edef68
2016-03-15 11:50:57 +00:00
Andreas Beeker
3a328aa220
#57031 - Out of Memory when extracting text from attached files
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734182 13f79535-47bb-0310-9956-ffa450edef68
2016-03-09 00:41:02 +00:00
Dominik Stadler
0a3370347e
Fix freeing resources in some tests and dev-tools so we can run unit-tests with enabled file-leak-detector
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721468 13f79535-47bb-0310-9956-ffa450edef68
2015-12-22 22:35:59 +00:00
Uwe Schindler
73a8488838
#58597 : Fix tests to not do setAccessible(), add some doPrivileged, too.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713891 13f79535-47bb-0310-9956-ffa450edef68
2015-11-11 16:57:39 +00:00
Andreas Beeker
9b4919cd51
extended forbidden-apis-check to ooxml-tests
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712693 13f79535-47bb-0310-9956-ffa450edef68
2015-11-05 00:15:51 +00:00
Dominik Stadler
1e45197f59
* Adjust reported text when a Zip-Bomb is detected to allow to quickly see why it happened
...
* Fail only with inflation ratio lower than the min, not equals, to behave as documented
* Add getters to be able to temporarily adjust the limits for unit tests
* Allow lower inflation ratio in OOXMLPrettyPrint as this is a dev-only tool
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696556 13f79535-47bb-0310-9956-ffa450edef68
2015-08-19 10:57:19 +00:00
Dominik Stadler
efc96e1d8e
Open file read-only in test to avoid making it dirty during running unit tests
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1688045 13f79535-47bb-0310-9956-ffa450edef68
2015-06-28 19:55:56 +00:00
Dominik Stadler
bde247f61a
Fix test to find the exception-text in all cases
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1687212 13f79535-47bb-0310-9956-ffa450edef68
2015-06-24 08:53:25 +00:00
Dominik Stadler
5103ea7c0c
show full exception stack-trace if zip-bomb detection test fails
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1687197 13f79535-47bb-0310-9956-ffa450edef68
2015-06-24 08:33:06 +00:00
Andreas Beeker
c0cb680292
Bug 56865 - Limit number of bytes (by counting them) while opening office docs
...
Bug 50090 - 'zip' bomb prevention
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1687148 13f79535-47bb-0310-9956-ffa450edef68
2015-06-23 23:39:07 +00:00
Dominik Stadler
5c76ccba5b
Add missing close() of resources in both production code and tests
...
Use revert() instead of close() on OCPPackage in some places to not re-write the file unnecessarily.
This should now run tests without leftover file handles when checked with file leak detector and
allows to find newly introduced cases more easily.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648160 13f79535-47bb-0310-9956-ffa450edef68
2014-12-28 09:16:57 +00:00
Uwe Schindler
eabb6a924b
More cleanups for bug #56814 and some more external entity leaks of #56164
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1617849 13f79535-47bb-0310-9956-ffa450edef68
2014-08-13 22:34:53 +00:00
Uwe Schindler
2f5bcfd162
Fix bug #56814 - Switch from dom4j to JAXP
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1617428 13f79535-47bb-0310-9956-ffa450edef68
2014-08-12 07:19:51 +00:00
Nick Burch
4c98f1db45
Patch from Raúl Wegmann from bug #56735 / GitHub Pull #10 - Rationalise POI temp file creation to the TempFile util class, and allow a system wide setting of where Temp files (eg for SXSSF) go, via TempFile / TempFileCreationStrategy
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613246 13f79535-47bb-0310-9956-ffa450edef68
2014-07-24 18:58:27 +00:00
Nick Burch
d72bd78c19
Fix bug #56164 - Tidy up the OPC SAX setup code with a new common Helper
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1569991 13f79535-47bb-0310-9956-ffa450edef68
2014-02-19 23:54:46 +00:00
Nick Burch
2f0107bb4e
Where possible, allow fetching of the size of the OPC Package Part (-1 if not)
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1482647 13f79535-47bb-0310-9956-ffa450edef68
2013-05-15 00:27:59 +00:00
Yegor Kozlov
c0e87067e6
Bugzilla 51780 - support replacement of content types in OPC packages
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1294998 13f79535-47bb-0310-9956-ffa450edef68
2012-02-29 07:50:10 +00:00
Yegor Kozlov
7c8f56ce1c
bug 51265: Enhanced Handling of Picture Parts in XWPF
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1130120 13f79535-47bb-0310-9956-ffa450edef68
2011-06-01 12:07:16 +00:00
Yegor Kozlov
2a9019985f
added ZipFileAssert, this file was in the original OpenXML4J package but wasn't included in POI-3.5
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@992551 13f79535-47bb-0310-9956-ffa450edef68
2010-09-04 06:33:22 +00:00
Yegor Kozlov
c9a7354786
close OPC package before assertion, otherwise the test fails on Win7 (unix-based systems always pass)
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@982911 13f79535-47bb-0310-9956-ffa450edef68
2010-08-06 09:03:32 +00:00
Nick Burch
3c4946472b
Improve handling and warnings when closing OPCPackage objects
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@982311 13f79535-47bb-0310-9956-ffa450edef68
2010-08-04 15:58:51 +00:00
Yegor Kozlov
a584c030ff
removed log4j calls from ooxml tests, also fixed misc bugs discovered when imlementing OOXMLLite
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@880799 13f79535-47bb-0310-9956-ffa450edef68
2009-11-16 15:33:45 +00:00
Yegor Kozlov
bd966f208b
removed unnecessary svn:executable flag from files in SVN trunk, see bugzilla 47734
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@814335 13f79535-47bb-0310-9956-ffa450edef68
2009-09-13 16:05:28 +00:00
Josh Micich
995d8fe73f
Fixed unused imports compiler warnings (and some others)
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@805262 13f79535-47bb-0310-9956-ffa450edef68
2009-08-18 02:41:45 +00:00
Yegor Kozlov
0f1f7d1d48
fixed compatibility issues with OpenOffice 3.0 and Excel 2008 Mac sp2, see Bugzilla #46419 and #47559
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@797350 13f79535-47bb-0310-9956-ffa450edef68
2009-07-24 07:29:22 +00:00
Yegor Kozlov
26f18ed27a
fixed XSSF and OpenXml4J to read/write relationships with targets starting with '#' (internal locations), see Bugzilla 47504
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@793280 13f79535-47bb-0310-9956-ffa450edef68
2009-07-12 07:18:42 +00:00
Josh Micich
67196db87e
Renamed Package (in org.apache.poi.openxml4j.opc) to OPCPackage so as to avoid clash with java.lang.Package (see bugzilla 46859)
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@755699 13f79535-47bb-0310-9956-ffa450edef68
2009-03-18 18:54:01 +00:00
Josh Micich
e6472ffac4
Improvements to OpenXML4J unit tests. Fixed class names. Refactored code for opening test data files. Changed test output to go to temp dir.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@741002 13f79535-47bb-0310-9956-ffa450edef68
2009-02-05 05:07:23 +00:00
Yegor Kozlov
ef4b2ebc2e
import OpenXML4j codebase
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@738842 13f79535-47bb-0310-9956-ffa450edef68
2009-01-29 12:44:31 +00:00