Commit Graph

1706 Commits

Author SHA1 Message Date
Javen O'Neal
31f2b5fdd1 bug 59783: replace deprecated Hyperlink.LINK_* and Hyperlink.getType usage
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753040 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 09:32:29 +00:00
Dominik Stadler
16b0c380c9 Bug 59665: Using HSSFWorkbook#setSheetOrder to move sheets to the end corrupts bspos value in WorkbookRecordList
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753038 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 09:27:07 +00:00
Javen O'Neal
4ba3ed06fc bug 59775: fix cell address index error
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753011 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 04:59:12 +00:00
Javen O'Neal
44199a8ecd bug 59872: add Sheet.getHyperlink(CellAddress)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753009 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 04:41:20 +00:00
Dominik Stadler
af2a99b910 Apply patch to fix bug 59740: Sheet.shiftRows incorrectly shifts merged region on exists merged region
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752997 13f79535-47bb-0310-9956-ffa450edef68
2016-07-16 20:52:39 +00:00
Dominik Stadler
ae7ef11c88 Bug 59861: Adjust testcase, it works now for me. Also combine the two TestProper classes into one
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752861 13f79535-47bb-0310-9956-ffa450edef68
2016-07-15 18:24:02 +00:00
Dominik Stadler
aec95a4491 Function PROPER: Don't use a regular expression syntax that is not available on Android. Actually the use of regular expression in this case was overkill, slow and even incorrect in corner cases, the function can be done without regex easily and runs a bit faster anyway (microBench is down from 4sec to 2s)
Also added a unit-test to ensure the behavior stays the same (except in cases where it needed fixing, e.g. some toUppercase() leads to more than one character which was handled incorrectly)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752779 13f79535-47bb-0310-9956-ffa450edef68
2016-07-15 06:32:45 +00:00
Javen O'Neal
75f5d3afc5 bug 59858: describe why VBA macro reading failed
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752778 13f79535-47bb-0310-9956-ffa450edef68
2016-07-15 06:12:37 +00:00
Javen O'Neal
bb8f614a90 bug 59858: add disabled unit test for bug 59858; file from Brooke
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752776 13f79535-47bb-0310-9956-ffa450edef68
2016-07-15 05:28:29 +00:00
Javen O'Neal
c541e0a16f add BaseTestCellUtil unit tests to cover setting cell style properties with an invalid value and using both valid Short and Enum values
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752079 13f79535-47bb-0310-9956-ffa450edef68
2016-07-10 11:37:22 +00:00
Javen O'Neal
2ec6b12e13 bug 59837: update CellUtil to handle VerticalAlignment and HorizontalAlignment enums
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752077 13f79535-47bb-0310-9956-ffa450edef68
2016-07-10 11:18:55 +00:00
Javen O'Neal
909c07f37f bug 59830: add context to why no more bytes could be read from input stream
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751982 13f79535-47bb-0310-9956-ffa450edef68
2016-07-09 05:39:56 +00:00
Javen O'Neal
3092c1121e bug 55555: set fill pattern, foreground color, and background color order correctly to follow HSSFCellStyle's order requirement; patch from Qualtagh. This closes #33 on Github
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751955 13f79535-47bb-0310-9956-ffa450edef68
2016-07-08 18:45:15 +00:00
Javen O'Neal
bb7da64c25 add crude line-coverage tests for setDebugEvaluationOutputForNextEval and setIgnoreMissingWorkbooks
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751841 13f79535-47bb-0310-9956-ffa450edef68
2016-07-07 23:00:07 +00:00
Javen O'Neal
140b11bc7a bug 59805: tearDown should reset, not set, the LocaleUtil ThreadLocals (also avoid memory leaks)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751741 13f79535-47bb-0310-9956-ffa450edef68
2016-07-07 02:09:25 +00:00
Javen O'Neal
1766825f62 bug 59805: add LocaleUtil#resetUserTimeZone and #resetUserLocale methods that call ThreadLocal.remove to fix PermGen memory leaks for long-running threaded applications; patch from apptaro
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751641 13f79535-47bb-0310-9956-ffa450edef68
2016-07-06 09:23:34 +00:00
Javen O'Neal
83e27bd10c bug 59805: add unit test for LocaleUtil#getLocaleCalendar
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751629 13f79535-47bb-0310-9956-ffa450edef68
2016-07-06 08:52:40 +00:00
Javen O'Neal
076b9b600d bug 59805: add unit test for LocaleUtil
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751620 13f79535-47bb-0310-9956-ffa450edef68
2016-07-06 08:12:08 +00:00
Dominik Stadler
6784574ea2 Add a unit-test to verify that DataFormatter.formatCellValue() does format formula-results correctly
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751400 13f79535-47bb-0310-9956-ffa450edef68
2016-07-05 07:24:14 +00:00
Javen O'Neal
268c5deeb2 bug 59791: FormulaEvaluator#evaluateFormulaCell(Cell) should return an integer for backwards compatibility
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751261 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 12:21:42 +00:00
Javen O'Neal
034d3cfcca bug 59791: getCellType and getCachedFormulaResultType should return an integer for backwards compatibility
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751256 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 11:54:20 +00:00
Javen O'Neal
fba65665fb reorganize imports (remove unused imports, sort alphabetically)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751244 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 10:38:25 +00:00
Javen O'Neal
64ef8e26a3 bug 59791: replace deprecated Cell.CELL_TYPE_* usage with CellType.*
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751240 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 10:15:18 +00:00
Javen O'Neal
d1d6ea97fb bug 59791: convert Cell Type to an enum
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751237 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 09:45:46 +00:00
Javen O'Neal
d358c2a0ab bug 59789: move HSSFComment shifting due to rowShift outside of for-loop for performance
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751198 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 03:06:11 +00:00
Javen O'Neal
f972e1c6e4 bug 59166: suggest alternative implementations for TempFileCreationStrategy
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751190 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 01:07:52 +00:00
Javen O'Neal
569db169dd bug 59788: move DefaultTempFileCreationStrategy from TempFile inner class to its own class
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751185 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 00:00:20 +00:00
Javen O'Neal
c54deaf3ff uncomment ignored unit tests so they at least compile
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751178 13f79535-47bb-0310-9956-ffa450edef68
2016-07-03 22:59:41 +00:00
Javen O'Neal
0e118a7b6d bug 59788: create temporary directories
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751177 13f79535-47bb-0310-9956-ffa450edef68
2016-07-03 22:58:06 +00:00
Andreas Beeker
1781e9d83f deprecated DrawingManager
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751175 13f79535-47bb-0310-9956-ffa450edef68
2016-07-03 22:21:55 +00:00
Andreas Beeker
8e84226202 #59170 - Remove deprecated classes (POI 3.15) - o.a.p.hssf.model.*Shape classes removed
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751174 13f79535-47bb-0310-9956-ffa450edef68
2016-07-03 21:54:17 +00:00
Javen O'Neal
4ab0e89901 bug 59781: promote to Common SS: move PaneInformation from o.a.p.hssf.util to o.a.p.ss.util
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751044 13f79535-47bb-0310-9956-ffa450edef68
2016-07-02 09:00:13 +00:00
Andreas Beeker
6eab79528b a few performance fixes to speed-up the tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1750867 13f79535-47bb-0310-9956-ffa450edef68
2016-06-30 22:59:46 +00:00
Andreas Beeker
099f63d054 deprecated constants pointing to MissingCellPolicy - use enum instead
javadocs fixes (jdk8)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1750172 13f79535-47bb-0310-9956-ffa450edef68
2016-06-24 23:31:12 +00:00
Javen O'Neal
fd1a23361b bug 59748: replace Hashtable with HashMap; contributed by Axel Howind
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1750168 13f79535-47bb-0310-9956-ffa450edef68
2016-06-24 21:39:44 +00:00
Javen O'Neal
0f3a7b24b4 bug 56781: make Name#validateName compatible on Java 6 (no Regex \p{IsAlphabetic} metaclasses
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749305 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 11:27:40 +00:00
Javen O'Neal
d23e77fcf5 remove commented out @Ignore
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749294 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 10:32:21 +00:00
Javen O'Neal
b617f3ccec bug 56781: disallow names with symbols, except underscore, period, and backslash
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749293 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 10:27:52 +00:00
Javen O'Neal
3881a0db31 bug 57929: add disabled unit test, adapted from nova
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749270 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 07:15:09 +00:00
Javen O'Neal
7929adbf80 whitespace (tabs to 4 spaces)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749264 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 04:21:26 +00:00
Javen O'Neal
57e9abb8d1 parameterize raw generics
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749260 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 03:50:30 +00:00
Javen O'Neal
ce8b8ea7ab bug 59730: promote XSSFSheet#removeMergedRegions to Sheet interface
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749258 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 03:40:32 +00:00
Javen O'Neal
2804197bdb bug 56454: add disabled unit test based on Jörg Selbach's test case showing shiftRows incorrectly handles merged regions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749246 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 01:44:44 +00:00
Javen O'Neal
8c6c7783d6 mv o.a.p.hssf.record.cf.CellRangeUtil o.a.p.ss.util.CellRangeUtil
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749240 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 00:25:29 +00:00
Javen O'Neal
e205422d39 bug 56454: add CellRangeAddress#containsRow and containsColumn
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749239 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 00:16:41 +00:00
Javen O'Neal
e08786d49e convert TestCellRangeAddress from junit3 to junit4
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749237 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 00:00:41 +00:00
Javen O'Neal
ebd55552bf bug 59728: add disabled unit test: should not be able to add an array formula to merged region
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749225 13f79535-47bb-0310-9956-ffa450edef68
2016-06-19 22:51:01 +00:00
Nick Burch
7da9b2cd67 #59724 Take advantage of all POIDocument classes being Closeable to tidy the OLE2 text extractor closing
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749214 13f79535-47bb-0310-9956-ffa450edef68
2016-06-19 22:13:41 +00:00
Javen O'Neal
492aac4e73 bug 56958: patch from Yaniv Kunda: check that cells containing array formulas do not belong to a merged region
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749210 13f79535-47bb-0310-9956-ffa450edef68
2016-06-19 22:00:44 +00:00
Javen O'Neal
895bcab9f9 bug 59645: add Page Setup Print row and column headings support for Common SS
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749191 13f79535-47bb-0310-9956-ffa450edef68
2016-06-19 18:20:23 +00:00