Commit Graph

1494 Commits

Author SHA1 Message Date
Javen O'Neal
2354bbb0b0 supporting changes for bug 58452: copy cell formulas containing unregistered function names
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711600 13f79535-47bb-0310-9956-ffa450edef68
2015-10-31 11:39:01 +00:00
Javen O'Neal
043a86e243 bug 58443: prevent corrupted workbooks by checking for overlapping merged regions before adding a merged region to a sheet; fix unit tests that produced corrupt workbooks; remove deprecated HSSFSheet#addMergedRegion(Region)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711586 13f79535-47bb-0310-9956-ffa450edef68
2015-10-31 10:22:19 +00:00
Dominik Stadler
50baa731d3 Add a limit of the max number of characters that can be extracted to avoid sending applications out of memory with very large documents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711520 13f79535-47bb-0310-9956-ffa450edef68
2015-10-30 17:26:37 +00:00
Nick Burch
fa5fc2e65e Javadoc fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711197 13f79535-47bb-0310-9956-ffa450edef68
2015-10-29 09:28:38 +00:00
Javen O'Neal
1396738460 bug 58557: fix from Alessandro Guarascio, shift hyperlinks when shifting rows on an XSSFSheet
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711185 13f79535-47bb-0310-9956-ffa450edef68
2015-10-29 06:53:55 +00:00
Andreas Beeker
1d1bdc1521 Common sl unification - copy first paragraph / textrun properties on XSLFTextShape.setText()
Common sl unification - converted ApacheconEU08 example to common sl - added missing functionality
Common sl unification - return null instead of default values for missing borders X/HSLFTable
Common sl unification - use points in HSLFTable.setColumnWidth()
Fix appending text to empty HSLFTextParagraph


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711171 13f79535-47bb-0310-9956-ffa450edef68
2015-10-29 01:05:27 +00:00
Nick Burch
632228a34e #58558 SXSSFCell.setCellValue((RichTextString)null) fixed to work like XSSF and HSSF, with common unit tests to verify this
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711082 13f79535-47bb-0310-9956-ffa450edef68
2015-10-28 17:42:56 +00:00
Dominik Stadler
856bbf97f4 Fix Sonar-Maven build, correctly determine path to test-file
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710694 13f79535-47bb-0310-9956-ffa450edef68
2015-10-26 20:48:38 +00:00
Dominik Stadler
f1f08de7fb Apply some micro-optimization which helps when retrieving the string-value of large spreadsheets
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710692 13f79535-47bb-0310-9956-ffa450edef68
2015-10-26 20:48:32 +00:00
Dominik Stadler
c7ebebcbb1 Bug 56957: Avoid error if Workbook with empty SharedStringTable is written
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710521 13f79535-47bb-0310-9956-ffa450edef68
2015-10-26 07:54:06 +00:00
Nick Burch
90db0bf451 Fix javadoc warning - @see with a URL needs wrapping in an a-href tag
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710460 13f79535-47bb-0310-9956-ffa450edef68
2015-10-25 16:19:35 +00:00
Nick Burch
e966499ad2 #58532 For Excel cell formats with 3+ parts to them (eg +ve,-ve,0), which
DataFormatter didn't properly support, call out to the alternate CellFormat
 instead for the formatting.
This also allows us to enable some disabled parts of DataFormatter unit tests
We still need to rationalise DataFormatter and CellFormatter though, so we
 only have one set of cell formatting logic...


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710399 13f79535-47bb-0310-9956-ffa450edef68
2015-10-24 23:34:47 +00:00
Javen O'Neal
538b2d1377 bug 33174: Use common unit test for testNoMergedRegionsIsEmptyList
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710140 13f79535-47bb-0310-9956-ffa450edef68
2015-10-23 08:38:14 +00:00
Dominik Stadler
27d4814b80 Set newer curvesapi-version in .classpath as well and update some third-party libs for the password-protection-code to the latest versions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710032 13f79535-47bb-0310-9956-ffa450edef68
2015-10-22 15:21:25 +00:00
Dustin Spicuzza
fe771aa808 XDGF: fix the fix
- Use Collections.emptySet() for an iterator instead
- Bump curvesapi to 1.03, which is compiled for JDK 1.5

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709463 13f79535-47bb-0310-9956-ffa450edef68
2015-10-19 18:36:45 +00:00
Dustin Spicuzza
9c23e12b8e XDGF: fix jdk < 1.8 compat
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709427 13f79535-47bb-0310-9956-ffa450edef68
2015-10-19 14:55:30 +00:00
Dustin Spicuzza
f540622a05 XDGF: fix jenkins build errors
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709363 13f79535-47bb-0310-9956-ffa450edef68
2015-10-19 06:55:06 +00:00
Dustin Spicuzza
e0a5e102b8 Add Visio OOXML text extractor + tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709361 13f79535-47bb-0310-9956-ffa450edef68
2015-10-19 06:26:57 +00:00
Dustin Spicuzza
879ca64994 Add some limited XDGF documentation
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709357 13f79535-47bb-0310-9956-ffa450edef68
2015-10-19 06:08:58 +00:00
Dustin Spicuzza
e3365dfaeb poi-import: fix build dependencies
- Compilation + tests work now

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709356 13f79535-47bb-0310-9956-ffa450edef68
2015-10-19 05:59:42 +00:00
Dustin Spicuzza
d70b8e8b88 poi-visio import: reformat code to fit project standards, remove JRE 7isms
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709355 13f79535-47bb-0310-9956-ffa450edef68
2015-10-19 05:59:37 +00:00
Dustin Spicuzza
3bd2011924 Import poi-visio codebase
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709354 13f79535-47bb-0310-9956-ffa450edef68
2015-10-19 05:52:35 +00:00
Dominik Stadler
3a8f40db7c Bug 58499: Don't report Zip-Bomb for small files which should not cause memory issues anyway
Also make error message a bit more specific and list classname in Zip-Bomb-Error to make it easier for users what the
problem is and how to find out where the static methods are

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709180 13f79535-47bb-0310-9956-ffa450edef68
2015-10-17 14:40:36 +00:00
Dominik Stadler
43ab1cd35a Use the default XmlOptions for all the invocations of the XmlBeans XML parsing
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709128 13f79535-47bb-0310-9956-ffa450edef68
2015-10-17 08:45:25 +00:00
David North
bb18031ac7 Remove unnecessary warning suppressions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1708921 13f79535-47bb-0310-9956-ffa450edef68
2015-10-16 09:00:43 +00:00
Andreas Beeker
a0a197bc96 javadoc fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1708265 13f79535-47bb-0310-9956-ffa450edef68
2015-10-12 23:10:02 +00:00
Andreas Beeker
5fd71db914 - removed deprecated and confusing methods in XSSFColor
- sonar fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1708236 13f79535-47bb-0310-9956-ffa450edef68
2015-10-12 20:43:42 +00:00
Dominik Stadler
7fbf591db5 Retry which measures duration a few times to see if that reduces the number of failures caused by this test sometimes when CI machines are loaded.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1707488 13f79535-47bb-0310-9956-ffa450edef68
2015-10-08 11:08:41 +00:00
Dustin Spicuzza
bf68d5f290 Bug 58048: Add visio schemas to the OOXML jar
- Bumped OOXML jar version also

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1707177 13f79535-47bb-0310-9956-ffa450edef68
2015-10-07 02:41:30 +00:00
Andreas Beeker
62561d5f53 sonar fixes and closing resources after use
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706937 13f79535-47bb-0310-9956-ffa450edef68
2015-10-06 00:04:12 +00:00
David North
2dc93d4411 Fix for https://bz.apache.org/bugzilla/show_bug.cgi?id=58466
ColumnHelper now preserves information on multiple changes to the same group, hopefully while preserving the faster implementation intended by the original patch.

NB changes to TestXSSFSheet: the behaviour of column group collapsing/expanding is now closer to what Excel does than before.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706789 13f79535-47bb-0310-9956-ffa450edef68
2015-10-05 10:31:33 +00:00
Andreas Beeker
eee32c0480 fixed sonar issues and eclipse warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706742 13f79535-47bb-0310-9956-ffa450edef68
2015-10-05 00:28:54 +00:00
Andreas Beeker
98e93217fe sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706648 13f79535-47bb-0310-9956-ffa450edef68
2015-10-04 00:35:30 +00:00
Andreas Beeker
2de9d527b4 sonar fixes
Very interesting was the exception swallowing in PackagePropertiesPart. When it was properly thrown, it already led to various errors in the junits test - I've fixed the handling for at least the ones which are in our test set

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706169 13f79535-47bb-0310-9956-ffa450edef68
2015-09-30 23:06:39 +00:00
Dominik Stadler
9deb59f263 Verify that bug 51998 is actually fixed since some time already.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1705855 13f79535-47bb-0310-9956-ffa450edef68
2015-09-29 13:09:47 +00:00
Andreas Beeker
ffd1f4333e sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1705814 13f79535-47bb-0310-9956-ffa450edef68
2015-09-29 08:31:15 +00:00
Dominik Stadler
72ae82f7dc Verify that bug 45541 can be resolved, add some more checks in XSLFFileHandler
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1705804 13f79535-47bb-0310-9956-ffa450edef68
2015-09-29 06:08:08 +00:00
Andreas Beeker
6f7f16853e Removed HDF API
Sonar fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1705779 13f79535-47bb-0310-9956-ffa450edef68
2015-09-28 21:26:06 +00:00
Andreas Beeker
5cd3436295 Sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1705587 13f79535-47bb-0310-9956-ffa450edef68
2015-09-27 22:14:25 +00:00
Andreas Beeker
abfe427e72 - a few findbugs/sonar fixes
- removed obsolete openxml4j signature classes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704964 13f79535-47bb-0310-9956-ffa450edef68
2015-09-23 23:22:46 +00:00
David North
c93ded0f36 Make XSSF and HSSF consistent in getMergedRegions - return empty list if there are none, rather than an exception. Tests for this.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58350

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704839 13f79535-47bb-0310-9956-ffa450edef68
2015-09-23 12:53:13 +00:00
Dominik Stadler
5e6b975b1c Ensure that the ThreadLocal-Biff-Password is reset correctly after each usage, we had some unit tests failing sporadically due to this
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704710 13f79535-47bb-0310-9956-ffa450edef68
2015-09-22 19:50:37 +00:00
Andreas Beeker
6488170c6d removed common sl path
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704207 13f79535-47bb-0310-9956-ffa450edef68
2015-09-21 00:16:36 +00:00
Andreas Beeker
dec09d2713 - #58216 - provide picture-shape resize that maintains the aspect ratio
- moved SlideShowFactory to Common SL
- changed get/setAnchor to Rectangle instead of Rectangle2D
- Fixed some Common SL generic definitions
- picture dimensions are now in points and an additional method exists for pixels

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704206 13f79535-47bb-0310-9956-ffa450edef68
2015-09-21 00:09:45 +00:00
Dominik Stadler
d61ea07e26 Bug 58333: Apply patch to verify behavior on row-index before and after the limits set by the specification
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704186 13f79535-47bb-0310-9956-ffa450edef68
2015-09-20 20:16:17 +00:00
Dominik Stadler
f2cd7ed8f5 Bug 58332: Adjust implementation of dev-util 'MemoryUsage' to print out information if limits are reached instead of OOM
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704182 13f79535-47bb-0310-9956-ffa450edef68
2015-09-20 20:05:36 +00:00
Andreas Beeker
f3004e6185 close resources in junit tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704124 13f79535-47bb-0310-9956-ffa450edef68
2015-09-20 12:02:40 +00:00
Andreas Beeker
18395d5c3b - #58207 - Provide user access to the original image dimensions (XSLF)
- same for hslf / common sl
- unify method names in H/XSLF Slideshow for common sl
- add/fix header information for PICT/EMF/WMF

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704097 13f79535-47bb-0310-9956-ffa450edef68
2015-09-20 02:25:35 +00:00
Dominik Stadler
6dda58db90 Apply patch from bug 57890 to add support for different datatypes in XSSFImportFromXML
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1703665 13f79535-47bb-0310-9956-ffa450edef68
2015-09-17 18:30:13 +00:00
Nick Burch
20b44d546e Javadoc fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1703575 13f79535-47bb-0310-9956-ffa450edef68
2015-09-17 11:18:15 +00:00
Nick Burch
9647b62d1a Patch from Javen ONeal from bug #58245 - Make Workbook support iterating over Sheets
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1703573 13f79535-47bb-0310-9956-ffa450edef68
2015-09-17 11:10:11 +00:00
Dominik Stadler
a5918f26fe Update javadoc for bug 56129
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1702805 13f79535-47bb-0310-9956-ffa450edef68
2015-09-13 19:32:50 +00:00
Dominik Stadler
c6f875fbb9 Eclipse warnings, comment out dead code, close resources, enhance unit tests, javadoc, ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1702802 13f79535-47bb-0310-9956-ffa450edef68
2015-09-13 19:05:55 +00:00
Dominik Stadler
42053fcf71 Verify that bug 55406 can be closed WORKSFORME
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1702800 13f79535-47bb-0310-9956-ffa450edef68
2015-09-13 19:05:28 +00:00
Dominik Stadler
fb88108e30 Add test case for bug 54399
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1702786 13f79535-47bb-0310-9956-ffa450edef68
2015-09-13 14:48:58 +00:00
Andreas Beeker
50777f1e48 fix eclipse warning - mostly generics cosmetics
close resources in tests
junit4 conversions
convert spreadsheet based formular test to junit parameterized tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1702773 13f79535-47bb-0310-9956-ffa450edef68
2015-09-13 12:36:56 +00:00
Andreas Beeker
5f94d8b533 fix eclipse warning - mostly generics cosmetics
close resources in tests
junit4 conversions
convert spreadsheet based formular test to junit parameterized tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1702659 13f79535-47bb-0310-9956-ffa450edef68
2015-09-12 18:45:07 +00:00
Andreas Beeker
aea434a135 forbidden apis fixes - a few DateFormat clean ups ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701888 13f79535-47bb-0310-9956-ffa450edef68
2015-09-09 00:41:03 +00:00
Andreas Beeker
50107cae16 Bug 58326 - Forbidden APIs patches - second set of changes for charset settings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701713 13f79535-47bb-0310-9956-ffa450edef68
2015-09-08 00:04:12 +00:00
Andreas Beeker
91e6a64627 forbidden apis fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701710 13f79535-47bb-0310-9956-ffa450edef68
2015-09-07 22:34:21 +00:00
Andreas Beeker
aaafb0270d Bug 58326 - Forbidden APIs patches - first set of changes for locale and timezone settings
also includes fixes for
- name shadowing 
- unused deprecated method "getClipRect" in classes extending Graphics2d
- HexDump - replaced intermediate String.format calls with custom padding
- convert testcases to junit4
- closing resources

also tested with an arbitary timezone (PST) and locale (ru)

supresses forbidden apis check for
- LocaleUtil (the only place where Locale.getDefault() and TimeZone.getDefault() should be called)
- Classes using FontMetrics - without the actual text it's difficult to return something sane

Some usage of UTC and Locale.ROOT might be still wrong, e.g. in MapiMessage we don't access the
extended mapi properties, which might contain the timezone

DataFormatter has now a Observable property which need to be observed when custom formats are used
and the Locale changes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701688 13f79535-47bb-0310-9956-ffa450edef68
2015-09-07 20:19:50 +00:00
Andreas Beeker
3166646249 Bug 58326 - Forbidden APIs patches - first set of changes for locale and timezone settings
commit single files because of svn failures ...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701684 13f79535-47bb-0310-9956-ffa450edef68
2015-09-07 20:14:33 +00:00
Dominik Stadler
782739541a Bug 58315: Avoid NPE for RichTextString without font-details
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701382 13f79535-47bb-0310-9956-ffa450edef68
2015-09-05 12:57:04 +00:00
Dominik Stadler
b2bd6a0a4c Eclipse warnings, close resources in CommandLineTextExtractor, add try/finally, formatting, ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701139 13f79535-47bb-0310-9956-ffa450edef68
2015-09-03 20:59:14 +00:00
Dominik Stadler
dab5f4c078 Fix bug 53275: reset indexed color flag when setting a non-indexed color
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701134 13f79535-47bb-0310-9956-ffa450edef68
2015-09-03 20:46:23 +00:00
Dominik Stadler
f7e0bdea37 Add unit test which verifies that bug 53105 is actually fixed now
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701133 13f79535-47bb-0310-9956-ffa450edef68
2015-09-03 20:46:14 +00:00
Dominik Stadler
4b8c20a7ca Add unit tests to verify that bug 51626 and bug 51451 are fixed
Conflicts:
	src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFBugs.java

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701132 13f79535-47bb-0310-9956-ffa450edef68
2015-09-03 20:46:04 +00:00
Dominik Stadler
fcfe2e2a71 Add unit tests which verify that the issues from bug 48962 and 50755 do not occur any more on the latest version
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701131 13f79535-47bb-0310-9956-ffa450edef68
2015-09-03 20:45:55 +00:00
Nick Burch
aa455c91fd Fix some Forbidden APIs errors
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700670 13f79535-47bb-0310-9956-ffa450edef68
2015-09-01 21:09:20 +00:00
Nick Burch
47fb9df1a1 Fix some Forbidden APIs errors
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700644 13f79535-47bb-0310-9956-ffa450edef68
2015-09-01 19:06:53 +00:00
Nick Burch
533e1c8dcb Fix some Forbidden APIs errors
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700642 13f79535-47bb-0310-9956-ffa450edef68
2015-09-01 19:01:36 +00:00
Nick Burch
f098eca5a0 Fix some Forbidden APIs errors
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700635 13f79535-47bb-0310-9956-ffa450edef68
2015-09-01 18:37:07 +00:00
Dominik Stadler
6bdc2fb024 Add possibility to set zoomPercent for XWPFDocument
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1697992 13f79535-47bb-0310-9956-ffa450edef68
2015-08-26 19:34:28 +00:00
Andreas Beeker
cd536720dd common sl: reworked and unified generics definitions
made various methods available through common sl
added createTextBox,AutoShape,... methods to ShapeContainers
hslf tables created by poi, will be identified as such when the file is read again

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1697515 13f79535-47bb-0310-9956-ffa450edef68
2015-08-24 23:15:14 +00:00
Nick Burch
0d7476e130 Tweak error message to make clear that we really need a file showing the problem
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1697502 13f79535-47bb-0310-9956-ffa450edef68
2015-08-24 21:20:01 +00:00
Nick Burch
d662021baf Javadoc tweak
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1697462 13f79535-47bb-0310-9956-ffa450edef68
2015-08-24 17:55:57 +00:00
Dominik Stadler
639b847d6e Reduce required memory in tests by not actually creating all the rows/cells when verifying the max number of cellstyles. Hopefully this will avoid the OOMs that we see in various CI environments currently while still verifying the limits correctly.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1697326 13f79535-47bb-0310-9956-ffa450edef68
2015-08-24 08:12:01 +00:00
Dominik Stadler
39163eccff Eclipse warnings, code formatting, missing @Overrides, Javadoc, missing close(), ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696794 13f79535-47bb-0310-9956-ffa450edef68
2015-08-20 14:28:39 +00:00
Dominik Stadler
c275dea88c POI Bug 58260: Fix checks for limit on number of styles in XSSF/SXSSF and fix having more than 32k styles in SXSSF workbooks
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696586 13f79535-47bb-0310-9956-ffa450edef68
2015-08-19 13:36:08 +00:00
Dominik Stadler
580171fe27 Adjust excludes to make the output a bit cleaner in OOXMLLite and also look in the superclass for @Test annotations to include one additional unit-test that we missed currently.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696577 13f79535-47bb-0310-9956-ffa450edef68
2015-08-19 13:03:05 +00:00
David North
2af2fa28c2 Improve ReadOnlySharedStringsTable to cope gracefully with an empty SST part.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58262

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696559 13f79535-47bb-0310-9956-ffa450edef68
2015-08-19 11:10:13 +00:00
Dominik Stadler
1e45197f59 * Adjust reported text when a Zip-Bomb is detected to allow to quickly see why it happened
* Fail only with inflation ratio lower than the min, not equals, to behave as documented
* Add getters to be able to temporarily adjust the limits for unit tests
* Allow lower inflation ratio in OOXMLPrettyPrint as this is a dev-only tool

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696556 13f79535-47bb-0310-9956-ffa450edef68
2015-08-19 10:57:19 +00:00
David North
5706c2ac9b Make intersection formulae work in XSSF. Patch from Matt Hillsdon plus additional tests.
https://bz.apache.org/bugzilla/show_bug.cgi?id=52111

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696549 13f79535-47bb-0310-9956-ffa450edef68
2015-08-19 10:10:08 +00:00
Dominik Stadler
0377dbbb3e Bug 54938: Throw InvalidFormatException as documented instead of IllegalArgumentException in WorkbookFactory.create()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696338 13f79535-47bb-0310-9956-ffa450edef68
2015-08-17 20:54:32 +00:00
Dominik Stadler
0345110611 Try to make Sonar builds run again: add missing dependency, add ooxml-schema-security, don't depend on dir test-data and build-directory directly, don't override a POILogger that is set via System Properties
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696165 13f79535-47bb-0310-9956-ffa450edef68
2015-08-16 20:51:40 +00:00
Andreas Beeker
05c92b7a19 FindBugs - DLS_DEAD_LOCAL_STORE
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696038 13f79535-47bb-0310-9956-ffa450edef68
2015-08-15 11:57:57 +00:00
Nick Burch
6be4fc05d2 Remove catches which were previously incorrectly declared when not needed
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695775 13f79535-47bb-0310-9956-ffa450edef68
2015-08-13 20:31:25 +00:00
Nick Burch
1a84b476e8 #58237 When adding a picture to a XWPF header or footer, attach it to the right part
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695772 13f79535-47bb-0310-9956-ffa450edef68
2015-08-13 20:23:58 +00:00
Nick Burch
cfbc261e65 #58237 Add some more XWPF header and footer tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695769 13f79535-47bb-0310-9956-ffa450edef68
2015-08-13 20:01:04 +00:00
Nick Burch
d9697de075 Fix inconsistent line endings and some eclipse warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695757 13f79535-47bb-0310-9956-ffa450edef68
2015-08-13 19:20:58 +00:00
Andreas Beeker
0e1aa75750 findbugs - DM_NUMBER_CTOR
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695635 13f79535-47bb-0310-9956-ffa450edef68
2015-08-13 00:38:04 +00:00
Andreas Beeker
3ac2d2905a findbugs - DM_BOXED_PRIMITIVE_...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695629 13f79535-47bb-0310-9956-ffa450edef68
2015-08-13 00:17:08 +00:00
Nick Burch
6d46fc382f #58220 - Improve the javadocs for XSSFFont and Font getFontHeight methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695528 13f79535-47bb-0310-9956-ffa450edef68
2015-08-12 14:14:12 +00:00
Nick Burch
ac8ed40f80 Fix some eclipse warnings, add TODOs for fields/hyperlinks XWPF add support, and give a more helpful exception if someone tries to remove a XWPFRun that is not a direct paragraph child
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695365 13f79535-47bb-0310-9956-ffa450edef68
2015-08-11 20:10:53 +00:00
Nick Burch
87a2acf935 Support XWPF field runs, the same way that we handle hyperlink runs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695361 13f79535-47bb-0310-9956-ffa450edef68
2015-08-11 20:01:26 +00:00
Dominik Stadler
ccc4ebcf70 Bug 56479: don't hardcode dcterms as namespace alias in the attribute, but expect the actual alias that is used in the corresponding element.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695212 13f79535-47bb-0310-9956-ffa450edef68
2015-08-11 05:37:15 +00:00
Andreas Beeker
750558d8d9 #56519 - XSLFSlide.draw is not working with text embeded in PPTX
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694925 13f79535-47bb-0310-9956-ffa450edef68
2015-08-09 22:44:13 +00:00
Nick Burch
bdb00633a3 Complete theme colour tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694892 13f79535-47bb-0310-9956-ffa450edef68
2015-08-09 14:15:00 +00:00
Nick Burch
5b97e55997 Get theme and non-theme rows consistent in the test file
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694889 13f79535-47bb-0310-9956-ffa450edef68
2015-08-09 13:30:35 +00:00
Nick Burch
d2a95d0901 Begin Themes+Normal colour tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694887 13f79535-47bb-0310-9956-ffa450edef68
2015-08-09 13:06:40 +00:00
Nick Burch
3abeb347a6 Fix the themes test for the complex workbook
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694883 13f79535-47bb-0310-9956-ffa450edef68
2015-08-09 12:36:57 +00:00
Andreas Beeker
d0e0f0cb97 #58205 - getSlideMasters() returns the master slides in the incorrect order
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694592 13f79535-47bb-0310-9956-ffa450edef68
2015-08-07 00:17:55 +00:00
David North
66fbc9d44e Example to go with refactor for https://bz.apache.org/bugzilla/show_bug.cgi?id=58219
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694536 13f79535-47bb-0310-9956-ffa450edef68
2015-08-06 16:37:09 +00:00
David North
9730ff9cd6 Proposed refactor for:
https://bz.apache.org/bugzilla/show_bug.cgi?id=58219

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694531 13f79535-47bb-0310-9956-ffa450edef68
2015-08-06 15:57:48 +00:00
Andreas Beeker
f28588fbb3 #57786 - XSLFFreeformShape ignores quadratic bezier curves
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694373 13f79535-47bb-0310-9956-ffa450edef68
2015-08-05 23:24:13 +00:00
Andreas Beeker
e5069da22a #58206 - provide a mechanism to find slide layouts by name
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694340 13f79535-47bb-0310-9956-ffa450edef68
2015-08-05 22:46:42 +00:00
Andreas Beeker
91353085b5 #58204 - STYLE: ShapeContainer interface makes internal getShapesList() redundant
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694335 13f79535-47bb-0310-9956-ffa450edef68
2015-08-05 21:44:01 +00:00
Nick Burch
1f6594c244 Stub next test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694127 13f79535-47bb-0310-9956-ffa450edef68
2015-08-04 23:26:20 +00:00
Nick Burch
b2ab81ad81 Use an enum to simplify the themes code and tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694125 13f79535-47bb-0310-9956-ffa450edef68
2015-08-04 23:14:23 +00:00
Nick Burch
f78eac8c41 Pull out indexes from the switch statement to constants, and fix warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694121 13f79535-47bb-0310-9956-ffa450edef68
2015-08-04 22:46:27 +00:00
Andreas Beeker
1241a24ebb move setting of xmlinputfactory from junit to gump-meta/poi.xml
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694120 13f79535-47bb-0310-9956-ffa450edef68
2015-08-04 22:24:31 +00:00
Nick Burch
885368e2ce Further XSSF Themes unit testing
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694093 13f79535-47bb-0310-9956-ffa450edef68
2015-08-04 17:50:44 +00:00
Andreas Beeker
adfcf4d251 FindBugs fixes - MS_SHOULD_BE_FINAL
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693984 13f79535-47bb-0310-9956-ffa450edef68
2015-08-03 23:36:28 +00:00
Andreas Beeker
0a42120b89 Javadoc fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693983 13f79535-47bb-0310-9956-ffa450edef68
2015-08-03 23:30:13 +00:00
Andreas Beeker
5a4575bb8c gump build fixing - move system properties tinkering into junit class
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693978 13f79535-47bb-0310-9956-ffa450edef68
2015-08-03 23:09:10 +00:00
Andreas Beeker
77315b425f Trying to fix the wrong xmlinputfactory on gump run
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693830 13f79535-47bb-0310-9956-ffa450edef68
2015-08-02 21:29:23 +00:00
Andreas Beeker
6b8af03c42 #58190 - The current picture handling uses raw integers for types and index, replace with enum and reference
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693825 13f79535-47bb-0310-9956-ffa450edef68
2015-08-02 20:21:35 +00:00
Nick Burch
42bf5e5fc6 Use the same "is this a formula" logic for both getCellType and getCachedFormulaResultType
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693767 13f79535-47bb-0310-9956-ffa450edef68
2015-08-01 21:34:34 +00:00
Andreas Beeker
98ed7bb5fb #58193 - Use input stream rather than byte array for checksum etc.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693754 13f79535-47bb-0310-9956-ffa450edef68
2015-08-01 20:09:37 +00:00
Nick Burch
fb731a62a5 Unit test for bug #57181
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693676 13f79535-47bb-0310-9956-ffa450edef68
2015-08-01 00:25:20 +00:00
Nick Burch
098177f39e Re-enable some SXSSF skipped tests, but not all, for our limited evaluation support #58200
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693663 13f79535-47bb-0310-9956-ffa450edef68
2015-07-31 22:16:53 +00:00
Nick Burch
0b6add86ac Start re-enabling some SXSSF formula evaluation tests, with required fixes #58200
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693662 13f79535-47bb-0310-9956-ffa450edef68
2015-07-31 22:07:58 +00:00
Nick Burch
1761949b02 Refactor the core part of the XSSF Formula Evaluator, to make SXSSF overrides easier #58200
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693661 13f79535-47bb-0310-9956-ffa450edef68
2015-07-31 22:04:16 +00:00
Nick Burch
4782319fd1 More helpful exception on the wrong cell type
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693656 13f79535-47bb-0310-9956-ffa450edef68
2015-07-31 21:44:56 +00:00
Nick Burch
a11d4082ca Get basic SXSSF formula evaluation working, for cells/references in the window #58200
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693654 13f79535-47bb-0310-9956-ffa450edef68
2015-07-31 21:31:53 +00:00
Nick Burch
5b22ad3be6 Push most of the common logic from XSSFEvaluationWorkbook into BaseXSSFEvaluationWorkbook, and start to use it for SXSSF as well #58200
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693647 13f79535-47bb-0310-9956-ffa450edef68
2015-07-31 20:40:41 +00:00
Nick Burch
070ac341d2 Remove a long-deprecated constructor
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693646 13f79535-47bb-0310-9956-ffa450edef68
2015-07-31 20:38:36 +00:00
Nick Burch
72909b1e6d Fix inconsistent indents/whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693645 13f79535-47bb-0310-9956-ffa450edef68
2015-07-31 20:24:29 +00:00
Nick Burch
af9f83fd08 Prepare for SXSSF evaluation #58200
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693644 13f79535-47bb-0310-9956-ffa450edef68
2015-07-31 20:22:11 +00:00
Nick Burch
66d370a978 #58200 Prepare for evaluating SXSSF cell formulas in limited cases
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693641 13f79535-47bb-0310-9956-ffa450edef68
2015-07-31 19:19:33 +00:00
Nick Burch
fcbd93a768 Use more specific return types in SXSSF, which avoids casts, and also fix some long-standing TODOs on 1904 dates
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693633 13f79535-47bb-0310-9956-ffa450edef68
2015-07-31 17:23:01 +00:00
Nick Burch
2ad973852c Have XSSF rich test strings report if they have formatting applied or not, and fix them to only add the formatting child element when needed
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693632 13f79535-47bb-0310-9956-ffa450edef68
2015-07-31 17:22:05 +00:00
Andreas Beeker
b6b3853330 temporary activate jaxp debugging to find jaxb/stax error on gump build
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1692944 13f79535-47bb-0310-9956-ffa450edef68
2015-07-27 20:24:09 +00:00
Dominik Stadler
4728df5b6a Improve error message slightly, add tests to verify things failing in Gump-build currently
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1692836 13f79535-47bb-0310-9956-ffa450edef68
2015-07-27 08:44:04 +00:00
Andreas Beeker
b2e18cf5ed Javadoc fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1692674 13f79535-47bb-0310-9956-ffa450edef68
2015-07-26 00:25:27 +00:00
Andreas Beeker
fe3b8e5eec Annotation for unimplemented drawing handlers.
Ignore unsupported image types (e.g. wmf).

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1692640 13f79535-47bb-0310-9956-ffa450edef68
2015-07-25 19:24:51 +00:00
Andreas Beeker
5d267dd16d fixed NPE with Jaxb proxy classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1692598 13f79535-47bb-0310-9956-ffa450edef68
2015-07-25 00:25:07 +00:00
Andreas Beeker
f5e9adea84 merged common_sl branch to trunk
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1692593 13f79535-47bb-0310-9956-ffa450edef68
2015-07-24 21:47:55 +00:00
Dominik Stadler
0a9a9e13f7 Bug 57571, Bug 58175: Fix creating comments for XSSF/SXSSF, regression was introduced via bug 54920
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1692483 13f79535-47bb-0310-9956-ffa450edef68
2015-07-24 11:58:01 +00:00
Nick Burch
a6779a3c02 Allow creating of an empty Themes Table on request
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1692211 13f79535-47bb-0310-9956-ffa450edef68
2015-07-22 00:04:59 +00:00
Nick Burch
8bb5d65cf8 Javadoc fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1692210 13f79535-47bb-0310-9956-ffa450edef68
2015-07-21 23:57:44 +00:00
Dominik Stadler
ed7d892de7 Bug 58156: Possible data corruption in hasPOIFSHeader and hasOOXMLHeader
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691948 13f79535-47bb-0310-9956-ffa450edef68
2015-07-20 14:03:35 +00:00
Nick Burch
5e77d18b53 Fix inconsistent whitespace/indents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691871 13f79535-47bb-0310-9956-ffa450edef68
2015-07-20 04:56:05 +00:00
Nick Burch
b7d27d44ce #58130 CF DataBar example and tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691869 13f79535-47bb-0310-9956-ffa450edef68
2015-07-20 04:43:36 +00:00
Nick Burch
104d9ad8e3 #58130 CF DataBar support
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691868 13f79535-47bb-0310-9956-ffa450edef68
2015-07-20 03:52:50 +00:00
Nick Burch
ac6aab29cf #58130 Begin CF DataBar support
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691867 13f79535-47bb-0310-9956-ffa450edef68
2015-07-20 03:21:57 +00:00
Nick Burch
164aa4c7c6 #58130 Support for creating CF Color Scale Formattings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691866 13f79535-47bb-0310-9956-ffa450edef68
2015-07-20 02:49:12 +00:00
Nick Burch
eee0fb2835 Move some of the XSSF Color logic to a base class, so that the HSSF Extended Color wrapper can use it
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691864 13f79535-47bb-0310-9956-ffa450edef68
2015-07-20 00:46:50 +00:00
Nick Burch
7261a10654 #58130 Enable CF ColorScale support on the rule, and begin testing
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691860 13f79535-47bb-0310-9956-ffa450edef68
2015-07-19 22:35:37 +00:00
Nick Burch
1f12ed1002 XSSF color scale CF objects
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691859 13f79535-47bb-0310-9956-ffa450edef68
2015-07-19 22:22:09 +00:00