Commit Graph

1136 Commits

Author SHA1 Message Date
Nick Burch
2ccd6db57e More missing core properties unit tests, covering read-write without checks, and encryption
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1662972 13f79535-47bb-0310-9956-ffa450edef68
2015-02-28 17:37:11 +00:00
Nick Burch
3ba7b59afc Ensure that the core properties are there before saving them, in case they have not yet been lazy-created
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1662971 13f79535-47bb-0310-9956-ffa450edef68
2015-02-28 17:36:19 +00:00
Dominik Stadler
f043c44017 * Verify some more Text-Extraction features as part of integration tests, fix some NullPointerExceptions that showed up now because the event-based extraction does not have a Document available
* Also handle a XLSX which does not have row-numbers in the sheet-xml. Excel can read it so it makes sense to also allow to read it in the XSSFSheetXMLHandler 
* Remove some Eclipse warnings in test-code

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1662691 13f79535-47bb-0310-9956-ffa450edef68
2015-02-27 14:58:41 +00:00
Dominik Stadler
e86ed72c2b * Add text-extraction verification to integration-tests via a new abstract base FileHandler
* Fix NullPointerException found in some documents when running against the test-data
* Add support for extracting text from Dir-Entries WORKBOOK and BOOK to support some old/strangely formatted XLS files.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1662652 13f79535-47bb-0310-9956-ffa450edef68
2015-02-27 09:59:14 +00:00
Dominik Stadler
7dfcd6c684 Adjust tests and fix small typo
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1662650 13f79535-47bb-0310-9956-ffa450edef68
2015-02-27 09:52:57 +00:00
Dominik Stadler
b57a4f04e3 Adjust to provide full exception information for cases where we catch unexpected exceptions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1662447 13f79535-47bb-0310-9956-ffa450edef68
2015-02-26 13:43:10 +00:00
Nick Burch
66afa6d09b Update Javadocs to refer to the fact that WorkbookFactory.create will throw a EncryptedDocumentException if the file is password protected
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1662074 13f79535-47bb-0310-9956-ffa450edef68
2015-02-24 18:20:02 +00:00
Nick Burch
7ee6e41e59 Fix inconsistent indents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1661912 13f79535-47bb-0310-9956-ffa450edef68
2015-02-24 12:11:34 +00:00
Nick Burch
b6a88f09c8 Patch from rojotek from github-18 - Handle documents with a picture-only header
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1661908 13f79535-47bb-0310-9956-ffa450edef68
2015-02-24 12:09:30 +00:00
Nick Burch
d5065b1742 Change from XMLEventFactory.newFactory to XMLEventFactory.newInstance, for IBM JDK Compatibility, fixes #57622
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1661903 13f79535-47bb-0310-9956-ffa450edef68
2015-02-24 12:03:53 +00:00
Dominik Stadler
1bbbd985d4 Bug 57612: Fix checking for proxy/accessible website in TestSignatureInfo
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1661774 13f79535-47bb-0310-9956-ffa450edef68
2015-02-23 20:45:21 +00:00
Nick Burch
327df5cf76 Unit tests for OPC handling of files without a Core Properties part
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1661663 13f79535-47bb-0310-9956-ffa450edef68
2015-02-23 13:21:23 +00:00
Dominik Stadler
04ae3247eb Revert organize imports
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1661327 13f79535-47bb-0310-9956-ffa450edef68
2015-02-21 11:58:45 +00:00
Dominik Stadler
fa85c4bbef Use assertArrayEquals() to try to better show why this test fails in some rare cases currently
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1660697 13f79535-47bb-0310-9956-ffa450edef68
2015-02-18 18:47:22 +00:00
Dominik Stadler
ce007f05ee Bug 57459: Add method in SXSSFSheet to directly set row OutLineLevel
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1659785 13f79535-47bb-0310-9956-ffa450edef68
2015-02-14 12:46:16 +00:00
Dominik Stadler
e450b8d5e1 Adjust TestSignatureInfo so junit provides more information if an unexpected exception happens
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1659784 13f79535-47bb-0310-9956-ffa450edef68
2015-02-14 12:46:04 +00:00
Nick Burch
702f8b9ee7 Finish converting ErrorEval to only use the FormulaError constants, and then finish unit test for 57535
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1658190 13f79535-47bb-0310-9956-ffa450edef68
2015-02-08 15:37:14 +00:00
Nick Burch
b1a6afc36a Add a unit test (disabled) for bug #57535 - "Unknown error type: -60" fetching formula error value
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1658186 13f79535-47bb-0310-9956-ffa450edef68
2015-02-08 15:17:47 +00:00
Nick Burch
25385edc38 XWPF implementation of some common Paragraph methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1657717 13f79535-47bb-0310-9956-ffa450edef68
2015-02-05 23:31:59 +00:00
Nick Burch
483982caad Stub a common WP paragraph class, needs uncommenting as XWPF implements/emulates
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1657712 13f79535-47bb-0310-9956-ffa450edef68
2015-02-05 23:20:43 +00:00
Nick Burch
c526206e0d More common HWPF/XWPF interfaces
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1657634 13f79535-47bb-0310-9956-ffa450edef68
2015-02-05 17:35:09 +00:00
Nick Burch
1f2fc6c08b More common XWPF/HWPF character run methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1657631 13f79535-47bb-0310-9956-ffa450edef68
2015-02-05 17:25:02 +00:00
Nick Burch
a351b66fde XWPF double strikethrough, and start on a common interface for HWPF and XWPF character runs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1657624 13f79535-47bb-0310-9956-ffa450edef68
2015-02-05 17:00:08 +00:00
Nick Burch
b25e4ca87d 57482 Handle XSLX files with no shared strings table in read-only mode
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1653825 13f79535-47bb-0310-9956-ffa450edef68
2015-01-22 12:15:59 +00:00
Nick Burch
ca33983388 Unit test from Isao Kadowaki from bug #57482
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1653814 13f79535-47bb-0310-9956-ffa450edef68
2015-01-22 11:45:40 +00:00
Dominik Stadler
eab2c0d20d Add a developer-tool to pretty-print the XMLs in an OOXML file. This makes it easier to compare OOXML files produced by different applications with differeing XML formatting.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1653777 13f79535-47bb-0310-9956-ffa450edef68
2015-01-22 07:24:01 +00:00
Nick Burch
0257c23cae Have ExtractorFactory open OPCPackages from files in read-only mode by default, since writing should never be needed when extracting text
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1652877 13f79535-47bb-0310-9956-ffa450edef68
2015-01-18 23:46:29 +00:00
Nick Burch
df20c0a69b For XSSFSheet, add a getDrawingPatriarch() method alongside the existing createDrawingPatriarch() one
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1652876 13f79535-47bb-0310-9956-ffa450edef68
2015-01-18 23:45:04 +00:00
Nick Burch
c4eb73a28b Test to show that bug #57430 works fine already
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1651314 13f79535-47bb-0310-9956-ffa450edef68
2015-01-13 09:57:46 +00:00
Dominik Stadler
113edb1a76 Adjust Bin2Dec similar to what we did for Hex2Dec in Bug 57196 and fix some smaller problems in the implementation found while adding full unit tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1650654 13f79535-47bb-0310-9956-ffa450edef68
2015-01-09 20:37:11 +00:00
Dominik Stadler
3403bef5a8 Fix Eclipse warnings, provide better error message and adjust javadoc slightly
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1650598 13f79535-47bb-0310-9956-ffa450edef68
2015-01-09 16:52:23 +00:00
Dominik Stadler
c8bf92f963 Bug 57196: Resolve RefEval to it's inner ValueEval in Hex2Dec
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1650597 13f79535-47bb-0310-9956-ffa450edef68
2015-01-09 16:51:02 +00:00
Nick Burch
ed8964594b Swap Exception for Throwable, to skip a wider range of problems (eg GAE) when attempting to set an xml security manager as best we can
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1650290 13f79535-47bb-0310-9956-ffa450edef68
2015-01-08 13:22:50 +00:00
Dominik Stadler
8997d8900d * Add missing close() on streams in ImageUtils.getImageDimension()
* Add some unit tests for CellReference

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1650070 13f79535-47bb-0310-9956-ffa450edef68
2015-01-07 14:36:39 +00:00
Dominik Stadler
f912ecac92 Add reproducer for bug 56655
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1650069 13f79535-47bb-0310-9956-ffa450edef68
2015-01-07 14:34:13 +00:00
Dominik Stadler
5aff4f5a2a Add reproducing testcase for Bug 57294
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649536 13f79535-47bb-0310-9956-ffa450edef68
2015-01-05 14:39:51 +00:00
Dominik Stadler
fa8eae2bfd Move some tests to the base test class where applicapple
Introduce class BaseTestXCell to collect tests for XSSFCell and SXSSFCell that do not work for HSSFCell

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649527 13f79535-47bb-0310-9956-ffa450edef68
2015-01-05 14:03:37 +00:00
Dominik Stadler
c2d82b6005 Update disabled test for bug 54071 to show the root-cause better
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649526 13f79535-47bb-0310-9956-ffa450edef68
2015-01-05 13:48:41 +00:00
Dominik Stadler
8edf70ec8f Add unit tests for XSSFTextRun and TextPainter, slightly more tests for XSSFSheet and enhance unit tests for XWPFParagraph and ExcelAntTest
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649309 13f79535-47bb-0310-9956-ffa450edef68
2015-01-04 10:23:01 +00:00
Dominik Stadler
9794510d33 Improve information in exceptions thrown by XSSFRichTextString and improve unit tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649234 13f79535-47bb-0310-9956-ffa450edef68
2015-01-03 19:30:56 +00:00
Dominik Stadler
2f681f430c Fix copy/paste errors in XSSFSimpleShape, allow unset of insets multiple times and add unit tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649233 13f79535-47bb-0310-9956-ffa450edef68
2015-01-03 19:30:36 +00:00
Dominik Stadler
3bbf57cd27 Fix copy/paste error in XSSFTextParagraph and add unit tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649232 13f79535-47bb-0310-9956-ffa450edef68
2015-01-03 19:29:51 +00:00
Dominik Stadler
302db39cb7 Fix some Eclipse warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649123 13f79535-47bb-0310-9956-ffa450edef68
2015-01-02 21:06:51 +00:00
Dominik Stadler
ffcc20f60e Bug 46898: Convert unit tests for circular references to also run for XSSF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649122 13f79535-47bb-0310-9956-ffa450edef68
2015-01-02 21:04:50 +00:00
Dominik Stadler
12edcc5ed2 Bug 46192: Add methods to query outline level for HSSF and XSSF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649107 13f79535-47bb-0310-9956-ffa450edef68
2015-01-02 20:03:28 +00:00
Dominik Stadler
5c76ccba5b Add missing close() of resources in both production code and tests
Use revert() instead of close() on OCPPackage in some places to not re-write the file unnecessarily.
This should now run tests without leftover file handles when checked with file leak detector and
allows to find newly introduced cases more easily.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648160 13f79535-47bb-0310-9956-ffa450edef68
2014-12-28 09:16:57 +00:00
Dominik Stadler
26585f4e95 Ensure that XSSFWorkbooks contain a BookView, some corrupt ones do not contain this, e.g. ones created by movescound.com
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648158 13f79535-47bb-0310-9956-ffa450edef68
2014-12-28 09:08:58 +00:00
Dominik Stadler
5173eca9ea Fix Eclipse warnings, unnecessary casts, use generics, static access...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648156 13f79535-47bb-0310-9956-ffa450edef68
2014-12-28 09:06:12 +00:00
Andreas Beeker
4bed984c0f Charset.forName() for known encodings makes catching UnknownEncodingException obsolete
Unify UTF-16LE conversion to StringUtil
BugFix for RecordInputStream.readFully in combination with continuing records
BugFix for integration tests - fix pathname for handler/exclude lookup on windows

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648032 13f79535-47bb-0310-9956-ffa450edef68
2014-12-27 01:33:28 +00:00
Dominik Stadler
0c580c8f45 Add a test-suite which performs integration/stress tests which load and handle all stored test files in various ways.
It works by using handlers for each type of file which perform various operations on the files, e.g. loading,
iterating content, modify, ... This will trigger changes which break working with the available test-files and
thus provides another layer of regression testing which hopefully prevents some failures from making it into
releases.

It is runnable via a new ant-target 'test-integration' and also added to the jenkins-target.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647885 13f79535-47bb-0310-9956-ffa450edef68
2014-12-25 09:16:44 +00:00