Commit Graph

1364 Commits

Author SHA1 Message Date
Nick Burch
293a7b4a5b Simplify CF icon rule asserts
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691764 13f79535-47bb-0310-9956-ffa450edef68
2015-07-18 18:50:52 +00:00
Nick Burch
6cfa6ee7e4 #58130 Mostly there with CF Icon sets
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691679 13f79535-47bb-0310-9956-ffa450edef68
2015-07-18 04:55:27 +00:00
Dominik Stadler
7f8a76da87 One more try to find out why autosize fails on the freebsd CI machine
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691495 13f79535-47bb-0310-9956-ffa450edef68
2015-07-17 08:42:10 +00:00
Dominik Stadler
6fcb49535a * Some more checks as test still fails on freebsd CI machine
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691407 13f79535-47bb-0310-9956-ffa450edef68
2015-07-16 14:17:13 +00:00
Dominik Stadler
651f03cc64 * Make on unit test not fail if Fonts are not available on the machine
* Refactor SheetUtil a bit to reduce code-duplication, adjust JavaDoc for -1 return values
* Add method to check if we can compute text-width
* Add unit-tests which verify some more of SheetUtil

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691341 13f79535-47bb-0310-9956-ffa450edef68
2015-07-16 09:06:47 +00:00
Dominik Stadler
aeb0d6abe3 Fixup printing record name in case of unknown sid
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691312 13f79535-47bb-0310-9956-ffa450edef68
2015-07-16 03:49:44 +00:00
Dominik Stadler
e64b72a4e1 More coverage of class EscherDump
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691311 13f79535-47bb-0310-9956-ffa450edef68
2015-07-16 03:42:17 +00:00
Dominik Stadler
0c410544a9 Fix some Eclipse warnings and adjust use of Generics, Comments, close()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691308 13f79535-47bb-0310-9956-ffa450edef68
2015-07-16 03:41:57 +00:00
Nick Burch
9c9023524a Further HSSF support towards CF IconSets #58130
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691113 13f79535-47bb-0310-9956-ffa450edef68
2015-07-15 00:04:53 +00:00
Nick Burch
c38bb72090 More CF colour tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691094 13f79535-47bb-0310-9956-ffa450edef68
2015-07-14 21:54:28 +00:00
Nick Burch
a6836c595f Start checking the CF colours in the unit tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691092 13f79535-47bb-0310-9956-ffa450edef68
2015-07-14 21:45:23 +00:00
Nick Burch
98d79c8eda Check more of the complex CF cases from the test files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1690813 13f79535-47bb-0310-9956-ffa450edef68
2015-07-13 20:25:52 +00:00
Nick Burch
4632e35c3d Move some test checks to using ConditionType instead of raw bytes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1690808 13f79535-47bb-0310-9956-ffa450edef68
2015-07-13 20:11:47 +00:00
Nick Burch
fbf95cdb54 Enable CF2007 test for XLSX too
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1690805 13f79535-47bb-0310-9956-ffa450edef68
2015-07-13 19:56:09 +00:00
Nick Burch
705c3fe1f9 Have the HSSF ConditionalFormattingTable look for CF12 records as well, and begin more detailed testing of the high level rules #58130
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1690796 13f79535-47bb-0310-9956-ffa450edef68
2015-07-13 18:55:42 +00:00
Nick Burch
65aa10e10f Begin updating the HSSF CF code to work on the base types, so it can handle both CF and CF12
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1690793 13f79535-47bb-0310-9956-ffa450edef68
2015-07-13 18:38:15 +00:00
Nick Burch
9e7d44b81c Fix inconsistent indents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1690790 13f79535-47bb-0310-9956-ffa450edef68
2015-07-13 18:28:05 +00:00
Nick Burch
6cc72aab77 Fix generics, and use base types
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1690789 13f79535-47bb-0310-9956-ffa450edef68
2015-07-13 18:27:06 +00:00
Nick Burch
72f0f10882 Enable CFRule12 use #58130
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1690783 13f79535-47bb-0310-9956-ffa450edef68
2015-07-13 18:09:12 +00:00
Nick Burch
010e67c749 More helpful output if a re-write test fails
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1690780 13f79535-47bb-0310-9956-ffa450edef68
2015-07-13 18:00:28 +00:00
Nick Burch
fdd0d249ca CFRule12 tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1690778 13f79535-47bb-0310-9956-ffa450edef68
2015-07-13 17:54:28 +00:00
Dominik Stadler
da56e012c3 Bug 58113: Fix regression: NullPointerException when setting cell value to null
add unit tests which verifies this for all three SS-implementations

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1690652 13f79535-47bb-0310-9956-ffa450edef68
2015-07-13 12:17:52 +00:00
Nick Burch
a904047399 Refactor some of the CFRuleRecord logic out to CFRuleBase, and begin work on CFRule12Record #58130
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1690527 13f79535-47bb-0310-9956-ffa450edef68
2015-07-12 20:38:57 +00:00
Nick Burch
883f4f4e0d Introduce a CFHeaderBase common parent #58130
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1690503 13f79535-47bb-0310-9956-ffa450edef68
2015-07-12 18:35:33 +00:00
Dominik Stadler
090b86cb71 Add some missing close(), reduce output in unit tests and remove some other Eclipse warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1689590 13f79535-47bb-0310-9956-ffa450edef68
2015-07-07 07:44:11 +00:00
Nick Burch
e942647b66 When writing the mini-stream, set the size of it on the root property #58061
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1689505 13f79535-47bb-0310-9956-ffa450edef68
2015-07-06 21:39:42 +00:00
Nick Burch
08b74eb15e Helper method to report the number of blocks used in a BAT
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1689504 13f79535-47bb-0310-9956-ffa450edef68
2015-07-06 21:15:57 +00:00
Nick Burch
305d31a998 Fix OPOIFS generics warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1688920 13f79535-47bb-0310-9956-ffa450edef68
2015-07-02 22:36:45 +00:00
Nick Burch
605b16c061 To better match OPOIFS, pad to the end of a block with 0xFF/-1
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1688543 13f79535-47bb-0310-9956-ffa450edef68
2015-07-01 00:43:33 +00:00
Nick Burch
75af780517 More NPOIFS ministream tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1688534 13f79535-47bb-0310-9956-ffa450edef68
2015-06-30 23:50:35 +00:00
Nick Burch
069d7db9e0 Put the properties table at block 0, with the first BAT at block 1, to hopefully solve #58061
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1688038 13f79535-47bb-0310-9956-ffa450edef68
2015-06-28 18:53:21 +00:00
Andreas Beeker
c0cb680292 Bug 56865 - Limit number of bytes (by counting them) while opening office docs
Bug 50090 - 'zip' bomb prevention

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1687148 13f79535-47bb-0310-9956-ffa450edef68
2015-06-23 23:39:07 +00:00
Andreas Beeker
057768994e Bug 58069 - Biff8RC4 xorShort returns wrong value for unsigned shorts
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1687146 13f79535-47bb-0310-9956-ffa450edef68
2015-06-23 23:06:23 +00:00
Andreas Beeker
48208023fb Bug 58040 - Log Forging
and marked POILogger/POILogFactory internal

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1686748 13f79535-47bb-0310-9956-ffa450edef68
2015-06-21 19:06:32 +00:00
Dominik Stadler
f58646196d Bug 57923: Fix check for tokens in NameRecord.getExternSheetNumber() to avoid ArrayOutOfBoundsException
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1686689 13f79535-47bb-0310-9956-ffa450edef68
2015-06-21 06:56:45 +00:00
Dominik Stadler
e4f5df42f6 Bug 56655: Fix Sumifs for cases where the criteria is in error.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1686610 13f79535-47bb-0310-9956-ffa450edef68
2015-06-20 13:10:28 +00:00
Dominik Stadler
cb5588c4a1 Bug 56420: Fix possible NullPointerException when empty cell is included in Sumif calculation
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1686564 13f79535-47bb-0310-9956-ffa450edef68
2015-06-20 11:29:14 +00:00
Dominik Stadler
ebf65abac7 Comment out writing to file in c:/temp which breaks the build now
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1686106 13f79535-47bb-0310-9956-ffa450edef68
2015-06-17 20:41:08 +00:00
Dominik Stadler
13eb52f12f Move more tests into base class and add a TestSXSSFBugs class to verify some things that are supported against SXSSFWorkbook as well
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1686035 13f79535-47bb-0310-9956-ffa450edef68
2015-06-17 14:53:38 +00:00
David North
32bf29fba6 Whitespace seems to be confusing the license header check; try pasting one off another file.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1685523 13f79535-47bb-0310-9956-ffa450edef68
2015-06-15 09:44:12 +00:00
Dominik Stadler
dafeb24564 One more file with missing license header
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1685522 13f79535-47bb-0310-9956-ffa450edef68
2015-06-15 09:38:29 +00:00
David North
369c593380 Add explicit test for NPE only caught by other tests. Test '97 fallback behaviour generally.
https://bz.apache.org/bugzilla/show_bug.cgi?id=56328

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1685104 13f79535-47bb-0310-9956-ffa450edef68
2015-06-12 15:29:20 +00:00
David North
16a9eca7c8 My own patch to fix #56328
Add tests for initial patch applied by Nick in r1582892

Fix and test AreaReference#isWholeColumnReference to take account of the prevailing spreadsheet version. Fixing all users of this is a big undertaking, so for now I've left a fallback on the original behaviour for some cases.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1685101 13f79535-47bb-0310-9956-ffa450edef68
2015-06-12 15:20:10 +00:00
Dominik Stadler
d3f93952e9 Bug 53109: Correctly handle unicode strings in NameCommentRecord
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1682999 13f79535-47bb-0310-9956-ffa450edef68
2015-06-01 20:49:53 +00:00
Nick Burch
7915b3ce38 Patch from René Scheibe from bug #57512 - Fix potential NPE in DateUtil for invalid dates
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1682796 13f79535-47bb-0310-9956-ffa450edef68
2015-05-31 21:18:11 +00:00
Nick Burch
b2d1c1b6ac #56791 Make NPOIFS the default when POIFSFileSystem is requested
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1681804 13f79535-47bb-0310-9956-ffa450edef68
2015-05-26 18:04:00 +00:00
Nick Burch
b8d9c978ad Force OPOIFS test to explicitly create OPOIFS instance
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1681803 13f79535-47bb-0310-9956-ffa450edef68
2015-05-26 18:03:29 +00:00
Nick Burch
8878be359a Force OPOIFS test to explicitly create OPOIFS instance
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1681802 13f79535-47bb-0310-9956-ffa450edef68
2015-05-26 17:59:13 +00:00
Nick Burch
fe07d32178 Fix warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1681763 13f79535-47bb-0310-9956-ffa450edef68
2015-05-26 14:06:17 +00:00
Nick Burch
e9f442ffa7 Fix testing for NPOIFS zero-length stream writing
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1681762 13f79535-47bb-0310-9956-ffa450edef68
2015-05-26 13:56:40 +00:00