moparisthebest/poi
1
0
Fork 0
Code Issues Pull Requests Releases 1 Wiki Activity
7,650 Commits 29 Branches 84 Tags 722 MiB
268c5deeb2
Commit Graph

1834 Commits

Author SHA1 Message Date
Dominik Stadler
902830cf14 Adjust test for extracting some more 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722411 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-30 20:31:50 +00:00
Dominik Stadler
8589924b22 Bug 58746: Fix missing adjustment of formulas when sheet-ordering is changed. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722410 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-30 20:31:44 +00:00
Dominik Stadler
8ae2972f3d Bug 58616: Try to initialize with empty password if not done before 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722407 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-30 20:31:23 +00:00
Dominik Stadler
b4ac21a810 Eclipse warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722406 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-30 20:31:13 +00:00
Nick Burch
a3d4d2571f Disabled unit test for #58760 (problem remains) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722244 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 22:42:17 +00:00
Javen O'Neal
434ebbbdef remove unused import 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722095 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 10:44:41 +00:00
Javen O'Neal
8be029b0c6 add comment 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722094 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 10:44:57 +00:00
Javen O'Neal
b96af85631 move comment 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722093 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 10:43:40 +00:00
Javen O'Neal
900d21a59c javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722092 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 10:41:50 +00:00
Javen O'Neal
44c5423be4 add unit test for bug 58779 when the problem gets fixed 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722091 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 10:40:20 +00:00
Javen O'Neal
dba7fcdd4e junit3 -> junit4 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722081 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 09:54:59 +00:00
Javen O'Neal
5310fc4b6d revert, not close, XSSFWorkbooks created by WorkbookFactory in order to avoid modifying SampleSS.xlsx (this bug will be addressed in a future commit). Since r1721468 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722079 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 09:28:32 +00:00
Javen O'Neal
6bc5c33c10 revert, not close, XSSFWorkbooks created by WorkbookFactory in order to avoid modifying SampleSS.xlsx (this bug will be addressed in a future commit). Since r1721468 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722078 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 09:21:17 +00:00
Javen O'Neal
5ab2c61a3f make spreadsheet file names static final rather than initializing them with setUp() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722073 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 08:53:46 +00:00
Javen O'Neal
eb5bca1612 javadoc fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722057 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 06:55:22 +00:00
Javen O'Neal
ef26a1d15c bug 58775: set an upper limit on number of data formats, default 250. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722054 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 05:46:20 +00:00
Javen O'Neal
70f08e1fc5 fix javadocs warnings for r1721930 (bug 58775) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722049 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 02:57:58 +00:00
Javen O'Neal
22b03ba71b convert junit3 to junit4 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722048 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 01:26:55 +00:00
Javen O'Neal
1dd49eff7c whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722047 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 01:18:16 +00:00
Javen O'Neal
ae1020ac35 bug 58778: override a built-in number format, such as using £ instead of $ for currency 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722043 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 00:12:04 +00:00
Javen O'Neal
bf5e95d37a bug 58740: javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721942 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-28 16:04:47 +00:00
Javen O'Neal
a50f45e4c2 bug 58775: use short for data format index, int for cell style index 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721930 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-28 14:50:54 +00:00
Javen O'Neal
0404c61acc bug 58775: consolidate HashMap and array numberFormats data structures to one SortedMap data structure 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721928 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-28 14:37:23 +00:00
Javen O'Neal
8f47967d55 write for loop for performance and readability 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721924 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-28 14:20:30 +00:00
Javen O'Neal
0849d8c34a bug 58775: fix a>b which should be a>=b; use shorts instead of ints to hold number format index 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721923 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-28 14:19:50 +00:00
Javen O'Neal
f3c14d82a6 simplify bug 57880 test case: 
remove unrelated DataFormat code (not worried about wrap-around here since Excel supports up to 250 data formats and we're using the short data type)
replace complex write-out, close, read-back, delete code with new better test apparatus

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721922 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-28 14:03:52 +00:00
Javen O'Neal
934effd443 add convenience methods for writing and reading back XSSFWorkbooks 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721920 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-28 13:44:08 +00:00
Javen O'Neal
3204cedf28 bug 58775: use assertNotBuiltInFormat 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721902 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-28 12:13:17 +00:00
Javen O'Neal
8a7cd6308e bug 58775: add Override annotations, Javadocs, and comments 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721880 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-28 07:56:54 +00:00
Javen O'Neal
ec4732a034 bug 58740: add @Internal annotations and decrease access level to methods that only exist for unit testing 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721864 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-28 00:52:47 +00:00
Javen O'Neal
19e5db9602 bug 58740: return unmodifiable list/map when exposing internal data structures 
patch from Archie Cobbs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721857 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-27 23:17:33 +00:00
Dominik Stadler
d89168fa51 Fix compiling unit-test after previous changes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721471 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-22 22:48:31 +00:00
Dominik Stadler
a021bc780b Fix some cases where file resources were not closed correctly, mostly when Exceptions occur during opening files 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721470 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-22 22:36:43 +00:00
Dominik Stadler
c9dee45744 fix commandline option in PPTX2PNG from quite to quiet 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721469 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-22 22:36:33 +00:00
Dominik Stadler
0a3370347e Fix freeing resources in some tests and dev-tools so we can run unit-tests with enabled file-leak-detector 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721468 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-22 22:35:59 +00:00
Dominik Stadler
b69c64fe21 Handle some cases better where file handles were left open by the ExtractorFactory, mostly when opening files failed, but also when using the NPOIFSFileSystem for initialization. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721064 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-20 20:39:01 +00:00
Nick Burch
355810fb9f Unit test for non-reproducable #58747 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1720588 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-17 15:05:06 +00:00
Dominik Stadler
ffe36ac2fe Fix unit test for bug 58731 to actually run 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1720534 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-17 12:39:01 +00:00
Nick Burch
1fbfc70cca Unit test for #58731 - not reproduced, and some javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1720411 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-16 18:15:31 +00:00
Andreas Beeker
7b4c17b70c #58733 - New AIOOBE in getCell while iterating through a table in PPT 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1720035 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-14 22:49:04 +00:00
Javen O'Neal
4f8057e56f bug 57450: javadoc fixes from Stefan Thurnherr 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1718226 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-06 21:43:26 +00:00
Dominik Stadler
96cb8c18fe Bug 58084: Fix cloning Cell Styles with Borders 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717973 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 14:39:07 +00:00
Dominik Stadler
387fb86d68 Eclipse warnings, code formatting, javadoc, ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717972 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 14:38:14 +00:00
Javen O'Neal
6d17f8ddef whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717927 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 10:46:58 +00:00
Javen O'Neal
17a4680cee findbugs: check return value of File.mkdir(s), and don't accidentally catch RuntimeException 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717923 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 10:33:28 +00:00
Javen O'Neal
83a2f13494 fix javadoc errors 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717903 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 07:10:26 +00:00
Javen O'Neal
44c9afd31d fix javadoc errors 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717902 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 07:05:52 +00:00
Javen O'Neal
9c19c23291 bug 58570: add get/setActiveCell to Sheet interface, add Cell.getAddress, 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717900 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 06:36:27 +00:00
Dominik Stadler
5a8aceec32 Add some additional rules for the forbidden-apis-check borrowed from Elasticsearch, also add a separate signature file with more rules for the 'prod' code and fix two newly found issues 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717689 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-02 21:47:52 +00:00
Andreas Beeker
cc77b04a94 Sonar fixes, direct array parameter 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717359 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-01 00:23:21 +00:00
Andreas Beeker
f0ed3cbbab - #47904 - Update text styles in HSLF MasterSlide 
- common sl unification for TextParagraph.setTextAlign

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717351 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-30 23:34:30 +00:00
Javen O'Neal
89fbd66262 bug 58670: cleanup from r1717192 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717194 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-30 07:03:09 +00:00
Javen O'Neal
8410c84ad6 bug 58670: replace SXSSFRow's storage of SXSSFCells[] with a TreeMap<Int, SXSSFCell> 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717192 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-30 06:07:49 +00:00
Javen O'Neal
b5ad3a9327 add @Override annotations to SXSSFRow 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717181 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-30 05:28:57 +00:00
Javen O'Neal
24e5a0a458 add @Override annotation. Explicitly specify workbook type returned by SXSSFITestDataProvider.writeOutAndReadBack 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717179 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-30 05:22:14 +00:00
Javen O'Neal
a5725f9b21 add @Override and @NotImplemented annotations to SXSSFCell, update javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717164 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-30 04:43:32 +00:00
Javen O'Neal
b2a24f1a71 javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717151 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-30 02:06:36 +00:00
Javen O'Neal
11650f84a9 add missing ASF License headers for bug 57450 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717149 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-30 01:05:10 +00:00
Javen O'Neal
226fefe0c9 patch from Stefan Thurnherr: bug 57450: autosize columns in SXSSF using rows that have been flushed to disk 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717146 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-30 00:22:50 +00:00
Andreas Beeker
60b17589b7 XSLF: tables can now be removed from sheets/groups 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717087 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 16:17:29 +00:00
Javen O'Neal
0e04793c2c bug 57844: add NotImplemented annotation to SXSSFSheet.shiftRows 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717079 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 15:31:57 +00:00
Javen O'Neal
0a69246abc add @Override annotations to Sheet classes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717078 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 15:27:34 +00:00
Andreas Beeker
ee0f9b84e1 close resources 
fix a few eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717077 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 15:26:53 +00:00
Javen O'Neal
79e099f5fa Patch from Lyle for bug 52903: HSSFSheet.shiftRows does not shift hyperlink references 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717069 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 14:45:24 +00:00
Javen O'Neal
5ee6c34217 findbugs: add missing equals and hashCode for classes with a compareTo method 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717068 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 14:33:28 +00:00
Javen O'Neal
d8223753ae javadoc 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717062 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 13:15:03 +00:00
Javen O'Neal
74f0442563 bug 58667: make SX/X/HSSFRow implement Comparable interface 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717054 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 12:14:45 +00:00
Javen O'Neal
f3b88f6755 SXSSFRow: privatize instance variables, make _sheet final 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717044 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 11:50:11 +00:00
Javen O'Neal
ff6d93d4f3 whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717043 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 11:48:02 +00:00
Javen O'Neal
a2ac15f1c8 make SXSSFRow._style private, add getRowStyleIndex() in its place 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717042 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 11:47:27 +00:00
Javen O'Neal
f324646c04 javadoc 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717040 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 11:44:03 +00:00
Javen O'Neal
db3028defb javadoc 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717038 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 11:39:36 +00:00
Javen O'Neal
7619f0c38f whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717035 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 11:34:56 +00:00
Javen O'Neal
9d014aa00b bug 52903/58557: add @Override decorators to XSSFHyperlink and HSSFHyperlink 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717026 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 02:43:17 +00:00
Andreas Beeker
0c7e8e0c47 #58663 - Pictures cannot be removed from a slide 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717018 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 00:51:04 +00:00
Javen O'Neal
1f05c1916a make instance variables final 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716843 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-27 11:35:43 +00:00
Javen O'Neal
1f874be829 bug 58636: upgrade anchor types from int to AnchorType enum 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716313 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-25 07:16:43 +00:00
Javen O'Neal
65cd898a61 bug 58637: replace deprecated getCellComment(row, col) usage 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716075 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 08:54:32 +00:00
Javen O'Neal
72aae0f14b bug 58348: use copy constructor design pattern rather than cloneable pattern for CellCopyPolicy 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716074 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 08:52:45 +00:00
Javen O'Neal
735c43ec9d bug 58644: fix HSSFSheet.setZoom(int); update documentation to use non-deprecated method 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716053 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 08:04:42 +00:00
Javen O'Neal
e7d29ad533 whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716051 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 07:53:17 +00:00
Javen O'Neal
8eabc4710a bug 58642: deprecate Sheet.setZoom(numerator, denominator) and replace with Sheet.setZoom(scale) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716048 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 07:43:53 +00:00
Javen O'Neal
891f2d26fc bug 58642: remove deprecated functions in Spreadsheet Sheet interface and implementing classes; add @Override annotations 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716046 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 07:34:09 +00:00
Javen O'Neal
84fdda5736 rewrite ternary expression as simple Math.min call (yes, the ternary expression as written is equivalent to min, not max, despite the variable being called max. I'll leave that fix up to the original author). 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716044 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 07:05:11 +00:00
Javen O'Neal
dc1acc7ead whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716035 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 05:57:31 +00:00
Javen O'Neal
2fab3547be whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716034 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 05:51:54 +00:00
Javen O'Neal
d6ee7f8221 remove duplicate null check of srcStartRow (identified by FindBugs) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716003 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 01:08:34 +00:00
Javen O'Neal
b5494da29c fix javadoc warnings from r1715839 bug 58365 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715993 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-23 23:52:59 +00:00
Javen O'Neal
4dd060e25b fix javadoc warnings from r1715839 bug 58365 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715987 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-23 23:34:33 +00:00
Javen O'Neal
7af82a3de2 catch IOException and rethrow as RuntimeException 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715850 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-23 15:36:57 +00:00
Javen O'Neal
3e10c4f0f6 bug 58365: patch from Hannes Erven: add method to efficiently get all cell comments on a Sheet and return a dictionary with the location of each comment as the key and the comment itself as the value. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715839 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-23 15:11:28 +00:00
Javen O'Neal
cf41635922 prevent slideshow test-data files shapes.pptx and tables_test.pptx from being modified when running "ant test"; close open resources 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715815 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-23 13:55:48 +00:00
Javen O'Neal
a77dd2777b bug 58365: patch from Hannes Erven. Update XSSFSheetXMLHandler.java to use CellAddress instead of CellReference/String 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715794 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-23 12:47:24 +00:00
Javen O'Neal
831fa71953 whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715787 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-23 12:32:26 +00:00
Javen O'Neal
090394287b bug 58365: patch from Hannes Erven. Update CommentsTable to use CellAddress instead of String 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715784 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-23 12:29:45 +00:00
Javen O'Neal
ae9bcd8e82 convert junit3 to junit4 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715752 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-23 10:26:06 +00:00
Andreas Beeker
4ccadf7315 fix unnecessary cast warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715626 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-22 12:30:42 +00:00
Andreas Beeker
47b5cde9c3 #58617 - Add custom safe XmlBeans type loader / rename vendor specific schema packages 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715555 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-21 19:37:26 +00:00
Andreas Beeker
7458fdc277 In preparation for table rendering, added table row heights and column widths to common sl. 
To have better results in rendering switch anchor from java.awt.Rectangle to Rectangle2D.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715540 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-21 15:54:01 +00:00
Andreas Beeker
2bc397b665 #58630 - Signing failed after deletion of first sheet 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715438 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-20 22:38:27 +00:00
Andreas Beeker
a0e06add7a #54210 When saving PPT to PNG, some text is rendered backwards 
#53189 Shapes drawn wrongly when ppt file converted to image
fix line decoration (HSLF)


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1714290 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-14 02:44:07 +00:00
Andreas Beeker
c6f11991e7 Add default XmlOptions to XMLBeans parsing 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1714288 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-14 02:41:48 +00:00
Uwe Schindler
73a8488838 #58597: Fix tests to not do setAccessible(), add some doPrivileged, too. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713891 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-11 16:57:39 +00:00
Uwe Schindler
da19b14670 #58597: Add more AccessController.doPrivileged. We should fix them later! 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713813 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-11 11:36:44 +00:00
Uwe Schindler
b62cc549fe #58597: Remove setAccessible (more coming soon) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713770 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-11 07:41:54 +00:00
Uwe Schindler
ce66e14b5a Wrap more security related reflection in AccessController 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713356 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-09 09:32:37 +00:00
Andreas Beeker
ccce28aae4 sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713319 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-08 23:14:50 +00:00
Andreas Beeker
e8d108ff22 Add support for HSLF metro blobs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713318 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-08 23:13:28 +00:00
asf-sync-process
c39e9df3c8 Add some more tests for the checks for files that can cause large memory usage. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713217 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-08 10:00:38 +00:00
Dominik Stadler
4cdcc9fc24 Eclipse warnings, typos, ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713216 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-08 10:00:24 +00:00
Nick Burch
172593de22 Add a XWPFRun equivalent of isHighlighted, and add to the common WP interface 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712793 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-05 15:15:36 +00:00
David North
5636e64d68 Patch to bring CTTableStyleInfo into poi-ooxml-schemas by referencing it from a unit test. 
Thanks to Danil Lopatin

https://bz.apache.org/bugzilla/show_bug.cgi?id=58579

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712769 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-05 13:44:14 +00:00
Andreas Beeker
9b4919cd51 extended forbidden-apis-check to ooxml-tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712693 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-05 00:15:51 +00:00
Nick Burch
ecab3629d8 Javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712606 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-04 18:25:35 +00:00
Javen O'Neal
265d198612 bug 58576: rename canComputeColumnWidht to canComputeColumnWidth 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712219 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-03 07:23:09 +00:00
Javen O'Neal
93373073bc set svn:eol-style native 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712214 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-03 06:06:43 +00:00
Andreas Beeker
acb219fbe1 fixes sonar/findbugs issues 
add Date.toString() to forbidden-apis and fix occurrences

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712181 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 23:46:57 +00:00
Javen O'Neal
06b3878176 javadoc fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711961 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 13:25:31 +00:00
Javen O'Neal
3b94c206e5 fix javadoc link 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711957 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 13:13:52 +00:00
Javen O'Neal
9b8250832e bug 58572: replace Cloneable with copy constructors for spreadsheet Hyperlink class 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711951 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 12:57:57 +00:00
Javen O'Neal
54113431b5 bug58348: add test for copying formula with unregistered UDF 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711939 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 10:47:19 +00:00
Javen O'Neal
f7fbfcd5ea bug 58348: add hyperlink copying and merging to CellCopyPolicy 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711926 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 09:59:32 +00:00
Javen O'Neal
0eb6ec6717 bug 58572: move getHyperlinkList() and getHyperlink(row, col) from XSSFSheet to Sheet 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711923 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 09:40:49 +00:00
Javen O'Neal
3c18d6aa7b don't leave behind files when running unit tests. In the future this should be revisited to verify POI isn't writing workbooks that are unopenable/corrupt by applications that read POI's formats (MS Office, OpenOffice, LibreOffice, etc) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711920 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 09:23:12 +00:00
Javen O'Neal
e88fac62ef whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711911 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 09:03:12 +00:00
Javen O'Neal
43a5f308d0 upgrade spreadsheet Hyperlink unit tests from junit3 to junit4 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711910 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 09:01:23 +00:00
Javen O'Neal
0e3230f703 upgrade spreadsheet Hyperlink unit tests from junit3 to junit4 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711909 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 08:55:45 +00:00
Javen O'Neal
3753893f1a whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711906 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 08:34:21 +00:00
Javen O'Neal
0aeab392e5 remove unused import 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711886 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 02:51:31 +00:00
Javen O'Neal
1360cd835d bug 58348: add support for copying rows for XSSFWorkbooks 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711885 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 02:50:33 +00:00
Javen O'Neal
6fc1d21367 javadocs, remove unnecessary SuppressWarnings("resource") decorator 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711883 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 02:39:15 +00:00
Javen O'Neal
682f5b3ed4 make private shouldRemoveRow static and final, remove unused import 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711881 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 02:28:34 +00:00
Javen O'Neal
40b250bbb3 replace deprecated usage of FormulaShifter.createForRowShift 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711879 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 02:22:03 +00:00
Javen O'Neal
75dd7f9ba3 remove unnecessary @SuppressWarnings(resource) add Override decorator to SXSSFCell.getCellStyle 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711877 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 02:06:43 +00:00
Javen O'Neal
c0aec91a93 delete unnecessary cast 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711876 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 01:51:03 +00:00
Andreas Beeker
5338f9dce1 Fix locale error 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711726 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-01 08:43:57 +00:00
Andreas Beeker
fa40f8417c findbugs fixes 
close resources in tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711712 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-01 03:23:16 +00:00
Andreas Beeker
8ebc22a84e Add method for setting bullet styles 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711707 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-31 23:10:43 +00:00
Javen O'Neal
401d3eec77 replace deprecated usage of AreaReference as a result of bug 56328 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711685 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-31 20:53:12 +00:00
Javen O'Neal
1aa81eb463 bug58452: set cell formulas containing unregistered function names 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711605 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-31 11:57:39 +00:00
Javen O'Neal
2354bbb0b0 supporting changes for bug 58452: copy cell formulas containing unregistered function names 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711600 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-31 11:39:01 +00:00
Javen O'Neal
043a86e243 bug 58443: prevent corrupted workbooks by checking for overlapping merged regions before adding a merged region to a sheet; fix unit tests that produced corrupt workbooks; remove deprecated HSSFSheet#addMergedRegion(Region) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711586 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-31 10:22:19 +00:00
Dominik Stadler
50baa731d3 Add a limit of the max number of characters that can be extracted to avoid sending applications out of memory with very large documents 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711520 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-30 17:26:37 +00:00
Nick Burch
fa5fc2e65e Javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711197 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-29 09:28:38 +00:00
Javen O'Neal
1396738460 bug 58557: fix from Alessandro Guarascio, shift hyperlinks when shifting rows on an XSSFSheet 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711185 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-29 06:53:55 +00:00
Andreas Beeker
1d1bdc1521 Common sl unification - copy first paragraph / textrun properties on XSLFTextShape.setText() 
Common sl unification - converted ApacheconEU08 example to common sl - added missing functionality
Common sl unification - return null instead of default values for missing borders X/HSLFTable
Common sl unification - use points in HSLFTable.setColumnWidth()
Fix appending text to empty HSLFTextParagraph


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711171 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-29 01:05:27 +00:00
Nick Burch
632228a34e #58558 SXSSFCell.setCellValue((RichTextString)null) fixed to work like XSSF and HSSF, with common unit tests to verify this 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711082 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-28 17:42:56 +00:00
Dominik Stadler
856bbf97f4 Fix Sonar-Maven build, correctly determine path to test-file 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710694 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-26 20:48:38 +00:00
Dominik Stadler
f1f08de7fb Apply some micro-optimization which helps when retrieving the string-value of large spreadsheets 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710692 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-26 20:48:32 +00:00
Dominik Stadler
c7ebebcbb1 Bug 56957: Avoid error if Workbook with empty SharedStringTable is written 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710521 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-26 07:54:06 +00:00
Nick Burch
90db0bf451 Fix javadoc warning - @see with a URL needs wrapping in an a-href tag 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710460 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-25 16:19:35 +00:00
Nick Burch
e966499ad2 #58532 For Excel cell formats with 3+ parts to them (eg +ve,-ve,0), which 
DataFormatter didn't properly support, call out to the alternate CellFormat
 instead for the formatting.
This also allows us to enable some disabled parts of DataFormatter unit tests
We still need to rationalise DataFormatter and CellFormatter though, so we
 only have one set of cell formatting logic...


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710399 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-24 23:34:47 +00:00
Javen O'Neal
538b2d1377 bug 33174: Use common unit test for testNoMergedRegionsIsEmptyList 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710140 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-23 08:38:14 +00:00
Dominik Stadler
27d4814b80 Set newer curvesapi-version in .classpath as well and update some third-party libs for the password-protection-code to the latest versions 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710032 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-22 15:21:25 +00:00
Dustin Spicuzza
fe771aa808 XDGF: fix the fix 
- Use Collections.emptySet() for an iterator instead
- Bump curvesapi to 1.03, which is compiled for JDK 1.5

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709463 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-19 18:36:45 +00:00
Dustin Spicuzza
9c23e12b8e XDGF: fix jdk < 1.8 compat 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709427 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-19 14:55:30 +00:00
Dustin Spicuzza
f540622a05 XDGF: fix jenkins build errors 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709363 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-19 06:55:06 +00:00
Dustin Spicuzza
e0a5e102b8 Add Visio OOXML text extractor + tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709361 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-19 06:26:57 +00:00
Dustin Spicuzza
879ca64994 Add some limited XDGF documentation 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709357 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-19 06:08:58 +00:00
Dustin Spicuzza
e3365dfaeb poi-import: fix build dependencies 
- Compilation + tests work now

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709356 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-19 05:59:42 +00:00
Dustin Spicuzza
d70b8e8b88 poi-visio import: reformat code to fit project standards, remove JRE 7isms 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709355 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-19 05:59:37 +00:00
Dustin Spicuzza
3bd2011924 Import poi-visio codebase 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709354 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-19 05:52:35 +00:00
Dominik Stadler
3a8f40db7c Bug 58499: Don't report Zip-Bomb for small files which should not cause memory issues anyway 
Also make error message a bit more specific and list classname in Zip-Bomb-Error to make it easier for users what the
problem is and how to find out where the static methods are

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709180 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-17 14:40:36 +00:00
Dominik Stadler
43ab1cd35a Use the default XmlOptions for all the invocations of the XmlBeans XML parsing 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709128 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-17 08:45:25 +00:00
David North
bb18031ac7 Remove unnecessary warning suppressions 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1708921 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-16 09:00:43 +00:00
Andreas Beeker
a0a197bc96 javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1708265 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-12 23:10:02 +00:00
Andreas Beeker
5fd71db914 - removed deprecated and confusing methods in XSSFColor 
- sonar fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1708236 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-12 20:43:42 +00:00
Dominik Stadler
7fbf591db5 Retry which measures duration a few times to see if that reduces the number of failures caused by this test sometimes when CI machines are loaded. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1707488 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-08 11:08:41 +00:00
Dustin Spicuzza
bf68d5f290 Bug 58048: Add visio schemas to the OOXML jar 
- Bumped OOXML jar version also

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1707177 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-07 02:41:30 +00:00
Andreas Beeker
62561d5f53 sonar fixes and closing resources after use 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706937 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-06 00:04:12 +00:00
David North
2dc93d4411 Fix for https://bz.apache.org/bugzilla/show_bug.cgi?id=58466 
ColumnHelper now preserves information on multiple changes to the same group, hopefully while preserving the faster implementation intended by the original patch.

NB changes to TestXSSFSheet: the behaviour of column group collapsing/expanding is now closer to what Excel does than before.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706789 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-05 10:31:33 +00:00
Andreas Beeker
eee32c0480 fixed sonar issues and eclipse warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706742 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-05 00:28:54 +00:00
Andreas Beeker
98e93217fe sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706648 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-04 00:35:30 +00:00
Andreas Beeker
2de9d527b4 sonar fixes 
Very interesting was the exception swallowing in PackagePropertiesPart. When it was properly thrown, it already led to various errors in the junits test - I've fixed the handling for at least the ones which are in our test set

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706169 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-30 23:06:39 +00:00
Dominik Stadler
9deb59f263 Verify that bug 51998 is actually fixed since some time already. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1705855 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-29 13:09:47 +00:00
Andreas Beeker
ffd1f4333e sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1705814 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-29 08:31:15 +00:00
Dominik Stadler
72ae82f7dc Verify that bug 45541 can be resolved, add some more checks in XSLFFileHandler 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1705804 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-29 06:08:08 +00:00
Andreas Beeker
6f7f16853e Removed HDF API 
Sonar fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1705779 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-28 21:26:06 +00:00
Andreas Beeker
5cd3436295 Sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1705587 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-27 22:14:25 +00:00
Andreas Beeker
abfe427e72 - a few findbugs/sonar fixes 
- removed obsolete openxml4j signature classes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704964 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-23 23:22:46 +00:00
David North
c93ded0f36 Make XSSF and HSSF consistent in getMergedRegions - return empty list if there are none, rather than an exception. Tests for this. 
https://bz.apache.org/bugzilla/show_bug.cgi?id=58350

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704839 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-23 12:53:13 +00:00
Dominik Stadler
5e6b975b1c Ensure that the ThreadLocal-Biff-Password is reset correctly after each usage, we had some unit tests failing sporadically due to this 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704710 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-22 19:50:37 +00:00
Andreas Beeker
6488170c6d removed common sl path 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704207 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-21 00:16:36 +00:00
Andreas Beeker
dec09d2713 - #58216 - provide picture-shape resize that maintains the aspect ratio 
- moved SlideShowFactory to Common SL
- changed get/setAnchor to Rectangle instead of Rectangle2D
- Fixed some Common SL generic definitions
- picture dimensions are now in points and an additional method exists for pixels

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704206 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-21 00:09:45 +00:00
Dominik Stadler
d61ea07e26 Bug 58333: Apply patch to verify behavior on row-index before and after the limits set by the specification 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704186 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-20 20:16:17 +00:00
Dominik Stadler
f2cd7ed8f5 Bug 58332: Adjust implementation of dev-util 'MemoryUsage' to print out information if limits are reached instead of OOM 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704182 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-20 20:05:36 +00:00
Andreas Beeker
f3004e6185 close resources in junit tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704124 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-20 12:02:40 +00:00
Andreas Beeker
18395d5c3b - #58207 - Provide user access to the original image dimensions (XSLF) 
- same for hslf / common sl
- unify method names in H/XSLF Slideshow for common sl
- add/fix header information for PICT/EMF/WMF

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704097 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-20 02:25:35 +00:00
Dominik Stadler
6dda58db90 Apply patch from bug 57890 to add support for different datatypes in XSSFImportFromXML 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1703665 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-17 18:30:13 +00:00
Nick Burch
20b44d546e Javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1703575 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-17 11:18:15 +00:00
Nick Burch
9647b62d1a Patch from Javen ONeal from bug #58245 - Make Workbook support iterating over Sheets 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1703573 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-17 11:10:11 +00:00
Dominik Stadler
a5918f26fe Update javadoc for bug 56129 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1702805 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-13 19:32:50 +00:00
Dominik Stadler
c6f875fbb9 Eclipse warnings, comment out dead code, close resources, enhance unit tests, javadoc, ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1702802 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-13 19:05:55 +00:00
Dominik Stadler
42053fcf71 Verify that bug 55406 can be closed WORKSFORME 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1702800 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-13 19:05:28 +00:00
Dominik Stadler
fb88108e30 Add test case for bug 54399 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1702786 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-13 14:48:58 +00:00
Andreas Beeker
50777f1e48 fix eclipse warning - mostly generics cosmetics 
close resources in tests
junit4 conversions
convert spreadsheet based formular test to junit parameterized tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1702773 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-13 12:36:56 +00:00
Andreas Beeker
5f94d8b533 fix eclipse warning - mostly generics cosmetics 
close resources in tests
junit4 conversions
convert spreadsheet based formular test to junit parameterized tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1702659 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-12 18:45:07 +00:00
Andreas Beeker
aea434a135 forbidden apis fixes - a few DateFormat clean ups ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701888 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-09 00:41:03 +00:00
Andreas Beeker
50107cae16 Bug 58326 - Forbidden APIs patches - second set of changes for charset settings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701713 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-08 00:04:12 +00:00
Andreas Beeker
91e6a64627 forbidden apis fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701710 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-07 22:34:21 +00:00
Andreas Beeker
aaafb0270d Bug 58326 - Forbidden APIs patches - first set of changes for locale and timezone settings 
also includes fixes for
- name shadowing 
- unused deprecated method "getClipRect" in classes extending Graphics2d
- HexDump - replaced intermediate String.format calls with custom padding
- convert testcases to junit4
- closing resources

also tested with an arbitary timezone (PST) and locale (ru)

supresses forbidden apis check for
- LocaleUtil (the only place where Locale.getDefault() and TimeZone.getDefault() should be called)
- Classes using FontMetrics - without the actual text it's difficult to return something sane

Some usage of UTC and Locale.ROOT might be still wrong, e.g. in MapiMessage we don't access the
extended mapi properties, which might contain the timezone

DataFormatter has now a Observable property which need to be observed when custom formats are used
and the Locale changes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701688 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-07 20:19:50 +00:00
Andreas Beeker
3166646249 Bug 58326 - Forbidden APIs patches - first set of changes for locale and timezone settings 
commit single files because of svn failures ...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701684 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-07 20:14:33 +00:00
Dominik Stadler
782739541a Bug 58315: Avoid NPE for RichTextString without font-details 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701382 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-05 12:57:04 +00:00
Dominik Stadler
b2bd6a0a4c Eclipse warnings, close resources in CommandLineTextExtractor, add try/finally, formatting, ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701139 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-03 20:59:14 +00:00
Dominik Stadler
dab5f4c078 Fix bug 53275: reset indexed color flag when setting a non-indexed color 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701134 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-03 20:46:23 +00:00
Dominik Stadler
f7e0bdea37 Add unit test which verifies that bug 53105 is actually fixed now 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701133 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-03 20:46:14 +00:00
Dominik Stadler
4b8c20a7ca Add unit tests to verify that bug 51626 and bug 51451 are fixed 
Conflicts:
	src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFBugs.java

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701132 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-03 20:46:04 +00:00
Dominik Stadler
fcfe2e2a71 Add unit tests which verify that the issues from bug 48962 and 50755 do not occur any more on the latest version 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701131 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-03 20:45:55 +00:00
Nick Burch
aa455c91fd Fix some Forbidden APIs errors 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700670 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-01 21:09:20 +00:00
Nick Burch
47fb9df1a1 Fix some Forbidden APIs errors 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700644 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-01 19:06:53 +00:00
Nick Burch
533e1c8dcb Fix some Forbidden APIs errors 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700642 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-01 19:01:36 +00:00
Nick Burch
f098eca5a0 Fix some Forbidden APIs errors 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700635 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-01 18:37:07 +00:00
Dominik Stadler
6bdc2fb024 Add possibility to set zoomPercent for XWPFDocument 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1697992 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-26 19:34:28 +00:00
Andreas Beeker
cd536720dd common sl: reworked and unified generics definitions 
made various methods available through common sl
added createTextBox,AutoShape,... methods to ShapeContainers
hslf tables created by poi, will be identified as such when the file is read again

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1697515 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-24 23:15:14 +00:00
Nick Burch
0d7476e130 Tweak error message to make clear that we really need a file showing the problem 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1697502 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-24 21:20:01 +00:00
Nick Burch
d662021baf Javadoc tweak 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1697462 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-24 17:55:57 +00:00
Dominik Stadler
639b847d6e Reduce required memory in tests by not actually creating all the rows/cells when verifying the max number of cellstyles. Hopefully this will avoid the OOMs that we see in various CI environments currently while still verifying the limits correctly. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1697326 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-24 08:12:01 +00:00
Dominik Stadler
39163eccff Eclipse warnings, code formatting, missing @Overrides, Javadoc, missing close(), ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696794 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-20 14:28:39 +00:00
Dominik Stadler
c275dea88c POI Bug 58260: Fix checks for limit on number of styles in XSSF/SXSSF and fix having more than 32k styles in SXSSF workbooks 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696586 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-19 13:36:08 +00:00
Dominik Stadler
580171fe27 Adjust excludes to make the output a bit cleaner in OOXMLLite and also look in the superclass for @Test annotations to include one additional unit-test that we missed currently. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696577 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-19 13:03:05 +00:00
David North
2af2fa28c2 Improve ReadOnlySharedStringsTable to cope gracefully with an empty SST part. 
https://bz.apache.org/bugzilla/show_bug.cgi?id=58262

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696559 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-19 11:10:13 +00:00
Dominik Stadler
1e45197f59 * Adjust reported text when a Zip-Bomb is detected to allow to quickly see why it happened 
* Fail only with inflation ratio lower than the min, not equals, to behave as documented
* Add getters to be able to temporarily adjust the limits for unit tests
* Allow lower inflation ratio in OOXMLPrettyPrint as this is a dev-only tool

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696556 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-19 10:57:19 +00:00
David North
5706c2ac9b Make intersection formulae work in XSSF. Patch from Matt Hillsdon plus additional tests. 
https://bz.apache.org/bugzilla/show_bug.cgi?id=52111

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696549 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-19 10:10:08 +00:00
Dominik Stadler
0377dbbb3e Bug 54938: Throw InvalidFormatException as documented instead of IllegalArgumentException in WorkbookFactory.create() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696338 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-17 20:54:32 +00:00
Dominik Stadler
0345110611 Try to make Sonar builds run again: add missing dependency, add ooxml-schema-security, don't depend on dir test-data and build-directory directly, don't override a POILogger that is set via System Properties 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696165 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-16 20:51:40 +00:00
Andreas Beeker
05c92b7a19 FindBugs - DLS_DEAD_LOCAL_STORE 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696038 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-15 11:57:57 +00:00
Nick Burch
6be4fc05d2 Remove catches which were previously incorrectly declared when not needed 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695775 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-13 20:31:25 +00:00
Nick Burch
1a84b476e8 #58237 When adding a picture to a XWPF header or footer, attach it to the right part 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695772 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-13 20:23:58 +00:00
Nick Burch
cfbc261e65 #58237 Add some more XWPF header and footer tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695769 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-13 20:01:04 +00:00
Nick Burch
d9697de075 Fix inconsistent line endings and some eclipse warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695757 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-13 19:20:58 +00:00
Andreas Beeker
0e1aa75750 findbugs - DM_NUMBER_CTOR 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695635 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-13 00:38:04 +00:00
Andreas Beeker
3ac2d2905a findbugs - DM_BOXED_PRIMITIVE_... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695629 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-13 00:17:08 +00:00
Nick Burch
6d46fc382f #58220 - Improve the javadocs for XSSFFont and Font getFontHeight methods 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695528 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-12 14:14:12 +00:00
Nick Burch
ac8ed40f80 Fix some eclipse warnings, add TODOs for fields/hyperlinks XWPF add support, and give a more helpful exception if someone tries to remove a XWPFRun that is not a direct paragraph child 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695365 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-11 20:10:53 +00:00
Nick Burch
87a2acf935 Support XWPF field runs, the same way that we handle hyperlink runs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695361 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-11 20:01:26 +00:00
Dominik Stadler
ccc4ebcf70 Bug 56479: don't hardcode dcterms as namespace alias in the attribute, but expect the actual alias that is used in the corresponding element. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695212 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-11 05:37:15 +00:00
Andreas Beeker
750558d8d9 #56519 - XSLFSlide.draw is not working with text embeded in PPTX 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694925 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-09 22:44:13 +00:00
Nick Burch
bdb00633a3 Complete theme colour tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694892 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-09 14:15:00 +00:00
Nick Burch
5b97e55997 Get theme and non-theme rows consistent in the test file 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694889 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-09 13:30:35 +00:00
Nick Burch
d2a95d0901 Begin Themes+Normal colour tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694887 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-09 13:06:40 +00:00
Nick Burch
3abeb347a6 Fix the themes test for the complex workbook 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694883 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-09 12:36:57 +00:00
Andreas Beeker
d0e0f0cb97 #58205 - getSlideMasters() returns the master slides in the incorrect order 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694592 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-07 00:17:55 +00:00
David North
66fbc9d44e Example to go with refactor for https://bz.apache.org/bugzilla/show_bug.cgi?id=58219 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694536 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-06 16:37:09 +00:00
David North
9730ff9cd6 Proposed refactor for: 
https://bz.apache.org/bugzilla/show_bug.cgi?id=58219

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694531 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-06 15:57:48 +00:00
Andreas Beeker
f28588fbb3 #57786 - XSLFFreeformShape ignores quadratic bezier curves 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694373 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-05 23:24:13 +00:00
Andreas Beeker
e5069da22a #58206 - provide a mechanism to find slide layouts by name 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694340 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-05 22:46:42 +00:00
Andreas Beeker
91353085b5 #58204 - STYLE: ShapeContainer interface makes internal getShapesList() redundant 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694335 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-05 21:44:01 +00:00
Nick Burch
1f6594c244 Stub next test 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694127 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-04 23:26:20 +00:00
Nick Burch
b2ab81ad81 Use an enum to simplify the themes code and tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694125 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-04 23:14:23 +00:00
Nick Burch
f78eac8c41 Pull out indexes from the switch statement to constants, and fix warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694121 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-04 22:46:27 +00:00
Andreas Beeker
1241a24ebb move setting of xmlinputfactory from junit to gump-meta/poi.xml 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694120 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-04 22:24:31 +00:00
Nick Burch
885368e2ce Further XSSF Themes unit testing 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694093 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-04 17:50:44 +00:00
Andreas Beeker
adfcf4d251 FindBugs fixes - MS_SHOULD_BE_FINAL 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693984 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-03 23:36:28 +00:00
Andreas Beeker
0a42120b89 Javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693983 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-03 23:30:13 +00:00
Andreas Beeker
5a4575bb8c gump build fixing - move system properties tinkering into junit class 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693978 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-03 23:09:10 +00:00
Andreas Beeker
77315b425f Trying to fix the wrong xmlinputfactory on gump run 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693830 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-02 21:29:23 +00:00
Andreas Beeker
6b8af03c42 #58190 - The current picture handling uses raw integers for types and index, replace with enum and reference 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693825 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-02 20:21:35 +00:00
Nick Burch
42bf5e5fc6 Use the same "is this a formula" logic for both getCellType and getCachedFormulaResultType 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693767 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-01 21:34:34 +00:00
Andreas Beeker
98ed7bb5fb #58193 - Use input stream rather than byte array for checksum etc. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693754 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-01 20:09:37 +00:00
Nick Burch
fb731a62a5 Unit test for bug #57181 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693676 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-01 00:25:20 +00:00
Nick Burch
098177f39e Re-enable some SXSSF skipped tests, but not all, for our limited evaluation support #58200 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693663 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-31 22:16:53 +00:00
Nick Burch
0b6add86ac Start re-enabling some SXSSF formula evaluation tests, with required fixes #58200 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693662 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-31 22:07:58 +00:00
Nick Burch
1761949b02 Refactor the core part of the XSSF Formula Evaluator, to make SXSSF overrides easier #58200 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693661 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-31 22:04:16 +00:00
Nick Burch
4782319fd1 More helpful exception on the wrong cell type 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693656 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-31 21:44:56 +00:00
Nick Burch
a11d4082ca Get basic SXSSF formula evaluation working, for cells/references in the window #58200 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693654 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-31 21:31:53 +00:00
Nick Burch
5b22ad3be6 Push most of the common logic from XSSFEvaluationWorkbook into BaseXSSFEvaluationWorkbook, and start to use it for SXSSF as well #58200 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693647 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-31 20:40:41 +00:00
Nick Burch
070ac341d2 Remove a long-deprecated constructor 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693646 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-31 20:38:36 +00:00
Nick Burch
72909b1e6d Fix inconsistent indents/whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693645 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-31 20:24:29 +00:00
Nick Burch
af9f83fd08 Prepare for SXSSF evaluation #58200 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693644 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-31 20:22:11 +00:00
Nick Burch
66d370a978 #58200 Prepare for evaluating SXSSF cell formulas in limited cases 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693641 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-31 19:19:33 +00:00
Nick Burch
fcbd93a768 Use more specific return types in SXSSF, which avoids casts, and also fix some long-standing TODOs on 1904 dates 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693633 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-31 17:23:01 +00:00
Nick Burch
2ad973852c Have XSSF rich test strings report if they have formatting applied or not, and fix them to only add the formatting child element when needed 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693632 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-31 17:22:05 +00:00
Andreas Beeker
b6b3853330 temporary activate jaxp debugging to find jaxb/stax error on gump build 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1692944 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-27 20:24:09 +00:00
Dominik Stadler
4728df5b6a Improve error message slightly, add tests to verify things failing in Gump-build currently 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1692836 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-27 08:44:04 +00:00
Andreas Beeker
b2e18cf5ed Javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1692674 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-26 00:25:27 +00:00
Andreas Beeker
fe3b8e5eec Annotation for unimplemented drawing handlers. 
Ignore unsupported image types (e.g. wmf).

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1692640 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-25 19:24:51 +00:00
Andreas Beeker
5d267dd16d fixed NPE with Jaxb proxy classes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1692598 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-25 00:25:07 +00:00
Andreas Beeker
f5e9adea84 merged common_sl branch to trunk 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1692593 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-24 21:47:55 +00:00
Dominik Stadler
0a9a9e13f7 Bug 57571, Bug 58175: Fix creating comments for XSSF/SXSSF, regression was introduced via bug 54920 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1692483 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-24 11:58:01 +00:00
Nick Burch
a6779a3c02 Allow creating of an empty Themes Table on request 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1692211 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-22 00:04:59 +00:00
Nick Burch
8bb5d65cf8 Javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1692210 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-21 23:57:44 +00:00
Dominik Stadler
ed7d892de7 Bug 58156: Possible data corruption in hasPOIFSHeader and hasOOXMLHeader 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691948 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-20 14:03:35 +00:00
Nick Burch
5e77d18b53 Fix inconsistent whitespace/indents 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691871 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-20 04:56:05 +00:00
Nick Burch
b7d27d44ce #58130 CF DataBar example and tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691869 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-20 04:43:36 +00:00
Nick Burch
104d9ad8e3 #58130 CF DataBar support 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691868 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-20 03:52:50 +00:00
Nick Burch
ac6aab29cf #58130 Begin CF DataBar support 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691867 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-20 03:21:57 +00:00
Nick Burch
164aa4c7c6 #58130 Support for creating CF Color Scale Formattings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691866 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-20 02:49:12 +00:00
Nick Burch
eee0fb2835 Move some of the XSSF Color logic to a base class, so that the HSSF Extended Color wrapper can use it 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691864 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-20 00:46:50 +00:00
Nick Burch
7261a10654 #58130 Enable CF ColorScale support on the rule, and begin testing 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691860 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-19 22:35:37 +00:00
Nick Burch
1f12ed1002 XSSF color scale CF objects 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691859 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-19 22:22:09 +00:00
Andreas Beeker
58bf1455ec merge trunk to common sl branch 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/common_sl@1691845 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-19 19:32:41 +00:00
Andreas Beeker
d439f080d6 merge trunk to common sl branch 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/common_sl@1691843 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-19 19:00:32 +00:00
Dominik Stadler
8c1b7df4bc Bug 57484: Allow processing of non-OOXML core namespace packages 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691821 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-19 12:11:19 +00:00
Nick Burch
6cfa6ee7e4 #58130 Mostly there with CF Icon sets 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691679 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-18 04:55:27 +00:00
Nick Burch
4780ccf161 Start on XSSF CF Iconset for #58130 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691479 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-17 02:55:22 +00:00
Nick Burch
a22ab7249f XSSF CF thresholds 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691478 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-17 02:41:20 +00:00
Nick Burch
0cde71224d #58130 more progress towards supporting other CF types 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691472 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-17 01:20:20 +00:00
Dominik Stadler
651f03cc64 * Make on unit test not fail if Fonts are not available on the machine 
* Refactor SheetUtil a bit to reduce code-duplication, adjust JavaDoc for -1 return values
* Add method to check if we can compute text-width
* Add unit-tests which verify some more of SheetUtil

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691341 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-16 09:06:47 +00:00
Andreas Beeker
d8bf3aae84 junit fixes 
set font size via Double
color handling via HSL calculation

git-svn-id: https://svn.apache.org/repos/asf/poi/branches/common_sl@1691117 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-15 00:30:21 +00:00
Nick Burch
a6836c595f Start checking the CF colours in the unit tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691092 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-14 21:45:23 +00:00
Nick Burch
e0f6ff5ca1 #58138 CF Border colour getters and setters on Color objects as well as shorts 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691083 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-14 21:19:13 +00:00
Nick Burch
8a62462905 Support unsetting the XSSF CF pattern colours 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691081 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-14 21:10:14 +00:00
Nick Burch
36c3b8d688 Cleaner code for checking and casting the Color objects 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691064 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-14 19:29:18 +00:00
Nick Burch
2eb88db1b0 Provide format-agnostic conditional formatting patter colour getters and setters 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691047 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-14 18:32:35 +00:00
Nick Burch
777806d350 Provide format-agnostic conditional formatting font colour getter and setter 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691045 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-14 18:05:28 +00:00
Nick Burch
892d7fa4d0 Constant for the Office 2010 Conditional Formatting extensions namespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691015 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-14 16:12:40 +00:00
Nick Burch
4632e35c3d Move some test checks to using ConditionType instead of raw bytes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1690808 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-13 20:11:47 +00:00
Nick Burch
fbf95cdb54 Enable CF2007 test for XLSX too 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1690805 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-13 19:56:09 +00:00
Nick Burch
9217c91425 Provide a Conditional Formatting type class, and deprecate the byte-based types, to better work with the wider range 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1690803 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-13 19:47:21 +00:00
Nick Burch
fdd0d249ca CFRule12 tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1690778 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-13 17:54:28 +00:00
David North
24612d3e82 Add Sheet.getMergedRegions to obtain them all as a list. Implement this for XSSF using "deprecated" methods in XMLBeans which allow the operation to be linear in the number of regions rather than n-squared. 
Fixes #57893

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1690661 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-13 13:00:35 +00:00
Dominik Stadler
da56e012c3 Bug 58113: Fix regression: NullPointerException when setting cell value to null 
add unit tests which verifies this for all three SS-implementations

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1690652 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-13 12:17:52 +00:00
David North
2f8aa558b3 Patch from Chris Boyle to add basic support for .xlsm (macro-enabled) workbooks. The binary blob containing the VBA macros may be copied from one such workbook into another. 
Fixes #58036

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1690593 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-13 09:05:17 +00:00
Andreas Beeker
65538c0f71 JUnit and rendering fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/common_sl@1690421 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-12 00:38:39 +00:00
Andreas Beeker
ee53e203c0 added ASL header to drawing classes 
fixed a few rendering NPEs
added dummy interfaces for table / connector shapes

git-svn-id: https://svn.apache.org/repos/asf/poi/branches/common_sl@1690185 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-09 22:46:29 +00:00
Dominik Stadler
0f24b7532c OOXMLPrettyPrint: Populate the standalone-attribute always to avoid differences in the resulting XML files from Excel and POI 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1689794 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-08 05:57:32 +00:00
Andreas Beeker
6fe5b7bf51 downgraded xjc params to jdk6 and regenerated geometry binding classes 
added rendering for auto numbers
fixed various bugs on failing tests
changed xslf paragraph indent to indentLevel to align with hslf
added escher record factory subclass to hslf, to eventually make hslf wrapper classes obsolete

git-svn-id: https://svn.apache.org/repos/asf/poi/branches/common_sl@1689777 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-08 00:09:34 +00:00
Dominik Stadler
efc96e1d8e Open file read-only in test to avoid making it dirty during running unit tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1688045 13f79535-47bb-0310-9956-ffa450edef68
 2015-06-28 19:55:56 +00:00
Dominik Stadler
bde247f61a Fix test to find the exception-text in all cases 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1687212 13f79535-47bb-0310-9956-ffa450edef68
 2015-06-24 08:53:25 +00:00
Dominik Stadler
5103ea7c0c show full exception stack-trace if zip-bomb detection test fails 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1687197 13f79535-47bb-0310-9956-ffa450edef68
 2015-06-24 08:33:06 +00:00
Andreas Beeker
7393f122b2 Removed Java7 calls 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1687176 13f79535-47bb-0310-9956-ffa450edef68
 2015-06-24 07:06:01 +00:00
Andreas Beeker
c0cb680292 Bug 56865 - Limit number of bytes (by counting them) while opening office docs 
Bug 50090 - 'zip' bomb prevention

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1687148 13f79535-47bb-0310-9956-ffa450edef68
 2015-06-23 23:39:07 +00:00
Dominik Stadler
e4f5df42f6 Bug 56655: Fix Sumifs for cases where the criteria is in error. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1686610 13f79535-47bb-0310-9956-ffa450edef68
 2015-06-20 13:10:28 +00:00
Dominik Stadler
cb5588c4a1 Bug 56420: Fix possible NullPointerException when empty cell is included in Sumif calculation 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1686564 13f79535-47bb-0310-9956-ffa450edef68
 2015-06-20 11:29:14 +00:00
Andreas Beeker
f97d6f6c34 Rendering fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/common_sl@1686117 13f79535-47bb-0310-9956-ffa450edef68
 2015-06-17 22:21:13 +00:00
Dominik Stadler
13eb52f12f Move more tests into base class and add a TestSXSSFBugs class to verify some things that are supported against SXSSFWorkbook as well 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1686035 13f79535-47bb-0310-9956-ffa450edef68
 2015-06-17 14:53:38 +00:00
Dominik Stadler
e7d33e4ccb Make setLandscape(false) and setLeftToRight(false) do what one would expect 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1686019 13f79535-47bb-0310-9956-ffa450edef68
 2015-06-17 14:26:31 +00:00
Dominik Stadler
f77cdd40b4 add missing license header 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1685506 13f79535-47bb-0310-9956-ffa450edef68
 2015-06-15 08:17:08 +00:00
Andreas Beeker
2170a52383 Rendering of rotated group shapes fixed, other smaller fixes, defaulting to white transparent slide background 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/common_sl@1685344 13f79535-47bb-0310-9956-ffa450edef68
 2015-06-13 23:26:46 +00:00
David North
16a9eca7c8 My own patch to fix #56328 
Add tests for initial patch applied by Nick in r1582892

Fix and test AreaReference#isWholeColumnReference to take account of the prevailing spreadsheet version. Fixing all users of this is a big undertaking, so for now I've left a fallback on the original behaviour for some cases.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1685101 13f79535-47bb-0310-9956-ffa450edef68
 2015-06-12 15:20:10 +00:00
Andreas Beeker
4acc6a84a1 Fixed TextRun handling and various junit tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/common_sl@1684773 13f79535-47bb-0310-9956-ffa450edef68
 2015-06-10 22:23:47 +00:00
David North
c580758b2c Use a different arbitrary value for the ID of the comment shape type. This appears to prevent Excel >= 2010 from turning POI-written comments into the wrong shape (giant curved arrow). 
Fixes https://bz.apache.org/bugzilla/show_bug.cgi?id=55410

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1683315 13f79535-47bb-0310-9956-ffa450edef68
 2015-06-03 12:50:10 +00:00
Tim Allison
ca17056096 POI-57975: clean up white spaces and other style issues in XWPF 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1682473 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-29 14:01:31 +00:00
Tim Allison
b8f9c0cad1 POI-57889 -- actually trigger inclusion of CTNumLvl with document contributed by Moritz Dorka on TIKA-1315 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1682310 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-28 19:08:24 +00:00
Nick Burch
a727593a41 Correct package 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1682210 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-28 11:15:07 +00:00
Nick Burch
c5c70d3ce4 Pull out the parts of TextPainter needed by XSLF from HSLF to common-SL in core #57963 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1682209 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-28 11:13:23 +00:00
Dominik Stadler
03805d9e20 Add WorkbookFactory.create() with a flag to allow to open files read-only, keep the current way of opening read/write as default to not break existing code. 
Also adjust Javadoc somewhat.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1681823 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-26 19:30:21 +00:00
Dominik Stadler
9017803980 Make POIXMLDocument implement Closeable as it holds an OCPPackage with open resources and thus should be closed after usage. Until now only XSSFWorkbook did this, but it makes sense for all derived classes. 
Also make close() in POIXMLDocument public to not have to re-implement it in all sub-classes.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1681822 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-26 19:30:04 +00:00
Dominik Stadler
589b189151 Prevent problems reported in Bug 56574 by ensuring that Cells are properly removed when a row is overwritten by calling createRow() with it's rownum. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1680280 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-19 13:13:09 +00:00
Dominik Stadler
dafabdc7b9 Move location where document is held and adjust constructors and class-hierarchy accordingly 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1679903 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-17 21:26:31 +00:00
Nick Burch
dd8fc66a0c #56791 More updates from OPOIFS to NPOIFS 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678801 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-11 18:59:10 +00:00
Nick Burch
8bd0d5b819 Refactor common default styles code to use the new helpers 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678197 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-07 13:34:03 +00:00
Nick Burch
120608b1f9 Start exposing the default paragraph and run styles from XWPFStyles 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678193 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-07 13:25:47 +00:00
Nick Burch
1c693babb8 Fix inconsistent whitespace/indents 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678188 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-07 13:08:15 +00:00
Nick Burch
9fd1832753 Start on XWPFStyles support for document default styles 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678187 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-07 13:07:00 +00:00
Nick Burch
9a755850e9 Begin on test for going from xwpf text to style 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678179 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-07 12:37:43 +00:00
Dominik Stadler
ea27ddf601 Try to fix flaky test by waiting for a switch of the second to ensure that we have the same timestamps in the two workbooks that we compare byte-wise in this test. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1677950 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-06 08:42:28 +00:00
Andreas Beeker
02bbe3b566 OOM fix for gump run 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1677913 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-05 23:51:10 +00:00
Tim Allison
8bfc6056c8 POI-57889 prevent NPE with on some documents with XWPFParagraph's getNumFmt() and add some other classes to enable calculation of paragraph numbers 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1677723 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-05 01:39:16 +00:00
Nick Burch
e9340cc1ba If an empty stream or file is given to WorkbookFactory.create, give a more informative exception - EmptyFileException 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1677562 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-04 09:15:48 +00:00