Commit Graph

5934 Commits

Author SHA1 Message Date
Nick Burch
2185e91883 Unit test for VBA macro reading #52949
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738427 13f79535-47bb-0310-9956-ffa450edef68
2016-04-10 12:45:53 +00:00
Nick Burch
82351e8fea Start to refactor VBAMacroExtractor into a more general class
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738423 13f79535-47bb-0310-9956-ffa450edef68
2016-04-10 11:54:09 +00:00
Nick Burch
4abcc6626a VBA extraction support from bug #52949 from Barry Lagerweij
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738418 13f79535-47bb-0310-9956-ffa450edef68
2016-04-10 11:16:49 +00:00
Dominik Stadler
2a0ed81538 Bug 57844: Add some javadoc for unimplemented features in SXSSF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738413 13f79535-47bb-0310-9956-ffa450edef68
2016-04-10 09:40:40 +00:00
Tim Allison
a060c664a1 close fileinputstream on second exception in ZipPackage
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738251 13f79535-47bb-0310-9956-ffa450edef68
2016-04-08 14:36:05 +00:00
Dominik Stadler
3718d45538 In Example FromHowTo, open the OPCPacakge read-only to not try to write it back on close()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738097 13f79535-47bb-0310-9956-ffa450edef68
2016-04-07 07:25:02 +00:00
Dominik Stadler
5c1780aa72 Close two more file-handles in Example FromHowTo
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738035 13f79535-47bb-0310-9956-ffa450edef68
2016-04-06 19:50:20 +00:00
Dominik Stadler
8b10d4d71b Tried to evaluate all formulas in worksheets as part of the integration tests, but some documents fail and it probably increases runtime of tests considerably, so left commented out for now.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738034 13f79535-47bb-0310-9956-ffa450edef68
2016-04-06 19:50:14 +00:00
Dominik Stadler
b9e7c32ffe Bug 58648: Fix handling whitespaces in formulas, unfortunately blank can be the intersection operator as well, so we need to try and skip it as whitespace if intersection fails which can lead to hard to track bugs or misleading error messages with some formulas
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738033 13f79535-47bb-0310-9956-ffa450edef68
2016-04-06 19:50:08 +00:00
Dominik Stadler
ec6bb2a066 Slightly improve error message
Fix some IntelliJ/compiler warnings
Use common interfaces where possible
Cleanup after testing POIFSDump

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738032 13f79535-47bb-0310-9956-ffa450edef68
2016-04-06 19:49:59 +00:00
Dominik Stadler
62ee0abc13 Code cleanup via IntelliJ: Remove unnecessary semicolon
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738031 13f79535-47bb-0310-9956-ffa450edef68
2016-04-06 19:49:47 +00:00
Dominik Stadler
2c4a66ee49 Add missing license header
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737963 13f79535-47bb-0310-9956-ffa450edef68
2016-04-06 10:52:36 +00:00
Dominik Stadler
5dc647da61 Bug 56911: Fix IndexOutOfBoundsException in PlfLfo.add() and add minimal test, however these classes look quite untested and thus require more test-coverage to make them more robust
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737947 13f79535-47bb-0310-9956-ffa450edef68
2016-04-06 09:00:05 +00:00
Nick Burch
a456ad5d77 Fix javadoc warning - As per http://bugs.java.com/bugdatabase/view_bug.do;jsessionid=d014dfa686594180be40ca5872f5?bug_id=4907024 an @see is only allowed a single link with nothing after it
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737924 13f79535-47bb-0310-9956-ffa450edef68
2016-04-06 06:28:14 +00:00
Javen O'Neal
7fd89e0e39 add test coverage for TestSXSSFCell.toString() on blank and date cells
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737923 13f79535-47bb-0310-9956-ffa450edef68
2016-04-06 06:01:26 +00:00
Javen O'Neal
f9c74888e3 add test coverage for WorkbookFactory.create(File file, String password, Boolean readOnly) when file does not exists
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737917 13f79535-47bb-0310-9956-ffa450edef68
2016-04-06 05:15:15 +00:00
Javen O'Neal
bed6a46d10 bug 59264: fix javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737914 13f79535-47bb-0310-9956-ffa450edef68
2016-04-06 04:32:36 +00:00
Javen O'Neal
b8dcd4df42 bug 59264: fix findbugs warning 'A boxed value is unboxed and then immediately reboxed.'
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737896 13f79535-47bb-0310-9956-ffa450edef68
2016-04-06 00:06:53 +00:00
Javen O'Neal
c95f6a4b35 whitespace (tabs to 4 spaces)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737895 13f79535-47bb-0310-9956-ffa450edef68
2016-04-05 23:47:41 +00:00
Javen O'Neal
fe13debb84 bug 59264: move border style deprecations to POI 3.15 beta 2.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737894 13f79535-47bb-0310-9956-ffa450edef68
2016-04-05 23:30:37 +00:00
Javen O'Neal
e2399abbe9 bug 59264: type safety: check if border code is a valid BorderStyle enum for setBorderX(short)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737886 13f79535-47bb-0310-9956-ffa450edef68
2016-04-05 21:38:55 +00:00
Javen O'Neal
5752c4bb7e bug 59264: allow borders styles to be set with BorderStyles enums or Short codes for backwards compatibility
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737885 13f79535-47bb-0310-9956-ffa450edef68
2016-04-05 21:36:11 +00:00
Javen O'Neal
f7939c4c95 bug 59264: add link to BorderStyle on deprecated BORDER_* constants
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737884 13f79535-47bb-0310-9956-ffa450edef68
2016-04-05 21:34:24 +00:00
Javen O'Neal
1786767b89 bug 59264: use BorderStyle for changing Cell border line style
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737879 13f79535-47bb-0310-9956-ffa450edef68
2016-04-05 20:28:46 +00:00
Javen O'Neal
739196e5b3 bug 59264: copy cell border style codes (from CellStyle.java) into BorderStyle enum
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737752 13f79535-47bb-0310-9956-ffa450edef68
2016-04-04 23:27:20 +00:00
Javen O'Neal
8e1b343761 rearrange BORDER_DOTTED and BORDER_HAIR
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737751 13f79535-47bb-0310-9956-ffa450edef68
2016-04-04 23:26:44 +00:00
Dominik Stadler
b46a57926c Bug 55982: Don't fail to open the spreadsheet if no TabIdRecord is found
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737602 13f79535-47bb-0310-9956-ffa450edef68
2016-04-03 18:32:22 +00:00
Dominik Stadler
e8263f9d8f Fix two more places where wrong/invalid files can lead to file-handle leaks currently
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737489 13f79535-47bb-0310-9956-ffa450edef68
2016-04-02 11:01:56 +00:00
Dominik Stadler
205055b83c Prevent us from changing the file with every test-run
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737488 13f79535-47bb-0310-9956-ffa450edef68
2016-04-02 11:01:49 +00:00
Dominik Stadler
328c52aab7 Fix some cases where file handles are not closed in OldExcelExtractor
Close resources in some more tests to make the file-leak report clean again

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737487 13f79535-47bb-0310-9956-ffa450edef68
2016-04-02 11:01:43 +00:00
Dominik Stadler
1985e23f59 Regression: Add unit-test which triggers more code deep inside XSLF to have some missing pieces included in the reduced ooxml-schema-jar
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737466 13f79535-47bb-0310-9956-ffa450edef68
2016-04-02 06:38:39 +00:00
Nick Burch
29c2e05b58 Javadoc fix - Generics are type-erased so not included in the javadoc links
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737317 13f79535-47bb-0310-9956-ffa450edef68
2016-04-01 07:17:04 +00:00
Dominik Stadler
88e9ff08db Enhance integration tests to call some of the common examples/devtools to also trigger these with all sample files, currently XLSX2CSV, BiffViewer, FromHowTo
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737308 13f79535-47bb-0310-9956-ffa450edef68
2016-04-01 06:25:49 +00:00
Tim Allison
26af28bbdb POI 59257 upgrade Bouncy Castle to 1.54
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737298 13f79535-47bb-0310-9956-ffa450edef68
2016-04-01 00:57:56 +00:00
Dominik Stadler
316c1fe307 Bug 57930: Add support for inlineString in FromHowTo
Also do not require an Apache Xerces Parser, let the JDK choose an available one instead

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737247 13f79535-47bb-0310-9956-ffa450edef68
2016-03-31 14:39:11 +00:00
Dominik Stadler
12f99cc9d5 Adjust integration tests, fix compilation warnings, make the check on "EXPECTED_EXTRACTOR_FAILURES" actually work
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737242 13f79535-47bb-0310-9956-ffa450edef68
2016-03-31 13:56:27 +00:00
Dominik Stadler
d0513f2ca6 Apply patch from bug 58909 - Add a cloneSheet() which directly sets the sheetname to allow to avoid a costly renaming of sheets.
Combine related unit-tests into Base-Test-Classes to run them for all types of Workbook/Sheet/...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737237 13f79535-47bb-0310-9956-ffa450edef68
2016-03-31 13:32:05 +00:00
Dominik Stadler
33cf4c310b DumpPOIFS: Create a separate named sub-directory for each file to not overwrite each other when passing in multiple files for dumping, check for failing mkdirs()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737031 13f79535-47bb-0310-9956-ffa450edef68
2016-03-29 18:44:11 +00:00
Dominik Stadler
992adb9c16 Revert set of inadvertedly committed files/changes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737029 13f79535-47bb-0310-9956-ffa450edef68
2016-03-29 18:11:44 +00:00
Dominik Stadler
f5332a3a40 Bug 58915: Add note about memory consumption and update changelog
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737025 13f79535-47bb-0310-9956-ffa450edef68
2016-03-29 17:30:55 +00:00
Dominik Stadler
ff68b433b8 Bug 58915: Update javadoc for memory consumption and fix some other javadoc and compiler warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737024 13f79535-47bb-0310-9956-ffa450edef68
2016-03-29 17:27:20 +00:00
Dominik Stadler
00e6abb6bc Try to reproduce bug 58922, convert to JUnit 4
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737018 13f79535-47bb-0310-9956-ffa450edef68
2016-03-29 16:11:29 +00:00
Dominik Stadler
0888ad4de5 Fix some compiler warnings, improve error message, cover some more code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737013 13f79535-47bb-0310-9956-ffa450edef68
2016-03-29 15:45:04 +00:00
Dominik Stadler
02b29ea698 Bug 59132: Adjust implementation of COUNTBLANK to be conforming to Excel, empty strings are counted as blank as well
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737009 13f79535-47bb-0310-9956-ffa450edef68
2016-03-29 14:53:44 +00:00
Andreas Beeker
4eeffd0532 XSLF: do not display Master Slide objects by default
XSLF: fix alternate content handling for picture shapes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736935 13f79535-47bb-0310-9956-ffa450edef68
2016-03-28 22:52:01 +00:00
Andreas Beeker
f8767e3981 some zips can't be opened via ZipFile in JDK6, as the central directory
contains either non-latin entries or the compression type can't be handled
the workaround is to iterate over the stream and not the directory


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736933 13f79535-47bb-0310-9956-ffa450edef68
2016-03-28 22:49:45 +00:00
Andreas Beeker
ceda10fa32 sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736932 13f79535-47bb-0310-9956-ffa450edef68
2016-03-28 22:46:53 +00:00
Dominik Stadler
0115c12e2d Fix some compiler warnings, javadoc, ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736924 13f79535-47bb-0310-9956-ffa450edef68
2016-03-28 20:22:08 +00:00
Dominik Stadler
8afb394974 Bug 59199: Handle null date-values in a similar way as null-Strings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736923 13f79535-47bb-0310-9956-ffa450edef68
2016-03-28 20:20:29 +00:00
Javen O'Neal
4f4531c67e assertCloseDoesNotModifyFile method was adapted from method with the same name in TestWorkbookFactory
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736744 13f79535-47bb-0310-9956-ffa450edef68
2016-03-27 13:09:50 +00:00