Commit Graph

1321 Commits

Author SHA1 Message Date
Andreas Beeker
20fe8a5e0f Reduce calls to utf-related methods - the integration test took ages because of poc-shared-strings.xlsx
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744004 13f79535-47bb-0310-9956-ffa450edef68
2016-05-16 10:01:36 +00:00
Andreas Beeker
84be4acea9 Dispose XmlCursor
Replacing a method argument (XmlCursor) with a local instance and then updating it, doesn't make sense

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744002 13f79535-47bb-0310-9956-ffa450edef68
2016-05-16 09:54:01 +00:00
Andreas Beeker
401a9fb477 #58144 - Behaviour for headers and footers of slides is inconsistent between slideshows created in 2003 and 2007
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1743769 13f79535-47bb-0310-9956-ffa450edef68
2016-05-13 23:50:39 +00:00
Javen O'Neal
730641576a bug 59443: exit early on setAddress if address is the same
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742881 13f79535-47bb-0310-9956-ffa450edef68
2016-05-09 05:46:14 +00:00
Javen O'Neal
191726ee7b bug 59443: use Comment.setAddress when changing both row and column of cell comment address
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742880 13f79535-47bb-0310-9956-ffa450edef68
2016-05-09 05:25:29 +00:00
Javen O'Neal
70459401a3 bug 59443: add get/setAddress methods on cell comment class
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742879 13f79535-47bb-0310-9956-ffa450edef68
2016-05-09 05:09:41 +00:00
Javen O'Neal
e9bfa9da87 whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742869 13f79535-47bb-0310-9956-ffa450edef68
2016-05-09 03:53:55 +00:00
Andreas Beeker
f850d93b68 #59434 - Cannot add a picture on a slide that already have an image with an hyperlink on it
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742816 13f79535-47bb-0310-9956-ffa450edef68
2016-05-08 13:28:11 +00:00
Dominik Stadler
61f84af565 Try to print out more information if the timestamp-operation fails
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742425 13f79535-47bb-0310-9956-ffa450edef68
2016-05-05 12:22:44 +00:00
Dominik Stadler
8908412e3a Some general code-fixes found while trying out Java 9
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742423 13f79535-47bb-0310-9956-ffa450edef68
2016-05-05 12:22:31 +00:00
Andreas Beeker
f688ed96c6 #59327 - Setting text direction on a table cell has no effect
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742338 13f79535-47bb-0310-9956-ffa450edef68
2016-05-04 22:09:10 +00:00
Javen O'Neal
556f1e78a1 restore r1739550 and r1739552 (by reverting r1739580). Exclude BaseTestXWorkbook, BaseTestXSheet, BaseTestXRow, and BaseTestXCell from the OOXML-Lite target
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739644 13f79535-47bb-0310-9956-ffa450edef68
2016-04-17 20:17:04 +00:00
Javen O'Neal
dca380f057 reformat exclude classes regular expression for OOXMLLite
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739643 13f79535-47bb-0310-9956-ffa450edef68
2016-04-17 20:02:17 +00:00
Javen O'Neal
ec84916a9f bug 59342: add sheet tab color getter and setter
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739548 13f79535-47bb-0310-9956-ffa450edef68
2016-04-17 07:39:36 +00:00
Javen O'Neal
4d4b54b7c8 bug 59342: add sheet tab color getter and setter
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739547 13f79535-47bb-0310-9956-ffa450edef68
2016-04-17 07:38:15 +00:00
Javen O'Neal
393ccc1873 fix Sonar warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738876 13f79535-47bb-0310-9956-ffa450edef68
2016-04-12 22:44:28 +00:00
Javen O'Neal
ecf7db3223 bug 59312: delete temporary files even when the output stream cannot be closed (such as out of disk space IOException)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738848 13f79535-47bb-0310-9956-ffa450edef68
2016-04-12 18:48:31 +00:00
Javen O'Neal
a4af4fc6c3 fix several findbugs SF_SWITCH_NO_DEFAULT warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738782 13f79535-47bb-0310-9956-ffa450edef68
2016-04-12 12:03:24 +00:00
Javen O'Neal
f49047e733 add @NotImplemented annotation to methods that are not implemented
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738469 13f79535-47bb-0310-9956-ffa450edef68
2016-04-10 21:28:41 +00:00
Dominik Stadler
2a0ed81538 Bug 57844: Add some javadoc for unimplemented features in SXSSF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738413 13f79535-47bb-0310-9956-ffa450edef68
2016-04-10 09:40:40 +00:00
Tim Allison
a060c664a1 close fileinputstream on second exception in ZipPackage
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738251 13f79535-47bb-0310-9956-ffa450edef68
2016-04-08 14:36:05 +00:00
Dominik Stadler
62ee0abc13 Code cleanup via IntelliJ: Remove unnecessary semicolon
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738031 13f79535-47bb-0310-9956-ffa450edef68
2016-04-06 19:49:47 +00:00
Javen O'Neal
c95f6a4b35 whitespace (tabs to 4 spaces)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737895 13f79535-47bb-0310-9956-ffa450edef68
2016-04-05 23:47:41 +00:00
Javen O'Neal
fe13debb84 bug 59264: move border style deprecations to POI 3.15 beta 2.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737894 13f79535-47bb-0310-9956-ffa450edef68
2016-04-05 23:30:37 +00:00
Javen O'Neal
e2399abbe9 bug 59264: type safety: check if border code is a valid BorderStyle enum for setBorderX(short)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737886 13f79535-47bb-0310-9956-ffa450edef68
2016-04-05 21:38:55 +00:00
Javen O'Neal
1786767b89 bug 59264: use BorderStyle for changing Cell border line style
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737879 13f79535-47bb-0310-9956-ffa450edef68
2016-04-05 20:28:46 +00:00
Dominik Stadler
e8263f9d8f Fix two more places where wrong/invalid files can lead to file-handle leaks currently
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737489 13f79535-47bb-0310-9956-ffa450edef68
2016-04-02 11:01:56 +00:00
Dominik Stadler
328c52aab7 Fix some cases where file handles are not closed in OldExcelExtractor
Close resources in some more tests to make the file-leak report clean again

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737487 13f79535-47bb-0310-9956-ffa450edef68
2016-04-02 11:01:43 +00:00
Nick Burch
29c2e05b58 Javadoc fix - Generics are type-erased so not included in the javadoc links
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737317 13f79535-47bb-0310-9956-ffa450edef68
2016-04-01 07:17:04 +00:00
Tim Allison
26af28bbdb POI 59257 upgrade Bouncy Castle to 1.54
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737298 13f79535-47bb-0310-9956-ffa450edef68
2016-04-01 00:57:56 +00:00
Dominik Stadler
d0513f2ca6 Apply patch from bug 58909 - Add a cloneSheet() which directly sets the sheetname to allow to avoid a costly renaming of sheets.
Combine related unit-tests into Base-Test-Classes to run them for all types of Workbook/Sheet/...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737237 13f79535-47bb-0310-9956-ffa450edef68
2016-03-31 13:32:05 +00:00
Dominik Stadler
992adb9c16 Revert set of inadvertedly committed files/changes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737029 13f79535-47bb-0310-9956-ffa450edef68
2016-03-29 18:11:44 +00:00
Dominik Stadler
f5332a3a40 Bug 58915: Add note about memory consumption and update changelog
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737025 13f79535-47bb-0310-9956-ffa450edef68
2016-03-29 17:30:55 +00:00
Dominik Stadler
ff68b433b8 Bug 58915: Update javadoc for memory consumption and fix some other javadoc and compiler warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737024 13f79535-47bb-0310-9956-ffa450edef68
2016-03-29 17:27:20 +00:00
Dominik Stadler
0888ad4de5 Fix some compiler warnings, improve error message, cover some more code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737013 13f79535-47bb-0310-9956-ffa450edef68
2016-03-29 15:45:04 +00:00
Andreas Beeker
4eeffd0532 XSLF: do not display Master Slide objects by default
XSLF: fix alternate content handling for picture shapes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736935 13f79535-47bb-0310-9956-ffa450edef68
2016-03-28 22:52:01 +00:00
Andreas Beeker
f8767e3981 some zips can't be opened via ZipFile in JDK6, as the central directory
contains either non-latin entries or the compression type can't be handled
the workaround is to iterate over the stream and not the directory


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736933 13f79535-47bb-0310-9956-ffa450edef68
2016-03-28 22:49:45 +00:00
Dominik Stadler
8afb394974 Bug 59199: Handle null date-values in a similar way as null-Strings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736923 13f79535-47bb-0310-9956-ffa450edef68
2016-03-28 20:20:29 +00:00
Javen O'Neal
01b20a6567 make OPCPackage logger final
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736721 13f79535-47bb-0310-9956-ffa450edef68
2016-03-27 05:01:02 +00:00
Javen O'Neal
f0e824587b bug 59224: change hasTint, add hasAlpha and unit tests. Patch from gubespam@gmail.com
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736469 13f79535-47bb-0310-9956-ffa450edef68
2016-03-24 17:29:00 +00:00
Javen O'Neal
4fe9f0bcab make private member variable ctColor final
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736395 13f79535-47bb-0310-9956-ffa450edef68
2016-03-24 06:37:34 +00:00
Javen O'Neal
784b07e424 bug 59222: fix NPE thrown by (S)XSSFSheet.getCellComments(). Reported by Vasily Kopytov.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736347 13f79535-47bb-0310-9956-ffa450edef68
2016-03-23 16:42:04 +00:00
Javen O'Neal
e2615ce68e bug 59212: Do not check for overlapping regions when adding merged regions to a sheet
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736155 13f79535-47bb-0310-9956-ffa450edef68
2016-03-22 09:02:08 +00:00
Dominik Stadler
d806c2ac2b Check for null in IOUtils.closeQuietly() to not log this unnecessarily
Add coverage for some  more methods in ExtractorFactory
Fix some IntelliJ warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736146 13f79535-47bb-0310-9956-ffa450edef68
2016-03-22 07:51:39 +00:00
Javen O'Neal
dd308cd87e return unmodifiable shared strings to guarentee parallel data structures stay in sync
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736144 13f79535-47bb-0310-9956-ffa450edef68
2016-03-22 07:04:51 +00:00
Javen O'Neal
a61e242e86 bug 59208: correctly understand val="1" for isBold, isItalic, etc
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736126 13f79535-47bb-0310-9956-ffa450edef68
2016-03-22 04:20:45 +00:00
Javen O'Neal
e89f19bef3 fix inconsistent newlines (remove carriage returns), set svnprop eol-style native
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736121 13f79535-47bb-0310-9956-ffa450edef68
2016-03-22 02:31:16 +00:00
Andreas Beeker
197aef5420 findbugs fixes - SE_COMPARATOR_SHOULD_BE_SERIALIZABLE
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736114 13f79535-47bb-0310-9956-ffa450edef68
2016-03-21 23:42:56 +00:00
Andreas Beeker
8be67e1910 fix eclipse warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735881 13f79535-47bb-0310-9956-ffa450edef68
2016-03-20 13:36:56 +00:00
Andreas Beeker
488ce5fec3 #59195 - POIXMLTypeLoader depends on XMLBeans 2.6.0 - remove piccolo classes from xmlbeans jars and disable xmloption in type loader
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735685 13f79535-47bb-0310-9956-ffa450edef68
2016-03-18 21:34:03 +00:00