Commit Graph

2429 Commits

Author SHA1 Message Date
Javen O'Neal
b8dcd4df42 bug 59264: fix findbugs warning 'A boxed value is unboxed and then immediately reboxed.'
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737896 13f79535-47bb-0310-9956-ffa450edef68
2016-04-06 00:06:53 +00:00
Javen O'Neal
c95f6a4b35 whitespace (tabs to 4 spaces)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737895 13f79535-47bb-0310-9956-ffa450edef68
2016-04-05 23:47:41 +00:00
Javen O'Neal
fe13debb84 bug 59264: move border style deprecations to POI 3.15 beta 2.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737894 13f79535-47bb-0310-9956-ffa450edef68
2016-04-05 23:30:37 +00:00
Javen O'Neal
5752c4bb7e bug 59264: allow borders styles to be set with BorderStyles enums or Short codes for backwards compatibility
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737885 13f79535-47bb-0310-9956-ffa450edef68
2016-04-05 21:36:11 +00:00
Javen O'Neal
f7939c4c95 bug 59264: add link to BorderStyle on deprecated BORDER_* constants
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737884 13f79535-47bb-0310-9956-ffa450edef68
2016-04-05 21:34:24 +00:00
Javen O'Neal
1786767b89 bug 59264: use BorderStyle for changing Cell border line style
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737879 13f79535-47bb-0310-9956-ffa450edef68
2016-04-05 20:28:46 +00:00
Javen O'Neal
739196e5b3 bug 59264: copy cell border style codes (from CellStyle.java) into BorderStyle enum
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737752 13f79535-47bb-0310-9956-ffa450edef68
2016-04-04 23:27:20 +00:00
Javen O'Neal
8e1b343761 rearrange BORDER_DOTTED and BORDER_HAIR
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737751 13f79535-47bb-0310-9956-ffa450edef68
2016-04-04 23:26:44 +00:00
Dominik Stadler
b46a57926c Bug 55982: Don't fail to open the spreadsheet if no TabIdRecord is found
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737602 13f79535-47bb-0310-9956-ffa450edef68
2016-04-03 18:32:22 +00:00
Dominik Stadler
328c52aab7 Fix some cases where file handles are not closed in OldExcelExtractor
Close resources in some more tests to make the file-leak report clean again

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737487 13f79535-47bb-0310-9956-ffa450edef68
2016-04-02 11:01:43 +00:00
Dominik Stadler
d0513f2ca6 Apply patch from bug 58909 - Add a cloneSheet() which directly sets the sheetname to allow to avoid a costly renaming of sheets.
Combine related unit-tests into Base-Test-Classes to run them for all types of Workbook/Sheet/...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737237 13f79535-47bb-0310-9956-ffa450edef68
2016-03-31 13:32:05 +00:00
Dominik Stadler
33cf4c310b DumpPOIFS: Create a separate named sub-directory for each file to not overwrite each other when passing in multiple files for dumping, check for failing mkdirs()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737031 13f79535-47bb-0310-9956-ffa450edef68
2016-03-29 18:44:11 +00:00
Dominik Stadler
992adb9c16 Revert set of inadvertedly committed files/changes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737029 13f79535-47bb-0310-9956-ffa450edef68
2016-03-29 18:11:44 +00:00
Dominik Stadler
f5332a3a40 Bug 58915: Add note about memory consumption and update changelog
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737025 13f79535-47bb-0310-9956-ffa450edef68
2016-03-29 17:30:55 +00:00
Dominik Stadler
02b29ea698 Bug 59132: Adjust implementation of COUNTBLANK to be conforming to Excel, empty strings are counted as blank as well
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737009 13f79535-47bb-0310-9956-ffa450edef68
2016-03-29 14:53:44 +00:00
Andreas Beeker
ceda10fa32 sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736932 13f79535-47bb-0310-9956-ffa450edef68
2016-03-28 22:46:53 +00:00
Dominik Stadler
0115c12e2d Fix some compiler warnings, javadoc, ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736924 13f79535-47bb-0310-9956-ffa450edef68
2016-03-28 20:22:08 +00:00
Javen O'Neal
e2615ce68e bug 59212: Do not check for overlapping regions when adding merged regions to a sheet
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736155 13f79535-47bb-0310-9956-ffa450edef68
2016-03-22 09:02:08 +00:00
Dominik Stadler
d806c2ac2b Check for null in IOUtils.closeQuietly() to not log this unnecessarily
Add coverage for some  more methods in ExtractorFactory
Fix some IntelliJ warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736146 13f79535-47bb-0310-9956-ffa450edef68
2016-03-22 07:51:39 +00:00
Andreas Beeker
197aef5420 findbugs fixes - SE_COMPARATOR_SHOULD_BE_SERIALIZABLE
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736114 13f79535-47bb-0310-9956-ffa450edef68
2016-03-21 23:42:56 +00:00
Andreas Beeker
762864d0f2 findbugs fixes - RR_NOT_CHECKED
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736112 13f79535-47bb-0310-9956-ffa450edef68
2016-03-21 23:29:06 +00:00
Andreas Beeker
e9f333827d fix eclipse warnings
close resources

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735912 13f79535-47bb-0310-9956-ffa450edef68
2016-03-21 00:14:21 +00:00
Andreas Beeker
87f4e8fa63 sonar fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735696 13f79535-47bb-0310-9956-ffa450edef68
2016-03-18 22:21:12 +00:00
Andreas Beeker
33991bfd98 sonar fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735514 13f79535-47bb-0310-9956-ffa450edef68
2016-03-17 22:39:20 +00:00
Andreas Beeker
492e51b15f findbugs fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735513 13f79535-47bb-0310-9956-ffa450edef68
2016-03-17 22:36:11 +00:00
Andreas Beeker
3e6de40c64 sonar fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735507 13f79535-47bb-0310-9956-ffa450edef68
2016-03-17 21:52:53 +00:00
Andreas Beeker
4187b04edb forgot another contains call ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735349 13f79535-47bb-0310-9956-ffa450edef68
2016-03-16 23:40:00 +00:00
Andreas Beeker
61388344ba findbugs fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735348 13f79535-47bb-0310-9956-ffa450edef68
2016-03-16 23:36:17 +00:00
Andreas Beeker
56ceb000f1 sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735345 13f79535-47bb-0310-9956-ffa450edef68
2016-03-16 23:30:19 +00:00
Andreas Beeker
d6d47e0bca findbugs fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735319 13f79535-47bb-0310-9956-ffa450edef68
2016-03-16 22:10:27 +00:00
Andreas Beeker
80e4d8b879 First try of uncluttering CellNumberFormatter.
Make inner classes static and remove setting of private outer properties while in constructor.
Make properties final to make sure they are only set once.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735300 13f79535-47bb-0310-9956-ffa450edef68
2016-03-16 21:18:58 +00:00
Nick Burch
4d7955d6b5 Start to give more helpful Exceptions from OPCPackage when non-OOXML files are passed to it
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735060 13f79535-47bb-0310-9956-ffa450edef68
2016-03-15 11:50:57 +00:00
Dominik Stadler
d853210049 Fix some IntelliJ warnings and adjust Javadoc of readFully() slightly to describe the behavior better.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734924 13f79535-47bb-0310-9956-ffa450edef68
2016-03-14 11:58:15 +00:00
Andreas Beeker
3f4f58829d HSLF: Add support for system colors
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734865 13f79535-47bb-0310-9956-ffa450edef68
2016-03-14 00:42:59 +00:00
Dominik Stadler
4bd9afde4f Bug 56930: Add Workbook.getNames() to allow to query for names that appear multiple times
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734863 13f79535-47bb-0310-9956-ffa450edef68
2016-03-13 21:30:38 +00:00
Dominik Stadler
0a5dcbec1b Bug 55668: Try to avoid NullPointerException when chaning cell type and formula leads to null-string by seting the cell to BLANK instead
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734861 13f79535-47bb-0310-9956-ffa450edef68
2016-03-13 21:30:18 +00:00
Nick Burch
2718aa2f51 Escape spaces in the URL
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734858 13f79535-47bb-0310-9956-ffa450edef68
2016-03-13 21:19:46 +00:00
Andreas Beeker
653403e956 #59135 - Password gets truncated when using passwords longer than 15 characters for the function protectSheet()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734843 13f79535-47bb-0310-9956-ffa450edef68
2016-03-13 19:31:32 +00:00
Dominik Stadler
9bf1bf60b2 Bug 57200: Do not try to delete the poifiles-tempdir as it can interfere when multiple applications are using SXSSF on the same machine.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734719 13f79535-47bb-0310-9956-ffa450edef68
2016-03-12 16:56:33 +00:00
Andreas Beeker
8e36872c48 #59170 - Remove deprecated classes (POI 3.15) - *Workbook.setRepeatingRowsAndColumns()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734701 13f79535-47bb-0310-9956-ffa450edef68
2016-03-12 13:33:53 +00:00
Dominik Stadler
2b28cd97a3 Apply patch to fix bug 57495: getTableArray method can not get 0 pos table
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734694 13f79535-47bb-0310-9956-ffa450edef68
2016-03-12 11:45:34 +00:00
Dominik Stadler
06083f85f4 Refactor some common code from the various Document-Factories into a helper class
Fix a potential file-handle-leak for password protected workbooks or slideshows

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734691 13f79535-47bb-0310-9956-ffa450edef68
2016-03-12 11:37:32 +00:00
Dominik Stadler
128a991f9c Findbugs fixes
OldExcelExtractor could leak file handles in case of exceptions
Free file handles in POIFSDump, add unit-test for POIFSDump
Add a Findbugs exclude and adjust findbugs-ant slightly

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734689 13f79535-47bb-0310-9956-ffa450edef68
2016-03-12 11:37:12 +00:00
Dominik Stadler
b1bc13c26f Mark duplicated RecordFormatException as deprecated to be able to remove it at some point in the future
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734688 13f79535-47bb-0310-9956-ffa450edef68
2016-03-12 11:36:56 +00:00
Andreas Beeker
7d6be0ff54 #59170 - Remove deprecated classes (POI 3.15) - org.apache.poi.hssf/ss.util.Region
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734651 13f79535-47bb-0310-9956-ffa450edef68
2016-03-12 00:17:16 +00:00
Andreas Beeker
0776e32108 sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734641 13f79535-47bb-0310-9956-ffa450edef68
2016-03-11 23:14:09 +00:00
Andreas Beeker
1b9523898d sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734337 13f79535-47bb-0310-9956-ffa450edef68
2016-03-10 00:20:34 +00:00
Andreas Beeker
e2fc2822a6 Remove a superfluous/bloated log function, which String.format can do better and is only used once ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734310 13f79535-47bb-0310-9956-ffa450edef68
2016-03-09 20:57:26 +00:00
Nick Burch
9090741226 More helpful exception message if POIFS is given a raw XML file (eg an Office 2003 XML file), plus tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734215 13f79535-47bb-0310-9956-ffa450edef68
2016-03-09 10:57:52 +00:00
Andreas Beeker
261ef4934c #59056 - Render individual slideshow shapes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732974 13f79535-47bb-0310-9956-ffa450edef68
2016-02-29 23:59:49 +00:00
Andreas Beeker
e5baa15b25 Fix NPE of regression tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732972 13f79535-47bb-0310-9956-ffa450edef68
2016-02-29 23:36:58 +00:00
Nick Burch
62b5b0d874 #59074 More helpful exception if Excel 1-95 files are given to ExtractorFactory
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732587 13f79535-47bb-0310-9956-ffa450edef68
2016-02-26 23:56:31 +00:00
Nick Burch
856261f4d0 Refactor out the POIFS directory entry name for Excel 1-95 entries, and have ExtractorFactory detect (but not support) these old files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732583 13f79535-47bb-0310-9956-ffa450edef68
2016-02-26 23:43:59 +00:00
Nick Burch
0b8283b37c Refactor to pull out the list of Excel 97+ directory entry names to a common place, avoiding duplication. Also starts on unit testing #59074
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732579 13f79535-47bb-0310-9956-ffa450edef68
2016-02-26 23:32:17 +00:00
Andreas Beeker
41d693fe15 Regression fixes for H/XSLF and HWMF
see http://apache-poi.1045710.n5.nabble.com/3-14-beta-2-3-14-final-tt5721829.html

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732236 13f79535-47bb-0310-9956-ffa450edef68
2016-02-24 22:43:51 +00:00
Dominik Stadler
161ef55132 Bug 47245: Comment out check and exception in case row-records are missing for some cells as it seems POI is handling this gracefully and LibreOffice/Excel are as well
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732235 13f79535-47bb-0310-9956-ffa450edef68
2016-02-24 22:39:11 +00:00
Dominik Stadler
10f46da1ae Include stacktrace of inner exception when block-positions are invalid in POIFSFileSystem
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731560 13f79535-47bb-0310-9956-ffa450edef68
2016-02-21 20:41:56 +00:00
Javen O'Neal
c80fa0c870 bug 56345: reject single-cell merged regions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730991 13f79535-47bb-0310-9956-ffa450edef68
2016-02-18 01:33:14 +00:00
Javen O'Neal
3cb72bfa7b bug 58339: patch from Patrick Zimmermann to allow OFFSET() to accept missing optional width or height parameters
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730606 13f79535-47bb-0310-9956-ffa450edef68
2016-02-15 20:27:59 +00:00
Nick Burch
86153c0ea6 Add details of the ignored errors where the HSSF spec provides a good description, and a bit more refactoring. #56892
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730543 13f79535-47bb-0310-9956-ffa450edef68
2016-02-15 14:58:16 +00:00
Nick Burch
0982d9dee5 Start generalising the IgnoredErrorType code for later HSSF use too #56892
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730540 13f79535-47bb-0310-9956-ffa450edef68
2016-02-15 14:40:24 +00:00
Dominik Stadler
98da5af350 Seems we need a cast here to compile with some newer JDKs, at least IntelliJ complains for me
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730464 13f79535-47bb-0310-9956-ffa450edef68
2016-02-15 08:33:12 +00:00
Dominik Stadler
c68a9e4c02 Regression analysis: the additional testing of cloning sheets showed a
possible ArrayIndexOutOfBounds error which we can avoid to make cloning
fail a bit less.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730274 13f79535-47bb-0310-9956-ffa450edef68
2016-02-13 21:29:46 +00:00
Javen O'Neal
95e95dfabb remove deprecated (2009) HSSFComment#setColumn(short). int version is available.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727805 13f79535-47bb-0310-9956-ffa450edef68
2016-01-31 12:52:32 +00:00
Javen O'Neal
80c9b356c2 HSSFComment: note a final field
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727803 13f79535-47bb-0310-9956-ffa450edef68
2016-01-31 12:33:00 +00:00
Javen O'Neal
dc860a6f93 fix O(n^2) runtime unnecessarily recreating an array inside a for-loop
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727800 13f79535-47bb-0310-9956-ffa450edef68
2016-01-31 12:14:55 +00:00
Dominik Stadler
68997de5f0 Make OldExcelExtractor Closeable to be able to free up resources if getText() was not called
Allow Excel files which have an entry "Workbook" instead of "Book" like other classes do
Add some more unit tests to cover more of the code

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727653 13f79535-47bb-0310-9956-ffa450edef68
2016-01-29 22:09:03 +00:00
Andreas Beeker
5fad9af36f #41047 - Support hyperlinks in HSLF shapes and textruns
#47291 - Cannot open link correctly which insert in ppt

HSLF hyperlink code was all over the place - moved most of it into HSLFHyperlink
extended common sl for hyperlinks
extended XSLF shape linking and added XSLFTextShape.appendText to go along with HSLF
adapted/fixed documentation
added convenience methods to the hyperlink classes to address the different targets

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1726458 13f79535-47bb-0310-9956-ffa450edef68
2016-01-24 00:12:10 +00:00
Dominik Stadler
fe359afec3 Fix possible NullPointerException with invalid/unsupported image types
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1725332 13f79535-47bb-0310-9956-ffa450edef68
2016-01-18 19:56:30 +00:00
Javen O'Neal
276e95e43f bug 58879: add SpreadsheetVersion to Workbook interface
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1725039 13f79535-47bb-0310-9956-ffa450edef68
2016-01-16 22:01:33 +00:00
Andreas Beeker
c1263423cf #56004 - Support for WMF rendering
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724897 13f79535-47bb-0310-9956-ffa450edef68
2016-01-16 00:11:01 +00:00
Dominik Stadler
bdef6e1c52 Regression in version 3.14-beta1: three or four-part formats with locale id cause exceptions when formatting instead of falling back to other formatting
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724488 13f79535-47bb-0310-9956-ffa450edef68
2016-01-13 19:46:17 +00:00
Dominik Stadler
e91e15ab10 Eclipse warnings, helper unit-test, improve information provided in Exceptions, do not swallow inner stacktraces, ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724486 13f79535-47bb-0310-9956-ffa450edef68
2016-01-13 19:45:05 +00:00
Nick Burch
c86a4af85e Javadoc fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724364 13f79535-47bb-0310-9956-ffa450edef68
2016-01-13 07:33:03 +00:00
Nick Burch
ed9a070491 #58847 Getters/setters/removers for the additional well-known document summary information properties from Office 12
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724363 13f79535-47bb-0310-9956-ffa450edef68
2016-01-13 07:26:26 +00:00
Andreas Beeker
b0c16b8261 #57796 - Support hyperlink extraction when rendering slides
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724338 13f79535-47bb-0310-9956-ffa450edef68
2016-01-12 23:20:48 +00:00
Nick Burch
ef61211207 More Office 12 DSI property IDs, getters/setters to follow
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724110 13f79535-47bb-0310-9956-ffa450edef68
2016-01-11 18:43:33 +00:00
Nick Burch
5e32d8c805 Bump up the max DSI property ID, and list a few Office 12 well known IDs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724104 13f79535-47bb-0310-9956-ffa450edef68
2016-01-11 18:26:24 +00:00
Andreas Beeker
b3b4ed6564 add other printStackTrace methods to forbidden-apis-check
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1723960 13f79535-47bb-0310-9956-ffa450edef68
2016-01-10 19:52:16 +00:00
Andreas Beeker
8d033e235c replace Throwable.printStackTrace() with POILogger calls - Todo: other printStrackTrace(...) calls
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1723899 13f79535-47bb-0310-9956-ffa450edef68
2016-01-10 02:20:35 +00:00
Javen O'Neal
1e9fd97f78 bug 58815: javadoc spelling
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1723445 13f79535-47bb-0310-9956-ffa450edef68
2016-01-07 01:53:05 +00:00
Dominik Stadler
c4c9ac0ccf bug 58043: provide some compatibility between HSSF and XSSF in regards to values for CellStyle.setRotation(). Also adjust JavaDoc to mention the remaining things to note
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722716 13f79535-47bb-0310-9956-ffa450edef68
2016-01-03 13:28:17 +00:00
Javen O'Neal
347881ef1e bug 58633 comment 5 and comment 6: add unit test coverage for CellUtil.java; throw exception of Cell does not belong to workbook for some methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722618 13f79535-47bb-0310-9956-ffa450edef68
2016-01-02 11:11:33 +00:00
Javen O'Neal
4a47ec3d39 fix javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722609 13f79535-47bb-0310-9956-ffa450edef68
2016-01-02 06:23:05 +00:00
asf-sync-process
de7807c8a7 bug 58633: Set multiple CellStyle properties at once. Patch from Mark Murphy.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722607 13f79535-47bb-0310-9956-ffa450edef68
2016-01-02 04:29:34 +00:00
Javen O'Neal
85bb833ea1 javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722605 13f79535-47bb-0310-9956-ffa450edef68
2016-01-02 03:40:22 +00:00
Andreas Beeker
f317f5e288 #56570 - RecordType has repeat by code type 3009
#58159 - getHeaderText() and getFooterText() duplicate text in sheet.getTextRuns()

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722476 13f79535-47bb-0310-9956-ffa450edef68
2015-12-31 22:10:17 +00:00
Dominik Stadler
8589924b22 Bug 58746: Fix missing adjustment of formulas when sheet-ordering is changed.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722410 13f79535-47bb-0310-9956-ffa450edef68
2015-12-30 20:31:44 +00:00
Dominik Stadler
8ae2972f3d Bug 58616: Try to initialize with empty password if not done before
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722407 13f79535-47bb-0310-9956-ffa450edef68
2015-12-30 20:31:23 +00:00
Javen O'Neal
70f08e1fc5 fix javadocs warnings for r1721930 (bug 58775)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722049 13f79535-47bb-0310-9956-ffa450edef68
2015-12-29 02:57:58 +00:00
Javen O'Neal
a50f45e4c2 bug 58775: use short for data format index, int for cell style index
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721930 13f79535-47bb-0310-9956-ffa450edef68
2015-12-28 14:50:54 +00:00
Javen O'Neal
0ef05fcdab java docs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721901 13f79535-47bb-0310-9956-ffa450edef68
2015-12-28 12:11:13 +00:00
Javen O'Neal
a94df00797 make HSSFCellStyle attributes final, add Override decorators on all methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721876 13f79535-47bb-0310-9956-ffa450edef68
2015-12-28 05:43:11 +00:00
Dominik Stadler
a021bc780b Fix some cases where file resources were not closed correctly, mostly when Exceptions occur during opening files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721470 13f79535-47bb-0310-9956-ffa450edef68
2015-12-22 22:36:43 +00:00
Dominik Stadler
0a3370347e Fix freeing resources in some tests and dev-tools so we can run unit-tests with enabled file-leak-detector
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721468 13f79535-47bb-0310-9956-ffa450edef68
2015-12-22 22:35:59 +00:00
Dominik Stadler
b69c64fe21 Handle some cases better where file handles were left open by the ExtractorFactory, mostly when opening files failed, but also when using the NPOIFSFileSystem for initialization.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721064 13f79535-47bb-0310-9956-ffa450edef68
2015-12-20 20:39:01 +00:00
Nick Burch
1fbfc70cca Unit test for #58731 - not reproduced, and some javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1720411 13f79535-47bb-0310-9956-ffa450edef68
2015-12-16 18:15:31 +00:00
Andreas Beeker
7b4c17b70c #58733 - New AIOOBE in getCell while iterating through a table in PPT
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1720035 13f79535-47bb-0310-9956-ffa450edef68
2015-12-14 22:49:04 +00:00
Andreas Beeker
3e8b58e356 fix forbidden apis issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1719778 13f79535-47bb-0310-9956-ffa450edef68
2015-12-13 09:51:22 +00:00
Javen O'Neal
5da709336c supporting change for bug 56454: SheetUtil.containsCell and CellRangeAddress.isInRange are equivalent
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1718221 13f79535-47bb-0310-9956-ffa450edef68
2015-12-06 21:11:38 +00:00