Commit Graph

6155 Commits

Author SHA1 Message Date
Dominik Stadler
113edb1a76 Adjust Bin2Dec similar to what we did for Hex2Dec in Bug 57196 and fix some smaller problems in the implementation found while adding full unit tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1650654 13f79535-47bb-0310-9956-ffa450edef68
2015-01-09 20:37:11 +00:00
Dominik Stadler
3403bef5a8 Fix Eclipse warnings, provide better error message and adjust javadoc slightly
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1650598 13f79535-47bb-0310-9956-ffa450edef68
2015-01-09 16:52:23 +00:00
Dominik Stadler
c8bf92f963 Bug 57196: Resolve RefEval to it's inner ValueEval in Hex2Dec
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1650597 13f79535-47bb-0310-9956-ffa450edef68
2015-01-09 16:51:02 +00:00
Nick Burch
ed8964594b Swap Exception for Throwable, to skip a wider range of problems (eg GAE) when attempting to set an xml security manager as best we can
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1650290 13f79535-47bb-0310-9956-ffa450edef68
2015-01-08 13:22:50 +00:00
Dominik Stadler
8997d8900d * Add missing close() on streams in ImageUtils.getImageDimension()
* Add some unit tests for CellReference

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1650070 13f79535-47bb-0310-9956-ffa450edef68
2015-01-07 14:36:39 +00:00
Dominik Stadler
f912ecac92 Add reproducer for bug 56655
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1650069 13f79535-47bb-0310-9956-ffa450edef68
2015-01-07 14:34:13 +00:00
Dominik Stadler
c15f7bc929 Add reproducer for bug 57074
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1650059 13f79535-47bb-0310-9956-ffa450edef68
2015-01-07 14:13:34 +00:00
Dominik Stadler
5aff4f5a2a Add reproducing testcase for Bug 57294
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649536 13f79535-47bb-0310-9956-ffa450edef68
2015-01-05 14:39:51 +00:00
Dominik Stadler
fa8eae2bfd Move some tests to the base test class where applicapple
Introduce class BaseTestXCell to collect tests for XSSFCell and SXSSFCell that do not work for HSSFCell

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649527 13f79535-47bb-0310-9956-ffa450edef68
2015-01-05 14:03:37 +00:00
Dominik Stadler
c2d82b6005 Update disabled test for bug 54071 to show the root-cause better
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649526 13f79535-47bb-0310-9956-ffa450edef68
2015-01-05 13:48:41 +00:00
Dominik Stadler
0819dd3b9f Update tests for ExcelAntWorkbookUtil, remove some unnecessary null-checks that can never happen, fix setting failed state on error in evaluation
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649311 13f79535-47bb-0310-9956-ffa450edef68
2015-01-04 10:23:45 +00:00
Dominik Stadler
71cf9cd8c3 Remove unnecessary casts
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649310 13f79535-47bb-0310-9956-ffa450edef68
2015-01-04 10:23:24 +00:00
Dominik Stadler
8edf70ec8f Add unit tests for XSSFTextRun and TextPainter, slightly more tests for XSSFSheet and enhance unit tests for XWPFParagraph and ExcelAntTest
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649309 13f79535-47bb-0310-9956-ffa450edef68
2015-01-04 10:23:01 +00:00
Dominik Stadler
9794510d33 Improve information in exceptions thrown by XSSFRichTextString and improve unit tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649234 13f79535-47bb-0310-9956-ffa450edef68
2015-01-03 19:30:56 +00:00
Dominik Stadler
2f681f430c Fix copy/paste errors in XSSFSimpleShape, allow unset of insets multiple times and add unit tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649233 13f79535-47bb-0310-9956-ffa450edef68
2015-01-03 19:30:36 +00:00
Dominik Stadler
3bbf57cd27 Fix copy/paste error in XSSFTextParagraph and add unit tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649232 13f79535-47bb-0310-9956-ffa450edef68
2015-01-03 19:29:51 +00:00
Dominik Stadler
2dce3dc7d0 Adjust .classpath sources and add missing dependencies to run ooxml-lite tests standalone
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649179 13f79535-47bb-0310-9956-ffa450edef68
2015-01-03 09:35:34 +00:00
Dominik Stadler
ff2dece3ce Update to junit-4.12, the jar file is downloaded, so not required on classpath anymore. Also adjust version in pom.xml for Sonar.
Conflicts:
	.classpath

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649178 13f79535-47bb-0310-9956-ffa450edef68
2015-01-03 09:35:21 +00:00
Dominik Stadler
397d0d61d6 Update to latest JaCoCo 0.7.2 and adjust coverage report to exclude third-party code that is not relevant for coverage measurement
Conflicts:
	build.xml

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649177 13f79535-47bb-0310-9956-ffa450edef68
2015-01-03 09:34:25 +00:00
Dominik Stadler
5a20499263 Bug 53453: Apply patch to add methods to set margins in sections of HWPF documents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649176 13f79535-47bb-0310-9956-ffa450edef68
2015-01-03 09:34:07 +00:00
Andreas Beeker
0ea9f5fff9 Test and fix for bug #46441
Use generics on Shape.getEscherChild() and SimpleShape.getClientDataRecord() to minimize casting
Unify access to Shape.getEscherOptRecord()

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649152 13f79535-47bb-0310-9956-ffa450edef68
2015-01-02 22:57:05 +00:00
Dominik Stadler
be0d5df4b7 Add missing license header
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649151 13f79535-47bb-0310-9956-ffa450edef68
2015-01-02 22:49:37 +00:00
Dominik Stadler
d909e0998c Add verifying test-case for bug 52420
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649147 13f79535-47bb-0310-9956-ffa450edef68
2015-01-02 22:38:52 +00:00
Dominik Stadler
b930f0c46c Include seen invalid index in thrown Exception
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649125 13f79535-47bb-0310-9956-ffa450edef68
2015-01-02 21:07:25 +00:00
Dominik Stadler
e8c5bd48ad Extract ROOT_DIR into constant, ignore .csv files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649124 13f79535-47bb-0310-9956-ffa450edef68
2015-01-02 21:07:14 +00:00
Dominik Stadler
302db39cb7 Fix some Eclipse warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649123 13f79535-47bb-0310-9956-ffa450edef68
2015-01-02 21:06:51 +00:00
Dominik Stadler
ffcc20f60e Bug 46898: Convert unit tests for circular references to also run for XSSF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649122 13f79535-47bb-0310-9956-ffa450edef68
2015-01-02 21:04:50 +00:00
Dominik Stadler
12edcc5ed2 Bug 46192: Add methods to query outline level for HSSF and XSSF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649107 13f79535-47bb-0310-9956-ffa450edef68
2015-01-02 20:03:28 +00:00
Andreas Beeker
b2a69b6152 Bug 56240 - Handle PP97_DUALSTORAGE streams
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648466 13f79535-47bb-0310-9956-ffa450edef68
2014-12-30 02:20:57 +00:00
Andreas Beeker
de9699fcad Bug 47261 - SlideShow.removeSlide makes PPT corrupted
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648458 13f79535-47bb-0310-9956-ffa450edef68
2014-12-30 01:05:41 +00:00
Andreas Beeker
26ae1edcd8 Bug 49541 - Mapping of symbol characters to unicode equivalent
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648415 13f79535-47bb-0310-9956-ffa450edef68
2014-12-29 19:43:35 +00:00
Andreas Beeker
8e3eee35cd Bug 54541 - Add support for cropped images in Slide.draw()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648335 13f79535-47bb-0310-9956-ffa450edef68
2014-12-29 13:35:57 +00:00
Dominik Stadler
bfffe6cb4f Add missing license header for new file
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648254 13f79535-47bb-0310-9956-ffa450edef68
2014-12-28 21:25:42 +00:00
Dominik Stadler
a0248ff4f0 Bug 57007: Add initial implementations of DMIN and DGET functions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648166 13f79535-47bb-0310-9956-ffa450edef68
2014-12-28 10:47:41 +00:00
Dominik Stadler
5c76ccba5b Add missing close() of resources in both production code and tests
Use revert() instead of close() on OCPPackage in some places to not re-write the file unnecessarily.
This should now run tests without leftover file handles when checked with file leak detector and
allows to find newly introduced cases more easily.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648160 13f79535-47bb-0310-9956-ffa450edef68
2014-12-28 09:16:57 +00:00
Dominik Stadler
7c9d23d887 Remove unused local variable
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648159 13f79535-47bb-0310-9956-ffa450edef68
2014-12-28 09:09:11 +00:00
Dominik Stadler
26585f4e95 Ensure that XSSFWorkbooks contain a BookView, some corrupt ones do not contain this, e.g. ones created by movescound.com
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648158 13f79535-47bb-0310-9956-ffa450edef68
2014-12-28 09:08:58 +00:00
Dominik Stadler
1cf8152d14 Start adding some coverage of more Scratchpad-classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648157 13f79535-47bb-0310-9956-ffa450edef68
2014-12-28 09:08:22 +00:00
Dominik Stadler
5173eca9ea Fix Eclipse warnings, unnecessary casts, use generics, static access...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648156 13f79535-47bb-0310-9956-ffa450edef68
2014-12-28 09:06:12 +00:00
Dominik Stadler
54fd49b39f Exclude javadoc-jars in findbugs run
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648155 13f79535-47bb-0310-9956-ffa450edef68
2014-12-28 08:59:34 +00:00
Andreas Beeker
4bed984c0f Charset.forName() for known encodings makes catching UnknownEncodingException obsolete
Unify UTF-16LE conversion to StringUtil
BugFix for RecordInputStream.readFully in combination with continuing records
BugFix for integration tests - fix pathname for handler/exclude lookup on windows

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648032 13f79535-47bb-0310-9956-ffa450edef68
2014-12-27 01:33:28 +00:00
Dominik Stadler
ae8391b926 One more change in file-pattern to actually exclude .svn files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647941 13f79535-47bb-0310-9956-ffa450edef68
2014-12-26 07:51:46 +00:00
Dominik Stadler
65ca8293d5 Exclude .svn sub-dirs as it seems Apache Jenkins still runs with Subversion <=1.6
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647939 13f79535-47bb-0310-9956-ffa450edef68
2014-12-26 07:04:34 +00:00
Dominik Stadler
b1e4a93f4d Add jars from compile-lib to findbugs target
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647938 13f79535-47bb-0310-9956-ffa450edef68
2014-12-26 07:04:10 +00:00
Andreas Beeker
47fe5b9651 Unified access to escher opt record
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647927 13f79535-47bb-0310-9956-ffa450edef68
2014-12-26 00:11:23 +00:00
Dominik Stadler
0c580c8f45 Add a test-suite which performs integration/stress tests which load and handle all stored test files in various ways.
It works by using handlers for each type of file which perform various operations on the files, e.g. loading,
iterating content, modify, ... This will trigger changes which break working with the available test-files and
thus provides another layer of regression testing which hopefully prevents some failures from making it into
releases.

It is runnable via a new ant-target 'test-integration' and also added to the jenkins-target.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647885 13f79535-47bb-0310-9956-ffa450edef68
2014-12-25 09:16:44 +00:00
Nick Burch
5ce675f345 Fix inconsistent whitespace/indents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647884 13f79535-47bb-0310-9956-ffa450edef68
2014-12-25 09:13:40 +00:00
Dominik Stadler
c7044b77aa Add javadoc to CellRange.getReferenceText()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647883 13f79535-47bb-0310-9956-ffa450edef68
2014-12-25 08:59:16 +00:00
Andreas Beeker
202aa8177f - Support for Office Binary Document RC4 CryptoAPI Encryption for HSLF
- Support for Office Binary Document RC4 Encryption
- use LittleEndian class in LittleEndianInputStream
- add normalize method for HSLF, to remove edit history, which is also necessary for encryption support
- update PersistDirectoryEntry handling in PersistPtrHolder to recognize groups while serializing
- deprecated PersistPtrHolder.getSlideOffsetDataLocationsLookup() - throws now UnsupportedOperationException,
  as this wasn't used outside the scope of the class and was quite internal logic of PersistPtrHolder


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647867 13f79535-47bb-0310-9956-ffa450edef68
2014-12-25 01:56:29 +00:00
Dominik Stadler
ed60f5cb08 Add comment
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647512 13f79535-47bb-0310-9956-ffa450edef68
2014-12-23 09:26:22 +00:00