moparisthebest/poi
1
0
Fork 0
Code Issues Pull Requests Releases 1 Wiki Activity
7,295 Commits 29 Branches 84 Tags 722 MiB
191726ee7b
Commit Graph

5997 Commits

Author SHA1 Message Date
Dominik Stadler
33cf4c310b DumpPOIFS: Create a separate named sub-directory for each file to not overwrite each other when passing in multiple files for dumping, check for failing mkdirs() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737031 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-29 18:44:11 +00:00
Dominik Stadler
992adb9c16 Revert set of inadvertedly committed files/changes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737029 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-29 18:11:44 +00:00
Dominik Stadler
f5332a3a40 Bug 58915: Add note about memory consumption and update changelog 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737025 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-29 17:30:55 +00:00
Dominik Stadler
ff68b433b8 Bug 58915: Update javadoc for memory consumption and fix some other javadoc and compiler warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737024 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-29 17:27:20 +00:00
Dominik Stadler
00e6abb6bc Try to reproduce bug 58922, convert to JUnit 4 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737018 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-29 16:11:29 +00:00
Dominik Stadler
0888ad4de5 Fix some compiler warnings, improve error message, cover some more code 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737013 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-29 15:45:04 +00:00
Dominik Stadler
02b29ea698 Bug 59132: Adjust implementation of COUNTBLANK to be conforming to Excel, empty strings are counted as blank as well 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737009 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-29 14:53:44 +00:00
Andreas Beeker
4eeffd0532 XSLF: do not display Master Slide objects by default 
XSLF: fix alternate content handling for picture shapes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736935 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-28 22:52:01 +00:00
Andreas Beeker
f8767e3981 some zips can't be opened via ZipFile in JDK6, as the central directory 
contains either non-latin entries or the compression type can't be handled
the workaround is to iterate over the stream and not the directory


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736933 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-28 22:49:45 +00:00
Andreas Beeker
ceda10fa32 sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736932 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-28 22:46:53 +00:00
Dominik Stadler
0115c12e2d Fix some compiler warnings, javadoc, ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736924 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-28 20:22:08 +00:00
Dominik Stadler
8afb394974 Bug 59199: Handle null date-values in a similar way as null-Strings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736923 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-28 20:20:29 +00:00
Javen O'Neal
4f4531c67e assertCloseDoesNotModifyFile method was adapted from method with the same name in TestWorkbookFactory 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736744 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-27 13:09:50 +00:00
Javen O'Neal
6b6b6a668e add more commented-out tests for bug 58779: closing an XML Workbook that was not opened as read-only will modify the file on disk 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736742 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-27 13:04:37 +00:00
Javen O'Neal
01b20a6567 make OPCPackage logger final 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736721 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-27 05:01:02 +00:00
Javen O'Neal
f0e824587b bug 59224: change hasTint, add hasAlpha and unit tests. Patch from gubespam@gmail.com 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736469 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-24 17:29:00 +00:00
Javen O'Neal
4fe9f0bcab make private member variable ctColor final 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736395 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-24 06:37:34 +00:00
Javen O'Neal
784b07e424 bug 59222: fix NPE thrown by (S)XSSFSheet.getCellComments(). Reported by Vasily Kopytov. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736347 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-23 16:42:04 +00:00
Javen O'Neal
1128818a70 bug 59212: Do not check for overlapping regions when adding merged regions to a sheet 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736165 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-22 09:22:03 +00:00
Javen O'Neal
e2615ce68e bug 59212: Do not check for overlapping regions when adding merged regions to a sheet 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736155 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-22 09:02:08 +00:00
Dominik Stadler
d806c2ac2b Check for null in IOUtils.closeQuietly() to not log this unnecessarily 
Add coverage for some  more methods in ExtractorFactory
Fix some IntelliJ warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736146 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-22 07:51:39 +00:00
Javen O'Neal
dd308cd87e return unmodifiable shared strings to guarentee parallel data structures stay in sync 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736144 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-22 07:04:51 +00:00
Javen O'Neal
a61e242e86 bug 59208: correctly understand val="1" for isBold, isItalic, etc 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736126 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-22 04:20:45 +00:00
Javen O'Neal
e89f19bef3 fix inconsistent newlines (remove carriage returns), set svnprop eol-style native 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736121 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-22 02:31:16 +00:00
Andreas Beeker
197aef5420 findbugs fixes - SE_COMPARATOR_SHOULD_BE_SERIALIZABLE 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736114 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-21 23:42:56 +00:00
Andreas Beeker
762864d0f2 findbugs fixes - RR_NOT_CHECKED 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736112 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-21 23:29:06 +00:00
Andreas Beeker
e9f333827d fix eclipse warnings 
close resources

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735912 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-21 00:14:21 +00:00
Andreas Beeker
8be67e1910 fix eclipse warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735881 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-20 13:36:56 +00:00
Andreas Beeker
b09c85ff04 eclipse warning fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735706 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-18 23:12:28 +00:00
Andreas Beeker
87f4e8fa63 sonar fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735696 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-18 22:21:12 +00:00
Andreas Beeker
488ce5fec3 #59195 - POIXMLTypeLoader depends on XMLBeans 2.6.0 - remove piccolo classes from xmlbeans jars and disable xmloption in type loader 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735685 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-18 21:34:03 +00:00
Andreas Beeker
33991bfd98 sonar fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735514 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-17 22:39:20 +00:00
Andreas Beeker
492e51b15f findbugs fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735513 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-17 22:36:11 +00:00
Andreas Beeker
3e6de40c64 sonar fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735507 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-17 21:52:53 +00:00
Andreas Beeker
4187b04edb forgot another contains call ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735349 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 23:40:00 +00:00
Andreas Beeker
61388344ba findbugs fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735348 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 23:36:17 +00:00
Andreas Beeker
56ceb000f1 sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735345 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 23:30:19 +00:00
Andreas Beeker
7652be2ed1 sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735323 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 22:34:26 +00:00
Andreas Beeker
d749785d1f sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735321 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 22:27:56 +00:00
Andreas Beeker
d6d47e0bca findbugs fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735319 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 22:10:27 +00:00
Andreas Beeker
4c4d718f52 forbidden-apis-fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735316 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 21:59:40 +00:00
Andreas Beeker
a7c073ada9 findbugs fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735312 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 21:46:28 +00:00
Andreas Beeker
ac6a01898d sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735301 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 21:20:15 +00:00
Andreas Beeker
80e4d8b879 First try of uncluttering CellNumberFormatter. 
Make inner classes static and remove setting of private outer properties while in constructor.
Make properties final to make sure they are only set once.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735300 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 21:18:58 +00:00
Andreas Beeker
52fe2e4571 Fix for Softmaker Office files, which set encryption settings invalidly 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735298 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 21:05:37 +00:00
Tim Allison
81e49eff0f 59183 - handle timezones (even with colons) in date parsing metadata in ooxml opc 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735270 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 17:52:42 +00:00
Nick Burch
560ce3ee0b Ignore ODS 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735079 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-15 14:17:47 +00:00
Nick Burch
197458b30c One final invalid file type check 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735071 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-15 12:37:01 +00:00
Nick Burch
7112835d90 Before opening an OOXML file, check the first few bytes, and give helpful exceptions for common mistakes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735069 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-15 12:30:45 +00:00
Nick Burch
700fe05e34 Push all the zip opening logic into ZipHelper 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735064 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-15 12:03:30 +00:00
Nick Burch
0fab07ccfc Fix inconsistent indents 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735063 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-15 11:56:28 +00:00
Nick Burch
5f2f0adfae Fix inconsistent indents 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735061 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-15 11:54:16 +00:00
Nick Burch
4d7955d6b5 Start to give more helpful Exceptions from OPCPackage when non-OOXML files are passed to it 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735060 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-15 11:50:57 +00:00
Dominik Stadler
4a98bd4c27 Remove some useless lines of code, the initialAllocationSize is ignored in SXSSFRow() anyway 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734925 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-14 12:00:27 +00:00
Dominik Stadler
d853210049 Fix some IntelliJ warnings and adjust Javadoc of readFully() slightly to describe the behavior better. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734924 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-14 11:58:15 +00:00
Andreas Beeker
3f4f58829d HSLF: Add support for system colors 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734865 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-14 00:42:59 +00:00
Dominik Stadler
4bd9afde4f Bug 56930: Add Workbook.getNames() to allow to query for names that appear multiple times 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734863 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-13 21:30:38 +00:00
Dominik Stadler
3c1052e375 Bug 55791: Avoid using an existing file-name when creating a new slide, it could still be left over from previous partial removal 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734862 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-13 21:30:27 +00:00
Dominik Stadler
0a5dcbec1b Bug 55668: Try to avoid NullPointerException when chaning cell type and formula leads to null-string by seting the cell to BLANK instead 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734861 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-13 21:30:18 +00:00
Nick Burch
2718aa2f51 Escape spaces in the URL 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734858 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-13 21:19:46 +00:00
Andreas Beeker
653403e956 #59135 - Password gets truncated when using passwords longer than 15 characters for the function protectSheet() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734843 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-13 19:31:32 +00:00
Andreas Beeker
045123e198 sonar fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734809 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-13 14:12:43 +00:00
Dominik Stadler
9bf1bf60b2 Bug 57200: Do not try to delete the poifiles-tempdir as it can interfere when multiple applications are using SXSSF on the same machine. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734719 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-12 16:56:33 +00:00
Dominik Stadler
f1a476d83a Fix bug 56549: correctly calculate char index ranges for HWPF in the TextPieceTable 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734718 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-12 16:56:26 +00:00
Andreas Beeker
8e36872c48 #59170 - Remove deprecated classes (POI 3.15) - *Workbook.setRepeatingRowsAndColumns() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734701 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-12 13:33:53 +00:00
Dominik Stadler
2b28cd97a3 Apply patch to fix bug 57495: getTableArray method can not get 0 pos table 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734694 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-12 11:45:34 +00:00
Dominik Stadler
06083f85f4 Refactor some common code from the various Document-Factories into a helper class 
Fix a potential file-handle-leak for password protected workbooks or slideshows

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734691 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-12 11:37:32 +00:00
Dominik Stadler
6d97ae7083 Fix some cases where POI itself or the tests leaked file-handles 
Also fix some IntelliJ warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734690 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-12 11:37:22 +00:00
Dominik Stadler
128a991f9c Findbugs fixes 
OldExcelExtractor could leak file handles in case of exceptions
Free file handles in POIFSDump, add unit-test for POIFSDump
Add a Findbugs exclude and adjust findbugs-ant slightly

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734689 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-12 11:37:12 +00:00
Dominik Stadler
b1bc13c26f Mark duplicated RecordFormatException as deprecated to be able to remove it at some point in the future 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734688 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-12 11:36:56 +00:00
Dominik Stadler
b989e4f5a8 Enable some tests that are ignored, actually run green and did not have any comment why they were ignored in the first place 
Fix some compiler warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734687 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-12 11:36:50 +00:00
Dominik Stadler
8c508d89b0 Add test for bug 59098 which shows that this is fixed in 3.14. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734686 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-12 11:36:43 +00:00
Andreas Beeker
7d6be0ff54 #59170 - Remove deprecated classes (POI 3.15) - org.apache.poi.hssf/ss.util.Region 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734651 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-12 00:17:16 +00:00
Andreas Beeker
0776e32108 sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734641 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-11 23:14:09 +00:00
Andreas Beeker
630bdd0f15 sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734339 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-10 00:32:33 +00:00
Andreas Beeker
1b9523898d sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734337 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-10 00:20:34 +00:00
Andreas Beeker
e2fc2822a6 Remove a superfluous/bloated log function, which String.format can do better and is only used once ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734310 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-09 20:57:26 +00:00
Nick Burch
9090741226 More helpful exception message if POIFS is given a raw XML file (eg an Office 2003 XML file), plus tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734215 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-09 10:57:52 +00:00
Andreas Beeker
9f47700711 #59058 - OOM when parsing docx after OPCPackage.open with File but not with InputStream (TIKA-1866) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734184 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-09 01:25:02 +00:00
Andreas Beeker
3a328aa220 #57031 - Out of Memory when extracting text from attached files 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734182 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-09 00:41:02 +00:00
Dominik Stadler
e444b4b01a Fix source rebuilding verification after resulting binaries in dist-folder changed 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1733878 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-07 08:32:11 +00:00
Nick Burch
ea9169b3c4 Comment and Javadoc updates 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1733119 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-01 18:11:14 +00:00
Andreas Beeker
261ef4934c #59056 - Render individual slideshow shapes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732974 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-29 23:59:49 +00:00
Andreas Beeker
e5baa15b25 Fix NPE of regression tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732972 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-29 23:36:58 +00:00
Dominik Stadler
4ad3d7b35a Exclude file for bug 59074 for some more tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732783 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-28 19:40:25 +00:00
Andreas Beeker
a7ca3d19ae find bugs fix - WMF_HEADER_MAGIC isn't final but should be 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732753 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-28 15:24:14 +00:00
Dominik Stadler
2fa065d96c Also mark the file for bug 59074 as expected-failure for integration testing 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732620 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-27 10:23:53 +00:00
Dominik Stadler
da1879c1b2 Bug 57914: Provide a better error message for OOXML strict format which we do not support yet. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732619 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-27 10:23:46 +00:00
Nick Burch
62b5b0d874 #59074 More helpful exception if Excel 1-95 files are given to ExtractorFactory 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732587 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-26 23:56:31 +00:00
Nick Burch
856261f4d0 Refactor out the POIFS directory entry name for Excel 1-95 entries, and have ExtractorFactory detect (but not support) these old files 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732583 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-26 23:43:59 +00:00
Nick Burch
1cbcfbe026 Fix inconsistent indents 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732580 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-26 23:32:54 +00:00
Nick Burch
0b8283b37c Refactor to pull out the list of Excel 97+ directory entry names to a common place, avoiding duplication. Also starts on unit testing #59074 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732579 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-26 23:32:17 +00:00
Andreas Beeker
41d693fe15 Regression fixes for H/XSLF and HWMF 
see http://apache-poi.1045710.n5.nabble.com/3-14-beta-2-3-14-final-tt5721829.html

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732236 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-24 22:43:51 +00:00
Dominik Stadler
161ef55132 Bug 47245: Comment out check and exception in case row-records are missing for some cells as it seems POI is handling this gracefully and LibreOffice/Excel are as well 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732235 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-24 22:39:11 +00:00
Nick Burch
d35942ca52 #59021 Namespace aware processing fix for ReadOnlySharedStringsTable, to match the one recently added to XSSFSheetXMLHandler 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731986 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-23 22:24:09 +00:00
Nick Burch
194fdfe162 Pull out two more XSSF namespace definitions as re-usable constants 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731980 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-23 22:16:54 +00:00
Nick Burch
094e3f68e6 Pull out http://schemas.openxmlformats.org/spreadsheetml/2006/main to a re-used constant 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731975 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-23 22:10:20 +00:00
Nick Burch
c58e4fe96c Patch from Jim King from bug #57989 - XSSFChart support for setting chart titles, plus get+set unit tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731566 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-21 21:17:23 +00:00
Dominik Stadler
0f10be0ca4 One more possible resource leak when creating the TextExtractor fails with a RuntimeException or one of the named exceptions 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731561 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-21 20:42:05 +00:00
Dominik Stadler
10f46da1ae Include stacktrace of inner exception when block-positions are invalid in POIFSFileSystem 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731560 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-21 20:41:56 +00:00
Tim Allison
bc716a2796 POI 59030 fix NPE in XWPFTableCell's getVerticalAlignment via Prasad Babu 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731257 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-19 15:46:26 +00:00
Javen O'Neal
2cab09db04 bug 58896: comment out time-dependent test 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731101 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-18 17:53:13 +00:00
Nick Burch
20777db2e7 Javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731047 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-18 11:16:11 +00:00
Javen O'Neal
7bb1a1bb22 move trackColumnsForAutoSizingIfSXSSF into ITestDataProvider, replace ITestDataProvider.trackColumnsForAutosizing(Sheet, int...) with ITestDataProvider.trackAllColumnsForAutosizing(Sheet) to avoid cluttering unit tests with specific columns that will be autosized 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730999 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-18 04:05:45 +00:00
Javen O'Neal
57ebf6b133 bug 58896: add unit test to time Sheet.autoSizeColumn 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730997 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-18 03:33:25 +00:00
Javen O'Neal
5e52b6f4e9 avoid redundant null check 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730994 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-18 02:03:11 +00:00
Tim Allison
9e46ee937c 59021 -- fix content extraction from namespaced elements in XSSFEventBasedExcelExtractor 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730992 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-18 01:49:59 +00:00
Javen O'Neal
c80fa0c870 bug 56345: reject single-cell merged regions 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730991 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-18 01:33:14 +00:00
Dominik Stadler
5093542774 Add test which verifies that bug 52684 is not a problem (any more) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730948 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-17 21:35:22 +00:00
Javen O'Neal
3cb72bfa7b bug 58339: patch from Patrick Zimmermann to allow OFFSET() to accept missing optional width or height parameters 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730606 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-15 20:27:59 +00:00
Dominik Stadler
4aeff3f0ac Tried to reproduce bug 55476, but could not, added unit test anyway 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730598 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-15 19:16:45 +00:00
Nick Burch
86153c0ea6 Add details of the ignored errors where the HSSF spec provides a good description, and a bit more refactoring. #56892 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730543 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-15 14:58:16 +00:00
Nick Burch
0982d9dee5 Start generalising the IgnoredErrorType code for later HSSF use too #56892 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730540 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-15 14:40:24 +00:00
Dominik Stadler
63a7f89342 No need to wrap OpenXML4JRuntimeException in another instance of itself and fix some compilation/javadoc warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730482 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-15 10:08:26 +00:00
Dominik Stadler
677b19afbd GitHub PR 27: Add method to check for any protection in XWPFDocument, closes #27 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730471 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-15 09:26:51 +00:00
Dominik Stadler
98da5af350 Seems we need a cast here to compile with some newer JDKs, at least IntelliJ complains for me 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730464 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-15 08:33:12 +00:00
Dominik Stadler
528a64dc76 Improve error messages to state which bounds are exceeded 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730463 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-15 07:41:47 +00:00
Dominik Stadler
b01efb6855 Regression analysis: Cloning sheets failed on ctrlProps, i.e. checkboxes 
and other GUI elements, add minimal support for these to allow clone to
succeed.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730275 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-13 21:30:10 +00:00
Dominik Stadler
c68a9e4c02 Regression analysis: the additional testing of cloning sheets showed a 
possible ArrayIndexOutOfBounds error which we can avoid to make cloning
fail a bit less.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730274 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-13 21:29:46 +00:00
Dominik Stadler
eeee511f71 Ignore a failure during cloning if we exceed file-format limits 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730273 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-13 21:29:23 +00:00
Dominik Stadler
b6de146895 bug 58996: Don't try to unset fill color if it is not set to avoid invalid access inside the Xml structures 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1729964 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-12 09:44:47 +00:00
Nick Burch
118b728156 Fix #57034 on SXSSF, and add a common unit test to show it was already fixed on the others + is now fixed for SXSSF 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1729849 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-11 15:13:40 +00:00
Nick Burch
a3966df033 Allow common tests to do auto-sizing even on SXSSF 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1729848 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-11 15:13:01 +00:00
Andreas Beeker
2aa39f5bdb Add example for adding videos 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1728888 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-06 22:23:47 +00:00
Andreas Beeker
ce22cc44c4 XSLF - fixed NPE when adding pictures with existing non-picture media files (e.g. movies) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1728737 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-05 22:03:44 +00:00
Dominik Stadler
fb07d95b55 Remove file from expected failures after changes for bug 56880 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1728612 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-05 07:51:35 +00:00
Tim Allison
827c3f562b Bug 56880 - switch exception to logged warning that non-extended pascal strings are not supported. Full fix would add parsing for these strings. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1728547 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-04 19:54:15 +00:00
Javen O'Neal
95e95dfabb remove deprecated (2009) HSSFComment#setColumn(short). int version is available. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727805 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-31 12:52:32 +00:00
Javen O'Neal
80c9b356c2 HSSFComment: note a final field 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727803 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-31 12:33:00 +00:00
Javen O'Neal
dc860a6f93 fix O(n^2) runtime unnecessarily recreating an array inside a for-loop 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727800 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-31 12:14:55 +00:00
Javen O'Neal
6c89d062bf bug 58885: fix javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727777 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-31 04:04:56 +00:00
Javen O'Neal
e365e9cbac bug 58885: performance regression on XSSFSheet.addMergedRegion(CellRangeAddress). Add an unsafe version of addMergedRegion that doesn't check for overlapping merged regions 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727776 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-31 03:27:35 +00:00
Dominik Stadler
a79dfd18e4 Adjust test to pass forbidden-apis-check 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727693 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-30 11:02:54 +00:00
Dominik Stadler
68997de5f0 Make OldExcelExtractor Closeable to be able to free up resources if getText() was not called 
Allow Excel files which have an entry "Workbook" instead of "Book" like other classes do
Add some more unit tests to cover more of the code

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727653 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-29 22:09:03 +00:00
Dominik Stadler
f94bb63332 add an ignored test for bug 58804 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1726681 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-25 20:21:30 +00:00
Andreas Beeker
5fad9af36f #41047 - Support hyperlinks in HSLF shapes and textruns 
#47291 - Cannot open link correctly which insert in ppt

HSLF hyperlink code was all over the place - moved most of it into HSLFHyperlink
extended common sl for hyperlinks
extended XSLF shape linking and added XSLFTextShape.appendText to go along with HSLF
adapted/fixed documentation
added convenience methods to the hyperlink classes to address the different targets

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1726458 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-24 00:12:10 +00:00
Dominik Stadler
2ac89a2dc9 Rename test-source file to actual class name to avoid constant recompilations on 'compile-main' 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1725336 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-18 20:16:38 +00:00
Dominik Stadler
a369daa432 Fix possible NPE found with msg-file from CommonCrawl 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1725334 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-18 20:16:23 +00:00
Dominik Stadler
fe359afec3 Fix possible NullPointerException with invalid/unsupported image types 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1725332 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-18 19:56:30 +00:00
Javen O'Neal
0173f22787 make SXSSFWorkbook member variables private 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1725047 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-16 22:58:25 +00:00
Javen O'Neal
14beee1cfd whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1725043 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-16 22:23:31 +00:00
Javen O'Neal
18c5045d5b fix questionable List.remove(int) in SXSSFITestDataProvider 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1725042 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-16 22:23:05 +00:00
Andreas Beeker
94fdd517aa BugFix: wrong hyperlink record added - used child instead of parent record 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1725041 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-16 22:19:34 +00:00
Javen O'Neal
51e4b32498 add @Override annotations to ITestDataProviders 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1725040 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-16 22:03:58 +00:00
Javen O'Neal
276e95e43f bug 58879: add SpreadsheetVersion to Workbook interface 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1725039 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-16 22:01:33 +00:00
Andreas Beeker
79920b06eb Fix NPE when calling HSLFTextRun.setHorizontalCentered() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1725022 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-16 19:27:58 +00:00
Andreas Beeker
c1263423cf #56004 - Support for WMF rendering 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724897 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-16 00:11:01 +00:00
Dominik Stadler
bdef6e1c52 Regression in version 3.14-beta1: three or four-part formats with locale id cause exceptions when formatting instead of falling back to other formatting 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724488 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-13 19:46:17 +00:00
Dominik Stadler
50d09bf36c Fix a NullPointerException that occurs with some PPTs now but did not in POI 3.13 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724487 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-13 19:45:49 +00:00
Dominik Stadler
e91e15ab10 Eclipse warnings, helper unit-test, improve information provided in Exceptions, do not swallow inner stacktraces, ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724486 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-13 19:45:05 +00:00