Javen O'Neal
|
49add35f3b
|
fix compile error
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812531 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-18 14:40:05 +00:00 |
|
Javen O'Neal
|
42c4e4909c
|
cleanup for r1812475: avoid NPEs from string.isEmpty()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812520 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-18 14:29:56 +00:00 |
|
Javen O'Neal
|
fc2bcfae9a
|
cleanup for r1812476: avoid NPEs from string.isEmpty()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812516 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-18 14:08:43 +00:00 |
|
Javen O'Neal
|
5fb4887907
|
replace "".equals(string) with string.isEmpty() to avoid null strings silently evaluating to false; most code should probably check string for null if it is not already
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812476 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-18 08:41:42 +00:00 |
|
Javen O'Neal
|
aba704b928
|
prefer literal.equals(variable) over variable.equals(literal)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812475 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-18 08:41:25 +00:00 |
|
Javen O'Neal
|
3a2ee5f4d1
|
convert "".equals(string) to string.isEmpty()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812470 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-18 08:22:51 +00:00 |
|
Javen O'Neal
|
21b65721e7
|
simplfy PackagingURIHelper#combine boolean logic using xor and replacing +FORWARD_SLASH_CHAR with FORWARD_SLASH_STRING
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812468 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-18 08:10:36 +00:00 |
|
Javen O'Neal
|
afa5be82d3
|
fix typo
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812464 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-18 07:47:25 +00:00 |
|
Javen O'Neal
|
cfac692a6a
|
string.equals("") -> string.isEmpty() or "".equals(string)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812463 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-18 07:45:53 +00:00 |
|
Javen O'Neal
|
36dcbd7403
|
for -> foreach
string.equals() -> string.isEmpty() or .equals(string)
ArrayList -> List
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812461 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-18 07:33:07 +00:00 |
|
Javen O'Neal
|
bcbadce32e
|
IntelliJ: simplify boolean logic
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812363 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-17 07:43:41 +00:00 |
|
Javen O'Neal
|
7eb6686b1d
|
remove deprecated XSSFRowShifter.shiftMerged(int,int,int) method; replaced with RowShifter.shiftMergedRegions(int,int,int) in POI 3.15 beta 2
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812354 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-17 07:10:25 +00:00 |
|
Javen O'Neal
|
e5f8463381
|
ignore gradle/, gradlew, and gradlew.bat
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812351 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-17 06:13:09 +00:00 |
|
Dustin Spicuzza
|
ab147e9998
|
Bug 61584: Fix XDGFPage variable typo causing crash
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812240 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-16 01:35:31 +00:00 |
|
Javen O'Neal
|
e593f50186
|
github-79: add String.toString() to forbidden API's
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812239 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-16 01:34:13 +00:00 |
|
PJ Fanning
|
16125ab3cc
|
Make public static members final [thanks to Kui Liu]. This close #78.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812234 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-15 20:50:58 +00:00 |
|
PJ Fanning
|
e1571c9130
|
Remove unnecessary toString calls [thanks to Kui Liu]. This close #79.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812233 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-15 20:34:10 +00:00 |
|
PJ Fanning
|
229af142fc
|
Remove unnecessary StringBuilder [thanks to Kui Liu]. This close #80.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812232 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-15 20:25:33 +00:00 |
|
Dominik Stadler
|
bc7d79a613
|
Fix some findbugs-issues and apply some code-cleanup and apply some smaller pull requests.
This closes #74, This closes #75, This closes #76
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812097 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-13 09:40:22 +00:00 |
|
Dominik Stadler
|
887ec868b7
|
Fix aparent copy/paste error in XSSFBorderFormatting
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811867 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-11 18:32:13 +00:00 |
|
Dominik Stadler
|
793938ecef
|
Bug 58068: Add a method to pass the actual Color to StylesTable.findFont().
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811866 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-11 18:32:01 +00:00 |
|
Dominik Stadler
|
c05e07b55c
|
adjust tests, javadoc, ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811865 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-11 18:31:34 +00:00 |
|
Dominik Stadler
|
673b223f61
|
Remove "filling" in IntList as this has no effect whatsoever as far as I could see
Fix some IntelliJ warnings, missing JavaDoc, typos, Findbugs issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811793 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-11 05:32:05 +00:00 |
|
Dominik Stadler
|
a21c09fd61
|
Add more output to the pre-check to help in analysis some strange build-failures in CI, e.g. INFRA-15244
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811597 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-09 19:35:43 +00:00 |
|
Dominik Stadler
|
73443aacf6
|
Fix target compile-ooxml-ss, it needs the crypt-code now
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811596 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-09 19:35:39 +00:00 |
|
Dominik Stadler
|
e24f25d0ef
|
Add test which shows that bug 51262 is fixed now
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811595 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-09 19:35:32 +00:00 |
|
Dominik Stadler
|
566789e983
|
Apply patch from bug 61096: Add support for modules in VBAMacroReader
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811383 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-07 06:11:12 +00:00 |
|
Dominik Stadler
|
c2d09c0217
|
Bug 61586: Add test which shows that it works as expected
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811355 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-06 17:41:20 +00:00 |
|
Dominik Stadler
|
0e52f62a1e
|
Bug 61564: Try to get rid of the Java 9 illegal access warning now that we run Java 8
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811145 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-04 19:54:41 +00:00 |
|
Dominik Stadler
|
dd23ba89a9
|
Add some more code from the separate integration test project to be able to publish the femaining functionality as separate project at some point
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811144 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-04 19:54:21 +00:00 |
|
Dominik Stadler
|
48613ee271
|
Bug 61064: Support behavior of function CEILING in newer versions of Microsoft Excel
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1810007 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-28 14:36:53 +00:00 |
|
Dominik Stadler
|
6450f1cc42
|
Bug 61082: Adjust JavaDoc for getFirst/LastRow/Cell to explain that there might be empty rows/cells included in the counts
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809988 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-28 13:12:32 +00:00 |
|
Dominik Stadler
|
688d5072d1
|
Fix bug 61516: when copying cells with formulas we should properly check for references that are invalid afterwards.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809967 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-28 09:56:45 +00:00 |
|
Dominik Stadler
|
3adbe1f8c5
|
Adjust some unit-tests, use try-with-resource, enable test which works now, ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809739 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-26 12:40:38 +00:00 |
|
Dominik Stadler
|
a751880c11
|
Replace "getEntry() plus catch" by "hasEntry()" in HSSFWorkbook
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809738 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-26 12:33:08 +00:00 |
|
Dominik Stadler
|
991fba37a2
|
Fixup change for CellReference to keep the behavior the same as before
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809737 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-26 12:31:51 +00:00 |
|
Dominik Stadler
|
5c90d94d8c
|
Remove empty directories beneath "scratchpad"
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809735 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-26 12:22:53 +00:00 |
|
Dominik Stadler
|
af1b1d619c
|
Replace deprecated CellReference class and some other warnings fixed
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809714 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-26 08:26:05 +00:00 |
|
Dominik Stadler
|
43717f6936
|
Fix some Sonar issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809636 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-25 15:10:40 +00:00 |
|
Dominik Stadler
|
61a281e790
|
Replace the incompatible new interface method endSheet() with a Java 8 default method so existing implementations do not need to be adjusted. Also use this for headerFooter() and remove the empty implementations that are now obsolete.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809635 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-25 14:45:14 +00:00 |
|
Tim Allison
|
7a2ce09761
|
Bug 61349 -- bump limits on classes that caused regressions in Dominik's regression corpus. Many thanks to Dominik Stadler for running the regression tests!!!
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809623 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-25 12:53:10 +00:00 |
|
PJ Fanning
|
3a622169d3
|
Remove more deprecated classes and methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809428 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-23 14:03:25 +00:00 |
|
Dominik Stadler
|
8e1b51128c
|
Fix compiling Examples after adding new interface-method, fix compiler warnings and adjust some broken Javadoc
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809388 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-23 10:26:27 +00:00 |
|
Dominik Stadler
|
acb1772d4b
|
Tried to enable this test, but it is broken since a long time and I am not sure how this is expected to behave...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809372 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-23 07:44:09 +00:00 |
|
Dominik Stadler
|
4a6bb031a0
|
Apply patch to add endSheet() to the XSSFEventBasedExcelExtractor, fixes bug 60737, thanks to user zakim for the patch
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809371 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-23 07:41:27 +00:00 |
|
Dominik Stadler
|
5ed15ac7c2
|
More IntelliJ warnings fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809370 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-23 07:38:01 +00:00 |
|
Dominik Stadler
|
996010a3ca
|
The Gradle-based Sonarqube job does not actually, it completes with success, but the data never appears on Sonarqube itself, we need to investigate this some more later, for now I enabled the Maven based job again.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809359 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-22 21:30:40 +00:00 |
|
Dominik Stadler
|
29dbeb51ad
|
Bug 59747: Adjust order of first two entries in the resulting Zip to try to enable some external tools to auto-detect the file-type
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809357 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-22 21:19:39 +00:00 |
|
Dominik Stadler
|
e54490712a
|
Adjust many examples for Java 8: try-with-resource, multi-catch and other code cleanup.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809354 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-22 21:16:09 +00:00 |
|
Dominik Stadler
|
79a039ec8d
|
Fix some IntelliJ warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809349 13f79535-47bb-0310-9956-ffa450edef68
|
2017-09-22 20:07:56 +00:00 |
|