Commit Graph

4637 Commits

Author SHA1 Message Date
Nick Burch
ba4225395f Provide a convenience method for creating a PropertySet from a Directory + Entry
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590650 13f79535-47bb-0310-9956-ffa450edef68
2014-04-28 14:19:13 +00:00
Nick Burch
52c6fd587c Fix generics warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590642 13f79535-47bb-0310-9956-ffa450edef68
2014-04-28 14:03:18 +00:00
Nick Burch
3a5825c43f Update the HPSF change properties example to use NPOIFS + in-place writes, and have NPOIFS give a helpful error if you try to in-place write on a read only open
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590577 13f79535-47bb-0310-9956-ffa450edef68
2014-04-28 09:22:58 +00:00
Nick Burch
a57e1f1fa6 Get NPOIFS in-place-write working!
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590556 13f79535-47bb-0310-9956-ffa450edef68
2014-04-28 06:35:39 +00:00
Andreas Beeker
5cd8324b89 junit4 fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590327 13f79535-47bb-0310-9956-ffa450edef68
2014-04-26 23:37:40 +00:00
Nick Burch
3e6cb71fb9 More on the HPFS in-place NPOIFS write tests, and a note about what is still to do for them
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590319 13f79535-47bb-0310-9956-ffa450edef68
2014-04-26 22:50:00 +00:00
Nick Burch
f649abdbe9 Fix javadoc layout
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590317 13f79535-47bb-0310-9956-ffa450edef68
2014-04-26 22:43:23 +00:00
Nick Burch
0496d8f330 Convert the HPSF test to JUnit 4, and add a bit more testing for NPOIFS
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590309 13f79535-47bb-0310-9956-ffa450edef68
2014-04-26 21:51:28 +00:00
Nick Burch
7f5f7d0440 Stream tests for NDocumentOutputStream
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590303 13f79535-47bb-0310-9956-ffa450edef68
2014-04-26 21:33:19 +00:00
Nick Burch
73bc57db74 NDocumentOutputStream write logic
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590191 13f79535-47bb-0310-9956-ffa450edef68
2014-04-25 23:34:09 +00:00
Nick Burch
b77ce4fede Fix inconsistent whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590190 13f79535-47bb-0310-9956-ffa450edef68
2014-04-25 23:33:16 +00:00
Nick Burch
c3769b5da0 Begin to support and test in-place changes to documents within a NPOIFS stream
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590185 13f79535-47bb-0310-9956-ffa450edef68
2014-04-25 23:07:00 +00:00
Nick Burch
868a108fe3 Support for replacing the contents of a Document in a NPOIFSFileSytem, in place
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590177 13f79535-47bb-0310-9956-ffa450edef68
2014-04-25 22:40:51 +00:00
Nick Burch
0250a0372f Complete NPOIFS write tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590162 13f79535-47bb-0310-9956-ffa450edef68
2014-04-25 22:05:46 +00:00
Nick Burch
0bdc025279 When deleting a document in NPOIFS, free the underlying blocks
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590160 13f79535-47bb-0310-9956-ffa450edef68
2014-04-25 22:00:30 +00:00
Nick Burch
fb89f2c2aa More progress with the write/read npoifs tests, but one bug still to go....
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590153 13f79535-47bb-0310-9956-ffa450edef68
2014-04-25 21:23:10 +00:00
Nick Burch
2c23f889df Refactor some of the NPOIFS write tests, and begin on the last missing write test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590149 13f79535-47bb-0310-9956-ffa450edef68
2014-04-25 21:11:26 +00:00
Nick Burch
b1dd6b403f Add a getEntryNames() method to POIFS/NPOIFS directory entries, to make listing easier
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590148 13f79535-47bb-0310-9956-ffa450edef68
2014-04-25 21:10:52 +00:00
Nick Burch
f6e7e1c8c7 Finish off the next NPOIFS write text
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590133 13f79535-47bb-0310-9956-ffa450edef68
2014-04-25 20:38:55 +00:00
Nick Burch
6a89a9afbf More NPOIFS mini stream improvements, and more tests for it all
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590098 13f79535-47bb-0310-9956-ffa450edef68
2014-04-25 18:39:31 +00:00
Nick Burch
e4e0e93ff5 Correct mini stream initialisation, and enable more npoifs write tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590088 13f79535-47bb-0310-9956-ffa450edef68
2014-04-25 18:14:28 +00:00
Nick Burch
4b6ae05a04 More NPOIFS tests, and a partial mini-stream fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590083 13f79535-47bb-0310-9956-ffa450edef68
2014-04-25 17:06:10 +00:00
Nick Burch
4540a3c0ab More npoifs write tests, some disabled as failing
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589987 13f79535-47bb-0310-9956-ffa450edef68
2014-04-25 10:57:15 +00:00
Nick Burch
a4c8f4f1c9 Add common code for writing out and reading NPOIFS again, and add a disabled roundtrip test (currently failing...)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589895 13f79535-47bb-0310-9956-ffa450edef68
2014-04-24 22:22:06 +00:00
Nick Burch
1fc66d1f71 Correct NPOIFS mini stream first write bug, and add more NPOIFS stream write tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589881 13f79535-47bb-0310-9956-ffa450edef68
2014-04-24 21:08:34 +00:00
Nick Burch
950c10faf4 Add TODOs for the next set of NPOIFS write tests we need
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589868 13f79535-47bb-0310-9956-ffa450edef68
2014-04-24 20:23:43 +00:00
Nick Burch
a94f150450 More NPOIFS write testing, and fix a problem with writing xbat details out
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589806 13f79535-47bb-0310-9956-ffa450edef68
2014-04-24 17:44:10 +00:00
Nick Burch
166b8f6f8a Update a test to use the existing EntryUtils to copy with, rather than duplciating the logic, and tweak naming/javadocs to clarify what the test does
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589802 13f79535-47bb-0310-9956-ffa450edef68
2014-04-24 17:32:47 +00:00
Nick Burch
b2a35bb494 More unit tests for NPOIFS writing, and correct a bug in how bats get allocated in xbats. (Some issues still remain)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589800 13f79535-47bb-0310-9956-ffa450edef68
2014-04-24 17:25:10 +00:00
Nick Burch
fbd86d5084 More int/long sizing fixes for >2gb NPOIFS files, see bug #56447
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589783 13f79535-47bb-0310-9956-ffa450edef68
2014-04-24 16:15:21 +00:00
Nick Burch
e7dff43065 Fix bug #56450 - Avoid a NPE if a comment has no associated NoteRecord (but we still don't know where it belongs)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589770 13f79535-47bb-0310-9956-ffa450edef68
2014-04-24 15:42:53 +00:00
Nick Burch
d36d917467 Fix some Eclipse identified warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589765 13f79535-47bb-0310-9956-ffa450edef68
2014-04-24 15:07:20 +00:00
Nick Burch
6050a68d5a Two more test files from Stefan Kopf for bug #56164, and unit tests which use them
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589759 13f79535-47bb-0310-9956-ffa450edef68
2014-04-24 14:52:09 +00:00
Nick Burch
67d97d8894 Correct an eclipse warning around close(), and a related bug that this identified
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589756 13f79535-47bb-0310-9956-ffa450edef68
2014-04-24 14:50:52 +00:00
Andreas Beeker
14a7ae6316 Bug 56437 - [PATCH] Streaming write support in NPOIFS
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1588887 13f79535-47bb-0310-9956-ffa450edef68
2014-04-21 14:37:33 +00:00
Andreas Beeker
821d3ca5bd Some encryption fixes:
- don't rely on SecretKey object having the right algorithm set
- leave encryption-description parsing of string/stream to xmlbeans and refactor it to one location
- use namespaces of schema instead of hard-coded strings
- use CryptoFunctions.getMessageDigest() instead of code duplication

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1588874 13f79535-47bb-0310-9956-ffa450edef68
2014-04-21 12:16:54 +00:00
Nick Burch
d3ad1a9bb8 Tweak 'assertAlmostEquals' bast on Jenkins results
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1588595 13f79535-47bb-0310-9956-ffa450edef68
2014-04-18 23:44:08 +00:00
Nick Burch
1dc3c57c0c Unit test for column autosizing of % values
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1588562 13f79535-47bb-0310-9956-ffa450edef68
2014-04-18 20:46:57 +00:00
Dominik Stadler
0974acc778 Bug 56315: Make rounding in MathX.round() behave equal to Excel, adjust/enhance some more tests in MathX
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1588538 13f79535-47bb-0310-9956-ffa450edef68
2014-04-18 18:20:15 +00:00
Nick Burch
d2d289b90f Rather than having lots of classes all create their own XML DocumentBuilderFactory instance, push that logic to a helper which sets all the right defaults
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1587739 13f79535-47bb-0310-9956-ffa450edef68
2014-04-15 21:59:52 +00:00
Dominik Stadler
91b6961a44 Fix some Eclipse warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1584544 13f79535-47bb-0310-9956-ffa450edef68
2014-04-04 07:26:53 +00:00
Dominik Stadler
a08e8e4824 exclude new broken test-file for this test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1584543 13f79535-47bb-0310-9956-ffa450edef68
2014-04-04 07:26:24 +00:00
Nick Burch
32b69ac9b9 Add another test file for bug #47251, from Joe Yuan, and a disabled test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1583825 13f79535-47bb-0310-9956-ffa450edef68
2014-04-01 23:27:05 +00:00
Dominik Stadler
a202d2fa64 Fix two javadoc warnings reported in Jenkins build and add some @Overrides
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1583598 13f79535-47bb-0310-9956-ffa450edef68
2014-04-01 10:40:13 +00:00
Dominik Stadler
aef13a344a Undo a toString() removal for a case where it is actually necessary.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1583571 13f79535-47bb-0310-9956-ffa450edef68
2014-04-01 08:28:52 +00:00
Cédric Walter
1c987c38e6 performance issue: removed instantiation of new String object by copying an existing string.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1583366 13f79535-47bb-0310-9956-ffa450edef68
2014-03-31 16:16:52 +00:00
Cédric Walter
730deb782b performance issue: call toString() on a String object. This is entirely redundant.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1583358 13f79535-47bb-0310-9956-ffa450edef68
2014-03-31 16:01:39 +00:00
Cédric Walter
a0d1ab5add performance issue logging calls are expensive because of the objects created when assembling the log messages. Using the check() method of the logging sub-system can prevent object creation
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1583357 13f79535-47bb-0310-9956-ffa450edef68
2014-03-31 15:54:52 +00:00
Nick Burch
f52fe377ae Patch from bug #56328 from David North - the maximum row number in a formula depends on HSSF vs XSSF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1582892 13f79535-47bb-0310-9956-ffa450edef68
2014-03-28 21:54:30 +00:00
Nick Burch
8bee2665b3 Patch for #55594 from Paul Vonnahme - Fix SXSSF encodings on EBC
IDIC platforms, by setting the required encoding explicitly

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1580314 13f79535-47bb-0310-9956-ffa450edef68
2014-03-22 20:48:58 +00:00
Nick Burch
3868a2cdc7 Avoid an IndexOutOfBoundsException if there are no property nodes when searching for the start index, return -1 instead
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1578929 13f79535-47bb-0310-9956-ffa450edef68
2014-03-18 14:40:27 +00:00
Nick Burch
af381473d0 Support adding tabs to a XWPFRun, and add unit tests on toString() for addTab and addCarriageReturn
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1578921 13f79535-47bb-0310-9956-ffa450edef68
2014-03-18 14:26:28 +00:00
Nick Burch
e9ea048c00 Fix whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1578915 13f79535-47bb-0310-9956-ffa450edef68
2014-03-18 14:17:36 +00:00
Nick Burch
6d2ecdeac2 Fix bug #56278 - Support loading .xlsx files with no Styles Table
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1578518 13f79535-47bb-0310-9956-ffa450edef68
2014-03-17 19:02:21 +00:00
Dominik Stadler
ee58bd0d32 Bug 56195: replace System.err with propert logging
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1578147 13f79535-47bb-0310-9956-ffa450edef68
2014-03-16 19:46:56 +00:00
Dominik Stadler
24fdb260bc Remove two files added inadvertedely
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1577909 13f79535-47bb-0310-9956-ffa450edef68
2014-03-15 17:31:43 +00:00
Dominik Stadler
7c3f1a926b Bug 56169: Fix NPE during export to XML with xs:all
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1577907 13f79535-47bb-0310-9956-ffa450edef68
2014-03-15 17:29:17 +00:00
Dominik Stadler
f597633624 Bug 56114: Add testcase to verify that the flag is correctly stored in the XLS
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1577901 13f79535-47bb-0310-9956-ffa450edef68
2014-03-15 17:00:22 +00:00
Nick Burch
1e03ded992 When looking for text run related records after a TextHeaderAtom, provide a cleaner way to skip ones we don't care about, and a cleaner way to find the StyleTextPropAtom. Should fix #56260
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1577803 13f79535-47bb-0310-9956-ffa450edef68
2014-03-15 08:16:43 +00:00
Nick Burch
488647cb43 Implement MasterTextPropAtom, which provides the indents for a run of text, needed for #56260
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1577802 13f79535-47bb-0310-9956-ffa450edef68
2014-03-15 08:14:36 +00:00
Nick Burch
adb98e1073 #56260 Partial fix for a slide with a TextHeaderAtom but no other atoms related to it, which is followed by another TextHeaderAtom straight away
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1577537 13f79535-47bb-0310-9956-ffa450edef68
2014-03-14 13:59:24 +00:00
Andreas Beeker
c5527db88a Bug 56075 - Add Change Tracking support to XWPF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1577010 13f79535-47bb-0310-9956-ffa450edef68
2014-03-13 00:16:56 +00:00
Nick Burch
f63b47b8f6 Fix inconsistent whitespace, and add a close call in the main method to avoid a resource-leak warning
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575684 13f79535-47bb-0310-9956-ffa450edef68
2014-03-09 09:53:25 +00:00
Nick Burch
2a7cebf8c0 Patch from Shaun Kalley from bug #56023 - On CellReference, implement hashCode, fix the equals(Object) logic, and fix inconsistent whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575683 13f79535-47bb-0310-9956-ffa450edef68
2014-03-09 09:49:06 +00:00
Nick Burch
434f05058e Fix the inconsistent indents in the test file
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575600 13f79535-47bb-0310-9956-ffa450edef68
2014-03-08 20:03:40 +00:00
Nick Burch
09adb72510 Add more unit tests for XWPF Headers and Footers
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575599 13f79535-47bb-0310-9956-ffa450edef68
2014-03-08 20:01:38 +00:00
Nick Burch
d5c8510750 When adding a new XPWFRun to a paragraph, update both the Runs and IRuns lists with it
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575597 13f79535-47bb-0310-9956-ffa450edef68
2014-03-08 19:52:09 +00:00
Nick Burch
70e1b5edeb Add some javadocs for the XWPF Header/Footer creation methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575594 13f79535-47bb-0310-9956-ffa450edef68
2014-03-08 19:33:07 +00:00
Dominik Stadler
7e21a14172 Adjust for JDK 8 where an empty locale is added to the array returned by DateFormat.getAvailableLocales()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575563 13f79535-47bb-0310-9956-ffa450edef68
2014-03-08 16:46:59 +00:00
Dominik Stadler
8c5115aeb1 Fix Sonar issues about finalize() usage
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575501 13f79535-47bb-0310-9956-ffa450edef68
2014-03-08 08:41:25 +00:00
Dominik Stadler
a128bcd5e2 Enhance test to print out more information, it seems to fail on Apache Jenkins JDK8 build
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575500 13f79535-47bb-0310-9956-ffa450edef68
2014-03-08 08:41:08 +00:00
Dominik Stadler
382be9f312 Adjust TestExtractorFactory to provide more output to see why it fails on Maven builds on nemo.sonarsource.org
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575497 13f79535-47bb-0310-9956-ffa450edef68
2014-03-08 08:22:03 +00:00
Andreas Beeker
3fe86eca24 Added MD4-option and some cleanups
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1574732 13f79535-47bb-0310-9956-ffa450edef68
2014-03-06 00:53:09 +00:00
Nick Burch
f6a5959788 POI is now on JDK 1.6, so remove 1.5 workaround
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1574049 13f79535-47bb-0310-9956-ffa450edef68
2014-03-04 11:57:44 +00:00
Nick Burch
6d8a78a373 Report how long the CSV conversion took, helpful for a quick read performance test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1572555 13f79535-47bb-0310-9956-ffa450edef68
2014-02-27 13:32:27 +00:00
Andreas Beeker
833ae007f8 Bug 56076 - Add document protection with password support to XWPF
Bug 56077 - Add password hash function to HWPF

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1570750 13f79535-47bb-0310-9956-ffa450edef68
2014-02-21 23:19:57 +00:00
Nick Burch
31493632ea Zero length code page fix has been committed, so this file can once again be included in the overall test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1570390 13f79535-47bb-0310-9956-ffa450edef68
2014-02-20 23:37:20 +00:00
Nick Burch
7984a1ec3f More helpful visio v5 exception, see bug #56171
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1570388 13f79535-47bb-0310-9956-ffa450edef68
2014-02-20 23:20:19 +00:00
Nick Burch
32290bd2bf Another content types test, for #55026
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1570002 13f79535-47bb-0310-9956-ffa450edef68
2014-02-20 00:06:34 +00:00
Andreas Beeker
49c69f0eed The junit test failed with the original test-file (CDT_Data_Retention-PPT.ppt), so another check was necessary
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1569999 13f79535-47bb-0310-9956-ffa450edef68
2014-02-20 00:03:42 +00:00
Nick Burch
d72bd78c19 Fix bug #56164 - Tidy up the OPC SAX setup code with a new common Helper
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1569991 13f79535-47bb-0310-9956-ffa450edef68
2014-02-19 23:54:46 +00:00
Andreas Beeker
8afdb7a9ce Bug 55732 - PPT can't open, fails with "Couldn't instantiate .... StyleTextProp9Atom : java.lang.ArrayIndexOutOfBoundsException: 56"
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1569984 13f79535-47bb-0310-9956-ffa450edef68
2014-02-19 23:45:07 +00:00
Nick Burch
56d6f0342a Complete support for OOXML content types with parameters, including parts of the patch from Sebastien Schneider from bug #55026
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1569976 13f79535-47bb-0310-9956-ffa450edef68
2014-02-19 23:34:53 +00:00
Andreas Beeker
edf1ffd89b upgraded to junit4 (before other changes)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1569972 13f79535-47bb-0310-9956-ffa450edef68
2014-02-19 23:30:12 +00:00
Nick Burch
6e933cb242 Begin to implement some of the tests and logic for content types with parameters, based on the test file for bug #55026
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1569965 13f79535-47bb-0310-9956-ffa450edef68
2014-02-19 23:12:56 +00:00
Andreas Beeker
2cfc8dbf17 FindBugs fix
- fixed "Equals method should not assume anything about the type of its argument"
- see http://findbugs.sourceforge.net/bugDescriptions.html#BC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568861 13f79535-47bb-0310-9956-ffa450edef68
2014-02-16 23:36:32 +00:00
Nick Burch
c144310a15 Patch and test from Jon Iles from bug #56138 - HPSF code page strings can be zero length
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568813 13f79535-47bb-0310-9956-ffa450edef68
2014-02-16 19:35:55 +00:00
Andreas Beeker
53c90692ee FindBugs fix
- fixed "equals() method does not check for null argument"
- see http://findbugs.sourceforge.net/bugDescriptions.html#NP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENT

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568812 13f79535-47bb-0310-9956-ffa450edef68
2014-02-16 19:35:16 +00:00
Andreas Beeker
8689458854 Sweeping is also needed for empty column-list ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568791 13f79535-47bb-0310-9956-ffa450edef68
2014-02-16 17:00:53 +00:00
Andreas Beeker
2a14920cdd FindBugs fix
- fixed/checked various null pointer related entries
- see http://findbugs.sourceforge.net/bugDescriptions.html#NP_NULL_PARAM_DEREF
- ... NP_NULL_ON_SOME_PATH, NP_NULL_ON_SOME_PATH_EXCEPTION


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568789 13f79535-47bb-0310-9956-ffa450edef68
2014-02-16 16:30:24 +00:00
Dominik Stadler
dcad3624dc Fix unit tests broken by newly added test-file, ignore TestFontRendering as it is inherently unstable currently
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568744 13f79535-47bb-0310-9956-ffa450edef68
2014-02-16 09:11:28 +00:00
Dominik Stadler
7e63803aa9 Fix unit test which failed after new corrupted file was added.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568741 13f79535-47bb-0310-9956-ffa450edef68
2014-02-16 08:39:47 +00:00
Dominik Stadler
2414998aac Adjust test to write the failing PNG in case expected and actual do not match
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568740 13f79535-47bb-0310-9956-ffa450edef68
2014-02-16 08:39:17 +00:00
Dominik Stadler
023fa18794 Instead of using initCause() when re-throwing exceptions, it leads to better stacktraces if a simple constructor-argument is used
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568614 13f79535-47bb-0310-9956-ffa450edef68
2014-02-15 10:43:58 +00:00
Dominik Stadler
b51a52cf20 Provide more output on test that failed for me locally
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568558 13f79535-47bb-0310-9956-ffa450edef68
2014-02-15 00:21:19 +00:00
Dominik Stadler
8bc8ac9bef Adjust some tests to not hardcode the 'test-data' directory. This breaks the Sonar-maven build that I am working on locally
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568557 13f79535-47bb-0310-9956-ffa450edef68
2014-02-15 00:20:24 +00:00
Dominik Stadler
9b4121cb45 Update Javadoc somewhat
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568555 13f79535-47bb-0310-9956-ffa450edef68
2014-02-15 00:19:32 +00:00
Dominik Stadler
2b85b00690 Add assertions, remove Sonar warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568554 13f79535-47bb-0310-9956-ffa450edef68
2014-02-15 00:18:34 +00:00
Andreas Beeker
f8bf66308e update *ssf-workbook tests to junit4
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568541 13f79535-47bb-0310-9956-ffa450edef68
2014-02-14 23:21:30 +00:00
Andreas Beeker
a0831ba0f9 Bug 53130 - SXSSF Shared Strings option support, to make generated xlsx files compatible with Google Docs or iPad
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568539 13f79535-47bb-0310-9956-ffa450edef68
2014-02-14 22:45:05 +00:00
Andreas Beeker
92a488a28b FindBugs fix
- fixed "Should be a static inner class"
- see http://findbugs.sourceforge.net/bugDescriptions.html#SIC_INNER_SHOULD_BE_STATIC


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568178 13f79535-47bb-0310-9956-ffa450edef68
2014-02-14 01:00:45 +00:00
Andreas Beeker
3ceb93b23d FindBugs fix
- fixed "Field isn't final but should be"
- see http://findbugs.sourceforge.net/bugDescriptions.html#MS_SHOULD_BE_FINAL


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568145 13f79535-47bb-0310-9956-ffa450edef68
2014-02-13 23:34:11 +00:00
Andreas Beeker
276b477322 disable not applicable findbugs check
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1567815 13f79535-47bb-0310-9956-ffa450edef68
2014-02-13 00:07:36 +00:00
Andreas Beeker
8c3785890a Bug 55902 - Mixed fonts issue with Chinese characters (unable to form images from ppt)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1567455 13f79535-47bb-0310-9956-ffa450edef68
2014-02-11 23:16:54 +00:00
Andreas Beeker
413e76aed0 FindBugs fix
- fixed "Class defines equals() and uses Object.hashCode()"
- see http://findbugs.sourceforge.net/bugDescriptions.html#HE_EQUALS_USE_HASHCODE
- implemented UnicodeString.ExtRst.hashCode() + junit-test

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1566427 13f79535-47bb-0310-9956-ffa450edef68
2014-02-09 21:19:20 +00:00
Dominik Stadler
d9009484a6 Bug 55923: Fix compare/sorting of nodes in exported XML
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1564050 13f79535-47bb-0310-9956-ffa450edef68
2014-02-03 20:56:43 +00:00
Dominik Stadler
19ed26f156 Bug 55924: Avoid errors during exporting XML if there are numeric cells without value, also verify in tests that XML can always be parsed
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1564045 13f79535-47bb-0310-9956-ffa450edef68
2014-02-03 20:17:59 +00:00
Dominik Stadler
d7028dcf09 Bug 55926: Handle numeric formula values when exporting to XML
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1564028 13f79535-47bb-0310-9956-ffa450edef68
2014-02-03 19:46:41 +00:00
Dominik Stadler
503ce1e6c4 Bug 55927: Handle date types when exporting to XML
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1564011 13f79535-47bb-0310-9956-ffa450edef68
2014-02-03 19:19:14 +00:00
Nick Burch
d07ce077f5 Fix whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563660 13f79535-47bb-0310-9956-ffa450edef68
2014-02-02 16:44:30 +00:00
Nick Burch
e023d34c9a Add setIncludeHeadersFooters(boolean) to the ExcelExtractor common interface, as all implementations now have the method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563658 13f79535-47bb-0310-9956-ffa450edef68
2014-02-02 16:41:27 +00:00
Nick Burch
eb2e8ffe0a Patch from Shaun Kalley from bug #56022 - XSSF Event Text Extractor header/footer support
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563657 13f79535-47bb-0310-9956-ffa450edef68
2014-02-02 16:39:53 +00:00
Nick Burch
85bee89fe3 Fix whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563653 13f79535-47bb-0310-9956-ffa450edef68
2014-02-02 16:28:04 +00:00
Nick Burch
720b4a3aad Have the Excel text extractors all implement the same interface, as best as they can
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563650 13f79535-47bb-0310-9956-ffa450edef68
2014-02-02 16:23:26 +00:00
Dominik Stadler
cdb915a279 Bug 56017: Fix comment-ref when shiftig rows with comments, this probably does not fix the bug itself, though
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563587 13f79535-47bb-0310-9956-ffa450edef68
2014-02-02 10:34:42 +00:00
Andreas Beeker
c1a7ab3860 Bug 53282 - Hyperlink with a non-breaking space throws java.lang.IllegalStateException
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563540 13f79535-47bb-0310-9956-ffa450edef68
2014-02-02 01:56:02 +00:00
Andreas Beeker
028ec314ae javadoc fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563509 13f79535-47bb-0310-9956-ffa450edef68
2014-02-01 23:23:07 +00:00
Andreas Beeker
f101bc0aff Bug 55802 - Special Letters not exported correct
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563496 13f79535-47bb-0310-9956-ffa450edef68
2014-02-01 22:26:18 +00:00
Nick Burch
fdcd28194e Fix up whitespace / indents to be consistent
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563491 13f79535-47bb-0310-9956-ffa450edef68
2014-02-01 22:05:23 +00:00
Nick Burch
c5823a746f Fix javadoc formatting
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563489 13f79535-47bb-0310-9956-ffa450edef68
2014-02-01 21:58:24 +00:00
Andreas Beeker
5e7679eafd Javadoc fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563488 13f79535-47bb-0310-9956-ffa450edef68
2014-02-01 21:56:07 +00:00
Nick Burch
2b0c8deb2f Expose the StyleIndex of CharacterRuns, and expand the range style tests to cover this + related
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563486 13f79535-47bb-0310-9956-ffa450edef68
2014-02-01 21:52:19 +00:00
Andreas Beeker
5d0f69097c Bug 51891 - Fix StringIndexOutOfBoundsException : Ole10Native.<init> (parsing word file)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563483 13f79535-47bb-0310-9956-ffa450edef68
2014-02-01 21:45:48 +00:00
Dominik Stadler
7db6081827 Bug 56011: Use default style if the cell style attribute is not present
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563470 13f79535-47bb-0310-9956-ffa450edef68
2014-02-01 20:54:09 +00:00
Andreas Beeker
bd3cd2243e TreeSet without JDK 6 method usages
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1561511 13f79535-47bb-0310-9956-ffa450edef68
2014-01-26 16:26:59 +00:00
Andreas Beeker
e790281425 This patch is not working as of license incompatibility - see http://www.apache.org/licenses/GPL-compatibility.html
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1561507 13f79535-47bb-0310-9956-ffa450edef68
2014-01-26 15:38:11 +00:00
Andreas Beeker
6f6c6cda34 As Jdk 1.5 doesn't provide NavigableMap/Set classes of JDK 1.6, we temporarily use the open jdk classes instead, until POI has switched to JDK 1.6
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1561500 13f79535-47bb-0310-9956-ffa450edef68
2014-01-26 15:01:12 +00:00
Andreas Beeker
30d9106d9a - Bug 51585 - WorkbookFactory.create() hangs when creating a workbook
- adapted relevant test-classes to Junit4 to support timeout handling
- tab / space cleanup

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1561435 13f79535-47bb-0310-9956-ffa450edef68
2014-01-26 02:18:53 +00:00
Andreas Beeker
474c4eec6a jdk 5 compiler doesn't support overwrite for interfaces ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1561406 13f79535-47bb-0310-9956-ffa450edef68
2014-01-25 21:56:08 +00:00
Nick Burch
d2687261e3 Patch from Detlef Brendle from bug #55873 - Support for COUNTIFS function
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1560736 13f79535-47bb-0310-9956-ffa450edef68
2014-01-23 16:43:59 +00:00
Andreas Beeker
439ad29071 Added license headers
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1559297 13f79535-47bb-0310-9956-ffa450edef68
2014-01-18 00:38:04 +00:00
Andreas Beeker
c148f9c3e5 javadoc fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1557290 13f79535-47bb-0310-9956-ffa450edef68
2014-01-11 00:14:17 +00:00
Andreas Beeker
1eba8faedb Bug 35897 - Password protected files
+ Junit4 modifications, needed for expected exceptions

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1557281 13f79535-47bb-0310-9956-ffa450edef68
2014-01-10 23:14:03 +00:00
Nick Burch
0e5300538f Ensure our package html files have consistent line endings, and the right svn properties set on them
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1557156 13f79535-47bb-0310-9956-ffa450edef68
2014-01-10 15:39:39 +00:00
Dominik Stadler
d714d0da65 Bug 55723: Make HSSFSheet.setAutoFilter() behave equal to XSSF, also make XSSF work when setAutoFilter is called multiple times
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1554688 13f79535-47bb-0310-9956-ffa450edef68
2014-01-01 22:15:44 +00:00
Dominik Stadler
5e77641784 remove some unused imports and some useless TODOs, slightly more
coverage, @Overrides, more info on failing test, fix some Eclipse
warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1554535 13f79535-47bb-0310-9956-ffa450edef68
2013-12-31 15:12:30 +00:00
Dominik Stadler
dcc34ec845 Don't unnecessarily convert from ArrayList to array, use the ArrayList directly instead, this speeds up BiffViewer and related unit tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1554534 13f79535-47bb-0310-9956-ffa450edef68
2013-12-31 15:11:59 +00:00
Dominik Stadler
d83461c3fb Print out which actual value was out of range
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1554533 13f79535-47bb-0310-9956-ffa450edef68
2013-12-31 15:11:44 +00:00
Andreas Beeker
f32e87957c obsoleted by TestEscherBlipRecord and EscherMetafileBlip
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1554104 13f79535-47bb-0310-9956-ffa450edef68
2013-12-30 00:00:54 +00:00
Andreas Beeker
ae2b93eaa0 Bug 45776 - Fix corrupt file problem using TextRun.setText
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1554077 13f79535-47bb-0310-9956-ffa450edef68
2013-12-29 22:14:05 +00:00
Andreas Beeker
c95d740ee4 Bug 41246 - AIOOBE with missing notes entries
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553760 13f79535-47bb-0310-9956-ffa450edef68
2013-12-27 23:42:34 +00:00
Nick Burch
e961fe6e94 Fix whitespace - reformat to consistent spaces, instead of a mix of tabs and spaces
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553625 13f79535-47bb-0310-9956-ffa450edef68
2013-12-27 04:26:18 +00:00
Andreas Beeker
3ef65e166d Bug 48593 - [PATCH] Multiple Saves Causes Slide Corruption
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553610 13f79535-47bb-0310-9956-ffa450edef68
2013-12-27 00:22:19 +00:00
Dominik Stadler
1e4c1770d7 Bug 51158: clear out Memory-based part before writing to it,
except for PictureData items, which keep the original image
data in the Part-object directly.
Add reproducer-unit tests and enhance some related unit tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553525 13f79535-47bb-0310-9956-ffa450edef68
2013-12-26 17:55:36 +00:00
Dominik Stadler
f8969e8d83 Remove unnecessary separate length, an array already has one
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553522 13f79535-47bb-0310-9956-ffa450edef68
2013-12-26 17:54:49 +00:00
Dominik Stadler
60ca1a5de4 Add some @Overrides suggested by Eclipse, generics and some warnings,
convert some tabs to spaces.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553466 13f79535-47bb-0310-9956-ffa450edef68
2013-12-26 09:38:48 +00:00
Dominik Stadler
3f39b60f53 Fix some Eclipse warnings in ReaderWriter
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553465 13f79535-47bb-0310-9956-ffa450edef68
2013-12-26 09:32:08 +00:00
Dominik Stadler
aaa4029cd5 Remove unused members and make others private
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553464 13f79535-47bb-0310-9956-ffa450edef68
2013-12-26 09:31:25 +00:00
Andreas Beeker
e34a1f9620 Bug 55579 - [PATCH] Patch for add/embed OLE objects into HSLF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553435 13f79535-47bb-0310-9956-ffa450edef68
2013-12-26 00:46:16 +00:00
Andreas Beeker
2788aca235 javadoc and compiler warning house-keeping
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553428 13f79535-47bb-0310-9956-ffa450edef68
2013-12-25 23:24:04 +00:00