moparisthebest/poi
1
0
Fork 0
Code Issues Pull Requests Releases 1 Wiki Activity
7,564 Commits 29 Branches 84 Tags 722 MiB
0ec8b3a88e
Commit Graph

6243 Commits

Author SHA1 Message Date
Javen O'Neal
67b7e97a9f rename borderIsNotSetOrBlank to borderIsNotSet. Changing a set border style from NONE to THIN fails the unit test. What is the correct behavior? 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748067 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 22:59:47 +00:00
Javen O'Neal
ad98f81e5f move check if border line style is blank before setting the border color to a helper function for readability 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748066 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 22:57:37 +00:00
Javen O'Neal
344b9d9884 remove public convenience methods that let the user avoid creating a CellAddress object. Having the user provide a CellAddress increases the chance the user-provided object will be reused if possible. This also moves the validation of the CellAddress object outside of this BorderPropertyTemplate class (easier to debug), improves readability, and runs slightly faster since the CellAddress is needed anyways as a key. 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748065 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 22:33:24 +00:00
Javen O'Neal
513dfc5ff1 javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748063 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 22:02:38 +00:00
Javen O'Neal
e6937956f2 use CellAddress in unit tests where possible to improve readability 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748062 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 22:01:30 +00:00
Javen O'Neal
3530aa3bf2 javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748061 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 22:00:45 +00:00
Javen O'Neal
f9c7ae0102 javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748055 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 21:35:56 +00:00
Andreas Beeker
a696823927 fixing javadocs errors (in JDK8) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748054 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 21:28:13 +00:00
Andreas Beeker
a1ff5002a5 fixing javadocs errors (in JDK8) 
removing Rainers author tags as those cause a lot of errors and should be omitted anyways (see https://poi.apache.org/guidelines.html)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748046 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 20:19:59 +00:00
Andreas Beeker
1ace43ba9f javadocs fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748042 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 19:54:35 +00:00
Andreas Beeker
0ef5f1d292 sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748028 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 16:57:15 +00:00
Andreas Beeker
feead38601 ignore invalid performance issues - e.g. see #57840 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747947 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 01:18:12 +00:00
Andreas Beeker
6a6aa540eb revert back to changes of bug 57840 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747945 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 00:54:01 +00:00
Andreas Beeker
f919e8bd8a Common-SS: changed UDFFinder from interface to abstract class 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747943 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 00:20:52 +00:00
Andreas Beeker
81d891921b findbugs fixes 
changed UDFFinder to abstract class and moved DEFAULT constant to factory method

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747942 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 00:12:22 +00:00
Dominik Stadler
b9ceae5ef3 Add some pre-checks to fail the test with better assertion if the locale is not set correctly. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747916 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 17:03:59 +00:00
Javen O'Neal
61f0e58abb make CellRangeAddresses easier to cross-reference the example with the written out workbook 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747888 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 12:18:04 +00:00
Javen O'Neal
16fb41d5f1 make these classes more discoverable/searchable using more specific names 
rename PropertyTemplate to BorderPropertyTemplate
  rename Extent to BorderExtent

git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747884 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 12:09:23 +00:00
Javen O'Neal
9e54ef68cb bug 57840: lazily compute hashCode; patch from Greg Woolsey 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747881 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 11:40:30 +00:00
Javen O'Neal
55546a5495 whitespace (tabs to spaces, 3-space to 4-space) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747879 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 11:35:18 +00:00
Javen O'Neal
be9b615048 bug 57840: add disabled unit test with large number of structured reference formulas 
patch and spreadsheet contributed by Mark Woolsey

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747878 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 11:28:55 +00:00
Javen O'Neal
cea8cc65a3 javadoc update and boolean addLeft|Right|Top|Bottom line wrap update 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747877 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 11:12:04 +00:00
Javen O'Neal
66498c10af fix spelling in javadoc 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747876 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 11:01:48 +00:00
Javen O'Neal
7c90716fdc fix javadocs: remove unnecessary @links, remove references to CellStyle 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747873 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 10:09:05 +00:00
Javen O'Neal
ad11547c8a move loop-invariants outside the loop for readability and execution speed 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747871 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 09:58:12 +00:00
Javen O'Neal
bd22a7be43 replace usage of all deprecated CellStyle.BORDER_* constants with BorderStyle.* 
update PropertyTemplate functions to require enum instead of short borderType

git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747868 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 09:15:57 +00:00
Dominik Stadler
9880040b1b Improve output on invalid HTTP Status Code and ignore another failure to contact the TSP server 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747863 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 08:45:41 +00:00
Javen O'Neal
7dc4706edf continue simplifying using helper functions 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747859 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 08:15:50 +00:00
Javen O'Neal
66875dbc1b continue simplifying using helper functions 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747858 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 08:08:04 +00:00
Javen O'Neal
8ad237f679 add helper functions for verifying template properties were set correctly 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747855 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 07:48:32 +00:00
Javen O'Neal
222e32d577 whitespace (unwrap lines) 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747854 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 07:40:46 +00:00
Javen O'Neal
50d0a1197f shorten PropertyTemplate.Extent to Extent 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747853 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 07:10:21 +00:00
Javen O'Neal
fc6b8cdd0e +props svn:eol-style=native 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747852 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 07:00:40 +00:00
Javen O'Neal
54213ab158 bug 58787: add PropertyTemplate, unit test, and example from Mark Murphy 
Attachment 33684 plus changes to TestPropertyTemplate#applyBorders: replaced assertEquals(CellStyle.BORDER_*, cs.getBorder*()) with assertEquals(BorderStyle.*, cs.getBorder*())

git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747851 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 06:47:25 +00:00
Javen O'Neal
249bdf8661 +props svn:eol-style native 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747846 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 04:27:21 +00:00
Javen O'Neal
8673812492 methods that return lists should return unmodifiable lists; use foreach sheet iterator when sheet index is not needed 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747843 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 03:05:31 +00:00
Javen O'Neal
ed3364b6d2 bug 57840: re-use XSSFEvaluationWorkbook when expanding a shared formula; patch from Greg Woolsey 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747840 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 02:28:21 +00:00
Javen O'Neal
69ded5b7b0 whitespace (tabs to spaces); +props svn:eol-style=native 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747839 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 02:12:43 +00:00
Javen O'Neal
e3beb3abdd bug 57840: cache XSSFEvaluationCell and XSSFEvaluationSheet instances (30% evaluation speedup due to caching and faster cell lookup); patch from Greg Woolsey 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747838 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 02:10:32 +00:00
Javen O'Neal
6d03eafcfe bug 57840: avoid auto-boxing ints for row/column TreeTable lookups (4% evaluation speedup at the cost of additional Integer objects); patch from Greg Woolsey 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747837 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 01:48:37 +00:00
Javen O'Neal
9ca89c2278 add warnings that AnalysisToolPak inconsistently handles case-sensitivity of function names 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747835 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 01:41:54 +00:00
Javen O'Neal
649f2df1e9 add crude unit tests for UDFFinder classes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747834 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 01:38:27 +00:00
Javen O'Neal
44c9a66906 remove deprecated o.a.p.xssf.model.IndexedUDFFinder, which was moved to o.a.p.ss.formula.udf 3 years ago and was @Internal before that 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747828 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 00:51:12 +00:00
Javen O'Neal
6ed13b4b5b add @Override annotations 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747825 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 00:42:57 +00:00
Javen O'Neal
3ff5a7669f fix typo 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747824 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 00:42:33 +00:00
Javen O'Neal
cd4058fd60 bug 57840: initialize the column header cache with 50% empty space 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747823 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 00:38:42 +00:00
Javen O'Neal
52e866f4bc whitespace (tabs to spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747822 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 00:34:22 +00:00
Javen O'Neal
9aaa2bd51e whitespace (tabs to spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747821 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 00:16:14 +00:00
Javen O'Neal
82134e3d8a whitespace (tabs to spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747820 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 00:15:00 +00:00
Javen O'Neal
1a906b4d68 bug 57840: add test using a Data Table not anchored at A1 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747819 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 00:11:41 +00:00
Andreas Beeker
12c7c32187 fix text height test 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747803 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 21:29:47 +00:00
Javen O'Neal
c8627bb8b2 bug 57840: add unit tests for XSSFTable methods; rename XSSFTable.getNumerOfMappedColumns() to getNumberOfMappedColumn() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747771 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 18:45:14 +00:00
Javen O'Neal
71e3aa52fd bug 57840: add unit test for XSSFTable.findColumnIndex 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747762 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 18:10:52 +00:00
Javen O'Neal
a6f21296cc bug 57840: fix to reuse XSSFEvaluationWorkbook inside itself; patch from Greg Woolsey 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747754 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 17:13:45 +00:00
Javen O'Neal
97adda6169 +props svn:eol-style native 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747752 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 17:12:28 +00:00
Javen O'Neal
ce5eccd8f5 bug 57721: add unit test for evaluating all formulas in a workbook containing structured reference formulas; patch from gruber.chri@gmx.at 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747740 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 16:36:59 +00:00
Javen O'Neal
db6ceaa7fa bug 59684: correctly parse CellReference(HOMEst163); Also deprecate misspelled methods isRowWithinRange/isColumnWithinRange 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747687 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 11:52:44 +00:00
Javen O'Neal
79ebd4915d findbugs: SBSC_USE_STRINGBUFFER_CONCATENATION FormulaParser.parseAsColumnQuantifier() concatenates strings using + in a loop 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747685 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 11:16:16 +00:00
Nick Burch
1197db5415 Javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747674 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 09:42:09 +00:00
Nick Burch
937519fad5 Javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747673 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 09:40:26 +00:00
Javen O'Neal
bec8fbe92c fix javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747671 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 09:16:41 +00:00
Javen O'Neal
30dc1a4d30 add missing AL header 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747669 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 09:10:41 +00:00
Javen O'Neal
a5f82ba8b0 fix spelling error 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747659 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 07:45:31 +00:00
Javen O'Neal
1da2c2d2d1 close opened workbooks in unit tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747656 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 07:36:22 +00:00
Javen O'Neal
954d5f8be4 bug 57840: add structured reference formula parsing tests from FormulaParser.parseStructuredReference 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747655 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 07:33:30 +00:00
Javen O'Neal
95df2cc417 whitespace (tabs to spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747638 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 05:38:10 +00:00
Javen O'Neal
f17c9a9c25 ooxml o.a.p.ss.formula.TestFormulaParser junit3 -> junit4 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747633 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 04:57:04 +00:00
Javen O'Neal
3de47c1c6f whitespace (tabs to spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747632 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 04:45:58 +00:00
Javen O'Neal
65c7d551e6 whitespace (tabs to spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747628 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 04:40:56 +00:00
Javen O'Neal
068bb510be bug 57840: add javadocs (warn about stale XSSFTable cache), remove rowIndex argument from calls to FormulaParser.parse(String, FormulaParsingWorkbook, FormulaType, int sheetIndex) when rowIndex is irrelevant, clear xmlColumnPr and commonXPath during updateHeaders so that users have a mechanism to clear invalidated cached values 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747627 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 04:20:41 +00:00
Javen O'Neal
1c2b9b3103 whitespace (tabs to spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747625 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 02:51:45 +00:00
Javen O'Neal
12a8f5b603 whitespace (tabs to spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747623 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 02:01:15 +00:00
Javen O'Neal
b983f435d1 whitespace (tabs to spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747622 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 01:57:13 +00:00
Javen O'Neal
3732a24a42 bug 57840: check for null to avoid NPE; add unit test for XSSFWorkbook.getTable() 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747621 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 01:52:08 +00:00
Javen O'Neal
1817337056 bug 57840: move XSSFTable cache from XSSFWorkbook to XSSFEvaluationWorkbook where staleness is less likely to cause problems for users 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747616 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 01:08:05 +00:00
Javen O'Neal
5b983791aa bug 57840: move XSSFTable cache from XSSFWorkbook to XSSFEvaluationWorkbook where staleness is less likely to cause problems for users 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747615 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 01:02:05 +00:00
Javen O'Neal
588c19e9d3 whitespace (tabs to spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747614 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 00:26:39 +00:00
Javen O'Neal
83abda843a bug 57840: apply patch from Daniel Livshen and Greg Woolsey to get structured references working in XSSFWorkbook formulas 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747612 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 00:21:59 +00:00
Javen O'Neal
944901f8f2 bug 57840: apply patch from Daniel Livshen and Greg Woolsey to get structured references working in XSSFWorkbook formulas 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747611 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 00:21:21 +00:00
Andreas Beeker
6e477490f9 #59686 - Error when trying to access XSLFTableCell properties like textHeight, lineWidth, etc. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747605 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-09 23:06:42 +00:00
Javen O'Neal
fe44b01cd3 bug 57840: add Table interface for Structured References. Patch from Daniel Livshen and Greg Woolsey. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747602 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-09 22:47:35 +00:00
Andreas Beeker
8dbe0b3cd8 javadocs / java warnings (jdk8) fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747327 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-07 23:38:05 +00:00
Andreas Beeker
f29eb91c08 Add XSSF support to ForkedEvaluator 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747326 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-07 23:15:40 +00:00
Andreas Beeker
3387617db8 #59170 - Remove deprecated classes (POI 3.15) - remove BuiltinFormats.getBuiltinFormats() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747325 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-07 23:13:57 +00:00
Javen O'Neal
9c19717151 add comments and make the statefulness of localeIsAdapting more obvious. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747171 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-07 08:54:08 +00:00
Javen O'Neal
914fb92f3c make emulateCSV final, add a single common all-inclusive (private) constructor that all other constructors tree up to and invert the constructors 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747163 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-07 07:39:40 +00:00
Javen O'Neal
b84f05a44c replace Obervable with Observable; emulateCsv with emulateCSV 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747152 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-07 06:37:24 +00:00
Javen O'Neal
74be4d4174 bug 59638: patch from Axel Howind, support non-comma number grouping separators (such as German 1.234,57) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747139 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-07 06:18:44 +00:00
Andreas Beeker
a749f7f3f5 sonar fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747093 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-06 23:54:29 +00:00
Andreas Beeker
60d35b92c6 close resources 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747092 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-06 23:34:17 +00:00
Andreas Beeker
b8e38304f2 javadocs / java warnings (jdk8) fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747090 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-06 23:33:00 +00:00
Dominik Stadler
ee222dc91d Fix test-failure in Maven builds that I introduced by manually deleting the temporary directory in the test. The Maven build runs these in one process and thus the directory was not re-created any more. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746933 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-05 16:55:48 +00:00
Andreas Beeker
c423015a1b try to find out temp file errors on maven build 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746932 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-05 16:49:18 +00:00
Andreas Beeker
9b05849946 PPTX2PNG - don't complain about missing output dir, when in testing mode 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746893 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-05 10:18:14 +00:00
Andreas Beeker
bd2b438ee1 Regression fix for XSLF 
- master style was always overridden, because of r1745100
- AIOOB in TextDirection mapping

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746858 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-05 01:04:58 +00:00
Andreas Beeker
d80170f9ac #57766 - XSLFTable isn't exported on convert slides of a .pptx slide show to a PNG/SVG image 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746856 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-04 22:53:00 +00:00
Dominik Stadler
1caa8ff288 Try to not fail if the time-webservice is offline temporarily 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746671 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-03 06:01:27 +00:00
Nick Burch
52537ae58e Add disabled test for XWPF writing to a new stream when opened read-only 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746653 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-02 22:59:47 +00:00
Dominik Stadler
1fdbf14e1e Fix some Sonar issues and some IntelliJ warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746627 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-02 20:14:28 +00:00
Dominik Stadler
6b6aa56455 Avoid NPE in XWPFTableCell, taken from https://github.com/prasad-babu/poi/tree/WORKING_BRANCH 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746625 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-02 20:09:44 +00:00
Dominik Stadler
ee6c0625d0 Try to reproduce bug 57798 but it seems to be fixed in the meantime 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746624 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-02 20:09:35 +00:00
Dominik Stadler
aee2959a64 Bug 59378: Try to reproduce, but could not 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746623 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-02 20:09:25 +00:00
Dominik Stadler
aad52afa12 The changes for using AccessController/SecurityManager also added a log which now spams a lot if log is enabled in integration-tests, reduce it a bit by not trying to call "cleaner()" on HeapByteBuffer which does not have it for sure 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746411 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-01 08:05:07 +00:00
Nick Burch
e9a1e2987f Javadoc fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746286 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-31 15:08:14 +00:00
Dominik Stadler
7cb15d81db Change logger.log to System.out to print out one line for each file that is handled in the test, otherwise it is sometimes impossible to see where the test stopped (e.g. on timeout), enabling POILogger leads to 400MB logs, which is usually too much to handle... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746275 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-31 13:52:16 +00:00
Dominik Stadler
68102762fd Fix some compiler/IntelliJ warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746274 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-31 13:48:25 +00:00
Dominik Stadler
505e695099 Bug 57838: Also remove comments when removing a row 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746062 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-29 21:33:47 +00:00
Dominik Stadler
a2bd714e55 Update error message to better indicate that we need a sample-file here 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746061 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-29 21:33:39 +00:00
Dominik Stadler
d53ad74c37 Remove the created temporary directory after the test again 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746060 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-29 21:33:33 +00:00
Dominik Stadler
a9f9290bb7 Try to access set/getVisible as well in TestXSSFVMLDrawing 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746058 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-29 21:33:24 +00:00
Andreas Beeker
334ec509fa fix handling of hsl and linear rgb (%-values) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1745412 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-24 23:39:23 +00:00
Dominik Stadler
10ce4e23a6 Adjust two tests slightly 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1745370 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-24 14:48:57 +00:00
Dominik Stadler
a7df6604a4 Upgrade to FindBugs 3.0.1 and add some findbugs-excludes 
Update to forbiddenapi-checker 2.1, use the newly provided rule-sets and remove things that were applied upstream 


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1745366 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-24 14:17:52 +00:00
Nick Burch
6c976b6700 Fix inconsistent spacing / whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1745361 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-24 13:39:46 +00:00
Nick Burch
dccad7fb92 Another exclude 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1745358 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-24 13:32:33 +00:00
Nick Burch
2ff845b852 Whitespace fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1745357 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-24 13:30:58 +00:00
Nick Burch
d71d796f62 Copy out code from the site and fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1745348 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-24 12:16:13 +00:00
Andreas Beeker
592f22882f #58217 - XSLF: support alpha channel on solid colors (fill, line, text) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1745101 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-22 23:58:07 +00:00
Andreas Beeker
dae1a761fd XSLF: remove creation of empty paragraph in XSLFTextShape.addNewTextParagraph() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1745100 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-22 23:57:14 +00:00
Dominik Stadler
e48e4e771d Bug 58190: Add more overloaded methods for adding pictures from streams and files 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1745073 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-22 16:08:51 +00:00
Andreas Beeker
3d60c67151 fix junit4 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744821 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-21 04:06:49 +00:00
Andreas Beeker
e58f6f3fb0 findbugs fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744802 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-20 22:05:00 +00:00
Andreas Beeker
e5393711b7 fix javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744797 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-20 21:02:49 +00:00
Dominik Stadler
ae32e5f677 Fix some compiler warnings, close resources in tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744636 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-19 20:18:19 +00:00
Dominik Stadler
2e4095deeb Apply patch for bug 59355: XSSFPivotTable::addColumnLabel sets the cell type of a cell outside of the source data area 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744635 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-19 20:18:08 +00:00
Andreas Beeker
eb111ce81f findbugs fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744332 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-17 23:34:52 +00:00
Dominik Stadler
0c78005743 Bug 59427: Add a check to better report cases when a document is already closed. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744306 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-17 19:08:34 +00:00
Dominik Stadler
df72dbfbed Revert expected failure as it seems to be fixed now 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744305 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-17 19:08:27 +00:00
Dominik Stadler
6a223ec11e BiffViewer: Close resources always 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744212 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-17 08:44:21 +00:00
Dominik Stadler
ff055532c1 Exclude newly added corrupt file 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744211 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-17 08:44:16 +00:00
Andreas Beeker
e28fff0423 ignore external relations 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744196 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-17 07:23:34 +00:00
Andreas Beeker
7b282db0e2 Move reflection-equals to POITestCase 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744169 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-16 23:28:25 +00:00
Andreas Beeker
61321b4b37 #54570 - InvalidFormatException because of Absolute URI forbidden 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744137 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-16 21:04:00 +00:00
Andreas Beeker
33241e821f add asl 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744021 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-16 10:54:02 +00:00
Andreas Beeker
73108582a0 deprecation fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744008 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-16 10:09:52 +00:00
Andreas Beeker
1f862981e2 Close resources in Common SL rendering classes and minimize memory consumption by using the image anchor dimensions instead of the WMF-included dimensions 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744007 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-16 10:09:22 +00:00
Andreas Beeker
306edb91e5 sonar fix - reduce complexity by using constants 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744006 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-16 10:04:46 +00:00
Andreas Beeker
fa00834766 Reduce calls to utf-related methods - the integration test took ages because of poc-shared-strings.xlsx 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744005 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-16 10:02:13 +00:00
Andreas Beeker
20fe8a5e0f Reduce calls to utf-related methods - the integration test took ages because of poc-shared-strings.xlsx 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744004 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-16 10:01:36 +00:00
Andreas Beeker
2e5f0132c5 Sonar fixes - array is stored directly 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744003 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-16 09:57:19 +00:00
Andreas Beeker
84be4acea9 Dispose XmlCursor 
Replacing a method argument (XmlCursor) with a local instance and then updating it, doesn't make sense

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744002 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-16 09:54:01 +00:00
Andreas Beeker
12425ac107 added commons-logging to integration test to make profiling easier - just match the timestamps of the log with the timestamps of the profiling monitor 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744001 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-16 09:49:17 +00:00
Andreas Beeker
dde2a25283 #59170 - Remove deprecated classes (POI 3.15) - use FormulaError instead of ErrorConstants 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744000 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-16 09:38:42 +00:00
Andreas Beeker
401a9fb477 #58144 - Behaviour for headers and footers of slides is inconsistent between slideshows created in 2003 and 2007 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1743769 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-13 23:50:39 +00:00
Javen O'Neal
4a3acf4de0 add @since to javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742882 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-09 05:47:49 +00:00
Javen O'Neal
730641576a bug 59443: exit early on setAddress if address is the same 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742881 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-09 05:46:14 +00:00
Javen O'Neal
191726ee7b bug 59443: use Comment.setAddress when changing both row and column of cell comment address 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742880 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-09 05:25:29 +00:00
Javen O'Neal
70459401a3 bug 59443: add get/setAddress methods on cell comment class 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742879 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-09 05:09:41 +00:00
Javen O'Neal
fe04abd31d fix BasteTestCellComment#attemptToSave2CommentsWithSameCoordinates to work with different behaviors of HSSFWorkbook and XSSFWorkbook 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742871 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-09 04:29:17 +00:00
Javen O'Neal
e9bfa9da87 whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742869 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-09 03:53:55 +00:00