Tim Allison
0fd3027a67
bug 62624 -- fix npe by adding processing of module name mapping in VBAMacroReader
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1845138 13f79535-47bb-0310-9956-ffa450edef68
2018-10-29 15:48:44 +00:00
Tim Allison
ad52c65f70
bug 62859 -- fix two potential NPEs when initializing XWPFSDTContent
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1844920 13f79535-47bb-0310-9956-ffa450edef68
2018-10-26 19:06:18 +00:00
Greg Woolsey
d24b4492f0
#62834 FormulaEvaluator.evaluateInCell() throws Exception
...
added cell type = formula check when looping through the shared formula range, to ignore any non-formula cells.
Also refactored a bit to enable passing in the evaluation context, as getCellFormula() uses it behind the scenes when evaluating a shared formula cell (has to shift the formula references based on the master cell). Review of these changes is welcome, as always.
Checked all other code referencing the "SHARED" enum, and didn't see anything else that dealt with formula cell values and thus would need to notice non-formula cells.
Added unit test based on the failing file from Bugzilla. Test failed until the fixed code was in place.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1844295 13f79535-47bb-0310-9956-ffa450edef68
2018-10-19 01:11:47 +00:00
Tim Allison
fcbed10cfc
62815 -- some numeric values not correctly extracted from xlsb
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1843553 13f79535-47bb-0310-9956-ffa450edef68
2018-10-11 14:14:07 +00:00
Alain Béarez
72d02f0c1c
extract valuable code from 54470 submitted patch
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842548 13f79535-47bb-0310-9956-ffa450edef68
2018-10-01 19:27:32 +00:00
PJ Fanning
19baa76652
[bug-62736] Relations on XSLFPictureShape are removed unconditionally. Thanks to Mate Borcsok
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842055 13f79535-47bb-0310-9956-ffa450edef68
2018-09-26 21:42:21 +00:00
Tim Allison
5e241fdd3c
bug 62591 -- revert to ignoring place holders even if they contain metroblobs in ppt
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1837742 13f79535-47bb-0310-9956-ffa450edef68
2018-08-09 15:50:34 +00:00
Tim Allison
070e815109
bug 62592 -- prevent StackOverflowError on corrupt thmx
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1837658 13f79535-47bb-0310-9956-ffa450edef68
2018-08-08 16:06:18 +00:00
PJ Fanning
51b4e33a62
add 1 of the pptx files failing in centic regression tests
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1837010 13f79535-47bb-0310-9956-ffa450edef68
2018-07-29 23:19:07 +00:00
PJ Fanning
3be215e070
Handle NPE issues in POIXMLProperties
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1837007 13f79535-47bb-0310-9956-ffa450edef68
2018-07-29 23:05:01 +00:00
Dominik Stadler
8e9ccfaacd
Regression tests: Add test which triggers reading header/footer of PPTX files so that we include the related CT classes
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1835184 13f79535-47bb-0310-9956-ffa450edef68
2018-07-05 19:54:24 +00:00
Andreas Beeker
9b50601458
#62513 - Don't try to parse embedded package relationships
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1834729 13f79535-47bb-0310-9956-ffa450edef68
2018-06-30 11:20:23 +00:00
Andreas Beeker
5169036f66
#62452 - Extract configuration while verifying XML signatures
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1833477 13f79535-47bb-0310-9956-ffa450edef68
2018-06-13 20:06:08 +00:00
Andreas Beeker
f35e818fa2
#62037 - SlideNames should not be null but have a default as if accessed by VBA
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1831745 13f79535-47bb-0310-9956-ffa450edef68
2018-05-16 21:57:49 +00:00
Andreas Beeker
5189313eb4
#61459 - HSLFShape.getShapeName() returns name of shapeType and not the shape name
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1829656 13f79535-47bb-0310-9956-ffa450edef68
2018-04-20 13:45:18 +00:00
Andreas Beeker
ab390ce170
#62319 - Decommission XSLF-/PowerPointExtractor
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1829653 13f79535-47bb-0310-9956-ffa450edef68
2018-04-20 12:52:59 +00:00
Andreas Beeker
4ba2d64a50
Bug 62092 - Text not extracted from grouped text shapes in HSLF
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1829453 13f79535-47bb-0310-9956-ffa450edef68
2018-04-18 15:02:02 +00:00
Dominik Stadler
eb4e20cd69
Try to avoid one NPE that popped up in commoncrawl-corpus tests
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1828375 13f79535-47bb-0310-9956-ffa450edef68
2018-04-04 19:40:54 +00:00
Dominik Stadler
2be766f267
Bug 61267: detect Word v2 files and report that they are not supported in Apache POI
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1828176 13f79535-47bb-0310-9956-ffa450edef68
2018-04-02 17:15:42 +00:00
PJ Fanning
4221ccebda
[bug-62055] Fix XSSFImportFromXML table resize. Thanks to Leonard Kappe. This closes #99
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1825315 13f79535-47bb-0310-9956-ffa450edef68
2018-02-25 17:06:19 +00:00
PJ Fanning
51f99aa616
[github-94] Add Range Copier. Thanks to Dragan Jovanović. This closes #94
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1824266 13f79535-47bb-0310-9956-ffa450edef68
2018-02-14 20:30:01 +00:00
Tim Allison
db3e8697f7
related to Bug 61991 -- include docx in test suite to trigger inclusion of CTPictureBase
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1822033 13f79535-47bb-0310-9956-ffa450edef68
2018-01-23 18:05:23 +00:00
Dominik Stadler
bc4eb140c5
Add test which verifies that bug 61652 is not appearing any more on latest trunk
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819769 13f79535-47bb-0310-9956-ffa450edef68
2018-01-01 14:39:08 +00:00
Yegor Kozlov
ca7549131b
Bug 58106: when a cell with a 'master' shared formula is removed, the next cell in the range becomes the master
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819623 13f79535-47bb-0310-9956-ffa450edef68
2017-12-30 16:34:57 +00:00
Yegor Kozlov
ff6f06cc27
Bugzilla 61116: Formula evaluation fails when using matrix addition within index function call
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819596 13f79535-47bb-0310-9956-ffa450edef68
2017-12-30 13:11:56 +00:00
Dominik Stadler
9eb8fedf5d
Fix bug 61787, which was introduced by bug 58067: Change how deleted content is detected to not incorrectly see too much text as deleted.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819405 13f79535-47bb-0310-9956-ffa450edef68
2017-12-28 08:45:51 +00:00
Dominik Stadler
eb8fac4f77
Bug 61911: Avoid IndexOutOfBounds access when reading pictures
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819403 13f79535-47bb-0310-9956-ffa450edef68
2017-12-28 08:45:36 +00:00
Greg Woolsey
a7a3293fb9
Implement DMAX and DSUM functions, following the pattern from DMIN.
...
Refactored the D* function enum to have instances return the function implementation instances rather than using a case construct, now that Java 8 is required.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819376 13f79535-47bb-0310-9956-ffa450edef68
2017-12-27 22:33:03 +00:00
Yegor Kozlov
64d98e7872
Bug 61869: updating a cell with shared formula produces an unreadable file
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818818 13f79535-47bb-0310-9956-ffa450edef68
2017-12-20 16:30:13 +00:00
Yegor Kozlov
1ccc7bfd46
Bug 61859: support for evaluating comparison operators in array mode, detect array mode from formula ptgs
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818587 13f79535-47bb-0310-9956-ffa450edef68
2017-12-18 15:54:50 +00:00
Greg Woolsey
08e25fe46e
Bug 61882 - Some paths can create an XSSFColor instance with a null CTColor reference
...
test file
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817797 13f79535-47bb-0310-9956-ffa450edef68
2017-12-11 17:33:00 +00:00
Andreas Beeker
2c2028ede6
#61881 - handle invalid font names
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817599 13f79535-47bb-0310-9956-ffa450edef68
2017-12-09 11:44:19 +00:00
Greg Woolsey
6390202491
Bug #61841 - Unnecessary long computation when evaluating VLOOKUP on all column reference
...
Found some optimizations in the general evaluation framework related to blank cells in rows beyond the last defined row of a sheet.
I don't see any issue with passing a bit of context down deeper into this framework, as it's all POI-internal and only had one calling path.
See the above bug for the performance analysis. Not specifically related to VLOOKUP, but improves that case by more than 2/3 as well.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817252 13f79535-47bb-0310-9956-ffa450edef68
2017-12-06 00:15:51 +00:00
Alain Béarez
c795f2e793
XDDF usermodel for Charts closes #68 on GitHub
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816383 13f79535-47bb-0310-9956-ffa450edef68
2017-11-26 14:03:01 +00:00
Greg Woolsey
ff034f6a20
Fixes Bug 61764 Conditional formatting rules don't evaluate properly for some multi-range rule definitions
...
Fixes Bug 61761 Conditional formatting rule evaluation doesn't like comparing cells of different types
fixed, with unit tests.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815298 13f79535-47bb-0310-9956-ffa450edef68
2017-11-15 08:35:17 +00:00
Javen O'Neal
a1b8f3ff14
bug 61745: add support for charts in XWPF/docx. Thanks to Sandeep Tiwari for the patch
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815047 13f79535-47bb-0310-9956-ffa450edef68
2017-11-12 21:48:41 +00:00
Dominik Stadler
4d13aefd6e
Add test-case which shows that bug 55814 is fixed already by other changes
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814290 13f79535-47bb-0310-9956-ffa450edef68
2017-11-04 13:45:12 +00:00
PJ Fanning
5402bcdd49
add test case for bug 61701
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813864 13f79535-47bb-0310-9956-ffa450edef68
2017-10-31 09:51:51 +00:00
Dominik Stadler
e24f25d0ef
Add test which shows that bug 51262 is fixed now
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811595 13f79535-47bb-0310-9956-ffa450edef68
2017-10-09 19:35:32 +00:00
Dominik Stadler
c2d09c0217
Bug 61586: Add test which shows that it works as expected
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811355 13f79535-47bb-0310-9956-ffa450edef68
2017-10-06 17:41:20 +00:00
Andreas Beeker
a51bac65b7
#60499 - Deleting a picture that is used twice on a slide corrupt the slide
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808661 13f79535-47bb-0310-9956-ffa450edef68
2017-09-17 22:45:03 +00:00
Dominik Stadler
445852e773
Tried to reproduce bug 61300, but could not.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808502 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:20:25 +00:00
Tim Allison
4852228f3f
60279 -- back off to brute-force search for macro content if offset information is not correct
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808301 13f79535-47bb-0310-9956-ffa450edef68
2017-09-14 02:22:55 +00:00
PJ Fanning
5ef2f1636c
Numeric Array Formula and Matrix Function [from Bob95132] This closes #69
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808297 13f79535-47bb-0310-9956-ffa450edef68
2017-09-13 23:54:36 +00:00
PJ Fanning
e726dd68de
[bug-61515] fix xlsf issue with relationships [from Alain Bearez] This closes #70
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808294 13f79535-47bb-0310-9956-ffa450edef68
2017-09-13 23:10:44 +00:00
Tim Allison
3b32a00aa7
61470 -- add extraction of content within ruby elements; allow users to concatenate or not concatenate phonetic strings. Default is to concatenate.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1806712 13f79535-47bb-0310-9956-ffa450edef68
2017-08-30 16:29:52 +00:00
Greg Woolsey
914ae602b1
Fixes bug #61468 , caused by a confusing OOXML spec design as noted in JavaDocs added in r1795648.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1806623 13f79535-47bb-0310-9956-ffa450edef68
2017-08-29 17:14:52 +00:00
Dominik Stadler
2108f82449
Fix 60384 and 60709: When shifting with merged regions we should correctly check if the region is moved along or needs to be removed because it is not fully kept via the shifting. This was broken by the fix for bug 59740, now additional unit tests ensure that it works better.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1805518 13f79535-47bb-0310-9956-ffa450edef68
2017-08-19 16:31:45 +00:00
Greg Woolsey
5e5adc70e5
Bug 61431 - Conditional formatting evaluation ignores undefined cells
...
now evaluating based on cell references instead, and watching out for undefined cells in rules that require a cell.
Added unit test based on previously failing file.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1805245 13f79535-47bb-0310-9956-ffa450edef68
2017-08-16 23:52:27 +00:00
PJ Fanning
9f28e36438
[Bug-61354] fix issue with extracting text from Word docs. This closes #66
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803250 13f79535-47bb-0310-9956-ffa450edef68
2017-07-28 07:42:23 +00:00