Nick Burch
7984a1ec3f
More helpful visio v5 exception, see bug #56171
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1570388 13f79535-47bb-0310-9956-ffa450edef68
2014-02-20 23:20:19 +00:00
Andreas Beeker
49c69f0eed
The junit test failed with the original test-file (CDT_Data_Retention-PPT.ppt), so another check was necessary
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1569999 13f79535-47bb-0310-9956-ffa450edef68
2014-02-20 00:03:42 +00:00
Andreas Beeker
8afdb7a9ce
Bug 55732 - PPT can't open, fails with "Couldn't instantiate .... StyleTextProp9Atom : java.lang.ArrayIndexOutOfBoundsException: 56"
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1569984 13f79535-47bb-0310-9956-ffa450edef68
2014-02-19 23:45:07 +00:00
Andreas Beeker
edf1ffd89b
upgraded to junit4 (before other changes)
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1569972 13f79535-47bb-0310-9956-ffa450edef68
2014-02-19 23:30:12 +00:00
Andreas Beeker
2cfc8dbf17
FindBugs fix
...
- fixed "Equals method should not assume anything about the type of its argument"
- see http://findbugs.sourceforge.net/bugDescriptions.html#BC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568861 13f79535-47bb-0310-9956-ffa450edef68
2014-02-16 23:36:32 +00:00
Andreas Beeker
53c90692ee
FindBugs fix
...
- fixed "equals() method does not check for null argument"
- see http://findbugs.sourceforge.net/bugDescriptions.html#NP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENT
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568812 13f79535-47bb-0310-9956-ffa450edef68
2014-02-16 19:35:16 +00:00
Andreas Beeker
2a14920cdd
FindBugs fix
...
- fixed/checked various null pointer related entries
- see http://findbugs.sourceforge.net/bugDescriptions.html#NP_NULL_PARAM_DEREF
- ... NP_NULL_ON_SOME_PATH, NP_NULL_ON_SOME_PATH_EXCEPTION
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568789 13f79535-47bb-0310-9956-ffa450edef68
2014-02-16 16:30:24 +00:00
Dominik Stadler
dcad3624dc
Fix unit tests broken by newly added test-file, ignore TestFontRendering as it is inherently unstable currently
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568744 13f79535-47bb-0310-9956-ffa450edef68
2014-02-16 09:11:28 +00:00
Dominik Stadler
2414998aac
Adjust test to write the failing PNG in case expected and actual do not match
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568740 13f79535-47bb-0310-9956-ffa450edef68
2014-02-16 08:39:17 +00:00
Dominik Stadler
b51a52cf20
Provide more output on test that failed for me locally
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568558 13f79535-47bb-0310-9956-ffa450edef68
2014-02-15 00:21:19 +00:00
Andreas Beeker
92a488a28b
FindBugs fix
...
- fixed "Should be a static inner class"
- see http://findbugs.sourceforge.net/bugDescriptions.html#SIC_INNER_SHOULD_BE_STATIC
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568178 13f79535-47bb-0310-9956-ffa450edef68
2014-02-14 01:00:45 +00:00
Andreas Beeker
3ceb93b23d
FindBugs fix
...
- fixed "Field isn't final but should be"
- see http://findbugs.sourceforge.net/bugDescriptions.html#MS_SHOULD_BE_FINAL
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568145 13f79535-47bb-0310-9956-ffa450edef68
2014-02-13 23:34:11 +00:00
Andreas Beeker
8c3785890a
Bug 55902 - Mixed fonts issue with Chinese characters (unable to form images from ppt)
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1567455 13f79535-47bb-0310-9956-ffa450edef68
2014-02-11 23:16:54 +00:00
Andreas Beeker
413e76aed0
FindBugs fix
...
- fixed "Class defines equals() and uses Object.hashCode()"
- see http://findbugs.sourceforge.net/bugDescriptions.html#HE_EQUALS_USE_HASHCODE
- implemented UnicodeString.ExtRst.hashCode() + junit-test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1566427 13f79535-47bb-0310-9956-ffa450edef68
2014-02-09 21:19:20 +00:00
Nick Burch
fdcd28194e
Fix up whitespace / indents to be consistent
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563491 13f79535-47bb-0310-9956-ffa450edef68
2014-02-01 22:05:23 +00:00
Nick Burch
c5823a746f
Fix javadoc formatting
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563489 13f79535-47bb-0310-9956-ffa450edef68
2014-02-01 21:58:24 +00:00
Nick Burch
2b0c8deb2f
Expose the StyleIndex of CharacterRuns, and expand the range style tests to cover this + related
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563486 13f79535-47bb-0310-9956-ffa450edef68
2014-02-01 21:52:19 +00:00
Andreas Beeker
439ad29071
Added license headers
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1559297 13f79535-47bb-0310-9956-ffa450edef68
2014-01-18 00:38:04 +00:00
Andreas Beeker
c148f9c3e5
javadoc fix
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1557290 13f79535-47bb-0310-9956-ffa450edef68
2014-01-11 00:14:17 +00:00
Dominik Stadler
5e77641784
remove some unused imports and some useless TODOs, slightly more
...
coverage, @Overrides, more info on failing test, fix some Eclipse
warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1554535 13f79535-47bb-0310-9956-ffa450edef68
2013-12-31 15:12:30 +00:00
Andreas Beeker
ae2b93eaa0
Bug 45776 - Fix corrupt file problem using TextRun.setText
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1554077 13f79535-47bb-0310-9956-ffa450edef68
2013-12-29 22:14:05 +00:00
Andreas Beeker
c95d740ee4
Bug 41246 - AIOOBE with missing notes entries
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553760 13f79535-47bb-0310-9956-ffa450edef68
2013-12-27 23:42:34 +00:00
Andreas Beeker
3ef65e166d
Bug 48593 - [PATCH] Multiple Saves Causes Slide Corruption
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553610 13f79535-47bb-0310-9956-ffa450edef68
2013-12-27 00:22:19 +00:00
Andreas Beeker
e34a1f9620
Bug 55579 - [PATCH] Patch for add/embed OLE objects into HSLF
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553435 13f79535-47bb-0310-9956-ffa450edef68
2013-12-26 00:46:16 +00:00
Andreas Beeker
2788aca235
javadoc and compiler warning house-keeping
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553428 13f79535-47bb-0310-9956-ffa450edef68
2013-12-25 23:24:04 +00:00
Dominik Stadler
bc7b658ea9
Fix some JavaDoc items that are reported in the build-output
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553404 13f79535-47bb-0310-9956-ffa450edef68
2013-12-25 18:05:41 +00:00
Yegor Kozlov
fdda5f2071
removed pictureFileZero.ppt from svn as requested by the owner, see discussion on @poi-dev from Dec 12, 2013
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1551845 13f79535-47bb-0310-9956-ffa450edef68
2013-12-18 05:26:49 +00:00
Yegor Kozlov
362fec4a01
Bugzilla 55560 : Patch for hiding slides in HSLF
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1540295 13f79535-47bb-0310-9956-ffa450edef68
2013-11-09 11:57:21 +00:00
Dominik Stadler
7014abae83
Bug 52400: fix handling some types of TNEF files, make HMEFMessage.HEADER_SIGNATURE int as it is handled as int everywhere, move .dat files to HMEF sample dir, cover some border cases in HMEFMessage, add another .dat sample file
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1538353 13f79535-47bb-0310-9956-ffa450edef68
2013-11-03 12:43:42 +00:00
Dominik Stadler
19630f1a29
Add more output to assertion in test-case that is sometimes failing, see e.g. Jenkins build #170...
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1538330 13f79535-47bb-0310-9956-ffa450edef68
2013-11-03 10:11:09 +00:00
Nick Burch
a6b301e485
Fix bug #55733 - XWPFWordExtractor need
...
s to handle .docx files with neither headers nor footers
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1538044 13f79535-47bb-0310-9956-ffa450edef68
2013-11-01 19:43:46 +00:00
Tim Allison
3e1208af44
Potential NPE in PPExtractor; found while working on TIKA-1171
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1527041 13f79535-47bb-0310-9956-ffa450edef68
2013-09-27 19:35:14 +00:00
Tim Allison
58dd7d7c0c
POI-54722 table text in ppt files
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1526960 13f79535-47bb-0310-9956-ffa450edef68
2013-09-27 15:45:55 +00:00
Dominik Stadler
ffc31302a4
Adjust build.xml to run JaCoCo coverage when running unit tests when
...
flag coverage.enabled is set to true, download necessary jars, add jacoco:coverage
to junit targets and a testcoveragereport target which produces the coverage report.
Also fix a test that is affected by JaCoCo and add slightly more coverage in another test.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1510243 13f79535-47bb-0310-9956-ffa450edef68
2013-08-04 16:38:01 +00:00
Nick Burch
dd1116a1e3
Have MAPIMessage try the codepage properties to get the ascii encoding, before falling back to the existing logic around content type parsing
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1497038 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 18:46:37 +00:00
Nick Burch
43b811f049
More unit tests for the HSMF fixed sized property values (a few still remain to be fixed though)
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1497023 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 17:45:57 +00:00
Nick Burch
b37e3c6df2
Make the fixed sized properties parser more flexible in the face of slightly duff data
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1497006 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 17:03:26 +00:00
Nick Burch
a9e1c0e320
Dig out the normal type for some more common properties
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1497004 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 16:58:11 +00:00
Nick Burch
b8644921c9
Support decoding a few more property types
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496988 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 16:17:00 +00:00
Nick Burch
c5893c8c34
More friendly output of byte arrays for property values in HSMFDump
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496982 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 16:03:09 +00:00
Nick Burch
43886b815b
Fix inconsistent whitespace in HSMF test files
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496969 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 15:28:25 +00:00
Nick Burch
73aa6c507e
Fix inconsistent whitespace in HSMF files
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496962 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 15:23:29 +00:00
Nick Burch
b3e4741320
Convert classes with a assertContains method to using the new POITestCase common parent class, which has it there
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496697 13f79535-47bb-0310-9956-ffa450edef68
2013-06-26 00:49:41 +00:00
Nick Burch
84a00d8d4b
Sanity check the length, logging and truncating if too long, to avoid a StringIndexOutOfBoundsException (bug #54925 )
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496520 13f79535-47bb-0310-9956-ffa450edef68
2013-06-25 15:49:45 +00:00
Nick Burch
456f6171d9
Fix the indenting to be consistent throughout the file
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496519 13f79535-47bb-0310-9956-ffa450edef68
2013-06-25 15:44:36 +00:00
Nick Burch
56d1f1b97a
Add another record type to the "don't warn" list, and tidy up the code a little bit (see bug #54925 )
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496518 13f79535-47bb-0310-9956-ffa450edef68
2013-06-25 15:40:05 +00:00
Yegor Kozlov
09c79ffed4
fixed compatibility issues with JDK 1.5
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1489685 13f79535-47bb-0310-9956-ffa450edef68
2013-06-05 02:03:07 +00:00
Nick Burch
c4f77a02e2
Unit test for bugs #54880 & #55030 - seems ok so far
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1488403 13f79535-47bb-0310-9956-ffa450edef68
2013-05-31 21:17:55 +00:00
Nick Burch
17cb45f1bf
Fix bug #55001 - check for unicode text too (plus fix indents)
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1488329 13f79535-47bb-0310-9956-ffa450edef68
2013-05-31 17:30:29 +00:00
Nick Burch
7c246cb5f0
More on bug #54682 - check for the end offset overflowing too
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1487558 13f79535-47bb-0310-9956-ffa450edef68
2013-05-29 17:31:50 +00:00