Dominik Stadler
0216a881f7
Bug 56017: fix shifting comments with shifted rows and move some more tests into the base classes to run them against XSSF, SXSSF and HSSF
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1666843 13f79535-47bb-0310-9956-ffa450edef68
2015-03-15 20:52:55 +00:00
Dominik Stadler
30d20582af
Bug 56295: Fix cloning of styles across workbooks and handling of default value of attribute applyFill
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1666736 13f79535-47bb-0310-9956-ffa450edef68
2015-03-14 19:32:28 +00:00
Dominik Stadler
7bf9b90fb2
Remove some findbugs warnings about missing close of streams, use existing IOUtils.copy() to copy from one stream to another
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1666683 13f79535-47bb-0310-9956-ffa450edef68
2015-03-14 13:18:43 +00:00
Nick Burch
ff737c5df4
Detect OOXML-strict, and give more helpful exceptions for them
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1666525 13f79535-47bb-0310-9956-ffa450edef68
2015-03-13 17:39:47 +00:00
Nick Burch
48e3a2e56a
Fix inconsistent indents
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1666518 13f79535-47bb-0310-9956-ffa450edef68
2015-03-13 17:17:47 +00:00
Nick Burch
a62be1da0c
More relation types
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1666517 13f79535-47bb-0310-9956-ffa450edef68
2015-03-13 17:17:27 +00:00
Dominik Stadler
b7c14b3a8f
Bug 56467: Fix cloning of sheets with pictures
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1665959 13f79535-47bb-0310-9956-ffa450edef68
2015-03-11 18:24:49 +00:00
Nick Burch
555e42f4de
Give a more helpful exception if a Visio VSDX ooxml file is passed to ExtractorFactory
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1665929 13f79535-47bb-0310-9956-ffa450edef68
2015-03-11 16:17:41 +00:00
Dominik Stadler
e13374683a
Bug 57165: Avoid PartAlreadyExistsException when removing/cloning sheets
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1663153 13f79535-47bb-0310-9956-ffa450edef68
2015-03-01 19:56:56 +00:00
Dominik Stadler
54bbd99ce4
Add missing close and handle theme-pptx in ExtractorFactory. Add creating slide-bitmaps to PPTX integration test.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1663137 13f79535-47bb-0310-9956-ffa450edef68
2015-03-01 17:50:16 +00:00
Nick Burch
3ba7b59afc
Ensure that the core properties are there before saving them, in case they have not yet been lazy-created
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1662971 13f79535-47bb-0310-9956-ffa450edef68
2015-02-28 17:36:19 +00:00
Dominik Stadler
f043c44017
* Verify some more Text-Extraction features as part of integration tests, fix some NullPointerExceptions that showed up now because the event-based extraction does not have a Document available
...
* Also handle a XLSX which does not have row-numbers in the sheet-xml. Excel can read it so it makes sense to also allow to read it in the XSSFSheetXMLHandler
* Remove some Eclipse warnings in test-code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1662691 13f79535-47bb-0310-9956-ffa450edef68
2015-02-27 14:58:41 +00:00
Dominik Stadler
e86ed72c2b
* Add text-extraction verification to integration-tests via a new abstract base FileHandler
...
* Fix NullPointerException found in some documents when running against the test-data
* Add support for extracting text from Dir-Entries WORKBOOK and BOOK to support some old/strangely formatted XLS files.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1662652 13f79535-47bb-0310-9956-ffa450edef68
2015-02-27 09:59:14 +00:00
Dominik Stadler
7dfcd6c684
Adjust tests and fix small typo
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1662650 13f79535-47bb-0310-9956-ffa450edef68
2015-02-27 09:52:57 +00:00
Nick Burch
66afa6d09b
Update Javadocs to refer to the fact that WorkbookFactory.create will throw a EncryptedDocumentException if the file is password protected
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1662074 13f79535-47bb-0310-9956-ffa450edef68
2015-02-24 18:20:02 +00:00
Nick Burch
b6a88f09c8
Patch from rojotek from github-18 - Handle documents with a picture-only header
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1661908 13f79535-47bb-0310-9956-ffa450edef68
2015-02-24 12:09:30 +00:00
Nick Burch
d5065b1742
Change from XMLEventFactory.newFactory to XMLEventFactory.newInstance, for IBM JDK Compatibility, fixes #57622
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1661903 13f79535-47bb-0310-9956-ffa450edef68
2015-02-24 12:03:53 +00:00
Dominik Stadler
ce007f05ee
Bug 57459: Add method in SXSSFSheet to directly set row OutLineLevel
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1659785 13f79535-47bb-0310-9956-ffa450edef68
2015-02-14 12:46:16 +00:00
Nick Burch
25385edc38
XWPF implementation of some common Paragraph methods
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1657717 13f79535-47bb-0310-9956-ffa450edef68
2015-02-05 23:31:59 +00:00
Nick Burch
483982caad
Stub a common WP paragraph class, needs uncommenting as XWPF implements/emulates
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1657712 13f79535-47bb-0310-9956-ffa450edef68
2015-02-05 23:20:43 +00:00
Nick Burch
c526206e0d
More common HWPF/XWPF interfaces
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1657634 13f79535-47bb-0310-9956-ffa450edef68
2015-02-05 17:35:09 +00:00
Nick Burch
1f2fc6c08b
More common XWPF/HWPF character run methods
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1657631 13f79535-47bb-0310-9956-ffa450edef68
2015-02-05 17:25:02 +00:00
Nick Burch
a351b66fde
XWPF double strikethrough, and start on a common interface for HWPF and XWPF character runs
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1657624 13f79535-47bb-0310-9956-ffa450edef68
2015-02-05 17:00:08 +00:00
Nick Burch
b25e4ca87d
57482 Handle XSLX files with no shared strings table in read-only mode
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1653825 13f79535-47bb-0310-9956-ffa450edef68
2015-01-22 12:15:59 +00:00
Dominik Stadler
eab2c0d20d
Add a developer-tool to pretty-print the XMLs in an OOXML file. This makes it easier to compare OOXML files produced by different applications with differeing XML formatting.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1653777 13f79535-47bb-0310-9956-ffa450edef68
2015-01-22 07:24:01 +00:00
Nick Burch
0257c23cae
Have ExtractorFactory open OPCPackages from files in read-only mode by default, since writing should never be needed when extracting text
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1652877 13f79535-47bb-0310-9956-ffa450edef68
2015-01-18 23:46:29 +00:00
Nick Burch
df20c0a69b
For XSSFSheet, add a getDrawingPatriarch() method alongside the existing createDrawingPatriarch() one
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1652876 13f79535-47bb-0310-9956-ffa450edef68
2015-01-18 23:45:04 +00:00
Dominik Stadler
3403bef5a8
Fix Eclipse warnings, provide better error message and adjust javadoc slightly
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1650598 13f79535-47bb-0310-9956-ffa450edef68
2015-01-09 16:52:23 +00:00
Nick Burch
ed8964594b
Swap Exception for Throwable, to skip a wider range of problems (eg GAE) when attempting to set an xml security manager as best we can
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1650290 13f79535-47bb-0310-9956-ffa450edef68
2015-01-08 13:22:50 +00:00
Dominik Stadler
fa8eae2bfd
Move some tests to the base test class where applicapple
...
Introduce class BaseTestXCell to collect tests for XSSFCell and SXSSFCell that do not work for HSSFCell
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649527 13f79535-47bb-0310-9956-ffa450edef68
2015-01-05 14:03:37 +00:00
Dominik Stadler
9794510d33
Improve information in exceptions thrown by XSSFRichTextString and improve unit tests
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649234 13f79535-47bb-0310-9956-ffa450edef68
2015-01-03 19:30:56 +00:00
Dominik Stadler
2f681f430c
Fix copy/paste errors in XSSFSimpleShape, allow unset of insets multiple times and add unit tests
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649233 13f79535-47bb-0310-9956-ffa450edef68
2015-01-03 19:30:36 +00:00
Dominik Stadler
3bbf57cd27
Fix copy/paste error in XSSFTextParagraph and add unit tests
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649232 13f79535-47bb-0310-9956-ffa450edef68
2015-01-03 19:29:51 +00:00
Dominik Stadler
12edcc5ed2
Bug 46192: Add methods to query outline level for HSSF and XSSF
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649107 13f79535-47bb-0310-9956-ffa450edef68
2015-01-02 20:03:28 +00:00
Dominik Stadler
5c76ccba5b
Add missing close() of resources in both production code and tests
...
Use revert() instead of close() on OCPPackage in some places to not re-write the file unnecessarily.
This should now run tests without leftover file handles when checked with file leak detector and
allows to find newly introduced cases more easily.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648160 13f79535-47bb-0310-9956-ffa450edef68
2014-12-28 09:16:57 +00:00
Dominik Stadler
26585f4e95
Ensure that XSSFWorkbooks contain a BookView, some corrupt ones do not contain this, e.g. ones created by movescound.com
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648158 13f79535-47bb-0310-9956-ffa450edef68
2014-12-28 09:08:58 +00:00
Dominik Stadler
5173eca9ea
Fix Eclipse warnings, unnecessary casts, use generics, static access...
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648156 13f79535-47bb-0310-9956-ffa450edef68
2014-12-28 09:06:12 +00:00
Andreas Beeker
4bed984c0f
Charset.forName() for known encodings makes catching UnknownEncodingException obsolete
...
Unify UTF-16LE conversion to StringUtil
BugFix for RecordInputStream.readFully in combination with continuing records
BugFix for integration tests - fix pathname for handler/exclude lookup on windows
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648032 13f79535-47bb-0310-9956-ffa450edef68
2014-12-27 01:33:28 +00:00
Andreas Beeker
202aa8177f
- Support for Office Binary Document RC4 CryptoAPI Encryption for HSLF
...
- Support for Office Binary Document RC4 Encryption
- use LittleEndian class in LittleEndianInputStream
- add normalize method for HSLF, to remove edit history, which is also necessary for encryption support
- update PersistDirectoryEntry handling in PersistPtrHolder to recognize groups while serializing
- deprecated PersistPtrHolder.getSlideOffsetDataLocationsLookup() - throws now UnsupportedOperationException,
as this wasn't used outside the scope of the class and was quite internal logic of PersistPtrHolder
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647867 13f79535-47bb-0310-9956-ffa450edef68
2014-12-25 01:56:29 +00:00
Dominik Stadler
ed60f5cb08
Add comment
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647512 13f79535-47bb-0310-9956-ffa450edef68
2014-12-23 09:26:22 +00:00
Dominik Stadler
7ee9ce8388
Fix two Eclipse warnings
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647325 13f79535-47bb-0310-9956-ffa450edef68
2014-12-22 14:56:47 +00:00
Dominik Stadler
83f5683c50
Bug 57373: Fix get/setFirstVisibleTab() for XSSFWorkbook
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647322 13f79535-47bb-0310-9956-ffa450edef68
2014-12-22 14:37:37 +00:00
Dominik Stadler
1db7f3bd3b
Bug 57362: Properly initialize chart axis when loading a workbook which already contains a chart.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647317 13f79535-47bb-0310-9956-ffa450edef68
2014-12-22 14:16:23 +00:00
Dominik Stadler
f622530806
Remove iterating over the number of runs for certain XSSFRichTextString operations. If I didn't overlook something, they can directly access the array element anyway. Seems this was some leftover copy/paste stuff.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647315 13f79535-47bb-0310-9956-ffa450edef68
2014-12-22 14:09:55 +00:00
Dominik Stadler
03f846c695
Bug 56511: Add a null-check to ensure that the run actually has a font to not cause a NullPointerException but rather return null as documented
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647308 13f79535-47bb-0310-9956-ffa450edef68
2014-12-22 13:06:58 +00:00
Dominik Stadler
645d2083bf
Bug 56550: Defer the initialization of the _classes to when it is actually needed to allow IBM JDK to at least load the class
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647302 13f79535-47bb-0310-9956-ffa450edef68
2014-12-22 12:38:44 +00:00
Dominik Stadler
0b6867d1d5
Bug 56644: Fix adding cells if MissingCellPolicy is set to NULL_FOR_BLANK and the last column in a row is empty
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647291 13f79535-47bb-0310-9956-ffa450edef68
2014-12-22 11:11:34 +00:00
Dominik Stadler
181de5f6e5
Bug 56888: XSSFDataValidation ignores "allow blank" read from sheet, assumes true
...
Add TestSXSSFDataValidation to verify some parts for SXSSF as well
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647276 13f79535-47bb-0310-9956-ffa450edef68
2014-12-22 10:03:32 +00:00
Dominik Stadler
0fdfac62c9
Bug 57171 and 57163: Adjust the active sheet in setSheetOrder() and removeSheet() for both HSSF and XSSF
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647264 13f79535-47bb-0310-9956-ffa450edef68
2014-12-22 09:00:18 +00:00
Dominik Stadler
213aa1559b
Adjust typos in Javadoc
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647210 13f79535-47bb-0310-9956-ffa450edef68
2014-12-21 21:07:06 +00:00