Dominik Stadler
001cdeb936
Apply fix reported in bug 47661 and add unit tests
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1680642 13f79535-47bb-0310-9956-ffa450edef68
2015-05-20 18:00:19 +00:00
Dominik Stadler
589b189151
Prevent problems reported in Bug 56574 by ensuring that Cells are properly removed when a row is overwritten by calling createRow() with it's rownum.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1680280 13f79535-47bb-0310-9956-ffa450edef68
2015-05-19 13:13:09 +00:00
Dominik Stadler
cbd315d441
Adjust error message to have the same error across different types of Workbook and revert test to check on common error message again
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678874 13f79535-47bb-0310-9956-ffa450edef68
2015-05-12 06:27:11 +00:00
Dominik Stadler
c4a26a18f4
Fix unit test which asserts on actual error message
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678861 13f79535-47bb-0310-9956-ffa450edef68
2015-05-12 04:54:47 +00:00
Dominik Stadler
142e4a9f92
Avoid possible NPE found via CommonCrawl files
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678811 13f79535-47bb-0310-9956-ffa450edef68
2015-05-11 20:00:18 +00:00
Nick Burch
dd8fc66a0c
#56791 More updates from OPOIFS to NPOIFS
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678801 13f79535-47bb-0310-9956-ffa450edef68
2015-05-11 18:59:10 +00:00
Nick Burch
aec457dbcb
#56791 More updates from OPOIFS to NPOIFS
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678787 13f79535-47bb-0310-9956-ffa450edef68
2015-05-11 18:15:03 +00:00
Nick Burch
a89a9d673a
#56791 More updates from OPOIFS to NPOIFS
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678783 13f79535-47bb-0310-9956-ffa450edef68
2015-05-11 18:04:30 +00:00
Nick Burch
bd6012d9b9
Add a deep re-write NPOIFS test
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678781 13f79535-47bb-0310-9956-ffa450edef68
2015-05-11 18:00:45 +00:00
Nick Burch
1945dfc00c
Correct zero byte entry support in NPOIFS
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678778 13f79535-47bb-0310-9956-ffa450edef68
2015-05-11 17:53:59 +00:00
Nick Burch
0d95d3df70
Disabled NPOIFS unit test - problem with 0 length entries discovered working on #56791
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678769 13f79535-47bb-0310-9956-ffa450edef68
2015-05-11 15:27:59 +00:00
Nick Burch
794e2b95fa
More NPOIFS ministore tests
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678767 13f79535-47bb-0310-9956-ffa450edef68
2015-05-11 15:20:42 +00:00
Nick Burch
89890a247a
Add a (disabled) failing unit test on heavily nested NPOIFS copies, found working on #56791
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678764 13f79535-47bb-0310-9956-ffa450edef68
2015-05-11 14:58:43 +00:00
Nick Burch
d46e76b8a1
Add missing license header
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1675750 13f79535-47bb-0310-9956-ffa450edef68
2015-04-24 02:24:36 +00:00
Nick Burch
5516228367
Patch from Conor from bug #57747 - Add ISERR() function
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1675741 13f79535-47bb-0310-9956-ffa450edef68
2015-04-24 01:47:20 +00:00
Nick Burch
20fa446f40
#57851 - Skip null properties in PropertyTableBase, which is how PropertyFactory reports unsupported POIFS properties
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1675702 13f79535-47bb-0310-9956-ffa450edef68
2015-04-23 18:35:15 +00:00
Nick Burch
22fa817fcc
Make the opening code generic
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1675700 13f79535-47bb-0310-9956-ffa450edef68
2015-04-23 18:26:01 +00:00
Nick Burch
d540ba43cc
Make the test generic across POIFS and NPOIFS
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1675698 13f79535-47bb-0310-9956-ffa450edef68
2015-04-23 18:20:27 +00:00
Nick Burch
f8977f76d0
Pull out a common NPOIFS/POIFS test to a decidated bugs test class
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1675696 13f79535-47bb-0310-9956-ffa450edef68
2015-04-23 18:16:37 +00:00
Nick Burch
3eb0a69666
Fix inconsistent indents
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1675690 13f79535-47bb-0310-9956-ffa450edef68
2015-04-23 18:02:38 +00:00
Nick Burch
bcf825883a
Add unit test for Eventmodel processing of password protected excel files
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1675689 13f79535-47bb-0310-9956-ffa450edef68
2015-04-23 18:01:51 +00:00
Dominik Stadler
acfc276396
Fix usage of Generics in some classes
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1674964 13f79535-47bb-0310-9956-ffa450edef68
2015-04-20 19:15:21 +00:00
Dominik Stadler
12c220121e
Bug 57163: Fix possible NullPointerException when a spreadsheet has no LinkTable and we try to adjust it during sheet removal.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1673168 13f79535-47bb-0310-9956-ffa450edef68
2015-04-13 12:19:11 +00:00
Dominik Stadler
570819e4f6
Bug 56579: Throw exception if max string length of 32767 chars is exceeded in XSSF and SXSSF.
...
Add verification testcase for bug 57008.
Move some unit tests to the Bsae-Test-Class to verify things for all SS-implementations.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1671096 13f79535-47bb-0310-9956-ffa450edef68
2015-04-03 15:55:21 +00:00
Dominik Stadler
7567838f9b
Add test from bug 49423 to verify that the problem was fixed in the meantime
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1668481 13f79535-47bb-0310-9956-ffa450edef68
2015-03-22 21:45:56 +00:00
Dominik Stadler
0216a881f7
Bug 56017: fix shifting comments with shifted rows and move some more tests into the base classes to run them against XSSF, SXSSF and HSSF
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1666843 13f79535-47bb-0310-9956-ffa450edef68
2015-03-15 20:52:55 +00:00
Dominik Stadler
1849741d43
Add second verification of bug 56325 to ensure it is really fixed
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1666718 13f79535-47bb-0310-9956-ffa450edef68
2015-03-14 17:50:55 +00:00
Dominik Stadler
e369d1c121
Bug 56380: Remove limitation of 1024 comments per Workbook
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1666505 13f79535-47bb-0310-9956-ffa450edef68
2015-03-13 16:26:41 +00:00
Dominik Stadler
c1a77cab75
Remove unused import
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1665956 13f79535-47bb-0310-9956-ffa450edef68
2015-03-11 18:23:47 +00:00
Dominik Stadler
0e16d14349
Move test-case to location where the scratchpad-classes are available
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1662712 13f79535-47bb-0310-9956-ffa450edef68
2015-02-27 15:01:46 +00:00
Dominik Stadler
f043c44017
* Verify some more Text-Extraction features as part of integration tests, fix some NullPointerExceptions that showed up now because the event-based extraction does not have a Document available
...
* Also handle a XLSX which does not have row-numbers in the sheet-xml. Excel can read it so it makes sense to also allow to read it in the XSSFSheetXMLHandler
* Remove some Eclipse warnings in test-code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1662691 13f79535-47bb-0310-9956-ffa450edef68
2015-02-27 14:58:41 +00:00
Dominik Stadler
7dfcd6c684
Adjust tests and fix small typo
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1662650 13f79535-47bb-0310-9956-ffa450edef68
2015-02-27 09:52:57 +00:00
Dominik Stadler
e7615fdd34
Bug 57456: Fix reading XLS with empty SSTRecord where Excel puts some random number in unique-strings-count-field
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1659650 13f79535-47bb-0310-9956-ffa450edef68
2015-02-13 19:14:14 +00:00
Nick Burch
9ccc610f6a
Fix TIKA-1515 - Handle Excel 3 files with a 0x8001 codepage
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1651517 13f79535-47bb-0310-9956-ffa450edef68
2015-01-13 22:13:24 +00:00
Nick Burch
9866864ccf
Add a sample Excel 3 file from TIKA-1515, and a disabled unit test for it
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1651451 13f79535-47bb-0310-9956-ffa450edef68
2015-01-13 19:32:50 +00:00
Dominik Stadler
113edb1a76
Adjust Bin2Dec similar to what we did for Hex2Dec in Bug 57196 and fix some smaller problems in the implementation found while adding full unit tests
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1650654 13f79535-47bb-0310-9956-ffa450edef68
2015-01-09 20:37:11 +00:00
Dominik Stadler
3403bef5a8
Fix Eclipse warnings, provide better error message and adjust javadoc slightly
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1650598 13f79535-47bb-0310-9956-ffa450edef68
2015-01-09 16:52:23 +00:00
Dominik Stadler
c8bf92f963
Bug 57196: Resolve RefEval to it's inner ValueEval in Hex2Dec
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1650597 13f79535-47bb-0310-9956-ffa450edef68
2015-01-09 16:51:02 +00:00
Dominik Stadler
8997d8900d
* Add missing close() on streams in ImageUtils.getImageDimension()
...
* Add some unit tests for CellReference
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1650070 13f79535-47bb-0310-9956-ffa450edef68
2015-01-07 14:36:39 +00:00
Dominik Stadler
c15f7bc929
Add reproducer for bug 57074
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1650059 13f79535-47bb-0310-9956-ffa450edef68
2015-01-07 14:13:34 +00:00
Dominik Stadler
fa8eae2bfd
Move some tests to the base test class where applicapple
...
Introduce class BaseTestXCell to collect tests for XSSFCell and SXSSFCell that do not work for HSSFCell
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649527 13f79535-47bb-0310-9956-ffa450edef68
2015-01-05 14:03:37 +00:00
Dominik Stadler
be0d5df4b7
Add missing license header
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649151 13f79535-47bb-0310-9956-ffa450edef68
2015-01-02 22:49:37 +00:00
Dominik Stadler
302db39cb7
Fix some Eclipse warnings
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649123 13f79535-47bb-0310-9956-ffa450edef68
2015-01-02 21:06:51 +00:00
Dominik Stadler
ffcc20f60e
Bug 46898: Convert unit tests for circular references to also run for XSSF
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649122 13f79535-47bb-0310-9956-ffa450edef68
2015-01-02 21:04:50 +00:00
Dominik Stadler
a0248ff4f0
Bug 57007: Add initial implementations of DMIN and DGET functions
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648166 13f79535-47bb-0310-9956-ffa450edef68
2014-12-28 10:47:41 +00:00
Dominik Stadler
5c76ccba5b
Add missing close() of resources in both production code and tests
...
Use revert() instead of close() on OCPPackage in some places to not re-write the file unnecessarily.
This should now run tests without leftover file handles when checked with file leak detector and
allows to find newly introduced cases more easily.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648160 13f79535-47bb-0310-9956-ffa450edef68
2014-12-28 09:16:57 +00:00
Dominik Stadler
5173eca9ea
Fix Eclipse warnings, unnecessary casts, use generics, static access...
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648156 13f79535-47bb-0310-9956-ffa450edef68
2014-12-28 09:06:12 +00:00
Andreas Beeker
4bed984c0f
Charset.forName() for known encodings makes catching UnknownEncodingException obsolete
...
Unify UTF-16LE conversion to StringUtil
BugFix for RecordInputStream.readFully in combination with continuing records
BugFix for integration tests - fix pathname for handler/exclude lookup on windows
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648032 13f79535-47bb-0310-9956-ffa450edef68
2014-12-27 01:33:28 +00:00
Dominik Stadler
0c580c8f45
Add a test-suite which performs integration/stress tests which load and handle all stored test files in various ways.
...
It works by using handlers for each type of file which perform various operations on the files, e.g. loading,
iterating content, modify, ... This will trigger changes which break working with the available test-files and
thus provides another layer of regression testing which hopefully prevents some failures from making it into
releases.
It is runnable via a new ant-target 'test-integration' and also added to the jenkins-target.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647885 13f79535-47bb-0310-9956-ffa450edef68
2014-12-25 09:16:44 +00:00
Dominik Stadler
a7ba500280
Bug 56595: Also switch the cache in DateUtil.isADateFormat() to ThreadLocals to not have another syncpoint here. Again only very little data is kept, so no memory bloat should happen because of this.
...
Also do more simple checks before actually looking at the cache
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647296 13f79535-47bb-0310-9956-ffa450edef68
2014-12-22 12:08:59 +00:00