Commit Graph

41 Commits

Author SHA1 Message Date
Dominik Stadler
77614b8c49 Test for another type of xml-bomb
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790473 13f79535-47bb-0310-9956-ffa450edef68
2017-04-06 21:50:03 +00:00
Tim Allison
b52126f7f3 60826 -- clean up. Many, many thanks to Javen O'Neal's code review!
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787320 13f79535-47bb-0310-9956-ffa450edef68
2017-03-17 10:09:59 +00:00
Tim Allison
730f394261 60826 -- add initial support for streaming reading of xlsb files.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787228 13f79535-47bb-0310-9956-ffa450edef68
2017-03-16 18:37:13 +00:00
Dominik Stadler
f2c9dbec3f Add some missing close() calls
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765875 13f79535-47bb-0310-9956-ffa450edef68
2016-10-20 20:31:50 +00:00
Javen O'Neal
8455e01772 add comment for purpose of test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761842 13f79535-47bb-0310-9956-ffa450edef68
2016-09-22 03:37:09 +00:00
Javen O'Neal
a09fe683dd bug 45565: add failing unit test for bug 45565
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761841 13f79535-47bb-0310-9956-ffa450edef68
2016-09-22 03:29:00 +00:00
Javen O'Neal
ed5cd06fb7 bug 60128: close open file descriptors when exceptions are thrown from OPCPackage.open
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760702 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 12:57:39 +00:00
Nick Burch
7179c813e6 Start moving logic over into the main and scratchpad jars for OLE2
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752226 13f79535-47bb-0310-9956-ffa450edef68
2016-07-11 22:47:02 +00:00
Javen O'Neal
fba65665fb reorganize imports (remove unused imports, sort alphabetically)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751244 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 10:38:25 +00:00
Andreas Beeker
f8767e3981 some zips can't be opened via ZipFile in JDK6, as the central directory
contains either non-latin entries or the compression type can't be handled
the workaround is to iterate over the stream and not the directory


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736933 13f79535-47bb-0310-9956-ffa450edef68
2016-03-28 22:49:45 +00:00
Dominik Stadler
d806c2ac2b Check for null in IOUtils.closeQuietly() to not log this unnecessarily
Add coverage for some  more methods in ExtractorFactory
Fix some IntelliJ warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736146 13f79535-47bb-0310-9956-ffa450edef68
2016-03-22 07:51:39 +00:00
Nick Burch
62b5b0d874 #59074 More helpful exception if Excel 1-95 files are given to ExtractorFactory
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732587 13f79535-47bb-0310-9956-ffa450edef68
2016-02-26 23:56:31 +00:00
Nick Burch
0b8283b37c Refactor to pull out the list of Excel 97+ directory entry names to a common place, avoiding duplication. Also starts on unit testing #59074
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732579 13f79535-47bb-0310-9956-ffa450edef68
2016-02-26 23:32:17 +00:00
Dominik Stadler
0f10be0ca4 One more possible resource leak when creating the TextExtractor fails with a RuntimeException or one of the named exceptions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731561 13f79535-47bb-0310-9956-ffa450edef68
2016-02-21 20:42:05 +00:00
Dominik Stadler
902830cf14 Adjust test for extracting some more
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722411 13f79535-47bb-0310-9956-ffa450edef68
2015-12-30 20:31:50 +00:00
Dominik Stadler
b69c64fe21 Handle some cases better where file handles were left open by the ExtractorFactory, mostly when opening files failed, but also when using the NPOIFSFileSystem for initialization.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721064 13f79535-47bb-0310-9956-ffa450edef68
2015-12-20 20:39:01 +00:00
Dustin Spicuzza
e0a5e102b8 Add Visio OOXML text extractor + tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709361 13f79535-47bb-0310-9956-ffa450edef68
2015-10-19 06:26:57 +00:00
Andreas Beeker
2de9d527b4 sonar fixes
Very interesting was the exception swallowing in PackagePropertiesPart. When it was properly thrown, it already led to various errors in the junits test - I've fixed the handling for at least the ones which are in our test set

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706169 13f79535-47bb-0310-9956-ffa450edef68
2015-09-30 23:06:39 +00:00
Nick Burch
ff737c5df4 Detect OOXML-strict, and give more helpful exceptions for them
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1666525 13f79535-47bb-0310-9956-ffa450edef68
2015-03-13 17:39:47 +00:00
Nick Burch
ace2354d6c Stub unit tests for #57699
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1666510 13f79535-47bb-0310-9956-ffa450edef68
2015-03-13 16:46:15 +00:00
Nick Burch
c5ea89b2bc Fix inconsistent indents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1665933 13f79535-47bb-0310-9956-ffa450edef68
2015-03-11 16:30:02 +00:00
Nick Burch
555e42f4de Give a more helpful exception if a Visio VSDX ooxml file is passed to ExtractorFactory
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1665929 13f79535-47bb-0310-9956-ffa450edef68
2015-03-11 16:17:41 +00:00
Dominik Stadler
5c76ccba5b Add missing close() of resources in both production code and tests
Use revert() instead of close() on OCPPackage in some places to not re-write the file unnecessarily.
This should now run tests without leftover file handles when checked with file leak detector and
allows to find newly introduced cases more easily.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648160 13f79535-47bb-0310-9956-ffa450edef68
2014-12-28 09:16:57 +00:00
Dominik Stadler
382be9f312 Adjust TestExtractorFactory to provide more output to see why it fails on Maven builds on nemo.sonarsource.org
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575497 13f79535-47bb-0310-9956-ffa450edef68
2014-03-08 08:22:03 +00:00
Nick Burch
f751e3cdd3 Inside ExtractorFactory, support finding embedded OOXML documents and providing extractors for them
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1049802 13f79535-47bb-0310-9956-ffa450edef68
2010-12-16 07:39:21 +00:00
Nick Burch
8dcf35452d Support nested outlook files in ExtractorFactory
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@982334 13f79535-47bb-0310-9956-ffa450edef68
2010-08-04 17:22:15 +00:00
Nick Burch
6ee6d9095f Enable Word6Extractor in ExtractorFactory
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@959360 13f79535-47bb-0310-9956-ffa450edef68
2010-06-30 16:08:10 +00:00
Nick Burch
a2e6cafca9 New event based xssf text extractor (XSSFEventBasedExcelExtractor)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@903182 13f79535-47bb-0310-9956-ffa450edef68
2010-01-26 11:39:44 +00:00
Nick Burch
6e2c32e1c5 Most of support suggested by Phil Varner on the list - ExtractorFactory can now be told to prefer Event Based extractors (current Excel only) on a per-thread or overall basis
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@902927 13f79535-47bb-0310-9956-ffa450edef68
2010-01-25 19:02:13 +00:00
Nick Burch
6e97a360a3 Add PublisherTextExtractor support to ExtractorFactory
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@897887 13f79535-47bb-0310-9956-ffa450edef68
2010-01-11 14:55:43 +00:00
Nick Burch
5ad8301c2a Add embeded (attachment) support to the outlook text extractor
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@897258 13f79535-47bb-0310-9956-ffa450edef68
2010-01-08 16:44:08 +00:00
Nick Burch
98cea49eb5 Rename the outlook extractor to be more consistent with other extractors
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@897249 13f79535-47bb-0310-9956-ffa450edef68
2010-01-08 16:18:52 +00:00
Nick Burch
cefe4e1d28 Wire up the new HSMFTextExtactor to the ExtractorFactory
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@897246 13f79535-47bb-0310-9956-ffa450edef68
2010-01-08 16:14:27 +00:00
Yegor Kozlov
0b9ab8930e included poi-ooxml-schemas and poi-examples in the release cycle, also misc improvements in build.xml: merged scratchpad and main examples, improved cross-module classpath dependencies, removed obsolete targets
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@882927 13f79535-47bb-0310-9956-ffa450edef68
2009-11-21 15:30:54 +00:00
Yegor Kozlov
728f88bd92 moved all test data to a top-level directory, refactored all junit usages of .testdata.path to one place
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@806959 13f79535-47bb-0310-9956-ffa450edef68
2009-08-23 12:34:24 +00:00
Yegor Kozlov
3304fa1887 Fixed ExtractorFactory to support .xltx and .dotx files, see Bugzilla 47517
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@795327 13f79535-47bb-0310-9956-ffa450edef68
2009-07-18 09:09:11 +00:00
Josh Micich
67196db87e Renamed Package (in org.apache.poi.openxml4j.opc) to OPCPackage so as to avoid clash with java.lang.Package (see bugzilla 46859)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@755699 13f79535-47bb-0310-9956-ffa450edef68
2009-03-18 18:54:01 +00:00
Yegor Kozlov
ef4b2ebc2e import OpenXML4j codebase
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@738842 13f79535-47bb-0310-9956-ffa450edef68
2009-01-29 12:44:31 +00:00
Yegor Kozlov
7c6cfb0360 fixed unit test failing on jdk-1.6: java code should not rely on the order of HashMap.iterator()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@734971 13f79535-47bb-0310-9956-ffa450edef68
2009-01-16 11:00:45 +00:00
Nick Burch
6c3a086277 Initial ExtractorFactory support for building TextExtractors for embeded documents
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ooxml@691351 13f79535-47bb-0310-9956-ffa450edef68
2008-09-02 19:37:52 +00:00
Nick Burch
7aa73d82dc Shuffle the common text extractor stuff from scratchpad to ooxml, to match the compile paths
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ooxml@646239 13f79535-47bb-0310-9956-ffa450edef68
2008-04-09 09:20:20 +00:00