From fce60a6630f7fbbc610ae49d0114c44d040928e0 Mon Sep 17 00:00:00 2001
From: Nick Burch <nick@apache.org>
Date: Thu, 20 Mar 2008 10:06:59 +0000
Subject: [PATCH] Test relating to bug #44636

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@639231 13f79535-47bb-0310-9956-ffa450edef68
---
 .../hssf/usermodel/HSSFFormulaEvaluator.java  |  30 ++++++
 .../usermodel/TestFormulaEvaluatorBugs.java   |  88 ++++++++++++++++++
 .../org/apache/poi/hssf/data/44636.xls        | Bin 0 -> 13824 bytes
 3 files changed, 118 insertions(+)
 create mode 100644 src/scratchpad/testcases/org/apache/poi/hssf/usermodel/TestFormulaEvaluatorBugs.java
 create mode 100644 src/testcases/org/apache/poi/hssf/data/44636.xls

diff --git a/src/scratchpad/src/org/apache/poi/hssf/usermodel/HSSFFormulaEvaluator.java b/src/scratchpad/src/org/apache/poi/hssf/usermodel/HSSFFormulaEvaluator.java
index 58ab5b47a..bb16fdfad 100644
--- a/src/scratchpad/src/org/apache/poi/hssf/usermodel/HSSFFormulaEvaluator.java
+++ b/src/scratchpad/src/org/apache/poi/hssf/usermodel/HSSFFormulaEvaluator.java
@@ -19,6 +19,7 @@ package org.apache.poi.hssf.usermodel;
 
 import java.lang.reflect.Constructor;
 import java.util.HashMap;
+import java.util.Iterator;
 import java.util.Map;
 import java.util.Stack;
 
@@ -251,6 +252,35 @@ public class HSSFFormulaEvaluator {
         }
         return cell;
     }
+    
+    /**
+     * Loops over all cells in all sheets of the supplied
+     *  workbook.
+     * For cells that contain formulas, their formulas are
+     *  evaluated, and the results are saved. These cells
+     *  remain as formula cells.
+     * For cells that do not contain formulas, no changes
+     *  are made.
+     * This is a helpful wrapper around looping over all 
+     *  cells, and calling evaluateFormulaCell on each one.
+     */
+	public static void evaluateAllFormulaCells(HSSFWorkbook wb) {
+		for(int i=0; i<wb.getNumberOfSheets(); i++) {
+			HSSFSheet sheet = wb.getSheetAt(i);
+			HSSFFormulaEvaluator evaluator = new HSSFFormulaEvaluator(sheet, wb);
+
+			for (Iterator rit = sheet.rowIterator(); rit.hasNext();) {
+				HSSFRow r = (HSSFRow)rit.next();
+				evaluator.setCurrentRow(r);
+
+				for (Iterator cit = r.cellIterator(); cit.hasNext();) {
+					HSSFCell c = (HSSFCell)cit.next();
+					if (c.getCellType() == HSSFCell.CELL_TYPE_FORMULA)
+						evaluator.evaluateFormulaCell(c);
+				}
+			}
+		}
+	}
         
     
     /**
diff --git a/src/scratchpad/testcases/org/apache/poi/hssf/usermodel/TestFormulaEvaluatorBugs.java b/src/scratchpad/testcases/org/apache/poi/hssf/usermodel/TestFormulaEvaluatorBugs.java
new file mode 100644
index 000000000..bcb7e3737
--- /dev/null
+++ b/src/scratchpad/testcases/org/apache/poi/hssf/usermodel/TestFormulaEvaluatorBugs.java
@@ -0,0 +1,88 @@
+/* ====================================================================
+   Licensed to the Apache Software Foundation (ASF) under one or more
+   contributor license agreements.  See the NOTICE file distributed with
+   this work for additional information regarding copyright ownership.
+   The ASF licenses this file to You under the Apache License, Version 2.0
+   (the "License"); you may not use this file except in compliance with
+   the License.  You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific language governing permissions and
+   limitations under the License.
+==================================================================== */
+package org.apache.poi.hssf.usermodel;
+
+import java.io.File;
+import java.io.FileInputStream;
+import java.io.FileOutputStream;
+import java.util.Iterator;
+
+import junit.framework.TestCase;
+
+public final class TestFormulaEvaluatorBugs extends TestCase {
+	private String dirName;
+	private String tmpDirName;
+
+	protected void setUp() throws Exception {
+		super.setUp();
+		dirName = System.getProperty("HSSF.testdata.path");
+		tmpDirName = System.getProperty("java.io.tmpdir");
+	}
+	
+	/**
+	 * An odd problem with evaluateFormulaCell giving the
+	 *  right values when file is opened, but changes
+	 *  to the source data in some versions of excel 
+	 *  doesn't cause them to be updated. However, other
+	 *  versions of excel, and gnumeric, work just fine
+	 * WARNING - tedious bug where you actually have to
+	 *  open up excel
+	 */
+	public void test44636() throws Exception {
+		// Open the existing file, tweak one value and
+		//  re-calculate
+		FileInputStream in = new FileInputStream(new File(dirName,"44636.xls"));
+		HSSFWorkbook wb = new HSSFWorkbook(in);
+		HSSFSheet sheet = wb.getSheetAt (0);
+		HSSFRow row = sheet.getRow (0);
+		
+		row.getCell((short)0).setCellValue(4.2);
+		row.getCell((short)2).setCellValue(25);
+		
+		HSSFFormulaEvaluator.evaluateAllFormulaCells(wb);
+		assertEquals(4.2*25, row.getCell((short)3).getNumericCellValue());
+		
+		// Save
+		File existing = new File(tmpDirName,"44636-existing.xls");
+		FileOutputStream out = new FileOutputStream(existing);
+		wb.write(out);
+		out.close();
+		System.err.println("Existing file for bug #44636 written to " + existing.toString());
+		
+		
+		// Now, do a new file from scratch
+		wb = new HSSFWorkbook();
+		sheet = wb.createSheet();
+		
+		row = sheet.createRow(0);
+		row.createCell((short)0).setCellValue(1.2);
+		row.createCell((short)1).setCellValue(4.2);
+		
+		row = sheet.createRow(1);
+		row.createCell((short)0).setCellFormula("SUM(A1:B1)");
+		
+		HSSFFormulaEvaluator.evaluateAllFormulaCells(wb);
+		assertEquals(5.4, row.getCell((short)0).getNumericCellValue());
+				
+		// Save
+		File scratch = new File(tmpDirName,"44636-scratch.xls");
+		out = new FileOutputStream(scratch);
+		wb.write(out);
+		out.close();
+		System.err.println("New file for bug #44636 written to " + scratch.toString());
+	}
+}
diff --git a/src/testcases/org/apache/poi/hssf/data/44636.xls b/src/testcases/org/apache/poi/hssf/data/44636.xls
new file mode 100644
index 0000000000000000000000000000000000000000..3108a620b26d84ead86dd54e6836e45b30f97e4c
GIT binary patch
literal 13824
zcmeHOYiv|S6#ni$%JxCKEwH?s%YvaV$fAi5NZCb&h!G_a1Y=EG+9hCHirbQ4qH$4b
zFo6Wc1b>hq5fwwCs0r``$ddR2jl@?75&sn9KY#d$L`k6Qch240?vqp#jE|YknYnZ3
z%sFSinS1AP?|$)l?eNhLW?VyFSPm~n(&Z@2;#<6)?&gDFc{(jwH=V|7vP}3FAy6J*
zN0#|fZC{%3Ns5<V;2JzQ>AS!f_>R<u9hd+-)f4aSjVJ8CCETYzbXwv=iUY5eR~8PF
zTg@>j+&YaXY5cy*oz=LNCBOn4dT38%39rC<n>;a<+plq0<7&nhPHUa3%2|XNxJdc*
z^9N+81HFE01rpeXPW0l=mDc-a!H=mxcwTsJ%iOt<_Qqvx4Q{5bvEDa__u;IZ@+a2C
zyPwPz3bT`Dj|nY|<mzEwRLw^K;e4q)Z5h$UXu{n<ySUP1yPjpTZ4Jt3Yh0FLgcpSA
zcY8yuomLj2kv~?=uGeH|S8B3zYDCe3rMbqO7UbGf*Ro7Tqhm(zMKgP8%&1#`)UI1u
zO=s7<AIGq~z_<cfU|wJ>;Xozck_Tplb|R5_-%7lVSP`w#FGbXr)*Hk-sLbiJVNBK$
zdOdAx>O?79_%e2t|EpVcd%oOE#pFxzMQbtn|1#f#EzQdW7tdw~hu`!0jV1UkCHPGx
z_~k|UVom+&$hX^qIhG9+@S9;3<-?KhMkcuJYH{QX_!;@$G5LcYAA(75TGHBNnWl9~
zpQe+N6EsB<nodso(;fP_9pXd$Q(ak<Vg1&4d~ne|_}C^37pwq@L;bvkn|xBaA<YML
z09}D8B$o$F$y|CWc;U=s!JL__(&OAFBF7mFFEM(I!V~q`U&Xi^HF{mk7zonH&3AwP
zYR%@g(RSrGDZg3c7nGCCa_cTOoAU*Bv*dzLY>7)Rs`MU>kIKWA64E$}jdWcGhNCQC
z7>?R)8z>vVbEr~IUogbHPxDgi+p4L2tT=g(XssU0d$~?~wK_Cf?xWo5s<FJEV`W~s
zSf!_)YSk}DfHMvd@No9mYhB1uwnlmE0hZ_T1fP5!7YhYEK_p*JY~}N$|Fe1LAnQk2
zVQzc9b_Hic{1lZKF%MfelNVlu@N{d%l{be@#RB-u^V=;y(INXRCs0x5^`fi}4-@ZH
z9pjNy8RJ_izvU5QK2GmqL>d=D-}dQ6j96-9-I@BK6RT1*Lhb2{5m6#N=qM31LR=Fa
zj}?0AQ6&^$`57vq(rhKtwbRrSfiHyJ*F!}-k&X@F9tmCNsDw(hm3T*$2;Lz~PfjeN
z#HUJ*?P#soc<n<fq0($6GFTi>q=Q1(-%(dY32|i^A^G9Uq0>}Cr6XCG_{o@o^Qd4i
zd8uw1^H;bA+eC<VA&!-!zvZ4foYLDqMsseM%{x$lV33|kN0I)Ks({5Lxv@<!2p9wm
z0tSIQfWQbRdCrdon&nYEJapuj8;@=co_HmI=J_9e6Cv+7N!AZi9wW)@^B_s4$_|q3
zy?2mgC9{__k@OmA66p<+So)ro>Y2*g<MIBT346l;j};#2?29{m(Um!D7?oSItt-(#
z(7$ESUb(9)-mA8gOCu*&@4aZnD4(qVIz0UHMJqFtkYj>Dz#w1{FbEg~3<3rLgMdN6
zAYc$M2p9wm0xkl#+y8qmU%GsF;mqK{L)`zj+;~s+{~wdeNwWW6OR6DlBFQOuH;Jz)
z`L5jA+Yd68egCs0o|R({NzMcIk>q^f2r2tKfX4zFWDj36zfyGxLv%{WPwRPrAb!Ys
zg!38+Rb+`uIbIO)js1z90eQnTpl8e?ZGu6-AYc$M2p9wm0tNwtfI+|@U=T0}7zF-*
z2*{3DHq5f;mi@PU2qqt2$(~yN*CBg-`3Ork)3Rrm{kwccDEodXuVpIl{AHi-e*Y+Y
zeK`-1@>?WHP55UbunztF4Z`MEdfS;M@C<uy{2|1zN8FalII;s011XKM%1NAf?bRs<
z<Qokc4=#TrttZff&FV*w%N}>ie}RnJ7eB^bkq1Q*{8*2j=;N<b+rFA8Y*C+tGsypb
u^pjIMG|;}>LvsI&*S>t;q94C7@#6tn=u#iz+5>;ipCx~x{o3?Q`~Lv&QFZhH

literal 0
HcmV?d00001